)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"267a21b70c65ce4d02f535abba18c9d8d222bb3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c4c9bafd_2afb8243","updated":"2023-04-12 16:56:47.000000000","message":"This makes sense to me.  I put up a child patch that removes paramiko from the testenv and runs the unit tests just to see what happens, but it\u0027s probably not very useful.","commit_id":"69497b151ee35aa626be6ddccb40742528241d45"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"ac0403befa9f1acdf5b533a81c643d57483b3607","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dc5c31aa_fd7486a5","updated":"2023-04-13 14:13:56.000000000","message":"You know guys, I don\u0027t like that we aren\u0027t adjusting drivers that bypass ssh_client. We asked them to be in tree in the first place so that the community can correct them without asking the driver\u0027s owner. And now that we have a need, we aren\u0027t doing it?","commit_id":"69497b151ee35aa626be6ddccb40742528241d45"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8c4ee22339fa82fd5a508b25e7d569cd9ca4d4dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c8e31531_246fd858","updated":"2023-04-17 15:41:41.000000000","message":"based on the recent discussion, this makes sense to do. LGTM.","commit_id":"69497b151ee35aa626be6ddccb40742528241d45"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1d3704c653024c9efa9d67226422a77119a7814d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"faadb3da_a8e2482a","updated":"2023-04-13 14:08:55.000000000","message":"one question inline","commit_id":"69497b151ee35aa626be6ddccb40742528241d45"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"81273e27d3dfefa24fa80184befc5d30f636f012","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8cad7666_1c54c760","in_reply_to":"dc5c31aa_fd7486a5","updated":"2023-04-17 14:31:21.000000000","message":"It makes sense to do this when we have chosen a replacement for paramiko.  But for now, this patch just makes things cleaner when running w/o paramiko.","commit_id":"69497b151ee35aa626be6ddccb40742528241d45"}],"cinder/ssh_utils.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1d3704c653024c9efa9d67226422a77119a7814d","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        self.privatekey \u003d privatekey"},{"line_number":69,"context_line":"        self.hosts_key_file \u003d None"},{"line_number":70,"context_line":"        self.current_size \u003d 0"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        if paramiko is None:"},{"line_number":73,"context_line":"            raise exception.RequirementMissing(req\u003d\u0027paramiko\u0027)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # Validate good config setting here."},{"line_number":76,"context_line":"        # Paramiko handles the case where the file is inaccessible."}],"source_content_type":"text/x-python","patch_set":1,"id":"1ff1f6b1_be00eff0","line":73,"range":{"start_line":71,"start_character":0,"end_line":73,"end_character":62},"updated":"2023-04-13 14:08:55.000000000","message":"do we want to support this library in a non-FIPS environment?\n\nor the wider question would be, is there any way to detect if we\u0027re running a FIPS environment or not based on the operator choice and allow this in a non-FIPS case?\n\nI\u0027ve no issues making the code 100% FIPS complaint but don\u0027t want to break existing deployments with the FIPS changes.","commit_id":"69497b151ee35aa626be6ddccb40742528241d45"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"36ab11477fecac85d6e56ea5f68fea9667790a2e","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        self.privatekey \u003d privatekey"},{"line_number":69,"context_line":"        self.hosts_key_file \u003d None"},{"line_number":70,"context_line":"        self.current_size \u003d 0"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        if paramiko is None:"},{"line_number":73,"context_line":"            raise exception.RequirementMissing(req\u003d\u0027paramiko\u0027)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # Validate good config setting here."},{"line_number":76,"context_line":"        # Paramiko handles the case where the file is inaccessible."}],"source_content_type":"text/x-python","patch_set":1,"id":"9e989a95_2664d420","line":73,"range":{"start_line":71,"start_character":0,"end_line":73,"end_character":62},"in_reply_to":"1ff1f6b1_be00eff0","updated":"2023-04-13 14:16:17.000000000","message":"paramiko is still in requirements.txt, so this won\u0027t change anything for existing deployments.\n\nWhat this patch does is allow downstream packagers to remove paramiko from the deployment and have Cinder still run rather than failing outright.\n\nMaking Cinder aware of whether its running in a FIPS environment would add a lot of unnecessary complication.","commit_id":"69497b151ee35aa626be6ddccb40742528241d45"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"ba9a302d960acb6f21e144e698edc49780e28f21","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        self.privatekey \u003d privatekey"},{"line_number":69,"context_line":"        self.hosts_key_file \u003d None"},{"line_number":70,"context_line":"        self.current_size \u003d 0"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        if paramiko is None:"},{"line_number":73,"context_line":"            raise exception.RequirementMissing(req\u003d\u0027paramiko\u0027)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # Validate good config setting here."},{"line_number":76,"context_line":"        # Paramiko handles the case where the file is inaccessible."}],"source_content_type":"text/x-python","patch_set":1,"id":"0dde473a_0551db42","line":73,"range":{"start_line":71,"start_character":0,"end_line":73,"end_character":62},"in_reply_to":"9e989a95_2664d420","updated":"2023-04-13 15:04:27.000000000","message":"I would still add the similar stubbing to drivers. But I don\u0027t feel strongly about any of this.","commit_id":"69497b151ee35aa626be6ddccb40742528241d45"}]}