)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"26ee3d994c897134a3c53110db708d569ac7ec85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a69faa5e_688f6913","updated":"2023-04-16 23:48:49.000000000","message":"Thanks Brian and Rajat for your review and comments!","commit_id":"75d778244d298961da3ff73fc23058c0b6958f5c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"710a1d515374ec10b850e6c52e591ce1bc4b2948","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a2a91944_fa1bb925","updated":"2023-04-14 13:21:41.000000000","message":"Thanks Brian for making the review simple and quick. LGTM.","commit_id":"75d778244d298961da3ff73fc23058c0b6958f5c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ac02011788a8c789b36f0bd68699dce592b95669","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0c046721_a3d67096","updated":"2023-04-14 13:14:08.000000000","message":"Thanks, Masayuki!  See comments inline about the conflicts (really minor and have been resolved correctly).  Even though this is a large patch, it should be backported because it concerns a data loss issue.  Raising the priority because the final Xena release is due to happen very soon, and it would be good to have this change in the release.","commit_id":"75d778244d298961da3ff73fc23058c0b6958f5c"}],"cinder/tests/unit/api/v2/test_volumes.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ac02011788a8c789b36f0bd68699dce592b95669","unresolved":true,"context_lines":[{"line_number":573,"context_line":"    def test_volume_create_with_invalid_multiattach(self):"},{"line_number":574,"context_line":"        vol \u003d self._vol_in_request_body(multiattach\u003d\"InvalidBool\")"},{"line_number":575,"context_line":"        body \u003d {\"volume\": vol}"},{"line_number":576,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/volumes\u0027)"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        self.assertRaises(exception.ValidationError,"},{"line_number":579,"context_line":"                          self.controller.create,"}],"source_content_type":"text/x-python","patch_set":2,"id":"587094cc_776bee18","side":"PARENT","line":576,"range":{"start_line":576,"start_character":40,"end_line":576,"end_character":42},"updated":"2023-04-14 13:14:08.000000000","message":"The conflict happened here because the code removed by the cherry-pick has /v3 here (because of change I3729cbe1902ab4dc in yoga), whereas in xena we\u0027ve got /v2 here and at line 559.","commit_id":"434d7c93c1c6a29c88f0e329276b4060f4b8fc61"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"26ee3d994c897134a3c53110db708d569ac7ec85","unresolved":false,"context_lines":[{"line_number":573,"context_line":"    def test_volume_create_with_invalid_multiattach(self):"},{"line_number":574,"context_line":"        vol \u003d self._vol_in_request_body(multiattach\u003d\"InvalidBool\")"},{"line_number":575,"context_line":"        body \u003d {\"volume\": vol}"},{"line_number":576,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/volumes\u0027)"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        self.assertRaises(exception.ValidationError,"},{"line_number":579,"context_line":"                          self.controller.create,"}],"source_content_type":"text/x-python","patch_set":2,"id":"87a518d7_29ecd683","side":"PARENT","line":576,"range":{"start_line":576,"start_character":40,"end_line":576,"end_character":42},"in_reply_to":"578b01e4_83198888","updated":"2023-04-16 23:48:49.000000000","message":"Thanks!","commit_id":"434d7c93c1c6a29c88f0e329276b4060f4b8fc61"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"710a1d515374ec10b850e6c52e591ce1bc4b2948","unresolved":true,"context_lines":[{"line_number":573,"context_line":"    def test_volume_create_with_invalid_multiattach(self):"},{"line_number":574,"context_line":"        vol \u003d self._vol_in_request_body(multiattach\u003d\"InvalidBool\")"},{"line_number":575,"context_line":"        body \u003d {\"volume\": vol}"},{"line_number":576,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/volumes\u0027)"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        self.assertRaises(exception.ValidationError,"},{"line_number":579,"context_line":"                          self.controller.create,"}],"source_content_type":"text/x-python","patch_set":2,"id":"578b01e4_83198888","side":"PARENT","line":576,"range":{"start_line":576,"start_character":40,"end_line":576,"end_character":42},"in_reply_to":"587094cc_776bee18","updated":"2023-04-14 13:21:41.000000000","message":"Thanks Brian!","commit_id":"434d7c93c1c6a29c88f0e329276b4060f4b8fc61"}],"cinder/volume/api.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ac02011788a8c789b36f0bd68699dce592b95669","unresolved":true,"context_lines":[{"line_number":208,"context_line":"               availability_zone\u003dNone, source_volume\u003dNone,"},{"line_number":209,"context_line":"               scheduler_hints\u003dNone,"},{"line_number":210,"context_line":"               source_replica\u003dNone, consistencygroup\u003dNone,"},{"line_number":211,"context_line":"               cgsnapshot\u003dNone, source_cg\u003dNone,"},{"line_number":212,"context_line":"               group\u003dNone, group_snapshot\u003dNone, source_group\u003dNone,"},{"line_number":213,"context_line":"               backup\u003dNone):"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"4993656d_0e15c5d8","line":211,"updated":"2023-04-14 13:14:08.000000000","message":"This is the conflict ... change I19a47c463dfb8794eb to yoga changed the parameters to a \"stacked\" style and added mypy annotations.","commit_id":"75d778244d298961da3ff73fc23058c0b6958f5c"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"26ee3d994c897134a3c53110db708d569ac7ec85","unresolved":false,"context_lines":[{"line_number":208,"context_line":"               availability_zone\u003dNone, source_volume\u003dNone,"},{"line_number":209,"context_line":"               scheduler_hints\u003dNone,"},{"line_number":210,"context_line":"               source_replica\u003dNone, consistencygroup\u003dNone,"},{"line_number":211,"context_line":"               cgsnapshot\u003dNone, source_cg\u003dNone,"},{"line_number":212,"context_line":"               group\u003dNone, group_snapshot\u003dNone, source_group\u003dNone,"},{"line_number":213,"context_line":"               backup\u003dNone):"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"eacae7c1_eb206027","line":211,"in_reply_to":"2661dae8_de018a42","updated":"2023-04-16 23:48:49.000000000","message":"Thanks!","commit_id":"75d778244d298961da3ff73fc23058c0b6958f5c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"710a1d515374ec10b850e6c52e591ce1bc4b2948","unresolved":true,"context_lines":[{"line_number":208,"context_line":"               availability_zone\u003dNone, source_volume\u003dNone,"},{"line_number":209,"context_line":"               scheduler_hints\u003dNone,"},{"line_number":210,"context_line":"               source_replica\u003dNone, consistencygroup\u003dNone,"},{"line_number":211,"context_line":"               cgsnapshot\u003dNone, source_cg\u003dNone,"},{"line_number":212,"context_line":"               group\u003dNone, group_snapshot\u003dNone, source_group\u003dNone,"},{"line_number":213,"context_line":"               backup\u003dNone):"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"2661dae8_de018a42","line":211,"in_reply_to":"4993656d_0e15c5d8","updated":"2023-04-14 13:21:41.000000000","message":"Thanks!","commit_id":"75d778244d298961da3ff73fc23058c0b6958f5c"}]}