)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"f037f1298b3d3ed787fced86148ec1142810b69c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"64a5485f_1746a92d","updated":"2023-05-02 14:09:28.000000000","message":"A release note would be required.","commit_id":"13bcd1515aae2c05571ec621cbaa7fa97e203d6d"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"e6d330c70ff987eab81c1c5ab973c2854ee2fbf6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a96b5eef_765157a6","updated":"2023-05-02 14:17:39.000000000","message":"Also, it would be great to have infinidat-volume-driver.rst updated with info about new features.","commit_id":"13bcd1515aae2c05571ec621cbaa7fa97e203d6d"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"f8a5cdf7276be7febe4ed20d1b2eb7e7f5015921","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"640f70df_c982f91c","in_reply_to":"a96b5eef_765157a6","updated":"2023-05-05 16:57:55.000000000","message":"Hello Raghavendra,\n\nThank you very much for the review!\nFixed in patch set #4.\n\nThank you!","commit_id":"13bcd1515aae2c05571ec621cbaa7fa97e203d6d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8fd110a24fc04bc68e23eadc9e2bd53722841e4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"63223289_9ec9fd1b","updated":"2023-09-15 20:19:03.000000000","message":"-1 for using a boolean option as a tri-state variable.  See comment inline.","commit_id":"f174ef7f57c5c675665a35a5e2bf88f47b154c30"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"5e3a4fd7519d69b62d57497df457007647d02412","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"651b42fa_3425ad3a","updated":"2023-05-08 06:50:51.000000000","message":"My comments have been addressed. Code and UT look good.\nInfinidat CI and Zuul have passed.","commit_id":"f174ef7f57c5c675665a35a5e2bf88f47b154c30"}],"cinder/volume/drivers/infinidat.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8fd110a24fc04bc68e23eadc9e2bd53722841e4b","unresolved":true,"context_lines":[{"line_number":99,"context_line":"                     \u0027unset (commented out) for all created volumes to \u0027"},{"line_number":100,"context_line":"                     \u0027inherit their compression setting from their parent \u0027"},{"line_number":101,"context_line":"                     \u0027pool at creation time. The default value is unset.\u0027),"},{"line_number":102,"context_line":"    cfg.BoolOpt(\u0027infinidat_use_ssd\u0027,"},{"line_number":103,"context_line":"                help\u003d\u0027Specifies whether to enable (true) or disable (false) \u0027"},{"line_number":104,"context_line":"                     \u0027SSD cache for all newly created volumes. Leave this \u0027"},{"line_number":105,"context_line":"                     \u0027unset (commented out) for all created volumes to \u0027"},{"line_number":106,"context_line":"                     \u0027inherit their SSD cache setting from their parent \u0027"},{"line_number":107,"context_line":"                     \u0027pool at creation time. The default value is unset.\u0027)"},{"line_number":108,"context_line":"]"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"CONF \u003d cfg.CONF"},{"line_number":111,"context_line":"CONF.register_opts(infinidat_opts, group\u003dconfiguration.SHARED_CONF_GROUP)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a9a0078_a901a78e","line":108,"range":{"start_line":102,"start_character":0,"end_line":108,"end_character":0},"updated":"2023-09-15 20:19:03.000000000","message":"As I mentioned on the other review, I think you need to make these vars string opts with enumerated values.  It will be easy for the new one; for infinidat_use_compression, I sketched out a way you could handle deprecation in a way that old config files will still work:\n\nhttps://paste.opendev.org/show/b6wOghHGREsrhSRagSJV/\n\n(You don\u0027t have to do it my way, just use it as a way to think about how to make this work.)","commit_id":"f174ef7f57c5c675665a35a5e2bf88f47b154c30"}]}