)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"aa9eb2bdf587e419d89a82c16d3755beb48874cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"73babd83_61e22ee3","updated":"2023-05-03 17:27:03.000000000","message":"Code and tests look good; I think you need to explain more clearly in the help text how the option works (because it\u0027s a 3-state setting now, not really a bool any more.)  See comments inline.","commit_id":"6ab18cd07a008d6dbf0b3d8948e2fdf346e516a8"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"7e6aa15edc99687e19dc35a635e7b0941f180e34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9bd46202_ae62093c","updated":"2023-05-01 12:09:49.000000000","message":"recheck cinder-plugin-ceph-tempest","commit_id":"6ab18cd07a008d6dbf0b3d8948e2fdf346e516a8"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"86ac9d8f963c2be4df142b2c44f26284db938ca1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"465ce8fc_360213b5","in_reply_to":"73babd83_61e22ee3","updated":"2023-05-04 09:14:17.000000000","message":"Hello Brian,\n\nThank you very much for the review and detailed comments!\nI tried to fix all the comments in the second patch.\n\nThank you!","commit_id":"6ab18cd07a008d6dbf0b3d8948e2fdf346e516a8"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"868ee66169c95c6b3b906ae058c5ddf2c656ae91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6fda37ea_996a7eaf","updated":"2023-06-08 05:10:11.000000000","message":"Code changes \u0026 release notes look good. Infinidat CI and Zuul have passed.","commit_id":"026dd9d34a3fa9bfc912cb350953aef64a6864a5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c6adeef57b85be0e9510d31ad7cf4876b4c08e11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a454366d_4a7fc541","updated":"2023-09-13 14:43:04.000000000","message":"I\u0027m OK with this, but I suggest that you do a followup patch to deprecate this option and replace it with a string option that takes an enumeration of \u0027enabled\u0027, \u0027disabled\u0027, or \u0027inherit\u0027, because relying on a weird oslo.config behavior that as far as I know is undocumented and could change, could cause problems later.  (I think future driver maintainers will thank you!)","commit_id":"026dd9d34a3fa9bfc912cb350953aef64a6864a5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6b2cd9b0065f7211b0214cc35c20d4e7a08706e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"12580fca_dbc20c23","updated":"2023-09-12 09:54:17.000000000","message":"LGTM","commit_id":"026dd9d34a3fa9bfc912cb350953aef64a6864a5"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"dbd05a3b33b77a8bedf9b438e95487e96c101e3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0e51de65_688bb29b","updated":"2023-05-04 11:55:53.000000000","message":"recheck grenade","commit_id":"026dd9d34a3fa9bfc912cb350953aef64a6864a5"}],"cinder/volume/drivers/infinidat.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"aa9eb2bdf587e419d89a82c16d3755beb48874cd","unresolved":true,"context_lines":[{"line_number":87,"context_line":"                help\u003d\u0027Specifies whether to explicitly enable or disable \u0027"},{"line_number":88,"context_line":"                     \u0027compression for newly created volumes. By default, \u0027"},{"line_number":89,"context_line":"                     \u0027compression for all created volumes is inherited \u0027"},{"line_number":90,"context_line":"                     \u0027from its parent pool at creation time.\u0027),"},{"line_number":91,"context_line":"]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f7da942_5084e923","line":90,"updated":"2023-05-03 17:27:03.000000000","message":"Line 640 shows that you\u0027re using this as a tri-state variable: True means enable compression, False means disable compression, and None (what you get in an oslo.config BoolOpt when there\u0027s no default) means inherit from the parent pool.  I think you should explicitly point this out in the help text, something like:\n\n\u003e Specifies whether to enable (true) or disable (false) compression for all newly created volumes.  Leave this unset (commented out) for all created volumes to inherit their compression setting from their parent pool at creation time.  (The default value is unset.)\n\nIt\u0027s tricky to use a boolean option like this because although you are allowed to have \u0027default\u003dNone\u0027 in the option definition (you don\u0027t, but you could), when the option is read from a config file, the boolean type is enforced.  So even though your generated sample will look like this:\n\n \\# Specifies whether to explicitly enable or disable compression for newly\n \\# created volumes. By default, compression for all created volumes is inherited\n \\# from its parent pool at creation time (boolean value)\n \\#infinidat_use_compression \u003d \u003cNone\u003e\n \nAll of these in a config file will cause an error:\n\ninfinidat_use_compression \u003d \u003cNone\u003e\ninfinidat_use_compression \u003d None\ninfinidat_use_compression \u003d\n\nThe only way for an operator to take advantage of the third state of this variable is to comment out the setting entirely, which is kind of tricky, so you need to be sure to explain this clearly in the help text and in your documentation.\n\nIt would be even better to use deprecate the old option and create a new one that took the values \u0027enabled\u0027, \u0027disabled\u0027, or \u0027inherit\u0027, but that might be overkill.","commit_id":"6ab18cd07a008d6dbf0b3d8948e2fdf346e516a8"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"86ac9d8f963c2be4df142b2c44f26284db938ca1","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                help\u003d\u0027Specifies whether to explicitly enable or disable \u0027"},{"line_number":88,"context_line":"                     \u0027compression for newly created volumes. By default, \u0027"},{"line_number":89,"context_line":"                     \u0027compression for all created volumes is inherited \u0027"},{"line_number":90,"context_line":"                     \u0027from its parent pool at creation time.\u0027),"},{"line_number":91,"context_line":"]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"65592dfd_eab3c55e","line":90,"in_reply_to":"7f7da942_5084e923","updated":"2023-05-04 09:14:17.000000000","message":"Hello Brian,\n\nThank you very much for the review and detailed comments!\nI tried to fix all the comments in the second patch.\n\nThank you!","commit_id":"6ab18cd07a008d6dbf0b3d8948e2fdf346e516a8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c6adeef57b85be0e9510d31ad7cf4876b4c08e11","unresolved":true,"context_lines":[{"line_number":88,"context_line":"                     \u0027compression for all newly created volumes. Leave this \u0027"},{"line_number":89,"context_line":"                     \u0027unset (commented out) for all created volumes to \u0027"},{"line_number":90,"context_line":"                     \u0027inherit their compression setting from their parent \u0027"},{"line_number":91,"context_line":"                     \u0027pool at creation time. The default value is unset.\u0027)"},{"line_number":92,"context_line":"]"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":2,"id":"2dfc01c1_1d5bcee8","line":91,"range":{"start_line":91,"start_character":73,"end_line":91,"end_character":74},"updated":"2023-09-13 14:43:04.000000000","message":"nit: it\u0027s nice to have a comma at the end of the option definition (even though it\u0027s the last one) so that when a new option is added after this one, the comma will already be there and line 91 won\u0027t have to change, and won\u0027t be included in a diff with the new patch.  (Just for future reference.)","commit_id":"026dd9d34a3fa9bfc912cb350953aef64a6864a5"}],"doc/source/configuration/block-storage/drivers/infinidat-volume-driver.rst":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"aa9eb2bdf587e419d89a82c16d3755beb48874cd","unresolved":true,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"  Volume compression is available for all supported InfiniBox versions."},{"line_number":184,"context_line":"  By default, compression for all newly created volumes is inherited from"},{"line_number":185,"context_line":"  its parent pool at creation time. While all pools are created by default"},{"line_number":186,"context_line":"  with compression enabled."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"  To explicitly enable or disable compression for all newly created volumes,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"cba37216_603b2863","line":185,"range":{"start_line":185,"start_character":36,"end_line":185,"end_character":45},"updated":"2023-05-03 17:27:03.000000000","message":"s/While all/All/","commit_id":"6ab18cd07a008d6dbf0b3d8948e2fdf346e516a8"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"86ac9d8f963c2be4df142b2c44f26284db938ca1","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"  Volume compression is available for all supported InfiniBox versions."},{"line_number":184,"context_line":"  By default, compression for all newly created volumes is inherited from"},{"line_number":185,"context_line":"  its parent pool at creation time. While all pools are created by default"},{"line_number":186,"context_line":"  with compression enabled."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"  To explicitly enable or disable compression for all newly created volumes,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"45fb0edc_39cd8600","line":185,"range":{"start_line":185,"start_character":36,"end_line":185,"end_character":45},"in_reply_to":"cba37216_603b2863","updated":"2023-05-04 09:14:17.000000000","message":"Hello Brian,\n\nFixed in the second patch.\n\nThank you!","commit_id":"6ab18cd07a008d6dbf0b3d8948e2fdf346e516a8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"aa9eb2bdf587e419d89a82c16d3755beb48874cd","unresolved":true,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"  .. code-block:: ini"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"     infinidat_use_compression \u003d true/false"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"After modifying the ``cinder.conf`` file, restart the ``cinder-volume``"},{"line_number":196,"context_line":"service."}],"source_content_type":"text/x-rst","patch_set":1,"id":"2c463e1a_37d7c7e5","line":193,"updated":"2023-05-03 17:27:03.000000000","message":"Add something here about commenting out the parameter or removing it from the file to get the default behavior.","commit_id":"6ab18cd07a008d6dbf0b3d8948e2fdf346e516a8"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"86ac9d8f963c2be4df142b2c44f26284db938ca1","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"  .. code-block:: ini"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"     infinidat_use_compression \u003d true/false"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"After modifying the ``cinder.conf`` file, restart the ``cinder-volume``"},{"line_number":196,"context_line":"service."}],"source_content_type":"text/x-rst","patch_set":1,"id":"4454bda0_065b54fc","line":193,"in_reply_to":"2c463e1a_37d7c7e5","updated":"2023-05-04 09:14:17.000000000","message":"Hello Brian,\n\nFixed in the second patch.\n\nThank you!","commit_id":"6ab18cd07a008d6dbf0b3d8948e2fdf346e516a8"}],"releasenotes/notes/bug-2017815-infinidat-fix-compression-setting-04eaf71933d55912.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"aa9eb2bdf587e419d89a82c16d3755beb48874cd","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Infinidat driver `bug #2017815"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2017815\u003e`_:"},{"line_number":6,"context_line":"    Fixed Infinidat driver to inherit compression setting by default"},{"line_number":7,"context_line":"    for all newly created volumes. Admin can set `True` or `False`"},{"line_number":8,"context_line":"    for the `infinidat_use_compression` option in the driver section"},{"line_number":9,"context_line":"    of cinder.conf to explicitly enable or disable compression setting"},{"line_number":10,"context_line":"    for all newly created volumes."},{"line_number":11,"context_line":"deprecations:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6317c_66f17143","line":8,"range":{"start_line":7,"start_character":49,"end_line":8,"end_character":40},"updated":"2023-05-03 17:27:03.000000000","message":"use double-backticks (\\`\\`) to get monospace font","commit_id":"6ab18cd07a008d6dbf0b3d8948e2fdf346e516a8"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"86ac9d8f963c2be4df142b2c44f26284db938ca1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Infinidat driver `bug #2017815"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2017815\u003e`_:"},{"line_number":6,"context_line":"    Fixed Infinidat driver to inherit compression setting by default"},{"line_number":7,"context_line":"    for all newly created volumes. Admin can set `True` or `False`"},{"line_number":8,"context_line":"    for the `infinidat_use_compression` option in the driver section"},{"line_number":9,"context_line":"    of cinder.conf to explicitly enable or disable compression setting"},{"line_number":10,"context_line":"    for all newly created volumes."},{"line_number":11,"context_line":"deprecations:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"863e3eb5_d823b368","line":8,"range":{"start_line":7,"start_character":49,"end_line":8,"end_character":40},"in_reply_to":"bab6317c_66f17143","updated":"2023-05-04 09:14:17.000000000","message":"Hello Brian,\n\nFixed in the second patch.\n\nThank you!","commit_id":"6ab18cd07a008d6dbf0b3d8948e2fdf346e516a8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"aa9eb2bdf587e419d89a82c16d3755beb48874cd","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    for the `infinidat_use_compression` option in the driver section"},{"line_number":9,"context_line":"    of cinder.conf to explicitly enable or disable compression setting"},{"line_number":10,"context_line":"    for all newly created volumes."},{"line_number":11,"context_line":"deprecations:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    Infinidat driver deprecated the support for for pre-v3.0 InfiniBox"},{"line_number":14,"context_line":"    systems that do not support compression. These versions are end of"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"016f5bb1_4ae43c9c","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":13},"updated":"2023-05-03 17:27:03.000000000","message":"this should go in the upgrade section (you\u0027re not deprecating now, you are announcing the removal of something previously deprecated)","commit_id":"6ab18cd07a008d6dbf0b3d8948e2fdf346e516a8"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"86ac9d8f963c2be4df142b2c44f26284db938ca1","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    for the `infinidat_use_compression` option in the driver section"},{"line_number":9,"context_line":"    of cinder.conf to explicitly enable or disable compression setting"},{"line_number":10,"context_line":"    for all newly created volumes."},{"line_number":11,"context_line":"deprecations:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    Infinidat driver deprecated the support for for pre-v3.0 InfiniBox"},{"line_number":14,"context_line":"    systems that do not support compression. These versions are end of"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d47f6a26_40e934a1","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":13},"in_reply_to":"016f5bb1_4ae43c9c","updated":"2023-05-04 09:14:17.000000000","message":"Hello Brian,\n\nFixed in the second patch.\n\nThank you!","commit_id":"6ab18cd07a008d6dbf0b3d8948e2fdf346e516a8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"aa9eb2bdf587e419d89a82c16d3755beb48874cd","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    Infinidat driver deprecated the support for for pre-v3.0 InfiniBox"},{"line_number":14,"context_line":"    systems that do not support compression. These versions are end of"},{"line_number":15,"context_line":"    life and no longer supported for a long time."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a46e5759_d54a757f","line":15,"updated":"2023-05-03 17:27:03.000000000","message":"I suggest rephrasing to something like:\n\n\u003e Infinidat driver: support has been removed for pre-v3.0 InfiniBox systems.\nThese versions are end of life and have not been supported for a long time.\n\n(It would be helpful if you could be specific about when support stopped if you know when it ended.)","commit_id":"6ab18cd07a008d6dbf0b3d8948e2fdf346e516a8"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"86ac9d8f963c2be4df142b2c44f26284db938ca1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    Infinidat driver deprecated the support for for pre-v3.0 InfiniBox"},{"line_number":14,"context_line":"    systems that do not support compression. These versions are end of"},{"line_number":15,"context_line":"    life and no longer supported for a long time."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0a1d3239_e1fb1518","line":15,"in_reply_to":"a46e5759_d54a757f","updated":"2023-05-04 09:14:17.000000000","message":"Hello Brian,\n\nThank you very much for the review and detailed comments!\nFixed in the second patch.\n\nThank you!","commit_id":"6ab18cd07a008d6dbf0b3d8948e2fdf346e516a8"}]}