)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"686aa997cef60863751a605227a9d23a4c8ab5b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d937f1e5_acf1af9d","updated":"2023-05-31 13:24:10.000000000","message":"Small change noted inline.  It\u0027s just a rewording of a comment, so if you push up a new patch, I\u0027ll carry over Jay\u0027s +2, and we can approve it right away.","commit_id":"9857d76717c1baa4ab989888a95314fb30bc8ccb"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"615cf333010c135df8343f70815efe840c1b7cd2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0f4fe65c_b7afde5f","updated":"2023-05-25 15:03:08.000000000","message":"This change looks ok to me.  Thanks!","commit_id":"9857d76717c1baa4ab989888a95314fb30bc8ccb"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ece24270dcb17b1768f308eb357fa01b20f2c266","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"03b6eadf_35634322","in_reply_to":"d937f1e5_acf1af9d","updated":"2023-05-31 13:27:41.000000000","message":"great! thank you!","commit_id":"9857d76717c1baa4ab989888a95314fb30bc8ccb"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ac986db423b2e54f00f20bc51b713a59191cc4bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fb3cab9a_ac79ff02","updated":"2023-05-31 13:28:48.000000000","message":"Only change is to a comment.  Carrying over Jay\u0027s +2 and approving.","commit_id":"b3d3f31fa325533cf8130533e955ef43b8f38189"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1277925cf6c821f5fb459c44d021b84d87b3921f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"568e9ed6_5a9e9ceb","updated":"2023-06-02 12:23:21.000000000","message":"recheck","commit_id":"b3d3f31fa325533cf8130533e955ef43b8f38189"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1875287e4f15558e97cd697d183dfb7f65e7064f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"698f41e1_4e26cae0","updated":"2023-06-01 11:38:07.000000000","message":"recheck","commit_id":"b3d3f31fa325533cf8130533e955ef43b8f38189"}],"cinder/image/image_utils.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"686aa997cef60863751a605227a9d23a4c8ab5b4","unresolved":true,"context_lines":[{"line_number":1315,"context_line":""},{"line_number":1316,"context_line":"    new_metadata \u003d _filter_out_metadata(metadata, reserved_name_spaces)"},{"line_number":1317,"context_line":"    # NOTE(ganso): handle adjustment of metadata structure performed by"},{"line_number":1318,"context_line":"    # the _merge_volume_image_meta method"},{"line_number":1319,"context_line":"    if \u0027properties\u0027 in new_metadata:"},{"line_number":1320,"context_line":"        new_metadata[\u0027properties\u0027] \u003d _filter_out_metadata("},{"line_number":1321,"context_line":"            metadata[\u0027properties\u0027], reserved_name_spaces)"}],"source_content_type":"text/x-python","patch_set":3,"id":"283a66bf_5e816b20","line":1318,"range":{"start_line":1318,"start_character":6,"end_line":1318,"end_character":41},"updated":"2023-05-31 13:24:10.000000000","message":"nit: replace this with\n\ncinder.volume.api.API._merge_volume_image_meta()\n\nso the reader knows where this function is located","commit_id":"9857d76717c1baa4ab989888a95314fb30bc8ccb"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ece24270dcb17b1768f308eb357fa01b20f2c266","unresolved":true,"context_lines":[{"line_number":1315,"context_line":""},{"line_number":1316,"context_line":"    new_metadata \u003d _filter_out_metadata(metadata, reserved_name_spaces)"},{"line_number":1317,"context_line":"    # NOTE(ganso): handle adjustment of metadata structure performed by"},{"line_number":1318,"context_line":"    # the _merge_volume_image_meta method"},{"line_number":1319,"context_line":"    if \u0027properties\u0027 in new_metadata:"},{"line_number":1320,"context_line":"        new_metadata[\u0027properties\u0027] \u003d _filter_out_metadata("},{"line_number":1321,"context_line":"            metadata[\u0027properties\u0027], reserved_name_spaces)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5d51df56_97c39fb6","line":1318,"range":{"start_line":1318,"start_character":6,"end_line":1318,"end_character":41},"in_reply_to":"283a66bf_5e816b20","updated":"2023-05-31 13:27:41.000000000","message":"done! :)","commit_id":"9857d76717c1baa4ab989888a95314fb30bc8ccb"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"686aa997cef60863751a605227a9d23a4c8ab5b4","unresolved":true,"context_lines":[{"line_number":1318,"context_line":"    # the _merge_volume_image_meta method"},{"line_number":1319,"context_line":"    if \u0027properties\u0027 in new_metadata:"},{"line_number":1320,"context_line":"        new_metadata[\u0027properties\u0027] \u003d _filter_out_metadata("},{"line_number":1321,"context_line":"            metadata[\u0027properties\u0027], reserved_name_spaces)"},{"line_number":1322,"context_line":""},{"line_number":1323,"context_line":"    LOG.debug(\"The metadata set [%s] was filtered using the reserved name \""},{"line_number":1324,"context_line":"              \"spaces [%s], and the result is [%s].\", metadata,"}],"source_content_type":"text/x-python","patch_set":3,"id":"af815292_1897aafe","line":1321,"updated":"2023-05-31 13:24:10.000000000","message":"I was thinking that maybe we only need to handle the \u0027properties\u0027 case because non-core image properties will only show up in \u0027properties\u0027 because of the way _merge_volume_image_meta() works ... but on the other hand, since the core properties are actually determined by CONF.glance_core_properties, we can\u0027t be sure what will be filtered out during the merge, so I think you are correct, we do need to check both the \"regular\" metadata and the \"properties\" dict to make sure we remove all the reserved namespace properties.","commit_id":"9857d76717c1baa4ab989888a95314fb30bc8ccb"}]}