)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"a8572a90c0a8081e0d366fa8d4097b2b4fb23de4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8e4f8409_cf85c5b1","updated":"2024-01-30 09:23:14.000000000","message":"Hi Hemna, since this is a backport it is not possible to make changes to the patch. It would be best to fix the log message in the master branch and backport that change if necessary.","commit_id":"5a87cf91a67c694c8f03971b52cf3247b41f5d87"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"528bcd6156b969a02f4060a15d3f0323bfa3a759","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"21ba2723_0b77ee68","updated":"2023-05-24 08:27:14.000000000","message":"Thanks Hemna for comment.\nLet me try to explain.\n\nSample error message:\nVolume osv-hVgiAJp7RZWAun-FL3dKCw has dependent snapshots: oss-H1gdPDOgTqysO2cSecdBeA. Either flatten or remove the dependent snapshots: oss-H1gdPDOgTqysO2cSecdBeA for the conversion of volume osv-hVgiAJp7RZWAun-FL3dKCw to succeed.\n\nIf i understand your query correctly...\nsince the names like \"osv-...\" and \"oss-...\" are specific to 3par backend;\nthe cinder admin won\u0027t be able to identify them.\nEg. the admin would use commands \"cinder list\" and \"cinder snapshot-list\".\nThey would return volume names as \"v1\", \"v2\" and snapshot names as \"s1\", \"s2\".\n\nSuggestion:\nIn the error message ... Instead of names like \"osv-...\" and \"oss-...\",\nwe can add some code to provide names used in cinder i.e \"v2\" and \"s2\" respectively.\n\nThen, cinder admin can use cinder snapshot-delete command to remove dependent snapshot \"s2\".\n\nIs this approach fine ?\nPlease correct me if i am missing anything.","commit_id":"5a87cf91a67c694c8f03971b52cf3247b41f5d87"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"f50c0d58b2a861f0c391b8d02601c7539c348d7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"66849f04_dbc4f984","updated":"2023-05-12 11:48:38.000000000","message":"run-HPE Storage CI","commit_id":"5a87cf91a67c694c8f03971b52cf3247b41f5d87"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"d4d2886eeebd67d54b5c0c9515c15713975f173f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6b5ceb03_c7248d10","updated":"2023-05-15 06:48:54.000000000","message":"run-HPE Storage CI","commit_id":"5a87cf91a67c694c8f03971b52cf3247b41f5d87"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"4910160ea31466bbe1c540ac8f9343716eeb5c1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7219c008_20c63acb","updated":"2023-05-15 11:00:34.000000000","message":"run-HPE Storage CI","commit_id":"5a87cf91a67c694c8f03971b52cf3247b41f5d87"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"2ab7d6719c83c0fa6fd77a6562e7ed315010a4e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c19d787c_0e7e5382","updated":"2023-05-12 05:46:35.000000000","message":"run-HPE Storage CI","commit_id":"5a87cf91a67c694c8f03971b52cf3247b41f5d87"},{"author":{"_account_id":5112,"name":"Seyeong Kim","email":"seyeong.kim@canonical.com","username":"xtrusia"},"change_message_id":"b9a7d64eaf9bf7cb226648cde9cf44e2c7447329","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"41635dcd_f4f14471","updated":"2024-01-31 00:15:59.000000000","message":"As 4.0.19 is already backported, there were conflict.\nI fixed it and uploaded this again.","commit_id":"af040f92537928401ccb167943d1edb6da80ad4e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"51f8936e1bb3a49a5057b921737c25208679b2cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"beb74d37_cb0f3ba0","updated":"2024-02-21 15:10:54.000000000","message":"I think this looks like an appropriate backport.","commit_id":"af040f92537928401ccb167943d1edb6da80ad4e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ff82524284e6aa1603b3318a6c049092f09dbcec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3b90e325_7a62a953","updated":"2024-05-22 13:54:28.000000000","message":"Small change (with tests) isolated to a single driver.  The followup patch discussed by Walt and Raghavendra looks worth doing, but I don\u0027t think we need to hold this up for that.","commit_id":"af040f92537928401ccb167943d1edb6da80ad4e"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"b5890e4d6274f27906caa002ae98b2231cc8775c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dc050a5e_7c8f8336","updated":"2024-05-24 06:23:38.000000000","message":"Thank you Brian","commit_id":"af040f92537928401ccb167943d1edb6da80ad4e"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c8567e12840064a4dffa3241633e870c91cd33b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d6997d64_4dbb4737","updated":"2024-02-22 06:02:17.000000000","message":"Thanks Seyeong and Jay.","commit_id":"af040f92537928401ccb167943d1edb6da80ad4e"},{"author":{"_account_id":5112,"name":"Seyeong Kim","email":"seyeong.kim@canonical.com","username":"xtrusia"},"change_message_id":"affca1bd7ef1cf89863decb645921a0b4a109ddf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c2129dad_6374ee41","updated":"2024-01-31 02:23:54.000000000","message":"recheck","commit_id":"af040f92537928401ccb167943d1edb6da80ad4e"}],"cinder/volume/drivers/hpe/hpe_3par_common.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"34cbf17d04efb15e33a8d0edc0bfb15a3151f153","unresolved":true,"context_lines":[{"line_number":3153,"context_line":"                         \" Either flatten or remove the dependent snapshots:\""},{"line_number":3154,"context_line":"                         \" %(snap)s for the conversion of volume %(name)s to\""},{"line_number":3155,"context_line":"                         \" succeed.\" % {\u0027name\u0027: volume_name,"},{"line_number":3156,"context_line":"                                        \u0027snap\u0027: snap_str}))"},{"line_number":3157,"context_line":"                raise exception.VolumeIsBusy(message\u003dmsg)"},{"line_number":3158,"context_line":""},{"line_number":3159,"context_line":"            # Create a physical copy of the volume"}],"source_content_type":"text/x-python","patch_set":1,"id":"3481fd16_36ef6e9e","line":3156,"updated":"2023-05-22 18:06:20.000000000","message":"I don\u0027t see how this message is very helpful as the admin has no way to do this using the cinder API.  How does an admin flatten dependent snapshots with the API ?","commit_id":"5a87cf91a67c694c8f03971b52cf3247b41f5d87"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"528bcd6156b969a02f4060a15d3f0323bfa3a759","unresolved":false,"context_lines":[{"line_number":3153,"context_line":"                         \" Either flatten or remove the dependent snapshots:\""},{"line_number":3154,"context_line":"                         \" %(snap)s for the conversion of volume %(name)s to\""},{"line_number":3155,"context_line":"                         \" succeed.\" % {\u0027name\u0027: volume_name,"},{"line_number":3156,"context_line":"                                        \u0027snap\u0027: snap_str}))"},{"line_number":3157,"context_line":"                raise exception.VolumeIsBusy(message\u003dmsg)"},{"line_number":3158,"context_line":""},{"line_number":3159,"context_line":"            # Create a physical copy of the volume"}],"source_content_type":"text/x-python","patch_set":1,"id":"d60e0f43_e68c4d21","line":3156,"in_reply_to":"3481fd16_36ef6e9e","updated":"2023-05-24 08:27:14.000000000","message":"Ack","commit_id":"5a87cf91a67c694c8f03971b52cf3247b41f5d87"}]}
