)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"71526a0ece53618a0e87c2b2fc36c8c17e152048","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5a352490_5b79fbe3","updated":"2023-05-10 20:24:43.000000000","message":"Reviewed this as a patch on the security bug, LGTM.","commit_id":"6df1839bdf288107c600b3e53dff7593a6d4c161"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e831aacf8881dbaa0fcbd908612a0c3fe7bff6d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5fb9953b_d2e61102","updated":"2023-05-11 05:38:06.000000000","message":"recheck unrelated failures in tempest-integrated-storage","commit_id":"6df1839bdf288107c600b3e53dff7593a6d4c161"}],"cinder/volume/api.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2b0a555baf86375c8edbfb6bbd367664873c2e6d","unresolved":true,"context_lines":[{"line_number":2584,"context_line":""},{"line_number":2585,"context_line":"            server_id \u003d attachment.instance_uuid"},{"line_number":2586,"context_line":"            # It\u0027s ok to delete if it\u0027s not connected to a vm."},{"line_number":2587,"context_line":"            if not server_id or not attachment.connection_info:"},{"line_number":2588,"context_line":"                return"},{"line_number":2589,"context_line":""},{"line_number":2590,"context_line":"            volume \u003d volume or attachment.volume"}],"source_content_type":"text/x-python","patch_set":2,"id":"efb9b705_153d6594","line":2587,"range":{"start_line":2587,"start_character":0,"end_line":2587,"end_character":63},"updated":"2023-05-10 22:18:30.000000000","message":"+1, so this is where test_attach_detach_volume_to_instance is valid, even server_idn is passed to cinder but if attachment is not there in nova server it is still good to delete attachment.","commit_id":"6df1839bdf288107c600b3e53dff7593a6d4c161"}],"doc/source/configuration/index.rst":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e831aacf8881dbaa0fcbd908612a0c3fe7bff6d9","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":".. warning::"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"   For security reasons **Service Tokens must to be configured** in OpenStack"},{"line_number":25,"context_line":"   for Cinder to operate securely.  Pay close attention to the :doc:`specific"},{"line_number":26,"context_line":"   section describing it: \u003cblock-storage/service-token\u003e`. See"},{"line_number":27,"context_line":"   https://bugs.launchpad.net/nova/+bug/2004555 for details."}],"source_content_type":"text/x-rst","patch_set":1,"id":"fee65251_46352666","line":24,"range":{"start_line":24,"start_character":46,"end_line":24,"end_character":48},"updated":"2023-05-11 05:38:06.000000000","message":"nit: not needed","commit_id":"f6f4b77b21393539d0e45b6d4d8df31ee4f7f0ef"}],"doc/source/install/index.rst":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e831aacf8881dbaa0fcbd908612a0c3fe7bff6d9","unresolved":true,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":".. warning::"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"   For security reasons **Service Tokens must to be configured** in OpenStack"},{"line_number":41,"context_line":"   for Cinder to operate securely.  Pay close attention to the :doc:`specific"},{"line_number":42,"context_line":"   section describing it: \u003c../configuration/block-storage/service-token\u003e`. See"},{"line_number":43,"context_line":"   https://bugs.launchpad.net/nova/+bug/2004555 for details."}],"source_content_type":"text/x-rst","patch_set":1,"id":"a93d9e91_388a1d39","line":40,"range":{"start_line":40,"start_character":46,"end_line":40,"end_character":48},"updated":"2023-05-11 05:38:06.000000000","message":"nit: same","commit_id":"f6f4b77b21393539d0e45b6d4d8df31ee4f7f0ef"}]}
