)]}'
{"id":"openstack%2Fcinder~882836","triplet_id":"openstack%2Fcinder~stable%2F2023.1~I612905a1bf4a1706cce913c0d8a6df7a240d599a","project":"openstack/cinder","branch":"stable/2023.1","topic":"bug/2004555","attention_set":{},"removed_from_attention_set":{"9535":{"account":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"last_update":"2023-05-11 12:17:00.000000000","reason":"Change was submitted"},"11904":{"account":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"last_update":"2023-05-11 12:17:00.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I612905a1bf4a1706cce913c0d8a6df7a240d599a","subject":"Reject unsafe delete attachment calls","status":"MERGED","created":"2023-05-10 14:37:38.000000000","updated":"2023-05-15 13:52:45.000000000","submitted":"2023-05-11 12:17:00.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"882836-bug/2004555","meta_rev_id":"133a2c7c7125b767b9457f006c0a4df2dbe23088","_number":882836,"virtual_id_number":882836,"owner":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-05-11 12:17:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2023-05-11 10:47:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2023-05-11 02:41:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2023-05-11 10:47:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"approved":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2023-05-11 02:41:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":22248,"name":"HPE AlletraMP iSCSI CI","email":"hp.cinder.blr.ci@groups.ext.hpe.com","username":"hp-storage-blr-ci","tags":["SERVICE_USER"]},{"_account_id":28801,"name":"Cisco Cinder CI","email":"cisco-cinder-ci@cisco.com","username":"cisco-cinder-ci"},{"_account_id":31868,"name":"Open-E CI","email":"open-e-ci-joviandss@open-e.com","username":"open-e-ci-joviandss","tags":["SERVICE_USER"]},{"_account_id":32912,"name":"Pure Storage Third-Party CI","display_name":"Pure Storage Third-Party CI","email":"openstack-third-party-ci@purestorage.com","username":"purestorage-thirdparty-ci","status":"Doing CI things"},{"_account_id":34318,"name":"HPE Nimble Storage CI","display_name":"HPE Nimble Storage CI","email":"raghavendra.tilay@capgemini.com","username":"hpe-nimble"}],"REVIEWER":[{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-05-10 14:53:53.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2023-05-10 15:06:53.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-05-10 15:46:48.000000000","updated_by":{"_account_id":22248,"name":"HPE AlletraMP iSCSI CI","email":"hp.cinder.blr.ci@groups.ext.hpe.com","username":"hp-storage-blr-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22248,"name":"HPE AlletraMP iSCSI CI","email":"hp.cinder.blr.ci@groups.ext.hpe.com","username":"hp-storage-blr-ci","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-05-10 16:03:08.000000000","updated_by":{"_account_id":28801,"name":"Cisco Cinder CI","email":"cisco-cinder-ci@cisco.com","username":"cisco-cinder-ci"},"reviewer":{"_account_id":28801,"name":"Cisco Cinder CI","email":"cisco-cinder-ci@cisco.com","username":"cisco-cinder-ci"},"state":"CC"},{"updated":"2023-05-10 16:42:28.000000000","updated_by":{"_account_id":34318,"name":"HPE Nimble Storage CI","display_name":"HPE Nimble Storage CI","email":"raghavendra.tilay@capgemini.com","username":"hpe-nimble"},"reviewer":{"_account_id":34318,"name":"HPE Nimble Storage CI","display_name":"HPE Nimble Storage CI","email":"raghavendra.tilay@capgemini.com","username":"hpe-nimble"},"state":"CC"},{"updated":"2023-05-10 16:53:09.000000000","updated_by":{"_account_id":32912,"name":"Pure Storage Third-Party CI","display_name":"Pure Storage Third-Party CI","email":"openstack-third-party-ci@purestorage.com","username":"purestorage-thirdparty-ci","status":"Doing CI things"},"reviewer":{"_account_id":32912,"name":"Pure Storage Third-Party CI","display_name":"Pure Storage Third-Party CI","email":"openstack-third-party-ci@purestorage.com","username":"purestorage-thirdparty-ci","status":"Doing CI things"},"state":"CC"},{"updated":"2023-05-10 17:18:08.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-05-10 20:27:30.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"CC"},{"updated":"2023-05-11 02:41:50.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2023-05-11 10:47:31.000000000","updated_by":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"reviewer":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"state":"REVIEWER"},{"updated":"2023-05-15 13:52:45.000000000","updated_by":{"_account_id":31868,"name":"Open-E CI","email":"open-e-ci-joviandss@open-e.com","username":"open-e-ci-joviandss","tags":["SERVICE_USER"]},"reviewer":{"_account_id":31868,"name":"Open-E CI","email":"open-e-ci-joviandss@open-e.com","username":"open-e-ci-joviandss","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"9b590a1abc419ef8dd6d36affd31f8fa4be7cbcd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2023-05-10 14:37:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"43110a642a156f8af1117c77da76a442b9d2e5ab","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2023-05-10 14:53:53.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"5ecfd1bd065233fe138647afef7ca2b2fbdac98c","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-10 15:06:53.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/8ecc914dee254249a0b784ca7a4c9fec\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/4b73867c5d7447368149df14e41df5c3 : SUCCESS in 9m 14s (non-voting)\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/b7c0150c690447ee9fba87be9abb83b6 : SUCCESS in 27m 06s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ffd135ac29cc0133e9fce1afa90aec7eb3e74506","author":{"_account_id":22248,"name":"HPE AlletraMP iSCSI CI","email":"hp.cinder.blr.ci@groups.ext.hpe.com","username":"hp-storage-blr-ci","tags":["SERVICE_USER"]},"date":"2023-05-10 15:46:48.000000000","message":"Patch Set 1:\n\nBuild failed.\n\n- 3par-iscsi-driver-master-client-pip-ssa02-dsvm https://github.com/hpe-storage/hpe_cinder_logs/tree/master/new_logs/882836 : FAILURE in 1h 06m 45s","accounts_in_message":[],"_revision_number":1},{"id":"36afdffecc554db60c7994673c98c348db073503","author":{"_account_id":28801,"name":"Cisco Cinder CI","email":"cisco-cinder-ci@cisco.com","username":"cisco-cinder-ci"},"date":"2023-05-10 16:03:08.000000000","message":"Patch Set 1:\n\nBuild failed.\nhttps://127.0.0.1:9000/t/openstack/buildset/6804d5d264d74541aeb704e640838b5c\n\n- dsvm-tempest-cisco-zonemanager-job https://127.0.0.1:9000/t/openstack/build/d993c6e61dc54d8c9572828be70e2a8e : POST_FAILURE in 14m 42s","accounts_in_message":[],"_revision_number":1},{"id":"f219ca9868e503e3947ef7cb754b7243a3b14f3f","author":{"_account_id":34318,"name":"HPE Nimble Storage CI","display_name":"HPE Nimble Storage CI","email":"raghavendra.tilay@capgemini.com","username":"hpe-nimble"},"date":"2023-05-10 16:42:28.000000000","message":"Patch Set 1:\n\nBuild failed.\n\n- iscsi-driver-alletra-6k https://hpe-storage.github.io/alletra-6k-ci-logs/logs/36/882836/1/check/iscsi-driver-alletra-6k/c2f4b99/c2f4b99.html : FAILURE in 2h 03m 28s","accounts_in_message":[],"_revision_number":1},{"id":"a2c755e10cc892953046a207cdada72eb0a6ad5e","author":{"_account_id":32912,"name":"Pure Storage Third-Party CI","display_name":"Pure Storage Third-Party CI","email":"openstack-third-party-ci@purestorage.com","username":"purestorage-thirdparty-ci","status":"Doing CI things"},"date":"2023-05-10 16:53:09.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- pure-devstack-cinder-tempest-iscsi-aio-jammy http://openstack-logs.purestorage.com/36/882836/1/thirdparty-check/pure-devstack-cinder-tempest-iscsi-aio-jammy/cc78e4e/ : SUCCESS in 2h 13m 24s\n- pure-devstack-cinder-tempest-fc-aio-jammy http://openstack-logs.purestorage.com/36/882836/1/thirdparty-check/pure-devstack-cinder-tempest-fc-aio-jammy/0e3695f/ : SUCCESS in 2h 13m 10s (non-voting)\n- pure-devstack-cinder-tempest-nvme-roce-aio-jammy http://openstack-logs.purestorage.com/36/882836/1/thirdparty-check/pure-devstack-cinder-tempest-nvme-roce-aio-jammy/3c693c4/ : SUCCESS in 2h 09m 39s","accounts_in_message":[],"_revision_number":1},{"id":"ad92575a5df291da71d835dd7150165d76503173","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-10 17:18:08.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/31402df299654a538259b6dc08a07835\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4c9c176084d641a6b8814747737fc481 : SUCCESS in 6m 06s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e4751494f07947faa950d6411e83023e : SUCCESS in 11m 37s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/a1e07d64963e493388935bb4e1ee238a : SUCCESS in 11m 06s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7c242790835c4dbd9adf8db5098f2cd2 : SUCCESS in 12m 02s\n- grenade https://zuul.opendev.org/t/openstack/build/de37c9bc9e7440169589d43bcd133879 : SUCCESS in 56m 27s\n- grenade-skip-level https://zuul.opendev.org/t/openstack/build/a5fbd282f8eb410ca6460fd11fee43a8 : FAILURE in 30m 00s (non-voting)\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/3a83f8e6d3914379819d2b9b2615c5a5 : SUCCESS in 1h 24m 46s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/c298acd147c941c38999f1db321372b4 : SUCCESS in 55m 32s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/38c06b2e82fc4042b77bdb3aea3addd1 : SUCCESS in 8m 30s\n- cinder-code-coverage https://zuul.opendev.org/t/openstack/build/a259babaa52548e5847fca084ee2383e : SUCCESS in 17m 32s (non-voting)\n- cinder-mypy https://zuul.opendev.org/t/openstack/build/0c3f68b84db943739ea9e3d9c9328025 : FAILURE in 5m 47s\n- cinder-tox-bandit-baseline https://zuul.opendev.org/t/openstack/build/4d53b79a7e3b4c8dacc245a110b3b231 : SUCCESS in 5m 09s (non-voting)\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/bf40e23d52754f95a68cbfd3ebd4ac97 : SUCCESS in 6m 35s\n- openstack-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/1a517490dce8414693541b5643a38532 : SUCCESS in 5m 31s\n- cinder-rally-task https://zuul.opendev.org/t/openstack/build/470aad803d544857944c8780664822f4 : SUCCESS in 50m 31s (non-voting)\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/bbba7202382145f2b823d5b8b0ac70a7 : FAILURE in 7m 43s (non-voting)\n- cinder-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/8f9e2aa33ccc4f4ebd8da5ae120ee5a6 : SUCCESS in 1h 56m 39s\n- cinder-plugin-ceph-tempest-mn-aa https://zuul.opendev.org/t/openstack/build/3421532f49fa418bbfd8c5d3c8eaf3df : FAILURE in 1h 38m 53s (non-voting)\n- cinder-tempest-plugin-lvm-lio-barbican https://zuul.opendev.org/t/openstack/build/265c92334c284f8d8bc323dba6537a05 : SUCCESS in 1h 50m 09s\n- cinder-grenade-mn-sub-volbak https://zuul.opendev.org/t/openstack/build/84a792e63a2a4348933e22f05ee6af88 : SUCCESS in 1h 15m 32s\n- cinder-tempest-lvm-multibackend https://zuul.opendev.org/t/openstack/build/082feb9b0d524b9b8cabf421be3048ee : SUCCESS in 1h 46m 57s (non-voting)\n- cinder-for-glance-optimized https://zuul.opendev.org/t/openstack/build/4226d589c04342ff9a6b8231fcbaa8ec : SUCCESS in 47m 50s (non-voting)\n- devstack-plugin-nfs-tempest-full https://zuul.opendev.org/t/openstack/build/5e4e4c9bc5f04b2897604fff82dd36de : SUCCESS in 1h 22m 08s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/6e54cbc0bd624083904624e43d3c6e79 : SUCCESS in 2h 32m 38s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/32c5bdba466e4b78ae3c50ddf49b1d4c : SUCCESS in 1h 10m 13s\n- tempest-integrated-storage-ubuntu-focal https://zuul.opendev.org/t/openstack/build/07980f7897c64554b7cf8fbe3694934a : SUCCESS in 1h 43m 26s","accounts_in_message":[],"_revision_number":1},{"id":"9db1acb225b3703956bf39b37a52f1b7a01d8f5d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2023-05-10 17:53:49.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:TRIVIAL_REBASE OR is:MIN\")\n* Verified-1\n","accounts_in_message":[],"_revision_number":2},{"id":"34fe3c497bf106231487d7035a553d9b499d7fab","author":{"_account_id":28801,"name":"Cisco Cinder CI","email":"cisco-cinder-ci@cisco.com","username":"cisco-cinder-ci"},"date":"2023-05-10 18:20:16.000000000","message":"Patch Set 2:\n\nBuild failed.\nhttps://127.0.0.1:9000/t/openstack/buildset/f80a143620304039be7229403a1d244c\n\n- dsvm-tempest-cisco-zonemanager-job https://127.0.0.1:9000/t/openstack/build/aed23ab5645e4672be99394f812fab62 : POST_FAILURE in 14m 46s","accounts_in_message":[],"_revision_number":2},{"id":"1390172a618a5a293953d6d26e15a8152e367585","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-10 18:29:22.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/dc912f9458874fa2a9e2dde783bdc024\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/24062023578e433aa901e0e4db3d9fee : SUCCESS in 27m 51s (non-voting)\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/faadab46754b489097ffab6410599da5 : SUCCESS in 33m 35s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"b3025ce81a1d829d59caf01875021999d4eba4ea","author":{"_account_id":22248,"name":"HPE AlletraMP iSCSI CI","email":"hp.cinder.blr.ci@groups.ext.hpe.com","username":"hp-storage-blr-ci","tags":["SERVICE_USER"]},"date":"2023-05-10 19:16:17.000000000","message":"Patch Set 2:\n\nBuild failed.\n\n- 3par-iscsi-driver-master-client-pip-ssa02-dsvm https://github.com/hpe-storage/hpe_cinder_logs/tree/master/new_logs/882836 : FAILURE in 1h 10m 41s","accounts_in_message":[],"_revision_number":2},{"id":"bd5695a3314ae2038a0f643322b133e71ee3270c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-10 19:38:54.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/cddc5b5c20a34b2fbe251577f19acf25\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/824a37c7dd09437ebcbcf8db295311cc : SUCCESS in 6m 03s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/82a1d5a01ea84b53b926a2d11154014e : SUCCESS in 11m 47s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/ce27dd9310084602b7ed7d53d450de3d : SUCCESS in 11m 59s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/54ad2784d4a640ed84ea7f1c3b124072 : SUCCESS in 12m 58s\n- grenade https://zuul.opendev.org/t/openstack/build/58a99abe17e64f019e09bb2f3a45e86f : SUCCESS in 48m 35s\n- grenade-skip-level https://zuul.opendev.org/t/openstack/build/b6cbf1d161d1491d8154463d412474c1 : FAILURE in 24m 11s (non-voting)\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/7b15bb9106ec453e8f6b2d98f56b325a : SUCCESS in 1h 16m 00s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/0888375ebbef4ecd93b4f1d59e7756bb : SUCCESS in 56m 27s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/341e4a9ffe744228b772eeabd0e65f4b : SUCCESS in 7m 26s\n- cinder-code-coverage https://zuul.opendev.org/t/openstack/build/26ed36171f4c479e94d924c9deb738fc : SUCCESS in 15m 54s (non-voting)\n- cinder-mypy https://zuul.opendev.org/t/openstack/build/14fd4f5c70564ee4a6d81b0f968bfdb5 : SUCCESS in 7m 41s\n- cinder-tox-bandit-baseline https://zuul.opendev.org/t/openstack/build/59dcda1f79c64aa7bbe40b218bf7cf5e : SUCCESS in 6m 48s (non-voting)\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/1d6c01a9793645c5affcc0428abdae89 : SUCCESS in 6m 02s\n- openstack-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/e5760da7128c41fb99f594e6b76406cc : SUCCESS in 6m 31s\n- cinder-rally-task https://zuul.opendev.org/t/openstack/build/c74e1c080e74496ab511055070b38e6a : SUCCESS in 37m 01s (non-voting)\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/f1b781973f584d25a075f663c809e690 : FAILURE in 6m 17s (non-voting)\n- cinder-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/6e2c5787b0044f4d8334fa40fc5d3c1d : SUCCESS in 1h 04m 50s\n- cinder-plugin-ceph-tempest-mn-aa https://zuul.opendev.org/t/openstack/build/33fbefb763774b4aad538d83e1c5f9a0 : FAILURE in 1h 39m 44s (non-voting)\n- cinder-tempest-plugin-lvm-lio-barbican https://zuul.opendev.org/t/openstack/build/30e1eccb1cdb4a10a866fc3b1b9fe41b : SUCCESS in 1h 42m 17s\n- cinder-grenade-mn-sub-volbak https://zuul.opendev.org/t/openstack/build/49ce7d6bc524407786d101d3e0ff24b4 : SUCCESS in 1h 05m 28s\n- cinder-tempest-lvm-multibackend https://zuul.opendev.org/t/openstack/build/41092d72aab943c4a8601eb4e236630e : SUCCESS in 1h 34m 11s (non-voting)\n- cinder-for-glance-optimized https://zuul.opendev.org/t/openstack/build/975f3173d91e435cac53122ba3cc0b44 : SUCCESS in 42m 10s (non-voting)\n- devstack-plugin-nfs-tempest-full https://zuul.opendev.org/t/openstack/build/683841896f6940deb7116406bdf8bd96 : SUCCESS in 1h 15m 36s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/f609bd3b2c67419ab79d1bceec4f1c00 : FAILURE in 1h 40m 22s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/1d365fd42c0d4a53af5be64c7decba5d : SUCCESS in 55m 59s\n- tempest-integrated-storage-ubuntu-focal https://zuul.opendev.org/t/openstack/build/d5a3a03e38ba4a8c8e24dbd1a312eb11 : SUCCESS in 1h 10m 02s","accounts_in_message":[],"_revision_number":2},{"id":"a7b3e2c18710aa06487f7342e5c8cdc6364262b9","author":{"_account_id":32912,"name":"Pure Storage Third-Party CI","display_name":"Pure Storage Third-Party CI","email":"openstack-third-party-ci@purestorage.com","username":"purestorage-thirdparty-ci","status":"Doing CI things"},"date":"2023-05-10 20:04:49.000000000","message":"Patch Set 2:\n\nBuild failed.\n\n- pure-devstack-cinder-tempest-iscsi-aio-jammy http://openstack-logs.purestorage.com/36/882836/2/thirdparty-check/pure-devstack-cinder-tempest-iscsi-aio-jammy/336fe2f/ : FAILURE in 1h 43m 14s\n- pure-devstack-cinder-tempest-fc-aio-jammy http://openstack-logs.purestorage.com/36/882836/2/thirdparty-check/pure-devstack-cinder-tempest-fc-aio-jammy/c29210c/ : SUCCESS in 2h 10m 03s (non-voting)\n- pure-devstack-cinder-tempest-nvme-roce-aio-jammy http://openstack-logs.purestorage.com/36/882836/2/thirdparty-check/pure-devstack-cinder-tempest-nvme-roce-aio-jammy/849d874/ : SUCCESS in 1h 52m 23s","accounts_in_message":[],"_revision_number":2},{"id":"8090ed81ede49e63c7b184cbf3e0d70b0b8c2984","author":{"_account_id":34318,"name":"HPE Nimble Storage CI","display_name":"HPE Nimble Storage CI","email":"raghavendra.tilay@capgemini.com","username":"hpe-nimble"},"date":"2023-05-10 20:13:39.000000000","message":"Patch Set 2:\n\nBuild failed.\n\n- iscsi-driver-alletra-6k https://hpe-storage.github.io/alletra-6k-ci-logs/logs/36/882836/2/check/iscsi-driver-alletra-6k/aa53e4c/aa53e4c.html : FAILURE in 2h 07m 08s","accounts_in_message":[],"_revision_number":2},{"id":"0c0423edffe638c5cd17d0e00a09ef9d1b797fca","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2023-05-10 20:27:30.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"156d83edf9215ad3afb3ab018370890c7931a91e","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-10 20:38:07.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/cf821d374f0b42b2877f6cc58c197c37\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/a400eef0eae2423d838b434171c93427 : SUCCESS in 9m 46s (non-voting)\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/7618e3cc6900483fbb68de0634c4bc2a : SUCCESS in 9m 06s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"23b10b75f0b97e673976619a76c157e28b597790","author":{"_account_id":28801,"name":"Cisco Cinder CI","email":"cisco-cinder-ci@cisco.com","username":"cisco-cinder-ci"},"date":"2023-05-10 20:45:02.000000000","message":"Patch Set 2:\n\nBuild failed.\nhttps://127.0.0.1:9000/t/openstack/buildset/dde0aefdc86745babb6102c8852cc837\n\n- dsvm-tempest-cisco-zonemanager-job https://127.0.0.1:9000/t/openstack/build/d084ad759ae74157b7a86aebbceb189b : POST_FAILURE in 14m 56s","accounts_in_message":[],"_revision_number":2},{"id":"a5c3e56a6f26cb73a39331b44d1936a523f7aa14","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-10 22:41:52.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ffff13f5e6e245279333c8b89d7adb7a\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/16e72129249c47988f1f524ed2b32585 : SUCCESS in 6m 09s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/fd93bd00abb748be8d1b3e76adf9151c : SUCCESS in 8m 45s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/171b47eb9516421c845427765e78005b : SUCCESS in 10m 33s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2ec30fa21fb84d63831b833d0091ad52 : SUCCESS in 11m 23s\n- grenade https://zuul.opendev.org/t/openstack/build/59b32a087d75493ba9b3260ea7d80807 : SUCCESS in 53m 45s\n- grenade-skip-level https://zuul.opendev.org/t/openstack/build/4b98395931034af3be737de8f704986d : FAILURE in 43m 25s (non-voting)\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/80fbe87a56a44ab5bba749a843751db4 : SUCCESS in 1h 25m 54s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/0197b6fac6cf4a838765c9769964dd5c : SUCCESS in 1h 09m 22s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/4eedf7e421df4d4180ef76788ad9c93a : SUCCESS in 8m 00s\n- cinder-code-coverage https://zuul.opendev.org/t/openstack/build/7b4fa1c3e672409cac4c1f664448f256 : SUCCESS in 17m 49s (non-voting)\n- cinder-mypy https://zuul.opendev.org/t/openstack/build/804d980e836841a3b86c99c1e6fb39c2 : SUCCESS in 5m 22s\n- cinder-tox-bandit-baseline https://zuul.opendev.org/t/openstack/build/32735c3be7e745ba918dca733793e310 : SUCCESS in 6m 57s (non-voting)\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/3e773879307c409bab5b384445d1bca4 : SUCCESS in 5m 46s\n- openstack-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/4271fc69bff140e2a4a00673bd5858c4 : SUCCESS in 5m 26s\n- cinder-rally-task https://zuul.opendev.org/t/openstack/build/98ffe2f2578b497f930aa506ab19fa03 : SUCCESS in 41m 18s (non-voting)\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/892608dd73304311a2741d649934c203 : FAILURE in 5m 50s (non-voting)\n- cinder-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/f2f88c587cb44c37b7e08266de2a3826 : SUCCESS in 1h 28m 39s\n- cinder-plugin-ceph-tempest-mn-aa https://zuul.opendev.org/t/openstack/build/16ca5728ae174cc0bb4b8609b4fe6a2c : FAILURE in 1h 33m 34s (non-voting)\n- cinder-tempest-plugin-lvm-lio-barbican https://zuul.opendev.org/t/openstack/build/23142854b3a54e8c859a42f26837eba8 : SUCCESS in 1h 33m 29s\n- cinder-grenade-mn-sub-volbak https://zuul.opendev.org/t/openstack/build/7fa75682f99a4278be9226ddd15420b9 : SUCCESS in 1h 07m 02s\n- cinder-tempest-lvm-multibackend https://zuul.opendev.org/t/openstack/build/9f1601682dff42519f90da07d74ed9de : SUCCESS in 1h 13m 47s (non-voting)\n- cinder-for-glance-optimized https://zuul.opendev.org/t/openstack/build/fd39ca78e4d74a51875659cbffb97beb : SUCCESS in 29m 15s (non-voting)\n- devstack-plugin-nfs-tempest-full https://zuul.opendev.org/t/openstack/build/e0e7ca0bd768433a94064eddb975ad6e : SUCCESS in 1h 18m 02s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/48ab294a71e84063b05b68f8d54f564a : SUCCESS in 1h 56m 56s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/a0dd568aac064a91ad44b9d9fb045323 : SUCCESS in 48m 55s\n- tempest-integrated-storage-ubuntu-focal https://zuul.opendev.org/t/openstack/build/d3225bd11a824f52a438f572739112a3 : SUCCESS in 1h 18m 02s","accounts_in_message":[],"_revision_number":2},{"id":"46c5512f53b8afdbcc870642a0305887553013bc","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2023-05-11 02:41:50.000000000","message":"Patch Set 2: Code-Review+2 Review-Priority+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"87ef29b6832ec2b92380dc76043bab01ba3e2383","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2023-05-11 10:47:31.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"ff98a4b0cd832ef6f540baaf5deb896782121eaa","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-11 10:48:06.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"ab94334207d63f79726f923b4a2aad9441ce8a18","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-11 12:17:00.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/081490f481484c559de7033059a78da3\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1ab69c8c555c48448b58b39fc14b3f29 : SUCCESS in 7m 10s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/5160e5b76bc24343a688b54706237897 : SUCCESS in 13m 36s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/c3fe285efe9a43eb8f3bd5a7d1b082c7 : SUCCESS in 11m 36s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6e5a8683f0a24a95925b0e8bd8f13386 : SUCCESS in 14m 43s\n- grenade https://zuul.opendev.org/t/openstack/build/400bbb8271a14a2f812417157d25df4c : SUCCESS in 1h 12m 53s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/8d2f120f12ff4f8da79a1c334435887e : SUCCESS in 1h 28m 12s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/8d7ed6ec71854f4fa8c4402b176d909a : SUCCESS in 1h 03m 02s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/5c11028a37694707a1376c74a0f8bdb5 : SUCCESS in 8m 41s\n- cinder-grenade-mn-sub-volbak https://zuul.opendev.org/t/openstack/build/0cff1bb884a24605bea56feecbc06a31 : SUCCESS in 1h 14m 04s\n- cinder-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/48dae5caf3eb43ff8d496c3d055500b3 : SUCCESS in 1h 16m 00s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/709ccdafeca04d15b03f848ca915f970 : SUCCESS in 52m 29s\n- tempest-integrated-storage-ubuntu-focal https://zuul.opendev.org/t/openstack/build/be9d4707c0fb4cf481d92893e51e26eb : SUCCESS in 1h 26m 39s","accounts_in_message":[],"_revision_number":2},{"id":"498f6e75ff8f3f9870823b083af416db783b36f6","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-11 12:17:00.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"29e967af0dfa17097277ffda0b08d6bf237607b2","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-11 12:18:33.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a803db70ad0541e593ae96fdc95889bf\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d05cce16e8564176a7e89020d61cbb47 : SUCCESS in 1m 12s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/1529d76972b542e69f2806dab6d01e9d : SUCCESS in 1m 02s","accounts_in_message":[],"_revision_number":2},{"id":"133a2c7c7125b767b9457f006c0a4df2dbe23088","author":{"_account_id":31868,"name":"Open-E CI","email":"open-e-ci-joviandss@open-e.com","username":"open-e-ci-joviandss","tags":["SERVICE_USER"]},"date":"2023-05-15 13:52:45.000000000","message":"Patch Set 2:\n\nBuild failed.\n\n- cinder-joviandss-driver-ci http://51.89.139.192/openstack/cinder/36/882836/2/ : RETRY_LIMIT in 8m 35s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"dd6010a9f7bf8cbe0189992f0848515321781747","revisions":{"93bce3fe9a733f6ca26d4ffb2fc9c1908eaf0e2b":{"kind":"REWORK","_number":1,"created":"2023-05-10 14:37:38.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/36/882836/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder","ref":"refs/changes/36/882836/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder refs/changes/36/882836/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder refs/changes/36/882836/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder refs/changes/36/882836/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder refs/changes/36/882836/1"}}},"commit":{"parents":[{"commit":"63e6dfdb081685e6955409082ed0fadd73b5166b","subject":"Update url of \"Unity Replication White Paper\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/63e6dfdb081685e6955409082ed0fadd73b5166b"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2023-02-16 14:57:15.000000000","tz":60},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2023-04-24 17:40:24.000000000","tz":120},"subject":"Reject unsafe delete attachment calls","message":"Reject unsafe delete attachment calls\n\nDue to how the Linux SCSI kernel driver works there are some storage\nsystems, such as iSCSI with shared targets, where a normal user can\naccess other projects\u0027 volume data connected to the same compute host\nusing the attachments REST API.\n\nThis affects both single and multi-pathed connections.\n\nTo prevent users from doing this, unintentionally or maliciously,\ncinder-api will now reject some delete attachment requests that are\ndeemed unsafe.\n\nCinder will process the delete attachment request normally in the\nfollowing cases:\n\n- The request comes from an OpenStack service that is sending the\n  service token that has one of the roles in `service_token_roles`.\n- Attachment doesn\u0027t have an instance_uuid value\n- The instance for the attachment doesn\u0027t exist in Nova\n- According to Nova the volume is not connected to the instance\n- Nova is not using this attachment record\n\nThere are 3 operations in the actions REST API endpoint that can be used\nfor an attack:\n\n- `os-terminate_connection`: Terminate volume attachment\n- `os-detach`: Detach a volume\n- `os-force_detach`: Force detach a volume\n\nIn this endpoint we just won\u0027t allow most requests not coming from a\nservice. The rules we apply are the same as for attachment delete\nexplained earlier, but in this case we may not have the attachment id\nand be more restrictive.  This should not be a problem for normal\noperations because:\n\n- Cinder backup doesn\u0027t use the REST API but RPC calls via RabbitMQ\n- Glance doesn\u0027t use this interface\n\nChecking whether it\u0027s a service or not is done at the cinder-api level\nby checking that the service user that made the call has at least one of\nthe roles in the `service_token_roles` configuration. These roles are\nretrieved from keystone by the keystone middleware using the value of\nthe \"X-Service-Token\" header.\n\nIf Cinder is configured with `service_token_roles_required \u003d true` and\nan attacker provides non-service valid credentials the service will\nreturn a 401 error, otherwise it\u0027ll return 409 as if a normal user had\nmade the call without the service token.\n\nCloses-Bug: #2004555\nChange-Id: I612905a1bf4a1706cce913c0d8a6df7a240d599a\n(cherry picked from commit 71c6bdfb9a6728622156bde4694aa4707b56f40b)\nConflicts:\n\tcinder/exception.py\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/93bce3fe9a733f6ca26d4ffb2fc9c1908eaf0e2b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/93bce3fe9a733f6ca26d4ffb2fc9c1908eaf0e2b"}]},"branch":"refs/heads/stable/2023.1"},"dd6010a9f7bf8cbe0189992f0848515321781747":{"kind":"REWORK","_number":2,"created":"2023-05-10 17:53:49.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/36/882836/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder","ref":"refs/changes/36/882836/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder refs/changes/36/882836/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder refs/changes/36/882836/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder refs/changes/36/882836/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder refs/changes/36/882836/2"}}},"commit":{"parents":[{"commit":"63e6dfdb081685e6955409082ed0fadd73b5166b","subject":"Update url of \"Unity Replication White Paper\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/63e6dfdb081685e6955409082ed0fadd73b5166b"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2023-02-16 14:57:15.000000000","tz":60},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2023-05-10 17:52:39.000000000","tz":120},"subject":"Reject unsafe delete attachment calls","message":"Reject unsafe delete attachment calls\n\nDue to how the Linux SCSI kernel driver works there are some storage\nsystems, such as iSCSI with shared targets, where a normal user can\naccess other projects\u0027 volume data connected to the same compute host\nusing the attachments REST API.\n\nThis affects both single and multi-pathed connections.\n\nTo prevent users from doing this, unintentionally or maliciously,\ncinder-api will now reject some delete attachment requests that are\ndeemed unsafe.\n\nCinder will process the delete attachment request normally in the\nfollowing cases:\n\n- The request comes from an OpenStack service that is sending the\n  service token that has one of the roles in `service_token_roles`.\n- Attachment doesn\u0027t have an instance_uuid value\n- The instance for the attachment doesn\u0027t exist in Nova\n- According to Nova the volume is not connected to the instance\n- Nova is not using this attachment record\n\nThere are 3 operations in the actions REST API endpoint that can be used\nfor an attack:\n\n- `os-terminate_connection`: Terminate volume attachment\n- `os-detach`: Detach a volume\n- `os-force_detach`: Force detach a volume\n\nIn this endpoint we just won\u0027t allow most requests not coming from a\nservice. The rules we apply are the same as for attachment delete\nexplained earlier, but in this case we may not have the attachment id\nand be more restrictive.  This should not be a problem for normal\noperations because:\n\n- Cinder backup doesn\u0027t use the REST API but RPC calls via RabbitMQ\n- Glance doesn\u0027t use this interface\n\nChecking whether it\u0027s a service or not is done at the cinder-api level\nby checking that the service user that made the call has at least one of\nthe roles in the `service_token_roles` configuration. These roles are\nretrieved from keystone by the keystone middleware using the value of\nthe \"X-Service-Token\" header.\n\nIf Cinder is configured with `service_token_roles_required \u003d true` and\nan attacker provides non-service valid credentials the service will\nreturn a 401 error, otherwise it\u0027ll return 409 as if a normal user had\nmade the call without the service token.\n\nCloses-Bug: #2004555\nChange-Id: I612905a1bf4a1706cce913c0d8a6df7a240d599a\n(cherry picked from commit 6df1839bdf288107c600b3e53dff7593a6d4c161)\nConflicts:\n\tcinder/exception.py\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/dd6010a9f7bf8cbe0189992f0848515321781747"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/dd6010a9f7bf8cbe0189992f0848515321781747"}]},"branch":"refs/heads/stable/2023.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}},{"label":"Review-Priority","status":"MAY","applied_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}