)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"864d2e68287141bc8ff267dcdfee2e570d39dc58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"14a072ba_75362d88","updated":"2023-05-31 09:37:00.000000000","message":"cinder-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/7309c0fd9fd64dfdaa0d301187d1cd9e : TIMED_OUT in 2h 03m 29s","commit_id":"db79d91c42dfe122d69682a16b7eb3ba9d77ca64"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"60e2442c17d367998a0f3401a4cf0d069f74d10e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a363fb91_42dbd13b","updated":"2023-05-31 09:37:05.000000000","message":"recheck","commit_id":"db79d91c42dfe122d69682a16b7eb3ba9d77ca64"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"607bb4fa42f732214455b4432cb8f016783df5a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d031b936_4134d8c0","updated":"2023-06-12 08:56:48.000000000","message":"recheck","commit_id":"db79d91c42dfe122d69682a16b7eb3ba9d77ca64"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"c738124d6a85caaae5f2f3feb37e05608b7f4f88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2e1cb593_5f7dd219","updated":"2023-06-16 12:01:59.000000000","message":"recheck","commit_id":"d4c03baf9d6a6cccd079b1d81930b7a452669c3a"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"dc65dd74891f3587812f8bfe10a552711e344b45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"aaced6fc_a83514b8","updated":"2023-06-20 08:20:32.000000000","message":"Zuul fails with \n`AssertionError: Timed out waiting for 10.1.0.26 to become reachable from 172.24.5.46`","commit_id":"4ab1c91f63512096e122c1e3c90d2bc7f03a6504"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4ada410766d679762e316eedbb69f2cc7744c639","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e4e89b09_f79c7c71","updated":"2023-06-20 13:06:59.000000000","message":"recheck","commit_id":"4ab1c91f63512096e122c1e3c90d2bc7f03a6504"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"84093d44acd7ed779cc4aafc3003757860353d57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3453bd1c_8c1f5660","updated":"2023-06-20 08:20:50.000000000","message":"recheck tempest-slow-py3","commit_id":"4ab1c91f63512096e122c1e3c90d2bc7f03a6504"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8f3b03e6b0c132f9875511edbc0dc815f366162d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f8f17eb1_5268b175","updated":"2023-09-29 22:05:33.000000000","message":"LGTM.  Raising the priority because this needs to be backported to catch up with the earlier patch.","commit_id":"becf45c6cb5660fae59efe9c92ec7ebff0fcbce2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"58ee702dc879aab31860b2eb556ae77ceb3bf444","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7e092a08_7806a4ef","updated":"2023-10-02 18:03:08.000000000","message":"Needs to be backported to 2023.2 to catch up to Iff8e1e90ab3c7b519819577ec3aafff838e6934f","commit_id":"becf45c6cb5660fae59efe9c92ec7ebff0fcbce2"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"f9b7723a9c54642a7c60ab2d98da499c0d35ed68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"77097258_6831d279","updated":"2023-10-02 16:24:35.000000000","message":"This change looks good to me.  There are only two small things I would\nhave liked to see:\n\n  * A reference to the format change so we can see when and the nature\n    of the format change.  It\u0027s always nice to see the change that\n    precipitated this change.\n\n  * In the test, in additional to checking the call count, it would be\n    cool to verify the base name string so that it\u0027s explicit\n\nBoth minor, I don\u0027t think that\u0027s enough to hold up the patch, it\u0027s\nimportant.","commit_id":"becf45c6cb5660fae59efe9c92ec7ebff0fcbce2"}],"cinder/backup/drivers/ceph.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c160e14fba770555c4dde45ac4550bfa8965dee7","unresolved":true,"context_lines":[{"line_number":1125,"context_line":"                # This approach ensures backward compatibility and makes it"},{"line_number":1126,"context_line":"                # possible to restore older backups that were created before"},{"line_number":1127,"context_line":"                # the change."},{"line_number":1128,"context_line":"                msg \u003d (_(\"Failed to find backup %(backup_id)s of volume \""},{"line_number":1129,"context_line":"                         \"%(volume_id)s.\") % {\u0027backup_id\u0027: backup.id,"},{"line_number":1130,"context_line":"                                              \u0027volume_id\u0027: backup.volume_id})"},{"line_number":1131,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"e9db5a0f_61f9a9aa","line":1128,"updated":"2023-06-20 14:37:25.000000000","message":"This message as an ERROR in the log will read like this operation failed, but it hasn\u0027t yet.  It should probably indicate that another attempt will be made.","commit_id":"4ab1c91f63512096e122c1e3c90d2bc7f03a6504"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"fbc8d7057cf3e54c8c0973ddd9837872fb953722","unresolved":false,"context_lines":[{"line_number":1125,"context_line":"                # This approach ensures backward compatibility and makes it"},{"line_number":1126,"context_line":"                # possible to restore older backups that were created before"},{"line_number":1127,"context_line":"                # the change."},{"line_number":1128,"context_line":"                msg \u003d (_(\"Failed to find backup %(backup_id)s of volume \""},{"line_number":1129,"context_line":"                         \"%(volume_id)s.\") % {\u0027backup_id\u0027: backup.id,"},{"line_number":1130,"context_line":"                                              \u0027volume_id\u0027: backup.volume_id})"},{"line_number":1131,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"8c86a4d6_0487557f","line":1128,"in_reply_to":"e9db5a0f_61f9a9aa","updated":"2023-08-25 21:15:38.000000000","message":"Done\n\nI combined it with the next message, for a couple of reasons.\nFirst, I don\u0027t like when two messages always go together - at different levels even.\nSecond, the word \"diff\" may confuse someone into thinking it\u0027s about the differential restore, while this one is still a full restore.","commit_id":"4ab1c91f63512096e122c1e3c90d2bc7f03a6504"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c160e14fba770555c4dde45ac4550bfa8965dee7","unresolved":true,"context_lines":[{"line_number":1138,"context_line":"                LOG.info(\"Attempting to restore from diff base backup: \""},{"line_number":1139,"context_line":"                         \"%(backup_name)s.\", {\u0027backup_name\u0027: backup_name})"},{"line_number":1140,"context_line":""},{"line_number":1141,"context_line":"                src_rbd \u003d eventlet.tpool.Proxy(self.rbd.Image(client.ioctx,"},{"line_number":1142,"context_line":"                                                              backup_name,"},{"line_number":1143,"context_line":"                                                              snapshot\u003d_src,"},{"line_number":1144,"context_line":"                                                              read_only\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":5,"id":"b11759b2_528184ca","line":1141,"updated":"2023-06-20 14:37:25.000000000","message":"What happens if this call fails with ImageNotFound?","commit_id":"4ab1c91f63512096e122c1e3c90d2bc7f03a6504"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"fbc8d7057cf3e54c8c0973ddd9837872fb953722","unresolved":false,"context_lines":[{"line_number":1138,"context_line":"                LOG.info(\"Attempting to restore from diff base backup: \""},{"line_number":1139,"context_line":"                         \"%(backup_name)s.\", {\u0027backup_name\u0027: backup_name})"},{"line_number":1140,"context_line":""},{"line_number":1141,"context_line":"                src_rbd \u003d eventlet.tpool.Proxy(self.rbd.Image(client.ioctx,"},{"line_number":1142,"context_line":"                                                              backup_name,"},{"line_number":1143,"context_line":"                                                              snapshot\u003d_src,"},{"line_number":1144,"context_line":"                                                              read_only\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":5,"id":"9456707b_4cb17162","line":1141,"in_reply_to":"3e067289_d1a2cf3e","updated":"2023-08-25 21:15:38.000000000","message":"Done, kinda.\n\nI went with a nested exception for simplicity.\n\nAlso, to Eric\u0027s question: there\u0027s no change with the previous behavior. It is checked with the test cinder.tests.unit.backup.drivers.test_backup_ceph.BackupCephTestCase.test_full_restore_with_image_not_found\nI tinkered with options that caught those exceptions and raised exception.BackupOperationError(), it seemed like work for no gain, so I left it how Sofia wrote it.","commit_id":"4ab1c91f63512096e122c1e3c90d2bc7f03a6504"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"1bcb41de15d833d7fc617ceff5e32986730ea8cc","unresolved":true,"context_lines":[{"line_number":1138,"context_line":"                LOG.info(\"Attempting to restore from diff base backup: \""},{"line_number":1139,"context_line":"                         \"%(backup_name)s.\", {\u0027backup_name\u0027: backup_name})"},{"line_number":1140,"context_line":""},{"line_number":1141,"context_line":"                src_rbd \u003d eventlet.tpool.Proxy(self.rbd.Image(client.ioctx,"},{"line_number":1142,"context_line":"                                                              backup_name,"},{"line_number":1143,"context_line":"                                                              snapshot\u003d_src,"},{"line_number":1144,"context_line":"                                                              read_only\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":5,"id":"3e067289_d1a2cf3e","line":1141,"in_reply_to":"b11759b2_528184ca","updated":"2023-06-20 17:37:12.000000000","message":"Should fail with a more descriptive message instead of ImageNotFound","commit_id":"4ab1c91f63512096e122c1e3c90d2bc7f03a6504"}]}