)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"8d95f235b1003772f5a3665d4e2b522b4a06aa0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"516af372_052d25a8","updated":"2023-06-08 19:11:33.000000000","message":"Please check Zuul as it\u0027s reporting failures.","commit_id":"0bb67e4c1302464dc327b4ba6579242ab11f26f8"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"5927caf6f9dc460c9762cefb85eb05a95dc0a997","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1a67635d_a924d046","updated":"2023-06-02 05:26:24.000000000","message":"Since this patch resolves bug, a release note would be required.\nhttps://docs.openstack.org/reno/latest/user/usage.html","commit_id":"0bb67e4c1302464dc327b4ba6579242ab11f26f8"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"174de120736019bf1797dfab252e3dec5cb00aaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b274d920_864b8c30","updated":"2023-06-12 10:22:38.000000000","message":"recheck","commit_id":"0bb67e4c1302464dc327b4ba6579242ab11f26f8"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"b56495e69e67a677c3bab3ca8171503354d72f95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"26324546_ad30354f","updated":"2023-06-30 12:37:28.000000000","message":"Code change looks ok. \nHowever to resolve \"Merge Conflict\", a rebase may be required.","commit_id":"27b851a01f2d45d7e3bae495fd5e946707d313fc"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"2fe2f22a00faba8180fa4a09e2d9b003c34001b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e9c99adc_77bd0625","updated":"2023-06-27 14:10:03.000000000","message":"LGTM good job","commit_id":"27b851a01f2d45d7e3bae495fd5e946707d313fc"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"52ef9f273dfac0e9a6d164efc6525fa8a0d37985","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d9474445_f8769f66","updated":"2023-06-28 11:25:59.000000000","message":"LGTM, thanks for working on this!","commit_id":"27b851a01f2d45d7e3bae495fd5e946707d313fc"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"5445fe323fed52c6608fa762f6ec5f5bd0c9f3a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cfaa8f31_171a4250","updated":"2023-06-27 14:02:32.000000000","message":"Looks good to me, waiting for CI to pass.","commit_id":"27b851a01f2d45d7e3bae495fd5e946707d313fc"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"a12ab78b96f7799e68cf1ab0e63fc03903f9ed19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"629b076d_336467b7","updated":"2023-06-22 14:15:05.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"27b851a01f2d45d7e3bae495fd5e946707d313fc"},{"author":{"_account_id":17450,"name":"Chongchong Lei","email":"Nathaniel.Lei@dell.com","username":"Chongchong","status":"Dell EMC"},"change_message_id":"065050c66b43599844cde6e755232aecf53cf95e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"11f55c20_8d56cbf4","updated":"2023-06-21 01:41:12.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"27b851a01f2d45d7e3bae495fd5e946707d313fc"},{"author":{"_account_id":17450,"name":"Chongchong Lei","email":"Nathaniel.Lei@dell.com","username":"Chongchong","status":"Dell EMC"},"change_message_id":"3a42f2f23c784180e08579573f0debdd60cc81fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6cce12f2_41d10732","updated":"2023-06-21 10:11:46.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"27b851a01f2d45d7e3bae495fd5e946707d313fc"},{"author":{"_account_id":17450,"name":"Chongchong Lei","email":"Nathaniel.Lei@dell.com","username":"Chongchong","status":"Dell EMC"},"change_message_id":"492e362c955e924378f7de04f267c68b32b23f14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8009f02d_7ddcafd5","updated":"2023-06-21 10:04:41.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"27b851a01f2d45d7e3bae495fd5e946707d313fc"},{"author":{"_account_id":24005,"name":"prashkre","email":"prashkre@in.ibm.com","username":"prashkre"},"change_message_id":"3ca29116a488b6b896ec535388867712ed0945e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1e87f423_d92d98ef","updated":"2023-07-25 17:41:51.000000000","message":"@Eric Harney: please review my comments and change-set again.","commit_id":"9ac0b2f8465b9e24a48b3dc336ac37545f08bf00"},{"author":{"_account_id":24005,"name":"prashkre","email":"prashkre@in.ibm.com","username":"prashkre"},"change_message_id":"5a312a2b015aa83c20d7d148248c287e2b040a4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0abd0239_10f18993","updated":"2023-07-10 16:00:43.000000000","message":"@Tony Saad, @happystacker: please review the change-set.","commit_id":"9ac0b2f8465b9e24a48b3dc336ac37545f08bf00"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"e1f4542636c15756867c533fe5ef94fbd9a55284","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9a6d1943_348894b9","updated":"2023-07-10 16:08:06.000000000","message":"Rebase looks good","commit_id":"9ac0b2f8465b9e24a48b3dc336ac37545f08bf00"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6686664bdf281fbc9bc3b0ef380ec8934219fdc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"25d8a680_8c06ff1a","updated":"2024-12-10 15:42:53.000000000","message":"See comment inline.","commit_id":"9ac0b2f8465b9e24a48b3dc336ac37545f08bf00"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"553656180e90f1ae7ce9cc8ef6eb1f65c7c811e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4ee76415_29c677da","updated":"2023-12-06 13:37:24.000000000","message":"The change looks consistent to me. Thank you","commit_id":"9ac0b2f8465b9e24a48b3dc336ac37545f08bf00"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a8c165d6161192e408543c87353d13ed5d08e4db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9f6bfaa2_533407a9","updated":"2024-12-05 15:51:06.000000000","message":"few questions inline","commit_id":"9ac0b2f8465b9e24a48b3dc336ac37545f08bf00"},{"author":{"_account_id":24005,"name":"prashkre","email":"prashkre@in.ibm.com","username":"prashkre"},"change_message_id":"c6e0a463aa64abb8da1ea09ee88b0c2897258ab6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2006578c_b6b27ad8","updated":"2023-07-06 14:23:53.000000000","message":"recheck","commit_id":"9ac0b2f8465b9e24a48b3dc336ac37545f08bf00"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"bf1cfc013e372b6ce72b60a44134580082216ea9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"82db113d_0a5b8990","updated":"2023-07-03 04:22:13.000000000","message":"recheck cinder-grenade-mn-sub-volbak","commit_id":"9ac0b2f8465b9e24a48b3dc336ac37545f08bf00"},{"author":{"_account_id":24005,"name":"prashkre","email":"prashkre@in.ibm.com","username":"prashkre"},"change_message_id":"a45d9110e24e587bf4e404e84c1b682d047c1b5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"733e32af_21fd4ec8","updated":"2023-07-04 17:31:56.000000000","message":"recheck cinder-plugin-ceph-tempest cinder-grenade-mn-sub-volbak tempest-slow-py3","commit_id":"9ac0b2f8465b9e24a48b3dc336ac37545f08bf00"},{"author":{"_account_id":24005,"name":"prashkre","email":"prashkre@in.ibm.com","username":"prashkre"},"change_message_id":"42562def0e6442fbd58fe030a5114e91076221c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6baff072_aa5a7e51","updated":"2023-07-06 18:31:34.000000000","message":"recheck tempest-integrated-storage","commit_id":"9ac0b2f8465b9e24a48b3dc336ac37545f08bf00"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c42d5e34ec35491e6e412c81453e5a03decc49bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"37bf7149_28399c93","updated":"2023-07-03 10:18:24.000000000","message":"recheck tempest-integrated-storage cinder-plugin-ceph-tempest","commit_id":"9ac0b2f8465b9e24a48b3dc336ac37545f08bf00"},{"author":{"_account_id":24005,"name":"prashkre","email":"prashkre@in.ibm.com","username":"prashkre"},"change_message_id":"4edadebacf3dccde5ccf231c0140042f3aaccb17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8e5b7d9c_edef851f","updated":"2023-07-05 03:05:11.000000000","message":"recheck tempest-integrated-storage cinder-plugin-ceph-tempest","commit_id":"9ac0b2f8465b9e24a48b3dc336ac37545f08bf00"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"ecadea94c44130d067bec3a93ef6074682329c70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7be4138d_e5f2891e","updated":"2023-07-06 22:21:58.000000000","message":"run-TOYOU TYDS CI","commit_id":"9ac0b2f8465b9e24a48b3dc336ac37545f08bf00"}],"cinder/volume/drivers/dell_emc/powermax/masking.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a8c165d6161192e408543c87353d13ed5d08e4db","unresolved":true,"context_lines":[{"line_number":1449,"context_line":"                      \"%(sg_name)s\", {\u0027sg_name\u0027: storagegroup_name})"},{"line_number":1450,"context_line":""},{"line_number":1451,"context_line":"            @coordination.synchronized(\"emc-sg-{sg_name}-{serial_number}\")"},{"line_number":1452,"context_line":"            @coordination.synchronized(\"emc-sg-rm-or-mv-{device_id}-{sg_name}-\""},{"line_number":1453,"context_line":"                                       \"{serial_number}\")"},{"line_number":1454,"context_line":"            def do_remove_volume_from_sg(sg_name, serial_number, device_id):"},{"line_number":1455,"context_line":"                # Make sure volume hasn\u0027t been recently removed from the sg"}],"source_content_type":"text/x-python","patch_set":6,"id":"9c7dfe4e_93937a37","line":1452,"range":{"start_line":1452,"start_character":57,"end_line":1452,"end_character":66},"updated":"2024-12-05 15:51:06.000000000","message":"the addition to these locks seems to be the ``device_id``\nWhat is strange to me is that we already have acquired the device_id lock in it\u0027s caller method\n\n    @coordination.synchronized(\"emc-vol-{device_id}\")\n    remove_and_reset_members()\n\nSo the calls are happening like:\n\n    remove_and_reset_members -\u003e acquires the device_id lock\n    |-\u003e _cleanup_deletion\n        |-\u003e remove_volume_from_sg\n            |-\u003e do_remove_volume_from_sg -\u003e acquires lock with serial_number + sg_name + device_id\n        \nWe should reassess these locking strategies here since more locks might lead to more problems with deadlocking or performance.","commit_id":"9ac0b2f8465b9e24a48b3dc336ac37545f08bf00"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6686664bdf281fbc9bc3b0ef380ec8934219fdc7","unresolved":true,"context_lines":[{"line_number":1487,"context_line":"            parent_sg_name \u003d self.rest.get_element_from_masking_view("},{"line_number":1488,"context_line":"                serial_number, masking_name, storagegroup\u003dTrue)"},{"line_number":1489,"context_line":""},{"line_number":1490,"context_line":"            @coordination.synchronized(\"emc-mv-{parent_name}-{serial_number}\")"},{"line_number":1491,"context_line":"            @coordination.synchronized(\"emc-mv-{mv_name}-{serial_number}\")"},{"line_number":1492,"context_line":"            @coordination.synchronized(\"emc-sg-{sg_name}-{serial_number}\")"},{"line_number":1493,"context_line":"            @coordination.synchronized(\"emc-sg-rm-or-mv-{device_id}-{sg_name}-\""}],"source_content_type":"text/x-python","patch_set":6,"id":"a2739327_22bc4766","line":1490,"updated":"2024-12-10 15:42:53.000000000","message":"I really don\u0027t like to see the decorators stacked like this.  I think Eric pointed out somewhere that we need to be careful about the ordering.  The decorator allows you to list multiple lock names.  See:\nhttps://opendev.org/openstack/cinder/src/commit/02980528fbc30edc733c9e8bb3779ccbfd6eb257/cinder/coordination.py#L204-L210\n\nand take a look at https://review.opendev.org/c/openstack/cinder/+/848900 to see a bug that occurred because of a decorator ordering problem.","commit_id":"9ac0b2f8465b9e24a48b3dc336ac37545f08bf00"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a8c165d6161192e408543c87353d13ed5d08e4db","unresolved":true,"context_lines":[{"line_number":1490,"context_line":"            @coordination.synchronized(\"emc-mv-{parent_name}-{serial_number}\")"},{"line_number":1491,"context_line":"            @coordination.synchronized(\"emc-mv-{mv_name}-{serial_number}\")"},{"line_number":1492,"context_line":"            @coordination.synchronized(\"emc-sg-{sg_name}-{serial_number}\")"},{"line_number":1493,"context_line":"            @coordination.synchronized(\"emc-sg-rm-or-mv-{device_id}-{sg_name}-\""},{"line_number":1494,"context_line":"                                       \"{serial_number}\")"},{"line_number":1495,"context_line":"            def do_remove_volume_from_sg("},{"line_number":1496,"context_line":"                    mv_name, sg_name, parent_name, serial_number, device_id):"},{"line_number":1497,"context_line":"                # Make sure volume hasn\u0027t been recently removed from the sg"}],"source_content_type":"text/x-python","patch_set":6,"id":"253710c8_c6d47052","line":1494,"range":{"start_line":1493,"start_character":56,"end_line":1494,"end_character":55},"updated":"2024-12-05 15:51:06.000000000","message":"are we trying to acquire locks in a hierarchy to narrow down the lock?\nserial_number -\u003e sg_name -\u003e device_id","commit_id":"9ac0b2f8465b9e24a48b3dc336ac37545f08bf00"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"cb668fbd59625152871462618f8bf227c2215867","unresolved":true,"context_lines":[{"line_number":1811,"context_line":"                                       \"{default_sg_name}-{serial_number}\","},{"line_number":1812,"context_line":"                                       blocking\u003dFalse)"},{"line_number":1813,"context_line":"            @coordination.synchronized("},{"line_number":1814,"context_line":"                \"emc-sg-{default_sg_name}-{serial_number}\")"},{"line_number":1815,"context_line":"            def _move_vol_to_default_sg(default_sg_name, serial_number,"},{"line_number":1816,"context_line":"                                        device_id):"},{"line_number":1817,"context_line":"                self.rest.move_volume_between_storage_groups("}],"source_content_type":"text/x-python","patch_set":6,"id":"482ccf20_fe159d35","line":1814,"range":{"start_line":1814,"start_character":24,"end_line":1814,"end_character":41},"updated":"2023-07-11 18:12:19.000000000","message":"Is default_sg_name here ever the same as sg_name on line 1451 or 1492?  Wondering if there is a potential for deadlock here due to the same locks being acquired in a different order.","commit_id":"9ac0b2f8465b9e24a48b3dc336ac37545f08bf00"},{"author":{"_account_id":24005,"name":"prashkre","email":"prashkre@in.ibm.com","username":"prashkre"},"change_message_id":"f1e0ca2e8387629396b8422aa06d81bc94052559","unresolved":false,"context_lines":[{"line_number":1811,"context_line":"                                       \"{default_sg_name}-{serial_number}\","},{"line_number":1812,"context_line":"                                       blocking\u003dFalse)"},{"line_number":1813,"context_line":"            @coordination.synchronized("},{"line_number":1814,"context_line":"                \"emc-sg-{default_sg_name}-{serial_number}\")"},{"line_number":1815,"context_line":"            def _move_vol_to_default_sg(default_sg_name, serial_number,"},{"line_number":1816,"context_line":"                                        device_id):"},{"line_number":1817,"context_line":"                self.rest.move_volume_between_storage_groups("}],"source_content_type":"text/x-python","patch_set":6,"id":"69ff7a8b_869ef784","line":1814,"range":{"start_line":1814,"start_character":24,"end_line":1814,"end_character":41},"in_reply_to":"482ccf20_fe159d35","updated":"2023-07-12 08:19:17.000000000","message":"When default_sg_name is same as sg_name, deadlock happened while taking lock here after holding the lock at lines 1451 or 1492 in the same request flow, to avoid this we are taking an extra non-blocking lock(blocking\u003dFalse) here with device_id to make sure that deadlock never happens.","commit_id":"9ac0b2f8465b9e24a48b3dc336ac37545f08bf00"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"cd5ce5e6a11b8408ec58077f9eac00778e6c6e21","unresolved":true,"context_lines":[{"line_number":1807,"context_line":"            rep_enabled, rep_mode)"},{"line_number":1808,"context_line":"        if src_sg is not None:"},{"line_number":1809,"context_line":"            # Need to lock the default storage group"},{"line_number":1810,"context_line":"            @coordination.synchronized(\"emc-sg-rm-or-mv-{device_id}-\""},{"line_number":1811,"context_line":"                                       \"{default_sg_name}-{serial_number}\","},{"line_number":1812,"context_line":"                                       blocking\u003dFalse)"},{"line_number":1813,"context_line":"            @coordination.synchronized("},{"line_number":1814,"context_line":"                \"emc-sg-{default_sg_name}-{serial_number}\")"},{"line_number":1815,"context_line":"            def _move_vol_to_default_sg(default_sg_name, serial_number,"},{"line_number":1816,"context_line":"                                        device_id):"},{"line_number":1817,"context_line":"                self.rest.move_volume_between_storage_groups("},{"line_number":1818,"context_line":"                    serial_number, device_id, src_sg,"},{"line_number":1819,"context_line":"                    default_sg_name, extra_specs, force\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"15aca904_3736b959","line":1816,"range":{"start_line":1810,"start_character":0,"end_line":1816,"end_character":51},"updated":"2024-12-06 07:00:45.000000000","message":"Within the \u0027device_id\u0027 lock, the availability of {device_id}-{sg_name}-{serial_number} is equivalent to {sg_name}-{serial_number}, while {device_id}-\n{default_sg_name}-{serial_number} is equivalent to {default_sg_name}-{serial_number}.\n\nThe deadlock happened when {sg_name} was same as {default_sg_name}. Above `do_remove_volume_from_sg` acquired {sg_name}-{serial_number}. And here `_move_vol_to_default_sg` tried to acquire the same {default_sg_name}-{serial_number} again.\n\nThis patch adds {device_id}-{default_sg_name}-{serial_number} as a non-blocking lock at Line 1812, before the lock \u0027{default_sg_name}-{serial_number}\u0027. It expects once `_move_vol_to_default_sg` can\u0027t acquire {device_id}-{default_sg_name}, it raises \u0027LockAcquireFailed\u0027 exception, instead of a deadlock.","commit_id":"9ac0b2f8465b9e24a48b3dc336ac37545f08bf00"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a8c165d6161192e408543c87353d13ed5d08e4db","unresolved":true,"context_lines":[{"line_number":1820,"context_line":"            try:"},{"line_number":1821,"context_line":"                _move_vol_to_default_sg("},{"line_number":1822,"context_line":"                    storagegroup_name, serial_number, device_id)"},{"line_number":1823,"context_line":"            except t_coordination.LockAcquireFailed:"},{"line_number":1824,"context_line":"                LOG.info(\"Lock acquired failed, moving volume \""},{"line_number":1825,"context_line":"                         \"without lock on device_id: %(device_id)s.\", dict("},{"line_number":1826,"context_line":"                             device_id\u003ddevice_id))"},{"line_number":1827,"context_line":"                self.rest.move_volume_between_storage_groups("},{"line_number":1828,"context_line":"                    serial_number, device_id, src_sg,"},{"line_number":1829,"context_line":"                    storagegroup_name, extra_specs, force\u003dTrue)"},{"line_number":1830,"context_line":"        else:"},{"line_number":1831,"context_line":"            self._check_adding_volume_to_storage_group("},{"line_number":1832,"context_line":"                serial_number, device_id, storagegroup_name, volume_name,"}],"source_content_type":"text/x-python","patch_set":6,"id":"108e079d_7d03c1c7","line":1829,"range":{"start_line":1823,"start_character":12,"end_line":1829,"end_character":63},"updated":"2024-12-05 15:51:06.000000000","message":"This is really strange, if we require locks in the first place to perform this, why are we still performing it if we fail to acquire the lock?","commit_id":"9ac0b2f8465b9e24a48b3dc336ac37545f08bf00"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"cd5ce5e6a11b8408ec58077f9eac00778e6c6e21","unresolved":true,"context_lines":[{"line_number":1824,"context_line":"                LOG.info(\"Lock acquired failed, moving volume \""},{"line_number":1825,"context_line":"                         \"without lock on device_id: %(device_id)s.\", dict("},{"line_number":1826,"context_line":"                             device_id\u003ddevice_id))"},{"line_number":1827,"context_line":"                self.rest.move_volume_between_storage_groups("},{"line_number":1828,"context_line":"                    serial_number, device_id, src_sg,"},{"line_number":1829,"context_line":"                    storagegroup_name, extra_specs, force\u003dTrue)"},{"line_number":1830,"context_line":"        else:"},{"line_number":1831,"context_line":"            self._check_adding_volume_to_storage_group("},{"line_number":1832,"context_line":"                serial_number, device_id, storagegroup_name, volume_name,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1367c5b9_acd7e2f3","line":1829,"range":{"start_line":1827,"start_character":0,"end_line":1829,"end_character":63},"updated":"2024-12-06 07:00:45.000000000","message":"When \u0027src_sg\u0027 is same as \u0027storagegroup_name\u0027, the restcall returns error code 500, as the volume is already in the target sg.","commit_id":"9ac0b2f8465b9e24a48b3dc336ac37545f08bf00"}]}