)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5274d44bff57a083036c7bb6dbbaa6d77c14b600","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     raghavendrat \u003craghavendra-uddhav.tilay@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-06-08 14:35:07 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"HPE: Fix err during retype of vol without comment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On HPE 3par array, for volumes .. the comment section can be empty."},{"line_number":10,"context_line":"During retype of such volumes, below error is observed:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"983c97ea_13e8d56f","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":12},"updated":"2023-07-12 12:00:36.000000000","message":"nit: error","commit_id":"e0667c3bfb8310259f344c755cf77937ccf152b8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5274d44bff57a083036c7bb6dbbaa6d77c14b600","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     raghavendrat \u003craghavendra-uddhav.tilay@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-06-08 14:35:07 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"HPE: Fix err during retype of vol without comment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On HPE 3par array, for volumes .. the comment section can be empty."},{"line_number":10,"context_line":"During retype of such volumes, below error is observed:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6ccf74ec_756db934","line":7,"range":{"start_line":7,"start_character":30,"end_line":7,"end_character":33},"updated":"2023-07-12 12:00:36.000000000","message":"nit: volume","commit_id":"e0667c3bfb8310259f344c755cf77937ccf152b8"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c81b93a77a71e7317003e9ac3437d1bc7da5e40f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     raghavendrat \u003craghavendra-uddhav.tilay@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-06-08 14:35:07 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"HPE: Fix err during retype of vol without comment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On HPE 3par array, for volumes .. the comment section can be empty."},{"line_number":10,"context_line":"During retype of such volumes, below error is observed:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"31b5c884_ba0611eb","line":7,"range":{"start_line":7,"start_character":30,"end_line":7,"end_character":33},"in_reply_to":"6ccf74ec_756db934","updated":"2023-07-13 12:20:19.000000000","message":"Done","commit_id":"e0667c3bfb8310259f344c755cf77937ccf152b8"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c81b93a77a71e7317003e9ac3437d1bc7da5e40f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     raghavendrat \u003craghavendra-uddhav.tilay@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-06-08 14:35:07 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"HPE: Fix err during retype of vol without comment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On HPE 3par array, for volumes .. the comment section can be empty."},{"line_number":10,"context_line":"During retype of such volumes, below error is observed:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c6fe4ddb_b76b6516","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":12},"in_reply_to":"983c97ea_13e8d56f","updated":"2023-07-13 12:20:19.000000000","message":"Done","commit_id":"e0667c3bfb8310259f344c755cf77937ccf152b8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5274d44bff57a083036c7bb6dbbaa6d77c14b600","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0c5f13a0_1b41aa52","updated":"2023-07-12 12:00:36.000000000","message":"Few minor comments inline but we really need a unit test for this to have code coverage and avoid issues with cases like this.","commit_id":"e0667c3bfb8310259f344c755cf77937ccf152b8"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"5ff1af578129c6282aaa49b36b3840e7b665b7c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3ac885ed_eafbff95","updated":"2023-06-16 15:31:04.000000000","message":"Looks good to me - thank you!","commit_id":"e0667c3bfb8310259f344c755cf77937ccf152b8"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c57bd96e4f8d485887cb9b19ad59b5a1334489d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a4a5ecc1_88e5098d","updated":"2023-07-12 12:21:20.000000000","message":"Thank you Rajat for feedback.\ni will submit new patchset.","commit_id":"e0667c3bfb8310259f344c755cf77937ccf152b8"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8c683034632a951b993076107921b383ac0f3db8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7b8bcd3f_0dc51d43","updated":"2023-07-11 07:02:58.000000000","message":"Zuul and HPE Storage CI have passed","commit_id":"e0667c3bfb8310259f344c755cf77937ccf152b8"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"204f751236a9af2003ec59b2713547b74d0b5358","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"84661605_950e6c14","updated":"2023-06-12 05:37:41.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican tempest-slow-py3","commit_id":"e0667c3bfb8310259f344c755cf77937ccf152b8"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"1a7b6d99e7f679db714bce4780f70712c22a24cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9f63a006_0b36595b","updated":"2023-06-08 14:17:31.000000000","message":"recheck grenade cinder-plugin-ceph-tempest","commit_id":"e0667c3bfb8310259f344c755cf77937ccf152b8"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"69a3e465bf1d4085a605fa62e277913fdae4774a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b118cfae_9d131ee6","updated":"2023-06-12 09:42:15.000000000","message":"recheck tempest-integrated-storage","commit_id":"e0667c3bfb8310259f344c755cf77937ccf152b8"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"96e3f85a1f07b2c6b6cfeb4bc06bd5a86f2bec69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"19140270_b2f29e35","updated":"2023-06-08 10:45:23.000000000","message":"recheck tempest-integrated-storage and cinder-tempest-plugin-lvm-lio-barbican","commit_id":"e0667c3bfb8310259f344c755cf77937ccf152b8"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"109bd3ddf720cee14829f1e5ee088cff36aa3092","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"862a220b_24b5138d","updated":"2023-07-07 07:05:21.000000000","message":"run-HPE Storage CI","commit_id":"e0667c3bfb8310259f344c755cf77937ccf152b8"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c81b93a77a71e7317003e9ac3437d1bc7da5e40f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c5bbecde_af839d30","updated":"2023-07-13 12:20:19.000000000","message":"Added UT code. Also addressed other comments.","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3ba88e7a98252b15ba7da6047f0d0dd39cff1346","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"857449c9_7ff9ce09","updated":"2023-08-08 11:30:39.000000000","message":"Code and tests look good; has a release note.","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"c42bbb9b21a2ab3fa75d2bb61f4a0c4c89e576ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9aa5bb10_5f683ab5","updated":"2023-09-12 10:29:23.000000000","message":"Looks good to me - thank you!","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"e1906b4cdb607b04107c2d4afa924acdbd8297a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"007f1a85_83b114d5","updated":"2023-08-08 11:40:34.000000000","message":"Thank you Brian","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"75ac68bc3b4a72bf6e6c41a2d986954369203993","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3e4db04b_3a6c7bfc","updated":"2023-09-07 07:02:32.000000000","message":"Thank you Eric","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"ceb88be63c064d61dd8c96c363836f27c99f808c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"58f29602_038da3ed","updated":"2023-09-13 06:39:18.000000000","message":"Thank you Rajat, Brian, Eric and everyone.\nThe patch has been merged.","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"f2670caa08c9762609e9dce823f8d48e8230180e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"77711646_aa0f3b32","updated":"2023-08-21 12:38:24.000000000","message":"hi Rajat,\nIt would great to know your feedback. thanks.","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"4d7e0e4024854617140957cfe2c4bbbe4fb83ed9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4ef4d7ce_065d784b","updated":"2023-09-11 04:21:14.000000000","message":"recheck","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"90498f1d37fe15b2dbb081e793088f13b14f7777","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0cea3464_d6efcff5","updated":"2023-07-14 04:07:36.000000000","message":"recheck cinder-grenade-mn-sub-volbak","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"0ae287b6333987fc32580010ed192e0e123ae52a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0c13c11e_d367fa9c","updated":"2023-09-07 12:39:54.000000000","message":"recheck cinder-plugin-ceph-tempest","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"f3e8472dd91d3b026e583e0f3371eda2ff007eaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3f72bd2b_669548d9","updated":"2023-09-07 10:02:03.000000000","message":"recheck cinder-plugin-ceph-tempest","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"412b1cca593aa307f9a4522512115316df65e074","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6c1eca10_07e1132b","updated":"2023-09-09 06:52:52.000000000","message":"recheck cinder-plugin-ceph-tempest","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"e4fb26a094260703042b2f0a1d1b41254d0d008c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"70ff12df_8af959ed","updated":"2023-09-08 12:04:45.000000000","message":"recheck cinder-plugin-ceph-tempest","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c62b05238b77c79d454308a600f2782f2cffe588","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1b1948bb_918a703e","updated":"2023-09-08 05:47:36.000000000","message":"recheck cinder-plugin-ceph-tempest cinder-tempest-plugin-lvm-lio-barbican","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"0bb06e473579122d638c370b94eeee462020d237","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8e3008ed_ff2168b2","updated":"2023-09-12 09:54:52.000000000","message":"recheck cinder-plugin-ceph-tempest cinder-tempest-plugin-lvm-lio-barbican","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"07487b28c54f95dde83d981c33619dd8db56f12a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e7d4779f_27953bbd","updated":"2023-09-08 09:32:13.000000000","message":"recheck cinder-plugin-ceph-tempest cinder-tempest-plugin-lvm-lio-barbican","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"caa471db71239128b1bd1b9fe74143fd26f91f10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6540e0e2_3565a589","updated":"2023-09-12 03:04:46.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"3914c0dcbcaee27c2e2a6b4c6216d75076f0030d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8b38662d_cb798df7","updated":"2023-09-11 09:10:00.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"21010d8161ce3c5dc4ff1ff8658e59d584e6edeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4d38085e_292c3945","updated":"2023-09-09 11:38:11.000000000","message":"recheck tempest-integrated-storage","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"9fd7cabc2bc4d89b1209e4a693aa0b12b3fd6529","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8eb12eee_4e1cbd95","updated":"2023-09-11 11:45:04.000000000","message":"recheck tempest-integrated-storage","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"b6553220ce6b79db80c64909a905888fe254e475","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a3577a15_ab5520ea","updated":"2023-09-07 07:02:46.000000000","message":"recheck tempest-integrated-storage","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"2f6aede57d0a2ee26b8e14500740d3796efd2eff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fd9b8084_7ea4c249","updated":"2023-09-12 06:25:42.000000000","message":"recheck tempest-integrated-storage cinder-for-glance-optimized","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"b1a305f4aa9e28e14f0ad67a7f6098e83b3dfccf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"eda60da7_16ccac31","updated":"2023-09-08 14:32:41.000000000","message":"recheck tempest-integrated-storage cinder-plugin-ceph-tempest","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"e8f5636b86267b0def69c73a0e56bb661f5226c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"136e3d03_5e6381fd","updated":"2023-07-14 11:55:36.000000000","message":"recheck tempest-integrated-storage tempest-slow-py3","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8040400faf9ab4ead76e6be4e8716943a69c0fbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f454eed3_8c2b565c","updated":"2023-07-17 06:22:58.000000000","message":"recheck tempest-slow-py3","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"da8d7c83b61458aa73f253c366e90aca85c3e7d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9c637969_4e21a536","updated":"2023-07-17 13:46:54.000000000","message":"run-HPE Storage CI","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"444ddc65b1dc3f9e45afc569cb6ce24e122007f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dad1213e_2eab14a4","updated":"2023-07-18 04:59:42.000000000","message":"run-HPE Storage CI","commit_id":"6a5e4ae16005c2a0bf444a8e499921fd6b8d2789"}],"cinder/volume/drivers/hpe/hpe_3par_common.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5274d44bff57a083036c7bb6dbbaa6d77c14b600","unresolved":true,"context_lines":[{"line_number":3687,"context_line":"        old_tpvv \u003d old_volume_info[\u0027provisioningType\u0027] \u003d\u003d self.THIN"},{"line_number":3688,"context_line":"        old_tdvv \u003d old_volume_info[\u0027provisioningType\u0027] \u003d\u003d self.DEDUP"},{"line_number":3689,"context_line":"        old_cpg \u003d old_volume_info[\u0027userCPG\u0027]"},{"line_number":3690,"context_line":"        old_comment \u003d old_volume_info.get(\u0027comment\u0027, \u0027\u0027)"},{"line_number":3691,"context_line":"        old_snap_cpg \u003d None"},{"line_number":3692,"context_line":"        if \u0027snapCPG\u0027 in old_volume_info:"},{"line_number":3693,"context_line":"            old_snap_cpg \u003d old_volume_info[\u0027snapCPG\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"81723a2d_679d7f70","line":3690,"range":{"start_line":3690,"start_character":51,"end_line":3690,"end_character":55},"updated":"2023-07-12 12:00:36.000000000","message":"nit: the default value is None here so that could have been used for the below logic","commit_id":"e0667c3bfb8310259f344c755cf77937ccf152b8"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c81b93a77a71e7317003e9ac3437d1bc7da5e40f","unresolved":false,"context_lines":[{"line_number":3687,"context_line":"        old_tpvv \u003d old_volume_info[\u0027provisioningType\u0027] \u003d\u003d self.THIN"},{"line_number":3688,"context_line":"        old_tdvv \u003d old_volume_info[\u0027provisioningType\u0027] \u003d\u003d self.DEDUP"},{"line_number":3689,"context_line":"        old_cpg \u003d old_volume_info[\u0027userCPG\u0027]"},{"line_number":3690,"context_line":"        old_comment \u003d old_volume_info.get(\u0027comment\u0027, \u0027\u0027)"},{"line_number":3691,"context_line":"        old_snap_cpg \u003d None"},{"line_number":3692,"context_line":"        if \u0027snapCPG\u0027 in old_volume_info:"},{"line_number":3693,"context_line":"            old_snap_cpg \u003d old_volume_info[\u0027snapCPG\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"cd31f2ae_083105eb","line":3690,"range":{"start_line":3690,"start_character":51,"end_line":3690,"end_character":55},"in_reply_to":"81723a2d_679d7f70","updated":"2023-07-13 12:20:19.000000000","message":"Done","commit_id":"e0667c3bfb8310259f344c755cf77937ccf152b8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5274d44bff57a083036c7bb6dbbaa6d77c14b600","unresolved":true,"context_lines":[{"line_number":5314,"context_line":"                         new_type_name, new_type_id):"},{"line_number":5315,"context_line":""},{"line_number":5316,"context_line":"        # Modify the comment during ModifyVolume"},{"line_number":5317,"context_line":"        if old_comment \u003d\u003d \u0027\u0027:"},{"line_number":5318,"context_line":"            comment_dict \u003d {}"},{"line_number":5319,"context_line":"        else:"},{"line_number":5320,"context_line":"            comment_dict \u003d dict(ast.literal_eval(old_comment))"},{"line_number":5321,"context_line":"        if \u0027vvs\u0027 in comment_dict:"},{"line_number":5322,"context_line":"            del comment_dict[\u0027vvs\u0027]"},{"line_number":5323,"context_line":"        if \u0027qos\u0027 in comment_dict:"}],"source_content_type":"text/x-python","patch_set":1,"id":"f51ec5f0_a6ce9401","line":5320,"range":{"start_line":5317,"start_character":8,"end_line":5320,"end_character":62},"updated":"2023-07-12 12:00:36.000000000","message":"super nit: If we used the None default value above, this can be modified to,\n\n    if not old_comment:\n        comment_dict \u003d {}\n    else:\n        comment_dict \u003d dict(ast.literal_eval(old_comment))","commit_id":"e0667c3bfb8310259f344c755cf77937ccf152b8"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c81b93a77a71e7317003e9ac3437d1bc7da5e40f","unresolved":false,"context_lines":[{"line_number":5314,"context_line":"                         new_type_name, new_type_id):"},{"line_number":5315,"context_line":""},{"line_number":5316,"context_line":"        # Modify the comment during ModifyVolume"},{"line_number":5317,"context_line":"        if old_comment \u003d\u003d \u0027\u0027:"},{"line_number":5318,"context_line":"            comment_dict \u003d {}"},{"line_number":5319,"context_line":"        else:"},{"line_number":5320,"context_line":"            comment_dict \u003d dict(ast.literal_eval(old_comment))"},{"line_number":5321,"context_line":"        if \u0027vvs\u0027 in comment_dict:"},{"line_number":5322,"context_line":"            del comment_dict[\u0027vvs\u0027]"},{"line_number":5323,"context_line":"        if \u0027qos\u0027 in comment_dict:"}],"source_content_type":"text/x-python","patch_set":1,"id":"17818e0f_a629ec2b","line":5320,"range":{"start_line":5317,"start_character":8,"end_line":5320,"end_character":62},"in_reply_to":"f51ec5f0_a6ce9401","updated":"2023-07-13 12:20:19.000000000","message":"Done","commit_id":"e0667c3bfb8310259f344c755cf77937ccf152b8"}]}