)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"fb24c3abf609739e747cf0356fddf7407cb08fed","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"597eb329_132fe3e5","updated":"2023-06-14 09:34:16.000000000","message":"Looks really good Dessira! Just one comment inline, please update the patch and I\u0027ll vote +2","commit_id":"ae1c63b875f1fe6739170e91cbaf8d8f0ae7367c"},{"author":{"_account_id":35851,"name":"Desire Barine","display_name":"dessira","email":"desirebarine16@gmail.com","username":"dessira"},"change_message_id":"f0a5b6f913812da027ade8ec7e5d0073b234b75f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2ac69ff8_c2cf9dfb","in_reply_to":"597eb329_132fe3e5","updated":"2023-06-22 06:52:01.000000000","message":"Done","commit_id":"ae1c63b875f1fe6739170e91cbaf8d8f0ae7367c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3b7bb348aef5aeb712dc0c42ee62211e18b414ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"517de40c_59e2a5bb","updated":"2023-07-07 11:22:38.000000000","message":"Few comments inline","commit_id":"a0d5d820f3eb80c75ca1017b67fc3dcbc0a12b47"},{"author":{"_account_id":35836,"name":"Toheeb Oyekola","display_name":"Toheeb","email":"toheeb.olawale.to23@gmail.com","username":"Toheeb"},"change_message_id":"0fd8ffcb916be212c880f6f518fe559961b67567","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ff677a5f_c9ed55f1","updated":"2023-06-23 14:30:22.000000000","message":"LGTM","commit_id":"a0d5d820f3eb80c75ca1017b67fc3dcbc0a12b47"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"6fbf48353d040756a997e57eea38ffbac7abe844","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0bf85172_acdec10a","updated":"2023-07-08 07:52:50.000000000","message":"run-TOYOU TYDS CI","commit_id":"8ba8ec6c63d88dce274d8b46fdae3f5016d4bbb3"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"8a66caf4b3534986272cad89e0a87a2ecaa2b5b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d60b369f_ee1f6fb3","updated":"2023-07-13 14:54:38.000000000","message":"LGTM, I think we discussed that the test for list transfers will be proposed in a follow up patch","commit_id":"79a9210c52bca5fd633ac4cfa429e640a78c7c2c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0b594dc5ae39a799dd53e8a4ff9b2928b6967d44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c609bbad_7e7ec085","updated":"2023-07-17 10:56:53.000000000","message":"my comments are addressed, the tests LGTM.","commit_id":"79a9210c52bca5fd633ac4cfa429e640a78c7c2c"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"4cccb5c1d3fb39aa213c4b7fe7e3442ebcc1a2f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"9c374801_9bed4b95","updated":"2023-07-09 03:31:55.000000000","message":"run-TOYOU TYDS CI","commit_id":"79a9210c52bca5fd633ac4cfa429e640a78c7c2c"}],"api-ref/source/v3/samples/volume_transfers/volume-transfers-create-request.json":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3b7bb348aef5aeb712dc0c42ee62211e18b414ea","unresolved":true,"context_lines":[{"line_number":2,"context_line":"\t\"transfer\": {"},{"line_number":3,"context_line":"            \"volume_id\": \"1eeae6be-c72d-4bad-8665-45071c8313df\","},{"line_number":4,"context_line":"            \"name\": \"first volume\","},{"line_number":5,"context_line":"\t    \"no_snapshots\": false"},{"line_number":6,"context_line":"    }"},{"line_number":7,"context_line":"}"}],"source_content_type":"application/json","patch_set":9,"id":"c4168bd8_e11f7711","line":5,"range":{"start_line":5,"start_character":5,"end_line":5,"end_character":26},"updated":"2023-07-07 11:22:38.000000000","message":"this should only be included if MV \u003e\u003d 3.55 so either\n1. the file location is wrong\n2. this parameter shouldn\u0027t be there in the JSON body","commit_id":"a0d5d820f3eb80c75ca1017b67fc3dcbc0a12b47"}],"cinder/tests/functional/api_sample_tests/samples/volume_transfers/v3.57/volume-transfers-create-response.json.tpl":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"fb24c3abf609739e747cf0356fddf7407cb08fed","unresolved":true,"context_lines":[{"line_number":17,"context_line":"        \"volume_id\": \"%(uuid)s\","},{"line_number":18,"context_line":"\t\"no_snapshots\": false,"},{"line_number":19,"context_line":"\t\"destination_project_id\": null,"},{"line_number":20,"context_line":"\t\"source_project_id\": \"89afd400-b646-4bbc-b12b-c0a4d63e5bd3\","},{"line_number":21,"context_line":"\t\"accepted\": false"},{"line_number":22,"context_line":"    }"},{"line_number":23,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"e629e9d0_666dd08d","line":20,"range":{"start_line":20,"start_character":23,"end_line":20,"end_character":59},"updated":"2023-06-14 09:34:16.000000000","message":"Please update this place. This should be %(uuid)s","commit_id":"ae1c63b875f1fe6739170e91cbaf8d8f0ae7367c"},{"author":{"_account_id":35851,"name":"Desire Barine","display_name":"dessira","email":"desirebarine16@gmail.com","username":"dessira"},"change_message_id":"437ffe2e46680b29cc36e3bf8ab221718f74ec15","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        \"volume_id\": \"%(uuid)s\","},{"line_number":18,"context_line":"\t\"no_snapshots\": false,"},{"line_number":19,"context_line":"\t\"destination_project_id\": null,"},{"line_number":20,"context_line":"\t\"source_project_id\": \"89afd400-b646-4bbc-b12b-c0a4d63e5bd3\","},{"line_number":21,"context_line":"\t\"accepted\": false"},{"line_number":22,"context_line":"    }"},{"line_number":23,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"3fd7d39c_e73a59dd","line":20,"range":{"start_line":20,"start_character":23,"end_line":20,"end_character":59},"in_reply_to":"e629e9d0_666dd08d","updated":"2023-06-17 18:12:55.000000000","message":"Done","commit_id":"ae1c63b875f1fe6739170e91cbaf8d8f0ae7367c"}],"cinder/tests/functional/api_sample_tests/samples/volume_transfers/volume-transfers-create-request.json.tpl":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3b7bb348aef5aeb712dc0c42ee62211e18b414ea","unresolved":true,"context_lines":[{"line_number":2,"context_line":"\t\"transfer\": {"},{"line_number":3,"context_line":"            \"volume_id\": \"%(volume_id)s\","},{"line_number":4,"context_line":"            \"name\": \"first volume\","},{"line_number":5,"context_line":"\t    \"no_snapshots\": false"},{"line_number":6,"context_line":"    }"},{"line_number":7,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":9,"id":"1ffe5fb6_ed3f7cac","line":5,"range":{"start_line":5,"start_character":5,"end_line":5,"end_character":26},"updated":"2023-07-07 11:22:38.000000000","message":"same, either requires MV 3.55 or should not be included in this template","commit_id":"a0d5d820f3eb80c75ca1017b67fc3dcbc0a12b47"}],"cinder/tests/functional/api_sample_tests/test_volume_transfers.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2299fe8a78877aebcb8b991bcfb876d77c1723ff","unresolved":true,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from oslo_serialization import jsonutils"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from cinder.tests.functional.api_sample_tests import test_volumes"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"af8fc2d8_55f1ca56","line":14,"updated":"2023-06-12 12:23:26.000000000","message":"need to import microversions file\n\nfrom cinder.api import microversions as mv","commit_id":"851b2d76eb48da0acf8020ef281d74c2a70f3fb3"},{"author":{"_account_id":35851,"name":"Desire Barine","display_name":"dessira","email":"desirebarine16@gmail.com","username":"dessira"},"change_message_id":"84e6530657bc2a59330132ed1b9d6b72278bfe52","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from oslo_serialization import jsonutils"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from cinder.tests.functional.api_sample_tests import test_volumes"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"10f27963_c0ee8e16","line":14,"in_reply_to":"af8fc2d8_55f1ca56","updated":"2023-06-13 06:30:26.000000000","message":"Done","commit_id":"851b2d76eb48da0acf8020ef281d74c2a70f3fb3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ef0ca83cd1d5000ead6d39df449b9771e68206f1","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from cinder.tests.functional.api_sample_tests import test_volumes"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class VolumeTransfersSampleJsonTest(test_volumes.test_base.VolumesSampleBase):"},{"line_number":19,"context_line":"    sample_dir \u003d \"volume_transfers\""},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"233ed2dd_6b0687e7","line":17,"updated":"2023-06-12 12:22:22.000000000","message":"you need to add this decorator to use the right microversion for request/response\n\n@test_base.VolumesSampleBase.use_versions(mv.TRANSFER_WITH_HISTORY)","commit_id":"851b2d76eb48da0acf8020ef281d74c2a70f3fb3"},{"author":{"_account_id":35851,"name":"Desire Barine","display_name":"dessira","email":"desirebarine16@gmail.com","username":"dessira"},"change_message_id":"84e6530657bc2a59330132ed1b9d6b72278bfe52","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from cinder.tests.functional.api_sample_tests import test_volumes"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class VolumeTransfersSampleJsonTest(test_volumes.test_base.VolumesSampleBase):"},{"line_number":19,"context_line":"    sample_dir \u003d \"volume_transfers\""},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa4fbfe1_d0fad0db","line":17,"in_reply_to":"233ed2dd_6b0687e7","updated":"2023-06-13 06:30:26.000000000","message":"Done","commit_id":"851b2d76eb48da0acf8020ef281d74c2a70f3fb3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"096a5f26a50a1e975ce495a80e5d40996c1b99ec","unresolved":true,"context_lines":[{"line_number":28,"context_line":"        }"},{"line_number":29,"context_line":"        self.response \u003d self._create_transfers(self.subs)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _create_transfers(self, subs\u003dNone):"},{"line_number":32,"context_line":"        response \u003d self._do_post(\u0027volume-transfers\u0027,"},{"line_number":33,"context_line":"                                 \u0027volume-transfers-create-request\u0027,"},{"line_number":34,"context_line":"                                 subs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"19535d11_f635bce3","line":31,"updated":"2023-06-12 12:25:13.000000000","message":"you need to create a directory v3.57 and place the request sample inside it, this will be the path\n\ncinder/tests/functional/api_sample_tests/samples/v3.57/volume-transfers-create-request.tpl","commit_id":"851b2d76eb48da0acf8020ef281d74c2a70f3fb3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ad494aff9bb4986f3349c92be833056e182351c9","unresolved":true,"context_lines":[{"line_number":28,"context_line":"        }"},{"line_number":29,"context_line":"        self.response \u003d self._create_transfers(self.subs)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _create_transfers(self, subs\u003dNone):"},{"line_number":32,"context_line":"        response \u003d self._do_post(\u0027volume-transfers\u0027,"},{"line_number":33,"context_line":"                                 \u0027volume-transfers-create-request\u0027,"},{"line_number":34,"context_line":"                                 subs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1c5b9e39_d42f41cc","line":31,"in_reply_to":"19535d11_f635bce3","updated":"2023-06-12 12:29:38.000000000","message":"cinder/tests/functional/api_sample_tests/samples/volume_transfer/v3.57/volume-transfers-create-request.tpl","commit_id":"851b2d76eb48da0acf8020ef281d74c2a70f3fb3"},{"author":{"_account_id":35851,"name":"Desire Barine","display_name":"dessira","email":"desirebarine16@gmail.com","username":"dessira"},"change_message_id":"84e6530657bc2a59330132ed1b9d6b72278bfe52","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        }"},{"line_number":29,"context_line":"        self.response \u003d self._create_transfers(self.subs)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _create_transfers(self, subs\u003dNone):"},{"line_number":32,"context_line":"        response \u003d self._do_post(\u0027volume-transfers\u0027,"},{"line_number":33,"context_line":"                                 \u0027volume-transfers-create-request\u0027,"},{"line_number":34,"context_line":"                                 subs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9c026fcb_1a2f29f1","line":31,"in_reply_to":"1c5b9e39_d42f41cc","updated":"2023-06-13 06:30:26.000000000","message":"Done","commit_id":"851b2d76eb48da0acf8020ef281d74c2a70f3fb3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3b7bb348aef5aeb712dc0c42ee62211e18b414ea","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        subs \u003d {"},{"line_number":51,"context_line":"            \u0027auth_key\u0027: res[\u0027auth_key\u0027]"},{"line_number":52,"context_line":"        }"},{"line_number":53,"context_line":"        with self.common_api_sample():"},{"line_number":54,"context_line":"            response \u003d self._do_post(\u0027volume-transfers/%s/accept\u0027 % res[\u0027id\u0027],"},{"line_number":55,"context_line":"                                     \u0027volume-transfers-accept-request\u0027,"},{"line_number":56,"context_line":"                                     subs)"}],"source_content_type":"text/x-python","patch_set":9,"id":"d02c7aef_813b3975","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":38},"updated":"2023-07-07 11:22:38.000000000","message":"why are we defining this as a common sample, do we need it for other tests?","commit_id":"a0d5d820f3eb80c75ca1017b67fc3dcbc0a12b47"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"8a66caf4b3534986272cad89e0a87a2ecaa2b5b6","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        subs \u003d {"},{"line_number":51,"context_line":"            \u0027auth_key\u0027: res[\u0027auth_key\u0027]"},{"line_number":52,"context_line":"        }"},{"line_number":53,"context_line":"        with self.common_api_sample():"},{"line_number":54,"context_line":"            response \u003d self._do_post(\u0027volume-transfers/%s/accept\u0027 % res[\u0027id\u0027],"},{"line_number":55,"context_line":"                                     \u0027volume-transfers-accept-request\u0027,"},{"line_number":56,"context_line":"                                     subs)"}],"source_content_type":"text/x-python","patch_set":9,"id":"87e9464b_96cf6e1f","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":38},"in_reply_to":"d02c7aef_813b3975","updated":"2023-07-13 14:54:38.000000000","message":"I can\u0027t remember our last discussion regarding why this is needed. But I think the comments are going to be address in a follow up patch?","commit_id":"a0d5d820f3eb80c75ca1017b67fc3dcbc0a12b47"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3b7bb348aef5aeb712dc0c42ee62211e18b414ea","unresolved":true,"context_lines":[{"line_number":54,"context_line":"            response \u003d self._do_post(\u0027volume-transfers/%s/accept\u0027 % res[\u0027id\u0027],"},{"line_number":55,"context_line":"                                     \u0027volume-transfers-accept-request\u0027,"},{"line_number":56,"context_line":"                                     subs)"},{"line_number":57,"context_line":"            with self.common_api_sample():"},{"line_number":58,"context_line":"                self._verify_response(\u0027volume-transfers-accept-response\u0027,"},{"line_number":59,"context_line":"                                      {}, response, 202)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3abd4eda_b369f760","line":57,"range":{"start_line":57,"start_character":12,"end_line":57,"end_character":42},"updated":"2023-07-07 11:22:38.000000000","message":"this shouldn\u0027t be needed","commit_id":"a0d5d820f3eb80c75ca1017b67fc3dcbc0a12b47"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3b7bb348aef5aeb712dc0c42ee62211e18b414ea","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ebebbd22_e7827f1c","line":73,"updated":"2023-07-07 11:22:38.000000000","message":"we are missing a test for list transfers","commit_id":"a0d5d820f3eb80c75ca1017b67fc3dcbc0a12b47"}]}