)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d1c212622ad74d83d052a9c3a243abeb664766a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"29866fdf_749d482c","updated":"2023-06-22 18:15:31.000000000","message":"Thanks!","commit_id":"05c050da34ffb03cb1d67b607144eb596749be63"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"eeac29e085e9fc1cdbb5cfe03b330e6532dd03f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cfd25838_ce0c712e","updated":"2023-06-23 11:30:17.000000000","message":"recheck  Timeouts","commit_id":"05c050da34ffb03cb1d67b607144eb596749be63"}],"cinder/tests/unit/volume/drivers/dell_emc/powerflex/__init__.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b5a48af0794c38338380035a9a390dbaf178546f","unresolved":true,"context_lines":[{"line_number":107,"context_line":"    __https_response_mode \u003d RESPONSE_MODE.Valid"},{"line_number":108,"context_line":"    log \u003d None"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    STORAGE_POOL_ID \u003d str(\u00271\u0027)"},{"line_number":111,"context_line":"    STORAGE_POOL_NAME \u003d \u0027SP1\u0027"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    PROT_DOMAIN_ID \u003d str(\u00271\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"749e6a67_60539f57","line":110,"updated":"2023-06-21 20:22:24.000000000","message":"Is there even a need to use str() here now?","commit_id":"7718be8b72edd7fe6d78c8bc14ceceeb183831e5"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"d23dacead1ac50d7431c8a7a1abbf19a61a7dbbd","unresolved":true,"context_lines":[{"line_number":107,"context_line":"    __https_response_mode \u003d RESPONSE_MODE.Valid"},{"line_number":108,"context_line":"    log \u003d None"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    STORAGE_POOL_ID \u003d str(\u00271\u0027)"},{"line_number":111,"context_line":"    STORAGE_POOL_NAME \u003d \u0027SP1\u0027"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    PROT_DOMAIN_ID \u003d str(\u00271\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"0000778f_9a6b83af","line":110,"in_reply_to":"749e6a67_60539f57","updated":"2023-06-22 15:17:46.000000000","message":"Good catch 😊\n\nThis should be good now:\n$ git show 05c050da3 | grep \"str(\u0027\"\n$","commit_id":"7718be8b72edd7fe6d78c8bc14ceceeb183831e5"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/client/test_api.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"401a48e36532aac75f2e33f0de65e008dbb56d41","unresolved":true,"context_lines":[{"line_number":102,"context_line":"        mock_invoke \u003d self.mock_object(six, \u0027text_type\u0027, return_value\u003d\u0027str\u0027)"},{"line_number":103,"context_line":"        self.root.set_api_version(**args)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.assertEqual(expected_call_args_list, mock_invoke.call_args_list)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @ddt.data({\u0027params\u0027: {\u0027result\u0027: zapi_fakes.FAKE_RESULT_API_ERR_REASON}},"},{"line_number":108,"context_line":"              {\u0027params\u0027: {\u0027result\u0027: zapi_fakes.FAKE_RESULT_API_ERRNO_INVALID}},"}],"source_content_type":"text/x-python","patch_set":1,"id":"87a29e04_86ddf4a2","side":"PARENT","line":105,"range":{"start_line":105,"start_character":8,"end_line":105,"end_character":24},"updated":"2023-06-15 22:33:44.000000000","message":"Honestly, I was not sure how to mock \"str()\". This test is not testing the set_api_version method itself, but rather its internals. We already have a test that makes sure this function raises a ValueError if the argument types are not right (test_set_api_version_value_error), so let\u0027s just test the method behaviour rather its implementation details.","commit_id":"e37366888251422a467039d47ee6e5642e5db7de"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b5a48af0794c38338380035a9a390dbaf178546f","unresolved":true,"context_lines":[{"line_number":102,"context_line":"        mock_invoke \u003d self.mock_object(six, \u0027text_type\u0027, return_value\u003d\u0027str\u0027)"},{"line_number":103,"context_line":"        self.root.set_api_version(**args)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.assertEqual(expected_call_args_list, mock_invoke.call_args_list)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @ddt.data({\u0027params\u0027: {\u0027result\u0027: zapi_fakes.FAKE_RESULT_API_ERR_REASON}},"},{"line_number":108,"context_line":"              {\u0027params\u0027: {\u0027result\u0027: zapi_fakes.FAKE_RESULT_API_ERRNO_INVALID}},"}],"source_content_type":"text/x-python","patch_set":1,"id":"da11de9d_dd1deae8","side":"PARENT","line":105,"range":{"start_line":105,"start_character":8,"end_line":105,"end_character":24},"in_reply_to":"87a29e04_86ddf4a2","updated":"2023-06-21 20:22:24.000000000","message":"+1","commit_id":"e37366888251422a467039d47ee6e5642e5db7de"}]}