)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"c61a556179012242fae4d38009cd87d2c97012c6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a1158808_2105390c","updated":"2023-06-20 07:44:58.000000000","message":"why we need set to metadata instead a record in database?","commit_id":"09670f1a7f8cdef3b24fcfbdfa408cd1f8a6c264"},{"author":{"_account_id":35916,"name":"Pham Le Gia Dai","display_name":"Dai","email":"daipham.3213@gmail.com","username":"daiplg","status":"Full Stack Dev"},"change_message_id":"4e9fca70d574d39030358e20b072568617424ca8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dc67cee8_ef19ab30","in_reply_to":"a1158808_2105390c","updated":"2023-06-20 08:11:10.000000000","message":"I think metadata is a convenient way to store the required data, instead of writing whole new migration.","commit_id":"09670f1a7f8cdef3b24fcfbdfa408cd1f8a6c264"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"4b57ab494f65eb05189b6b99673f3f2f65585bf4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ddf36cd7_2f2ce635","in_reply_to":"dc67cee8_ef19ab30","updated":"2023-06-20 08:39:36.000000000","message":"whether it will make maintain flow more complex? what happens when we do something make change metadata? I think we need make is consistent.","commit_id":"09670f1a7f8cdef3b24fcfbdfa408cd1f8a6c264"},{"author":{"_account_id":35916,"name":"Pham Le Gia Dai","display_name":"Dai","email":"daipham.3213@gmail.com","username":"daiplg","status":"Full Stack Dev"},"change_message_id":"58536a381cc99ad65047c848c48fc6002d376e7e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f8fd4144_aed4c656","in_reply_to":"ddf36cd7_2f2ce635","updated":"2023-06-20 08:58:03.000000000","message":"so what is your suggestion? how should I store the retention point data?","commit_id":"09670f1a7f8cdef3b24fcfbdfa408cd1f8a6c264"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4b913a18b6b28cb9335f0b5a72f106b1ac0ed50f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4b8240a2_72ffa11e","updated":"2023-06-20 12:00:54.000000000","message":"The lifecycle and orchestration of backups are typically handled outside of Cinder, with Cinder only providing the primitives for coordinating the creation and deletion. It seems dangerous to me to have Cinder itself start also deleting backups. That could cause situations where the backup management thinks there are backups available when in reality they are not. So personally, I don\u0027t think this is a great idea.","commit_id":"4337eb33c977977872bae7b3195dbe5a1262c777"},{"author":{"_account_id":35916,"name":"Pham Le Gia Dai","display_name":"Dai","email":"daipham.3213@gmail.com","username":"daiplg","status":"Full Stack Dev"},"change_message_id":"dd91ecc2e6d42a1886fbf80f33a65da760ca4802","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"22b64a15_3d6317de","in_reply_to":"4b8240a2_72ffa11e","updated":"2023-06-22 03:56:44.000000000","message":"The metadata `retention` key acting like a switch so the user can choose if they want the backup to \"do\" retention or not. Also there are various providers that have this functionality while Cinder not. This is just a simple implementation but it can reduce lots of storage consumption.","commit_id":"4337eb33c977977872bae7b3195dbe5a1262c777"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b2cba8848c5a2696d5c6861764dcaf165c4c0903","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0c9f280f_c2cb6eb9","updated":"2023-06-21 13:51:35.000000000","message":"See previous comment.","commit_id":"f10ea5c0d356803964f5ee515ccc0d424d3fa2f7"}]}