)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"63d972ee69e0025b415c1b5072cdc6c6fec1af8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"266d3657_92f7751c","updated":"2023-07-19 13:32:33.000000000","message":"After doing a manual QA, I executed the tempest tests in the A/A environment, and results looks good [1]\n\n[1] https://paste.opendev.org/show/bmaUmTpiJ72NS5DIRJcX/","commit_id":"299ee4ba4cfaf74de7b4759c2b67c2bee5fec90c"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"62d048b95674b672fe8330ce5a20a964b1b67463","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"40575b28_2ef83a56","updated":"2023-07-20 20:56:38.000000000","message":"Thanks for the answers, Nahim.","commit_id":"299ee4ba4cfaf74de7b4759c2b67c2bee5fec90c"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"4ac66f241d351989060467cf2ee6bee4fb77e1d2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"87f08c9d_2f81044a","updated":"2023-07-20 18:38:11.000000000","message":"Thanks for the patch, Nahim. Just a few questions inline to understand better. The rest LGTM.","commit_id":"299ee4ba4cfaf74de7b4759c2b67c2bee5fec90c"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"95521ba1fa75cdda3a64b51482f765a290b2502e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ee0f6c86_63fcd794","updated":"2023-07-20 20:24:53.000000000","message":"Thanks for the review, Thiago. I replied your comments inline.","commit_id":"299ee4ba4cfaf74de7b4759c2b67c2bee5fec90c"},{"author":{"_account_id":33986,"name":"Lucas Morais de oliveira","email":"lucasmoliveira059@gmail.com","username":"lucasmoliveira059"},"change_message_id":"487cd7ee17e7bf4b806ce979d0144b76876a12f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6cca5296_42f02ad5","updated":"2023-07-21 12:42:48.000000000","message":"recheck","commit_id":"299ee4ba4cfaf74de7b4759c2b67c2bee5fec90c"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"7872a673710f8745d68f5bc2716ed55a48829aa0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"06e0b577_0c86f8ef","updated":"2023-07-20 20:25:59.000000000","message":"recheck - non related failures on zuul jobs","commit_id":"299ee4ba4cfaf74de7b4759c2b67c2bee5fec90c"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"d9351889f34448781f89f060f1e2768315c20ae9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"46248546_4bf76230","updated":"2023-07-19 13:33:33.000000000","message":"recheck - zuul failures are not related to this patch changes","commit_id":"299ee4ba4cfaf74de7b4759c2b67c2bee5fec90c"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"62d048b95674b672fe8330ce5a20a964b1b67463","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"66b4bb21_411e1059","in_reply_to":"87f08c9d_2f81044a","updated":"2023-07-20 20:56:38.000000000","message":"Done","commit_id":"299ee4ba4cfaf74de7b4759c2b67c2bee5fec90c"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"bc29b4486c6edad2e1d15602519c84add6653747","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"34524c7d_d7e0c7c9","updated":"2023-07-26 20:31:30.000000000","message":"The matrix change LGTM. Keeping the previous vote.","commit_id":"e3d88c459972a1003db85eb3e220d15432f11c62"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"7c2ee20e9aa9f83221445f6e1995330585ec4b02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fd231cfc_fc2015e5","updated":"2023-07-25 15:03:29.000000000","message":"recheck","commit_id":"e3d88c459972a1003db85eb3e220d15432f11c62"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"4db9a0927725c36f0ae0ed8d28acf59a2c95ea28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"47880b62_7e76980a","updated":"2023-07-28 06:51:31.000000000","message":"Code change and UT look good. Suggestion inline","commit_id":"97184a93e5ac646f7592a63ff8935f7eb2c42350"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"de493a9682f0363d056e559d5adba3746b9d0c1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b936e0b1_01df7523","updated":"2023-08-10 11:55:18.000000000","message":"LGTM.","commit_id":"db813c41fd484a2678c388eff74265acc25eb375"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"832b94e343f54b576b6439bd0d5bc5148e7616f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bbce5e85_21a13739","updated":"2023-07-28 10:50:29.000000000","message":"Thanks for the review, Raghavendra. I updated the patch.","commit_id":"db813c41fd484a2678c388eff74265acc25eb375"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"07d46f518a55597cec9fbe17ec4c6d4daf2cd575","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a8f2c590_9118e3ba","updated":"2023-07-29 09:14:50.000000000","message":"nit inline","commit_id":"db813c41fd484a2678c388eff74265acc25eb375"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"05495a81732d5dc53e2d7088fcc54d47ab659b6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"51cb4dbd_a119912a","updated":"2023-09-09 08:16:44.000000000","message":"Gates have been fixed, the dependent patch should merge now and this one as well.","commit_id":"45263d54dc1638a3f942d61f9660808e1d5a982e"},{"author":{"_account_id":33986,"name":"Lucas Morais de oliveira","email":"lucasmoliveira059@gmail.com","username":"lucasmoliveira059"},"change_message_id":"740d49a63133b4d88ff9b4248390837aeb9bcc41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e8140332_ab607667","updated":"2023-08-03 13:17:03.000000000","message":"LGTM","commit_id":"45263d54dc1638a3f942d61f9660808e1d5a982e"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"d90b24b4cdbd70f96d20625f8e433229f70f58a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cde2b8d6_73245ed1","updated":"2023-08-01 13:10:05.000000000","message":"My comment has been addressed. thanks","commit_id":"45263d54dc1638a3f942d61f9660808e1d5a982e"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"dba3b5e6739d239952146809b63b262dff246e52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e5f1dd6b_01b88964","updated":"2023-08-04 14:03:04.000000000","message":"Thank you Nahim. Code LGTM and NetApp CI is passing.","commit_id":"45263d54dc1638a3f942d61f9660808e1d5a982e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"0b9b2c114696bd65e1b12a9a50ed406e5ad0fb28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1e929af7_97d767b3","updated":"2023-08-16 14:53:08.000000000","message":"This looks good to me.  Thanks!","commit_id":"45263d54dc1638a3f942d61f9660808e1d5a982e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b7185fbd159e15c18ca844d801c8571d4a2b8ce8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4707bc31_2da8b9b7","updated":"2023-08-09 12:41:15.000000000","message":"code and tests look good, netapp NFS CI is reporting success (although I\u0027m not sure if this is being tested in the CI)\nIf the netapp team has proposed this, I would assume they have tested the feature. LGTM.","commit_id":"45263d54dc1638a3f942d61f9660808e1d5a982e"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"2d4fc3439af54d1c626342172a1423b99d16e774","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"899f4d11_1c7327bf","updated":"2023-08-01 14:05:56.000000000","message":"recheck - unrelated failure on zuul","commit_id":"45263d54dc1638a3f942d61f9660808e1d5a982e"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"4738fc2c77ef1e3593cfa6e90b5ffda99cc69a75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"74c6855b_02aef0f2","updated":"2023-09-11 13:52:38.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican and cinder-grenade-mn-sub-volbak Failures not related","commit_id":"45263d54dc1638a3f942d61f9660808e1d5a982e"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"4427a66672b11668044fc273b7525cb0ad068963","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f87ac47f_feb516d3","updated":"2023-08-01 13:10:16.000000000","message":"recheck tempest-integrated-storage","commit_id":"45263d54dc1638a3f942d61f9660808e1d5a982e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6edac891083d63be98e3f932504102e75adec73e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ace1881a_759805ac","updated":"2023-09-11 11:00:15.000000000","message":"recheck unrelated failure in tempest-integrated storage\n\ntempest.lib.exceptions.IdentityError: Got identity error","commit_id":"45263d54dc1638a3f942d61f9660808e1d5a982e"},{"author":{"_account_id":36178,"name":"Saravanan Manickam","display_name":"msaravan","email":"manicsaran@gmail.com","username":"msaravan"},"change_message_id":"f4870566682188dfa8168946d0ceedf9f305a26e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"44b355f7_da22fcbf","updated":"2023-08-03 03:47:18.000000000","message":"recheck: no related failure","commit_id":"45263d54dc1638a3f942d61f9660808e1d5a982e"},{"author":{"_account_id":36178,"name":"Saravanan Manickam","display_name":"msaravan","email":"manicsaran@gmail.com","username":"msaravan"},"change_message_id":"38057274e8ff86cd6c43eaf7e48ac9b897c0591d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5fbb1527_2cf9a29a","updated":"2023-09-11 11:52:17.000000000","message":"recheck: no related failure","commit_id":"45263d54dc1638a3f942d61f9660808e1d5a982e"}],"cinder/volume/drivers/netapp/dataontap/nfs_cmode.py":[{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"4ac66f241d351989060467cf2ee6bee4fb77e1d2","unresolved":true,"context_lines":[{"line_number":72,"context_line":"    VERSION \u003d \"3.0.0\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    REQUIRED_CMODE_FLAGS \u003d [\u0027netapp_vserver\u0027]"},{"line_number":75,"context_line":"    SUPPORTS_ACTIVE_ACTIVE \u003d True"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":78,"context_line":"        super(NetAppCmodeNfsDriver, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fdfeaa68_0a54cc46","line":75,"updated":"2023-07-20 18:38:11.000000000","message":"I did not find where this const is used. It will be used in an upcoming patch or I missed something?","commit_id":"299ee4ba4cfaf74de7b4759c2b67c2bee5fec90c"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"62d048b95674b672fe8330ce5a20a964b1b67463","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    VERSION \u003d \"3.0.0\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    REQUIRED_CMODE_FLAGS \u003d [\u0027netapp_vserver\u0027]"},{"line_number":75,"context_line":"    SUPPORTS_ACTIVE_ACTIVE \u003d True"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":78,"context_line":"        super(NetAppCmodeNfsDriver, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"02c8fbf9_48d2022b","line":75,"in_reply_to":"9d5ae643_5900bec7","updated":"2023-07-20 20:56:38.000000000","message":"Done","commit_id":"299ee4ba4cfaf74de7b4759c2b67c2bee5fec90c"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"95521ba1fa75cdda3a64b51482f765a290b2502e","unresolved":true,"context_lines":[{"line_number":72,"context_line":"    VERSION \u003d \"3.0.0\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    REQUIRED_CMODE_FLAGS \u003d [\u0027netapp_vserver\u0027]"},{"line_number":75,"context_line":"    SUPPORTS_ACTIVE_ACTIVE \u003d True"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":78,"context_line":"        super(NetAppCmodeNfsDriver, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9d5ae643_5900bec7","line":75,"in_reply_to":"fdfeaa68_0a54cc46","updated":"2023-07-20 20:24:53.000000000","message":"This is used by the manager, during the driver initialization - https://github.com/openstack/cinder/blob/39c254a50ac755568dce83d39f9c9d291a4d2d1e/cinder/volume/manager.py#L321","commit_id":"299ee4ba4cfaf74de7b4759c2b67c2bee5fec90c"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"4ac66f241d351989060467cf2ee6bee4fb77e1d2","unresolved":true,"context_lines":[{"line_number":871,"context_line":"        \"\"\"Failover a backend to a secondary replication target."},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"           This function combines failover() and failover_completed()"},{"line_number":874,"context_line":"           to perform failover when Active/Active is not enabled."},{"line_number":875,"context_line":"        \"\"\""},{"line_number":876,"context_line":"        active_backend_name, volume_updates, group_updates \u003d ("},{"line_number":877,"context_line":"            self._failover(context, volumes, secondary_id, groups))"}],"source_content_type":"text/x-python","patch_set":2,"id":"b9abeabf_f90faafa","line":874,"range":{"start_line":874,"start_character":31,"end_line":874,"end_character":64},"updated":"2023-07-20 18:38:11.000000000","message":"I\u0027m little confused. From commit message I thought this method would be for A/A enabled. I understood wrong?","commit_id":"299ee4ba4cfaf74de7b4759c2b67c2bee5fec90c"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"95521ba1fa75cdda3a64b51482f765a290b2502e","unresolved":true,"context_lines":[{"line_number":871,"context_line":"        \"\"\"Failover a backend to a secondary replication target."},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"           This function combines failover() and failover_completed()"},{"line_number":874,"context_line":"           to perform failover when Active/Active is not enabled."},{"line_number":875,"context_line":"        \"\"\""},{"line_number":876,"context_line":"        active_backend_name, volume_updates, group_updates \u003d ("},{"line_number":877,"context_line":"            self._failover(context, volumes, secondary_id, groups))"}],"source_content_type":"text/x-python","patch_set":2,"id":"c3e860ae_47777180","line":874,"range":{"start_line":874,"start_character":31,"end_line":874,"end_character":64},"in_reply_to":"b9abeabf_f90faafa","updated":"2023-07-20 20:24:53.000000000","message":"Though A/A is supported by NFS driver, it can be disabled. This method is used in this case. When A/A is enabled (which means, a cluster name is defined in cinder.conf), the manager will call `failover` and `failover_completed` methods.\n\nYou can check the spec [1] if you want to see more details.\n\n[1] https://files.openstack.org/project/specs.openstack.org/openstack/cinder-specs/specs/ocata/ha-aa-replication.html","commit_id":"299ee4ba4cfaf74de7b4759c2b67c2bee5fec90c"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"62d048b95674b672fe8330ce5a20a964b1b67463","unresolved":false,"context_lines":[{"line_number":871,"context_line":"        \"\"\"Failover a backend to a secondary replication target."},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"           This function combines failover() and failover_completed()"},{"line_number":874,"context_line":"           to perform failover when Active/Active is not enabled."},{"line_number":875,"context_line":"        \"\"\""},{"line_number":876,"context_line":"        active_backend_name, volume_updates, group_updates \u003d ("},{"line_number":877,"context_line":"            self._failover(context, volumes, secondary_id, groups))"}],"source_content_type":"text/x-python","patch_set":2,"id":"d8e46478_19a21f85","line":874,"range":{"start_line":874,"start_character":31,"end_line":874,"end_character":64},"in_reply_to":"c3e860ae_47777180","updated":"2023-07-20 20:56:38.000000000","message":"Done","commit_id":"299ee4ba4cfaf74de7b4759c2b67c2bee5fec90c"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"4db9a0927725c36f0ae0ed8d28acf59a2c95ea28","unresolved":true,"context_lines":[{"line_number":66,"context_line":"                Implement FlexGroup pool"},{"line_number":67,"context_line":"        3.0.0 - Add support for Intra-cluster Storage assisted volume migration"},{"line_number":68,"context_line":"                Add support for revert to snapshot"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    \"\"\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    VERSION \u003d \"3.0.0\""}],"source_content_type":"text/x-python","patch_set":4,"id":"14f47922_e03e1e44","line":69,"updated":"2023-07-28 06:51:31.000000000","message":"nit: If it helps, a new version can be added.\n4.0.0 - Add A/A High Availability support","commit_id":"97184a93e5ac646f7592a63ff8935f7eb2c42350"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"832b94e343f54b576b6439bd0d5bc5148e7616f3","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                Implement FlexGroup pool"},{"line_number":67,"context_line":"        3.0.0 - Add support for Intra-cluster Storage assisted volume migration"},{"line_number":68,"context_line":"                Add support for revert to snapshot"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    \"\"\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    VERSION \u003d \"3.0.0\""}],"source_content_type":"text/x-python","patch_set":4,"id":"6cddb511_32468183","line":69,"in_reply_to":"14f47922_e03e1e44","updated":"2023-07-28 10:50:29.000000000","message":"Good suggestion. Done.","commit_id":"97184a93e5ac646f7592a63ff8935f7eb2c42350"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"07d46f518a55597cec9fbe17ec4c6d4daf2cd575","unresolved":true,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    \"\"\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    VERSION \u003d \"3.0.0\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    REQUIRED_CMODE_FLAGS \u003d [\u0027netapp_vserver\u0027]"},{"line_number":77,"context_line":"    SUPPORTS_ACTIVE_ACTIVE \u003d True"}],"source_content_type":"text/x-python","patch_set":5,"id":"8cd6d87e_02b75af4","line":74,"updated":"2023-07-29 09:14:50.000000000","message":"nit: 4.0.0","commit_id":"db813c41fd484a2678c388eff74265acc25eb375"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"877e9af2a98246a0ace9a638f0e67030afe45c53","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    \"\"\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    VERSION \u003d \"3.0.0\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    REQUIRED_CMODE_FLAGS \u003d [\u0027netapp_vserver\u0027]"},{"line_number":77,"context_line":"    SUPPORTS_ACTIVE_ACTIVE \u003d True"}],"source_content_type":"text/x-python","patch_set":5,"id":"bcb585dd_6f1d3bfa","line":74,"in_reply_to":"8cd6d87e_02b75af4","updated":"2023-07-31 11:40:38.000000000","message":"Oops, I forgot to change that :D\nThanks!","commit_id":"db813c41fd484a2678c388eff74265acc25eb375"}],"cinder/volume/drivers/netapp/dataontap/utils/data_motion.py":[{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"4ac66f241d351989060467cf2ee6bee4fb77e1d2","unresolved":true,"context_lines":[{"line_number":824,"context_line":"    def _failover_completed(self, context, secondary_id\u003dNone):"},{"line_number":825,"context_line":"        \"\"\"Update volume node when `failover` is completed.\"\"\""},{"line_number":826,"context_line":"        # Update the ZAPI client to the backend we failed over to"},{"line_number":827,"context_line":"        self._update_zapi_client(secondary_id)"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"        self.failed_over \u003d True"},{"line_number":830,"context_line":"        self.failed_over_backend_name \u003d secondary_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"cb92a3b6_d5e26455","line":827,"range":{"start_line":827,"start_character":8,"end_line":827,"end_character":46},"updated":"2023-07-20 18:38:11.000000000","message":"Do you think it\u0027s better put this inside try/except block to track a possible exception, like call in L815, or you think it is not necessary?","commit_id":"299ee4ba4cfaf74de7b4759c2b67c2bee5fec90c"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"95521ba1fa75cdda3a64b51482f765a290b2502e","unresolved":true,"context_lines":[{"line_number":824,"context_line":"    def _failover_completed(self, context, secondary_id\u003dNone):"},{"line_number":825,"context_line":"        \"\"\"Update volume node when `failover` is completed.\"\"\""},{"line_number":826,"context_line":"        # Update the ZAPI client to the backend we failed over to"},{"line_number":827,"context_line":"        self._update_zapi_client(secondary_id)"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"        self.failed_over \u003d True"},{"line_number":830,"context_line":"        self.failed_over_backend_name \u003d secondary_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"f48fcbdc_c9be6986","line":827,"range":{"start_line":827,"start_character":8,"end_line":827,"end_character":46},"in_reply_to":"cb92a3b6_d5e26455","updated":"2023-07-20 20:24:53.000000000","message":"Nice catch, but I think this is not necessary in this case, since manager handles this exception - https://github.com/openstack/cinder/blob/39c254a50ac755568dce83d39f9c9d291a4d2d1e/cinder/volume/manager.py#L4652 \n\nWDYT?","commit_id":"299ee4ba4cfaf74de7b4759c2b67c2bee5fec90c"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"62d048b95674b672fe8330ce5a20a964b1b67463","unresolved":false,"context_lines":[{"line_number":824,"context_line":"    def _failover_completed(self, context, secondary_id\u003dNone):"},{"line_number":825,"context_line":"        \"\"\"Update volume node when `failover` is completed.\"\"\""},{"line_number":826,"context_line":"        # Update the ZAPI client to the backend we failed over to"},{"line_number":827,"context_line":"        self._update_zapi_client(secondary_id)"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"        self.failed_over \u003d True"},{"line_number":830,"context_line":"        self.failed_over_backend_name \u003d secondary_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"c3d6d5e8_a0d43dde","line":827,"range":{"start_line":827,"start_character":8,"end_line":827,"end_character":46},"in_reply_to":"f48fcbdc_c9be6986","updated":"2023-07-20 20:56:38.000000000","message":"Nice, I think it\u0027s good.","commit_id":"299ee4ba4cfaf74de7b4759c2b67c2bee5fec90c"}]}