)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6765495cd6a78a989a767aa8bab44c66d7fbaa5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f31f3d05_f13bf824","updated":"2023-09-26 16:26:38.000000000","message":"Looks like I need to squash the next patch into this one","commit_id":"2db3b8872346c0dae188160b171b940831491340"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"365aa8f0f74038ab2baff95fbf45efc83d75b761","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"27915d03_25bb92e1","updated":"2023-11-01 15:19:22.000000000","message":"Passing the check and the changes make sense to me.","commit_id":"796b33b8bcd3279fad8698af361763e6331a80ae"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1935843670af88b33f92b8878659929291f76ce5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ce0f57d4_faed893a","updated":"2023-11-13 15:01:17.000000000","message":"The explanation sounds good, LGTM.","commit_id":"9927bdc9b391f715b6cc80c6a6116d21030e07de"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b83115d87f34a56de2048f94e2732b1e88db8541","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4f97689a_0e1ea5a3","updated":"2023-11-09 12:13:56.000000000","message":"change looks good, UTs are passing. Still confirming if we don\u0027t end up in a weird situation where test might start failing because of FK constraint","commit_id":"9927bdc9b391f715b6cc80c6a6116d21030e07de"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f8d7051f8ae9ecdaec9ea3e58a0fb9df096025bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5229338c_f61f7e30","updated":"2023-11-15 06:25:29.000000000","message":"recheck multiple unrelated failures","commit_id":"9927bdc9b391f715b6cc80c6a6116d21030e07de"}],"cinder/tests/unit/db/test_purge.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b83115d87f34a56de2048f94e2732b1e88db8541","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        self.engine \u003d db_api.get_engine()"},{"line_number":42,"context_line":"        if self.engine.url.get_dialect() \u003d\u003d sqlite.dialect:"},{"line_number":43,"context_line":"            with self.engine.connect() as conn:"},{"line_number":44,"context_line":"                conn.connection.execute(\"PRAGMA foreign_keys \u003d ON\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        self.volumes \u003d sqlalchemyutils.get_table("},{"line_number":47,"context_line":"            self.engine, \"volumes\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"c2492406_a2c69a8c","line":44,"range":{"start_line":44,"start_character":41,"end_line":44,"end_character":65},"updated":"2023-11-09 12:13:56.000000000","message":"will this have any effect on other tests (apart from the intended ones) since we are doing this for all tests now?","commit_id":"9927bdc9b391f715b6cc80c6a6116d21030e07de"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3443fe3e90df01a212c5821598fad080b4d2f0de","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.engine \u003d db_api.get_engine()"},{"line_number":42,"context_line":"        if self.engine.url.get_dialect() \u003d\u003d sqlite.dialect:"},{"line_number":43,"context_line":"            with self.engine.connect() as conn:"},{"line_number":44,"context_line":"                conn.connection.execute(\"PRAGMA foreign_keys \u003d ON\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        self.volumes \u003d sqlalchemyutils.get_table("},{"line_number":47,"context_line":"            self.engine, \"volumes\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"05cb5d94_c818558a","line":44,"range":{"start_line":44,"start_character":41,"end_line":44,"end_character":65},"in_reply_to":"58e32e63_97b58501","updated":"2023-11-10 11:16:39.000000000","message":"Done","commit_id":"9927bdc9b391f715b6cc80c6a6116d21030e07de"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"21546f48ed8d89df5ae0a407ad19233bd1cdb9a8","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        self.engine \u003d db_api.get_engine()"},{"line_number":42,"context_line":"        if self.engine.url.get_dialect() \u003d\u003d sqlite.dialect:"},{"line_number":43,"context_line":"            with self.engine.connect() as conn:"},{"line_number":44,"context_line":"                conn.connection.execute(\"PRAGMA foreign_keys \u003d ON\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        self.volumes \u003d sqlalchemyutils.get_table("},{"line_number":47,"context_line":"            self.engine, \"volumes\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"58e32e63_97b58501","line":44,"range":{"start_line":44,"start_character":41,"end_line":44,"end_character":65},"in_reply_to":"c2492406_a2c69a8c","updated":"2023-11-10 11:14:12.000000000","message":"No. The connection is still an in-memory database and a new one is created per test (via the `Database` fixture). As such, this only affects the database used in each individual test.\n\nThe [first revision of this patch](https://review.opendev.org/c/openstack/cinder/+/887033/1/cinder/db/sqlalchemy/api.py) attempted to enable foreign keys globally and the number of failures was, ahem, rather large 😅 That we don\u0027t see such failures here, even when running with `--random`, is also practical evidence.","commit_id":"9927bdc9b391f715b6cc80c6a6116d21030e07de"}]}