)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"9be61f7b04eed3e1e19338bd2960ce769ab30764","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1a807eea_761077e8","updated":"2023-07-12 04:00:55.000000000","message":"recheck cinder-plugin-ceph-tempest cinder-grenade-mn-sub-volbak tempest-slow-py3","commit_id":"fa4b9585f12801a69be4109ff8a796b591913d70"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"72135220a28438a6004905000f5013d127d4aeae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dba57de9_b152872b","updated":"2023-07-11 08:16:30.000000000","message":"recheck openstack-tox-docs tempest-integrated-storage","commit_id":"fa4b9585f12801a69be4109ff8a796b591913d70"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"f8f66833eb7399e2798f59cdbc0ab400804d87f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"31ebe961_ea7d4faf","updated":"2023-07-12 09:39:58.000000000","message":"recheck tempest-slow-py3","commit_id":"fa4b9585f12801a69be4109ff8a796b591913d70"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"e97f76e40cf809fb65f858254b3279c2935684c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9b248de5_8116026e","updated":"2023-07-11 03:05:47.000000000","message":"recheck tempest-slow-py3","commit_id":"fa4b9585f12801a69be4109ff8a796b591913d70"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"5fe592df842b33d2358d8747ae8f84cc3d092062","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d57bee21_4d7ec1e8","updated":"2023-07-11 11:34:10.000000000","message":"recheck tempest-slow-py3","commit_id":"fa4b9585f12801a69be4109ff8a796b591913d70"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"e882be8e4757a44e0fd67ab65690c8fabe802abc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c4c3ea18_17006487","updated":"2023-07-17 03:48:22.000000000","message":"run-DellEMC PowerStore CI","commit_id":"fa4b9585f12801a69be4109ff8a796b591913d70"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"89f129093b4337caa5d16569eab9fb5237a90871","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"00ef1fb9_305b4acc","updated":"2023-07-13 12:26:53.000000000","message":"run-HPE Storage CI","commit_id":"fa4b9585f12801a69be4109ff8a796b591913d70"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"5989c20c51f55bdea67815879efa2827ae83a9bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f846872_a27c8949","updated":"2023-07-12 12:01:34.000000000","message":"run-HPE Storage CI","commit_id":"fa4b9585f12801a69be4109ff8a796b591913d70"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8db939eb718913407e9bf83ce4596e5f734dcb21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"89e5a452_a28c7477","updated":"2023-07-18 09:46:12.000000000","message":"run-HPE Storage CI","commit_id":"fa4b9585f12801a69be4109ff8a796b591913d70"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"9e50e696c30aa40179673496cadbebb2b945dfe5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"979dd015_58057ca9","updated":"2023-07-18 07:23:10.000000000","message":"run-HPE Storage CI","commit_id":"fa4b9585f12801a69be4109ff8a796b591913d70"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"d16fba6fbbd097090ce22499e2163bb4826fce47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cf49ed15_35313ea5","updated":"2023-07-28 11:39:38.000000000","message":"recheck cinder-grenade-mn-sub-volbak tempest-slow-py3","commit_id":"f4d9df0fcbb0d449b365dfe48b987b1880e2a264"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"358a858f5a454f0b8352cb955c8d110ab6c1d5e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ca91f53d_9fef68fd","updated":"2023-07-28 06:22:25.000000000","message":"recheck cinder-plugin-ceph-tempest","commit_id":"f4d9df0fcbb0d449b365dfe48b987b1880e2a264"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"0be14d74b755dcec226fc4e2b6ef226ccd61225e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"07b2add6_712ce29c","updated":"2023-07-28 09:01:32.000000000","message":"recheck cinder-plugin-ceph-tempest tempest-slow-py3","commit_id":"f4d9df0fcbb0d449b365dfe48b987b1880e2a264"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"0832b91fa054905acdff9d2b4493c095556cc427","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ffe98b5c_7cf6cf18","updated":"2023-07-29 09:11:32.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican","commit_id":"f4d9df0fcbb0d449b365dfe48b987b1880e2a264"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"b28d38dc6f1413687185ae1fbb7a55e774be66ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e772d8d9_83b90a5d","updated":"2023-07-28 02:45:18.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican tempest-slow-py3","commit_id":"f4d9df0fcbb0d449b365dfe48b987b1880e2a264"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"910f64b68ae0c42ab56df422d472836dd26fc0e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7295e4bb_3a86d006","updated":"2023-07-28 10:24:00.000000000","message":"run-HPE Storage CI","commit_id":"f4d9df0fcbb0d449b365dfe48b987b1880e2a264"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"bb81fd676fce41ece550db7d028fd0811fdc894c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7859d0b5_1988a9ca","updated":"2023-07-28 05:37:51.000000000","message":"run-HPE Storage CI","commit_id":"f4d9df0fcbb0d449b365dfe48b987b1880e2a264"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"6a6aef8ac3f90867bb88728d0ac1aad008a7231e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8b5a3bc0_5ce1aaa2","updated":"2023-07-27 15:26:27.000000000","message":"run-HPE Storage CI","commit_id":"f4d9df0fcbb0d449b365dfe48b987b1880e2a264"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"feba9e823a0f31ed22b55c8f82bce154df8cd3f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"93e475e0_edc6ed1e","updated":"2023-07-28 02:47:42.000000000","message":"run-HPE Storage CI","commit_id":"f4d9df0fcbb0d449b365dfe48b987b1880e2a264"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"0bea073c836264fef99ebb71b6df9e2cdcb933d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b1ba5d0f_f28e2890","updated":"2023-07-28 07:19:20.000000000","message":"run-HPE Storage CI","commit_id":"f4d9df0fcbb0d449b365dfe48b987b1880e2a264"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"347db14049935ca0b6d0c04867de7e521e87436d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d8437f11_5da6a254","updated":"2023-07-28 09:09:26.000000000","message":"run-HPE Storage CI","commit_id":"f4d9df0fcbb0d449b365dfe48b987b1880e2a264"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8e6a3aea9cbebda58701057e953c74e3ec94d50c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b1a04399_3b494638","updated":"2023-08-04 12:05:24.000000000","message":"recheck - failures occurred due to time_out","commit_id":"856e091abae9a0810da6d1b19ac290eae8bf26ad"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"e83a742d7fce6f01a15072038ca5b229af2e1940","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"893a1786_8f3f8953","updated":"2023-08-03 11:25:51.000000000","message":"recheck cinder-plugin-ceph-tempest cinder-tempest-plugin-lvm-lio-barbican cinder-grenade-mn-sub-volbak","commit_id":"856e091abae9a0810da6d1b19ac290eae8bf26ad"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"b00b0ac4ff5df7df9d1491eb1f23b6dc2f4773ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"766f585a_436c87e9","updated":"2023-08-04 04:23:26.000000000","message":"recheck tests - tempest-integrated-storage cinder-tempest-plugin-lvm-lio-barbican cinder-grenade-mn-sub-volbak tempest-slow-py3","commit_id":"856e091abae9a0810da6d1b19ac290eae8bf26ad"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"0638b9ee7919cbddd03d7fd638f62161be26cc2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"201bf103_5c969cc7","updated":"2023-08-04 04:40:07.000000000","message":"run-HPE Storage CI","commit_id":"856e091abae9a0810da6d1b19ac290eae8bf26ad"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"74196e18d0dcc51c1a9ba3905e6815ab1161b37a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6dd36eb7_08059d5c","updated":"2023-08-03 11:26:40.000000000","message":"run-HPE Storage CI","commit_id":"856e091abae9a0810da6d1b19ac290eae8bf26ad"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"5347f96dab584af1749fdbb72085c6433dc63762","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"e990425d_d6b17ec8","updated":"2023-08-17 04:22:30.000000000","message":"recheck cinder-plugin-ceph-tempest","commit_id":"2a725637255e9055d2cd421a6aa7655aecee68f5"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"aa2ec59f688510fff463976ad2aa456908f519e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"436c0906_51214d1c","updated":"2023-08-16 13:58:37.000000000","message":"recheck tempest-integrated-storage cinder-plugin-ceph-tempest cinder-tempest-plugin-lvm-lio-barbican","commit_id":"2a725637255e9055d2cd421a6aa7655aecee68f5"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"209b34de74c41538061d18596f47432efd8ab6c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"add0ccbe_950bbad4","updated":"2023-08-16 11:26:18.000000000","message":"run-HPE Storage CI","commit_id":"2a725637255e9055d2cd421a6aa7655aecee68f5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c4c5ea7bd64c27751146196aa2e37b18fe6a7a28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"2eb07378_e5f3ca30","updated":"2023-09-15 14:32:11.000000000","message":"few comments inline","commit_id":"ba8556ba89a2064cb29ca393c107a2e5ac230a44"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"90306c1c172806f494d551f3a448ad673bdf52e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1f5202a2_c3b404d4","updated":"2023-09-15 08:10:30.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"ba8556ba89a2064cb29ca393c107a2e5ac230a44"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"9ccf2de5972ff9cf9d19219c433a9e2258a8d320","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"2afb9f8c_c2488001","updated":"2023-09-19 02:03:09.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"ba8556ba89a2064cb29ca393c107a2e5ac230a44"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"23f2df617b723fdfc65eaef4fc8060628879df1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"54ce95f7_70de3c28","updated":"2023-09-15 08:02:26.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"ba8556ba89a2064cb29ca393c107a2e5ac230a44"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"b5f84fe50b346e24f93452da44178e29918d3a0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7561d479_674f1b6b","updated":"2023-09-18 02:34:27.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"ba8556ba89a2064cb29ca393c107a2e5ac230a44"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"8e812dd2c76239adb81b41e46589c35c0eab0b59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"a78108b8_54a67dbc","updated":"2023-09-15 07:33:13.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"ba8556ba89a2064cb29ca393c107a2e5ac230a44"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"6dd477f88bd4c36fa31938627e1ca38108e67e12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"dc4323c7_e1a70ea9","updated":"2023-09-15 08:15:54.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"ba8556ba89a2064cb29ca393c107a2e5ac230a44"},{"author":{"_account_id":35822,"name":"Senthil Vasudevan","display_name":"HPE AlletraMP FC CI","email":"senthil.vasudevan@hpe.com","username":"senthilv"},"change_message_id":"289b6857b47214d085a45ff40e64908bf57f7ca9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"041550d9_5864800d","updated":"2023-09-19 06:05:03.000000000","message":"run-HPE Storage CI","commit_id":"ba8556ba89a2064cb29ca393c107a2e5ac230a44"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"a11fe982684c83bc6c93aa8b6a23eda939f212f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"627f6ea7_8f88ff14","updated":"2023-09-15 11:17:22.000000000","message":"run-HPE Storage CI","commit_id":"ba8556ba89a2064cb29ca393c107a2e5ac230a44"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"81652204201f193bc4eca526b5ab91c186e58688","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"58f4b714_0a36644e","updated":"2023-10-04 06:20:18.000000000","message":"Hi Rajat,\nIt would be great to know your opinion. Thanks.","commit_id":"e1656c6b9b60a12b500e46a96de01b5b7f4c7a7b"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"cd55de87735867c5e8b00bc470dc3104f6d604f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"6a9a441c_ed0f3c1e","updated":"2023-09-19 13:34:36.000000000","message":"Hi Rajat,\ni tried to address review comments in Patchset 13.\nIt would be great to know your feedback.\nThanks.","commit_id":"e1656c6b9b60a12b500e46a96de01b5b7f4c7a7b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5aa0cdb5cd4aec7fc3a407826d2584e8742b8276","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"877893de_c47ce684","updated":"2023-10-10 02:24:49.000000000","message":"I don\u0027t know much about the backend, so I can\u0027t really say much about the logic, but I don\u0027t seen anything concerning in the Python.  Question inline about your function that renames the migrated vvset.","commit_id":"e1656c6b9b60a12b500e46a96de01b5b7f4c7a7b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f83778edc2b04ac2de1b4a5aaa945f0a5b7e4265","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"e6f2edaf_a0929a48","updated":"2023-10-04 16:41:35.000000000","message":"I\u0027m still not 100% certain i understand all the things going on here but don\u0027t want to hold this up for other reviewers!","commit_id":"e1656c6b9b60a12b500e46a96de01b5b7f4c7a7b"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"cac8affa20d114f1a62806380be5f717db01c4fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"f1306e4c_942e4601","updated":"2023-09-28 08:44:22.000000000","message":"Thanks Hemna","commit_id":"e1656c6b9b60a12b500e46a96de01b5b7f4c7a7b"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"eb0f0e333fc8bc2e2cbbde8d8a4f5a1dc76e7373","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"f1b13cf6_2dd9edc0","updated":"2023-10-05 04:17:09.000000000","message":"Thanks Rajat","commit_id":"e1656c6b9b60a12b500e46a96de01b5b7f4c7a7b"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"2203a22a7e56ebf7fcbe9197325301a92e401161","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"0b0b22c7_dd76904b","updated":"2023-09-28 12:44:44.000000000","message":"Thanks Rajat for feedback.\n\nPlease find response inline.","commit_id":"e1656c6b9b60a12b500e46a96de01b5b7f4c7a7b"},{"author":{"_account_id":35822,"name":"Senthil Vasudevan","display_name":"HPE AlletraMP FC CI","email":"senthil.vasudevan@hpe.com","username":"senthilv"},"change_message_id":"cad181c282963f5c4ddfcc64ba749bbcc8c20756","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"284d160c_5f922fdb","updated":"2023-09-22 11:54:05.000000000","message":"run-HPE Storage CI","commit_id":"e1656c6b9b60a12b500e46a96de01b5b7f4c7a7b"},{"author":{"_account_id":35822,"name":"Senthil Vasudevan","display_name":"HPE AlletraMP FC CI","email":"senthil.vasudevan@hpe.com","username":"senthilv"},"change_message_id":"7bf26044b9d36594823adcaa48ed6a2b7f9df631","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"29a84253_6342cd9e","updated":"2023-09-28 03:22:48.000000000","message":"run-HPE Storage CI","commit_id":"e1656c6b9b60a12b500e46a96de01b5b7f4c7a7b"},{"author":{"_account_id":35822,"name":"Senthil Vasudevan","display_name":"HPE AlletraMP FC CI","email":"senthil.vasudevan@hpe.com","username":"senthilv"},"change_message_id":"0daca66127f3f275b4d6fa6b9bfcc77ee35b2cde","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"41609285_34a38416","updated":"2023-09-28 04:31:27.000000000","message":"run-HPE Storage CI","commit_id":"e1656c6b9b60a12b500e46a96de01b5b7f4c7a7b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5599e2612f31c9bbe26530c839d0aa0056bb259a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"338ba33d_cc3b87bf","updated":"2023-10-10 11:46:40.000000000","message":"Revision LGTM.  Only a +1 while waiting for HPE Storage CI to be green.","commit_id":"aed9f1800f3a08da1af2a11ad153e9a3bdbe1e74"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"3fa2138d20ec0a84ede8ace4df963043a6b1c7ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"7e5832e8_24d31b73","updated":"2023-10-10 12:01:53.000000000","message":"Thanks Brian","commit_id":"aed9f1800f3a08da1af2a11ad153e9a3bdbe1e74"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"bfd223b54b766ed64c9b43594af53b80cb93fd08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"8c8be838_1ff9071a","updated":"2023-10-10 10:04:22.000000000","message":"Thanks Brian for feedback.\ni addressed one comment in new patchset (PS 14) \u0026 replied to the other comment.","commit_id":"aed9f1800f3a08da1af2a11ad153e9a3bdbe1e74"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"48d1500d145b5cf5422e4a26af2d15627f1270ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"30377e40_5bd666ed","updated":"2023-10-10 11:46:44.000000000","message":"run-HPE Storage CI","commit_id":"aed9f1800f3a08da1af2a11ad153e9a3bdbe1e74"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"f75e497e818b5e9e238a3e52610b1399023c7e75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"cb4faf1f_1d5182b2","updated":"2023-12-08 04:49:47.000000000","message":"run-HPE Storage CI","commit_id":"aed9f1800f3a08da1af2a11ad153e9a3bdbe1e74"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"3be3f7c90e00f024f8b6094f59a1a8ba4019012c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"54acefd4_98733c55","updated":"2023-12-11 05:57:37.000000000","message":"Hi Brian/Hemna,\nThis patch was reviewed couple of months ago. At that time, CI had failed.\nNow the HPE Storage CI has passed (on Dec 8th).\nAlso performed a rebase \u0026 zuul passed too (on Dec 9th).\nIt would be great if you can provide feedback. Thanks.","commit_id":"7e8b87c40e4dcb17bad1352c766183cdba674e16"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a92dad4449a8553bc4587b16b458add94b1aa2b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"86284b78_27d71f94","updated":"2023-12-12 15:43:23.000000000","message":"Sorry I lost track of this one.  Zuul and third-party CI are happy.","commit_id":"7e8b87c40e4dcb17bad1352c766183cdba674e16"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8f9cb097a884d92f023227946feb8ed0d98cd01a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"706eba1c_5d1842ef","updated":"2023-12-13 06:27:42.000000000","message":"Thank you Brian","commit_id":"7e8b87c40e4dcb17bad1352c766183cdba674e16"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c2078e169378d28ae6542a6d5feb80569949ddb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"baba1b83_c935eeee","updated":"2023-12-13 10:46:07.000000000","message":"one question inline and a concern regarding Unit tests","commit_id":"7e8b87c40e4dcb17bad1352c766183cdba674e16"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"9b778780f309e982e063d3411822bc6e12416fde","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"39c06c3f_40a1fadf","updated":"2023-12-09 05:44:25.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican","commit_id":"7e8b87c40e4dcb17bad1352c766183cdba674e16"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"5f3cad8f6de5f644cf775177524475bf6105edcf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"25e3933a_aa8700e7","updated":"2023-12-08 12:20:49.000000000","message":"recheck tempest-integrated-storage tempest-slow-py3","commit_id":"7e8b87c40e4dcb17bad1352c766183cdba674e16"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fb79c28b669d3fbc46a04cd2c16ff915902c89da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"361daf60_e857c928","updated":"2023-12-15 07:30:16.000000000","message":"My comments are addressed. HPE CI is passing. LGTM.\nThanks Raghavendra","commit_id":"74c5ec0ab1ed94446f8ed81c3561adcaf462732d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f3e77232937e4926578da02b3d228dca6f2bd5ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"5ff334dd_4837942b","updated":"2023-12-14 16:47:17.000000000","message":"Revisions since PS 15 LGTM.  I\u0027m going to leave a +2 on the assumption that the second core reviewer will check to make sure the third-party CI is green before giving a +W.","commit_id":"74c5ec0ab1ed94446f8ed81c3561adcaf462732d"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"4bc8b9e8c7f74fb402dc86a5801a1c037c38d5da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"99aee0b2_6f95c68b","updated":"2023-12-15 04:33:20.000000000","message":"Thank you Brian. The CI has passed too.","commit_id":"74c5ec0ab1ed94446f8ed81c3561adcaf462732d"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"d918c1931c9be41a4989920ff655616fcf293dd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"79d0e787_32cfab9c","updated":"2023-12-15 10:01:22.000000000","message":"Thank you Rajat.","commit_id":"74c5ec0ab1ed94446f8ed81c3561adcaf462732d"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"f5bca452ece399b7be4b8e39527f93b23d516d58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"c9600374_e171e3cf","updated":"2023-12-14 07:54:39.000000000","message":"Thanks Rajat for feedback.\ni added a UT (test_rename_migrated_vvset) \u0026 replied to other comment.","commit_id":"74c5ec0ab1ed94446f8ed81c3561adcaf462732d"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"9d9e8d5287eead254696234fe28759a34bb16260","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"c73a0e5c_8b0a1db2","updated":"2023-12-14 10:55:30.000000000","message":"run-HPE Storage CI","commit_id":"74c5ec0ab1ed94446f8ed81c3561adcaf462732d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"39f93e49b9533940222d5de2af0d3b4e982fab1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"dbe185ee_25d8833a","updated":"2023-12-14 16:46:15.000000000","message":"run-HPE Storage CI","commit_id":"74c5ec0ab1ed94446f8ed81c3561adcaf462732d"}],"cinder/volume/drivers/hpe/hpe_3par_common.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c4c5ea7bd64c27751146196aa2e37b18fe6a7a28","unresolved":true,"context_lines":[{"line_number":2704,"context_line":"            raise exception.CinderException(ex)"},{"line_number":2705,"context_line":""},{"line_number":2706,"context_line":"    def delete_volume(self, volume):"},{"line_number":2707,"context_line":"        vol_id \u003d volume[\u0027id\u0027]"},{"line_number":2708,"context_line":"        name_id \u003d volume.get(\u0027_name_id\u0027)"},{"line_number":2709,"context_line":"        LOG.debug(\"DELETE volume vol_id: %(vol_id)s, name_id: %(name_id)s\","},{"line_number":2710,"context_line":"                  {\u0027vol_id\u0027: vol_id, \u0027name_id\u0027: name_id})"}],"source_content_type":"text/x-python","patch_set":12,"id":"a3952465_b2e8f8a1","line":2707,"range":{"start_line":2707,"start_character":17,"end_line":2707,"end_character":29},"updated":"2023-09-15 14:32:11.000000000","message":"isn\u0027t volume an OVO object here? if yes, we can do volume.id","commit_id":"ba8556ba89a2064cb29ca393c107a2e5ac230a44"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"cd55de87735867c5e8b00bc470dc3104f6d604f0","unresolved":false,"context_lines":[{"line_number":2704,"context_line":"            raise exception.CinderException(ex)"},{"line_number":2705,"context_line":""},{"line_number":2706,"context_line":"    def delete_volume(self, volume):"},{"line_number":2707,"context_line":"        vol_id \u003d volume[\u0027id\u0027]"},{"line_number":2708,"context_line":"        name_id \u003d volume.get(\u0027_name_id\u0027)"},{"line_number":2709,"context_line":"        LOG.debug(\"DELETE volume vol_id: %(vol_id)s, name_id: %(name_id)s\","},{"line_number":2710,"context_line":"                  {\u0027vol_id\u0027: vol_id, \u0027name_id\u0027: name_id})"}],"source_content_type":"text/x-python","patch_set":12,"id":"089f0d21_43bddb31","line":2707,"range":{"start_line":2707,"start_character":17,"end_line":2707,"end_character":29},"in_reply_to":"a3952465_b2e8f8a1","updated":"2023-09-19 13:34:36.000000000","message":"Done","commit_id":"ba8556ba89a2064cb29ca393c107a2e5ac230a44"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c4c5ea7bd64c27751146196aa2e37b18fe6a7a28","unresolved":true,"context_lines":[{"line_number":3112,"context_line":"        vvs_name_src \u003d self._get_3par_vvs_name(src_volume[\u0027id\u0027])"},{"line_number":3113,"context_line":"        vvs_name_dest \u003d self._get_3par_vvs_name(dest_volume[\u0027id\u0027])"},{"line_number":3114,"context_line":""},{"line_number":3115,"context_line":"        # There can be parallel execution. Ensure that temp_vvs_name is unique"},{"line_number":3116,"context_line":"        # eg. if vvs_name_src is: vvs-DK3sEwkPTCqVHdHKHtwZBA"},{"line_number":3117,"context_line":"        # then temp_vvs_name is : tos-DK3sEwkPTCqVHdHKHtwZBA"},{"line_number":3118,"context_line":"        temp_vvs_name \u003d \u0027tos-\u0027 + vvs_name_src[4:]"}],"source_content_type":"text/x-python","patch_set":12,"id":"c2534268_9ec7afe2","line":3115,"range":{"start_line":3115,"start_character":10,"end_line":3115,"end_character":42},"updated":"2023-09-15 14:32:11.000000000","message":"doesn\u0027t parallel execution cause race conditions here?\nEg:\n\nsrc -\u003e source\ndest -\u003e destination\ntemp -\u003e temporary\n\nwhile renaming dest -\u003e temp, if we try to rename src to dest, it will fail right?\nUntil destination is completely renamed to temp, the volume file with name dest will remain?","commit_id":"ba8556ba89a2064cb29ca393c107a2e5ac230a44"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"cd55de87735867c5e8b00bc470dc3104f6d604f0","unresolved":false,"context_lines":[{"line_number":3112,"context_line":"        vvs_name_src \u003d self._get_3par_vvs_name(src_volume[\u0027id\u0027])"},{"line_number":3113,"context_line":"        vvs_name_dest \u003d self._get_3par_vvs_name(dest_volume[\u0027id\u0027])"},{"line_number":3114,"context_line":""},{"line_number":3115,"context_line":"        # There can be parallel execution. Ensure that temp_vvs_name is unique"},{"line_number":3116,"context_line":"        # eg. if vvs_name_src is: vvs-DK3sEwkPTCqVHdHKHtwZBA"},{"line_number":3117,"context_line":"        # then temp_vvs_name is : tos-DK3sEwkPTCqVHdHKHtwZBA"},{"line_number":3118,"context_line":"        temp_vvs_name \u003d \u0027tos-\u0027 + vvs_name_src[4:]"}],"source_content_type":"text/x-python","patch_set":12,"id":"352ca759_de660861","line":3115,"range":{"start_line":3115,"start_character":10,"end_line":3115,"end_character":42},"in_reply_to":"c2534268_9ec7afe2","updated":"2023-09-19 13:34:36.000000000","message":"By parallel execution, i meant ... two volumes are retyped at same time.\nIn such case, if temp_vvs_name is something just like \u0027temp_vvs\u0027, it would cause conflict. So, using part of vvs_name_src in temp_vvs_name.\n\nBelow operations would occur serially:\ndest -\u003e temp\nsrc  -\u003e dest\ntemp -\u003e src","commit_id":"ba8556ba89a2064cb29ca393c107a2e5ac230a44"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c4c5ea7bd64c27751146196aa2e37b18fe6a7a28","unresolved":true,"context_lines":[{"line_number":3117,"context_line":"        # then temp_vvs_name is : tos-DK3sEwkPTCqVHdHKHtwZBA"},{"line_number":3118,"context_line":"        temp_vvs_name \u003d \u0027tos-\u0027 + vvs_name_src[4:]"},{"line_number":3119,"context_line":""},{"line_number":3120,"context_line":"        try:"},{"line_number":3121,"context_line":"            LOG.debug(\"Renaming vvset %(old)s to %(new)s\","},{"line_number":3122,"context_line":"                      {\u0027old\u0027: vvs_name_dest, \u0027new\u0027: temp_vvs_name})"},{"line_number":3123,"context_line":"            self.client.modifyVolumeSet(vvs_name_dest, newName\u003dtemp_vvs_name)"},{"line_number":3124,"context_line":"        except Exception as ex:"},{"line_number":3125,"context_line":"            LOG.error(\"exception: %(details)s\", {\u0027details\u0027: str(ex)})"},{"line_number":3126,"context_line":""},{"line_number":3127,"context_line":"        try:"},{"line_number":3128,"context_line":"            LOG.debug(\"Renaming vvset %(old)s to %(new)s\","},{"line_number":3129,"context_line":"                      {\u0027old\u0027: vvs_name_src, \u0027new\u0027: vvs_name_dest})"},{"line_number":3130,"context_line":"            self.client.modifyVolumeSet(vvs_name_src, newName\u003dvvs_name_dest)"},{"line_number":3131,"context_line":"        except Exception as ex:"},{"line_number":3132,"context_line":"            LOG.error(\"exception: %(details)s\", {\u0027details\u0027: str(ex)})"},{"line_number":3133,"context_line":""},{"line_number":3134,"context_line":"        try:"},{"line_number":3135,"context_line":"            LOG.debug(\"Renaming vvset %(old)s to %(new)s\","},{"line_number":3136,"context_line":"                      {\u0027old\u0027: temp_vvs_name, \u0027new\u0027: vvs_name_src})"},{"line_number":3137,"context_line":"            self.client.modifyVolumeSet(temp_vvs_name, newName\u003dvvs_name_src)"},{"line_number":3138,"context_line":"        except Exception as ex:"},{"line_number":3139,"context_line":"            LOG.error(\"exception: %(details)s\", {\u0027details\u0027: str(ex)})"},{"line_number":3140,"context_line":""},{"line_number":3141,"context_line":"    def update_migrated_volume(self, context, volume, new_volume,"},{"line_number":3142,"context_line":"                               original_volume_status):"}],"source_content_type":"text/x-python","patch_set":12,"id":"3b49a2a0_50bc3495","line":3139,"range":{"start_line":3120,"start_character":8,"end_line":3139,"end_character":69},"updated":"2023-09-15 14:32:11.000000000","message":"i guess there isn\u0027t a more efficient way to do the swapping of file names","commit_id":"ba8556ba89a2064cb29ca393c107a2e5ac230a44"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"cd55de87735867c5e8b00bc470dc3104f6d604f0","unresolved":false,"context_lines":[{"line_number":3117,"context_line":"        # then temp_vvs_name is : tos-DK3sEwkPTCqVHdHKHtwZBA"},{"line_number":3118,"context_line":"        temp_vvs_name \u003d \u0027tos-\u0027 + vvs_name_src[4:]"},{"line_number":3119,"context_line":""},{"line_number":3120,"context_line":"        try:"},{"line_number":3121,"context_line":"            LOG.debug(\"Renaming vvset %(old)s to %(new)s\","},{"line_number":3122,"context_line":"                      {\u0027old\u0027: vvs_name_dest, \u0027new\u0027: temp_vvs_name})"},{"line_number":3123,"context_line":"            self.client.modifyVolumeSet(vvs_name_dest, newName\u003dtemp_vvs_name)"},{"line_number":3124,"context_line":"        except Exception as ex:"},{"line_number":3125,"context_line":"            LOG.error(\"exception: %(details)s\", {\u0027details\u0027: str(ex)})"},{"line_number":3126,"context_line":""},{"line_number":3127,"context_line":"        try:"},{"line_number":3128,"context_line":"            LOG.debug(\"Renaming vvset %(old)s to %(new)s\","},{"line_number":3129,"context_line":"                      {\u0027old\u0027: vvs_name_src, \u0027new\u0027: vvs_name_dest})"},{"line_number":3130,"context_line":"            self.client.modifyVolumeSet(vvs_name_src, newName\u003dvvs_name_dest)"},{"line_number":3131,"context_line":"        except Exception as ex:"},{"line_number":3132,"context_line":"            LOG.error(\"exception: %(details)s\", {\u0027details\u0027: str(ex)})"},{"line_number":3133,"context_line":""},{"line_number":3134,"context_line":"        try:"},{"line_number":3135,"context_line":"            LOG.debug(\"Renaming vvset %(old)s to %(new)s\","},{"line_number":3136,"context_line":"                      {\u0027old\u0027: temp_vvs_name, \u0027new\u0027: vvs_name_src})"},{"line_number":3137,"context_line":"            self.client.modifyVolumeSet(temp_vvs_name, newName\u003dvvs_name_src)"},{"line_number":3138,"context_line":"        except Exception as ex:"},{"line_number":3139,"context_line":"            LOG.error(\"exception: %(details)s\", {\u0027details\u0027: str(ex)})"},{"line_number":3140,"context_line":""},{"line_number":3141,"context_line":"    def update_migrated_volume(self, context, volume, new_volume,"},{"line_number":3142,"context_line":"                               original_volume_status):"}],"source_content_type":"text/x-python","patch_set":12,"id":"ec5a0102_5b3c19d1","line":3139,"range":{"start_line":3120,"start_character":8,"end_line":3139,"end_character":69},"in_reply_to":"3b49a2a0_50bc3495","updated":"2023-09-19 13:34:36.000000000","message":"Agreed","commit_id":"ba8556ba89a2064cb29ca393c107a2e5ac230a44"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3491bbf630f70e2e3db235f7b3b219bd8c1575e8","unresolved":true,"context_lines":[{"line_number":1466,"context_line":"    def _get_3par_rcg_name(self, volume):"},{"line_number":1467,"context_line":"        # if non-replicated volume is retyped or migrated to replicated vol,"},{"line_number":1468,"context_line":"        # then rcg_name is different. Try to get that new rcg_name."},{"line_number":1469,"context_line":"        if volume[\u0027migration_status\u0027] \u003d\u003d \u0027success\u0027:"},{"line_number":1470,"context_line":"            vol_name \u003d self._get_3par_vol_name(volume)"},{"line_number":1471,"context_line":"            vol_details \u003d self.client.getVolume(vol_name)"},{"line_number":1472,"context_line":"            rcg_name \u003d vol_details.get(\u0027rcopyGroup\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"c3482112_465d8b4b","line":1469,"range":{"start_line":1469,"start_character":8,"end_line":1469,"end_character":50},"updated":"2023-09-28 10:09:21.000000000","message":"This doesn\u0027t seem to be a good validation check.\nIIUC, after a migration is successful, this field is always set to success\nIf an operation, let\u0027s say revert to snapshot, calls this method right after a successful migration, this if will evaluate to true which seems incorrect.\nShouldn\u0027t we just call this method internally after a migration with a parameter migration\u003dTrue?","commit_id":"e1656c6b9b60a12b500e46a96de01b5b7f4c7a7b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f83778edc2b04ac2de1b4a5aaa945f0a5b7e4265","unresolved":false,"context_lines":[{"line_number":1466,"context_line":"    def _get_3par_rcg_name(self, volume):"},{"line_number":1467,"context_line":"        # if non-replicated volume is retyped or migrated to replicated vol,"},{"line_number":1468,"context_line":"        # then rcg_name is different. Try to get that new rcg_name."},{"line_number":1469,"context_line":"        if volume[\u0027migration_status\u0027] \u003d\u003d \u0027success\u0027:"},{"line_number":1470,"context_line":"            vol_name \u003d self._get_3par_vol_name(volume)"},{"line_number":1471,"context_line":"            vol_details \u003d self.client.getVolume(vol_name)"},{"line_number":1472,"context_line":"            rcg_name \u003d vol_details.get(\u0027rcopyGroup\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"bab0b62d_3fdbf6c0","line":1469,"range":{"start_line":1469,"start_character":8,"end_line":1469,"end_character":50},"in_reply_to":"08aa51f3_57828594","updated":"2023-10-04 16:41:35.000000000","message":"Ack","commit_id":"e1656c6b9b60a12b500e46a96de01b5b7f4c7a7b"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"2203a22a7e56ebf7fcbe9197325301a92e401161","unresolved":true,"context_lines":[{"line_number":1466,"context_line":"    def _get_3par_rcg_name(self, volume):"},{"line_number":1467,"context_line":"        # if non-replicated volume is retyped or migrated to replicated vol,"},{"line_number":1468,"context_line":"        # then rcg_name is different. Try to get that new rcg_name."},{"line_number":1469,"context_line":"        if volume[\u0027migration_status\u0027] \u003d\u003d \u0027success\u0027:"},{"line_number":1470,"context_line":"            vol_name \u003d self._get_3par_vol_name(volume)"},{"line_number":1471,"context_line":"            vol_details \u003d self.client.getVolume(vol_name)"},{"line_number":1472,"context_line":"            rcg_name \u003d vol_details.get(\u0027rcopyGroup\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"08aa51f3_57828594","line":1469,"range":{"start_line":1469,"start_character":8,"end_line":1469,"end_character":50},"in_reply_to":"c3482112_465d8b4b","updated":"2023-09-28 12:44:44.000000000","message":"For normal replicated volumes (which aren\u0027t migrated),\nthe rcg name (on 3par array) matches with vol name (on 3par array).\nEg. suppose vol name is osv-abcd then rcg name would be rcg-abcd.\n\nAfter retype of single volume to replicated vol,\nthe rcg name (on 3par array) doesn\u0027t exactly match with vol name (on 3par array).\nEg. if vol name is osv-abcd then rcg name could be rcg-wxyz (just an example).\n\nSo after migration of such vol, if another operation is done; eg. revert_to_snapshot(),\nthen these operations would require correct rcg name (i.e rcg-wxyz) instead of default rcg name (i.e rcg-abcd).\n\nThus, the condition ... if volume[\u0027migration_status\u0027] \u003d\u003d \u0027success\u0027:\nworks well for further operations [like revert_to_snapshot, etc]\n\nPlease let me know if i was able to explain properly.","commit_id":"e1656c6b9b60a12b500e46a96de01b5b7f4c7a7b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5aa0cdb5cd4aec7fc3a407826d2584e8742b8276","unresolved":true,"context_lines":[{"line_number":3119,"context_line":"        temp_vvs_name \u003d \u0027tos-\u0027 + vvs_name_src[4:]"},{"line_number":3120,"context_line":""},{"line_number":3121,"context_line":"        try:"},{"line_number":3122,"context_line":"            LOG.debug(\"Renaming vvset %(old)s to %(new)s\","},{"line_number":3123,"context_line":"                      {\u0027old\u0027: vvs_name_dest, \u0027new\u0027: temp_vvs_name})"},{"line_number":3124,"context_line":"            self.client.modifyVolumeSet(vvs_name_dest, newName\u003dtemp_vvs_name)"},{"line_number":3125,"context_line":"        except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":13,"id":"37fa0aef_79e49234","line":3122,"updated":"2023-10-10 02:24:49.000000000","message":"I wonder whether this should be logged *after* line 3124, when you know that the rename has succeeded (same for the other 2 cases)","commit_id":"e1656c6b9b60a12b500e46a96de01b5b7f4c7a7b"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"bfd223b54b766ed64c9b43594af53b80cb93fd08","unresolved":false,"context_lines":[{"line_number":3119,"context_line":"        temp_vvs_name \u003d \u0027tos-\u0027 + vvs_name_src[4:]"},{"line_number":3120,"context_line":""},{"line_number":3121,"context_line":"        try:"},{"line_number":3122,"context_line":"            LOG.debug(\"Renaming vvset %(old)s to %(new)s\","},{"line_number":3123,"context_line":"                      {\u0027old\u0027: vvs_name_dest, \u0027new\u0027: temp_vvs_name})"},{"line_number":3124,"context_line":"            self.client.modifyVolumeSet(vvs_name_dest, newName\u003dtemp_vvs_name)"},{"line_number":3125,"context_line":"        except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":13,"id":"9743420b_4fd743fb","line":3122,"in_reply_to":"37fa0aef_79e49234","updated":"2023-10-10 10:04:22.000000000","message":"Done","commit_id":"e1656c6b9b60a12b500e46a96de01b5b7f4c7a7b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5aa0cdb5cd4aec7fc3a407826d2584e8742b8276","unresolved":true,"context_lines":[{"line_number":3128,"context_line":"        try:"},{"line_number":3129,"context_line":"            LOG.debug(\"Renaming vvset %(old)s to %(new)s\","},{"line_number":3130,"context_line":"                      {\u0027old\u0027: vvs_name_src, \u0027new\u0027: vvs_name_dest})"},{"line_number":3131,"context_line":"            self.client.modifyVolumeSet(vvs_name_src, newName\u003dvvs_name_dest)"},{"line_number":3132,"context_line":"        except Exception as ex:"},{"line_number":3133,"context_line":"            LOG.error(\"exception: %(details)s\", {\u0027details\u0027: str(ex)})"},{"line_number":3134,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"d98b4a53_6eb2a272","line":3131,"updated":"2023-10-10 02:24:49.000000000","message":"If you hit an exception at line 3124, does it make sense to do this rename?  (Same thing for lines 3135-3140)","commit_id":"e1656c6b9b60a12b500e46a96de01b5b7f4c7a7b"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"bfd223b54b766ed64c9b43594af53b80cb93fd08","unresolved":false,"context_lines":[{"line_number":3128,"context_line":"        try:"},{"line_number":3129,"context_line":"            LOG.debug(\"Renaming vvset %(old)s to %(new)s\","},{"line_number":3130,"context_line":"                      {\u0027old\u0027: vvs_name_src, \u0027new\u0027: vvs_name_dest})"},{"line_number":3131,"context_line":"            self.client.modifyVolumeSet(vvs_name_src, newName\u003dvvs_name_dest)"},{"line_number":3132,"context_line":"        except Exception as ex:"},{"line_number":3133,"context_line":"            LOG.error(\"exception: %(details)s\", {\u0027details\u0027: str(ex)})"},{"line_number":3134,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"318664f8_090e227b","line":3131,"in_reply_to":"d98b4a53_6eb2a272","updated":"2023-10-10 10:04:22.000000000","message":"We still wish to proceed with further rename operations.","commit_id":"e1656c6b9b60a12b500e46a96de01b5b7f4c7a7b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c2078e169378d28ae6542a6d5feb80569949ddb4","unresolved":true,"context_lines":[{"line_number":3106,"context_line":"                log_error(\u0027original\u0027, e, temp_name, current_name, temp_name)"},{"line_number":3107,"context_line":"        return True"},{"line_number":3108,"context_line":""},{"line_number":3109,"context_line":"    def _rename_migrated_vvset(self, src_volume, dest_volume):"},{"line_number":3110,"context_line":"        \"\"\"Rename the vvsets after a migration."},{"line_number":3111,"context_line":""},{"line_number":3112,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"315fa5c8_3647b9de","line":3109,"range":{"start_line":3109,"start_character":8,"end_line":3109,"end_character":30},"updated":"2023-12-13 10:46:07.000000000","message":"i can see we don\u0027t have a UT testing this method or maybe it\u0027s being tested indirectly but good to have a specific UT","commit_id":"7e8b87c40e4dcb17bad1352c766183cdba674e16"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"f5bca452ece399b7be4b8e39527f93b23d516d58","unresolved":false,"context_lines":[{"line_number":3106,"context_line":"                log_error(\u0027original\u0027, e, temp_name, current_name, temp_name)"},{"line_number":3107,"context_line":"        return True"},{"line_number":3108,"context_line":""},{"line_number":3109,"context_line":"    def _rename_migrated_vvset(self, src_volume, dest_volume):"},{"line_number":3110,"context_line":"        \"\"\"Rename the vvsets after a migration."},{"line_number":3111,"context_line":""},{"line_number":3112,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"bc776aef_977b946f","line":3109,"range":{"start_line":3109,"start_character":8,"end_line":3109,"end_character":30},"in_reply_to":"315fa5c8_3647b9de","updated":"2023-12-14 07:54:39.000000000","message":"Now added a UT","commit_id":"7e8b87c40e4dcb17bad1352c766183cdba674e16"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c2078e169378d28ae6542a6d5feb80569949ddb4","unresolved":true,"context_lines":[{"line_number":3122,"context_line":"            self.client.modifyVolumeSet(vvs_name_dest, newName\u003dtemp_vvs_name)"},{"line_number":3123,"context_line":"            LOG.debug(\"Renamed vvset %(old)s to %(new)s\","},{"line_number":3124,"context_line":"                      {\u0027old\u0027: vvs_name_dest, \u0027new\u0027: temp_vvs_name})"},{"line_number":3125,"context_line":"        except Exception as ex:"},{"line_number":3126,"context_line":"            LOG.error(\"exception: %(details)s\", {\u0027details\u0027: str(ex)})"},{"line_number":3127,"context_line":""},{"line_number":3128,"context_line":"        try:"},{"line_number":3129,"context_line":"            self.client.modifyVolumeSet(vvs_name_src, newName\u003dvvs_name_dest)"}],"source_content_type":"text/x-python","patch_set":15,"id":"529a20a7_38837610","line":3126,"range":{"start_line":3125,"start_character":8,"end_line":3126,"end_character":69},"updated":"2023-12-13 10:46:07.000000000","message":"IIUC, this is a swap operation\n\ntemp \u003d dest\ndest \u003d source\nsource \u003d temp\n\nthe problem i see is we are just logging an error here and continuing with the workflow, if one of the modifyVolumeSet operation fails, does it make sense to execute the other ones?\nAlso isn\u0027t this a fatal issue for the operation to fail it at this point rather than continuing?","commit_id":"7e8b87c40e4dcb17bad1352c766183cdba674e16"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"f5bca452ece399b7be4b8e39527f93b23d516d58","unresolved":false,"context_lines":[{"line_number":3122,"context_line":"            self.client.modifyVolumeSet(vvs_name_dest, newName\u003dtemp_vvs_name)"},{"line_number":3123,"context_line":"            LOG.debug(\"Renamed vvset %(old)s to %(new)s\","},{"line_number":3124,"context_line":"                      {\u0027old\u0027: vvs_name_dest, \u0027new\u0027: temp_vvs_name})"},{"line_number":3125,"context_line":"        except Exception as ex:"},{"line_number":3126,"context_line":"            LOG.error(\"exception: %(details)s\", {\u0027details\u0027: str(ex)})"},{"line_number":3127,"context_line":""},{"line_number":3128,"context_line":"        try:"},{"line_number":3129,"context_line":"            self.client.modifyVolumeSet(vvs_name_src, newName\u003dvvs_name_dest)"}],"source_content_type":"text/x-python","patch_set":15,"id":"12380a93_a29b478c","line":3126,"range":{"start_line":3125,"start_character":8,"end_line":3126,"end_character":69},"in_reply_to":"529a20a7_38837610","updated":"2023-12-14 07:54:39.000000000","message":"Its not fatal issue. We still wish to proceed with further rename operations.","commit_id":"7e8b87c40e4dcb17bad1352c766183cdba674e16"}]}