)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"6840182b702a28f90714f9747484d23d945bd608","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cbb8ae7e_289f866a","updated":"2023-07-14 11:12:01.000000000","message":"I have realized that there is duplicate code between the current patch and https://review.opendev.org/c/openstack/cinder/+/886818. To address this, I suggest creating a separate patch specifically for the export backup tests, which will depend on patch 886818.\n\nHere is one possible way to proceed:\n\n\n1. Start by fetching and checking out patch 886818 using the command git review -d 886818.\n\n2. Create a new branch on top of patch 886818 with the command git checkout -b test_export_backup.\n\n3. Add the necessary code for the test_backup_export to the test_backups.py file in this new branch.\n\n4. Once you have finished making the changes, you can push the branch using git review. Gerrit will automatically create a separate patch that is linked to patch 886818.\n\n- If you require any assistance during this process, please let me know, and I will be glad to help in creating the patch.\n\nPlease keep me updated on your progress, and feel free to ask for any further assistance you may need.","commit_id":"bbbcb6ccf9002c8e0473c64b0d076e41b5631441"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"c89832b7c09b5757212ba7c5520f531e01ac3ef8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5c886d91_91f88496","updated":"2023-07-14 11:05:22.000000000","message":"Let\u0027s discuss this on out meeting next Monday","commit_id":"bbbcb6ccf9002c8e0473c64b0d076e41b5631441"}],"cinder/tests/functional/api_sample_tests/test_backups.py":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"c89832b7c09b5757212ba7c5520f531e01ac3ef8","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        self._verify_response(\u0027backups-list-response\u0027,"},{"line_number":50,"context_line":"                              {}, response, 200)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @test_base.VolumesSampleBase.override_mv(mv.SUPPORT_COUNT_INFO)  # 3.45"},{"line_number":53,"context_line":"    def test_backup_list_with_count(self):"},{"line_number":54,"context_line":"        response \u003d self._do_get(\u0027backups?with_count\u003dTrue\u0027)"},{"line_number":55,"context_line":"        self._verify_response(\u0027backups-list-response\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"790a98fd_4a30dbe4","line":52,"range":{"start_line":52,"start_character":4,"end_line":52,"end_character":75},"updated":"2023-07-14 11:05:22.000000000","message":"the current implementation is not achieving the intended effect as it runs the test against all microversions regardless. I cannot recall if we had discussed whether to keep the decorators for the sake of readability, indicating the necessary microversion, or if they should be removed.\n\n\nOutput from Zuul:\n```\n{5} cinder.tests.functional.api_sample_tests.test_backups.BackupClassesSampleJsonTest.test_backup_list_with_count_3_45 [1.807113s] ... ok\n{0} cinder.tests.functional.api_sample_tests.test_backups.BackupClassesSampleJsonTest.test_backup_list_with_count_3_0 [1.839258s] ... ok\n{0} cinder.tests.functional.api_sample_tests.test_backups.BackupClassesSampleJsonTest.test_backup_list_with_count_3_9 [1.849438s] ... ok\n{4} cinder.tests.functional.api_sample_tests.test_backups.BackupClassesSampleJsonTest.test_backup_list_with_count_3_43 [1.727424s] ... ok\n{1} cinder.tests.functional.api_sample_tests.test_backups.BackupClassesSampleJsonTest.test_backup_list_with_count_3_18 [1.802909s] ... ok\n{1} cinder.tests.functional.api_sample_tests.test_backups.BackupClassesSampleJsonTest.test_backup_list_with_count_3_56 [1.696508s] ... ok\n\n```","commit_id":"bbbcb6ccf9002c8e0473c64b0d076e41b5631441"}]}