)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"159a0331c06113b5db7917542b73c34044e7687b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0260662f_a29e39b7","updated":"2023-07-27 05:39:36.000000000","message":"I think it\u0027s OK to redefine the create transfer template in v3.59 (pagination) directory as well and we can refactor it later","commit_id":"bdd73e26c8a4fc35cc6286fbfbcb271b273e0855"},{"author":{"_account_id":35851,"name":"Desire Barine","display_name":"dessira","email":"desirebarine16@gmail.com","username":"dessira"},"change_message_id":"d2be756a9a08240edee0feb7eb5e65335dbc9c97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7dbbd06a_867972b1","updated":"2023-08-08 15:53:07.000000000","message":"All done. Thanks for the feedback","commit_id":"3d489285102e4a1227518665860ee123700d6813"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"346c8918e6627bbc2021ba78030a5a2c7f41991a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1ce3e439_179ee700","updated":"2023-08-06 23:15:50.000000000","message":"LGTM","commit_id":"3d489285102e4a1227518665860ee123700d6813"}],"cinder/tests/functional/api_sample_tests/test_volume_transfers.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"159a0331c06113b5db7917542b73c34044e7687b","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        self._verify_response(\u0027volume-transfers-list-detail-response\u0027, {},"},{"line_number":76,"context_line":"                              res, 200)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"class VolumeTransfersListSampleJsonTest(VolumeTransfersSampleJsonTest):"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    #Create volume transfer with specific version to use in test"},{"line_number":81,"context_line":"    @test_base.VolumesSampleBase.override_mv(mv.TRANSFER_WITH_SNAPSHOTS)"}],"source_content_type":"text/x-python","patch_set":1,"id":"caf650c3_4fa1cf96","line":78,"range":{"start_line":78,"start_character":40,"end_line":78,"end_character":69},"updated":"2023-07-27 05:39:36.000000000","message":"this should inherit from test_volumes.test_base.VolumesSampleBase to avoid running the same tests again","commit_id":"bdd73e26c8a4fc35cc6286fbfbcb271b273e0855"},{"author":{"_account_id":35851,"name":"Desire Barine","display_name":"dessira","email":"desirebarine16@gmail.com","username":"dessira"},"change_message_id":"d2be756a9a08240edee0feb7eb5e65335dbc9c97","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self._verify_response(\u0027volume-transfers-list-detail-response\u0027, {},"},{"line_number":76,"context_line":"                              res, 200)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"class VolumeTransfersListSampleJsonTest(VolumeTransfersSampleJsonTest):"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    #Create volume transfer with specific version to use in test"},{"line_number":81,"context_line":"    @test_base.VolumesSampleBase.override_mv(mv.TRANSFER_WITH_SNAPSHOTS)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff950bc3_40027f8d","line":78,"range":{"start_line":78,"start_character":40,"end_line":78,"end_character":69},"in_reply_to":"caf650c3_4fa1cf96","updated":"2023-08-08 15:53:07.000000000","message":"Done","commit_id":"bdd73e26c8a4fc35cc6286fbfbcb271b273e0855"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"159a0331c06113b5db7917542b73c34044e7687b","unresolved":true,"context_lines":[{"line_number":78,"context_line":"class VolumeTransfersListSampleJsonTest(VolumeTransfersSampleJsonTest):"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    #Create volume transfer with specific version to use in test"},{"line_number":81,"context_line":"    @test_base.VolumesSampleBase.override_mv(mv.TRANSFER_WITH_SNAPSHOTS)"},{"line_number":82,"context_line":"    def create_transfers_wrap(self):"},{"line_number":83,"context_line":"        self._create_transfers(self.subs)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @test_base.VolumesSampleBase.override_mv(mv.TRANSFER_WITH_SNAPSHOTS)"},{"line_number":86,"context_line":"    def test_transfer_list(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"4188cc21_f9c78873","line":83,"range":{"start_line":81,"start_character":0,"end_line":83,"end_character":41},"updated":"2023-07-27 05:39:36.000000000","message":"once the above change is done, we will need to redefine the create transfer code\n\n    def setUp(self):\n        super(VolumeTransfersSampleJsonTest, self).setUp()\n        res \u003d self._create_volume()\n        res \u003d jsonutils.loads(res.content)[\u0027volume\u0027]\n        self._poll_volume_while(res[\u0027id\u0027], [\u0027creating\u0027])\n        self.subs \u003d {\n            \"volume_id\": res[\u0027id\u0027]\n        }\n\n    def _create_transfers(self, subs\u003dNone):\n        response \u003d self._do_post(\u0027volume-transfers\u0027,\n                                 \u0027volume-transfers-create-request\u0027,\n                                 self.subs)\n        return response","commit_id":"bdd73e26c8a4fc35cc6286fbfbcb271b273e0855"},{"author":{"_account_id":35851,"name":"Desire Barine","display_name":"dessira","email":"desirebarine16@gmail.com","username":"dessira"},"change_message_id":"d2be756a9a08240edee0feb7eb5e65335dbc9c97","unresolved":false,"context_lines":[{"line_number":78,"context_line":"class VolumeTransfersListSampleJsonTest(VolumeTransfersSampleJsonTest):"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    #Create volume transfer with specific version to use in test"},{"line_number":81,"context_line":"    @test_base.VolumesSampleBase.override_mv(mv.TRANSFER_WITH_SNAPSHOTS)"},{"line_number":82,"context_line":"    def create_transfers_wrap(self):"},{"line_number":83,"context_line":"        self._create_transfers(self.subs)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @test_base.VolumesSampleBase.override_mv(mv.TRANSFER_WITH_SNAPSHOTS)"},{"line_number":86,"context_line":"    def test_transfer_list(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5c286bef_bbb756a4","line":83,"range":{"start_line":81,"start_character":0,"end_line":83,"end_character":41},"in_reply_to":"4188cc21_f9c78873","updated":"2023-08-08 15:53:07.000000000","message":"Done","commit_id":"bdd73e26c8a4fc35cc6286fbfbcb271b273e0855"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"159a0331c06113b5db7917542b73c34044e7687b","unresolved":true,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @test_base.VolumesSampleBase.override_mv(mv.TRANSFER_WITH_SNAPSHOTS)"},{"line_number":86,"context_line":"    def test_transfer_list(self):"},{"line_number":87,"context_line":"        self.create_transfers_wrap()"},{"line_number":88,"context_line":"        res \u003d self._do_get(\u0027volume-transfers\u0027)"},{"line_number":89,"context_line":"        self._verify_response(\u0027volume-transfers-list-project-response\u0027, {},"},{"line_number":90,"context_line":"                              res, 200)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c10814d6_677d2300","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":36},"updated":"2023-07-27 05:39:36.000000000","message":"after above changes, if we now call self._create_transfers, would it use mv.TRANSFER_WITH_SNAPSHOTS during the create call?","commit_id":"bdd73e26c8a4fc35cc6286fbfbcb271b273e0855"},{"author":{"_account_id":35851,"name":"Desire Barine","display_name":"dessira","email":"desirebarine16@gmail.com","username":"dessira"},"change_message_id":"d2be756a9a08240edee0feb7eb5e65335dbc9c97","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @test_base.VolumesSampleBase.override_mv(mv.TRANSFER_WITH_SNAPSHOTS)"},{"line_number":86,"context_line":"    def test_transfer_list(self):"},{"line_number":87,"context_line":"        self.create_transfers_wrap()"},{"line_number":88,"context_line":"        res \u003d self._do_get(\u0027volume-transfers\u0027)"},{"line_number":89,"context_line":"        self._verify_response(\u0027volume-transfers-list-project-response\u0027, {},"},{"line_number":90,"context_line":"                              res, 200)"}],"source_content_type":"text/x-python","patch_set":1,"id":"298d5fe8_5e4d1e05","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":36},"in_reply_to":"c10814d6_677d2300","updated":"2023-08-08 15:53:07.000000000","message":"Done","commit_id":"bdd73e26c8a4fc35cc6286fbfbcb271b273e0855"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"eb780a912375ea21c2dc42690681736dae0c4993","unresolved":true,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @test_base.VolumesSampleBase.override_mv(mv.SUPPORT_TRANSFER_PAGINATION)"},{"line_number":93,"context_line":"    def test_transfer_list_params(self):"},{"line_number":94,"context_line":"        self.create_transfers_wrap()"},{"line_number":95,"context_line":"        res \u003d self._do_get(\u0027volume-transfers?limit\u003d1\u0026offset\u003d0\u0026sort_key\u003ddisplay_name\u0026sort_dir\u003dasc\u0027)"},{"line_number":96,"context_line":"        self._verify_response(\u0027volume-transfers-list-project-response\u0027, {},"},{"line_number":97,"context_line":"                              res, 200)"}],"source_content_type":"text/x-python","patch_set":1,"id":"612eeb15_e1f612b6","line":94,"range":{"start_line":94,"start_character":8,"end_line":94,"end_character":36},"updated":"2023-07-24 11:25:37.000000000","message":"can we try\n\n    with self.common_api_sample():\n        response \u003d self._create_transfers(self.subs)","commit_id":"bdd73e26c8a4fc35cc6286fbfbcb271b273e0855"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"159a0331c06113b5db7917542b73c34044e7687b","unresolved":true,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @test_base.VolumesSampleBase.override_mv(mv.SUPPORT_TRANSFER_PAGINATION)"},{"line_number":93,"context_line":"    def test_transfer_list_params(self):"},{"line_number":94,"context_line":"        self.create_transfers_wrap()"},{"line_number":95,"context_line":"        res \u003d self._do_get(\u0027volume-transfers?limit\u003d1\u0026offset\u003d0\u0026sort_key\u003ddisplay_name\u0026sort_dir\u003dasc\u0027)"},{"line_number":96,"context_line":"        self._verify_response(\u0027volume-transfers-list-project-response\u0027, {},"},{"line_number":97,"context_line":"                              res, 200)"}],"source_content_type":"text/x-python","patch_set":1,"id":"db6a2212_30873122","line":94,"range":{"start_line":94,"start_character":8,"end_line":94,"end_character":36},"in_reply_to":"612eeb15_e1f612b6","updated":"2023-07-27 05:39:36.000000000","message":"Same as above, after above changes would it use mv.SUPPORT_TRANSFER_PAGINATION to create the transfer","commit_id":"bdd73e26c8a4fc35cc6286fbfbcb271b273e0855"},{"author":{"_account_id":35851,"name":"Desire Barine","display_name":"dessira","email":"desirebarine16@gmail.com","username":"dessira"},"change_message_id":"d2be756a9a08240edee0feb7eb5e65335dbc9c97","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @test_base.VolumesSampleBase.override_mv(mv.SUPPORT_TRANSFER_PAGINATION)"},{"line_number":93,"context_line":"    def test_transfer_list_params(self):"},{"line_number":94,"context_line":"        self.create_transfers_wrap()"},{"line_number":95,"context_line":"        res \u003d self._do_get(\u0027volume-transfers?limit\u003d1\u0026offset\u003d0\u0026sort_key\u003ddisplay_name\u0026sort_dir\u003dasc\u0027)"},{"line_number":96,"context_line":"        self._verify_response(\u0027volume-transfers-list-project-response\u0027, {},"},{"line_number":97,"context_line":"                              res, 200)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a325e9d6_01d7e8d3","line":94,"range":{"start_line":94,"start_character":8,"end_line":94,"end_character":36},"in_reply_to":"db6a2212_30873122","updated":"2023-08-08 15:53:07.000000000","message":"Done","commit_id":"bdd73e26c8a4fc35cc6286fbfbcb271b273e0855"}]}