)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1cd10a9bc1986222f3d2a718cab5c31efe6c920f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2bf9f52d_1cb50c3f","updated":"2023-09-14 14:47:54.000000000","message":"one question inline","commit_id":"e54c9d63acf10eabbde3bd7cb85d6e7f4eaf2afa"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c3bf6ac12cdbb5e2427712acaa2373c2a5e71de4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"177e6058_9815b2ff","updated":"2023-07-30 15:28:49.000000000","message":"recheck","commit_id":"e54c9d63acf10eabbde3bd7cb85d6e7f4eaf2afa"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"4268e28ef2b4a124fbdf503047424ed7b810868d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1d9782c5_dd2758e9","updated":"2023-07-30 11:46:49.000000000","message":"recheck","commit_id":"e54c9d63acf10eabbde3bd7cb85d6e7f4eaf2afa"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"464a395e967b567e650698013326defb62dc7b44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3a799d6a_f02fae8a","updated":"2023-09-13 17:20:02.000000000","message":"recheck","commit_id":"e54c9d63acf10eabbde3bd7cb85d6e7f4eaf2afa"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"0cd2d9937ec530d0133c303be8c63d63d6cb411a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ae7ffc0e_d4536423","updated":"2023-07-29 21:19:09.000000000","message":"recheck","commit_id":"e54c9d63acf10eabbde3bd7cb85d6e7f4eaf2afa"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"e091105e97e97cccc8a6a574e7e695b6fbeee1e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ddc075fc_8bac9559","updated":"2023-09-13 14:18:42.000000000","message":"recheck","commit_id":"e54c9d63acf10eabbde3bd7cb85d6e7f4eaf2afa"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c03dff851735c020f382360cc793dd85097d09f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"239a324f_835afcdd","updated":"2023-09-15 15:11:45.000000000","message":"... and Zuul likes it, too.  Pure CI already green.","commit_id":"8e1d5b4aeb5c4bbae9039a8602f5725dddeb59bd"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2ef9d3915224babf56684fed3dbcaf8aaf6728db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9d37333e_103cf486","updated":"2023-09-15 15:10:57.000000000","message":"LGTM.","commit_id":"8e1d5b4aeb5c4bbae9039a8602f5725dddeb59bd"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8a52b2798db04bab376dda83d517771fba8a4a9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"019d4474_6030ee8e","updated":"2023-09-15 03:46:25.000000000","message":"LGTM. only the release note was changed from last PS so CIs should report same.","commit_id":"8e1d5b4aeb5c4bbae9039a8602f5725dddeb59bd"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"ed6549154e2355708364db87fddaa6f182ce74c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"15164dae_6ad0e56e","updated":"2023-09-15 14:26:57.000000000","message":"Looks good to me - thank you!","commit_id":"8e1d5b4aeb5c4bbae9039a8602f5725dddeb59bd"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"18b2de679864cbcf1846baca7368a6ccb82d7f58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3d02a160_3c37b572","updated":"2023-09-15 12:48:44.000000000","message":"recheck","commit_id":"8e1d5b4aeb5c4bbae9039a8602f5725dddeb59bd"}],"cinder/volume/drivers/pure.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1cd10a9bc1986222f3d2a718cab5c31efe6c920f","unresolved":true,"context_lines":[{"line_number":927,"context_line":"            for array in self._uniform_active_cluster_target_arrays:"},{"line_number":928,"context_line":"                try:"},{"line_number":929,"context_line":"                    self._disconnect(array, volume, connector,"},{"line_number":930,"context_line":"                                     remove_remote_hosts\u003dTrue,"},{"line_number":931,"context_line":"                                     is_multiattach\u003dmultiattach)"},{"line_number":932,"context_line":"                except purestorage.PureError as err:"},{"line_number":933,"context_line":"                    # Swallow any exception, just warn and continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"020e158c_c2937ab2","line":930,"range":{"start_line":930,"start_character":37,"end_line":930,"end_character":61},"updated":"2023-09-14 14:47:54.000000000","message":"in the bug report we mention the condition, \"When Pure Storage synchronous replication is set to use `uniform:True`\", I don\u0027t see that condition checked here?\nIs it because we are ALWAYS disconnecting from secondary storage either uniform is True or False?","commit_id":"e54c9d63acf10eabbde3bd7cb85d6e7f4eaf2afa"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"e1226466b5d49f88625d62cd48dbe240746b6c9b","unresolved":true,"context_lines":[{"line_number":927,"context_line":"            for array in self._uniform_active_cluster_target_arrays:"},{"line_number":928,"context_line":"                try:"},{"line_number":929,"context_line":"                    self._disconnect(array, volume, connector,"},{"line_number":930,"context_line":"                                     remove_remote_hosts\u003dTrue,"},{"line_number":931,"context_line":"                                     is_multiattach\u003dmultiattach)"},{"line_number":932,"context_line":"                except purestorage.PureError as err:"},{"line_number":933,"context_line":"                    # Swallow any exception, just warn and continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"8690a6ae_539d000b","line":930,"range":{"start_line":930,"start_character":37,"end_line":930,"end_character":61},"in_reply_to":"020e158c_c2937ab2","updated":"2023-09-14 14:52:13.000000000","message":"Line 927 controls entering this section of code and only happens if uniform is true","commit_id":"e54c9d63acf10eabbde3bd7cb85d6e7f4eaf2afa"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8a52b2798db04bab376dda83d517771fba8a4a9f","unresolved":false,"context_lines":[{"line_number":927,"context_line":"            for array in self._uniform_active_cluster_target_arrays:"},{"line_number":928,"context_line":"                try:"},{"line_number":929,"context_line":"                    self._disconnect(array, volume, connector,"},{"line_number":930,"context_line":"                                     remove_remote_hosts\u003dTrue,"},{"line_number":931,"context_line":"                                     is_multiattach\u003dmultiattach)"},{"line_number":932,"context_line":"                except purestorage.PureError as err:"},{"line_number":933,"context_line":"                    # Swallow any exception, just warn and continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"ae27cd40_53eba05a","line":930,"range":{"start_line":930,"start_character":37,"end_line":930,"end_character":61},"in_reply_to":"8690a6ae_539d000b","updated":"2023-09-15 03:46:25.000000000","message":"Ah ok, I missed that.","commit_id":"e54c9d63acf10eabbde3bd7cb85d6e7f4eaf2afa"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2ef9d3915224babf56684fed3dbcaf8aaf6728db","unresolved":true,"context_lines":[{"line_number":924,"context_line":"        if self._is_vol_in_pod(vol_name):"},{"line_number":925,"context_line":"            # Try to disconnect from each host, they may not be online though"},{"line_number":926,"context_line":"            # so if they fail don\u0027t cause a problem."},{"line_number":927,"context_line":"            for array in self._uniform_active_cluster_target_arrays:"},{"line_number":928,"context_line":"                try:"},{"line_number":929,"context_line":"                    self._disconnect(array, volume, connector,"},{"line_number":930,"context_line":"                                     remove_remote_hosts\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"c3402973_43ac09ae","line":927,"range":{"start_line":927,"start_character":30,"end_line":927,"end_character":67},"updated":"2023-09-15 15:10:57.000000000","message":"OK, looks like this will only be populated when uniform\u003dtrue, so makes sense to unconditionally have remove_remote_hosts\u003dTrue at line 930.","commit_id":"8e1d5b4aeb5c4bbae9039a8602f5725dddeb59bd"}],"releasenotes/notes/pure_uniform_disconnect_bug-357c849bf12e8832.yaml":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1cd10a9bc1986222f3d2a718cab5c31efe6c920f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Pure Storage Cinder Driver: Fixes `bug 2029005"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2029005\u003e`__ to correctly"},{"line_number":6,"context_line":"    disconnect a sync replicated volume from host on the secondary"},{"line_number":7,"context_line":"    array when uniform option is set to True."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c31ca08e_33775177","line":4,"range":{"start_line":4,"start_character":32,"end_line":4,"end_character":37},"updated":"2023-09-14 14:47:54.000000000","message":"nit: Fixed","commit_id":"e54c9d63acf10eabbde3bd7cb85d6e7f4eaf2afa"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"740b90910d44e9e57f6fe8a1c4beb4ec3ebd1d49","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Pure Storage Cinder Driver: Fixes `bug 2029005"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2029005\u003e`__ to correctly"},{"line_number":6,"context_line":"    disconnect a sync replicated volume from host on the secondary"},{"line_number":7,"context_line":"    array when uniform option is set to True."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"588dd371_36c74bac","line":4,"range":{"start_line":4,"start_character":32,"end_line":4,"end_character":37},"in_reply_to":"c31ca08e_33775177","updated":"2023-09-15 03:32:02.000000000","message":"Done","commit_id":"e54c9d63acf10eabbde3bd7cb85d6e7f4eaf2afa"}]}