)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"a7939bc62c7372e9bd532b295b705b478aee8ed1","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[NetApp] LUN space-allocation support for iSCSI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New extra-spec netapp:space-allocation will"},{"line_number":10,"context_line":"take boolean value TRUE/FALSE. Base on this"},{"line_number":11,"context_line":"volume extra spec LUN will be created to"},{"line_number":12,"context_line":"support for the SCSI Thin Provisioning"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"102ecf61_8dd3ed84","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":39},"updated":"2023-08-08 18:36:04.000000000","message":"from the code is using \"netapp:space_allocation\"","commit_id":"da923d8dad007c03b2bf134e582487f95a8bb354"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"4a9d33e3f772a470d4b998babb83ea99292b1d54","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[NetApp] LUN space-allocation support for iSCSI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New extra-spec netapp:space-allocation will"},{"line_number":10,"context_line":"take boolean value TRUE/FALSE. Base on this"},{"line_number":11,"context_line":"volume extra spec LUN will be created to"},{"line_number":12,"context_line":"support for the SCSI Thin Provisioning"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"95badd08_7fb599ba","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":39},"in_reply_to":"102ecf61_8dd3ed84","updated":"2023-08-09 18:11:39.000000000","message":"Thank you! Updated description to netapp:space_allocation","commit_id":"da923d8dad007c03b2bf134e582487f95a8bb354"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"a7939bc62c7372e9bd532b295b705b478aee8ed1","unresolved":true,"context_lines":[{"line_number":11,"context_line":"volume extra spec LUN will be created to"},{"line_number":12,"context_line":"support for the SCSI Thin Provisioning"},{"line_number":13,"context_line":"feature enable/disable."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ie4ac6b2be27b7da381407a4e26b571f972fef283"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8239aa9a_e4576472","line":14,"updated":"2023-08-08 18:36:04.000000000","message":"please, add the blueprint that is being implemented here.","commit_id":"da923d8dad007c03b2bf134e582487f95a8bb354"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"4a9d33e3f772a470d4b998babb83ea99292b1d54","unresolved":false,"context_lines":[{"line_number":11,"context_line":"volume extra spec LUN will be created to"},{"line_number":12,"context_line":"support for the SCSI Thin Provisioning"},{"line_number":13,"context_line":"feature enable/disable."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ie4ac6b2be27b7da381407a4e26b571f972fef283"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d679f380_379118c4","line":14,"in_reply_to":"8239aa9a_e4576472","updated":"2023-08-09 18:11:39.000000000","message":"Create blue print https://blueprints.launchpad.net/cinder/+spec/netapp-space-allocation-support","commit_id":"da923d8dad007c03b2bf134e582487f95a8bb354"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"20919f17a7743551776709809c84465e2fe24177","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[NetApp] LUN space allocation support for iSCSI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New extra-spec netapp:space_allocation will"},{"line_number":10,"context_line":"take boolean value TRUE/FALSE. Base on this"},{"line_number":11,"context_line":"volume extra spec LUN will be created to"},{"line_number":12,"context_line":"support for the SCSI Thin Provisioning"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"af816727_4dd46390","line":9,"range":{"start_line":9,"start_character":22,"end_line":9,"end_character":38},"updated":"2023-08-23 16:21:24.000000000","message":"-1: Instead of using a new custom extra spec we should be using the existing ones: `thin_provisioning_support` and `thick_provisioning_support` as mentioned in the extra specs docs: https://docs.openstack.org/cinder/latest/admin/over-subscription.html#volume-type-extra-specs\n\nWhen the driver can do both it should report that in the stats as well: https://github.com/openstack/cinder/blob/ddcf394ae277692d7cab2e03b4b6ae67ba7f1cc3/cinder/volume/drivers/netapp/dataontap/utils/capabilities.py#L141-L142\n\nAnd you can see how other drivers check the volume type to see if it is thick [1] and how they use it during the volume creation [2].\n\n\n[1]: https://github.com/openstack/cinder/blob/ddcf394ae277692d7cab2e03b4b6ae67ba7f1cc3/cinder/volume/drivers/dell_emc/unity/adapter.py#L123\n\n[2]: https://github.com/openstack/cinder/blob/ddcf394ae277692d7cab2e03b4b6ae67ba7f1cc3/cinder/volume/drivers/dell_emc/unity/adapter.py#L416","commit_id":"e4b547897f2a89b324496f643509100363d33662"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"9f09ef46201385878426eb9c1b496cd44ee7b091","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[NetApp] LUN space allocation support for iSCSI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New extra-spec netapp:space_allocation will"},{"line_number":10,"context_line":"take boolean value TRUE/FALSE. Base on this"},{"line_number":11,"context_line":"volume extra spec LUN will be created to"},{"line_number":12,"context_line":"support for the SCSI Thin Provisioning"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"344380f2_cf344430","line":9,"range":{"start_line":9,"start_character":22,"end_line":9,"end_character":38},"in_reply_to":"af816727_4dd46390","updated":"2023-08-28 13:21:10.000000000","message":"Thank you! Gorka. I really appreciate your suggestion. With your suggestion, I am able to use volume extra spec thin/thick attributes to provision Netapp LUN space_allocation to true/false. Can you please review again.","commit_id":"e4b547897f2a89b324496f643509100363d33662"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"7ac08c903651f2d898fc2f205babd8ef87679ebf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0a01f6b1_349089ca","updated":"2023-08-09 12:17:56.000000000","message":"Hi Jay thank you for working on this. Felipe addressed some comments about adding release notes. Here is the documentation:\n\nhttps://docs.openstack.org/keystone/latest/contributor/release-notes.html#release-notes-for-features\n\nPlease, also check the unit tests.","commit_id":"da923d8dad007c03b2bf134e582487f95a8bb354"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"a7939bc62c7372e9bd532b295b705b478aee8ed1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"de71850a_d68037c0","updated":"2023-08-08 18:36:04.000000000","message":"Thank you for the work Jayaanand. Pleae, the patch has to have a \"release note\" (following Cinder pattern). Besied that, I added some comments to the code.","commit_id":"da923d8dad007c03b2bf134e582487f95a8bb354"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"c734ec63bc494637e193ac74bd96dd2060901637","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4f27499c_9a189aca","updated":"2023-08-09 13:01:59.000000000","message":"Thanks for this patch, Jayaanand. In addition to Felipe and Caique\u0027s points, I have a question inline.","commit_id":"da923d8dad007c03b2bf134e582487f95a8bb354"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"c4926b297b94ad3c9ead64c7ae0dc70ab7ed76a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c99fe9e8_b1173b09","in_reply_to":"0a01f6b1_349089ca","updated":"2023-08-09 18:47:07.000000000","message":"Thank you! Caique. create release notes for space allocation feature.","commit_id":"da923d8dad007c03b2bf134e582487f95a8bb354"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e3820e58cfa03c4be02f24f6aa38268ceff342a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e7554834_42a3cde2","updated":"2023-08-16 11:56:48.000000000","message":"Jayaa, thanks for the fixes. See more points inline.","commit_id":"8b7e816d2e968b6b195838fc8b58e90ec469e36a"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"533bacd2583d7227f5b8c1ca1c6aa22f32ae9a20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ec111821_d7c11d27","updated":"2023-08-10 12:21:48.000000000","message":"recheck: unrelated failure. Ex: tempest.lib.exceptions.IdentityError: Got identity error. These are not related to my changes\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_fff/890818/4/check/tempest-integrated-storage/fff1613/job-output.txt","commit_id":"8b7e816d2e968b6b195838fc8b58e90ec469e36a"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"e572baaf6e64ff52fe82941dfd922a73260cb4af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3394f860_af832dc2","updated":"2023-08-17 17:13:52.000000000","message":"Thank you! Felipe for review. Additional validation is added.","commit_id":"32d9034302e5659d461901871397700a04e885e5"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"59aa1be0b3690c4d24b9ce1ea97516178bdf45e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3ab8f79b_c837af2f","updated":"2023-08-22 12:14:24.000000000","message":"Thank you Jay for working on this.","commit_id":"e4b547897f2a89b324496f643509100363d33662"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"9de732994a3567f68a19db5abf172bfb8f614cc3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4e36938e_899b2d58","updated":"2023-08-18 13:14:10.000000000","message":"Thanks Jay, LGTM","commit_id":"e4b547897f2a89b324496f643509100363d33662"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"0eae4e27278962dae5b371896f8de76419a86529","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e4ff5a5e_f1e34c21","updated":"2023-08-22 13:35:14.000000000","message":"Thanks Jaya. It seems ready to go! :)","commit_id":"e4b547897f2a89b324496f643509100363d33662"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"a134db31265c94ec42b1b461ab9e71177885c927","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"728107dd_e0ac2686","updated":"2023-08-18 06:28:37.000000000","message":"recheck: unrelated failure with job","commit_id":"e4b547897f2a89b324496f643509100363d33662"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"f11592365959c2a22be2d622a0336d6f351c828f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a2be61cc_4c67978f","updated":"2023-08-24 13:12:33.000000000","message":"recheck: unrelated failure with this change","commit_id":"81f6c9e7086487e2dc52bdce0d080ef864462019"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"84345a2079efd3f9caffb5e138a5dd678e768001","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"553c7cb7_120ba895","updated":"2023-08-24 17:06:16.000000000","message":"run-NetApp CI","commit_id":"81f6c9e7086487e2dc52bdce0d080ef864462019"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"23f1fb0d140eabd33adf183eeace2e00ec2b8bb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a3ace8db_cd00be73","updated":"2023-08-28 10:48:23.000000000","message":"run-NetApp CI","commit_id":"81f6c9e7086487e2dc52bdce0d080ef864462019"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"5bc3f8dff2c4b0c37ba0706ab2ffb1f32bfad557","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e4ea6e7d_a63370a2","updated":"2023-08-25 16:47:24.000000000","message":"run-NetApp CI","commit_id":"81f6c9e7086487e2dc52bdce0d080ef864462019"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"1a44ba6c5a6f612dbfb3b283b38e520f9c660515","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"2ce0eba7_f806fd3a","updated":"2023-08-29 12:00:20.000000000","message":"Thanks jayaa for the new approach. See the comments.","commit_id":"44de128963ca3e020586948a4340adfbf27d95ed"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"a7021137ea4c3b619a2a7c27aee626fc95e49642","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"4c70128b_13b170d6","updated":"2023-08-29 12:29:18.000000000","message":"more some comments","commit_id":"44de128963ca3e020586948a4340adfbf27d95ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"e1551876c0c0458230af45e6e7221a824fbcc1a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"35db9607_ac561fef","updated":"2023-08-29 05:09:10.000000000","message":"recheck: unrelated failure with this change","commit_id":"44de128963ca3e020586948a4340adfbf27d95ed"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/client/test_client_base.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e3820e58cfa03c4be02f24f6aa38268ceff342a2","unresolved":true,"context_lines":[{"line_number":30,"context_line":"from cinder.volume.drivers.netapp.dataontap.client import api as netapp_api"},{"line_number":31,"context_line":"from cinder.volume.drivers.netapp.dataontap.client import client_base"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"CONNECTION_INFO \u003d {\u0027hostname\u0027: \u0027hostname\u0027,"},{"line_number":35,"context_line":"                   \u0027transport_type\u0027: \u0027https\u0027,"},{"line_number":36,"context_line":"                   \u0027port\u0027: 443,"}],"source_content_type":"text/x-python","patch_set":4,"id":"feac357c_718382ad","side":"PARENT","line":33,"updated":"2023-08-16 11:56:48.000000000","message":"why are you removing this line ? You should only update lines when required for the patch. If it was by mistake, please, undo this change.","commit_id":"ff4b1c910e65274efcbc0fd052f1f9bc5a643603"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"e572baaf6e64ff52fe82941dfd922a73260cb4af","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from cinder.volume.drivers.netapp.dataontap.client import api as netapp_api"},{"line_number":31,"context_line":"from cinder.volume.drivers.netapp.dataontap.client import client_base"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"CONNECTION_INFO \u003d {\u0027hostname\u0027: \u0027hostname\u0027,"},{"line_number":35,"context_line":"                   \u0027transport_type\u0027: \u0027https\u0027,"},{"line_number":36,"context_line":"                   \u0027port\u0027: 443,"}],"source_content_type":"text/x-python","patch_set":4,"id":"0861d9b9_34429e4d","side":"PARENT","line":33,"in_reply_to":"34a2a36b_437ef563","updated":"2023-08-17 17:13:52.000000000","message":"added back line.","commit_id":"ff4b1c910e65274efcbc0fd052f1f9bc5a643603"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"c30418c35d9aad85680ba81e3a758e5609adf8dc","unresolved":true,"context_lines":[{"line_number":30,"context_line":"from cinder.volume.drivers.netapp.dataontap.client import api as netapp_api"},{"line_number":31,"context_line":"from cinder.volume.drivers.netapp.dataontap.client import client_base"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"CONNECTION_INFO \u003d {\u0027hostname\u0027: \u0027hostname\u0027,"},{"line_number":35,"context_line":"                   \u0027transport_type\u0027: \u0027https\u0027,"},{"line_number":36,"context_line":"                   \u0027port\u0027: 443,"}],"source_content_type":"text/x-python","patch_set":4,"id":"34a2a36b_437ef563","side":"PARENT","line":33,"in_reply_to":"feac357c_718382ad","updated":"2023-08-17 09:55:53.000000000","message":"Added PEP8 validation to PyCharm. I didn\u0027t find any issue wit Tox PEP8 validation.","commit_id":"ff4b1c910e65274efcbc0fd052f1f9bc5a643603"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"a7021137ea4c3b619a2a7c27aee626fc95e49642","unresolved":true,"context_lines":[{"line_number":414,"context_line":"    def test_map_lun_with_api_error(self):"},{"line_number":415,"context_line":"        path \u003d \u0027/vol/%s/%s\u0027 % (self.fake_volume, self.fake_lun)"},{"line_number":416,"context_line":"        igroup \u003d \u0027igroup\u0027"},{"line_number":417,"context_line":"        self.connection.invoke_successfully.side_effect \u003d \\"},{"line_number":418,"context_line":"            netapp_api.NaApiError()"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"        with mock.patch.object(netapp_api.NaElement,"}],"source_content_type":"text/x-python","patch_set":13,"id":"1288df26_05db32ea","line":417,"range":{"start_line":417,"start_character":55,"end_line":417,"end_character":59},"updated":"2023-08-29 12:29:18.000000000","message":"same here","commit_id":"44de128963ca3e020586948a4340adfbf27d95ed"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"a7021137ea4c3b619a2a7c27aee626fc95e49642","unresolved":true,"context_lines":[{"line_number":449,"context_line":"    def test_unmap_lun_with_api_error(self):"},{"line_number":450,"context_line":"        path \u003d \u0027/vol/%s/%s\u0027 % (self.fake_volume, self.fake_lun)"},{"line_number":451,"context_line":"        igroup \u003d \u0027igroup\u0027"},{"line_number":452,"context_line":"        self.connection.invoke_successfully.side_effect \u003d \\"},{"line_number":453,"context_line":"            netapp_api.NaApiError()"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"        with mock.patch.object(netapp_api.NaElement,"}],"source_content_type":"text/x-python","patch_set":13,"id":"e3755141_36e41661","line":452,"range":{"start_line":452,"start_character":56,"end_line":452,"end_character":59},"updated":"2023-08-29 12:29:18.000000000","message":"why are you chaning this line ? Is it related to your change ?","commit_id":"44de128963ca3e020586948a4340adfbf27d95ed"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"a7021137ea4c3b619a2a7c27aee626fc95e49642","unresolved":true,"context_lines":[{"line_number":466,"context_line":"        path \u003d \u0027/vol/%s/%s\u0027 % (self.fake_volume, self.fake_lun)"},{"line_number":467,"context_line":"        igroup \u003d \u0027igroup\u0027"},{"line_number":468,"context_line":"        EINVALIDINPUTERROR \u003d \u002713115\u0027"},{"line_number":469,"context_line":"        self.connection.invoke_successfully.side_effect \u003d \\"},{"line_number":470,"context_line":"            netapp_api.NaApiError(code\u003dEINVALIDINPUTERROR)"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"        with mock.patch.object(netapp_api.NaElement,"}],"source_content_type":"text/x-python","patch_set":13,"id":"e95ef835_68a12399","line":469,"range":{"start_line":469,"start_character":53,"end_line":469,"end_character":58},"updated":"2023-08-29 12:29:18.000000000","message":"same here","commit_id":"44de128963ca3e020586948a4340adfbf27d95ed"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"a7021137ea4c3b619a2a7c27aee626fc95e49642","unresolved":true,"context_lines":[{"line_number":484,"context_line":"        path \u003d \u0027/vol/%s/%s\u0027 % (self.fake_volume, self.fake_lun)"},{"line_number":485,"context_line":"        igroup \u003d \u0027igroup\u0027"},{"line_number":486,"context_line":"        EVDISK_ERROR_NO_SUCH_LUNMAP \u003d \u00279016\u0027"},{"line_number":487,"context_line":"        self.connection.invoke_successfully.side_effect \u003d \\"},{"line_number":488,"context_line":"            netapp_api.NaApiError(code\u003dEVDISK_ERROR_NO_SUCH_LUNMAP)"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        with mock.patch.object(netapp_api.NaElement,"}],"source_content_type":"text/x-python","patch_set":13,"id":"53650d7f_2a09c548","line":487,"range":{"start_line":487,"start_character":54,"end_line":487,"end_character":59},"updated":"2023-08-29 12:29:18.000000000","message":"same here","commit_id":"44de128963ca3e020586948a4340adfbf27d95ed"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"a7021137ea4c3b619a2a7c27aee626fc95e49642","unresolved":true,"context_lines":[{"line_number":582,"context_line":""},{"line_number":583,"context_line":"    def test_get_lun_geometry_with_api_error(self):"},{"line_number":584,"context_line":"        path \u003d \u0027/vol/%s/%s\u0027 % (self.fake_volume, self.fake_lun)"},{"line_number":585,"context_line":"        self.connection.invoke_successfully.side_effect \u003d \\"},{"line_number":586,"context_line":"            netapp_api.NaApiError()"},{"line_number":587,"context_line":"        geometry \u003d self.client.get_lun_geometry(path)"},{"line_number":588,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"97c34c06_ad610b53","line":585,"range":{"start_line":585,"start_character":56,"end_line":585,"end_character":59},"updated":"2023-08-29 12:29:18.000000000","message":"same here","commit_id":"44de128963ca3e020586948a4340adfbf27d95ed"}],"cinder/volume/drivers/netapp/dataontap/block_base.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"a7939bc62c7372e9bd532b295b705b478aee8ed1","unresolved":true,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        metadata \u003d {\u0027OsType\u0027: self.lun_ostype,"},{"line_number":232,"context_line":"                    \u0027SpaceReserved\u0027: self.lun_space_reservation,"},{"line_number":233,"context_line":"                    \u0027SpaceAllocated\u0027: extra_specs.get(\u0027netapp:space_allocation\u0027),"},{"line_number":234,"context_line":"                    \u0027Path\u0027: \u0027/vol/%s/%s\u0027 % (pool_name, lun_name)}"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        qos_policy_group_info \u003d self._setup_qos_for_volume(volume, extra_specs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ddcf1b3b_c0b3572c","line":233,"range":{"start_line":233,"start_character":38,"end_line":233,"end_character":80},"updated":"2023-08-08 18:36:04.000000000","message":"Differently of `lun_space_reservation` which is always set, this extra_specs can not be set here. As result, the `SpaceAllocated` will be `None`, instead of `False` (as expected). I think it can end up with some erros. Correct would be:\n\nextra_specs.get(\u0027netapp:space_allocation`, \u0027false\u0027)\n\nRight ?","commit_id":"da923d8dad007c03b2bf134e582487f95a8bb354"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"4a9d33e3f772a470d4b998babb83ea99292b1d54","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        metadata \u003d {\u0027OsType\u0027: self.lun_ostype,"},{"line_number":232,"context_line":"                    \u0027SpaceReserved\u0027: self.lun_space_reservation,"},{"line_number":233,"context_line":"                    \u0027SpaceAllocated\u0027: extra_specs.get(\u0027netapp:space_allocation\u0027),"},{"line_number":234,"context_line":"                    \u0027Path\u0027: \u0027/vol/%s/%s\u0027 % (pool_name, lun_name)}"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        qos_policy_group_info \u003d self._setup_qos_for_volume(volume, extra_specs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"452ae537_ea36d677","line":233,"range":{"start_line":233,"start_character":38,"end_line":233,"end_character":80},"in_reply_to":"ddcf1b3b_c0b3572c","updated":"2023-08-09 18:11:39.000000000","message":"Thank you! for suggestion. update dictionary get to return false in case of missing value.","commit_id":"da923d8dad007c03b2bf134e582487f95a8bb354"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e3820e58cfa03c4be02f24f6aa38268ceff342a2","unresolved":true,"context_lines":[{"line_number":231,"context_line":"        metadata \u003d {\u0027OsType\u0027: self.lun_ostype,"},{"line_number":232,"context_line":"                    \u0027SpaceReserved\u0027: self.lun_space_reservation,"},{"line_number":233,"context_line":"                    \u0027SpaceAllocated\u0027:"},{"line_number":234,"context_line":"                        extra_specs.get(\u0027netapp:space_allocation\u0027, \u0027false\u0027),"},{"line_number":235,"context_line":"                    \u0027Path\u0027: \u0027/vol/%s/%s\u0027 % (pool_name, lun_name)}"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        qos_policy_group_info \u003d self._setup_qos_for_volume(volume, extra_specs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5d32e43a_9c57dedb","line":234,"range":{"start_line":234,"start_character":24,"end_line":234,"end_character":65},"updated":"2023-08-16 11:56:48.000000000","message":"You are not validating this field, since it is passed by the end users, it may contain invalid values (e.g., typo \u0027truer\u0027). In this scenario, you will call a failed storage API, which should be avoided.\n\nPlease, validate the field and only call the storage API if it is passed correctly (or not passed).","commit_id":"8b7e816d2e968b6b195838fc8b58e90ec469e36a"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"b0eab5c256cbb4d82b393612caaf890d9f6cb5bf","unresolved":true,"context_lines":[{"line_number":231,"context_line":"        metadata \u003d {\u0027OsType\u0027: self.lun_ostype,"},{"line_number":232,"context_line":"                    \u0027SpaceReserved\u0027: self.lun_space_reservation,"},{"line_number":233,"context_line":"                    \u0027SpaceAllocated\u0027:"},{"line_number":234,"context_line":"                        extra_specs.get(\u0027netapp:space_allocation\u0027, \u0027false\u0027),"},{"line_number":235,"context_line":"                    \u0027Path\u0027: \u0027/vol/%s/%s\u0027 % (pool_name, lun_name)}"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        qos_policy_group_info \u003d self._setup_qos_for_volume(volume, extra_specs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"657e7de0_1dca64c0","line":234,"range":{"start_line":234,"start_character":24,"end_line":234,"end_character":65},"in_reply_to":"5d32e43a_9c57dedb","updated":"2023-08-17 09:53:58.000000000","message":"Thank you! Felipe, Driver is transparently passing user request to ONTAP and error back to user transparently. Ex: For ONTAP QOS, I didn\u0027t find any custom validations for extra spec in driver. Let me know if you see otherwise. Below example from executing type. Resource is not create(i.e. no side effect). Also, ONTAP error message in detailed enough to point at problem. To address your comment i have to replicate all scenarios what ONTAP is handling already.\nstack@ostack-ubuntu-03 ~ $ openstack volume type list --long | grep test\n| b0d95d7d-8a2b-4ac3-b06d-4225799970a9 | sai_iscsi_sa_test    | True      |                     | netapp:space_allocation\u003d\u0027truer\u0027                              |\ncinder create --display-name sai-iscsi-sa-test --volume-type sai_iscsi_sa_test 1\ncinder list | grep test\n| e5872471-d20c-485b-a487-ab90af89bf38 | error      | sai-iscsi-sa-test   | 1    | sai_iscsi_sa_test    | false    |             |\nstack@ostack-ubuntu-03 ~ $\nERROR cinder.volume.manager cinder.volume.drivers.netapp.dataontap.client.api.NaApiError: NetApp API failed. Reason - 13115:Invalid boolean value for space-allocation-enabled: truer","commit_id":"8b7e816d2e968b6b195838fc8b58e90ec469e36a"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"e572baaf6e64ff52fe82941dfd922a73260cb4af","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        metadata \u003d {\u0027OsType\u0027: self.lun_ostype,"},{"line_number":232,"context_line":"                    \u0027SpaceReserved\u0027: self.lun_space_reservation,"},{"line_number":233,"context_line":"                    \u0027SpaceAllocated\u0027:"},{"line_number":234,"context_line":"                        extra_specs.get(\u0027netapp:space_allocation\u0027, \u0027false\u0027),"},{"line_number":235,"context_line":"                    \u0027Path\u0027: \u0027/vol/%s/%s\u0027 % (pool_name, lun_name)}"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        qos_policy_group_info \u003d self._setup_qos_for_volume(volume, extra_specs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf76ad7a_7363ddba","line":234,"range":{"start_line":234,"start_character":24,"end_line":234,"end_character":65},"in_reply_to":"657e7de0_1dca64c0","updated":"2023-08-17 17:13:52.000000000","message":"Thank you! Added validation and unit tests for additional code.","commit_id":"8b7e816d2e968b6b195838fc8b58e90ec469e36a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e1d4e8019047fb133c3b5cdccfc9a56b26f6c22c","unresolved":true,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        extra_specs \u003d na_utils.get_volume_extra_specs(volume)"},{"line_number":226,"context_line":"        thin_provisioning_support \u003d ("},{"line_number":227,"context_line":"            extra_specs.get(\u0027capabilities:thin_provisioning_support\u0027, True))"},{"line_number":228,"context_line":"        thick_provisioning_support \u003d ("},{"line_number":229,"context_line":"            extra_specs.get(\u0027capabilities:thick_provisioning_support\u0027, False))"},{"line_number":230,"context_line":"        space_allocation \u003d \u0027false\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"3edab234_cbcf7e16","line":227,"range":{"start_line":227,"start_character":70,"end_line":227,"end_character":74},"updated":"2023-08-29 09:46:46.000000000","message":"?: Maybe I misunderstood, but I thought that the NetApp pool could be configured to default to thin or thick provisioning, but looking at this code it would mean that it\u0027s always thin, is that correct?","commit_id":"44de128963ca3e020586948a4340adfbf27d95ed"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"1a44ba6c5a6f612dbfb3b283b38e520f9c660515","unresolved":true,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        extra_specs \u003d na_utils.get_volume_extra_specs(volume)"},{"line_number":226,"context_line":"        thin_provisioning_support \u003d ("},{"line_number":227,"context_line":"            extra_specs.get(\u0027capabilities:thin_provisioning_support\u0027, True))"},{"line_number":228,"context_line":"        thick_provisioning_support \u003d ("},{"line_number":229,"context_line":"            extra_specs.get(\u0027capabilities:thick_provisioning_support\u0027, False))"},{"line_number":230,"context_line":"        space_allocation \u003d \u0027false\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"7e699be0_8e4205d6","line":227,"range":{"start_line":227,"start_character":70,"end_line":227,"end_character":74},"in_reply_to":"3edab234_cbcf7e16","updated":"2023-08-29 12:00:20.000000000","message":"I have the same understanding as Gorka. The NetApp pool default behavior follows the FlexVol (pool on ONTAP side) configuration. It means, if FlexVol is thin, the default Cinder volume wil be thin. If the FlexVol is thick, the default Cinder volume will be thick. In another words, it could be both, depending on the pool configuration.","commit_id":"44de128963ca3e020586948a4340adfbf27d95ed"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e1d4e8019047fb133c3b5cdccfc9a56b26f6c22c","unresolved":true,"context_lines":[{"line_number":226,"context_line":"        thin_provisioning_support \u003d ("},{"line_number":227,"context_line":"            extra_specs.get(\u0027capabilities:thin_provisioning_support\u0027, True))"},{"line_number":228,"context_line":"        thick_provisioning_support \u003d ("},{"line_number":229,"context_line":"            extra_specs.get(\u0027capabilities:thick_provisioning_support\u0027, False))"},{"line_number":230,"context_line":"        space_allocation \u003d \u0027false\u0027"},{"line_number":231,"context_line":"        if thick_provisioning_support or not thin_provisioning_support:"},{"line_number":232,"context_line":"            space_allocation \u003d \u0027true\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"71fb4ac7_6fa9aec1","line":229,"updated":"2023-08-29 09:46:46.000000000","message":"-1: This doesn\u0027t cover all cases:\n\n- Extra spec key can also be without the \"capabilities:\" prefix.\n- Extra spec can be missing the thin or thick provisioning support and instead provide the \"provisioning:type\".\n- It\u0027s not enough to check that the key has data, we have to determine if it\u0027s setting it to True or False, because we could have a value of \"\u003cis\u003e False\".\n\nYou can at the description of these cases here: https://github.com/openstack/cinder-specs/blob/master/specs/kilo/over-subscription-in-thin-provisioning.rst#volume-type-extra-specs\n\nWe should create a common method in cinder/volume/driver_utils.py to do this, since it will be common for all drivers (I won\u0027t downvote if you just create it in your driver).","commit_id":"44de128963ca3e020586948a4340adfbf27d95ed"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"1a44ba6c5a6f612dbfb3b283b38e520f9c660515","unresolved":true,"context_lines":[{"line_number":226,"context_line":"        thin_provisioning_support \u003d ("},{"line_number":227,"context_line":"            extra_specs.get(\u0027capabilities:thin_provisioning_support\u0027, True))"},{"line_number":228,"context_line":"        thick_provisioning_support \u003d ("},{"line_number":229,"context_line":"            extra_specs.get(\u0027capabilities:thick_provisioning_support\u0027, False))"},{"line_number":230,"context_line":"        space_allocation \u003d \u0027false\u0027"},{"line_number":231,"context_line":"        if thick_provisioning_support or not thin_provisioning_support:"},{"line_number":232,"context_line":"            space_allocation \u003d \u0027true\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"2baa2b38_9d52eec5","line":229,"in_reply_to":"71fb4ac7_6fa9aec1","updated":"2023-08-29 12:00:20.000000000","message":"Gorka+1","commit_id":"44de128963ca3e020586948a4340adfbf27d95ed"}],"cinder/volume/drivers/netapp/dataontap/block_cmode.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"a7021137ea4c3b619a2a7c27aee626fc95e49642","unresolved":true,"context_lines":[{"line_number":263,"context_line":"        data[\u0027pools\u0027] \u003d self._get_pool_stats("},{"line_number":264,"context_line":"            filter_function\u003dfilter_function,"},{"line_number":265,"context_line":"            goodness_function\u003dgoodness_function)"},{"line_number":266,"context_line":"        if data[\u0027storage_protocol\u0027] \u003d\u003d constants.ISCSI:"},{"line_number":267,"context_line":"            for pool in data[\u0027pools\u0027]:"},{"line_number":268,"context_line":"                pool[\u0027thick_provisioning_support\u0027] \u003d True"},{"line_number":269,"context_line":"                pool[\u0027thin_provisioning_support\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":13,"id":"9c6b6538_ec24260e","line":266,"updated":"2023-08-29 12:29:18.000000000","message":"Please, add a NOTE here explaining this behavior. It seems like \"magic\" without a note.\n\n\\# NOTE(jayaanand): only iSCSI backends can enable/disable LUN space-allocation feature, selecting thin or thick no matter how the pool (FlexVol) is configured. Other protocols keep supporing only one of those provisioning according to the pool.","commit_id":"44de128963ca3e020586948a4340adfbf27d95ed"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e1d4e8019047fb133c3b5cdccfc9a56b26f6c22c","unresolved":true,"context_lines":[{"line_number":263,"context_line":"        data[\u0027pools\u0027] \u003d self._get_pool_stats("},{"line_number":264,"context_line":"            filter_function\u003dfilter_function,"},{"line_number":265,"context_line":"            goodness_function\u003dgoodness_function)"},{"line_number":266,"context_line":"        if data[\u0027storage_protocol\u0027] \u003d\u003d constants.ISCSI:"},{"line_number":267,"context_line":"            for pool in data[\u0027pools\u0027]:"},{"line_number":268,"context_line":"                pool[\u0027thick_provisioning_support\u0027] \u003d True"},{"line_number":269,"context_line":"                pool[\u0027thin_provisioning_support\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":13,"id":"795c875a_ee30f273","line":266,"updated":"2023-08-29 09:46:46.000000000","message":"nit: I\u0027m not loving the code setting the values of thin and thick support first in `update_ssc` and then overriding them here based on the protocol.\n\n?: Is the pool always able to do thin and thick?  I thought it was only able to do both if the pool was configured for thin.","commit_id":"44de128963ca3e020586948a4340adfbf27d95ed"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"a7021137ea4c3b619a2a7c27aee626fc95e49642","unresolved":true,"context_lines":[{"line_number":263,"context_line":"        data[\u0027pools\u0027] \u003d self._get_pool_stats("},{"line_number":264,"context_line":"            filter_function\u003dfilter_function,"},{"line_number":265,"context_line":"            goodness_function\u003dgoodness_function)"},{"line_number":266,"context_line":"        if data[\u0027storage_protocol\u0027] \u003d\u003d constants.ISCSI:"},{"line_number":267,"context_line":"            for pool in data[\u0027pools\u0027]:"},{"line_number":268,"context_line":"                pool[\u0027thick_provisioning_support\u0027] \u003d True"},{"line_number":269,"context_line":"                pool[\u0027thin_provisioning_support\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":13,"id":"9c0d3078_dbc8db3c","line":266,"in_reply_to":"795c875a_ee30f273","updated":"2023-08-29 12:29:18.000000000","message":"Gorka, I think so. The thick pool can have the thin and thick volumes. A thin pool can have thin and thick volumes too. That\u0027s the idea of ONTAP LUN space-allocatiion: you can request thin/thick no matter where the LUN is on. I am not totally sure, though. That\u0027s my understanding. Please, Jayaa confirm this information.","commit_id":"44de128963ca3e020586948a4340adfbf27d95ed"}],"cinder/volume/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"c734ec63bc494637e193ac74bd96dd2060901637","unresolved":true,"context_lines":[{"line_number":663,"context_line":"            \u0027svm.name\u0027: self.vserver,"},{"line_number":664,"context_line":"            \u0027fields\u0027: \u0027svm.name,location.volume.name,space.size,\u0027"},{"line_number":665,"context_line":"                      \u0027location.qtree.name,name,os_type,\u0027"},{"line_number":666,"context_line":"                      \u0027space.scsi_thin_provisioning_support_enabled,\u0027"},{"line_number":667,"context_line":"                      \u0027space.guarantee.requested,uuid\u0027"},{"line_number":668,"context_line":"        }"},{"line_number":669,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"02da94d7_011dee21","line":666,"range":{"start_line":666,"start_character":29,"end_line":666,"end_character":33},"updated":"2023-08-09 13:01:59.000000000","message":"Possible typo of iscsi? If so, there is other locations (commit message, tests, fakes file) to correct using this name.","commit_id":"da923d8dad007c03b2bf134e582487f95a8bb354"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"4a9d33e3f772a470d4b998babb83ea99292b1d54","unresolved":false,"context_lines":[{"line_number":663,"context_line":"            \u0027svm.name\u0027: self.vserver,"},{"line_number":664,"context_line":"            \u0027fields\u0027: \u0027svm.name,location.volume.name,space.size,\u0027"},{"line_number":665,"context_line":"                      \u0027location.qtree.name,name,os_type,\u0027"},{"line_number":666,"context_line":"                      \u0027space.scsi_thin_provisioning_support_enabled,\u0027"},{"line_number":667,"context_line":"                      \u0027space.guarantee.requested,uuid\u0027"},{"line_number":668,"context_line":"        }"},{"line_number":669,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bc0533ee_ed387ceb","line":666,"range":{"start_line":666,"start_character":29,"end_line":666,"end_character":33},"in_reply_to":"02da94d7_011dee21","updated":"2023-08-09 18:11:39.000000000","message":"Thank you! for the review.Attribute text is taken from ONTAP documentation...https://library.netapp.com/ecm/ecm_download_file/ECMLP2882104 ... Please look at page#174","commit_id":"da923d8dad007c03b2bf134e582487f95a8bb354"}],"releasenotes/notes/netapp-space-allocation-support-1c626740f15ae4fc.yaml":[{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"59aa1be0b3690c4d24b9ce1ea97516178bdf45e9","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The \"space-allocation\" feature in ONTAP LUN management refers to how"},{"line_number":5,"context_line":"    storage space is allocated and managed within the LUN. Current "},{"line_number":6,"context_line":"    implementation defaults to space-allocation to false. Resulting "},{"line_number":7,"context_line":"    in always restrict to thin-provisioning. Need flexibility from "},{"line_number":8,"context_line":"    user perspective to thin or thick provision, \u0027space-allocation\u0027 "}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c965eee1_0e926b92","line":5,"range":{"start_line":5,"start_character":66,"end_line":5,"end_character":67},"updated":"2023-08-22 12:14:24.000000000","message":"nit: white spaces","commit_id":"e4b547897f2a89b324496f643509100363d33662"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"67091eacbef94167eb3350e287a389fb9c0e25ef","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The \"space-allocation\" feature in ONTAP LUN management refers to how"},{"line_number":5,"context_line":"    storage space is allocated and managed within the LUN. Current "},{"line_number":6,"context_line":"    implementation defaults to space-allocation to false. Resulting "},{"line_number":7,"context_line":"    in always restrict to thin-provisioning. Need flexibility from "},{"line_number":8,"context_line":"    user perspective to thin or thick provision, \u0027space-allocation\u0027 "}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5084cdaf_240fffe0","line":5,"range":{"start_line":5,"start_character":66,"end_line":5,"end_character":67},"in_reply_to":"c965eee1_0e926b92","updated":"2023-08-23 13:31:21.000000000","message":"Thank you! Caique. looks like Idea is adding empty spaces. I will try to see this will be removed in next commit.","commit_id":"e4b547897f2a89b324496f643509100363d33662"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"1a44ba6c5a6f612dbfb3b283b38e520f9c660515","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    space-allocation option to enabled, ONTAP notifies"},{"line_number":5,"context_line":"    the host when the volume has run out of space and"},{"line_number":6,"context_line":"    the LUN in the volume cannot accept writes."},{"line_number":7,"context_line":"    This option also enables ONTAP to reclaim space "},{"line_number":8,"context_line":"    automatically when your host deletes data."},{"line_number":9,"context_line":"    Volume extraspec capabilities:thin_provisioning_support"},{"line_number":10,"context_line":"    and capabilities:thick_provisioning_support will be used"},{"line_number":11,"context_line":"    to set space_allocation to true/false when"},{"line_number":12,"context_line":"    iSCSI LUN is created"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"2f4910ae_9ba30ea7","line":12,"range":{"start_line":4,"start_character":4,"end_line":12,"end_character":24},"updated":"2023-08-29 12:00:20.000000000","message":"It seems a bit confuse. I think too much information. You should be more direct, explaing the new feature with the Cinder view (they are Cinder/OpenStack users, not ONTAP users) and Operators view. You shouldn\u0027t explain how it works in the low level.  Please, read [1]. Specifally, the driver section. Note: a driver feature should start with: \"NetApp ONTAP iSCSI driver:\"\n\nIt might be:\n\nNetApp ONTAP iSCSI driver: this driver is now supporting in the same backend the thin and thick provisioning. Requesting a thin provisioned volume will enable the ONTAP space-allocation for that volume.\n\n[1] https://docs.openstack.org/cinder/latest/contributor/releasenotes.html","commit_id":"44de128963ca3e020586948a4340adfbf27d95ed"}]}