)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c1fae02705e97f5aad039eec749b22b35804361f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0cfd2014_39aad0d3","updated":"2023-08-17 20:48:59.000000000","message":"Thanks for doing this.  As far as I\u0027m concerned, it\u0027s definitely an improvement.","commit_id":"2c858e9b407770c6979c465e1662015cb959987d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"37d41c1a022ebc1a6d4976847555feb05ed1105c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"849b54bd_bc2ddc54","updated":"2024-03-22 20:53:19.000000000","message":"Still LGTM.","commit_id":"d4c9fb62012b5ec79fbb0e2468d4f6443043a03c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3c855aee9214a8578504ca5d5bddc4df0905f2a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8d57054e_446e7d4c","updated":"2024-05-17 15:46:20.000000000","message":"I agree with Brian that removing parenthesis for some statements will improve readability. However that\u0027s not the main purpose of this patch. LGTM.","commit_id":"b87d45b3c87ad836d94c7bcbde1dbaeff5f1caae"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a5f1573aef73815547ac195e198fad45900408e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"238ba550_5812949c","updated":"2024-05-13 16:08:06.000000000","message":"Nice. I\u0027d done this separately in https://review.opendev.org/c/openstack/cinder/+/916788 but I\u0027m happy to rebase this series once this lands","commit_id":"b87d45b3c87ad836d94c7bcbde1dbaeff5f1caae"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fafa9cc2872a60e0ee9b33e2a207b1b029952889","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0b380700_d737cf28","updated":"2024-05-17 15:32:00.000000000","message":"Still LGTM.  A few nits noted inline, but let\u0027s merge this thing, and if they bother anyone else, they can be handled in a followup.  This is definitely an improvement.\n\nRaising the priority because, let\u0027s merge this thing and get it out of here!","commit_id":"b87d45b3c87ad836d94c7bcbde1dbaeff5f1caae"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d1891a908a26a3c9b57cc5a59dab7c27d8572c82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d947d9c4_65e4b99a","updated":"2024-05-03 20:48:04.000000000","message":"recheck\n\nlvm-lio-barbican failed in\n    tempest.scenario.test_instances_with_cinder_volumes.TestInstancesWithCinderVolumes.test_instances_with_cinder_volumes_on_all_compute_nodes","commit_id":"b87d45b3c87ad836d94c7bcbde1dbaeff5f1caae"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"369833b1e956ddf60869a5e9f89ebcffaa2d74b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b3c2eb2b_ad2db20e","updated":"2024-04-19 14:40:34.000000000","message":"recheck tempest-slow-py3 - tempest.scenario.test_volume_migrate_attached.TestVolumeMigrateRetypeAttached.test_volume_migrate_attached_data_volume : tempest.lib.exceptions.SSHExecCommandFailed: Command \u0027set -eu -o pipefail; PATH\u003d$PATH:/sbin:/usr/sbin; sudo mount /dev/vdb /mnt\u0027, exit status: 255, stderr:\nmount: mounting /dev/vdb on /mnt failed: Device or resource busy","commit_id":"b87d45b3c87ad836d94c7bcbde1dbaeff5f1caae"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"511a1181c38e8e6be658ca985ae841b55070daec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d8477502_56849756","in_reply_to":"238ba550_5812949c","updated":"2024-05-13 16:08:30.000000000","message":"*rebase this series and drop my patch, naturally","commit_id":"b87d45b3c87ad836d94c7bcbde1dbaeff5f1caae"}],"cinder/tests/unit/volume/drivers/hpe/test_hpe3par.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fafa9cc2872a60e0ee9b33e2a207b1b029952889","unresolved":true,"context_lines":[{"line_number":5360,"context_line":""},{"line_number":5361,"context_line":"            conf \u003d self._set_unique_fqdn_override(False, in_shared)"},{"line_number":5362,"context_line":"            my_connector \u003d self.connector.copy()"},{"line_number":5363,"context_line":"            del (my_connector[\u0027initiator\u0027])"},{"line_number":5364,"context_line":"            my_connector[\u0027host\u0027] \u003d \"abc123abc123abc123abc123abc123abc123\""},{"line_number":5365,"context_line":"            safe_host \u003d common._safe_hostname(my_connector, conf)"},{"line_number":5366,"context_line":"            self.assertEqual(fixed_hostname, safe_host)"}],"source_content_type":"text/x-python","patch_set":6,"id":"451fcd36_be64f817","line":5363,"updated":"2024-05-17 15:32:00.000000000","message":"nit: don\u0027t think this needs any parentheses?","commit_id":"b87d45b3c87ad836d94c7bcbde1dbaeff5f1caae"}],"cinder/tests/unit/volume/drivers/lightos/test_lightos_storage.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fafa9cc2872a60e0ee9b33e2a207b1b029952889","unresolved":true,"context_lines":[{"line_number":202,"context_line":"        return httpstatus.OK, vol"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def update_volume(self, **kwargs):"},{"line_number":205,"context_line":"        assert (\"project_name\" in kwargs and kwargs[\"project_name\"]), \\"},{"line_number":206,"context_line":"            \"project_name must be provided\""},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def create_snapshot(self, snapshot) -\u003e Tuple[int, Dict]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"b7ac15c6_c299ab11","line":205,"updated":"2024-05-17 15:32:00.000000000","message":"nit: don\u0027t need the parens around the expression","commit_id":"b87d45b3c87ad836d94c7bcbde1dbaeff5f1caae"}],"cinder/tests/unit/volume/drivers/netapp/test_utils.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fafa9cc2872a60e0ee9b33e2a207b1b029952889","unresolved":true,"context_lines":[{"line_number":723,"context_line":""},{"line_number":724,"context_line":"    def test_get_backend_qos_spec_from_volume_type_no_qos_specs_id(self):"},{"line_number":725,"context_line":"        volume_type \u003d copy.deepcopy(fake.VOLUME_TYPE)"},{"line_number":726,"context_line":"        del (volume_type[\u0027qos_specs_id\u0027])"},{"line_number":727,"context_line":"        mock_get_context \u003d self.mock_object(context, \u0027get_admin_context\u0027)"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"        result \u003d na_utils.get_backend_qos_spec_from_volume_type(volume_type)"}],"source_content_type":"text/x-python","patch_set":6,"id":"53fb9487_312b3dfb","line":726,"updated":"2024-05-17 15:32:00.000000000","message":"nit: parens not needed","commit_id":"b87d45b3c87ad836d94c7bcbde1dbaeff5f1caae"}],"cinder/tests/unit/volume/flows/test_create_volume_flow.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fafa9cc2872a60e0ee9b33e2a207b1b029952889","unresolved":true,"context_lines":[{"line_number":1348,"context_line":"    def test_get_flow(self, is_migration_target, use_quota, flow_mock,"},{"line_number":1349,"context_line":"                      extract_ref_mock, onfailure_mock, extract_spec_mock,"},{"line_number":1350,"context_line":"                      notify_mock, create_mock, onfinish_mock, load_mock):"},{"line_number":1351,"context_line":"        assert (isinstance(is_migration_target, bool))"},{"line_number":1352,"context_line":"        filter_properties \u003d {\u0027retry\u0027: mock.sentinel.retry}"},{"line_number":1353,"context_line":"        tasks \u003d [mock.call(extract_ref_mock.return_value),"},{"line_number":1354,"context_line":"                 mock.call(onfailure_mock.return_value),"}],"source_content_type":"text/x-python","patch_set":6,"id":"b1062147_0f0f463d","line":1351,"updated":"2024-05-17 15:32:00.000000000","message":"nit: outer parens not necessary","commit_id":"b87d45b3c87ad836d94c7bcbde1dbaeff5f1caae"}],"cinder/volume/drivers/datacore/driver.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fafa9cc2872a60e0ee9b33e2a207b1b029952889","unresolved":true,"context_lines":[{"line_number":411,"context_line":"            kwargs \u003d {\u0027existing_ref\u0027: vd_alias,"},{"line_number":412,"context_line":"                      \u0027reason\u0027: \u0027Specified Virtual disk does not exist.\u0027}"},{"line_number":413,"context_line":"            raise cinder_exception.ManageExistingInvalidReference(**kwargs)"},{"line_number":414,"context_line":"        return (self._get_size_in_gigabytes(virtual_disk.Size.Value))"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    def _update_volume_stats(self):"},{"line_number":417,"context_line":"        performance_data \u003d self._api.get_performance_by_type("}],"source_content_type":"text/x-python","patch_set":6,"id":"616aecea_fbdf1151","line":414,"updated":"2024-05-17 15:32:00.000000000","message":"nit:parens not necessary","commit_id":"b87d45b3c87ad836d94c7bcbde1dbaeff5f1caae"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fafa9cc2872a60e0ee9b33e2a207b1b029952889","unresolved":true,"context_lines":[{"line_number":4439,"context_line":"            if \u0027IOThrottle_rate\u0027 in model_update[\u0027metadata\u0027]:"},{"line_number":4440,"context_line":"                del model_update[\u0027metadata\u0027][\u0027IOThrottle_rate\u0027]"},{"line_number":4441,"context_line":"        model_update[\u0027host\u0027] \u003d volume[\u0027host\u0027]"},{"line_number":4442,"context_line":"        return (model_update)"},{"line_number":4443,"context_line":""},{"line_number":4444,"context_line":"    def add_vdisk_copy(self, volume, dest_pool, vol_type, auto_delete\u003dFalse):"},{"line_number":4445,"context_line":"        return self._helpers.add_vdisk_copy(volume, dest_pool,"}],"source_content_type":"text/x-python","patch_set":6,"id":"2f719eb4_eb8981dd","line":4442,"updated":"2024-05-17 15:32:00.000000000","message":"nit: parens not necessary","commit_id":"b87d45b3c87ad836d94c7bcbde1dbaeff5f1caae"}],"cinder/volume/drivers/remotefs.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fafa9cc2872a60e0ee9b33e2a207b1b029952889","unresolved":true,"context_lines":[{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"        LOG.info(\u0027Deleting stale snapshot: %s\u0027, snapshot.id)"},{"line_number":1259,"context_line":"        self._delete(snapshot_path)"},{"line_number":1260,"context_line":"        del (snap_info[snapshot.id])"},{"line_number":1261,"context_line":"        self._write_info_file(info_path, snap_info)"},{"line_number":1262,"context_line":""},{"line_number":1263,"context_line":"    def _delete_snapshot(self, snapshot: objects.Snapshot) -\u003e None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"668df18a_1a30e3e9","line":1260,"updated":"2024-05-17 15:32:00.000000000","message":"nit: don\u0027t need the parens on any of the \u0027del\u0027 statements in this file","commit_id":"b87d45b3c87ad836d94c7bcbde1dbaeff5f1caae"}],"cinder/volume/drivers/windows/smbfs.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fafa9cc2872a60e0ee9b33e2a207b1b029952889","unresolved":true,"context_lines":[{"line_number":486,"context_line":"            self._delete(merged_img_path)"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"            # TODO(lpetrut): drop snapshot info file usage."},{"line_number":489,"context_line":"            del (snap_info[snapshot.id])"},{"line_number":490,"context_line":"            self._write_info_file(info_path, snap_info)"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        if not isinstance(snapshot, objects.Snapshot):"}],"source_content_type":"text/x-python","patch_set":6,"id":"4e25328a_80f01ab3","line":489,"updated":"2024-05-17 15:32:00.000000000","message":"nit: don\u0027t need the parens","commit_id":"b87d45b3c87ad836d94c7bcbde1dbaeff5f1caae"}]}