)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4f8f3c371924b9007be6195df5b2b75b3002aa6b","unresolved":true,"context_lines":[{"line_number":21,"context_line":"Note: Storage feature \"High Availability\" is called"},{"line_number":22,"context_line":"\"Global-Active device\" on Hitachi storage."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Some code to support HAD can also support data deduplication,"},{"line_number":25,"context_line":"that is why this patch supporting two features in one patch."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Implements: blueprint HPEXP-support-GAD-dedup"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"54c2caf9_58d7039d","line":24,"range":{"start_line":24,"start_character":21,"end_line":24,"end_character":24},"updated":"2023-09-06 11:22:37.000000000","message":"GAD?","commit_id":"c986d8a1491a0d73995fee3d8187b3c18ea8b23e"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"29f9d0155aabb7cb41ca2af9aa20d7a53d33063a","unresolved":true,"context_lines":[{"line_number":21,"context_line":"Note: Storage feature \"High Availability\" is called"},{"line_number":22,"context_line":"\"Global-Active device\" on Hitachi storage."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Some code to support HAD can also support data deduplication,"},{"line_number":25,"context_line":"that is why this patch supporting two features in one patch."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Implements: blueprint HPEXP-support-GAD-dedup"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7c7a3413_36ea2614","line":24,"range":{"start_line":24,"start_character":21,"end_line":24,"end_character":24},"in_reply_to":"54c2caf9_58d7039d","updated":"2023-09-06 15:27:42.000000000","message":"HA is correct. I\u0027ll fix.","commit_id":"c986d8a1491a0d73995fee3d8187b3c18ea8b23e"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"06643c5d1e7c6c2c3b5b107b1c55b68c002d7f2a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Note: Storage feature \"High Availability\" is called"},{"line_number":22,"context_line":"\"Global-Active device\" on Hitachi storage."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Some code to support HAD can also support data deduplication,"},{"line_number":25,"context_line":"that is why this patch supporting two features in one patch."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Implements: blueprint HPEXP-support-GAD-dedup"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"d33950bf_23da1db9","line":24,"range":{"start_line":24,"start_character":21,"end_line":24,"end_character":24},"in_reply_to":"7c7a3413_36ea2614","updated":"2023-09-07 00:17:18.000000000","message":"Done","commit_id":"c986d8a1491a0d73995fee3d8187b3c18ea8b23e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4f8f3c371924b9007be6195df5b2b75b3002aa6b","unresolved":true,"context_lines":[{"line_number":21,"context_line":"Note: Storage feature \"High Availability\" is called"},{"line_number":22,"context_line":"\"Global-Active device\" on Hitachi storage."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Some code to support HAD can also support data deduplication,"},{"line_number":25,"context_line":"that is why this patch supporting two features in one patch."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Implements: blueprint HPEXP-support-GAD-dedup"},{"line_number":28,"context_line":"Change-Id: I8f8e231c499193b7801953ca96df41bf598fba14"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"901d30f5_6b7b33a5","line":25,"range":{"start_line":24,"start_character":29,"end_line":25,"end_character":60},"updated":"2023-09-06 11:22:37.000000000","message":"this is not a good reason to include 2 features into one\nIt\u0027s always better to have one feature in one patch and then do a dependent or follow up on that to support another one even if it has less code changes required to add the new feature","commit_id":"c986d8a1491a0d73995fee3d8187b3c18ea8b23e"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"06643c5d1e7c6c2c3b5b107b1c55b68c002d7f2a","unresolved":true,"context_lines":[{"line_number":21,"context_line":"Note: Storage feature \"High Availability\" is called"},{"line_number":22,"context_line":"\"Global-Active device\" on Hitachi storage."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Some code to support HAD can also support data deduplication,"},{"line_number":25,"context_line":"that is why this patch supporting two features in one patch."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Implements: blueprint HPEXP-support-GAD-dedup"},{"line_number":28,"context_line":"Change-Id: I8f8e231c499193b7801953ca96df41bf598fba14"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"62648c78_8bf81d24","line":25,"range":{"start_line":24,"start_character":29,"end_line":25,"end_character":60},"in_reply_to":"2946f41f_38546cb0","updated":"2023-09-07 00:17:18.000000000","message":"Please forget above my reply.\nI\u0027ll :\n- fix this patch to support HA only\n- upload another follow up patch for supporting deduplication","commit_id":"c986d8a1491a0d73995fee3d8187b3c18ea8b23e"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"388a0710806e30307ed4a4433d4e026a3ea6dcf1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Note: Storage feature \"High Availability\" is called"},{"line_number":22,"context_line":"\"Global-Active device\" on Hitachi storage."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Some code to support HAD can also support data deduplication,"},{"line_number":25,"context_line":"that is why this patch supporting two features in one patch."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Implements: blueprint HPEXP-support-GAD-dedup"},{"line_number":28,"context_line":"Change-Id: I8f8e231c499193b7801953ca96df41bf598fba14"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"40e5acee_23e66751","line":25,"range":{"start_line":24,"start_character":29,"end_line":25,"end_character":60},"in_reply_to":"62648c78_8bf81d24","updated":"2023-09-07 01:41:14.000000000","message":"Done","commit_id":"c986d8a1491a0d73995fee3d8187b3c18ea8b23e"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"29f9d0155aabb7cb41ca2af9aa20d7a53d33063a","unresolved":true,"context_lines":[{"line_number":21,"context_line":"Note: Storage feature \"High Availability\" is called"},{"line_number":22,"context_line":"\"Global-Active device\" on Hitachi storage."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Some code to support HAD can also support data deduplication,"},{"line_number":25,"context_line":"that is why this patch supporting two features in one patch."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Implements: blueprint HPEXP-support-GAD-dedup"},{"line_number":28,"context_line":"Change-Id: I8f8e231c499193b7801953ca96df41bf598fba14"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"2946f41f_38546cb0","line":25,"range":{"start_line":24,"start_character":29,"end_line":25,"end_character":60},"in_reply_to":"901d30f5_6b7b33a5","updated":"2023-09-06 15:27:42.000000000","message":"\u003e another one even if it has less code changes required to add the new feature\n\nIt is no code change to support deduplication for the code to support HA.\nIf we make separate patches, the differences b/w both patches for HA and for deduplication should be commit message only.\nShould we separete patches?","commit_id":"c986d8a1491a0d73995fee3d8187b3c18ea8b23e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4f8f3c371924b9007be6195df5b2b75b3002aa6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ca31ceaf_3b70cb25","updated":"2023-09-06 11:22:37.000000000","message":"I think this needs to be split up into two different features, It doesn\u0027t sound correct to have 2 driver features in one patch. Let\u0027s discuss this at the cinder meeting today","commit_id":"c986d8a1491a0d73995fee3d8187b3c18ea8b23e"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"aef1b7b00c067b286e30e47e63b5fed53fd80ec1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0663750c_a24a34b7","updated":"2023-09-08 13:02:40.000000000","message":"LGTM, thank you","commit_id":"2610317fd46ee8d2e6454cb981421ec670ab9413"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"8351a0e7c564c2aea86d25c65147bcbc825644e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1d9172fc_e7c2dfad","updated":"2023-09-11 03:34:31.000000000","message":"recheck InvocationError in cinder-plugin-ceph-tempest","commit_id":"2610317fd46ee8d2e6454cb981421ec670ab9413"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"d6940e84459c237385f245cfcc611909589932e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"565f366e_8be9e435","updated":"2023-09-12 10:26:25.000000000","message":"Looks good to me - thank you!","commit_id":"900e909b2640ce3d924ade22087fda4922939048"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"94a3878f18b5a3930148c419910d14296ff1054c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b1286e4e_8a72afd0","updated":"2023-09-11 10:10:07.000000000","message":"Patchset6 is to separate unit test code and add test cases for HA","commit_id":"900e909b2640ce3d924ade22087fda4922939048"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"63fd00dafa193f7b05a90dcf20e2b7971d2fc54e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4ce2cf19_99079ea9","updated":"2023-12-06 13:38:47.000000000","message":"LGTM. Thks","commit_id":"642f4f0e471c6ac666e65ec5d33aab690c652fa9"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"6f0dbf0c99ba11e272682f2d148a438d8ef54eee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2d0e016b_9ffc85a1","updated":"2023-11-29 05:56:54.000000000","message":"Rebased to solve merge conflict, not changed any code and releasenote","commit_id":"642f4f0e471c6ac666e65ec5d33aab690c652fa9"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"fd1fb4097db6e382d1410fa16044f0097cffdb7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a2bc6d6f_122ac87f","updated":"2024-01-19 14:55:12.000000000","message":"Are we sure someone\u0027s not confused about active-active here? The base driver that\u0027s getting re-implemented here does not set that flag. See:\n cinder/volume/drivers/hitachi/hbsd_iscsi.py\n \nIf that is fine, then this is fine too, I think.\n\nActive-active is a feature of Cinder. There may be a controller failover in the array, driven by one instance of controller node (e.g. not A-A). Right? Please correct me if I\u0027m wrong.","commit_id":"af8daa65021e803e5e052c5995b918d217ea8afb"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"4dcbbc6ca6ef894d49c4a3336f20f92543440c58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"73c7dde0_a72da39b","updated":"2024-01-18 10:33:02.000000000","message":"As per my knowledge, below file also needs to be updated:\ndoc/source/reference/support-matrix.ini\nUnder section: [operation.active_active_ha]\nline 997: driver.hpe_xp\u003dcomplete","commit_id":"af8daa65021e803e5e052c5995b918d217ea8afb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e262bc8736aa797959f8fad9793bafee7b03fb69","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3c63f670_4c7dd750","updated":"2024-02-05 08:12:45.000000000","message":"IIUC https://review.opendev.org/c/openstack/cinder/+/907139 should be merged into this.","commit_id":"af8daa65021e803e5e052c5995b918d217ea8afb"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"dae328e4650834b2e23a51e28f0b8bb6ce84ebab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"cef17001_5927e3c2","updated":"2024-01-18 10:39:19.000000000","message":"One more comment inline","commit_id":"af8daa65021e803e5e052c5995b918d217ea8afb"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"b626147b00322548af770232f8c6e1696fe874dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5c255273_2954db2f","updated":"2024-01-22 05:06:12.000000000","message":"Thanks Kawai \u0026 Pete for providing details.","commit_id":"af8daa65021e803e5e052c5995b918d217ea8afb"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"0d6445b619e5e95dc6c419b8800cf67a5ad377de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c4dec1fd_70b5b83a","updated":"2024-01-18 04:32:52.000000000","message":"rebased by \"896412: Skip sparse copy during volume reimage | https://review.opendev.org/c/openstack/cinder/+/896412 \" is merged","commit_id":"af8daa65021e803e5e052c5995b918d217ea8afb"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"802a8768bd12bb5fdc1a7578702eec7af5688a24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"dcbbd45d_833b7906","updated":"2024-01-18 07:58:32.000000000","message":"recheck tempest-slow-py3 by connection timed out","commit_id":"af8daa65021e803e5e052c5995b918d217ea8afb"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"9d15f91218fcddaddcfc5e89f9712701ec7313ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6506ebfa_76cf9e6b","in_reply_to":"3c63f670_4c7dd750","updated":"2024-02-07 01:07:07.000000000","message":"I\u0027ve updated the files along above the patch.","commit_id":"af8daa65021e803e5e052c5995b918d217ea8afb"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"3b85b19241766cea8a520ed3539c793e0bb6e801","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d142ab9d_90224d40","in_reply_to":"a2bc6d6f_122ac87f","updated":"2024-01-22 05:42:21.000000000","message":"To Pete, \nThank you for your help. Both you commented are correct.\nThe base driver supports only Active-Standby(\"A-S\"), and not set the flag, either.\nActive-Active(\"A-A\") is one of the failover mechanism. On A-A, Both nodes work usually, and survived node will also handle jobs which run on failed node.\nOn A-S, which is supported by the base driver and the patch, only one node works usually, and standby node will wake up and handle jobs when failed.","commit_id":"af8daa65021e803e5e052c5995b918d217ea8afb"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"2c4900cde777f5afda61430b6884d4fd13e1a304","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c7776554_b6c0e498","updated":"2024-02-07 14:39:41.000000000","message":"LGTM.","commit_id":"0946074134b9fa74b2227c89d542c35db847652b"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"780523bf2a8e7007bc78cd503ab2ea2502e76415","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"5c09e29c_42fc91e5","updated":"2024-02-07 13:05:51.000000000","message":"recheck\nbuild-openstack-releasenotes had failed because it could not find stable/yoga","commit_id":"0946074134b9fa74b2227c89d542c35db847652b"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"d975167d6c29e893b9445b6342319d8c4bd64fb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"6866f18a_ec3350ea","updated":"2024-02-16 06:51:48.000000000","message":"recheck tempest-integrated-storage","commit_id":"0946074134b9fa74b2227c89d542c35db847652b"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"b93cb6ab3769570de7dc7c9a9f957ff9abcee175","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"2cf3b3e3_1c75870b","updated":"2024-03-04 17:41:53.000000000","message":"(no change aside from copyright string)","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":34148,"name":"Aboubacar Diare","display_name":"abdi","email":"diare@hpe.com","username":"abdi"},"change_message_id":"024a7bd8cd82a08f913f4ddff14955554680ff82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d27425db_9dc3e090","updated":"2024-03-08 03:18:27.000000000","message":"@BrianRosmaita. HPE has had an unexpected resource transition and our CI is currently unmaned. I am being pulled in to help out but I am requesting the weekend to execute our CI against this patch in case we need to sort through devstack issues. Please advise!","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"70a669e018a769e369b0427715dab52e4989561c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3260faf1_95baf5ea","updated":"2024-03-07 19:14:18.000000000","message":"@akawai: thanks for answering my questions!","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0ae0d5fced2e2b4eefe7850fc8ccfd92db9a56f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"dfbbb64a_445211e5","updated":"2024-03-12 18:28:24.000000000","message":"As discussed, today was the deadline for getting a running CI. Please collect tempest test run from a local deployment and add that as a comment and bring it up in the cinder meeting tomorrow for team\u0027s approval.","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"861ba3a04833175bed7e66daf1765f850fc085e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"519dc113_15c14660","updated":"2024-03-11 18:19:53.000000000","message":"Checking on this today, the CI hasn\u0027t responded yet","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"43154defd1df272a1f102bf76ad53b82d9af602a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"535492d7_be6d25d1","updated":"2024-03-07 19:34:58.000000000","message":"Code looks good and has good test coverage.  Only a +1 because while the Hitachi VSP CI is green, I don\u0027t see the HPE_XP_Storage_CI responding on this patch (though correct me if I\u0027m wrong ... I may just be missing it).","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1f431f215b4bfcc0f10a77466bdb9323a2ab963b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"cad10d13_9f5a2ca5","updated":"2024-03-08 17:34:04.000000000","message":"Hi HPE team,\n\nWe are past the FFE deadline and ideally the feature should go into the next release. However, considering that the code and tests looks ready and the blocker is on the CI side, we understand that last moment breakage happens so we have a plan for merging this patch before RC1 (before cutting stable/2024.1 branch).\n\nBy Tuesday, The CI should be functional and reporting to get the change merged.\n\nIf that doesn\u0027t work out, there is another backup idea to run tempest locally and attach the logs here to verify the changes doesn\u0027t cause any regression and works with tempest tests.\n\nI would still encourage to get the CI functional since the tempest test result plan might require team\u0027s approval at the cinder meeting upstream and I can\u0027t say for certain if the team would approve of the idea.","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e8d77a32024c4265f18660780b430a77c05a3b9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"59904fbd_d4902648","updated":"2024-03-04 13:27:08.000000000","message":"Mostly looks good, but a few issues noted inline to look at.  I still need to look over the tests.","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"3229e80bc0c9bdc69d4ebb2afaec0e06d5dde2d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e45585fa_1ce18ce6","updated":"2024-02-27 00:20:43.000000000","message":"rebased for https://review.opendev.org/c/openstack/cinder/+/908808","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"88bce1d4e6af49fad411234c4ad6a310a564bfcd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1e23a198_a93d6384","updated":"2024-02-27 06:12:50.000000000","message":"recheck cinder-plugin-ceph-tempest by InvocationError","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"f9cc51b8e383839d078a645f45d287c2fb67e1bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ae5003ca_723559f4","updated":"2024-02-28 00:50:16.000000000","message":"recheck tempest-slow-py3 failed by request time out","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"31e9ed8f6691d5dff18ef78970d1cce197be2a98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"bc14f7dc_4f0f6b21","updated":"2024-02-27 08:28:29.000000000","message":"recheck unrelated incremental backup test failed","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":34148,"name":"Aboubacar Diare","display_name":"abdi","email":"diare@hpe.com","username":"abdi"},"change_message_id":"a4954fb3862aab5652a4dd8cf5df1946aa5a1ba3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"4536a63c_19bb8307","updated":"2024-03-12 10:22:00.000000000","message":"run-HPE XP Storage CI","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":34148,"name":"Aboubacar Diare","display_name":"abdi","email":"diare@hpe.com","username":"abdi"},"change_message_id":"35c04c5219e6163c88554a42ef040c05d5faa44a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"5834b052_4d9579e1","updated":"2024-03-12 10:12:29.000000000","message":"run-HPE XP Storage CI","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":34148,"name":"Aboubacar Diare","display_name":"abdi","email":"diare@hpe.com","username":"abdi"},"change_message_id":"f118a60184cfb7479cc636c01239fe5f83762dcb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7ff060ee_1662bb52","updated":"2024-03-12 10:19:04.000000000","message":"run-HPE XP Storage CI","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":34148,"name":"Aboubacar Diare","display_name":"abdi","email":"diare@hpe.com","username":"abdi"},"change_message_id":"daa26f42ff5cb2bc28d047b184c374e3ca21a662","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"96b06c07_f7e35e4b","in_reply_to":"519dc113_15c14660","updated":"2024-03-11 18:26:05.000000000","message":"Working on this.  Sorting through devstack issues.  Hoping to resolve them and get CI to respond ASAP.","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":34148,"name":"Aboubacar Diare","display_name":"abdi","email":"diare@hpe.com","username":"abdi"},"change_message_id":"daa26f42ff5cb2bc28d047b184c374e3ca21a662","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"8e7edb05_71287bf5","in_reply_to":"cad10d13_9f5a2ca5","updated":"2024-03-11 18:26:05.000000000","message":"Sounds great.  I\u0027ll try and get some results back through Gerrit first","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"4a8a3841bf47db73ddff93c68f7b9dea977b8565","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"a5a737bd_94c722a4","updated":"2024-07-29 00:52:41.000000000","message":"The patchset only solve merge conflict","commit_id":"ab1efbb04f71ee92708b411fb308d0aefd117f76"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"49dc38b48b3be9b56325b6873d16bd44ffc1936f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"4d33119b_cd4015cc","updated":"2024-09-26 11:19:18.000000000","message":"Patchset 14 is only for rebasing","commit_id":"7378acfd5a9e9a5b2eab3ef7cb6de43fa4f9b4da"}],"cinder/volume/drivers/hitachi/hbsd_common.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e8d77a32024c4265f18660780b430a77c05a3b9d","unresolved":true,"context_lines":[{"line_number":600,"context_line":"    def _range2list(self, param):"},{"line_number":601,"context_line":"        \"\"\"Analyze a \u0027xxx-xxx\u0027 string and return a list of two integers.\"\"\""},{"line_number":602,"context_line":"        values \u003d [str2int(value) for value in"},{"line_number":603,"context_line":"                  getattr(self.conf, param).split(\u0027-\u0027)]"},{"line_number":604,"context_line":"        if len(values) !\u003d 2 or None in values or values[0] \u003e values[1]:"},{"line_number":605,"context_line":"            msg \u003d self.output_log(MSG.INVALID_PARAMETER, param\u003dparam)"},{"line_number":606,"context_line":"            self.raise_error(msg)"}],"source_content_type":"text/x-python","patch_set":12,"id":"6d1036dd_5bf56fba","line":603,"updated":"2024-03-04 13:27:08.000000000","message":"I\u0027m assuming the switch from safe_get() here is to raise an AttributeError if param is missing?  If so, maybe you want to put this in a try so that you can use self.raise_error() like you do at lines 604-606?","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"4a6b45a5581f252a7d2ac9a434e9c7818c064fc7","unresolved":true,"context_lines":[{"line_number":600,"context_line":"    def _range2list(self, param):"},{"line_number":601,"context_line":"        \"\"\"Analyze a \u0027xxx-xxx\u0027 string and return a list of two integers.\"\"\""},{"line_number":602,"context_line":"        values \u003d [str2int(value) for value in"},{"line_number":603,"context_line":"                  getattr(self.conf, param).split(\u0027-\u0027)]"},{"line_number":604,"context_line":"        if len(values) !\u003d 2 or None in values or values[0] \u003e values[1]:"},{"line_number":605,"context_line":"            msg \u003d self.output_log(MSG.INVALID_PARAMETER, param\u003dparam)"},{"line_number":606,"context_line":"            self.raise_error(msg)"}],"source_content_type":"text/x-python","patch_set":12,"id":"84d2cb81_88c0aa12","line":603,"in_reply_to":"6d1036dd_5bf56fba","updated":"2024-03-07 04:50:46.000000000","message":"No, safe_get() will fail by the option is undefined every running, because this driver internally replaces the option names `hpexp_*`, which defined in cinder.conf by HPE XP user, to `hitachi_*`, then, use. Here is getting the value of `hitachi_ldev_range`, which is not defined in the cinder.conf.\nThis failure faced when supporting this feature.\n\nWhen the value is not defined, HPE XP storage will automatically uses the lowest unassigned LDEV number without any errors.","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"70a669e018a769e369b0427715dab52e4989561c","unresolved":false,"context_lines":[{"line_number":600,"context_line":"    def _range2list(self, param):"},{"line_number":601,"context_line":"        \"\"\"Analyze a \u0027xxx-xxx\u0027 string and return a list of two integers.\"\"\""},{"line_number":602,"context_line":"        values \u003d [str2int(value) for value in"},{"line_number":603,"context_line":"                  getattr(self.conf, param).split(\u0027-\u0027)]"},{"line_number":604,"context_line":"        if len(values) !\u003d 2 or None in values or values[0] \u003e values[1]:"},{"line_number":605,"context_line":"            msg \u003d self.output_log(MSG.INVALID_PARAMETER, param\u003dparam)"},{"line_number":606,"context_line":"            self.raise_error(msg)"}],"source_content_type":"text/x-python","patch_set":12,"id":"440f6ebc_ca4c4f3e","line":603,"in_reply_to":"84d2cb81_88c0aa12","updated":"2024-03-07 19:14:18.000000000","message":"Acknowledged","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e8d77a32024c4265f18660780b430a77c05a3b9d","unresolved":true,"context_lines":[{"line_number":647,"context_line":"                self.conf,"},{"line_number":648,"context_line":"                self.driver_info[\u0027param_prefix\u0027] + \u0027_group_name_format\u0027):"},{"line_number":649,"context_line":"            self.check_opts(self.conf, COMMON_NAME_OPTS)"},{"line_number":650,"context_line":"        if self.conf.hitachi_ldev_range:"},{"line_number":651,"context_line":"            self.storage_info[\u0027ldev_range\u0027] \u003d self._range2list("},{"line_number":652,"context_line":"                \u0027hitachi_ldev_range\u0027)"},{"line_number":653,"context_line":"        if (not self.conf.hitachi_target_ports and"},{"line_number":654,"context_line":"                not self.conf.hitachi_compute_target_ports):"},{"line_number":655,"context_line":"            msg \u003d self.output_log("}],"source_content_type":"text/x-python","patch_set":12,"id":"e0f823e8_27303fe7","line":652,"range":{"start_line":650,"start_character":0,"end_line":652,"end_character":37},"updated":"2024-03-04 13:27:08.000000000","message":"This is kind of an unrelated fix, but I don\u0027t mind including it.  You should review this series of settings carefully to make sure you have completely separated out all the hitachi-specific opts.","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"70a669e018a769e369b0427715dab52e4989561c","unresolved":false,"context_lines":[{"line_number":647,"context_line":"                self.conf,"},{"line_number":648,"context_line":"                self.driver_info[\u0027param_prefix\u0027] + \u0027_group_name_format\u0027):"},{"line_number":649,"context_line":"            self.check_opts(self.conf, COMMON_NAME_OPTS)"},{"line_number":650,"context_line":"        if self.conf.hitachi_ldev_range:"},{"line_number":651,"context_line":"            self.storage_info[\u0027ldev_range\u0027] \u003d self._range2list("},{"line_number":652,"context_line":"                \u0027hitachi_ldev_range\u0027)"},{"line_number":653,"context_line":"        if (not self.conf.hitachi_target_ports and"},{"line_number":654,"context_line":"                not self.conf.hitachi_compute_target_ports):"},{"line_number":655,"context_line":"            msg \u003d self.output_log("}],"source_content_type":"text/x-python","patch_set":12,"id":"dabcedcd_982cfa4a","line":652,"range":{"start_line":650,"start_character":0,"end_line":652,"end_character":37},"in_reply_to":"6841e2f9_72163477","updated":"2024-03-07 19:14:18.000000000","message":"Acknowledged","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"4a6b45a5581f252a7d2ac9a434e9c7818c064fc7","unresolved":true,"context_lines":[{"line_number":647,"context_line":"                self.conf,"},{"line_number":648,"context_line":"                self.driver_info[\u0027param_prefix\u0027] + \u0027_group_name_format\u0027):"},{"line_number":649,"context_line":"            self.check_opts(self.conf, COMMON_NAME_OPTS)"},{"line_number":650,"context_line":"        if self.conf.hitachi_ldev_range:"},{"line_number":651,"context_line":"            self.storage_info[\u0027ldev_range\u0027] \u003d self._range2list("},{"line_number":652,"context_line":"                \u0027hitachi_ldev_range\u0027)"},{"line_number":653,"context_line":"        if (not self.conf.hitachi_target_ports and"},{"line_number":654,"context_line":"                not self.conf.hitachi_compute_target_ports):"},{"line_number":655,"context_line":"            msg \u003d self.output_log("}],"source_content_type":"text/x-python","patch_set":12,"id":"6841e2f9_72163477","line":652,"range":{"start_line":650,"start_character":0,"end_line":652,"end_character":37},"in_reply_to":"e0f823e8_27303fe7","updated":"2024-03-07 04:50:46.000000000","message":"almost same as above. This driver internally replaced from `hpexp_ldev_range` to `hitachi_ldev_range`. It\u0027s related this feature.","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"}],"cinder/volume/drivers/hitachi/hbsd_replication.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e8d77a32024c4265f18660780b430a77c05a3b9d","unresolved":true,"context_lines":[{"line_number":238,"context_line":"            name \u003d opt.name.replace(\u0027hitachi_mirror_\u0027, \u0027hitachi_\u0027)"},{"line_number":239,"context_line":"            try:"},{"line_number":240,"context_line":"                if opt.name \u003d\u003d \u0027hitachi_mirror_pool\u0027:"},{"line_number":241,"context_line":"                    opt_value \u003d getattr(conf, \u0027hitachi_mirror_pool\u0027)"},{"line_number":242,"context_line":"                    if opt_value is not None:"},{"line_number":243,"context_line":"                        name \u003d \u0027hitachi_pools\u0027"},{"line_number":244,"context_line":"                        value \u003d [getattr(conf, opt.name)]"}],"source_content_type":"text/x-python","patch_set":12,"id":"771e67e1_65f3d0a8","line":241,"updated":"2024-03-04 13:27:08.000000000","message":"Why not use safe_get() here?  Without a default option specified, this will raise an AttributeError, whereas with safe_get, you\u0027ll take the branch at line 245 and then raise a ValueError.  So this is a kind of big change in behavior for this function.","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"70a669e018a769e369b0427715dab52e4989561c","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            name \u003d opt.name.replace(\u0027hitachi_mirror_\u0027, \u0027hitachi_\u0027)"},{"line_number":239,"context_line":"            try:"},{"line_number":240,"context_line":"                if opt.name \u003d\u003d \u0027hitachi_mirror_pool\u0027:"},{"line_number":241,"context_line":"                    opt_value \u003d getattr(conf, \u0027hitachi_mirror_pool\u0027)"},{"line_number":242,"context_line":"                    if opt_value is not None:"},{"line_number":243,"context_line":"                        name \u003d \u0027hitachi_pools\u0027"},{"line_number":244,"context_line":"                        value \u003d [getattr(conf, opt.name)]"}],"source_content_type":"text/x-python","patch_set":12,"id":"d781c3c5_7dcb3bed","line":241,"in_reply_to":"1965f5bd_f5f1d344","updated":"2024-03-07 19:14:18.000000000","message":"Acknowledged","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"4a6b45a5581f252a7d2ac9a434e9c7818c064fc7","unresolved":true,"context_lines":[{"line_number":238,"context_line":"            name \u003d opt.name.replace(\u0027hitachi_mirror_\u0027, \u0027hitachi_\u0027)"},{"line_number":239,"context_line":"            try:"},{"line_number":240,"context_line":"                if opt.name \u003d\u003d \u0027hitachi_mirror_pool\u0027:"},{"line_number":241,"context_line":"                    opt_value \u003d getattr(conf, \u0027hitachi_mirror_pool\u0027)"},{"line_number":242,"context_line":"                    if opt_value is not None:"},{"line_number":243,"context_line":"                        name \u003d \u0027hitachi_pools\u0027"},{"line_number":244,"context_line":"                        value \u003d [getattr(conf, opt.name)]"}],"source_content_type":"text/x-python","patch_set":12,"id":"1965f5bd_f5f1d344","line":241,"in_reply_to":"771e67e1_65f3d0a8","updated":"2024-03-07 04:50:46.000000000","message":"alomost same as reply in hbsd_common #603. safe_get() can\u0027t get the value `hitachi_mirror_pool`, so, we fixed to use getattr(). It\u0027s related this feature, too.\nWhen `hpexp_mirror_pool` is not set, the driver issues an error. \nWe\u0027ve fixed the behavior, if `hpexp_mirror_pool` is not set, as the merged patch https://review.opendev.org/c/openstack/cinder/+/877672/","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"}],"cinder/volume/drivers/hitachi/hbsd_rest_api.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e8d77a32024c4265f18660780b430a77c05a3b9d","unresolved":true,"context_lines":[{"line_number":998,"context_line":"        return \"%s,%s-LDEV-%d-%d\" % ("},{"line_number":999,"context_line":"            self._remote_copygroup_id(remote_client, copy_group_name,"},{"line_number":1000,"context_line":"                                      is_secondary),"},{"line_number":1001,"context_line":"            self.driver_prefix,"},{"line_number":1002,"context_line":"            pvol_ldev_id,"},{"line_number":1003,"context_line":"            svol_ldev_id)"},{"line_number":1004,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"db562b23_f59d0cdb","line":1001,"updated":"2024-03-04 13:27:08.000000000","message":"This is another unrelated fix; if you have many of these, it may make sense to file a specific bug to fix these missed places where the HSBD driver assumes it\u0027s looking for hitachi backend opts instead of child driver opts.","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"70a669e018a769e369b0427715dab52e4989561c","unresolved":false,"context_lines":[{"line_number":998,"context_line":"        return \"%s,%s-LDEV-%d-%d\" % ("},{"line_number":999,"context_line":"            self._remote_copygroup_id(remote_client, copy_group_name,"},{"line_number":1000,"context_line":"                                      is_secondary),"},{"line_number":1001,"context_line":"            self.driver_prefix,"},{"line_number":1002,"context_line":"            pvol_ldev_id,"},{"line_number":1003,"context_line":"            svol_ldev_id)"},{"line_number":1004,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"c2f68729_6cb68d71","line":1001,"in_reply_to":"9f8b00c5_4bcb02dd","updated":"2024-03-07 19:14:18.000000000","message":"Acknowledged","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"4a6b45a5581f252a7d2ac9a434e9c7818c064fc7","unresolved":true,"context_lines":[{"line_number":998,"context_line":"        return \"%s,%s-LDEV-%d-%d\" % ("},{"line_number":999,"context_line":"            self._remote_copygroup_id(remote_client, copy_group_name,"},{"line_number":1000,"context_line":"                                      is_secondary),"},{"line_number":1001,"context_line":"            self.driver_prefix,"},{"line_number":1002,"context_line":"            pvol_ldev_id,"},{"line_number":1003,"context_line":"            svol_ldev_id)"},{"line_number":1004,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9f8b00c5_4bcb02dd","line":1001,"in_reply_to":"db562b23_f59d0cdb","updated":"2024-03-07 04:50:46.000000000","message":"It\u0027s related this feature, too. This fix is to re-brand prefix for copy-pair name from `HBSD-`, stands for \"**H**itachi **B**lock **S**torage **D**river\", to `HPEXP-`, like the merged patch https://review.opendev.org/c/openstack/cinder/+/879830","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"}],"cinder/volume/drivers/hpe/xp/hpe_xp_fc.py":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"dae328e4650834b2e23a51e28f0b8bb6ce84ebab","unresolved":true,"context_lines":[{"line_number":68,"context_line":"    VERSION \u003d utils.VERSION"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    # ThirdPartySystems wiki page"},{"line_number":71,"context_line":"    CI_WIKI_NAME \u003d utils.CI_WIKI_NAME"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":74,"context_line":"        \"\"\"Initialize instance variables.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"4cb47b9e_da51c5fc","line":71,"updated":"2024-01-18 10:39:19.000000000","message":"Need to add below line:\nSUPPORTS_ACTIVE_ACTIVE \u003d True","commit_id":"af8daa65021e803e5e052c5995b918d217ea8afb"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"fa09d9320382d2a19a46b89813a29715676de312","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    VERSION \u003d utils.VERSION"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    # ThirdPartySystems wiki page"},{"line_number":71,"context_line":"    CI_WIKI_NAME \u003d utils.CI_WIKI_NAME"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":74,"context_line":"        \"\"\"Initialize instance variables.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"ec104164_bb5fd778","line":71,"in_reply_to":"4cb47b9e_da51c5fc","updated":"2024-01-19 03:42:59.000000000","message":"Thank you for your review.\nWe support only active-standby on this patch.\nWe\u0027ll add the line when we support active-active.","commit_id":"af8daa65021e803e5e052c5995b918d217ea8afb"}],"cinder/volume/drivers/hpe/xp/hpe_xp_iscsi.py":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"dae328e4650834b2e23a51e28f0b8bb6ce84ebab","unresolved":true,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    # ThirdPartySystems wiki page"},{"line_number":71,"context_line":"    CI_WIKI_NAME \u003d utils.CI_WIKI_NAME"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":74,"context_line":"        \"\"\"Initialize instance variables.\"\"\""},{"line_number":75,"context_line":"        super(HPEXPISCSIDriver, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":9,"id":"41af38ef_ddd2830e","line":72,"updated":"2024-01-18 10:39:19.000000000","message":"Same comment as in hpe_xp_fc.py","commit_id":"af8daa65021e803e5e052c5995b918d217ea8afb"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"fa09d9320382d2a19a46b89813a29715676de312","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    # ThirdPartySystems wiki page"},{"line_number":71,"context_line":"    CI_WIKI_NAME \u003d utils.CI_WIKI_NAME"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":74,"context_line":"        \"\"\"Initialize instance variables.\"\"\""},{"line_number":75,"context_line":"        super(HPEXPISCSIDriver, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":9,"id":"40007edf_97098a90","line":72,"in_reply_to":"41af38ef_ddd2830e","updated":"2024-01-19 03:42:59.000000000","message":"same reply as in hpe_xp_fc.py","commit_id":"af8daa65021e803e5e052c5995b918d217ea8afb"}],"cinder/volume/drivers/hpe/xp/hpe_xp_rest.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e8d77a32024c4265f18660780b430a77c05a3b9d","unresolved":true,"context_lines":[{"line_number":154,"context_line":"        \u0027hpexp_rest_get_api_response_timeout\u0027,"},{"line_number":155,"context_line":"        default\u003dhbsd_rest_api._GET_API_RESPONSE_TIMEOUT,"},{"line_number":156,"context_line":"        help\u003d\u0027Maximum wait time in seconds for a response against \u0027"},{"line_number":157,"context_line":"             \u0027sync methods, for example GET\u0027),"},{"line_number":158,"context_line":"    cfg.IntOpt("},{"line_number":159,"context_line":"        \u0027hpexp_rest_server_busy_timeout\u0027,"},{"line_number":160,"context_line":"        default\u003dhbsd_rest_api._REST_SERVER_BUSY_TIMEOUT,"}],"source_content_type":"text/x-python","patch_set":12,"id":"ade9a628_638b2c5b","line":157,"updated":"2024-03-04 13:27:08.000000000","message":"Just want to note that these are all good clarifications to the help text.","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"4a6b45a5581f252a7d2ac9a434e9c7818c064fc7","unresolved":true,"context_lines":[{"line_number":154,"context_line":"        \u0027hpexp_rest_get_api_response_timeout\u0027,"},{"line_number":155,"context_line":"        default\u003dhbsd_rest_api._GET_API_RESPONSE_TIMEOUT,"},{"line_number":156,"context_line":"        help\u003d\u0027Maximum wait time in seconds for a response against \u0027"},{"line_number":157,"context_line":"             \u0027sync methods, for example GET\u0027),"},{"line_number":158,"context_line":"    cfg.IntOpt("},{"line_number":159,"context_line":"        \u0027hpexp_rest_server_busy_timeout\u0027,"},{"line_number":160,"context_line":"        default\u003dhbsd_rest_api._REST_SERVER_BUSY_TIMEOUT,"}],"source_content_type":"text/x-python","patch_set":12,"id":"bb6abcbe_f0d09a60","line":157,"in_reply_to":"ade9a628_638b2c5b","updated":"2024-03-07 04:50:46.000000000","message":"These fixing becomes same messages as that of Hitachi driver.","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"70a669e018a769e369b0427715dab52e4989561c","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        \u0027hpexp_rest_get_api_response_timeout\u0027,"},{"line_number":155,"context_line":"        default\u003dhbsd_rest_api._GET_API_RESPONSE_TIMEOUT,"},{"line_number":156,"context_line":"        help\u003d\u0027Maximum wait time in seconds for a response against \u0027"},{"line_number":157,"context_line":"             \u0027sync methods, for example GET\u0027),"},{"line_number":158,"context_line":"    cfg.IntOpt("},{"line_number":159,"context_line":"        \u0027hpexp_rest_server_busy_timeout\u0027,"},{"line_number":160,"context_line":"        default\u003dhbsd_rest_api._REST_SERVER_BUSY_TIMEOUT,"}],"source_content_type":"text/x-python","patch_set":12,"id":"7b9c5a3f_2a43868f","line":157,"in_reply_to":"bb6abcbe_f0d09a60","updated":"2024-03-07 19:14:18.000000000","message":"Acknowledged","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e8d77a32024c4265f18660780b430a77c05a3b9d","unresolved":true,"context_lines":[{"line_number":220,"context_line":"    cfg.IntOpt("},{"line_number":221,"context_line":"        \u0027hpexp_quorum_disk_id\u0027,"},{"line_number":222,"context_line":"        min\u003d0, max\u003d31,"},{"line_number":223,"context_line":"        help\u003d\u0027ID of the Quorum disk used for global-active device\u0027),"},{"line_number":224,"context_line":"    cfg.IntOpt("},{"line_number":225,"context_line":"        \u0027hpexp_replication_copy_speed\u0027,"},{"line_number":226,"context_line":"        min\u003d1, max\u003d15, default\u003d3,"}],"source_content_type":"text/x-python","patch_set":12,"id":"97a45dad_f7681097","line":223,"updated":"2024-03-04 13:27:08.000000000","message":"I realize that it doesn\u0027t make sense to have a default value here, but keep in mind that an IntOpt with no default set will evaluate to None when you go to use it ... so make sure you can handle that case.","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"70a669e018a769e369b0427715dab52e4989561c","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    cfg.IntOpt("},{"line_number":221,"context_line":"        \u0027hpexp_quorum_disk_id\u0027,"},{"line_number":222,"context_line":"        min\u003d0, max\u003d31,"},{"line_number":223,"context_line":"        help\u003d\u0027ID of the Quorum disk used for global-active device\u0027),"},{"line_number":224,"context_line":"    cfg.IntOpt("},{"line_number":225,"context_line":"        \u0027hpexp_replication_copy_speed\u0027,"},{"line_number":226,"context_line":"        min\u003d1, max\u003d15, default\u003d3,"}],"source_content_type":"text/x-python","patch_set":12,"id":"9b6e2a6f_c36e3627","line":223,"in_reply_to":"7af6c0ee_dcb4b56a","updated":"2024-03-07 19:14:18.000000000","message":"Acknowledged","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"4a6b45a5581f252a7d2ac9a434e9c7818c064fc7","unresolved":true,"context_lines":[{"line_number":220,"context_line":"    cfg.IntOpt("},{"line_number":221,"context_line":"        \u0027hpexp_quorum_disk_id\u0027,"},{"line_number":222,"context_line":"        min\u003d0, max\u003d31,"},{"line_number":223,"context_line":"        help\u003d\u0027ID of the Quorum disk used for global-active device\u0027),"},{"line_number":224,"context_line":"    cfg.IntOpt("},{"line_number":225,"context_line":"        \u0027hpexp_replication_copy_speed\u0027,"},{"line_number":226,"context_line":"        min\u003d1, max\u003d15, default\u003d3,"}],"source_content_type":"text/x-python","patch_set":12,"id":"7af6c0ee_dcb4b56a","line":223,"in_reply_to":"97a45dad_f7681097","updated":"2024-03-07 04:50:46.000000000","message":"The value of this option depends on each customer site. So, we shouldn\u0027t define the default value to avoid a risk which unexpected disk is used.\nWe know ``None`` is set, and we\u0027ve also confirmed the response of REST_API says the failure \"undefined required value\" when `hpexp_quorum_disk_id` is not defined.","commit_id":"847e8212c835c35ac2fd69988a8e25acd8f0e8e4"}],"releasenotes/notes/hpe-xp-support-gad-and-dedup-665be6bfa2f511fe.yaml":[{"author":{"_account_id":22879,"name":"Prabhuraj K","email":"k.prabhuraj@in.ibm.com","username":"pk1218"},"change_message_id":"1130c8125e4dda8e26a752fbd29ce3566860d88f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    HPE XP driver: supported following features: "},{"line_number":5,"context_line":"    * High Availability"},{"line_number":6,"context_line":"    * data deduplication"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"872d7886_27476757","line":4,"range":{"start_line":4,"start_character":43,"end_line":4,"end_character":49},"updated":"2023-08-30 04:40:51.000000000","message":"Extra space need to be removed","commit_id":"a03301a0500111215cf12dc6173978036f58a404"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"e71ec817ada1a6bd938cb0d2580ac3ae751a6c40","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    HPE XP driver: supported following features: "},{"line_number":5,"context_line":"    * High Availability"},{"line_number":6,"context_line":"    * data deduplication"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d004409c_2bafc9a4","line":4,"range":{"start_line":4,"start_character":43,"end_line":4,"end_character":49},"in_reply_to":"872d7886_27476757","updated":"2023-08-30 04:49:25.000000000","message":"Thanks for reviewing.\nI\u0027ve fixed it and published as patchset2.","commit_id":"a03301a0500111215cf12dc6173978036f58a404"}]}