)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"078e04663fb05032e3e08a80ee80aab083f59f9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"07ad1008_ffa13880","updated":"2023-08-29 13:32:10.000000000","message":"See also, https://review.opendev.org/c/openstack/cinder/+/890460","commit_id":"6cded0528833b1d29b8a793cfc0400a8a7adedf7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7bfa39f4de69e753875ec47f2c1bad0c4aa71203","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f5b65769_bba857db","in_reply_to":"07ad1008_ffa13880","updated":"2023-08-29 13:58:41.000000000","message":"interesting to know regarding gorkas comment about hte vg infor possibely being state.\n\nthis version should have the unit test fixed and im also adding --readonly to the lvdisplay commands where i think its safe.\n\nthat said i want to see what devstack says since this is mostly sepcultive based on my reading of the manpage rahter then direct experince with these commands.\n\ni.e. there may be dragons i have not seen.","commit_id":"6cded0528833b1d29b8a793cfc0400a8a7adedf7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9cd558323da060a75f55ac7e0c00be3f43d3f4fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a8f6deef_97a1e22d","updated":"2023-08-30 13:12:40.000000000","message":"recheck https://github.com/tox-dev/pyproject-api/issues/101","commit_id":"879226ee2ad82b00d879f619e6120ea2ea24ee85"}],"cinder/brick/local_dev/lvm.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8a0f4a035e09058f2b182a85d49e56cb9ec583e1","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    cmd \u003d list(command_prefix) + ["},{"line_number":84,"context_line":"        \u0027lvs\u0027, \u0027--noheadings\u0027, \u0027--unit\u003dg\u0027,"},{"line_number":85,"context_line":"        \u0027-o\u0027, \u0027size,data_percent\u0027, \u0027--separator\u0027,"},{"line_number":86,"context_line":"        \u0027:\u0027, \u0027--nosuffix\u0027, \u0027--readonly\u0027]"},{"line_number":87,"context_line":"    # NOTE(gfidente): data_percent only applies to some types of LV so we"},{"line_number":88,"context_line":"    # make sure to append the actual thin pool name"},{"line_number":89,"context_line":"    cmd.append(\"/dev/%s/%s\" % (vg_name, thin_pool_name))"}],"source_content_type":"text/x-python","patch_set":1,"id":"cb175c61_8d85d8fb","line":86,"range":{"start_line":86,"start_character":30,"end_line":86,"end_character":38},"updated":"2023-08-29 17:59:52.000000000","message":"ok so it looks like this canot be readonly \n\nAug 29 13:25:13.072568 np0035088964 cinder-volume[85116]: DEBUG oslo.privsep.daemon [-] privsep: reply[37352c6f-a776-4eb2-afa3-a92a8e60ad89]: (4, (\u0027  28.50:\\n\u0027, \u0027\u0027)) {{(pid\u003d85157) _call_back /opt/stack/data/venv/lib/python3.10/site-packages/oslo_privsep/daemon.py:499}}\n\nAug 29 13:25:13.074060 np0035088964 cinder-volume[85116]: ERROR cinder.volume.manager [None req-04d6e8f6-a36a-4378-9f24-15b9f51dd3b5 None None] Failed to initialize driver.: ValueError: could not convert string to float: \u0027\u0027\n\nAug 29 13:25:13.074060 np0035088964 cinder-volume[85116]: ERROR cinder.volume.manager Traceback (most recent call last):\n\nAug 29 13:25:13.074060 np0035088964 cinder-volume[85116]: ERROR cinder.volume.manager   File \"/opt/stack/cinder/cinder/volume/manager.py\", line 525, in _init_host\n\nAug 29 13:25:13.074060 np0035088964 cinder-volume[85116]: ERROR cinder.volume.manager     self.driver.check_for_setup_error()\n\nAug 29 13:25:13.074060 np0035088964 cinder-volume[85116]: ERROR cinder.volume.manager   File \"/opt/stack/cinder/cinder/volume/drivers/lvm.py\", line 352, in check_for_setup_error\n\nAug 29 13:25:13.074060 np0035088964 cinder-volume[85116]: ERROR cinder.volume.manager     self.vg.update_volume_group_info()\n\nAug 29 13:25:13.074060 np0035088964 cinder-volume[85116]: ERROR cinder.volume.manager   File \"/opt/stack/cinder/cinder/brick/local_dev/lvm.py\", line 539, in update_volume_group_info\n\nAug 29 13:25:13.074060 np0035088964 cinder-volume[85116]: ERROR cinder.volume.manager     tpfs \u003d self._get_thin_pool_free_space(self.vg_name,\n\nAug 29 13:25:13.074060 np0035088964 cinder-volume[85116]: ERROR cinder.volume.manager   File \"/opt/stack/cinder/cinder/brick/local_dev/lvm.py\", line 260, in _get_thin_pool_free_space\n\nAug 29 13:25:13.074060 np0035088964 cinder-volume[85116]: ERROR cinder.volume.manager     data_percent \u003d float(data[1])\n\nAug 29 13:25:13.074060 np0035088964 cinder-volume[85116]: ERROR cinder.volume.manager ValueError: could not convert string to float: \u0027\u0027\n\nit appears we need the actual free space not the logical free space.","commit_id":"6cded0528833b1d29b8a793cfc0400a8a7adedf7"}]}