)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"253ade78168bc1ac4b16e9b997a61fd8171946fc","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Space allocation is an important NetApp driver specific feature. This needs to be set when the cinder volume is created. This is not related to thin/thick provisioning feature of cinder volumes.It is independent of that. It enables ONTAP to reclaim space automatically when host deletes data.This helps ONTAP and host to see the actual space correctly when the host deletes data."},{"line_number":10,"context_line":"It also helps to keep a LUN (cinder volume) online when the LUN (cinder volume) in ontap runs out of space and containing volume (in ONTAP) cannot automatically grow more space."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"User can configure it by using Volume extraspec"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"netapp:space_allocation: \u0027True\u0027  # to enable space allocation"},{"line_number":15,"context_line":"netapp:space_allocation: \u0027False\u0027 # to disable space allocation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"55430e95_80b6de3d","line":12,"range":{"start_line":12,"start_character":31,"end_line":12,"end_character":47},"updated":"2023-09-01 02:11:49.000000000","message":"nit: volume type extra specs","commit_id":"bca22013caece31926349d78d3e1b35152d44d90"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"e0c23ec1771d32a61f1a46a7d7073f8f6439870f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Space allocation is an important NetApp driver specific feature. This needs to be set when the cinder volume is created. This is not related to thin/thick provisioning feature of cinder volumes.It is independent of that. It enables ONTAP to reclaim space automatically when host deletes data.This helps ONTAP and host to see the actual space correctly when the host deletes data."},{"line_number":10,"context_line":"It also helps to keep a LUN (cinder volume) online when the LUN (cinder volume) in ontap runs out of space and containing volume (in ONTAP) cannot automatically grow more space."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"User can configure it by using Volume extraspec"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"netapp:space_allocation: \u0027True\u0027  # to enable space allocation"},{"line_number":15,"context_line":"netapp:space_allocation: \u0027False\u0027 # to disable space allocation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7d5b5528_ac59262b","line":12,"range":{"start_line":12,"start_character":31,"end_line":12,"end_character":47},"in_reply_to":"55430e95_80b6de3d","updated":"2023-09-01 13:57:27.000000000","message":"Thank you! Rajat, missed \u0027type\u0027 text. updated now.","commit_id":"bca22013caece31926349d78d3e1b35152d44d90"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"579804a3a368a038901de28fbf432471f890d61c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Jayaanand Borra \u003cjayaanand.borra@netapp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-09-04 19:47:28 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[NetApp] LUN space allocation support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Space allocation is an important NetApp driver specific feature. This needs to be set when the cinder volume is created. This is not related to thin/thick provisioning feature of cinder volumes.It is independent of that. It enables ONTAP to reclaim space automatically when host deletes data.This helps ONTAP and host to see the actual space correctly when the host deletes data."},{"line_number":10,"context_line":"It also helps to keep a LUN (cinder volume) online when the LUN (cinder volume) in ontap runs out of space and containing volume (in ONTAP) cannot automatically grow more space."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"10705c41_ddf9d177","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":7},"updated":"2023-09-06 12:53:41.000000000","message":"is all NetApp drivers that support this new feature ? If not, please, inform specifically which drivers are changed with this new feature.","commit_id":"bd25788019c3fd1b8c86d521dfaa11c2513d5f7b"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"c77918230567219ad7dbce46dba1d20daef6157a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jayaanand Borra \u003cjayaanand.borra@netapp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-09-04 19:47:28 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[NetApp] LUN space allocation support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Space allocation is an important NetApp driver specific feature. This needs to be set when the cinder volume is created. This is not related to thin/thick provisioning feature of cinder volumes.It is independent of that. It enables ONTAP to reclaim space automatically when host deletes data.This helps ONTAP and host to see the actual space correctly when the host deletes data."},{"line_number":10,"context_line":"It also helps to keep a LUN (cinder volume) online when the LUN (cinder volume) in ontap runs out of space and containing volume (in ONTAP) cannot automatically grow more space."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"2ffe25c5_a1adc8f3","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":7},"in_reply_to":"10705c41_ddf9d177","updated":"2023-09-06 16:18:21.000000000","message":"This feature is specific to NetApp cinder volume. Information is present in description. Let me know if i need to add more details.","commit_id":"bd25788019c3fd1b8c86d521dfaa11c2513d5f7b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e94ad3518688ea7735265a9cfc3c7cac6d4a7c55","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[NetApp] LUN space allocation support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Space allocation is an important NetApp driver specific feature. This needs to be set when the cinder volume is created. This is not related to thin/thick provisioning feature of cinder volumes.It is independent of that. It enables ONTAP to reclaim space automatically when host deletes data.This helps ONTAP and host to see the actual space correctly when the host deletes data."},{"line_number":10,"context_line":"It also helps to keep a LUN (cinder volume) online when the LUN (cinder volume) in ontap runs out of space and containing volume (in ONTAP) cannot automatically grow more space."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"User can configure it by using volume type extra spec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"7840540a_e85f963b","line":9,"updated":"2024-03-05 23:58:17.000000000","message":"Please wrap this at 72 chars.","commit_id":"bfeaad4a41d36aff7f5320e2c56709e57a77e7a3"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"ccb1d292a0e48e626c2a3552dd0888563f6e25ca","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[NetApp] LUN space allocation support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Space allocation is an important NetApp driver specific feature. This needs to be set when the cinder volume is created. This is not related to thin/thick provisioning feature of cinder volumes.It is independent of that. It enables ONTAP to reclaim space automatically when host deletes data.This helps ONTAP and host to see the actual space correctly when the host deletes data."},{"line_number":10,"context_line":"It also helps to keep a LUN (cinder volume) online when the LUN (cinder volume) in ontap runs out of space and containing volume (in ONTAP) cannot automatically grow more space."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"User can configure it by using volume type extra spec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"b843ab4b_a6ab5af6","line":9,"in_reply_to":"7840540a_e85f963b","updated":"2024-03-06 08:25:53.000000000","message":"Thank you! update text to wrap withing 72 chars.","commit_id":"bfeaad4a41d36aff7f5320e2c56709e57a77e7a3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e94ad3518688ea7735265a9cfc3c7cac6d4a7c55","unresolved":true,"context_lines":[{"line_number":12,"context_line":"User can configure it by using volume type extra spec"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"netapp:space_allocation: \"\u003cis\u003e True\"  # to enable space allocation"},{"line_number":15,"context_line":"netapp:space_allocation: \"\u003cis\u003e False\" # to disable space allocation"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Blueprint: netapp-space-allocation-support"},{"line_number":18,"context_line":"Change-Id: Ib7072f3093067ecd8ad84e396aaecec8f15c49ba"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"e6b2d095_7afa412c","line":15,"updated":"2024-03-05 23:58:17.000000000","message":"This talk of enable/disable is a bit confusing.  My impression from what you say above is that the default is no space allocation, and it must be explicitly set at the time of volume creation in order to be enabled for the volume.  If that\u0027s correct, you should say that disabled is the default, that if the extra_spec is missing space allocation is disabled for that volume type, and that an operator can create the \u0027\u003cis\u003e False\u0027 extra spec to make it clear that space allocation is not in effect for volumes of that type.","commit_id":"bfeaad4a41d36aff7f5320e2c56709e57a77e7a3"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"ccb1d292a0e48e626c2a3552dd0888563f6e25ca","unresolved":false,"context_lines":[{"line_number":12,"context_line":"User can configure it by using volume type extra spec"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"netapp:space_allocation: \"\u003cis\u003e True\"  # to enable space allocation"},{"line_number":15,"context_line":"netapp:space_allocation: \"\u003cis\u003e False\" # to disable space allocation"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Blueprint: netapp-space-allocation-support"},{"line_number":18,"context_line":"Change-Id: Ib7072f3093067ecd8ad84e396aaecec8f15c49ba"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"d6f6493c_d9fd46f3","line":15,"in_reply_to":"e6b2d095_7afa412c","updated":"2024-03-06 08:25:53.000000000","message":"Current behavior without this change is disable by default. I updated message to reflect this information. Also, updated logic to always pass this value to SpaceAllocation to avoid confusion. Please refer below document for more information.\nhttps://docs.netapp.com/us-en/ontap/san-admin/enable-space-allocation-scsi-thin-provisioned-luns-task.html\n\"\nAbout this task\n\nThe space-allocation option is set to disabled by default, and you must take the LUN offline to enable space allocation. After you enable space allocation, you must perform discovery on the host before the host will recognize that space allocation has been enabled.\n\"","commit_id":"bfeaad4a41d36aff7f5320e2c56709e57a77e7a3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"1bbe787172e4a14f68a77af9cccea52fa99891db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2d2688d4_2c5b4e6c","updated":"2023-08-29 19:05:31.000000000","message":"Please review patch related to NetApp space allocation. Earlier one abandoned https://review.opendev.org/c/openstack/cinder/+/890818 as I mixed space_allocation with thin/thick feature of Cinder, which is not correct.","commit_id":"3b318186b19fc2caab452d67dbc727fe5b9ac159"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"1966ac331f291b1de96ef0ee2f839e74d7f974b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ad58171b_c85e1523","updated":"2023-08-29 19:02:01.000000000","message":"geguileo@redhat.com,felipefuty01@gmail.com,caiquemellosbo@gmail.com,thiago.andrade@fit-tecnologia.org.br,shanjiayi@yovole.com,manicsaran@gmail.com","commit_id":"3b318186b19fc2caab452d67dbc727fe5b9ac159"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"96dc89d39051c4411564f5034b12d79267d28e4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"58697ee9_2d15f68e","updated":"2023-08-30 07:29:01.000000000","message":"recheck: unrelated failure with job","commit_id":"3b318186b19fc2caab452d67dbc727fe5b9ac159"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"1ebe0790fb21b5d184bc4a5c5de1956ed21d87ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e2f1c088_e543e04d","updated":"2023-08-30 14:40:23.000000000","message":"recheck: unrelated failure with job","commit_id":"3b318186b19fc2caab452d67dbc727fe5b9ac159"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"f5775961e1c77ca92109b5bf1f9218e0773bf295","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"aa642a26_943d501f","updated":"2023-08-31 10:26:23.000000000","message":"run-NetApp CI","commit_id":"3cdc44c3e775c2e992b144dbecdea7eff4f5ac4b"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"6814c146ccc246bb24e5a93abc99156e43e8be13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cd5701ec_93d47ce3","updated":"2023-08-31 05:17:01.000000000","message":"run-NetApp CI","commit_id":"3cdc44c3e775c2e992b144dbecdea7eff4f5ac4b"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"6c9e109c1a131f56e1c5756c3a48d485fba60c1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f1bbcc53_d3c15763","updated":"2023-08-30 19:08:11.000000000","message":"run-NetApp CI","commit_id":"3cdc44c3e775c2e992b144dbecdea7eff4f5ac4b"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"02aff0242cd25b777b0321370890e6bc6e5ae066","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"42afa2b6_94e2de9a","updated":"2023-08-31 18:35:24.000000000","message":"Thanks for the patch, Jaya. Can you check if last NetApp-CI failure is related to your changes, since none of iSCSI-rest job executions passed?","commit_id":"bca22013caece31926349d78d3e1b35152d44d90"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"253ade78168bc1ac4b16e9b997a61fd8171946fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"375dea5f_8ff06fe9","updated":"2023-09-01 02:11:49.000000000","message":"few comments inline","commit_id":"bca22013caece31926349d78d3e1b35152d44d90"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"c552f7fea4ed777e1dc055d4e549922872e60344","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1e39088c_117c4cf9","updated":"2023-08-31 19:47:04.000000000","message":"run-NetApp CI","commit_id":"bca22013caece31926349d78d3e1b35152d44d90"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"2a43df2a408c75ea87808bab074f5b01e081dae5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d24cf110_43eda14a","in_reply_to":"42afa2b6_94e2de9a","updated":"2023-08-31 19:46:22.000000000","message":"Thank you! Thiago, My changes are restricted to ONTAP driver. FCP and ISCSI driver tempest test are good. \nhttps://netappopenstacklogserver.s3.us-west-1.amazonaws.com/index.html#logs/06/893106/5/upstream-check/cinder-tempest-plugin-ontap-fcp/370a682/\nhttps://netappopenstacklogserver.s3.us-west-1.amazonaws.com/index.html#logs/06/893106/5/upstream-check/cinder-tempest-plugin-ontap-iscsi/b82781a/\n\nAlso, i am looking at REST logs. Nothing pointing at LUN creation. Resource errors are from snapshort and other get calls. Nothing pointing at my code.","commit_id":"bca22013caece31926349d78d3e1b35152d44d90"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"56ec8fa5c113cf1876ff9dc459157f726e301e93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"099184b0_d621e275","in_reply_to":"d24cf110_43eda14a","updated":"2023-09-04 15:41:43.000000000","message":"Nice Jaya. LGTM.","commit_id":"bca22013caece31926349d78d3e1b35152d44d90"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"e0c23ec1771d32a61f1a46a7d7073f8f6439870f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b087d8b3_7544fb26","updated":"2023-09-01 13:57:27.000000000","message":"Thank you! Rajat.","commit_id":"40a5d8b14b6a56af9960de972fbf6e720b1c4e7d"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"7138f96ba37c7618b9bbf859cb5ca4d3689d9333","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"83f0477a_a34dd5cb","updated":"2023-09-04 06:05:20.000000000","message":"recheck: unrelated failure with job","commit_id":"f2aea122068df927b61689f6c146cae2eba33502"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"579804a3a368a038901de28fbf432471f890d61c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6ec5365f_18af09ed","updated":"2023-09-06 12:53:41.000000000","message":"Thanks Jayaa for this new NetApp feature. Please, see my comments.","commit_id":"bd25788019c3fd1b8c86d521dfaa11c2513d5f7b"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"9c61eab3a5a2e4384067b1716228f7fe64ce8177","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"123b0314_e08dacfe","updated":"2023-09-05 23:26:49.000000000","message":"run-NetApp CI","commit_id":"bd25788019c3fd1b8c86d521dfaa11c2513d5f7b"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"9cc520ef4e6858933f5c2cbfd75e0c6d789942a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2e5ba112_6f25c7fc","updated":"2023-09-06 02:30:53.000000000","message":"run-NetApp CI","commit_id":"bd25788019c3fd1b8c86d521dfaa11c2513d5f7b"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"54664dbd4b7da853dd6df85d39be9e40b1447249","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d2139bac_f8e2207a","updated":"2023-09-05 05:21:06.000000000","message":"run-NetApp CI","commit_id":"bd25788019c3fd1b8c86d521dfaa11c2513d5f7b"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"c77918230567219ad7dbce46dba1d20daef6157a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d0e33108_fcd0f182","updated":"2023-09-06 16:18:21.000000000","message":"Thank you! Felipe. Addressed your review comments. Please review again.","commit_id":"716c9213d76a916e1b85ab71f493f25d2c61ba5f"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"5d122915887395244ff81c2cb1bacd9753f01b2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"21214574_a262e7c7","updated":"2023-09-11 10:01:25.000000000","message":"recheck cinder-plugin-ceph-tempest failure","commit_id":"716c9213d76a916e1b85ab71f493f25d2c61ba5f"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"92615d74e503dbd85c1acd8817725e3275b688f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"6f6cd2eb_f94d42ae","updated":"2023-09-12 14:01:15.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbica","commit_id":"716c9213d76a916e1b85ab71f493f25d2c61ba5f"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"e823ec514651fe28619f0ef1cf0c25fe1e2397bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"68cda4ff_42826b1a","updated":"2023-09-07 03:15:37.000000000","message":"recheck: unrelated failure with job","commit_id":"716c9213d76a916e1b85ab71f493f25d2c61ba5f"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"4c85c2bee06758f82610028eec354268fc8ddb39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"8acc0dcf_23a30980","updated":"2023-12-16 14:33:07.000000000","message":"Hi All, \nI added NetApp driver implementation to send discard value to True/False based on space allocation LUN value during connection initiation. This information is reflected in Nova logs. Please find below details.\n\n1)When NetApp space allocation is enabled. Nova logs are reflecting Discard to True.\n\nDEBUG os_brick.initiator.connectors.iscsi [^[[01;36mNone req-14e906c5-e88f-4f47-97bc-d8f58126eeec ^[[00;36madmin admin] ^[[01;35m\u003d\u003d\u003e connect_volume: call \"{\u0027self\u0027: \u003cos_brick.initiator.connectors.iscsi.ISCSIConnector object at 0x7fb239a82520\u003e, \u0027connection_properties\u0027: {\u0027target_discovered\u0027: False, \u0027target_portal\u0027: \u002710.192.96.35:3260\u0027, \u0027target_iqn\u0027: \u0027iqn.1992-08.com.netapp:sn.a33ef18b315e11eeba88d039ea50375c:vs.8\u0027, \u0027target_lun\u0027: 1, \u0027volume_id\u0027: \u002727b834b1-227c-45d0-a1d7-0067ca00c165\u0027, \u0027target_portals\u0027: [\u002710.192.96.35:3260\u0027, \u002710.192.96.36:3260\u0027], \u0027target_iqns\u0027: [\u0027iqn.1992-08.com.netapp:sn.a33ef18b315e11eeba88d039ea50375c:vs.8\u0027, \u0027iqn.1992-08.com.netapp:sn.a33ef18b315e11eeba88d039ea50375c:vs.8\u0027], \u0027target_luns\u0027: [1, 1], \u0027qos_specs\u0027: None, \u0027access_mode\u0027: \u0027rw\u0027, \u0027encrypted\u0027: False, \u0027cacheable\u0027: False, \u0027discard\u0027: True}}\"\n\n2) When NetApp space allocation is enabled. Nova logs are reflecting Discard to False.\n\nDEBUG os_brick.initiator.connectors.iscsi [^[[01;36mNone req-ba04a430-bf81-47d3-b004-3335c7e00659 ^[[00;36madmin admin] ^[[01;35m\u003d\u003d\u003e connect_volume: call \"{\u0027self\u0027: \u003cos_brick.initiator.connectors.iscsi.ISCSIConnector object at 0x7fb239a82520\u003e, \u0027connection_properties\u0027: {\u0027target_discovered\u0027: False, \u0027target_portal\u0027: \u002710.192.96.35:3260\u0027, \u0027target_iqn\u0027: \u0027iqn.1992-08.com.netapp:sn.a33ef18b315e11eeba88d039ea50375c:vs.8\u0027, \u0027target_lun\u0027: 1, \u0027volume_id\u0027: \u002727b834b1-227c-45d0-a1d7-0067ca00c165\u0027, \u0027target_portals\u0027: [\u002710.192.96.35:3260\u0027, \u002710.192.96.36:3260\u0027], \u0027target_iqns\u0027: [\u0027iqn.1992-08.com.netapp:sn.a33ef18b315e11eeba88d039ea50375c:vs.8\u0027, \u0027iqn.1992-08.com.netapp:sn.a33ef18b315e11eeba88d039ea50375c:vs.8\u0027], \u0027target_luns\u0027: [1, 1], \u0027qos_specs\u0027: None, \u0027access_mode\u0027: \u0027rw\u0027, \u0027encrypted\u0027: False, \u0027cacheable\u0027: False, \u0027discard\u0027: False}}\n\nThank you!\nJayaanand.","commit_id":"e063f8f9abf98a86b9aca90549c061c68449e4ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"711e91895e4b7748e00f1dedc13168c2477c2308","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"dec11d2e_b10b1f91","updated":"2023-12-18 06:39:52.000000000","message":"recheck: unrelated failure with job","commit_id":"e063f8f9abf98a86b9aca90549c061c68449e4ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"b8b4d096ad1fa4392349baaf8dd494ca042bf3a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"2aedcff6_1b4768f6","updated":"2023-12-19 05:57:38.000000000","message":"run-NetApp CI","commit_id":"e063f8f9abf98a86b9aca90549c061c68449e4ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"b55f853b81de0e6c585b4d7c44484f38218c2c5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"55cec39a_11ef426c","updated":"2023-12-19 04:15:31.000000000","message":"run-NetApp CI","commit_id":"e063f8f9abf98a86b9aca90549c061c68449e4ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"73b1277e3d67cd67219121c14234f75f8d8be6d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ae070749_6d5e7878","updated":"2023-12-18 16:42:26.000000000","message":"run-NetApp CI","commit_id":"e063f8f9abf98a86b9aca90549c061c68449e4ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"20fdfbdc2737d15b25b6e47070a67adbd5bb102d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"c465834a_a13d2506","updated":"2023-12-19 17:20:35.000000000","message":"run-NetApp CI","commit_id":"e063f8f9abf98a86b9aca90549c061c68449e4ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"2a0c52cfce48cbc133dfca076b6f1ec8b85a8c2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"d38b6b9e_62167019","updated":"2023-12-19 14:01:41.000000000","message":"run-NetApp CI","commit_id":"e063f8f9abf98a86b9aca90549c061c68449e4ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"54b67ee156c1f65d44a36f701c2e959501553b40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"dc17fff5_d5a11fab","updated":"2023-12-19 10:21:52.000000000","message":"run-NetApp CI","commit_id":"e063f8f9abf98a86b9aca90549c061c68449e4ea"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b45f4b525ca8723288f0bc9735a8384d47c206e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"8b598d09_9a5d10d1","updated":"2024-02-15 20:00:36.000000000","message":"we need some documentation around this new extra spec and the possible values, as i can see there are 2 values possible, \u0027true\u0027 and \u0027false\u0027\n\nAlso I would like to get some clarity that if we don\u0027t pass the extra spec property, will the LUN even contain the SpaceAllocated metadata and if it doesn\u0027t generate a keyerror when trying to fetch that key","commit_id":"e063f8f9abf98a86b9aca90549c061c68449e4ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"c2c25e834675404bcf95788f84600d26655255a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"84da3fd4_93ca21d0","in_reply_to":"8b598d09_9a5d10d1","updated":"2024-02-23 15:05:23.000000000","message":"Thank you! Rajat for the review. We have detailed documentation in our douwnstream Gerrit. Planning to publish once this change is merged.\n\nCurrent and behavior before this patch is, ONTAP always sets space-allocation false, Customer wants a way to enable and also disable if required. Also, all ONTAP  version LUNs has this attribute present and set to false by default. SpaceAllocated metadata is always present from ONTAP side for a given LUN. Please refer below doc link for details.\nhttps://docs.netapp.com/us-en/ontap/san-admin/enable-space-allocation-scsi-thin-provisioned-luns-task.html","commit_id":"e063f8f9abf98a86b9aca90549c061c68449e4ea"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"686c4bd5f38d30aae26c64eb66ee4bf21ca641ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"f2901c9d_ed09aa19","updated":"2024-02-28 22:20:42.000000000","message":"Also, I should add that if there\u0027s not time to address my concerns before tomorrow\u0027s deadline, I would support a freeze exception for this patch.","commit_id":"afc3be5daf765047174acc58717e3f3d9d9e07f8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"20f67971435c340ece9130c18b1c655a5f94802e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"ae60b5b7_8c51dd9b","updated":"2024-02-26 17:43:58.000000000","message":"Few nits inline but overall LGTM\n\nonly +1 because Netapp CI is failing on fcp and iscsi-rest","commit_id":"afc3be5daf765047174acc58717e3f3d9d9e07f8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"899728c3cc6f1633d0ee4eea6b1025b2d3eca4e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"8f57f03d_a75006ff","updated":"2024-02-28 22:17:21.000000000","message":"Forgot to vote.","commit_id":"afc3be5daf765047174acc58717e3f3d9d9e07f8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"48287a2da71a09d3403fd4254e26f1f0598360ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"22a4edda_f186496b","updated":"2024-02-28 10:27:12.000000000","message":"Given the recent comment, NetApp team has verified that this works as expected, though it would be good to see CI green. upgrading my vote.","commit_id":"afc3be5daf765047174acc58717e3f3d9d9e07f8"},{"author":{"_account_id":36178,"name":"Saravanan Manickam","display_name":"msaravan","email":"manicsaran@gmail.com","username":"msaravan"},"change_message_id":"481a7eb17c9b44c70041b5fe40a1ff0e49941055","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"c1472e97_1a070ee4","updated":"2024-02-28 08:40:52.000000000","message":"Look good. Thank you for capturing the discard related logs good. \n\n@Rajat - We manually verified and we are good on FCP and Rest API part. \n\nFCP and REST API suites used to pass earlier. At present, we face network problem in FCP setup, and we are working on fixing them. For REST API, there used to be only a single failure and we logged a bug to debug and fix it in the environment. Will use the tempest bug 2048965 to fix Rest API suite completely.","commit_id":"afc3be5daf765047174acc58717e3f3d9d9e07f8"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"c2c25e834675404bcf95788f84600d26655255a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"3051eac5_dfd69b56","updated":"2024-02-23 15:05:23.000000000","message":"Thank you! Rajath for the detailed review. Please review again.","commit_id":"afc3be5daf765047174acc58717e3f3d9d9e07f8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4a253da123a87423882acfb029b5185459c2583f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"ad661bfa_3b94ff87","updated":"2024-02-28 22:17:05.000000000","message":"This mostly looks OK as far as I can tell, but I think there are some problems with handling the extra_spec value ... see comments inline.\n\nAlso, I take it that the docs will be updated in a follow-up patch?","commit_id":"afc3be5daf765047174acc58717e3f3d9d9e07f8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"635e82eed4843e92c3ddb3bf44cd95413a5c67d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"f7d9bdd1_169aed7b","updated":"2024-02-27 08:10:56.000000000","message":"run-NetApp CI","commit_id":"afc3be5daf765047174acc58717e3f3d9d9e07f8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0a01e5b7a47c0f3bb54612fa464f4358ab67a4f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"a4ea672a_07ba2a29","updated":"2024-03-03 21:42:07.000000000","message":"Looks like the pep8 and unit tests failures are for real.","commit_id":"91eaac04b94a033e5e978106ac0dac4e39de8932"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"b7df8a8e1b5f729d45c6d31673d5b0671e7edfa3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"bd7ff476_2c627090","updated":"2024-03-02 19:13:31.000000000","message":"Thank you! Brain for detailed review. Addressed review comments. Please review again.","commit_id":"91eaac04b94a033e5e978106ac0dac4e39de8932"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"584bf57abe8d8b106243e613cf53af07f55b6837","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"9971f48b_029b293f","updated":"2024-03-04 07:41:35.000000000","message":"the UT failure seems legit","commit_id":"9d9322eee360c1d047b26a8e49dbd16a753f2d88"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"042f60263709d023654bb9e755ac4892dc3a7645","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"2f23569f_b971f244","updated":"2024-03-05 07:13:53.000000000","message":"Thank you! Rajat, I am facing issue in locally running TOX. This PR is from old relase and have python3.8 dependency. Not able to resolve all requirements. Now rebased my changes and able to run Tox locally with Python 3.10. Don\u0027t want to repeat UTs and Pep8 errors. Sorry for the inconvenience.","commit_id":"f5ad747304747c00bb88332b65e0ebcb0aea20ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"e179799c8b7827e449bff4fe412578071e1a00a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"d2c16cba_c0c71509","updated":"2024-03-04 16:51:53.000000000","message":"Thank you! Rajath, Updated failing UTs. can you review again.","commit_id":"f5ad747304747c00bb88332b65e0ebcb0aea20ed"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cf86711d015fa9099d2a7d23bcb61de4a2b38454","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"452297a8_4902c6f1","updated":"2024-03-04 20:05:35.000000000","message":"please fix the pep8 issues","commit_id":"f5ad747304747c00bb88332b65e0ebcb0aea20ed"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e8db56e75bc0fb46c52e09e2c015ad7eb402092f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"bf2746e5_52bcd612","updated":"2024-03-05 23:03:54.000000000","message":"A few questions inline.  The -1 is so that you notice, not because anything is necessarily wrong.","commit_id":"bfeaad4a41d36aff7f5320e2c56709e57a77e7a3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"171a8f31af987a956de091f7508895231c63e968","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"23a4c962_00a0139e","updated":"2024-03-05 18:22:21.000000000","message":"recheck - the ceph jobs have been fixed by https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/910966","commit_id":"bfeaad4a41d36aff7f5320e2c56709e57a77e7a3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b83b0fa76e78ca62e0266426427d0389c7d192e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"0822b64f_e97c7b88","updated":"2024-03-06 13:49:03.000000000","message":"NetApp CI is passing, as Netapp team already mentioned the cinder-tempest-plugin-ontap-fcp CI has some issues and they have kept it N-V but have verified the patch works.","commit_id":"48d922cf625c079c8338bf90a3d17f849df0c6b5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"77248794cbb45776e19adea2f8e638d16d3d8fbe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"0ca8c4ac_9f466426","updated":"2024-03-06 16:19:01.000000000","message":"Revisions LGTM.  Thanks for being so responsive to comments!","commit_id":"48d922cf625c079c8338bf90a3d17f849df0c6b5"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"ccb1d292a0e48e626c2a3552dd0888563f6e25ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"38a0c2ba_02e6c760","updated":"2024-03-06 08:25:53.000000000","message":"Thank you! Brain, updated code to address your comment. Please review again.","commit_id":"48d922cf625c079c8338bf90a3d17f849df0c6b5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d6c49fb6d4c17ec337f380b1c707f448f1c8a735","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"d52adb6d_959122e7","updated":"2024-03-06 10:55:43.000000000","message":"my comments are addressed, gate is passing, waiting for netapp CI to respond.","commit_id":"48d922cf625c079c8338bf90a3d17f849df0c6b5"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/client/fakes.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"253ade78168bc1ac4b16e9b997a61fd8171946fc","unresolved":true,"context_lines":[{"line_number":2349,"context_line":"            LUN_GET_ITER_REST[\u0027records\u0027][0][\u0027space\u0027][\u0027guarantee\u0027][\u0027requested\u0027],"},{"line_number":2350,"context_line":"        \u0027SpaceAllocated\u0027:"},{"line_number":2351,"context_line":"            LUN_GET_ITER_REST[\u0027records\u0027][0][\u0027space\u0027]"},{"line_number":2352,"context_line":"            [\u0027scsi_thin_provisioning_support_enabled\u0027],"},{"line_number":2353,"context_line":"        \u0027UUID\u0027: LUN_GET_ITER_REST[\u0027records\u0027][0][\u0027uuid\u0027],"},{"line_number":2354,"context_line":"    },"},{"line_number":2355,"context_line":"    {"}],"source_content_type":"text/x-python","patch_set":5,"id":"f1ec08b2_53014483","line":2352,"range":{"start_line":2352,"start_character":14,"end_line":2352,"end_character":52},"updated":"2023-09-01 02:11:49.000000000","message":"nit: this is kind of misleading as we are again associating SpaceAllocated with thin provisioning which is not True\ncan we add additional property in the space section for space allocated or just hardcode the value as true/false here?","commit_id":"bca22013caece31926349d78d3e1b35152d44d90"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"7f2c60be6aeb4d063c19255b5bbc78e7174eec04","unresolved":false,"context_lines":[{"line_number":2349,"context_line":"            LUN_GET_ITER_REST[\u0027records\u0027][0][\u0027space\u0027][\u0027guarantee\u0027][\u0027requested\u0027],"},{"line_number":2350,"context_line":"        \u0027SpaceAllocated\u0027:"},{"line_number":2351,"context_line":"            LUN_GET_ITER_REST[\u0027records\u0027][0][\u0027space\u0027]"},{"line_number":2352,"context_line":"            [\u0027scsi_thin_provisioning_support_enabled\u0027],"},{"line_number":2353,"context_line":"        \u0027UUID\u0027: LUN_GET_ITER_REST[\u0027records\u0027][0][\u0027uuid\u0027],"},{"line_number":2354,"context_line":"    },"},{"line_number":2355,"context_line":"    {"}],"source_content_type":"text/x-python","patch_set":5,"id":"d633fb82_7b97ba57","line":2352,"range":{"start_line":2352,"start_character":14,"end_line":2352,"end_character":52},"in_reply_to":"33a1bdc5_52c5c13b","updated":"2023-09-06 16:12:13.000000000","message":"Please look at Page#174, in https://library.netapp.com/ecm/ecm_download_file/ECMLP2882104. Netapp named attribute space-allocation-enabled as space.scsi_thin_provisioning_support_enabled","commit_id":"bca22013caece31926349d78d3e1b35152d44d90"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"e0c23ec1771d32a61f1a46a7d7073f8f6439870f","unresolved":false,"context_lines":[{"line_number":2349,"context_line":"            LUN_GET_ITER_REST[\u0027records\u0027][0][\u0027space\u0027][\u0027guarantee\u0027][\u0027requested\u0027],"},{"line_number":2350,"context_line":"        \u0027SpaceAllocated\u0027:"},{"line_number":2351,"context_line":"            LUN_GET_ITER_REST[\u0027records\u0027][0][\u0027space\u0027]"},{"line_number":2352,"context_line":"            [\u0027scsi_thin_provisioning_support_enabled\u0027],"},{"line_number":2353,"context_line":"        \u0027UUID\u0027: LUN_GET_ITER_REST[\u0027records\u0027][0][\u0027uuid\u0027],"},{"line_number":2354,"context_line":"    },"},{"line_number":2355,"context_line":"    {"}],"source_content_type":"text/x-python","patch_set":5,"id":"33a1bdc5_52c5c13b","line":2352,"range":{"start_line":2352,"start_character":14,"end_line":2352,"end_character":52},"in_reply_to":"f1ec08b2_53014483","updated":"2023-09-01 13:57:27.000000000","message":"I am not able to find space allocation related information available in ONTAP rest. https://library.netapp.com/ecmdocs/ECMLP2856304/html/index.html#/SAN/lun_collection_get. Also in ONTAP system manager. removed this attribute from code.","commit_id":"bca22013caece31926349d78d3e1b35152d44d90"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/client/test_client_cmode_rest.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"253ade78168bc1ac4b16e9b997a61fd8171946fc","unresolved":true,"context_lines":[{"line_number":854,"context_line":"            \u0027uuid\u0027: fake.UUID1,"},{"line_number":855,"context_line":"            \u0027fields\u0027: \u0027svm.name,location.volume.name,space.size,\u0027"},{"line_number":856,"context_line":"                      \u0027location.qtree.name,name,os_type,\u0027"},{"line_number":857,"context_line":"                      \u0027space.scsi_thin_provisioning_support_enabled,\u0027"},{"line_number":858,"context_line":"                      \u0027space.guarantee.requested,uuid\u0027"},{"line_number":859,"context_line":"        }"},{"line_number":860,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"c59a44c1_4dc26d47","line":857,"range":{"start_line":857,"start_character":0,"end_line":857,"end_character":69},"updated":"2023-09-01 02:11:49.000000000","message":"again, using thin provisioning in substitution of space allocation field sounds wrong to me (even though it\u0027s only in tests)\ncan we create and use a new field for space allocated instead?","commit_id":"bca22013caece31926349d78d3e1b35152d44d90"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"7f2c60be6aeb4d063c19255b5bbc78e7174eec04","unresolved":false,"context_lines":[{"line_number":854,"context_line":"            \u0027uuid\u0027: fake.UUID1,"},{"line_number":855,"context_line":"            \u0027fields\u0027: \u0027svm.name,location.volume.name,space.size,\u0027"},{"line_number":856,"context_line":"                      \u0027location.qtree.name,name,os_type,\u0027"},{"line_number":857,"context_line":"                      \u0027space.scsi_thin_provisioning_support_enabled,\u0027"},{"line_number":858,"context_line":"                      \u0027space.guarantee.requested,uuid\u0027"},{"line_number":859,"context_line":"        }"},{"line_number":860,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7d0a14f5_939d4991","line":857,"range":{"start_line":857,"start_character":0,"end_line":857,"end_character":69},"in_reply_to":"6b427160_25d44ac5","updated":"2023-09-06 16:12:13.000000000","message":"Please look at Page#174, in https://library.netapp.com/ecm/ecm_download_file/ECMLP2882104. Netapp named attribute space-allocation-enabled  as space.scsi_thin_provisioning_support_enabled","commit_id":"bca22013caece31926349d78d3e1b35152d44d90"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"e0c23ec1771d32a61f1a46a7d7073f8f6439870f","unresolved":false,"context_lines":[{"line_number":854,"context_line":"            \u0027uuid\u0027: fake.UUID1,"},{"line_number":855,"context_line":"            \u0027fields\u0027: \u0027svm.name,location.volume.name,space.size,\u0027"},{"line_number":856,"context_line":"                      \u0027location.qtree.name,name,os_type,\u0027"},{"line_number":857,"context_line":"                      \u0027space.scsi_thin_provisioning_support_enabled,\u0027"},{"line_number":858,"context_line":"                      \u0027space.guarantee.requested,uuid\u0027"},{"line_number":859,"context_line":"        }"},{"line_number":860,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"6b427160_25d44ac5","line":857,"range":{"start_line":857,"start_character":0,"end_line":857,"end_character":69},"in_reply_to":"c59a44c1_4dc26d47","updated":"2023-09-01 13:57:27.000000000","message":"Thank you! Rajat,I am not able to find space allocation related information available in ONTAP rest. https://library.netapp.com/ecmdocs/ECMLP2856304/html/index.html#/SAN/lun_collection_get. Also in ONTAP system manager. removed this attribute from code.Also, ONTAP REST is not used so this is not resulting in any error.","commit_id":"bca22013caece31926349d78d3e1b35152d44d90"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/test_block_base.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"584bf57abe8d8b106243e613cf53af07f55b6837","unresolved":true,"context_lines":[{"line_number":184,"context_line":"                         return_value\u003d{\u0027netapp:space_allocation\u0027: \u0027xyz\u0027})"},{"line_number":185,"context_line":"        self.mock_object(self.library, \u0027_setup_qos_for_volume\u0027,"},{"line_number":186,"context_line":"                         return_value\u003dfake.QOS_POLICY_GROUP_INFO)"},{"line_number":187,"context_line":"        self.mock_object(self.library, \u0027_create_lun\u0027, side_effect\u003dException)"},{"line_number":188,"context_line":"        self.mock_object(self.library, \u0027_mark_qos_policy_group_for_deletion\u0027)"},{"line_number":189,"context_line":"        self.assertRaises(exception.InvalidVolumeType,"},{"line_number":190,"context_line":"                          self.library.create_volume, fake.VOLUME)"}],"source_content_type":"text/x-python","patch_set":19,"id":"43b8bb13_baaaf176","line":187,"range":{"start_line":187,"start_character":8,"end_line":187,"end_character":76},"updated":"2024-03-04 07:41:35.000000000","message":"looks like raising here is causing the issue with unit tests\n\nTraceback (most recent call last):\n  File \"/home/zuul/src/opendev.org/openstack/cinder/cinder/volume/drivers/netapp/dataontap/block_base.py\", line 251, in create_volume\n    self._create_lun(pool_name, lun_name, size, metadata,\n  File \"/usr/lib/python3.8/unittest/mock.py\", line 1081, in __call__\n    return self._mock_call(*args, **kwargs)\n  File \"/usr/lib/python3.8/unittest/mock.py\", line 1085, in _mock_call\n    return self._execute_mock_call(*args, **kwargs)\n  File \"/usr/lib/python3.8/unittest/mock.py\", line 1140, in _execute_mock_call\n    raise effect\nException","commit_id":"9d9322eee360c1d047b26a8e49dbd16a753f2d88"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"e179799c8b7827e449bff4fe412578071e1a00a0","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                         return_value\u003d{\u0027netapp:space_allocation\u0027: \u0027xyz\u0027})"},{"line_number":185,"context_line":"        self.mock_object(self.library, \u0027_setup_qos_for_volume\u0027,"},{"line_number":186,"context_line":"                         return_value\u003dfake.QOS_POLICY_GROUP_INFO)"},{"line_number":187,"context_line":"        self.mock_object(self.library, \u0027_create_lun\u0027, side_effect\u003dException)"},{"line_number":188,"context_line":"        self.mock_object(self.library, \u0027_mark_qos_policy_group_for_deletion\u0027)"},{"line_number":189,"context_line":"        self.assertRaises(exception.InvalidVolumeType,"},{"line_number":190,"context_line":"                          self.library.create_volume, fake.VOLUME)"}],"source_content_type":"text/x-python","patch_set":19,"id":"013838cb_f026205c","line":187,"range":{"start_line":187,"start_character":8,"end_line":187,"end_character":76},"in_reply_to":"43b8bb13_baaaf176","updated":"2024-03-04 16:51:53.000000000","message":"Thank you! Rajath, update failing UT","commit_id":"9d9322eee360c1d047b26a8e49dbd16a753f2d88"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cf86711d015fa9099d2a7d23bcb61de4a2b38454","unresolved":true,"context_lines":[{"line_number":147,"context_line":"    def test_create_volume_extra_spec(self):"},{"line_number":148,"context_line":"        volume_size_in_bytes \u003d int(fake.SIZE) * units.Gi"},{"line_number":149,"context_line":"        self.mock_object(na_utils, \u0027get_volume_extra_specs\u0027,"},{"line_number":150,"context_line":"                         return_value\u003d{\u0027netapp:space_allocation\u0027: \u0027\u003cis\u003e False\u0027})"},{"line_number":151,"context_line":"        self.mock_object(na_utils, \u0027log_extra_spec_warnings\u0027)"},{"line_number":152,"context_line":"        self.mock_object(block_base, \u0027LOG\u0027)"},{"line_number":153,"context_line":"        self.mock_object(volume_utils, \u0027extract_host\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"aa48fecd_45b6b120","line":150,"range":{"start_line":150,"start_character":25,"end_line":150,"end_character":80},"updated":"2024-03-04 20:05:35.000000000","message":"self.mock_object(\n        na_utils, \u0027get_volume_extra_specs\u0027,\n        return_value\u003d{\u0027netapp:space_allocation\u0027: \u0027\u003cis\u003e False\u0027})","commit_id":"f5ad747304747c00bb88332b65e0ebcb0aea20ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"042f60263709d023654bb9e755ac4892dc3a7645","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    def test_create_volume_extra_spec(self):"},{"line_number":148,"context_line":"        volume_size_in_bytes \u003d int(fake.SIZE) * units.Gi"},{"line_number":149,"context_line":"        self.mock_object(na_utils, \u0027get_volume_extra_specs\u0027,"},{"line_number":150,"context_line":"                         return_value\u003d{\u0027netapp:space_allocation\u0027: \u0027\u003cis\u003e False\u0027})"},{"line_number":151,"context_line":"        self.mock_object(na_utils, \u0027log_extra_spec_warnings\u0027)"},{"line_number":152,"context_line":"        self.mock_object(block_base, \u0027LOG\u0027)"},{"line_number":153,"context_line":"        self.mock_object(volume_utils, \u0027extract_host\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"f0f56091_877b7254","line":150,"range":{"start_line":150,"start_character":25,"end_line":150,"end_character":80},"in_reply_to":"aa48fecd_45b6b120","updated":"2024-03-05 07:13:53.000000000","message":"update","commit_id":"f5ad747304747c00bb88332b65e0ebcb0aea20ed"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cf86711d015fa9099d2a7d23bcb61de4a2b38454","unresolved":true,"context_lines":[{"line_number":179,"context_line":"                          fake.VOLUME)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def test_space_allocation_exception_path(self):"},{"line_number":182,"context_line":"        volume_size_in_bytes \u003d int(fake.SIZE) * units.Gi"},{"line_number":183,"context_line":"        self.mock_object(block_base, \u0027LOG\u0027)"},{"line_number":184,"context_line":"        self.mock_object(na_utils, \u0027get_volume_extra_specs\u0027,"},{"line_number":185,"context_line":"                         return_value\u003d{\u0027netapp:space_allocation\u0027: \u0027xyz\u0027})"}],"source_content_type":"text/x-python","patch_set":20,"id":"0076751a_a1e36a21","line":182,"range":{"start_line":182,"start_character":0,"end_line":182,"end_character":56},"updated":"2024-03-04 20:05:35.000000000","message":"remove this","commit_id":"f5ad747304747c00bb88332b65e0ebcb0aea20ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"042f60263709d023654bb9e755ac4892dc3a7645","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                          fake.VOLUME)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def test_space_allocation_exception_path(self):"},{"line_number":182,"context_line":"        volume_size_in_bytes \u003d int(fake.SIZE) * units.Gi"},{"line_number":183,"context_line":"        self.mock_object(block_base, \u0027LOG\u0027)"},{"line_number":184,"context_line":"        self.mock_object(na_utils, \u0027get_volume_extra_specs\u0027,"},{"line_number":185,"context_line":"                         return_value\u003d{\u0027netapp:space_allocation\u0027: \u0027xyz\u0027})"}],"source_content_type":"text/x-python","patch_set":20,"id":"8788ae4d_ef80c7c0","line":182,"range":{"start_line":182,"start_character":0,"end_line":182,"end_character":56},"in_reply_to":"0076751a_a1e36a21","updated":"2024-03-05 07:13:53.000000000","message":"removed.","commit_id":"f5ad747304747c00bb88332b65e0ebcb0aea20ed"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e8db56e75bc0fb46c52e09e2c015ad7eb402092f","unresolved":true,"context_lines":[{"line_number":148,"context_line":"        volume_size_in_bytes \u003d int(fake.SIZE) * units.Gi"},{"line_number":149,"context_line":"        self.mock_object(na_utils, \u0027get_volume_extra_specs\u0027,"},{"line_number":150,"context_line":"                         return_value\u003d{"},{"line_number":151,"context_line":"                             \u0027netapp:space_allocation\u0027: \u0027\u003cis\u003e False\u0027"},{"line_number":152,"context_line":"                         }"},{"line_number":153,"context_line":"                         )"},{"line_number":154,"context_line":"        self.mock_object(na_utils, \u0027log_extra_spec_warnings\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"5332dc44_138b880f","line":151,"updated":"2024-03-05 23:03:54.000000000","message":"It\u0027s good to test this, but don\u0027t you also want to test the case when it\u0027s true?","commit_id":"bfeaad4a41d36aff7f5320e2c56709e57a77e7a3"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"ccb1d292a0e48e626c2a3552dd0888563f6e25ca","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        volume_size_in_bytes \u003d int(fake.SIZE) * units.Gi"},{"line_number":149,"context_line":"        self.mock_object(na_utils, \u0027get_volume_extra_specs\u0027,"},{"line_number":150,"context_line":"                         return_value\u003d{"},{"line_number":151,"context_line":"                             \u0027netapp:space_allocation\u0027: \u0027\u003cis\u003e False\u0027"},{"line_number":152,"context_line":"                         }"},{"line_number":153,"context_line":"                         )"},{"line_number":154,"context_line":"        self.mock_object(na_utils, \u0027log_extra_spec_warnings\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"3c83181b_cfaf1c10","line":151,"in_reply_to":"5332dc44_138b880f","updated":"2024-03-06 08:25:53.000000000","message":"Thank you! added additional UT to test that scenarios.","commit_id":"bfeaad4a41d36aff7f5320e2c56709e57a77e7a3"}],"cinder/volume/drivers/netapp/dataontap/block_base.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"253ade78168bc1ac4b16e9b997a61fd8171946fc","unresolved":true,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        extra_specs \u003d na_utils.get_volume_extra_specs(volume)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        space_allocation \u003d extra_specs.get(\u0027netapp:space_allocation\u0027, None)"},{"line_number":228,"context_line":"        if (space_allocation is not None and"},{"line_number":229,"context_line":"                space_allocation.lower() not in (\"true\", \"false\")):"},{"line_number":230,"context_line":"            msg \u003d (_(\"Invalid boolean value for space-allocation-enabled: %s.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"886b320c_5c492588","line":227,"range":{"start_line":227,"start_character":70,"end_line":227,"end_character":74},"updated":"2023-09-01 02:11:49.000000000","message":"nit: default value for get is already None","commit_id":"bca22013caece31926349d78d3e1b35152d44d90"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"e0c23ec1771d32a61f1a46a7d7073f8f6439870f","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        extra_specs \u003d na_utils.get_volume_extra_specs(volume)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        space_allocation \u003d extra_specs.get(\u0027netapp:space_allocation\u0027, None)"},{"line_number":228,"context_line":"        if (space_allocation is not None and"},{"line_number":229,"context_line":"                space_allocation.lower() not in (\"true\", \"false\")):"},{"line_number":230,"context_line":"            msg \u003d (_(\"Invalid boolean value for space-allocation-enabled: %s.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"58f2abc9_94857f75","line":227,"range":{"start_line":227,"start_character":70,"end_line":227,"end_character":74},"in_reply_to":"886b320c_5c492588","updated":"2023-09-01 13:57:27.000000000","message":"removed redundant None","commit_id":"bca22013caece31926349d78d3e1b35152d44d90"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"579804a3a368a038901de28fbf432471f890d61c","unresolved":true,"context_lines":[{"line_number":227,"context_line":"        space_allocation \u003d extra_specs.get(\u0027netapp:space_allocation\u0027)"},{"line_number":228,"context_line":"        if (space_allocation is not None and"},{"line_number":229,"context_line":"                space_allocation.lower() not in (\"true\", \"false\")):"},{"line_number":230,"context_line":"            msg \u003d (_(\"Invalid boolean value for space-allocation-enabled: %s.\")"},{"line_number":231,"context_line":"                   % space_allocation)"},{"line_number":232,"context_line":"            raise exception.InvalidVolumeType(reason\u003dmsg)"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"46c0bd97_579ef69a","line":230,"range":{"start_line":230,"start_character":48,"end_line":230,"end_character":72},"updated":"2023-09-06 12:53:41.000000000","message":"don\u0027t use ONTAP API name, Cinder may not know about ONTAP and its API. Use the Cinder name:\n\n\"Invalid boolean value for netapp:space_allocation: %s.\"","commit_id":"bd25788019c3fd1b8c86d521dfaa11c2513d5f7b"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"c77918230567219ad7dbce46dba1d20daef6157a","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        space_allocation \u003d extra_specs.get(\u0027netapp:space_allocation\u0027)"},{"line_number":228,"context_line":"        if (space_allocation is not None and"},{"line_number":229,"context_line":"                space_allocation.lower() not in (\"true\", \"false\")):"},{"line_number":230,"context_line":"            msg \u003d (_(\"Invalid boolean value for space-allocation-enabled: %s.\")"},{"line_number":231,"context_line":"                   % space_allocation)"},{"line_number":232,"context_line":"            raise exception.InvalidVolumeType(reason\u003dmsg)"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"4e65fb1e_4f25f53f","line":230,"range":{"start_line":230,"start_character":48,"end_line":230,"end_character":72},"in_reply_to":"46c0bd97_579ef69a","updated":"2023-09-06 16:18:21.000000000","message":"Modified to netapp:space_allocation.","commit_id":"bd25788019c3fd1b8c86d521dfaa11c2513d5f7b"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"579804a3a368a038901de28fbf432471f890d61c","unresolved":true,"context_lines":[{"line_number":240,"context_line":"                    \u0027Path\u0027: \u0027/vol/%s/%s\u0027 % (pool_name, lun_name)}"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        if space_allocation is not None:"},{"line_number":243,"context_line":"            metadata[\u0027SpaceAllocated\u0027] \u003d space_allocation"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        qos_policy_group_info \u003d self._setup_qos_for_volume(volume, extra_specs)"},{"line_number":246,"context_line":"        qos_policy_group_name \u003d ("}],"source_content_type":"text/x-python","patch_set":10,"id":"d581796b_0cbc8ed2","line":243,"updated":"2023-09-06 12:53:41.000000000","message":"This line is not being tested by UTs, see the coverage results: https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_9d9/893106/10/check/cinder-code-coverage/9d94349/cover/d_51037160818d3f73_block_base_py.html#t244\n\nSince it is the actual feature being used, you should cover it.","commit_id":"bd25788019c3fd1b8c86d521dfaa11c2513d5f7b"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"c77918230567219ad7dbce46dba1d20daef6157a","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                    \u0027Path\u0027: \u0027/vol/%s/%s\u0027 % (pool_name, lun_name)}"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        if space_allocation is not None:"},{"line_number":243,"context_line":"            metadata[\u0027SpaceAllocated\u0027] \u003d space_allocation"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        qos_policy_group_info \u003d self._setup_qos_for_volume(volume, extra_specs)"},{"line_number":246,"context_line":"        qos_policy_group_name \u003d ("}],"source_content_type":"text/x-python","patch_set":10,"id":"1a193fcf_451cef0b","line":243,"in_reply_to":"d581796b_0cbc8ed2","updated":"2023-09-06 16:18:21.000000000","message":"Added extra test cases to cover space_allocation None.","commit_id":"bd25788019c3fd1b8c86d521dfaa11c2513d5f7b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b45f4b525ca8723288f0bc9735a8384d47c206e1","unresolved":true,"context_lines":[{"line_number":239,"context_line":"                    \u0027SpaceReserved\u0027: self.lun_space_reservation,"},{"line_number":240,"context_line":"                    \u0027Path\u0027: \u0027/vol/%s/%s\u0027 % (pool_name, lun_name)}"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        if space_allocation is not None:"},{"line_number":243,"context_line":"            metadata[\u0027SpaceAllocated\u0027] \u003d space_allocation"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        qos_policy_group_info \u003d self._setup_qos_for_volume(volume, extra_specs)"},{"line_number":246,"context_line":"        qos_policy_group_name \u003d ("}],"source_content_type":"text/x-python","patch_set":15,"id":"f8b1086e_07371d72","line":243,"range":{"start_line":242,"start_character":8,"end_line":243,"end_character":57},"updated":"2024-02-15 20:00:36.000000000","message":"if we don\u0027t provide space_allocation property in volume type, what is the default value that will be assigned?","commit_id":"e063f8f9abf98a86b9aca90549c061c68449e4ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"c2c25e834675404bcf95788f84600d26655255a4","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                    \u0027SpaceReserved\u0027: self.lun_space_reservation,"},{"line_number":240,"context_line":"                    \u0027Path\u0027: \u0027/vol/%s/%s\u0027 % (pool_name, lun_name)}"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        if space_allocation is not None:"},{"line_number":243,"context_line":"            metadata[\u0027SpaceAllocated\u0027] \u003d space_allocation"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        qos_policy_group_info \u003d self._setup_qos_for_volume(volume, extra_specs)"},{"line_number":246,"context_line":"        qos_policy_group_name \u003d ("}],"source_content_type":"text/x-python","patch_set":15,"id":"cc2a3e8b_a101f958","line":243,"range":{"start_line":242,"start_character":8,"end_line":243,"end_character":57},"in_reply_to":"f8b1086e_07371d72","updated":"2024-02-23 15:05:23.000000000","message":"If SpaceAllocated value is not passed then ONTAP will set this value to false.\nhttps://docs.netapp.com/us-en/ontap/san-admin/enable-space-allocation-scsi-thin-provisioned-luns-task.html","commit_id":"e063f8f9abf98a86b9aca90549c061c68449e4ea"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b45f4b525ca8723288f0bc9735a8384d47c206e1","unresolved":true,"context_lines":[{"line_number":723,"context_line":"                    LOG.error(\"Exception details: %s\", e)"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"    def _is_space_alloc_enabled(self, path):"},{"line_number":726,"context_line":"        \"\"\"Gets block counts for the LUN.\"\"\""},{"line_number":727,"context_line":"        LOG.debug(\"Getting LUN space allocation enabled.\")"},{"line_number":728,"context_line":"        lun_infos \u003d self.zapi_client.get_lun_by_args(path\u003dpath)"},{"line_number":729,"context_line":"        if not lun_infos:"}],"source_content_type":"text/x-python","patch_set":15,"id":"146834be_2a6af4ac","line":726,"range":{"start_line":726,"start_character":11,"end_line":726,"end_character":41},"updated":"2024-02-15 20:00:36.000000000","message":"we are not getting the block count here\nwe are checking if the space allocation is enabled for the LUN","commit_id":"e063f8f9abf98a86b9aca90549c061c68449e4ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"c2c25e834675404bcf95788f84600d26655255a4","unresolved":false,"context_lines":[{"line_number":723,"context_line":"                    LOG.error(\"Exception details: %s\", e)"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"    def _is_space_alloc_enabled(self, path):"},{"line_number":726,"context_line":"        \"\"\"Gets block counts for the LUN.\"\"\""},{"line_number":727,"context_line":"        LOG.debug(\"Getting LUN space allocation enabled.\")"},{"line_number":728,"context_line":"        lun_infos \u003d self.zapi_client.get_lun_by_args(path\u003dpath)"},{"line_number":729,"context_line":"        if not lun_infos:"}],"source_content_type":"text/x-python","patch_set":15,"id":"a9a0ab59_154ff39c","line":726,"range":{"start_line":726,"start_character":11,"end_line":726,"end_character":41},"in_reply_to":"146834be_2a6af4ac","updated":"2024-02-23 15:05:23.000000000","message":"Correct, thank you! for pointing.","commit_id":"e063f8f9abf98a86b9aca90549c061c68449e4ea"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b45f4b525ca8723288f0bc9735a8384d47c206e1","unresolved":true,"context_lines":[{"line_number":730,"context_line":"            seg \u003d path.split(\u0027/\u0027)"},{"line_number":731,"context_line":"            msg \u003d _(\u0027Failure getting LUN info for %s.\u0027)"},{"line_number":732,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg % seg[-1])"},{"line_number":733,"context_line":"        lun_info \u003d lun_infos[-1]"},{"line_number":734,"context_line":"        return bool(lun_info[\u0027SpaceAllocated\u0027])"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"    def _get_lun_block_count(self, path):"}],"source_content_type":"text/x-python","patch_set":15,"id":"b8f4d904_09968cf6","line":733,"range":{"start_line":733,"start_character":19,"end_line":733,"end_character":32},"updated":"2024-02-15 20:00:36.000000000","message":"is there a possibility that we have multiple LUNs returned from a particular LUN path?\nnit: I assume this list will only have 1 element so lun_infos[0] should work as well, getting the last LUN looks confusing","commit_id":"e063f8f9abf98a86b9aca90549c061c68449e4ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"c2c25e834675404bcf95788f84600d26655255a4","unresolved":false,"context_lines":[{"line_number":730,"context_line":"            seg \u003d path.split(\u0027/\u0027)"},{"line_number":731,"context_line":"            msg \u003d _(\u0027Failure getting LUN info for %s.\u0027)"},{"line_number":732,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg % seg[-1])"},{"line_number":733,"context_line":"        lun_info \u003d lun_infos[-1]"},{"line_number":734,"context_line":"        return bool(lun_info[\u0027SpaceAllocated\u0027])"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"    def _get_lun_block_count(self, path):"}],"source_content_type":"text/x-python","patch_set":15,"id":"618607f4_b46b9bd1","line":733,"range":{"start_line":733,"start_character":19,"end_line":733,"end_character":32},"in_reply_to":"b8f4d904_09968cf6","updated":"2024-02-23 15:05:23.000000000","message":"Updated to get first record","commit_id":"e063f8f9abf98a86b9aca90549c061c68449e4ea"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b45f4b525ca8723288f0bc9735a8384d47c206e1","unresolved":true,"context_lines":[{"line_number":731,"context_line":"            msg \u003d _(\u0027Failure getting LUN info for %s.\u0027)"},{"line_number":732,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg % seg[-1])"},{"line_number":733,"context_line":"        lun_info \u003d lun_infos[-1]"},{"line_number":734,"context_line":"        return bool(lun_info[\u0027SpaceAllocated\u0027])"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"    def _get_lun_block_count(self, path):"},{"line_number":737,"context_line":"        \"\"\"Gets block counts for the LUN.\"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"cc4cada4_9eb3d924","line":734,"range":{"start_line":734,"start_character":20,"end_line":734,"end_character":46},"updated":"2024-02-15 20:00:36.000000000","message":"is there a case possible where this key doesn\u0027t exist? also if we don\u0027t set it in volume type, what will be the default value?","commit_id":"e063f8f9abf98a86b9aca90549c061c68449e4ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"c2c25e834675404bcf95788f84600d26655255a4","unresolved":false,"context_lines":[{"line_number":731,"context_line":"            msg \u003d _(\u0027Failure getting LUN info for %s.\u0027)"},{"line_number":732,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg % seg[-1])"},{"line_number":733,"context_line":"        lun_info \u003d lun_infos[-1]"},{"line_number":734,"context_line":"        return bool(lun_info[\u0027SpaceAllocated\u0027])"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"    def _get_lun_block_count(self, path):"},{"line_number":737,"context_line":"        \"\"\"Gets block counts for the LUN.\"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"99916914_2e1ef568","line":734,"range":{"start_line":734,"start_character":20,"end_line":734,"end_character":46},"in_reply_to":"cc4cada4_9eb3d924","updated":"2024-02-23 15:05:23.000000000","message":"Key is always present from ONTAP side. If SpaceAllocation is not set ONTAP will set it to False for a newly create LUN.","commit_id":"e063f8f9abf98a86b9aca90549c061c68449e4ea"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"20f67971435c340ece9130c18b1c655a5f94802e","unresolved":true,"context_lines":[{"line_number":225,"context_line":"        extra_specs \u003d na_utils.get_volume_extra_specs(volume)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        space_allocation \u003d extra_specs.get(\u0027netapp:space_allocation\u0027)"},{"line_number":228,"context_line":"        if (space_allocation is not None and"},{"line_number":229,"context_line":"                space_allocation.lower() not in (\"true\", \"false\")):"},{"line_number":230,"context_line":"            msg \u003d (_(\"Invalid boolean value for netapp:space-allocation: %s.\")"},{"line_number":231,"context_line":"                   % space_allocation)"}],"source_content_type":"text/x-python","patch_set":16,"id":"db9f571e_e09fd781","line":228,"range":{"start_line":228,"start_character":12,"end_line":228,"end_character":40},"updated":"2024-02-26 17:43:58.000000000","message":"nit: why are we setting this instead of \n\n    if space_allocation and ...:\n\nare we trying to handle cases when we provide empty string in the extra specs?\n\n    netapp:space_allocation\u003d\u0027\u0027","commit_id":"afc3be5daf765047174acc58717e3f3d9d9e07f8"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"b7df8a8e1b5f729d45c6d31673d5b0671e7edfa3","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        extra_specs \u003d na_utils.get_volume_extra_specs(volume)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        space_allocation \u003d extra_specs.get(\u0027netapp:space_allocation\u0027)"},{"line_number":228,"context_line":"        if (space_allocation is not None and"},{"line_number":229,"context_line":"                space_allocation.lower() not in (\"true\", \"false\")):"},{"line_number":230,"context_line":"            msg \u003d (_(\"Invalid boolean value for netapp:space-allocation: %s.\")"},{"line_number":231,"context_line":"                   % space_allocation)"}],"source_content_type":"text/x-python","patch_set":16,"id":"68a18083_b32e3356","line":228,"range":{"start_line":228,"start_character":12,"end_line":228,"end_character":40},"in_reply_to":"db9f571e_e09fd781","updated":"2024-03-02 19:13:31.000000000","message":"removed this section now.","commit_id":"afc3be5daf765047174acc58717e3f3d9d9e07f8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4a253da123a87423882acfb029b5185459c2583f","unresolved":true,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        space_allocation \u003d extra_specs.get(\u0027netapp:space_allocation\u0027)"},{"line_number":228,"context_line":"        if (space_allocation is not None and"},{"line_number":229,"context_line":"                space_allocation.lower() not in (\"true\", \"false\")):"},{"line_number":230,"context_line":"            msg \u003d (_(\"Invalid boolean value for netapp:space-allocation: %s.\")"},{"line_number":231,"context_line":"                   % space_allocation)"},{"line_number":232,"context_line":"            raise exception.InvalidVolumeType(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":16,"id":"57d13dc8_cc010126","line":229,"range":{"start_line":229,"start_character":49,"end_line":229,"end_character":64},"updated":"2024-02-28 22:17:05.000000000","message":"Traditionally, cinder uses \"\u003cis\u003e True\" and \"\u003cis\u003e False\" to express boolean values (because extra_specs values are always strings).  For example, take a look at the definition of the netapp:qos_policy_group_is_adaptive extra spec in the netapp docs [0].  You can take a look at the patch that added that qos extra-spec to see one way to handle parsing the extra-specs [1].  You need to fix this, because an operator using the standard cinder convention of \"\u003cis\u003e True\" will be pretty annoyed to have it fail at line 232.\n\n[0] https://docs.openstack.org/cinder/latest/configuration/block-storage/drivers/netapp-volume-driver.html#netapp-supported-extra-specs-for-clustered-data-ontap\n[1] https://review.opendev.org/c/openstack/cinder/+/775455/4/cinder/volume/drivers/netapp/dataontap/nfs_cmode.py#168","commit_id":"afc3be5daf765047174acc58717e3f3d9d9e07f8"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"8ff7532b22d5a27289b46c4a2e059b5f778709e4","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        space_allocation \u003d extra_specs.get(\u0027netapp:space_allocation\u0027)"},{"line_number":228,"context_line":"        if (space_allocation is not None and"},{"line_number":229,"context_line":"                space_allocation.lower() not in (\"true\", \"false\")):"},{"line_number":230,"context_line":"            msg \u003d (_(\"Invalid boolean value for netapp:space-allocation: %s.\")"},{"line_number":231,"context_line":"                   % space_allocation)"},{"line_number":232,"context_line":"            raise exception.InvalidVolumeType(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":16,"id":"dd28b73b_20804cfc","line":229,"range":{"start_line":229,"start_character":49,"end_line":229,"end_character":64},"in_reply_to":"14c04c77_55906295","updated":"2024-03-02 19:17:35.000000000","message":"Also, NetApp expecting string \"true\"/\"false\" in ZAPI. Please not below error from ONTAP when i pass boolean value directly.\ncinder-volume.log:ERROR oslo_messaging.rpc.server   File \"/opt/stack/cinder/cinder/volume/drivers/netapp/dataontap/client/api.py\", line 341, in set_content\ncinder-volume.log:ERROR oslo_messaging.rpc.server     self._element.text \u003d text\ncinder-volume.log:ERROR oslo_messaging.rpc.server   File \"src/lxml/etree.pyx\", line 1048, in lxml.etree._Element.text.__set__\ncinder-volume.log:ERROR oslo_messaging.rpc.server   File \"src/lxml/apihelpers.pxi\", line 749, in lxml.etree._setNodeText\ncinder-volume.log:ERROR oslo_messaging.rpc.server   File \"src/lxml/apihelpers.pxi\", line 737, in lxml.etree._createTextNode\ncinder-volume.log:ERROR oslo_messaging.rpc.server   File \"src/lxml/apihelpers.pxi\", line 1528, in lxml.etree._utf8\ncinder-volume.log:ERROR oslo_messaging.rpc.server TypeError: Argument must be bytes or unicode, got \u0027bool\u0027","commit_id":"afc3be5daf765047174acc58717e3f3d9d9e07f8"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"b7df8a8e1b5f729d45c6d31673d5b0671e7edfa3","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        space_allocation \u003d extra_specs.get(\u0027netapp:space_allocation\u0027)"},{"line_number":228,"context_line":"        if (space_allocation is not None and"},{"line_number":229,"context_line":"                space_allocation.lower() not in (\"true\", \"false\")):"},{"line_number":230,"context_line":"            msg \u003d (_(\"Invalid boolean value for netapp:space-allocation: %s.\")"},{"line_number":231,"context_line":"                   % space_allocation)"},{"line_number":232,"context_line":"            raise exception.InvalidVolumeType(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":16,"id":"14c04c77_55906295","line":229,"range":{"start_line":229,"start_character":49,"end_line":229,"end_character":64},"in_reply_to":"57d13dc8_cc010126","updated":"2024-03-02 19:13:31.000000000","message":"Thank you! Brain for detailed example. Modified code to set NetApp LUN space-allocation value based on \"\u003cis\u003e True\" and \"\u003cis\u003e False\".","commit_id":"afc3be5daf765047174acc58717e3f3d9d9e07f8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4a253da123a87423882acfb029b5185459c2583f","unresolved":true,"context_lines":[{"line_number":227,"context_line":"        space_allocation \u003d extra_specs.get(\u0027netapp:space_allocation\u0027)"},{"line_number":228,"context_line":"        if (space_allocation is not None and"},{"line_number":229,"context_line":"                space_allocation.lower() not in (\"true\", \"false\")):"},{"line_number":230,"context_line":"            msg \u003d (_(\"Invalid boolean value for netapp:space-allocation: %s.\")"},{"line_number":231,"context_line":"                   % space_allocation)"},{"line_number":232,"context_line":"            raise exception.InvalidVolumeType(reason\u003dmsg)"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"48ce886c_72d63978","line":230,"updated":"2024-02-28 22:17:05.000000000","message":"You should probably revise this error message when you fix the above issue.","commit_id":"afc3be5daf765047174acc58717e3f3d9d9e07f8"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"b7df8a8e1b5f729d45c6d31673d5b0671e7edfa3","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        space_allocation \u003d extra_specs.get(\u0027netapp:space_allocation\u0027)"},{"line_number":228,"context_line":"        if (space_allocation is not None and"},{"line_number":229,"context_line":"                space_allocation.lower() not in (\"true\", \"false\")):"},{"line_number":230,"context_line":"            msg \u003d (_(\"Invalid boolean value for netapp:space-allocation: %s.\")"},{"line_number":231,"context_line":"                   % space_allocation)"},{"line_number":232,"context_line":"            raise exception.InvalidVolumeType(reason\u003dmsg)"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7ed57f92_74c6e18b","line":230,"in_reply_to":"48ce886c_72d63978","updated":"2024-03-02 19:13:31.000000000","message":"\"volume_utils.is_boolean_str\" is handling error based on input. Removed redundant error handling.","commit_id":"afc3be5daf765047174acc58717e3f3d9d9e07f8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"20f67971435c340ece9130c18b1c655a5f94802e","unresolved":true,"context_lines":[{"line_number":239,"context_line":"                    \u0027SpaceReserved\u0027: self.lun_space_reservation,"},{"line_number":240,"context_line":"                    \u0027Path\u0027: \u0027/vol/%s/%s\u0027 % (pool_name, lun_name)}"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        if space_allocation is not None:"},{"line_number":243,"context_line":"            metadata[\u0027SpaceAllocated\u0027] \u003d space_allocation"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        qos_policy_group_info \u003d self._setup_qos_for_volume(volume, extra_specs)"}],"source_content_type":"text/x-python","patch_set":16,"id":"209b5083_765e4457","line":242,"range":{"start_line":242,"start_character":11,"end_line":242,"end_character":39},"updated":"2024-02-26 17:43:58.000000000","message":"nit: same, can\u0027t we just use\n\n    if space_allocation:","commit_id":"afc3be5daf765047174acc58717e3f3d9d9e07f8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4a253da123a87423882acfb029b5185459c2583f","unresolved":true,"context_lines":[{"line_number":239,"context_line":"                    \u0027SpaceReserved\u0027: self.lun_space_reservation,"},{"line_number":240,"context_line":"                    \u0027Path\u0027: \u0027/vol/%s/%s\u0027 % (pool_name, lun_name)}"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        if space_allocation is not None:"},{"line_number":243,"context_line":"            metadata[\u0027SpaceAllocated\u0027] \u003d space_allocation"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        qos_policy_group_info \u003d self._setup_qos_for_volume(volume, extra_specs)"}],"source_content_type":"text/x-python","patch_set":16,"id":"cfe52769_8872c0ed","line":242,"range":{"start_line":242,"start_character":11,"end_line":242,"end_character":39},"in_reply_to":"209b5083_765e4457","updated":"2024-02-28 22:17:05.000000000","message":"I think because space_allocation is a string at this point, and bool(\u0027False\u0027) is True.  Rajat brings up a good point here, namely, that although the extra spec values arrive to the driver as strings, you can convert them to \"real\" booleans and that will make using them much less error prone.  So I suggest that the above error checking code should also set space_allocation to an explicit python boolean True or False.  It\u0027s not a big deal if you\u0027re only going to use it within this single function, but if you expect to use it elsewhere, you should make it a real boolean, or otherwise you\u0027re just asking for trouble.","commit_id":"afc3be5daf765047174acc58717e3f3d9d9e07f8"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"b7df8a8e1b5f729d45c6d31673d5b0671e7edfa3","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                    \u0027SpaceReserved\u0027: self.lun_space_reservation,"},{"line_number":240,"context_line":"                    \u0027Path\u0027: \u0027/vol/%s/%s\u0027 % (pool_name, lun_name)}"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        if space_allocation is not None:"},{"line_number":243,"context_line":"            metadata[\u0027SpaceAllocated\u0027] \u003d space_allocation"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        qos_policy_group_info \u003d self._setup_qos_for_volume(volume, extra_specs)"}],"source_content_type":"text/x-python","patch_set":16,"id":"122e3db8_e69ca506","line":242,"range":{"start_line":242,"start_character":11,"end_line":242,"end_character":39},"in_reply_to":"cfe52769_8872c0ed","updated":"2024-03-02 19:13:31.000000000","message":"Now handling only if space_allocation is True. Not handling if space_allocation truthy value.","commit_id":"afc3be5daf765047174acc58717e3f3d9d9e07f8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"20f67971435c340ece9130c18b1c655a5f94802e","unresolved":true,"context_lines":[{"line_number":729,"context_line":"        if not lun_infos:"},{"line_number":730,"context_line":"            seg \u003d path.split(\u0027/\u0027)"},{"line_number":731,"context_line":"            msg \u003d _(\u0027Failure getting LUN info for %s.\u0027)"},{"line_number":732,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg % seg[-1])"},{"line_number":733,"context_line":"        lun_info \u003d lun_infos[0]"},{"line_number":734,"context_line":"        return bool(lun_info[\u0027SpaceAllocated\u0027])"},{"line_number":735,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"49a735bc_09176c83","line":732,"range":{"start_line":732,"start_character":54,"end_line":732,"end_character":72},"updated":"2024-02-26 17:43:58.000000000","message":"nit: better to create this string in the previous line itself for readability\n\n    msg \u003d _(\u0027Failure getting LUN info for %s\u0027 % seg[-1])\n    raise exception.VolumeBackendAPIException(data\u003dmsg)","commit_id":"afc3be5daf765047174acc58717e3f3d9d9e07f8"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"ccb1d292a0e48e626c2a3552dd0888563f6e25ca","unresolved":false,"context_lines":[{"line_number":729,"context_line":"        if not lun_infos:"},{"line_number":730,"context_line":"            seg \u003d path.split(\u0027/\u0027)"},{"line_number":731,"context_line":"            msg \u003d _(\u0027Failure getting LUN info for %s.\u0027)"},{"line_number":732,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg % seg[-1])"},{"line_number":733,"context_line":"        lun_info \u003d lun_infos[0]"},{"line_number":734,"context_line":"        return bool(lun_info[\u0027SpaceAllocated\u0027])"},{"line_number":735,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"5d4183ff_893d6112","line":732,"range":{"start_line":732,"start_character":54,"end_line":732,"end_character":72},"in_reply_to":"49a735bc_09176c83","updated":"2024-03-06 08:25:53.000000000","message":"Thank you! updated logic","commit_id":"afc3be5daf765047174acc58717e3f3d9d9e07f8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"20f67971435c340ece9130c18b1c655a5f94802e","unresolved":true,"context_lines":[{"line_number":730,"context_line":"            seg \u003d path.split(\u0027/\u0027)"},{"line_number":731,"context_line":"            msg \u003d _(\u0027Failure getting LUN info for %s.\u0027)"},{"line_number":732,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg % seg[-1])"},{"line_number":733,"context_line":"        lun_info \u003d lun_infos[0]"},{"line_number":734,"context_line":"        return bool(lun_info[\u0027SpaceAllocated\u0027])"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"    def _get_lun_block_count(self, path):"},{"line_number":737,"context_line":"        \"\"\"Gets block counts for the LUN.\"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"7a0546dd_cfe295e5","line":734,"range":{"start_line":733,"start_character":8,"end_line":734,"end_character":47},"updated":"2024-02-26 17:43:58.000000000","message":"nit: lun_info seems not necessary\n\n    return bool(lun_infos[0][\u0027SpaceAllocated\u0027])\n    \nalso what is the content of lun_infos?","commit_id":"afc3be5daf765047174acc58717e3f3d9d9e07f8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4a253da123a87423882acfb029b5185459c2583f","unresolved":true,"context_lines":[{"line_number":730,"context_line":"            seg \u003d path.split(\u0027/\u0027)"},{"line_number":731,"context_line":"            msg \u003d _(\u0027Failure getting LUN info for %s.\u0027)"},{"line_number":732,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg % seg[-1])"},{"line_number":733,"context_line":"        lun_info \u003d lun_infos[0]"},{"line_number":734,"context_line":"        return bool(lun_info[\u0027SpaceAllocated\u0027])"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"    def _get_lun_block_count(self, path):"},{"line_number":737,"context_line":"        \"\"\"Gets block counts for the LUN.\"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"dda171c0_73f3f602","line":734,"range":{"start_line":733,"start_character":8,"end_line":734,"end_character":47},"in_reply_to":"7a0546dd_cfe295e5","updated":"2024-02-28 22:17:05.000000000","message":"Also, unless I\u0027m misreading the logic here, at line 243, space_allocation contains a non-empty string, possibly \"false\", and that\u0027s what got stored in metadata[\u0027SpaceAllocated\u0027].  If that metadata dict is what\u0027s in lun_infos[0], then line 734 will return True even though the value is the string \"False\".","commit_id":"afc3be5daf765047174acc58717e3f3d9d9e07f8"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"b7df8a8e1b5f729d45c6d31673d5b0671e7edfa3","unresolved":false,"context_lines":[{"line_number":730,"context_line":"            seg \u003d path.split(\u0027/\u0027)"},{"line_number":731,"context_line":"            msg \u003d _(\u0027Failure getting LUN info for %s.\u0027)"},{"line_number":732,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg % seg[-1])"},{"line_number":733,"context_line":"        lun_info \u003d lun_infos[0]"},{"line_number":734,"context_line":"        return bool(lun_info[\u0027SpaceAllocated\u0027])"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"    def _get_lun_block_count(self, path):"},{"line_number":737,"context_line":"        \"\"\"Gets block counts for the LUN.\"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"7a3964a7_2ee4f7fc","line":734,"range":{"start_line":733,"start_character":8,"end_line":734,"end_character":47},"in_reply_to":"dda171c0_73f3f602","updated":"2024-03-02 19:13:31.000000000","message":"updated to use value directly. also, metadata[\u0027SpaceAllocated\u0027] always return string \"true\" or \"false\". Added function to return boolean value.","commit_id":"afc3be5daf765047174acc58717e3f3d9d9e07f8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e8db56e75bc0fb46c52e09e2c015ad7eb402092f","unresolved":true,"context_lines":[{"line_number":236,"context_line":"                    \u0027SpaceReserved\u0027: self.lun_space_reservation,"},{"line_number":237,"context_line":"                    \u0027Path\u0027: \u0027/vol/%s/%s\u0027 % (pool_name, lun_name)}"},{"line_number":238,"context_line":"        if space_allocation is True:"},{"line_number":239,"context_line":"            metadata[\u0027SpaceAllocated\u0027] \u003d str(space_allocation).lower()"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        qos_policy_group_info \u003d self._setup_qos_for_volume(volume, extra_specs)"},{"line_number":242,"context_line":"        qos_policy_group_name \u003d ("}],"source_content_type":"text/x-python","patch_set":22,"id":"85acb36b_09c8f87b","line":239,"updated":"2024-03-05 23:03:54.000000000","message":"OK, at line 227 space_allocation was set to a boolean value for sure, so I think you can just do what Rajat suggested and say \u0027if space_allocation:\u0027 for line 238.\n\nThe other thing is that I think your old code would set metadata[\u0027SpaceAllocated\u0027] to \u0027False\u0027 ... I just want to verify that in the case where space_allocated is False, you want to leave it out of the metadata dict entirely.  Is that correct?","commit_id":"bfeaad4a41d36aff7f5320e2c56709e57a77e7a3"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"ccb1d292a0e48e626c2a3552dd0888563f6e25ca","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                    \u0027SpaceReserved\u0027: self.lun_space_reservation,"},{"line_number":237,"context_line":"                    \u0027Path\u0027: \u0027/vol/%s/%s\u0027 % (pool_name, lun_name)}"},{"line_number":238,"context_line":"        if space_allocation is True:"},{"line_number":239,"context_line":"            metadata[\u0027SpaceAllocated\u0027] \u003d str(space_allocation).lower()"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        qos_policy_group_info \u003d self._setup_qos_for_volume(volume, extra_specs)"},{"line_number":242,"context_line":"        qos_policy_group_name \u003d ("}],"source_content_type":"text/x-python","patch_set":22,"id":"cf7d601a_0fe6caaf","line":239,"in_reply_to":"85acb36b_09c8f87b","updated":"2024-03-06 08:25:53.000000000","message":"updated logic to always pass this value to SpaceAllocation to avoid confusion.","commit_id":"bfeaad4a41d36aff7f5320e2c56709e57a77e7a3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e8db56e75bc0fb46c52e09e2c015ad7eb402092f","unresolved":true,"context_lines":[{"line_number":726,"context_line":"            seg \u003d path.split(\u0027/\u0027)"},{"line_number":727,"context_line":"            msg \u003d _(\u0027Failure getting LUN info for %s\u0027 % seg[-1])"},{"line_number":728,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":729,"context_line":"        return lun_infos[0][\u0027SpaceAllocated\u0027] \u003d\u003d \"true\""},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"    def _get_lun_block_count(self, path):"},{"line_number":732,"context_line":"        \"\"\"Gets block counts for the LUN.\"\"\""}],"source_content_type":"text/x-python","patch_set":22,"id":"f0b63343_971ee805","line":729,"updated":"2024-03-05 23:03:54.000000000","message":"OK, so this \u0027SpaceAllocated\u0027 is coming from the backend, so you are guaranteed that it will always be present and will always be \u0027true\u0027 or \u0027false\u0027 (as strings).  (Just checking.)","commit_id":"bfeaad4a41d36aff7f5320e2c56709e57a77e7a3"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"ccb1d292a0e48e626c2a3552dd0888563f6e25ca","unresolved":false,"context_lines":[{"line_number":726,"context_line":"            seg \u003d path.split(\u0027/\u0027)"},{"line_number":727,"context_line":"            msg \u003d _(\u0027Failure getting LUN info for %s\u0027 % seg[-1])"},{"line_number":728,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":729,"context_line":"        return lun_infos[0][\u0027SpaceAllocated\u0027] \u003d\u003d \"true\""},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"    def _get_lun_block_count(self, path):"},{"line_number":732,"context_line":"        \"\"\"Gets block counts for the LUN.\"\"\""}],"source_content_type":"text/x-python","patch_set":22,"id":"d0b47f50_c4ef8033","line":729,"in_reply_to":"f0b63343_971ee805","updated":"2024-03-06 08:25:53.000000000","message":"Current behavior without this change is disable by default. I updated message to reflect this information. Also, updated logic to always pass this value to SpaceAllocation to avoid confusion. Please refer below document for more information.\nhttps://docs.netapp.com/us-en/ontap/san-admin/enable-space-allocation-scsi-thin-provisioned-luns-task.html\n\"\nAbout this task\n\nThe space-allocation option is set to disabled by default, and you must take the LUN offline to enable space allocation. After you enable space allocation, you must perform discovery on the host before the host will recognize that space allocation has been enabled.\n\"","commit_id":"bfeaad4a41d36aff7f5320e2c56709e57a77e7a3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d6c49fb6d4c17ec337f380b1c707f448f1c8a735","unresolved":true,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        extra_specs \u003d na_utils.get_volume_extra_specs(volume)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        space_allocation \u003d volume_utils.is_boolean_str("},{"line_number":228,"context_line":"            extra_specs.get(\u0027netapp:space_allocation\u0027)"},{"line_number":229,"context_line":"        )"},{"line_number":230,"context_line":"        LOG.debug(\u0027create_volume space_allocation %r\u0027, space_allocation)"}],"source_content_type":"text/x-python","patch_set":24,"id":"fd61db6d_85078ced","line":227,"range":{"start_line":227,"start_character":40,"end_line":227,"end_character":54},"updated":"2024-03-06 10:55:43.000000000","message":"using this means we only allow values starting with \u003cis\u003e prefix\n\nhttps://opendev.org/openstack/cinder/src/branch/master/cinder/volume/volume_utils.py#L1026","commit_id":"48d922cf625c079c8338bf90a3d17f849df0c6b5"}],"cinder/volume/drivers/netapp/dataontap/client/client_base.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"579804a3a368a038901de28fbf432471f890d61c","unresolved":true,"context_lines":[{"line_number":131,"context_line":"                  \u0027ostype\u0027: metadata[\u0027OsType\u0027],"},{"line_number":132,"context_line":"                  \u0027space-reservation-enabled\u0027: space_reservation}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        if \"SpaceAllocated\" in metadata:"},{"line_number":135,"context_line":"            params[\u0027space-allocation-enabled\u0027] \u003d metadata[\u0027SpaceAllocated\u0027]"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        version \u003d self.get_ontapi_version()"},{"line_number":138,"context_line":"        if version \u003e\u003d (1, 110):"}],"source_content_type":"text/x-python","patch_set":10,"id":"580c9c0b_7605ecc1","line":135,"range":{"start_line":134,"start_character":7,"end_line":135,"end_character":75},"updated":"2023-09-06 12:53:41.000000000","message":"nice, this is the ZAPI implemnetation. Where is the REST implementation of this feature ? I","commit_id":"bd25788019c3fd1b8c86d521dfaa11c2513d5f7b"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"c77918230567219ad7dbce46dba1d20daef6157a","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                  \u0027ostype\u0027: metadata[\u0027OsType\u0027],"},{"line_number":132,"context_line":"                  \u0027space-reservation-enabled\u0027: space_reservation}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        if \"SpaceAllocated\" in metadata:"},{"line_number":135,"context_line":"            params[\u0027space-allocation-enabled\u0027] \u003d metadata[\u0027SpaceAllocated\u0027]"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        version \u003d self.get_ontapi_version()"},{"line_number":138,"context_line":"        if version \u003e\u003d (1, 110):"}],"source_content_type":"text/x-python","patch_set":10,"id":"a1c60791_f128fc6e","line":135,"range":{"start_line":134,"start_character":7,"end_line":135,"end_character":75},"in_reply_to":"580c9c0b_7605ecc1","updated":"2023-09-06 16:18:21.000000000","message":"REST also covered. Please look at updated code.","commit_id":"bd25788019c3fd1b8c86d521dfaa11c2513d5f7b"}],"releasenotes/notes/netapp-space-allocation-support-36a26aecc8fe1500.yaml":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"253ade78168bc1ac4b16e9b997a61fd8171946fc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"features:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    Space allocation is an important NetApp driver specific feature."},{"line_number":4,"context_line":"    This is very much required for the users to configure it on the"},{"line_number":5,"context_line":"    cinder volumes (LUNs in ONTAP) so that ONTAP and host can see"},{"line_number":6,"context_line":"    the actual space correctly when host deletes data. This also"},{"line_number":7,"context_line":"    notifies the host when the LUN cannot accept write due to"},{"line_number":8,"context_line":"    lack of space on the volume, and makes the LUN read-only"},{"line_number":9,"context_line":"    (rather then going offline)."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bdc5d87b_ec272da7","line":9,"range":{"start_line":3,"start_character":4,"end_line":9,"end_character":32},"updated":"2023-09-01 02:11:49.000000000","message":"I think this can be reworded better, I understand the need of emphasis on certain parts but we should be informative about what the end user will eventually get in the release.\n\nNetApp space allocation feature allows ONTAP and host to see the actual space correctly when host deletes data. It also notifies the host when the LUN cannot accept write data due to lack of space on the volume, and makes the LUN read-only (rather than going offline).\nThis feature can be enabled or disabled on cinder volumes by using volume type extra specs with the \\`\\`netapp:space_allocation\\`\\` property.","commit_id":"bca22013caece31926349d78d3e1b35152d44d90"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"e0c23ec1771d32a61f1a46a7d7073f8f6439870f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"features:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    Space allocation is an important NetApp driver specific feature."},{"line_number":4,"context_line":"    This is very much required for the users to configure it on the"},{"line_number":5,"context_line":"    cinder volumes (LUNs in ONTAP) so that ONTAP and host can see"},{"line_number":6,"context_line":"    the actual space correctly when host deletes data. This also"},{"line_number":7,"context_line":"    notifies the host when the LUN cannot accept write due to"},{"line_number":8,"context_line":"    lack of space on the volume, and makes the LUN read-only"},{"line_number":9,"context_line":"    (rather then going offline)."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5c26ff88_2d0688c0","line":9,"range":{"start_line":3,"start_character":4,"end_line":9,"end_character":32},"in_reply_to":"bdc5d87b_ec272da7","updated":"2023-09-01 13:57:27.000000000","message":"Thank you! For providing reworded text.Looks better than what we have. updated in release notes.","commit_id":"bca22013caece31926349d78d3e1b35152d44d90"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"579804a3a368a038901de28fbf432471f890d61c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"features:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    NetApp space allocation feature allows ONTAP and host to see the actual"},{"line_number":4,"context_line":"    space correctly when host deletes data. It also notifies the host when"},{"line_number":5,"context_line":"    the LUN cannot accept write data due to lack of space on the volume,"},{"line_number":6,"context_line":"    and makes the LUN read-only (rather than going offline)."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"35eebc00_3d729a45","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":11},"updated":"2023-09-06 12:53:41.000000000","message":"You should start the release note pointing to which NetApp drivers you are delivering this feature. From my understanding, it is not all (iSCSI, NFS, FCP and NVMe/TCP). Please, start with:\n\nNetApp \u003cprotocols\u003e drivers:","commit_id":"bd25788019c3fd1b8c86d521dfaa11c2513d5f7b"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"c77918230567219ad7dbce46dba1d20daef6157a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"features:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    NetApp space allocation feature allows ONTAP and host to see the actual"},{"line_number":4,"context_line":"    space correctly when host deletes data. It also notifies the host when"},{"line_number":5,"context_line":"    the LUN cannot accept write data due to lack of space on the volume,"},{"line_number":6,"context_line":"    and makes the LUN read-only (rather than going offline)."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5f44ab73_43ea3d8c","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":11},"in_reply_to":"35eebc00_3d729a45","updated":"2023-09-06 16:18:21.000000000","message":"FCP and iSCSI supported for ONTAP LUN. Updated description.","commit_id":"bd25788019c3fd1b8c86d521dfaa11c2513d5f7b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d6c49fb6d4c17ec337f380b1c707f448f1c8a735","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    to lack of space on the volume, and makes the LUN read-only"},{"line_number":7,"context_line":"    (rather than going offline). This feature can be enabled or"},{"line_number":8,"context_line":"    disabled on cinder volumes by using volume type extra specs with"},{"line_number":9,"context_line":"    the ``netapp:space_allocation`` property."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"eae12921_9fa1c5b1","line":9,"updated":"2024-03-06 10:55:43.000000000","message":"nit: we can mention the possible values in a followup,\n\nThe possible values for the option are ``\u003cis\u003e True`` and ``\u003cis\u003e False``","commit_id":"48d922cf625c079c8338bf90a3d17f849df0c6b5"}]}