)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"0ece78bc57cdcaf1c8b66779e3afed8ddda41693","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Alan Baghumian \u003calan.baghumian@canonical.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-09-02 22:58:02 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"LP# 1999706: Automatically map availability zones to volume types."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic17b43133460271df34659014cda1e8c7f235fd0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c54a7c76_e392379c","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":66},"updated":"2023-09-05 15:30:15.000000000","message":"Can you please rewrite this as follows:\n\nAutomatically map availability zones to volume types.\n\nCloses-Bug: #1999706","commit_id":"874997268a5316769d2a125e16abd029f25ad255"},{"author":{"_account_id":35648,"name":"Alan Baghumian","display_name":"Alan Baghumian","email":"alan.baghumian@canonical.com","username":"alanbach"},"change_message_id":"2cac24964bfc42cefba2dae9e4812fbf68c83f8c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alan Baghumian \u003calan.baghumian@canonical.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-09-02 22:58:02 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"LP# 1999706: Automatically map availability zones to volume types."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic17b43133460271df34659014cda1e8c7f235fd0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"aeef44b9_46c7d127","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":66},"in_reply_to":"c54a7c76_e392379c","updated":"2023-09-05 19:10:20.000000000","message":"Done","commit_id":"874997268a5316769d2a125e16abd029f25ad255"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"0ece78bc57cdcaf1c8b66779e3afed8ddda41693","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"619cc0a1_320ff616","updated":"2023-09-05 15:30:15.000000000","message":"Hi Alan, the first step here is to fixup your commit message and also run tox so you can see where it is failing (or look in the Zuul output). For example it is currently failing pep8 tests.","commit_id":"874997268a5316769d2a125e16abd029f25ad255"},{"author":{"_account_id":35648,"name":"Alan Baghumian","display_name":"Alan Baghumian","email":"alan.baghumian@canonical.com","username":"alanbach"},"change_message_id":"2cac24964bfc42cefba2dae9e4812fbf68c83f8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6eeb2dc3_ff7e9881","updated":"2023-09-05 19:10:20.000000000","message":"Applied fixes to make tox happy and updated the commit message as requested. Thanks much!","commit_id":"b1ec0896ca60e59893751a347c8b31c27975c9a0"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"1f782d753f222630a8a824d102587e57c95e512a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3a26b52b_8283d89a","updated":"2023-09-11 09:58:24.000000000","message":"I think you should add a release note for this change as this is related to Bug.","commit_id":"a381aeb4838dfdf489cc4370234f39351f9f0272"},{"author":{"_account_id":35648,"name":"Alan Baghumian","display_name":"Alan Baghumian","email":"alan.baghumian@canonical.com","username":"alanbach"},"change_message_id":"918d9d20a789faf22f02e94416a46693dc0a8b82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a61c76ac_53779bd7","updated":"2023-12-01 00:05:08.000000000","message":"Added reviewers from the previously abandoned review.","commit_id":"2da1cb293dfbddc1da6b3f0bf55ea3804b9a7817"}],"cinder/volume/flows/api/create_volume.py":[{"author":{"_account_id":35648,"name":"Alan Baghumian","display_name":"Alan Baghumian","email":"alan.baghumian@canonical.com","username":"alanbach"},"change_message_id":"2cac24964bfc42cefba2dae9e4812fbf68c83f8c","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        # in RESKEY:availability_zones specs"},{"line_number":433,"context_line":"        if availability_zone:"},{"line_number":434,"context_line":"            all_types \u003d volume_types.get_all_types(context,"},{"line_number":435,"context_line":"                filters\u003d{\u0027extra_specs\u0027: {\"RESKEY:availability_zones\": \"%\"}})"},{"line_number":436,"context_line":"            for vtype in all_types:"},{"line_number":437,"context_line":"                azs \u003d all_types[vtype][\u0027extra_specs\u0027][\u0027RESKEY:availability_zones\u0027].split(\u0027,\u0027)"},{"line_number":438,"context_line":"                for az in azs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"72aefb21_a1fad5de","line":435,"in_reply_to":"6a9f5793_89d5dcd4","updated":"2023-09-05 19:10:20.000000000","message":"\u003e pep8: E128 continuation line under-indented for visual indent\n\nPlease fix.","commit_id":"874997268a5316769d2a125e16abd029f25ad255"},{"author":{"_account_id":35648,"name":"Alan Baghumian","display_name":"Alan Baghumian","email":"alan.baghumian@canonical.com","username":"alanbach"},"change_message_id":"2cac24964bfc42cefba2dae9e4812fbf68c83f8c","unresolved":false,"context_lines":[{"line_number":434,"context_line":"            all_types \u003d volume_types.get_all_types(context,"},{"line_number":435,"context_line":"                filters\u003d{\u0027extra_specs\u0027: {\"RESKEY:availability_zones\": \"%\"}})"},{"line_number":436,"context_line":"            for vtype in all_types:"},{"line_number":437,"context_line":"                azs \u003d all_types[vtype][\u0027extra_specs\u0027][\u0027RESKEY:availability_zones\u0027].split(\u0027,\u0027)"},{"line_number":438,"context_line":"                for az in azs:"},{"line_number":439,"context_line":"                    if az \u003d\u003d availability_zone:"},{"line_number":440,"context_line":"                        return all_types[vtype]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ec6b3010_3f2f90ca","line":437,"in_reply_to":"bd36d58a_9dee999a","updated":"2023-09-05 19:10:20.000000000","message":"\u003e pep8: E501 line too long (93 \u003e 79 characters)\n\nPlease fix.","commit_id":"874997268a5316769d2a125e16abd029f25ad255"},{"author":{"_account_id":35648,"name":"Alan Baghumian","display_name":"Alan Baghumian","email":"alan.baghumian@canonical.com","username":"alanbach"},"change_message_id":"2cac24964bfc42cefba2dae9e4812fbf68c83f8c","unresolved":false,"context_lines":[{"line_number":484,"context_line":"            \u0027cinder_img_volume_type\u0027, None) if image_properties else None"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"        volume_type \u003d self._get_volume_type("},{"line_number":487,"context_line":"            context, volume_type, source_volume, snapshot, image_volume_type, availability_zone)"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"        volume_type_id \u003d volume_type.get(\u0027id\u0027) if volume_type else None"},{"line_number":490,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"78707f20_390caa16","line":487,"in_reply_to":"5b825271_3408c179","updated":"2023-09-05 19:10:20.000000000","message":"\u003e pep8: E501 line too long (96 \u003e 79 characters)\n\nPlease fix.","commit_id":"874997268a5316769d2a125e16abd029f25ad255"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"92eca9750723c5db887d7ddc7d2be17e51b7ece9","unresolved":true,"context_lines":[{"line_number":440,"context_line":"                azs \u003d extra_specs[\u0027RESKEY:availability_zones\u0027].split(\u0027,\u0027)"},{"line_number":441,"context_line":"                for az in azs:"},{"line_number":442,"context_line":"                    if az \u003d\u003d availability_zone:"},{"line_number":443,"context_line":"                        return volume_type"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"        # otherwise, use the default volume type"},{"line_number":446,"context_line":"        return volume_types.get_default_volume_type(context)"}],"source_content_type":"text/x-python","patch_set":5,"id":"aa76241f_edf3aa4b","line":443,"updated":"2024-01-10 11:57:30.000000000","message":"-1: Sorry, but I think this approach is not correct, as it can break the scheduling mechanism and it goes against the idea of what volume types are.\n\nA volume type is not a one-to-one mapping to a cinder storage backend.\nVolume types are either explicitly selected by the user or they are defaulted (to project or global default).\nFrom what I see in the bug report, that is a problem with how restrictive the configuration has been set.\nIf you change your default volume type to one that is not tied to a specific cinder backend, then the AZ request would be honored.","commit_id":"2da1cb293dfbddc1da6b3f0bf55ea3804b9a7817"}]}