)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2aed5ef861835ff5587a4e50fa1d4e48bb60f12d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8fcb4743_498564dc","updated":"2024-01-04 15:40:54.000000000","message":"LGTM only a minor improvement that I think can be done in the test","commit_id":"a752012c92bb15cf264c617bb2071958a32a8ad1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a9b056abc74896c60bfca6068e5940bcb4fe4eb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d6d8c598_1d184301","updated":"2024-01-04 17:16:13.000000000","message":"LGTM!","commit_id":"a752012c92bb15cf264c617bb2071958a32a8ad1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7c1b4099a8b86ac7afcb6aac024785cd382606ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ece8588b_e298b557","updated":"2024-01-05 10:13:39.000000000","message":"Thanks Gorka and Brian!","commit_id":"a752012c92bb15cf264c617bb2071958a32a8ad1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5a75965d91d44ad8fa70ea22611fbba5813e5eff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e9e4c6b5_f0a8bd80","updated":"2023-12-12 05:57:33.000000000","message":"recheck cinder-plugin-ceph-tempest failed deploying ceph\n\n2023-12-04 16:51:50.474740 | controller | /usr/bin/podman: stderr Trying to pull quay.io/ceph/ceph:v17.2...\n2023-12-04 16:51:50.474771 | controller | /usr/bin/podman: stderr Error: initializing source docker://quay.io/ceph/ceph:v17.2: can\u0027t talk to a V1 container registry\n2023-12-04 16:51:50.474905 | controller | ERROR: Failed command: /usr/bin/podman pull quay.io/ceph/ceph:v17.2\n2023-12-04 16:51:50.504052 | controller | + /opt/stack/devstack-plugin-ceph/devstack/lib/cephadm:start_ceph:1 :   exit_trap","commit_id":"a752012c92bb15cf264c617bb2071958a32a8ad1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ac6c89176597e290e7467553b0e83dc53c5e5dce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b14ecf75_94203222","updated":"2023-12-04 16:22:43.000000000","message":"recheck lvm-lio-barbican job failed with identity error","commit_id":"a752012c92bb15cf264c617bb2071958a32a8ad1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"756ec4d57a0d73ae4ba81a9a63f7730f75b9a524","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"37f71e86_b4b9aea5","updated":"2023-11-30 11:57:32.000000000","message":"recheck more tests failed in integrated storage job but looks unrelated","commit_id":"a752012c92bb15cf264c617bb2071958a32a8ad1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"aac7197a38cbbb4d86c6b2d8ef9507c3f975be3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b0388aa1_9f1ff600","updated":"2023-11-30 04:57:23.000000000","message":"recheck unrelated compute test failure in tempest-integrated-storage","commit_id":"a752012c92bb15cf264c617bb2071958a32a8ad1"}],"cinder/tests/unit/volume/test_volume_reimage.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2aed5ef861835ff5587a4e50fa1d4e48bb60f12d","unresolved":true,"context_lines":[{"line_number":113,"context_line":"    @ddt.data(\u0027available\u0027, \u0027error\u0027)"},{"line_number":114,"context_line":"    def test_volume_reimage_check_meta_exception(self, status, mock_reimage,"},{"line_number":115,"context_line":"                                                 mock_check):"},{"line_number":116,"context_line":"        volume \u003d tests_utils.create_volume(self.context)"},{"line_number":117,"context_line":"        volume.status \u003d status"},{"line_number":118,"context_line":"        volume.save()"},{"line_number":119,"context_line":"        self.assertEqual(volume.status, status)"},{"line_number":120,"context_line":"        mock_check.side_effect \u003d exception.ImageUnacceptable("},{"line_number":121,"context_line":"            image_id\u003dself.image_meta[\u0027id\u0027], reason\u003d\u0027\u0027)"},{"line_number":122,"context_line":"        # The available or error volume can be reimaged directly"}],"source_content_type":"text/x-python","patch_set":2,"id":"73a97f49_a011a090","line":119,"range":{"start_line":116,"start_character":0,"end_line":119,"end_character":47},"updated":"2024-01-04 15:40:54.000000000","message":"Doesn\u0027t it work in a single line?  Because it should work\n```\n  volume \u003d tests_utils.create_volume(self.context, status\u003dstatus)\n```","commit_id":"a752012c92bb15cf264c617bb2071958a32a8ad1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7c1b4099a8b86ac7afcb6aac024785cd382606ab","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    @ddt.data(\u0027available\u0027, \u0027error\u0027)"},{"line_number":114,"context_line":"    def test_volume_reimage_check_meta_exception(self, status, mock_reimage,"},{"line_number":115,"context_line":"                                                 mock_check):"},{"line_number":116,"context_line":"        volume \u003d tests_utils.create_volume(self.context)"},{"line_number":117,"context_line":"        volume.status \u003d status"},{"line_number":118,"context_line":"        volume.save()"},{"line_number":119,"context_line":"        self.assertEqual(volume.status, status)"},{"line_number":120,"context_line":"        mock_check.side_effect \u003d exception.ImageUnacceptable("},{"line_number":121,"context_line":"            image_id\u003dself.image_meta[\u0027id\u0027], reason\u003d\u0027\u0027)"},{"line_number":122,"context_line":"        # The available or error volume can be reimaged directly"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fe13c5c_5b661707","line":119,"range":{"start_line":116,"start_character":0,"end_line":119,"end_character":47},"in_reply_to":"73a97f49_a011a090","updated":"2024-01-05 10:13:39.000000000","message":"yes it does work, i used to existing test structure from other tests, which is not efficient LOC wise. updated all the places here https://review.opendev.org/c/openstack/cinder/+/904822","commit_id":"a752012c92bb15cf264c617bb2071958a32a8ad1"}],"cinder/volume/api.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"002380a4f214e389da2db41147cb7e04984c11a6","unresolved":true,"context_lines":[{"line_number":2677,"context_line":"        image_meta \u003d self.image_service.show(context, image_id)"},{"line_number":2678,"context_line":"        try:"},{"line_number":2679,"context_line":"            volume_utils.check_image_metadata(image_meta, volume[\u0027size\u0027])"},{"line_number":2680,"context_line":"        except (exception.InvalidInput, exception.ImageUnacceptable):"},{"line_number":2681,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":2682,"context_line":"                LOG.exception(\"Failed to reimage volume %(volume_id)s with \""},{"line_number":2683,"context_line":"                              \"image %(image_id)s\","}],"source_content_type":"text/x-python","patch_set":1,"id":"f965d144_4a2acdbf","line":2680,"updated":"2023-09-22 07:51:20.000000000","message":"-1: We should catch all exceptions to revert the state","commit_id":"6d5a9ab4e867de880590055a4d01bfad4a709424"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2585b2fa3a15173af4caba027e537a017b832a07","unresolved":false,"context_lines":[{"line_number":2677,"context_line":"        image_meta \u003d self.image_service.show(context, image_id)"},{"line_number":2678,"context_line":"        try:"},{"line_number":2679,"context_line":"            volume_utils.check_image_metadata(image_meta, volume[\u0027size\u0027])"},{"line_number":2680,"context_line":"        except (exception.InvalidInput, exception.ImageUnacceptable):"},{"line_number":2681,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":2682,"context_line":"                LOG.exception(\"Failed to reimage volume %(volume_id)s with \""},{"line_number":2683,"context_line":"                              \"image %(image_id)s\","}],"source_content_type":"text/x-python","patch_set":1,"id":"1d0f631c_31714ba9","line":2680,"in_reply_to":"e4125524_7b5a7537","updated":"2023-11-28 14:24:02.000000000","message":"Thanks Gorka and Brian, updated the patch with a comment.","commit_id":"6d5a9ab4e867de880590055a4d01bfad4a709424"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0dd4d410d149d567b6df5b3a4151b351fe33b55f","unresolved":true,"context_lines":[{"line_number":2677,"context_line":"        image_meta \u003d self.image_service.show(context, image_id)"},{"line_number":2678,"context_line":"        try:"},{"line_number":2679,"context_line":"            volume_utils.check_image_metadata(image_meta, volume[\u0027size\u0027])"},{"line_number":2680,"context_line":"        except (exception.InvalidInput, exception.ImageUnacceptable):"},{"line_number":2681,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":2682,"context_line":"                LOG.exception(\"Failed to reimage volume %(volume_id)s with \""},{"line_number":2683,"context_line":"                              \"image %(image_id)s\","}],"source_content_type":"text/x-python","patch_set":1,"id":"e4125524_7b5a7537","line":2680,"in_reply_to":"f965d144_4a2acdbf","updated":"2023-09-27 15:23:25.000000000","message":"Agree with Gorka.  Since we\u0027re going to re-raise, we won\u0027t be hiding any exceptions, and since we haven\u0027t actually done anything with the volume yet, it won\u0027t hurt to restore its previous status.","commit_id":"6d5a9ab4e867de880590055a4d01bfad4a709424"}]}