)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"994bc7871b2de922cb466b8bf5873cf1043bef5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"be8e1e1f_26cd973c","updated":"2023-10-27 15:40:16.000000000","message":"Please take a look at my alternative proposal and let me know if it satisfies your needs wrt. the bug. It retains the pipe, instead of adding p1.communicate() that reads it into a memory buffer.\n\nhttps://review.opendev.org/c/openstack/cinder/+/899488","commit_id":"3da81515cba413c8e97120646805a040241dee7a"},{"author":{"_account_id":33634,"name":"Jan Hartkopf","email":"j@hartkopf.io","username":"jhartkopf"},"change_message_id":"9b1f6ad9e351a5d3e41fe4922b63d90e0a28350a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d733e50c_42aa81d4","updated":"2023-11-06 12:32:29.000000000","message":"Thanks, Pete! The code looks sensible, I will try to test it and report back.","commit_id":"3da81515cba413c8e97120646805a040241dee7a"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"73748b056ef5543c1c6e88faa7455c4cd192154b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"632291a2_a9003d4a","updated":"2023-10-27 03:02:38.000000000","message":"There has to be a better way, please give me a few moments.","commit_id":"3da81515cba413c8e97120646805a040241dee7a"},{"author":{"_account_id":33634,"name":"Jan Hartkopf","email":"j@hartkopf.io","username":"jhartkopf"},"change_message_id":"f1445bbdd2a143b667e77a9b6dfe9b2b039cdb25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9289972c_8a4841dd","in_reply_to":"be8e1e1f_26cd973c","updated":"2023-11-22 13:56:23.000000000","message":"I have now tested your adapted change and it looks good! I will squash your change into mine.","commit_id":"3da81515cba413c8e97120646805a040241dee7a"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"bdf4ffdd6e805b3153c676e2a22549a796d58a5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1245f270_3f7c609e","updated":"2023-12-18 10:36:05.000000000","message":"A release note may be required.","commit_id":"c308e997d68878089cf6c42abdca31dba5be39e4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0145a0a3c856660886cb1b219e75548fc514b47a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"94db5dca_39001931","updated":"2024-01-15 18:06:12.000000000","message":"this requires a releasenote with a fixes section, you can refer to this section for help https://docs.openstack.org/cinder/latest/contributor/releasenotes.html#bugs","commit_id":"c308e997d68878089cf6c42abdca31dba5be39e4"},{"author":{"_account_id":33634,"name":"Jan Hartkopf","email":"j@hartkopf.io","username":"jhartkopf"},"change_message_id":"15d8fbd721613fc3fc65f436ee070445b6192e70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"81164992_8ddbc65c","in_reply_to":"94db5dca_39001931","updated":"2024-01-16 14:36:21.000000000","message":"Done","commit_id":"c308e997d68878089cf6c42abdca31dba5be39e4"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"e70604fab189cc585ff84f81a72177e891332233","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"100ede0f_ac737f47","updated":"2024-01-16 14:43:03.000000000","message":"(release note was updated)","commit_id":"f8e13a883d961a4a5ba1cf6f557a96ebe6f540ad"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"6e207cd4415b5f33fe6130117a5f0ead5b00d081","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"042bc72c_e6e8a06a","updated":"2024-02-08 09:02:00.000000000","message":"Any change someone might Workflow+1 this one?","commit_id":"f8e13a883d961a4a5ba1cf6f557a96ebe6f540ad"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"b962787eb0a5c98a7bee595b20f672e80f8909ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2b8a5f43_8ace7106","updated":"2024-03-28 07:07:08.000000000","message":"Could anybody please consider merging this?","commit_id":"f8e13a883d961a4a5ba1cf6f557a96ebe6f540ad"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"bbb92b58e6dcc8a52f3e3c6824760a0d653a1ed0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3390b06c_2e7fc406","updated":"2024-03-20 13:52:13.000000000","message":"Is there anything keeping this from being merged?","commit_id":"f8e13a883d961a4a5ba1cf6f557a96ebe6f540ad"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"9dbbdaf5ab2badc472c19b0213befd3e08a4e601","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"47fdf2b7_be4c0f9d","updated":"2024-01-26 11:12:54.000000000","message":"LGTM, thks.","commit_id":"f8e13a883d961a4a5ba1cf6f557a96ebe6f540ad"},{"author":{"_account_id":33634,"name":"Jan Hartkopf","email":"j@hartkopf.io","username":"jhartkopf"},"change_message_id":"48f05236fc3e4546810cbc17b37edcf10a507afd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0a3d3eb2_f8b42c58","updated":"2024-01-17 10:31:57.000000000","message":"recheck grenade","commit_id":"f8e13a883d961a4a5ba1cf6f557a96ebe6f540ad"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"d0ab4e8a9892a12c59e63bfc440320673750372a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8d8ee249_660db538","updated":"2024-01-17 06:14:45.000000000","message":"recheck tempest-integrated-storage\nCode change and UT look good.","commit_id":"f8e13a883d961a4a5ba1cf6f557a96ebe6f540ad"}],"cinder/backup/drivers/ceph.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"73748b056ef5543c1c6e88faa7455c4cd192154b","unresolved":true,"context_lines":[{"line_number":644,"context_line":"            raise"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"        p1.stdout.close()"},{"line_number":647,"context_line":"        _, p1_stderr \u003d p1.communicate()"},{"line_number":648,"context_line":"        _, p2_stderr \u003d p2.communicate()"},{"line_number":649,"context_line":"        return p1.returncode or p2.returncode, p1_stderr, p2_stderr"},{"line_number":650,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"27bacb3e_77167331","line":647,"updated":"2023-10-27 03:02:38.000000000","message":"This cannot possibly be right. I loads the whole stdout into memory. You\u0027re losing the effect of piping the diff.","commit_id":"3da81515cba413c8e97120646805a040241dee7a"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"2b273a4d6e0c54b9fe344bee7bfb79e1dc0fc84d","unresolved":false,"context_lines":[{"line_number":644,"context_line":"            raise"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"        p1.stdout.close()"},{"line_number":647,"context_line":"        _, p1_stderr \u003d p1.communicate()"},{"line_number":648,"context_line":"        _, p2_stderr \u003d p2.communicate()"},{"line_number":649,"context_line":"        return p1.returncode or p2.returncode, p1_stderr, p2_stderr"},{"line_number":650,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"d2c0bab0_d132fc6f","line":647,"in_reply_to":"27bacb3e_77167331","updated":"2024-01-24 10:37:55.000000000","message":"Done","commit_id":"3da81515cba413c8e97120646805a040241dee7a"}]}