)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"883213f93469b319da659b15e09917a75a7568aa","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     David Hill \u003cdhill@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-10-04 09:27:58 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix data_reduction parameter discovery on pool_data"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix data_reduction parameter discovery on pool_data"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c4d2a298_90d4eda9","line":7,"updated":"2023-10-04 14:21:34.000000000","message":"The subject line should reference the driver, so add \"[IBM SvF]\" prefix. SvF is the name they\u0027re calling the driver now.","commit_id":"49911fbe577b921e323e6a9527bae2d3adea45e1"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"883213f93469b319da659b15e09917a75a7568aa","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix data_reduction parameter discovery on pool_data"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix data_reduction parameter discovery on pool_data"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Idf730563c71c841a4661d7a4d3a06c0f459fc70e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0110af19_6a1473ab","line":9,"updated":"2023-10-04 14:21:34.000000000","message":"This needs further explanation. You could state the storage array can return \"True|False\" or \"Yes|No\" depending on the version, and both responses need to be interpreted correctly.","commit_id":"49911fbe577b921e323e6a9527bae2d3adea45e1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"883213f93469b319da659b15e09917a75a7568aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6ef8551d_2759aa4d","updated":"2023-10-04 14:21:34.000000000","message":"This needs unit test coverage and a release note. Ideally it should also reference a LP bug, which would facilitate backporting the fix to stable releases.","commit_id":"49911fbe577b921e323e6a9527bae2d3adea45e1"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"8718de2e3b46ae08a34b0809ef502254087cddc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a7581a93_173737ab","updated":"2023-10-04 14:25:29.000000000","message":"See my previous comments.","commit_id":"3facaba15f45115f3751a88a4d6515109fcb8c2e"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"883213f93469b319da659b15e09917a75a7568aa","unresolved":true,"context_lines":[{"line_number":5987,"context_line":""},{"line_number":5988,"context_line":"            # Get the data_reduction information for pool and set"},{"line_number":5989,"context_line":"            # is_dr_pool flag."},{"line_number":5990,"context_line":"            is_dr_pool \u003d pool_data.get(\u0027data_reduction\u0027, False)"},{"line_number":5991,"context_line":"            if is_dr_pool \u003d\u003d \u0027no\u0027:"},{"line_number":5992,"context_line":"               is_dr_pool \u003d False"},{"line_number":5993,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"05c25c17_7474ff17","line":5990,"updated":"2023-10-04 14:21:34.000000000","message":"This won\u0027t work because pool_data[\u0027data_reduction\u0027] is a string, not a boolean. Both \u0027No\u0027 and \u0027False\u0027 would evaluate as a boolean True.\n\nIt seems their firmware returns a mix of \u0027Yes\u0027 and \u0027True (or \u0027No\u0027 and \u0027False\u0027) depending on the model/firmware.\n\nSomething like this should cover all possibilities:\n\n           is_dr_pool \u003d pool_data.get(\u0027data_reduction\u0027, \u0027False\u0027).lower() in [\u0027true\u0027, \u0027yes\u0027]","commit_id":"49911fbe577b921e323e6a9527bae2d3adea45e1"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"e9b42139a216b93001b41315a4a9569342db5ce8","unresolved":false,"context_lines":[{"line_number":5987,"context_line":""},{"line_number":5988,"context_line":"            # Get the data_reduction information for pool and set"},{"line_number":5989,"context_line":"            # is_dr_pool flag."},{"line_number":5990,"context_line":"            is_dr_pool \u003d pool_data.get(\u0027data_reduction\u0027, False)"},{"line_number":5991,"context_line":"            if is_dr_pool \u003d\u003d \u0027no\u0027:"},{"line_number":5992,"context_line":"               is_dr_pool \u003d False"},{"line_number":5993,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"355577be_5aef5d76","line":5990,"in_reply_to":"05c25c17_7474ff17","updated":"2023-10-04 15:41:56.000000000","message":"Yeah I did another patch (or a few other patches after this one).","commit_id":"49911fbe577b921e323e6a9527bae2d3adea45e1"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"03ae4afb0d823b14ab796802693ace5a24e29987","unresolved":true,"context_lines":[{"line_number":849,"context_line":""},{"line_number":850,"context_line":"        pool_data \u003d self.get_pool_attrs(pool_name)"},{"line_number":851,"context_line":"        if (pool_data and \u0027data_reduction\u0027 in pool_data and"},{"line_number":852,"context_line":"                pool_data[\u0027data_reduction\u0027]):"},{"line_number":853,"context_line":"            return True"},{"line_number":854,"context_line":"        return False"},{"line_number":855,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1bebf917_482758d6","line":852,"updated":"2023-10-04 14:53:29.000000000","message":"-1: Like Alan said, you need to parse this because it\u0027s a string, not a boolean (this comes from a SSH call)\n\nYou can import at the beginning of the file:\n\n  from oslo_utils import strutils\n\nAnd then:\n\n  return strutils.bool_from_string(pool_data.get(\u0027data_reduction\u0027, False))\n\nAnd that will accept yes, no, true, false, etc, as mentioned here: https://github.com/openstack/oslo.utils/blob/a122f5c065c346c9ca2218a9131a2a352e6b380f/oslo_utils/strutils.py#L142C5-L142C21","commit_id":"b272da9cf80df0f3fa05ed0599eee55aec44a36a"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"e9b42139a216b93001b41315a4a9569342db5ce8","unresolved":false,"context_lines":[{"line_number":849,"context_line":""},{"line_number":850,"context_line":"        pool_data \u003d self.get_pool_attrs(pool_name)"},{"line_number":851,"context_line":"        if (pool_data and \u0027data_reduction\u0027 in pool_data and"},{"line_number":852,"context_line":"                pool_data[\u0027data_reduction\u0027]):"},{"line_number":853,"context_line":"            return True"},{"line_number":854,"context_line":"        return False"},{"line_number":855,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"96b7cce2_ef721597","line":852,"in_reply_to":"1bebf917_482758d6","updated":"2023-10-04 15:41:56.000000000","message":"I didn\u0027t know about strutils.bool_from_string... hopefully my lastest patch is satisfying.   It gives a very long line so I hacked my way around it.","commit_id":"b272da9cf80df0f3fa05ed0599eee55aec44a36a"}]}