)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9b14e4badae4eb536e8406ddd6ca1ad049ebc65e","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding test cases for recently merged replication-enabled consistency groups feature"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Related: #891234"},{"line_number":12,"context_line":"Change-Id: I3964cac87a933a256064c332c68b312705ca7e0c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"6abe7c4f_849c6ede","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":16},"updated":"2023-10-11 17:46:31.000000000","message":"this should be\n\nRelated-Bug: #891234\n\nRefer to this section for more info\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references","commit_id":"ce0f4fb423d06671adeeb7e1c59783de8cf7474a"},{"author":{"_account_id":35316,"name":"Keerthivasan S","email":"ksuresh@purestorage.com","username":"keerthivasan"},"change_message_id":"bca7f12eafa9b9766d6800b5e6eb36d7786094df","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding test cases for recently merged replication-enabled consistency groups feature"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Related: #891234"},{"line_number":12,"context_line":"Change-Id: I3964cac87a933a256064c332c68b312705ca7e0c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"425146b7_f558a3f6","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":16},"in_reply_to":"6abe7c4f_849c6ede","updated":"2023-10-11 20:46:40.000000000","message":"As discussed mentioned related change id","commit_id":"ce0f4fb423d06671adeeb7e1c59783de8cf7474a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c6c1ed9b354936ea16599acb0a4459113b997994","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2050a294_0c509dac","updated":"2023-10-05 13:45:40.000000000","message":"recheck","commit_id":"c19fd616492a57eb4dc934378abde0916a161165"},{"author":{"_account_id":35316,"name":"Keerthivasan S","email":"ksuresh@purestorage.com","username":"keerthivasan"},"change_message_id":"41f1e7d2b4f98d5d60470ba88b65f505c1c22eab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7a8d4e20_435dc780","updated":"2023-10-05 08:29:58.000000000","message":"recheck","commit_id":"c19fd616492a57eb4dc934378abde0916a161165"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"ddc379af3875bb0c5cfc0c9b204fa81014c41f5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"08a0b522_28941eb7","updated":"2023-10-05 14:05:30.000000000","message":"Unit tests as promised...","commit_id":"8aa6410292f7e53049839f6c98fdbaaccc6bcf9e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b2cffc242d4abadd51cf14c87bd6d02034664c3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cfa1f293_baded3d2","updated":"2023-10-09 11:06:27.000000000","message":"few comments inline","commit_id":"8aa6410292f7e53049839f6c98fdbaaccc6bcf9e"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"2ba4c7e68470d6c1ee63774fae8c36d2f3471fbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"078e4a5c_2d6f2621","updated":"2023-10-06 03:56:53.000000000","message":"recheck","commit_id":"8aa6410292f7e53049839f6c98fdbaaccc6bcf9e"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"45319375a5755997855c95efffb2106c354236b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9ebc6f13_ca5866f7","updated":"2023-10-06 00:50:35.000000000","message":"recheck","commit_id":"8aa6410292f7e53049839f6c98fdbaaccc6bcf9e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9b14e4badae4eb536e8406ddd6ca1ad049ebc65e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"38dd1035_68d53a10","updated":"2023-10-11 17:46:31.000000000","message":"If we see the coverage report[1], there are few sections of new code that are still not being tested.\nMostly are exception clauses or else statement but good to get every scenario covered at least in the UTs.\n\n[1] https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_76f/897382/4/check/cinder-code-coverage/76fb56b/cover/d_2751295e1ac4fa14_pure_py.html","commit_id":"ce0f4fb423d06671adeeb7e1c59783de8cf7474a"},{"author":{"_account_id":35316,"name":"Keerthivasan S","email":"ksuresh@purestorage.com","username":"keerthivasan"},"change_message_id":"cbf102a81001e913496c0d456331c1497b6c3a48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ac43d776_a6e27d4f","updated":"2023-10-11 14:51:00.000000000","message":"Review comments are addressed","commit_id":"ce0f4fb423d06671adeeb7e1c59783de8cf7474a"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"77becf1d4b41011600c85470a06e910be5158274","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"dde18956_85587c76","updated":"2023-10-11 17:33:21.000000000","message":"recheck","commit_id":"ce0f4fb423d06671adeeb7e1c59783de8cf7474a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6ae5b85522bef22dc0969a5c1979476309a880a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d043e2f6_a6b2bd39","updated":"2023-10-17 07:33:51.000000000","message":"This looks pretty close, we should highlight the code change in the commit message","commit_id":"f9ce1d80da2da8fdfa3a053643a741256364fdfb"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"07f28253237722959e6d3c840ff467008c6468ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4e9f02ed_cc6f78e1","updated":"2023-10-11 23:54:12.000000000","message":"recheck","commit_id":"f9ce1d80da2da8fdfa3a053643a741256364fdfb"},{"author":{"_account_id":35316,"name":"Keerthivasan S","email":"ksuresh@purestorage.com","username":"keerthivasan"},"change_message_id":"83e4d291b33166bb59ae165660dbea888ab2272d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8efca902_7253b1bb","updated":"2023-10-12 08:52:30.000000000","message":"recheck","commit_id":"f9ce1d80da2da8fdfa3a053643a741256364fdfb"},{"author":{"_account_id":35316,"name":"Keerthivasan S","email":"ksuresh@purestorage.com","username":"keerthivasan"},"change_message_id":"97e23115b4c5b347ee92a27a855b0cb1cdb4c3cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c5a6d297_b0a14ef1","updated":"2023-10-12 05:02:15.000000000","message":"recheck","commit_id":"f9ce1d80da2da8fdfa3a053643a741256364fdfb"},{"author":{"_account_id":35316,"name":"Keerthivasan S","email":"ksuresh@purestorage.com","username":"keerthivasan"},"change_message_id":"36d28aea1e73285c4b3e8395c61331054c943eab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"faa514d5_bf2fda41","updated":"2023-10-17 11:15:42.000000000","message":"Addressed issues from review, please check.","commit_id":"ca3fcebcb491906e7d955eda75b58667f024b676"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"a86fdc3c52a6b6b0d42d0afb4b6bc2d60fa92c82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b922224f_9d4c981f","updated":"2023-10-18 19:38:01.000000000","message":"Group snapshots has already merged, this is a follow on to that patch.  Code and tests look good to me.","commit_id":"ca3fcebcb491906e7d955eda75b58667f024b676"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"f1f3a36c5724aae5cbd694d0da82cb25bd084d2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"595db67e_82ce9b25","updated":"2023-10-17 11:58:31.000000000","message":"LGTM","commit_id":"ca3fcebcb491906e7d955eda75b58667f024b676"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"26e777e55713450bd1104726aef0bc585f428372","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f24b45bb_d78a00c6","updated":"2023-10-17 11:20:23.000000000","message":"LGTM! thanks","commit_id":"ca3fcebcb491906e7d955eda75b58667f024b676"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"8400e6bfce51b7dd37aae475a366df742d97f239","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"10e8f650_cae75568","updated":"2023-10-19 01:15:21.000000000","message":"recheck","commit_id":"ca3fcebcb491906e7d955eda75b58667f024b676"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"46196143be451fcde94bf7883f8d3be590d1ab0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"223e50ce_111d8f70","updated":"2023-10-20 02:36:57.000000000","message":"recheck","commit_id":"ca3fcebcb491906e7d955eda75b58667f024b676"},{"author":{"_account_id":35316,"name":"Keerthivasan S","email":"ksuresh@purestorage.com","username":"keerthivasan"},"change_message_id":"6b24d4535e518e0b846eab657b9cbb5306b50655","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2cb29169_53661c1f","updated":"2023-10-25 12:27:57.000000000","message":"recheck","commit_id":"ca3fcebcb491906e7d955eda75b58667f024b676"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"51e81010364428bd848c1ced5ce339523aa8e155","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3dae8f03_7ac77dff","updated":"2023-10-19 23:44:32.000000000","message":"recheck","commit_id":"ca3fcebcb491906e7d955eda75b58667f024b676"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"d3a879b955767c479942cd80cbd508eb42a87cbe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"45709658_9c81a30b","updated":"2023-10-17 23:11:38.000000000","message":"recheck","commit_id":"ca3fcebcb491906e7d955eda75b58667f024b676"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"42494c7831c7094712352b82405e98c067071b5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6b2b0562_6e75639f","updated":"2023-10-24 12:47:52.000000000","message":"recheck","commit_id":"ca3fcebcb491906e7d955eda75b58667f024b676"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"b8deb03bb417db7a16cb7fc5a3af4c19de750352","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"76d7d46f_732f11c2","updated":"2023-10-20 21:26:59.000000000","message":"recheck","commit_id":"ca3fcebcb491906e7d955eda75b58667f024b676"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"d8bb677287df9c870a22543812c0fdd8161d826e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7a673fc4_564d8973","updated":"2023-10-17 13:44:24.000000000","message":"recheck","commit_id":"ca3fcebcb491906e7d955eda75b58667f024b676"},{"author":{"_account_id":35316,"name":"Keerthivasan S","email":"ksuresh@purestorage.com","username":"keerthivasan"},"change_message_id":"e0f7eed8d08aa0f92e90bf83927d1d341823504a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7c9fbb6c_eb36d51d","updated":"2023-10-25 04:40:36.000000000","message":"recheck","commit_id":"ca3fcebcb491906e7d955eda75b58667f024b676"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"9e858db0b2cbc193bd4dbdb2616ae7c780fc340f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"943dbefd_3b579216","updated":"2023-10-19 09:02:27.000000000","message":"recheck","commit_id":"ca3fcebcb491906e7d955eda75b58667f024b676"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"badb51fefbd49cac50a42d248123857d9960dc45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"95a2b0fe_fdbdc878","updated":"2023-10-18 01:55:51.000000000","message":"recheck","commit_id":"ca3fcebcb491906e7d955eda75b58667f024b676"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"f15e3e873cb8b4e49d49ef02794f09b9284bd244","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"967330da_abc456ce","updated":"2023-10-23 18:41:24.000000000","message":"recheck","commit_id":"ca3fcebcb491906e7d955eda75b58667f024b676"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"82666be6a84e2c810c661c3a88a7b341d7634747","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a55cafc4_d37d947c","updated":"2023-10-23 21:15:12.000000000","message":"recheck","commit_id":"ca3fcebcb491906e7d955eda75b58667f024b676"},{"author":{"_account_id":35316,"name":"Keerthivasan S","email":"ksuresh@purestorage.com","username":"keerthivasan"},"change_message_id":"39ea0329d5797d03f050ecc529a9bcdc7e113aba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e142af20_c26b36d0","updated":"2023-10-19 12:23:24.000000000","message":"recheck","commit_id":"ca3fcebcb491906e7d955eda75b58667f024b676"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"7990846a3bada3ae8d390ae546640e4698f2a472","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e40f78bd_020385da","updated":"2023-10-19 04:45:34.000000000","message":"recheck","commit_id":"ca3fcebcb491906e7d955eda75b58667f024b676"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"bb499a1f6325b71a057f694fa75f2eb6a2ecb85e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f50ef85d_4f9117d9","updated":"2023-10-24 17:54:37.000000000","message":"recheck","commit_id":"ca3fcebcb491906e7d955eda75b58667f024b676"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c3620eff8bbf528c31554823f30f00caa23b89be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fe7a61b9_870109be","updated":"2023-10-24 02:06:47.000000000","message":"recheck","commit_id":"ca3fcebcb491906e7d955eda75b58667f024b676"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"bdc1de53e1c3cf052bc630b36c92bce4231c277f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1897c70e_73d501bc","updated":"2023-10-20 21:52:08.000000000","message":"run Pure Storage CI","commit_id":"ca3fcebcb491906e7d955eda75b58667f024b676"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"b3396509a60a864214649ea016ef8bf25e416105","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"31aa3af7_db14488a","updated":"2023-10-23 19:32:45.000000000","message":"run Pure Storage CI","commit_id":"ca3fcebcb491906e7d955eda75b58667f024b676"}],"cinder/tests/unit/volume/drivers/test_pure.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b2cffc242d4abadd51cf14c87bd6d02034664c3b","unresolved":true,"context_lines":[{"line_number":4548,"context_line":"        mock_is_repl.return_value \u003d True"},{"line_number":4549,"context_line":"        group \u003d fake_group.fake_group_type_obj(None)"},{"line_number":4550,"context_line":"        group.volume_type_ids \u003d [fake.GROUP_ID]"},{"line_number":4551,"context_line":"        self.driver._is_replication_enabled \u003d True"},{"line_number":4552,"context_line":"        output \u003d self.driver.create_group(None, group)"},{"line_number":4553,"context_line":"        self.assertEqual(output, {\u0027status\u0027: \u0027available\u0027})"},{"line_number":4554,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"e9814ce7_5c135ab2","line":4551,"range":{"start_line":4551,"start_character":8,"end_line":4551,"end_character":50},"updated":"2023-10-09 11:06:27.000000000","message":"should we reset these values to their default so they don\u0027t affect other tests in parallel execution?","commit_id":"8aa6410292f7e53049839f6c98fdbaaccc6bcf9e"},{"author":{"_account_id":35316,"name":"Keerthivasan S","email":"ksuresh@purestorage.com","username":"keerthivasan"},"change_message_id":"cbf102a81001e913496c0d456331c1497b6c3a48","unresolved":false,"context_lines":[{"line_number":4548,"context_line":"        mock_is_repl.return_value \u003d True"},{"line_number":4549,"context_line":"        group \u003d fake_group.fake_group_type_obj(None)"},{"line_number":4550,"context_line":"        group.volume_type_ids \u003d [fake.GROUP_ID]"},{"line_number":4551,"context_line":"        self.driver._is_replication_enabled \u003d True"},{"line_number":4552,"context_line":"        output \u003d self.driver.create_group(None, group)"},{"line_number":4553,"context_line":"        self.assertEqual(output, {\u0027status\u0027: \u0027available\u0027})"},{"line_number":4554,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"f77c93d1_35fc351c","line":4551,"range":{"start_line":4551,"start_character":8,"end_line":4551,"end_character":50},"in_reply_to":"e9814ce7_5c135ab2","updated":"2023-10-11 14:51:00.000000000","message":"reset done as suggested","commit_id":"8aa6410292f7e53049839f6c98fdbaaccc6bcf9e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b2cffc242d4abadd51cf14c87bd6d02034664c3b","unresolved":true,"context_lines":[{"line_number":4550,"context_line":"        group.volume_type_ids \u003d [fake.GROUP_ID]"},{"line_number":4551,"context_line":"        self.driver._is_replication_enabled \u003d True"},{"line_number":4552,"context_line":"        output \u003d self.driver.create_group(None, group)"},{"line_number":4553,"context_line":"        self.assertEqual(output, {\u0027status\u0027: \u0027available\u0027})"},{"line_number":4554,"context_line":""},{"line_number":4555,"context_line":"    @mock.patch(BASE_DRIVER_OBJ + \"._group_potential_repl_types\")"},{"line_number":4556,"context_line":"    @mock.patch(\u0027cinder.objects.volume_type.VolumeType.get_by_name_or_id\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"f398ad08_125b40b0","line":4553,"range":{"start_line":4553,"start_character":25,"end_line":4553,"end_character":56},"updated":"2023-10-09 11:06:27.000000000","message":"the format we use across UTs is (expected, actual) so we should change the order here","commit_id":"8aa6410292f7e53049839f6c98fdbaaccc6bcf9e"},{"author":{"_account_id":35316,"name":"Keerthivasan S","email":"ksuresh@purestorage.com","username":"keerthivasan"},"change_message_id":"cbf102a81001e913496c0d456331c1497b6c3a48","unresolved":false,"context_lines":[{"line_number":4550,"context_line":"        group.volume_type_ids \u003d [fake.GROUP_ID]"},{"line_number":4551,"context_line":"        self.driver._is_replication_enabled \u003d True"},{"line_number":4552,"context_line":"        output \u003d self.driver.create_group(None, group)"},{"line_number":4553,"context_line":"        self.assertEqual(output, {\u0027status\u0027: \u0027available\u0027})"},{"line_number":4554,"context_line":""},{"line_number":4555,"context_line":"    @mock.patch(BASE_DRIVER_OBJ + \"._group_potential_repl_types\")"},{"line_number":4556,"context_line":"    @mock.patch(\u0027cinder.objects.volume_type.VolumeType.get_by_name_or_id\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1781b3ff_bc69ca4d","line":4553,"range":{"start_line":4553,"start_character":25,"end_line":4553,"end_character":56},"in_reply_to":"f398ad08_125b40b0","updated":"2023-10-11 14:51:00.000000000","message":"Order changed","commit_id":"8aa6410292f7e53049839f6c98fdbaaccc6bcf9e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b2cffc242d4abadd51cf14c87bd6d02034664c3b","unresolved":true,"context_lines":[{"line_number":4572,"context_line":"        mock_is_repl.return_value \u003d True"},{"line_number":4573,"context_line":"        group \u003d fake_group.fake_group_type_obj(None)"},{"line_number":4574,"context_line":"        group.volume_type_ids \u003d [fake.GROUP_ID]"},{"line_number":4575,"context_line":"        self.driver._is_replication_enabled \u003d True"},{"line_number":4576,"context_line":"        output \u003d self.driver.create_group(None, group)"},{"line_number":4577,"context_line":"        self.assertEqual(output, {\u0027status\u0027: \u0027error\u0027})"},{"line_number":4578,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"951d63d5_751e21e0","line":4575,"range":{"start_line":4575,"start_character":8,"end_line":4575,"end_character":50},"updated":"2023-10-09 11:06:27.000000000","message":"same","commit_id":"8aa6410292f7e53049839f6c98fdbaaccc6bcf9e"},{"author":{"_account_id":35316,"name":"Keerthivasan S","email":"ksuresh@purestorage.com","username":"keerthivasan"},"change_message_id":"cbf102a81001e913496c0d456331c1497b6c3a48","unresolved":false,"context_lines":[{"line_number":4572,"context_line":"        mock_is_repl.return_value \u003d True"},{"line_number":4573,"context_line":"        group \u003d fake_group.fake_group_type_obj(None)"},{"line_number":4574,"context_line":"        group.volume_type_ids \u003d [fake.GROUP_ID]"},{"line_number":4575,"context_line":"        self.driver._is_replication_enabled \u003d True"},{"line_number":4576,"context_line":"        output \u003d self.driver.create_group(None, group)"},{"line_number":4577,"context_line":"        self.assertEqual(output, {\u0027status\u0027: \u0027error\u0027})"},{"line_number":4578,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b8c00a12_61c125be","line":4575,"range":{"start_line":4575,"start_character":8,"end_line":4575,"end_character":50},"in_reply_to":"951d63d5_751e21e0","updated":"2023-10-11 14:51:00.000000000","message":"reset done as suggested","commit_id":"8aa6410292f7e53049839f6c98fdbaaccc6bcf9e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b2cffc242d4abadd51cf14c87bd6d02034664c3b","unresolved":true,"context_lines":[{"line_number":4574,"context_line":"        group.volume_type_ids \u003d [fake.GROUP_ID]"},{"line_number":4575,"context_line":"        self.driver._is_replication_enabled \u003d True"},{"line_number":4576,"context_line":"        output \u003d self.driver.create_group(None, group)"},{"line_number":4577,"context_line":"        self.assertEqual(output, {\u0027status\u0027: \u0027error\u0027})"},{"line_number":4578,"context_line":""},{"line_number":4579,"context_line":"    @mock.patch(\u0027cinder.volume.volume_utils.is_group_a_cg_snapshot_type\u0027)"},{"line_number":4580,"context_line":"    def test_create_group(self, mock_is_cg):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a9fba95_c29b282b","line":4577,"range":{"start_line":4577,"start_character":25,"end_line":4577,"end_character":52},"updated":"2023-10-09 11:06:27.000000000","message":"same","commit_id":"8aa6410292f7e53049839f6c98fdbaaccc6bcf9e"},{"author":{"_account_id":35316,"name":"Keerthivasan S","email":"ksuresh@purestorage.com","username":"keerthivasan"},"change_message_id":"cbf102a81001e913496c0d456331c1497b6c3a48","unresolved":false,"context_lines":[{"line_number":4574,"context_line":"        group.volume_type_ids \u003d [fake.GROUP_ID]"},{"line_number":4575,"context_line":"        self.driver._is_replication_enabled \u003d True"},{"line_number":4576,"context_line":"        output \u003d self.driver.create_group(None, group)"},{"line_number":4577,"context_line":"        self.assertEqual(output, {\u0027status\u0027: \u0027error\u0027})"},{"line_number":4578,"context_line":""},{"line_number":4579,"context_line":"    @mock.patch(\u0027cinder.volume.volume_utils.is_group_a_cg_snapshot_type\u0027)"},{"line_number":4580,"context_line":"    def test_create_group(self, mock_is_cg):"}],"source_content_type":"text/x-python","patch_set":2,"id":"62c88794_e67dd562","line":4577,"range":{"start_line":4577,"start_character":25,"end_line":4577,"end_character":52},"in_reply_to":"7a9fba95_c29b282b","updated":"2023-10-11 14:51:00.000000000","message":"Order changed","commit_id":"8aa6410292f7e53049839f6c98fdbaaccc6bcf9e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6ae5b85522bef22dc0969a5c1979476309a880a6","unresolved":true,"context_lines":[{"line_number":1832,"context_line":"            if \u0027addtargetlist\u0027 in kwargs:"},{"line_number":1833,"context_line":"                raise pure.purestorage.\\"},{"line_number":1834,"context_line":"                    PureHTTPError(code\u003dhttp.client.BAD_REQUEST,"},{"line_number":1835,"context_line":"                                  text\u003d\u0027ERR_MSG_ALREADY_INCLUDES\u0027)"},{"line_number":1836,"context_line":"            elif \u0027pgroup_name_on_target\u0027 in kwargs:"},{"line_number":1837,"context_line":"                raise pure.purestorage.\\"},{"line_number":1838,"context_line":"                    PureHTTPError(code\u003dhttp.client.BAD_REQUEST,"}],"source_content_type":"text/x-python","patch_set":6,"id":"a11a083a_439b6a5a","line":1835,"range":{"start_line":1835,"start_character":40,"end_line":1835,"end_character":64},"updated":"2023-10-17 07:33:51.000000000","message":"I don\u0027t think we are asserting these specific error messages anywhere and the exception raised and checked in both cases is PureHTTPError so does these error messages really make a difference in the test? Would be good to have this asserted as well","commit_id":"f9ce1d80da2da8fdfa3a053643a741256364fdfb"},{"author":{"_account_id":35316,"name":"Keerthivasan S","email":"ksuresh@purestorage.com","username":"keerthivasan"},"change_message_id":"36d28aea1e73285c4b3e8395c61331054c943eab","unresolved":false,"context_lines":[{"line_number":1832,"context_line":"            if \u0027addtargetlist\u0027 in kwargs:"},{"line_number":1833,"context_line":"                raise pure.purestorage.\\"},{"line_number":1834,"context_line":"                    PureHTTPError(code\u003dhttp.client.BAD_REQUEST,"},{"line_number":1835,"context_line":"                                  text\u003d\u0027ERR_MSG_ALREADY_INCLUDES\u0027)"},{"line_number":1836,"context_line":"            elif \u0027pgroup_name_on_target\u0027 in kwargs:"},{"line_number":1837,"context_line":"                raise pure.purestorage.\\"},{"line_number":1838,"context_line":"                    PureHTTPError(code\u003dhttp.client.BAD_REQUEST,"}],"source_content_type":"text/x-python","patch_set":6,"id":"69f88b71_96fd977f","line":1835,"range":{"start_line":1835,"start_character":40,"end_line":1835,"end_character":64},"in_reply_to":"a11a083a_439b6a5a","updated":"2023-10-17 11:15:42.000000000","message":"Added test to assert text messages","commit_id":"f9ce1d80da2da8fdfa3a053643a741256364fdfb"}],"cinder/volume/drivers/pure.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9b14e4badae4eb536e8406ddd6ca1ad049ebc65e","unresolved":true,"context_lines":[{"line_number":248,"context_line":"        self._replication_retention_long_term \u003d None"},{"line_number":249,"context_line":"        self._replication_retention_long_term_per_day \u003d None"},{"line_number":250,"context_line":"        self._async_replication_retention_policy \u003d None"},{"line_number":251,"context_line":"        self._retention_policy \u003d {}"},{"line_number":252,"context_line":"        self._is_replication_enabled \u003d False"},{"line_number":253,"context_line":"        self._is_active_cluster_enabled \u003d False"},{"line_number":254,"context_line":"        self._is_trisync_enabled \u003d False"}],"source_content_type":"text/x-python","patch_set":4,"id":"edd58829_3c3410ba","line":251,"range":{"start_line":251,"start_character":8,"end_line":251,"end_character":35},"updated":"2023-10-11 17:46:31.000000000","message":"sorry i missed this out on earlier review but why are we adding this?","commit_id":"ce0f4fb423d06671adeeb7e1c59783de8cf7474a"},{"author":{"_account_id":35316,"name":"Keerthivasan S","email":"ksuresh@purestorage.com","username":"keerthivasan"},"change_message_id":"bca7f12eafa9b9766d6800b5e6eb36d7786094df","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        self._replication_retention_long_term \u003d None"},{"line_number":249,"context_line":"        self._replication_retention_long_term_per_day \u003d None"},{"line_number":250,"context_line":"        self._async_replication_retention_policy \u003d None"},{"line_number":251,"context_line":"        self._retention_policy \u003d {}"},{"line_number":252,"context_line":"        self._is_replication_enabled \u003d False"},{"line_number":253,"context_line":"        self._is_active_cluster_enabled \u003d False"},{"line_number":254,"context_line":"        self._is_trisync_enabled \u003d False"}],"source_content_type":"text/x-python","patch_set":4,"id":"adc09d39_594b1810","line":251,"range":{"start_line":251,"start_character":8,"end_line":251,"end_character":35},"in_reply_to":"edd58829_3c3410ba","updated":"2023-10-11 20:46:40.000000000","message":"Called out right functions and set vars accordingly.","commit_id":"ce0f4fb423d06671adeeb7e1c59783de8cf7474a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6ae5b85522bef22dc0969a5c1979476309a880a6","unresolved":true,"context_lines":[{"line_number":1173,"context_line":"        if grp_type:"},{"line_number":1174,"context_line":"            current_array.set_pgroup("},{"line_number":1175,"context_line":"                pg_name,"},{"line_number":1176,"context_line":"                **self._async_replication_retention_policy"},{"line_number":1177,"context_line":"            )"},{"line_number":1178,"context_line":"            # Configure replication propagation frequency on a"},{"line_number":1179,"context_line":"            # protection group."}],"source_content_type":"text/x-python","patch_set":6,"id":"87cb85bb_29b04929","line":1176,"updated":"2023-10-17 07:33:51.000000000","message":"would be good to mention this change in commit message, currently it only refers to adding UTs","commit_id":"f9ce1d80da2da8fdfa3a053643a741256364fdfb"},{"author":{"_account_id":35316,"name":"Keerthivasan S","email":"ksuresh@purestorage.com","username":"keerthivasan"},"change_message_id":"36d28aea1e73285c4b3e8395c61331054c943eab","unresolved":false,"context_lines":[{"line_number":1173,"context_line":"        if grp_type:"},{"line_number":1174,"context_line":"            current_array.set_pgroup("},{"line_number":1175,"context_line":"                pg_name,"},{"line_number":1176,"context_line":"                **self._async_replication_retention_policy"},{"line_number":1177,"context_line":"            )"},{"line_number":1178,"context_line":"            # Configure replication propagation frequency on a"},{"line_number":1179,"context_line":"            # protection group."}],"source_content_type":"text/x-python","patch_set":6,"id":"39db84f7_e036b9e0","line":1176,"in_reply_to":"87cb85bb_29b04929","updated":"2023-10-17 11:15:42.000000000","message":"Details mentioned in commit message","commit_id":"f9ce1d80da2da8fdfa3a053643a741256364fdfb"}]}