)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"0ed73649e6ab2e07d886f338b2f89ad9cd1eae76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a679a0e8_9a20a857","updated":"2023-10-23 12:05:15.000000000","message":"LGTM","commit_id":"a57f6fb829d4f630529596aaeb7888efc1bc65ea"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5549d38517fab263ff1d5b490e1737fe7d220745","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3eb49f41_4e6057d7","updated":"2023-12-15 21:20:16.000000000","message":"LGTM, and one of the NEC developers has give it a +1.","commit_id":"a57f6fb829d4f630529596aaeb7888efc1bc65ea"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"10159c70ee6b19797ecad04b4f2ec42ea3228b6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"17e81e65_8da7aad4","updated":"2023-11-17 14:38:47.000000000","message":"LGTM. few questions inline.","commit_id":"a57f6fb829d4f630529596aaeb7888efc1bc65ea"},{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"b8f9d3ca01584e6026c5bb98ffc0b70e8a33d987","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"deaf94a6_d13aa837","updated":"2023-10-11 11:54:16.000000000","message":"Looks good to me, thank you!","commit_id":"a57f6fb829d4f630529596aaeb7888efc1bc65ea"}],"cinder/tests/unit/volume/drivers/nec/v/test_internal_nec_rest_fc.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"10159c70ee6b19797ecad04b4f2ec42ea3228b6d","unresolved":true,"context_lines":[{"line_number":447,"context_line":"            hbsd_rest._LUN_RETRY_INTERVAL)"},{"line_number":448,"context_line":"        self.configuration.nec_v_restore_timeout \u003d hbsd_rest._RESTORE_TIMEOUT"},{"line_number":449,"context_line":"        self.configuration.nec_v_state_transition_timeout \u003d ("},{"line_number":450,"context_line":"            hbsd_rest._STATE_TRANSITION_TIMEOUT)"},{"line_number":451,"context_line":"        self.configuration.nec_v_lock_timeout \u003d hbsd_rest_api._LOCK_TIMEOUT"},{"line_number":452,"context_line":"        self.configuration.nec_v_rest_timeout \u003d hbsd_rest_api._REST_TIMEOUT"},{"line_number":453,"context_line":"        self.configuration.nec_v_extend_timeout \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"36d17efc_4c929b15","side":"PARENT","line":450,"range":{"start_line":450,"start_character":22,"end_line":450,"end_character":47},"updated":"2023-11-17 14:38:47.000000000","message":"the default value is (15 * 60) which is 900 secs","commit_id":"aa91cf149e73201df1511e487b0ce0227e834912"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"10159c70ee6b19797ecad04b4f2ec42ea3228b6d","unresolved":true,"context_lines":[{"line_number":449,"context_line":"        self.configuration.nec_v_state_transition_timeout \u003d ("},{"line_number":450,"context_line":"            hbsd_rest._STATE_TRANSITION_TIMEOUT)"},{"line_number":451,"context_line":"        self.configuration.nec_v_lock_timeout \u003d hbsd_rest_api._LOCK_TIMEOUT"},{"line_number":452,"context_line":"        self.configuration.nec_v_rest_timeout \u003d hbsd_rest_api._REST_TIMEOUT"},{"line_number":453,"context_line":"        self.configuration.nec_v_extend_timeout \u003d ("},{"line_number":454,"context_line":"            hbsd_rest_api._EXTEND_TIMEOUT)"},{"line_number":455,"context_line":"        self.configuration.nec_v_exec_retry_interval \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"53eba446_0ca46b3a","side":"PARENT","line":452,"range":{"start_line":452,"start_character":62,"end_line":452,"end_character":75},"updated":"2023-11-17 14:38:47.000000000","message":"the default value is 30 secs","commit_id":"aa91cf149e73201df1511e487b0ce0227e834912"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"10159c70ee6b19797ecad04b4f2ec42ea3228b6d","unresolved":true,"context_lines":[{"line_number":445,"context_line":"        self.configuration.nec_v_lun_timeout \u003d hbsd_rest._LUN_TIMEOUT"},{"line_number":446,"context_line":"        self.configuration.nec_v_lun_retry_interval \u003d ("},{"line_number":447,"context_line":"            hbsd_rest._LUN_RETRY_INTERVAL)"},{"line_number":448,"context_line":"        self.configuration.nec_v_restore_timeout \u003d hbsd_rest._RESTORE_TIMEOUT"},{"line_number":449,"context_line":"        self.configuration.nec_v_state_transition_timeout \u003d 2"},{"line_number":450,"context_line":"        self.configuration.nec_v_lock_timeout \u003d hbsd_rest_api._LOCK_TIMEOUT"},{"line_number":451,"context_line":"        self.configuration.nec_v_rest_timeout \u003d 3"}],"source_content_type":"text/x-python","patch_set":1,"id":"2fc4a99a_a3fadb84","line":448,"range":{"start_line":448,"start_character":61,"end_line":448,"end_character":77},"updated":"2023-11-17 14:38:47.000000000","message":"same case 24 * 60 * 60 \u003d 86400 secs","commit_id":"a57f6fb829d4f630529596aaeb7888efc1bc65ea"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"10159c70ee6b19797ecad04b4f2ec42ea3228b6d","unresolved":true,"context_lines":[{"line_number":447,"context_line":"            hbsd_rest._LUN_RETRY_INTERVAL)"},{"line_number":448,"context_line":"        self.configuration.nec_v_restore_timeout \u003d hbsd_rest._RESTORE_TIMEOUT"},{"line_number":449,"context_line":"        self.configuration.nec_v_state_transition_timeout \u003d 2"},{"line_number":450,"context_line":"        self.configuration.nec_v_lock_timeout \u003d hbsd_rest_api._LOCK_TIMEOUT"},{"line_number":451,"context_line":"        self.configuration.nec_v_rest_timeout \u003d 3"},{"line_number":452,"context_line":"        self.configuration.nec_v_extend_timeout \u003d ("},{"line_number":453,"context_line":"            hbsd_rest_api._EXTEND_TIMEOUT)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dbd003ec_f46987d7","line":450,"range":{"start_line":450,"start_character":62,"end_line":450,"end_character":75},"updated":"2023-11-17 14:38:47.000000000","message":"do we require these values as default? it\u0027s default is much higher : 2 * 60 * 60 \u003d 7200 secs","commit_id":"a57f6fb829d4f630529596aaeb7888efc1bc65ea"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5549d38517fab263ff1d5b490e1737fe7d220745","unresolved":true,"context_lines":[{"line_number":615,"context_line":""},{"line_number":616,"context_line":"    @reduce_retrying_time"},{"line_number":617,"context_line":"    @mock.patch.object(requests.Session, \"request\")"},{"line_number":618,"context_line":"    def test_create_volume_timeout(self, request):"},{"line_number":619,"context_line":"        request.return_value \u003d FakeResponse("},{"line_number":620,"context_line":"            500, ERROR_RESULT,"},{"line_number":621,"context_line":"            headers\u003d{\u0027Content-Type\u0027: \u0027json\u0027})"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1e053a_f795c222","line":618,"updated":"2023-12-15 21:20:16.000000000","message":"The hitachi driver handles this by explicitly overriding the config values in the test.  (Not saying that you should do that too, I was just wondering why we haven\u0027t seen the same slowness problem with the hitachi driver that this nec driver is based on.)","commit_id":"a57f6fb829d4f630529596aaeb7888efc1bc65ea"}]}