)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"1e387b027a424562ae7faa5bb4e016b15de0833d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     cuiyeliu \u003ccuiye.liu@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-01-05 10:28:18 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell PowerMax : Fix the function of Dell PowerMax live migration without a pool name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change is to update the live migration ability in environments using Dell PowerMax. In previous 2023.1 version, the live migration fails without a pool name."},{"line_number":10,"context_line":"This update fixes the ability of live migration without a pool name."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"d694a4f5_844b555f","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":84},"updated":"2024-02-22 07:00:24.000000000","message":"Line 7: exceed 50 characters","commit_id":"9dce114ad6a8d6320630e0dc1ba8ed9994b30480"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"2f8b8d773d706c6124fbf79b0bdf0b61e38d5423","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     cuiyeliu \u003ccuiye.liu@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-01-05 10:28:18 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell PowerMax : Fix the function of Dell PowerMax live migration without a pool name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change is to update the live migration ability in environments using Dell PowerMax. In previous 2023.1 version, the live migration fails without a pool name."},{"line_number":10,"context_line":"This update fixes the ability of live migration without a pool name."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"5fb0acd9_183ded29","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":84},"in_reply_to":"d694a4f5_844b555f","updated":"2024-02-27 02:59:26.000000000","message":"Resolved","commit_id":"9dce114ad6a8d6320630e0dc1ba8ed9994b30480"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"1e387b027a424562ae7faa5bb4e016b15de0833d","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell PowerMax : Fix the function of Dell PowerMax live migration without a pool name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change is to update the live migration ability in environments using Dell PowerMax. In previous 2023.1 version, the live migration fails without a pool name."},{"line_number":10,"context_line":"This update fixes the ability of live migration without a pool name."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #2034937"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"8e412da0_452a0be0","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":162},"updated":"2024-02-22 07:00:24.000000000","message":"Line 9: exceed 72 characters","commit_id":"9dce114ad6a8d6320630e0dc1ba8ed9994b30480"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"2f8b8d773d706c6124fbf79b0bdf0b61e38d5423","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell PowerMax : Fix the function of Dell PowerMax live migration without a pool name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change is to update the live migration ability in environments using Dell PowerMax. In previous 2023.1 version, the live migration fails without a pool name."},{"line_number":10,"context_line":"This update fixes the ability of live migration without a pool name."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #2034937"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"7f7116fb_b8561b77","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":162},"in_reply_to":"8e412da0_452a0be0","updated":"2024-02-27 02:59:26.000000000","message":"Resolved","commit_id":"9dce114ad6a8d6320630e0dc1ba8ed9994b30480"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8a5974e714742fa1ecaa13c879afb7776e68c01e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     cuiyeliu \u003ccuiye.liu@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-03-01 03:16:01 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the function of DELL PowerMax live migration"},{"line_number":8,"context_line":"without a pool name"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This change is to update the live migration ability in environments"},{"line_number":11,"context_line":"using PowerMax. In previous 2023.1 version, the live migration fails"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"e70ceedb_cdb96c1f","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":19},"updated":"2024-03-18 06:45:39.000000000","message":"The next line after header line is usually empty.\nThese two lines can be phrased as single line:\nPowerMax: Allow live migration without pool name","commit_id":"23b856955332013b40f417a8fe73915cbc03d624"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"b99ec1f3cb689e4ab4cd44fd20625c4c2467b7f6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     cuiyeliu \u003ccuiye.liu@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-03-01 03:16:01 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the function of DELL PowerMax live migration"},{"line_number":8,"context_line":"without a pool name"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This change is to update the live migration ability in environments"},{"line_number":11,"context_line":"using PowerMax. In previous 2023.1 version, the live migration fails"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"769a2168_91a016d9","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":19},"in_reply_to":"e70ceedb_cdb96c1f","updated":"2024-03-20 09:25:13.000000000","message":"Thans for you advece.Corrected.","commit_id":"23b856955332013b40f417a8fe73915cbc03d624"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8a5974e714742fa1ecaa13c879afb7776e68c01e","unresolved":true,"context_lines":[{"line_number":12,"context_line":"without a pool name."},{"line_number":13,"context_line":"The update adds the ability of live migration without a pool name."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Iad767cd516c8527136508470629236f68e0c7cc2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"01c75ed9_4b628c65","line":15,"updated":"2024-03-18 06:45:39.000000000","message":"Before Change-Id, below line can be added:\nCloses-Bug: #2034937","commit_id":"23b856955332013b40f417a8fe73915cbc03d624"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"b99ec1f3cb689e4ab4cd44fd20625c4c2467b7f6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"without a pool name."},{"line_number":13,"context_line":"The update adds the ability of live migration without a pool name."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Iad767cd516c8527136508470629236f68e0c7cc2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"d6970ddf_7ce06735","line":15,"in_reply_to":"01c75ed9_4b628c65","updated":"2024-03-20 09:25:13.000000000","message":"Has added the bug info.","commit_id":"23b856955332013b40f417a8fe73915cbc03d624"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"23f89c78fc33eb75fdf7d06f842cb34b1bb182b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8f9b5dc0_a1212ac4","updated":"2023-10-17 11:51:50.000000000","message":"You have PEP8 issues + few comments.","commit_id":"bd775cb1eae7dfd25a535199ad48ef062aa71814"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"29b686f521f3161b56a2e29cbbd681502ce288c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1e04205c_c83ef08d","updated":"2023-11-17 09:50:50.000000000","message":"If this a bug fix, the bug should be mentioned in the commit message\n\nTitle would be more adequate: Fix live migration when a pool name is not specifed or something similar.","commit_id":"c12037cc4fb294bf5a1319cd9297245328ccb980"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"6174e3951cb85d18e4d671ffa702d9f11073c056","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1985db40_bfc31bb0","updated":"2023-11-17 09:17:19.000000000","message":"recheck","commit_id":"c12037cc4fb294bf5a1319cd9297245328ccb980"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"6166635378e90cbd1f857782154d022979c870a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4b0c9a22_7b9dc9c4","updated":"2023-11-17 13:42:59.000000000","message":"There are two release notes. remove one.\nAdd the bug link in the description.","commit_id":"1ac4271d2752b3e89adfbdc7842fc0776f0b2039"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"dfd7f51eeb26859c86617c242c7f69202886d704","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3e22d6ba_2e743a2e","updated":"2023-11-21 03:31:28.000000000","message":"recheck","commit_id":"52d346a679ce53aa46185ff26fe1ccc37b2d88f2"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"885b2617e287dfdac1899386bc7c992eeb7489ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"88917ff0_914f3c44","updated":"2023-11-20 17:57:20.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican failures","commit_id":"52d346a679ce53aa46185ff26fe1ccc37b2d88f2"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"dfd7f51eeb26859c86617c242c7f69202886d704","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"232f8ff6_9a120ac1","in_reply_to":"88917ff0_914f3c44","updated":"2023-11-21 03:31:28.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican","commit_id":"52d346a679ce53aa46185ff26fe1ccc37b2d88f2"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"58e4ec2a28bfaafee152ec21e0a74df0d18aac46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"f4b53ca6_7e3e8e15","updated":"2023-11-21 13:54:59.000000000","message":"Resolved","commit_id":"0977a7cd2c9958c5f15a4982e57f1ae9991d88ec"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"27df1d50325caa3913cf103a0bded18e3dac65b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"a149cda4_64d2ef23","updated":"2023-11-22 07:57:55.000000000","message":"Zuul still failing. Please check.","commit_id":"0977a7cd2c9958c5f15a4982e57f1ae9991d88ec"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"f715e4c1f5b94af8927ff64d413e154c58c5174c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"144e66a6_350f35a9","updated":"2023-11-21 14:14:58.000000000","message":"resolved","commit_id":"0977a7cd2c9958c5f15a4982e57f1ae9991d88ec"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"3490c5b39318f0d98e5d023f11fb8c4baac253ff","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":15,"id":"cf35d70c_7a020ba0","updated":"2023-11-21 13:55:50.000000000","message":"resolved","commit_id":"0977a7cd2c9958c5f15a4982e57f1ae9991d88ec"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"7b6c8e6eaad8438b9498c90c55cad2af6f5f7e50","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ee0c19db_82fb3d42","in_reply_to":"cf35d70c_7a020ba0","updated":"2023-11-21 14:14:24.000000000","message":"a","commit_id":"0977a7cd2c9958c5f15a4982e57f1ae9991d88ec"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"f715e4c1f5b94af8927ff64d413e154c58c5174c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"36ff8ed4_779e2d8e","in_reply_to":"ee0c19db_82fb3d42","updated":"2023-11-21 14:14:58.000000000","message":"Done","commit_id":"0977a7cd2c9958c5f15a4982e57f1ae9991d88ec"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"d1064b561fe0924e2c0dd1e7c7c62a30a378877d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"476ef8be_0413c6b5","updated":"2023-11-28 02:28:21.000000000","message":"recheck","commit_id":"1d5decee8e6d053b567c1be806697f36019be61b"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"fa94b448ed16a00a23e6d566d0b288f92a890f87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"701008a5_5176cff5","updated":"2023-11-25 02:19:21.000000000","message":"recheck","commit_id":"1d5decee8e6d053b567c1be806697f36019be61b"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"c9b15de207e822c92c5ad6f7951b7573d2f9737e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"05d49320_f2afe99c","updated":"2023-12-04 10:43:29.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"1d5decee8e6d053b567c1be806697f36019be61b"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"6f699fc336b4ce5a1dc3c3b476349805d3df0e0c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"ebd613fd_5c8307aa","updated":"2024-02-22 06:58:21.000000000","message":"Minor comments in the commit message.\nAnd please engage with e-lab to run PowerMax CI.","commit_id":"9dce114ad6a8d6320630e0dc1ba8ed9994b30480"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"fd005e2a0fc5aeadb9aedc512c85eb247cafdc7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"824aad5c_00acb1fb","updated":"2024-01-22 13:37:22.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican failure","commit_id":"9dce114ad6a8d6320630e0dc1ba8ed9994b30480"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"2aad498a28e270e42695c2ca7dd2b7d5f1c77465","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"a90fbe7d_86793b14","in_reply_to":"02b44f4a_c21540f8","updated":"2024-02-28 03:22:52.000000000","message":"recheck","commit_id":"9dce114ad6a8d6320630e0dc1ba8ed9994b30480"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"3e2210f654fe465384fdd2be464aacba4b87cd51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"577f4554_71f67e6d","in_reply_to":"a90fbe7d_86793b14","updated":"2024-03-01 02:48:30.000000000","message":"recheck cinder-plugin-ceph-tempest and cinder-plugin-ceph-tempest-mn-aa","commit_id":"9dce114ad6a8d6320630e0dc1ba8ed9994b30480"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"059947c24371f5a110bc067e07dcb23329574359","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"02b44f4a_c21540f8","in_reply_to":"ebd613fd_5c8307aa","updated":"2024-02-27 03:14:11.000000000","message":"Resolved","commit_id":"9dce114ad6a8d6320630e0dc1ba8ed9994b30480"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"2f8b8d773d706c6124fbf79b0bdf0b61e38d5423","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"94d4de5c_f5786b13","updated":"2024-02-27 02:59:26.000000000","message":"Resolved","commit_id":"dc79d087b461ed662b8037d3b0968f039e57d460"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"1249698894b8e9af7324f607bb3063b421e06ec6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"cd0a5d6a_c59d1e68","updated":"2024-03-13 17:36:19.000000000","message":"I\u0027m okay with this. The magic constant is in the pre-existing code.","commit_id":"23b856955332013b40f417a8fe73915cbc03d624"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8a5974e714742fa1ecaa13c879afb7776e68c01e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"395fcff6_0bda0c0b","updated":"2024-03-18 06:45:39.000000000","message":"Zuul and PowerMax CI have passed. Code change and UT look good.\nMinor comment in commit message.","commit_id":"23b856955332013b40f417a8fe73915cbc03d624"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"a9dc4536439fd2f0a6b089a18700af466bae7cb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"bf129e09_6ac70ffe","updated":"2024-03-01 06:13:57.000000000","message":"recheck","commit_id":"23b856955332013b40f417a8fe73915cbc03d624"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"0994908a8ca885bc12556430cb7a73bd743872b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"eb178e7d_969ce9fc","updated":"2024-03-04 02:20:29.000000000","message":"recheck cinder-plugin-ceph-tempest-mn-aa failure","commit_id":"23b856955332013b40f417a8fe73915cbc03d624"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"a5573d963826b81dd89f8ba6a735da2c3e621efe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"dc0ce534_05c615f8","updated":"2024-03-01 11:10:21.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican failure","commit_id":"23b856955332013b40f417a8fe73915cbc03d624"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"6320a2a0b51981739244865263646c9d9cec5af4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"b2df5274_80ab34b7","updated":"2024-03-04 09:05:23.000000000","message":"recheck devstack-plugin-nfs-tempest-full-fips failure","commit_id":"23b856955332013b40f417a8fe73915cbc03d624"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"9fdb1d1f9211747def8ccbd7bbce4e55d4c742d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"4ace6546_cc108a7a","updated":"2024-03-07 02:49:09.000000000","message":"resolved","commit_id":"23b856955332013b40f417a8fe73915cbc03d624"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"2020104c9e0779099c9253e53acb4557db5dd855","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"aa230533_d4b56aff","updated":"2024-03-07 02:49:53.000000000","message":"resolved","commit_id":"23b856955332013b40f417a8fe73915cbc03d624"},{"author":{"_account_id":17450,"name":"Chongchong Lei","email":"Nathaniel.Lei@dell.com","username":"Chongchong","status":"Dell EMC"},"change_message_id":"c472013b39dcf51991ec7204a7450eb4b46afa81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"129c105c_328bc22e","updated":"2024-03-11 13:15:25.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"23b856955332013b40f417a8fe73915cbc03d624"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"6e39cc83cabc3012e15fba015ded63dd7b4c4019","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"51dbc83d_aedeaf4d","updated":"2024-03-20 09:50:24.000000000","message":"My comment has been addressed. Thanks.","commit_id":"747a81ebce6676a1ce6d0bafa795551f74008ea6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2c80e696d7068f00fbb4b7e2c390eeed3176319c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"4e8cfc52_4b6d247a","updated":"2024-03-26 02:01:52.000000000","message":"Question inline.","commit_id":"747a81ebce6676a1ce6d0bafa795551f74008ea6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f53f99064cb237578eceaceff387cfb3cfe9b0b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"32319449_4b054f8c","updated":"2024-03-27 14:38:35.000000000","message":"All my concerns have been addressed.  Agree with Rajat that we can count the third party CI passing on PS22 for PS24.","commit_id":"9a470d41f4d2cd389a0f85e461d87ed5a3a664e3"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"994c75dc9c7229d5bcdb05a8d91e23806f98e585","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"ed9e3287_b597daa4","updated":"2024-03-28 07:46:11.000000000","message":"Created cherry pick: https://review.opendev.org/c/openstack/cinder/+/914582","commit_id":"9a470d41f4d2cd389a0f85e461d87ed5a3a664e3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7932405cf8df981d8ac9d431d19af655d91fdf82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"603d569f_02f515e3","updated":"2024-03-27 11:01:56.000000000","message":"code and tests LGTM.\nLooks like Brian\u0027s comments are addressed.\npowermax CI has passed on previous patchset and there hasn\u0027t been any major changes in the code.","commit_id":"9a470d41f4d2cd389a0f85e461d87ed5a3a664e3"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"c7896965ac66a75bc865c23b1dd1c48a775cd31e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"2d824531_95d8631a","updated":"2024-03-28 02:17:49.000000000","message":"recheck cinder-plugin-ceph-tempest","commit_id":"9a470d41f4d2cd389a0f85e461d87ed5a3a664e3"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"3df665160920d572cc8598a93e452f6b11c9c2e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"1086dcf6_575e883e","updated":"2024-03-27 13:52:07.000000000","message":"recheck openstack-tox-py312","commit_id":"9a470d41f4d2cd389a0f85e461d87ed5a3a664e3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"80d2e768c65808d3972ffd82bd9336e30993616b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"71a86e42_5fde3e83","updated":"2024-03-27 11:00:38.000000000","message":"recheck py312 failed since asyncore import failed\n\n2024-03-26 09:27:24.294298 | debian-bookworm |   File \"/home/zuul/src/opendev.org/openstack/cinder/.tox/py312/lib/python3.12/site-packages/taskflow/engines/action_engine/process_executor.py\", line 17, in \u003cmodule\u003e\n2024-03-26 09:27:24.349384 | debian-bookworm |     import asyncore\n2024-03-26 09:27:24.349444 | debian-bookworm | ModuleNotFoundError: No module named \u0027asyncore\u0027\n\nlet\u0027s see if there is a dependency change recently in taskflow or our requirements","commit_id":"9a470d41f4d2cd389a0f85e461d87ed5a3a664e3"}],"cinder/volume/drivers/dell_emc/powermax/masking.py":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"23f89c78fc33eb75fdf7d06f842cb34b1bb182b5","unresolved":true,"context_lines":[{"line_number":2044,"context_line":"            src_slo \u003d split_pool[0]"},{"line_number":2045,"context_line":"            src_wl \u003d split_pool[1] if len(split_pool) \u003d\u003d 4 else \u0027NONE\u0027"},{"line_number":2046,"context_line":"        else:"},{"line_number":2047,"context_line":"            src_slo \u003d extra_specs[\u0027slo\u0027]"},{"line_number":2048,"context_line":"            src_wl \u003d extra_specs[\u0027workload\u0027]"},{"line_number":2049,"context_line":"        slo_wl_combo \u003d self.utils.truncate_string(src_slo + src_wl.upper(), 10)"},{"line_number":2050,"context_line":"        print(slo_wl_combo)"}],"source_content_type":"text/x-python","patch_set":3,"id":"96e1404e_37be86b8","line":2047,"updated":"2023-10-17 11:51:50.000000000","message":"So we get these parametes from extra_specs from volume type? It\u0027ll break if none are passed right?","commit_id":"bd775cb1eae7dfd25a535199ad48ef062aa71814"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"6174e3951cb85d18e4d671ffa702d9f11073c056","unresolved":false,"context_lines":[{"line_number":2044,"context_line":"            src_slo \u003d split_pool[0]"},{"line_number":2045,"context_line":"            src_wl \u003d split_pool[1] if len(split_pool) \u003d\u003d 4 else \u0027NONE\u0027"},{"line_number":2046,"context_line":"        else:"},{"line_number":2047,"context_line":"            src_slo \u003d extra_specs[\u0027slo\u0027]"},{"line_number":2048,"context_line":"            src_wl \u003d extra_specs[\u0027workload\u0027]"},{"line_number":2049,"context_line":"        slo_wl_combo \u003d self.utils.truncate_string(src_slo + src_wl.upper(), 10)"},{"line_number":2050,"context_line":"        print(slo_wl_combo)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1eab2ccc_88f12250","line":2047,"in_reply_to":"0067eea6_51ff4af2","updated":"2023-11-17 09:17:19.000000000","message":"recheck","commit_id":"bd775cb1eae7dfd25a535199ad48ef062aa71814"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"1225acceacddb56e8cd159b8d80630ef21404ba4","unresolved":false,"context_lines":[{"line_number":2044,"context_line":"            src_slo \u003d split_pool[0]"},{"line_number":2045,"context_line":"            src_wl \u003d split_pool[1] if len(split_pool) \u003d\u003d 4 else \u0027NONE\u0027"},{"line_number":2046,"context_line":"        else:"},{"line_number":2047,"context_line":"            src_slo \u003d extra_specs[\u0027slo\u0027]"},{"line_number":2048,"context_line":"            src_wl \u003d extra_specs[\u0027workload\u0027]"},{"line_number":2049,"context_line":"        slo_wl_combo \u003d self.utils.truncate_string(src_slo + src_wl.upper(), 10)"},{"line_number":2050,"context_line":"        print(slo_wl_combo)"}],"source_content_type":"text/x-python","patch_set":3,"id":"d3b1522b_03d2d05a","line":2047,"in_reply_to":"08673eb4_d22746c5","updated":"2023-11-08 08:56:56.000000000","message":"Resolved","commit_id":"bd775cb1eae7dfd25a535199ad48ef062aa71814"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"59edeedda2075d772d8c9263c2ed8100a9fce4a4","unresolved":false,"context_lines":[{"line_number":2044,"context_line":"            src_slo \u003d split_pool[0]"},{"line_number":2045,"context_line":"            src_wl \u003d split_pool[1] if len(split_pool) \u003d\u003d 4 else \u0027NONE\u0027"},{"line_number":2046,"context_line":"        else:"},{"line_number":2047,"context_line":"            src_slo \u003d extra_specs[\u0027slo\u0027]"},{"line_number":2048,"context_line":"            src_wl \u003d extra_specs[\u0027workload\u0027]"},{"line_number":2049,"context_line":"        slo_wl_combo \u003d self.utils.truncate_string(src_slo + src_wl.upper(), 10)"},{"line_number":2050,"context_line":"        print(slo_wl_combo)"}],"source_content_type":"text/x-python","patch_set":3,"id":"0067eea6_51ff4af2","line":2047,"in_reply_to":"2ccde449_8371970e","updated":"2023-11-10 15:08:19.000000000","message":"The codes[1] in common.py can answer my question. The variable \u0027extra_specs\u0027 is not just a dict of volume type extra-specs set by the user, but containing more key/value pairs.\n\nBesides, please use snippet like [2] to avoid hard-coded.\n\n[1] https://opendev.org/openstack/cinder/src/branch/master/cinder/volume/drivers/dell_emc/powermax/common.py#L2373-L2416\n\n[2]\nsrc_slo  \u003d extra_specs[utils.SLO]\nsrc_wl \u003d extra_specs[utils.WORKLOAD]","commit_id":"bd775cb1eae7dfd25a535199ad48ef062aa71814"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"f2b0f6b0f583329eb5e75b57ba866473da5e5e19","unresolved":true,"context_lines":[{"line_number":2044,"context_line":"            src_slo \u003d split_pool[0]"},{"line_number":2045,"context_line":"            src_wl \u003d split_pool[1] if len(split_pool) \u003d\u003d 4 else \u0027NONE\u0027"},{"line_number":2046,"context_line":"        else:"},{"line_number":2047,"context_line":"            src_slo \u003d extra_specs[\u0027slo\u0027]"},{"line_number":2048,"context_line":"            src_wl \u003d extra_specs[\u0027workload\u0027]"},{"line_number":2049,"context_line":"        slo_wl_combo \u003d self.utils.truncate_string(src_slo + src_wl.upper(), 10)"},{"line_number":2050,"context_line":"        print(slo_wl_combo)"}],"source_content_type":"text/x-python","patch_set":3,"id":"08673eb4_d22746c5","line":2047,"in_reply_to":"96e1404e_37be86b8","updated":"2023-11-06 07:00:54.000000000","message":"If pool_name is not present in the extra_specs so no slo/ workload information is present using default slo/ workload combination: Optimized/NONE.","commit_id":"bd775cb1eae7dfd25a535199ad48ef062aa71814"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"9a3b142496dacd5fb71216d199abeb64c283d9bb","unresolved":false,"context_lines":[{"line_number":2044,"context_line":"            src_slo \u003d split_pool[0]"},{"line_number":2045,"context_line":"            src_wl \u003d split_pool[1] if len(split_pool) \u003d\u003d 4 else \u0027NONE\u0027"},{"line_number":2046,"context_line":"        else:"},{"line_number":2047,"context_line":"            src_slo \u003d extra_specs[\u0027slo\u0027]"},{"line_number":2048,"context_line":"            src_wl \u003d extra_specs[\u0027workload\u0027]"},{"line_number":2049,"context_line":"        slo_wl_combo \u003d self.utils.truncate_string(src_slo + src_wl.upper(), 10)"},{"line_number":2050,"context_line":"        print(slo_wl_combo)"}],"source_content_type":"text/x-python","patch_set":3,"id":"2ccde449_8371970e","line":2047,"in_reply_to":"d3b1522b_03d2d05a","updated":"2023-11-08 09:18:06.000000000","message":"The driver doesn\u0027t support volume type extra specs \u0027slo\u0027 or \u0027workload\u0027.","commit_id":"bd775cb1eae7dfd25a535199ad48ef062aa71814"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"23f89c78fc33eb75fdf7d06f842cb34b1bb182b5","unresolved":true,"context_lines":[{"line_number":2047,"context_line":"            src_slo \u003d extra_specs[\u0027slo\u0027]"},{"line_number":2048,"context_line":"            src_wl \u003d extra_specs[\u0027workload\u0027]"},{"line_number":2049,"context_line":"        slo_wl_combo \u003d self.utils.truncate_string(src_slo + src_wl.upper(), 10)"},{"line_number":2050,"context_line":"        print(slo_wl_combo)"},{"line_number":2051,"context_line":"        for sg in sg_list.get(\u0027storageGroupId\u0027, []):"},{"line_number":2052,"context_line":"            if slo_wl_combo in sg:"},{"line_number":2053,"context_line":"                fast_source_sg_name \u003d sg"}],"source_content_type":"text/x-python","patch_set":3,"id":"d0aca9eb_c8c72533","line":2050,"updated":"2023-10-17 11:51:50.000000000","message":"Remove the print statement.","commit_id":"bd775cb1eae7dfd25a535199ad48ef062aa71814"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"7b68c6f18aed1c454d0553a8115b43a63a291703","unresolved":false,"context_lines":[{"line_number":2047,"context_line":"            src_slo \u003d extra_specs[\u0027slo\u0027]"},{"line_number":2048,"context_line":"            src_wl \u003d extra_specs[\u0027workload\u0027]"},{"line_number":2049,"context_line":"        slo_wl_combo \u003d self.utils.truncate_string(src_slo + src_wl.upper(), 10)"},{"line_number":2050,"context_line":"        print(slo_wl_combo)"},{"line_number":2051,"context_line":"        for sg in sg_list.get(\u0027storageGroupId\u0027, []):"},{"line_number":2052,"context_line":"            if slo_wl_combo in sg:"},{"line_number":2053,"context_line":"                fast_source_sg_name \u003d sg"}],"source_content_type":"text/x-python","patch_set":3,"id":"de17695a_699f2069","line":2050,"in_reply_to":"d0aca9eb_c8c72533","updated":"2023-11-07 03:26:29.000000000","message":"Removed","commit_id":"bd775cb1eae7dfd25a535199ad48ef062aa71814"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"6174e3951cb85d18e4d671ffa702d9f11073c056","unresolved":false,"context_lines":[{"line_number":2047,"context_line":"            src_slo \u003d extra_specs[\u0027slo\u0027]"},{"line_number":2048,"context_line":"            src_wl \u003d extra_specs[\u0027workload\u0027]"},{"line_number":2049,"context_line":"        slo_wl_combo \u003d self.utils.truncate_string(src_slo + src_wl.upper(), 10)"},{"line_number":2050,"context_line":"        print(slo_wl_combo)"},{"line_number":2051,"context_line":"        for sg in sg_list.get(\u0027storageGroupId\u0027, []):"},{"line_number":2052,"context_line":"            if slo_wl_combo in sg:"},{"line_number":2053,"context_line":"                fast_source_sg_name \u003d sg"}],"source_content_type":"text/x-python","patch_set":3,"id":"04c19c3d_0b37fea5","line":2050,"in_reply_to":"de17695a_699f2069","updated":"2023-11-17 09:17:19.000000000","message":"recheck","commit_id":"bd775cb1eae7dfd25a535199ad48ef062aa71814"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"a2118363365cc3b13fff4fe6324cb1479c8d0109","unresolved":true,"context_lines":[{"line_number":2043,"context_line":"        if \u0027pool_name\u0027 in extra_specs:"},{"line_number":2044,"context_line":"            split_pool \u003d extra_specs[\u0027pool_name\u0027].split(\u0027+\u0027)"},{"line_number":2045,"context_line":"            src_slo \u003d split_pool[0]"},{"line_number":2046,"context_line":"            src_wl \u003d split_pool[1] if len(split_pool) \u003d\u003d 4 else \u0027NONE\u0027"},{"line_number":2047,"context_line":"        else:"},{"line_number":2048,"context_line":"            src_slo \u003d extra_specs[\u0027slo\u0027]"},{"line_number":2049,"context_line":"            src_wl \u003d extra_specs[\u0027workload\u0027]"}],"source_content_type":"text/x-python","patch_set":22,"id":"6a0a774a_f04865b0","line":2046,"range":{"start_line":2046,"start_character":57,"end_line":2046,"end_character":58},"updated":"2024-03-05 21:54:12.000000000","message":"Hey @cherry,\n\nWould you be agreeable to adding either comments or constants for the raw numbers? This looks like an instance of \"magic numbers\" unless I am missing something.","commit_id":"23b856955332013b40f417a8fe73915cbc03d624"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"2020104c9e0779099c9253e53acb4557db5dd855","unresolved":false,"context_lines":[{"line_number":2043,"context_line":"        if \u0027pool_name\u0027 in extra_specs:"},{"line_number":2044,"context_line":"            split_pool \u003d extra_specs[\u0027pool_name\u0027].split(\u0027+\u0027)"},{"line_number":2045,"context_line":"            src_slo \u003d split_pool[0]"},{"line_number":2046,"context_line":"            src_wl \u003d split_pool[1] if len(split_pool) \u003d\u003d 4 else \u0027NONE\u0027"},{"line_number":2047,"context_line":"        else:"},{"line_number":2048,"context_line":"            src_slo \u003d extra_specs[\u0027slo\u0027]"},{"line_number":2049,"context_line":"            src_wl \u003d extra_specs[\u0027workload\u0027]"}],"source_content_type":"text/x-python","patch_set":22,"id":"1e363784_513a3e21","line":2046,"range":{"start_line":2046,"start_character":57,"end_line":2046,"end_character":58},"in_reply_to":"54fd2f08_45a41804","updated":"2024-03-07 02:49:53.000000000","message":"resolved","commit_id":"23b856955332013b40f417a8fe73915cbc03d624"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"8a6332984d0ee484bd848356db6e4ee0b2e80c4b","unresolved":true,"context_lines":[{"line_number":2043,"context_line":"        if \u0027pool_name\u0027 in extra_specs:"},{"line_number":2044,"context_line":"            split_pool \u003d extra_specs[\u0027pool_name\u0027].split(\u0027+\u0027)"},{"line_number":2045,"context_line":"            src_slo \u003d split_pool[0]"},{"line_number":2046,"context_line":"            src_wl \u003d split_pool[1] if len(split_pool) \u003d\u003d 4 else \u0027NONE\u0027"},{"line_number":2047,"context_line":"        else:"},{"line_number":2048,"context_line":"            src_slo \u003d extra_specs[\u0027slo\u0027]"},{"line_number":2049,"context_line":"            src_wl \u003d extra_specs[\u0027workload\u0027]"}],"source_content_type":"text/x-python","patch_set":22,"id":"54fd2f08_45a41804","line":2046,"range":{"start_line":2046,"start_character":57,"end_line":2046,"end_character":58},"in_reply_to":"6a0a774a_f04865b0","updated":"2024-03-06 05:50:41.000000000","message":"Because the split_pool contains slo, workload, srp and array, the length is 4. If there is no pool_name, it is None.","commit_id":"23b856955332013b40f417a8fe73915cbc03d624"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2c80e696d7068f00fbb4b7e2c390eeed3176319c","unresolved":true,"context_lines":[{"line_number":2046,"context_line":"            src_wl \u003d split_pool[1] if len(split_pool) \u003d\u003d 4 else \u0027NONE\u0027"},{"line_number":2047,"context_line":"        else:"},{"line_number":2048,"context_line":"            src_slo \u003d extra_specs[\u0027slo\u0027]"},{"line_number":2049,"context_line":"            src_wl \u003d extra_specs[\u0027workload\u0027]"},{"line_number":2050,"context_line":"        slo_wl_combo \u003d self.utils.truncate_string(src_slo + src_wl.upper(), 10)"},{"line_number":2051,"context_line":"        for sg in sg_list.get(\u0027storageGroupId\u0027, []):"},{"line_number":2052,"context_line":"            if slo_wl_combo in sg:"}],"source_content_type":"text/x-python","patch_set":23,"id":"95f58089_92ad1610","line":2049,"updated":"2024-03-26 02:01:52.000000000","message":"nit: instead of the literals, use utils.SLO and utils.WORKLOAD\n\nBut what I really wanted to ask here is how do you know that \u0027slo\u0027 and \u0027workload\u0027 will be present in the extra_specs?","commit_id":"747a81ebce6676a1ce6d0bafa795551f74008ea6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f53f99064cb237578eceaceff387cfb3cfe9b0b1","unresolved":false,"context_lines":[{"line_number":2046,"context_line":"            src_wl \u003d split_pool[1] if len(split_pool) \u003d\u003d 4 else \u0027NONE\u0027"},{"line_number":2047,"context_line":"        else:"},{"line_number":2048,"context_line":"            src_slo \u003d extra_specs[\u0027slo\u0027]"},{"line_number":2049,"context_line":"            src_wl \u003d extra_specs[\u0027workload\u0027]"},{"line_number":2050,"context_line":"        slo_wl_combo \u003d self.utils.truncate_string(src_slo + src_wl.upper(), 10)"},{"line_number":2051,"context_line":"        for sg in sg_list.get(\u0027storageGroupId\u0027, []):"},{"line_number":2052,"context_line":"            if slo_wl_combo in sg:"}],"source_content_type":"text/x-python","patch_set":23,"id":"f839d526_704404a5","line":2049,"in_reply_to":"918c3c66_0bdaf1c3","updated":"2024-03-27 14:38:35.000000000","message":"Thanks for the link to the function that loads the extra-specs!","commit_id":"747a81ebce6676a1ce6d0bafa795551f74008ea6"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"cb066a53047fdae551a663460e6d8d09c8cc1283","unresolved":false,"context_lines":[{"line_number":2046,"context_line":"            src_wl \u003d split_pool[1] if len(split_pool) \u003d\u003d 4 else \u0027NONE\u0027"},{"line_number":2047,"context_line":"        else:"},{"line_number":2048,"context_line":"            src_slo \u003d extra_specs[\u0027slo\u0027]"},{"line_number":2049,"context_line":"            src_wl \u003d extra_specs[\u0027workload\u0027]"},{"line_number":2050,"context_line":"        slo_wl_combo \u003d self.utils.truncate_string(src_slo + src_wl.upper(), 10)"},{"line_number":2051,"context_line":"        for sg in sg_list.get(\u0027storageGroupId\u0027, []):"},{"line_number":2052,"context_line":"            if slo_wl_combo in sg:"}],"source_content_type":"text/x-python","patch_set":23,"id":"918c3c66_0bdaf1c3","line":2049,"in_reply_to":"95f58089_92ad1610","updated":"2024-03-26 09:10:40.000000000","message":"This is described in https://opendev.org/openstack/cinder/src/branch/master/cinder/volume/drivers/dell_emc/powermax/common.py#L2373-L2472\n\nand I correct it to avoid hard-coded\n\nsrc_slo \u003d extra_specs[utils.SLO]\nsrc_wl \u003d extra_specs[utils.WORKLOAD]","commit_id":"747a81ebce6676a1ce6d0bafa795551f74008ea6"}],"releasenotes/notes/add-powermax-live-migration-without-a-pool-name-7690fcd67b5f690c.yaml":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"29b686f521f3161b56a2e29cbbd681502ce288c0","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2034937\u003e`_: Fixed"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    This change is to update the live migration ability in environments using PowerMax. In previous 2023.1 version, the live migration fails without a pool name."},{"line_number":8,"context_line":"    This update adds the ability of live migration without a pool name."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5a611c1f_bcfcc473","line":8,"updated":"2023-11-17 09:50:50.000000000","message":"remove the empty line at the end of the file.\nPay attention to the format","commit_id":"c12037cc4fb294bf5a1319cd9297245328ccb980"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"58e4ec2a28bfaafee152ec21e0a74df0d18aac46","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2034937\u003e`_: Fixed"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    This change is to update the live migration ability in environments using PowerMax. In previous 2023.1 version, the live migration fails without a pool name."},{"line_number":8,"context_line":"    This update adds the ability of live migration without a pool name."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"54d327e6_815cb580","line":8,"in_reply_to":"5a611c1f_bcfcc473","updated":"2023-11-21 13:54:59.000000000","message":"Resolved","commit_id":"c12037cc4fb294bf5a1319cd9297245328ccb980"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2c80e696d7068f00fbb4b7e2c390eeed3176319c","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2034937\u003e`_: Fixed"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    This change is to update the live migration ability in environments using PowerMax. In previous "},{"line_number":8,"context_line":"    2023.1 version, the live migration fails without a pool name. "},{"line_number":9,"context_line":"    This update add the ability of live migration without a pool name."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"eb6d7f43_b07f9c0f","line":8,"updated":"2024-03-26 02:01:52.000000000","message":"nit: would be good to remove the trailing whitespace on the 2 lines above","commit_id":"747a81ebce6676a1ce6d0bafa795551f74008ea6"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"cb066a53047fdae551a663460e6d8d09c8cc1283","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2034937\u003e`_: Fixed"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    This change is to update the live migration ability in environments using PowerMax. In previous "},{"line_number":8,"context_line":"    2023.1 version, the live migration fails without a pool name. "},{"line_number":9,"context_line":"    This update add the ability of live migration without a pool name."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"ca07d846_f1a03cab","line":8,"in_reply_to":"eb6d7f43_b07f9c0f","updated":"2024-03-26 09:10:40.000000000","message":"remove the  trailing whitespace","commit_id":"747a81ebce6676a1ce6d0bafa795551f74008ea6"}],"releasenotes/notes/fix-powermax-live-migration-without-a-pool-name-7690fcd67b5f690c.yaml":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"5a2b2df64128f267613b8c196b5018f2a4555e0d","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    This change is to update the live migration ability in environments using PowerMax. In previous 2023.1 version, the live migration fails without a pool name."},{"line_number":8,"context_line":"    This update fixes the ability of live migration without a pool name."},{"line_number":9,"context_line":"    "}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5bb0bce3_035e3e17","line":9,"updated":"2023-11-20 08:07:50.000000000","message":"Remove the empty line at the end of the file.\nFormat looks weird. Please check.","commit_id":"f130d7062629c398a5456a1a1e95d71965a158e9"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"b61cf509bf4a6ae1a6f75e6cec5b2496402f5ef8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    This change is to update the live migration ability in environments using PowerMax. In previous 2023.1 version, the live migration fails without a pool name."},{"line_number":8,"context_line":"    This update fixes the ability of live migration without a pool name."},{"line_number":9,"context_line":"    "}],"source_content_type":"text/x-yaml","patch_set":11,"id":"6c3e8e53_7e30e1c3","line":9,"in_reply_to":"5bb0bce3_035e3e17","updated":"2023-11-21 07:36:29.000000000","message":"recheck","commit_id":"f130d7062629c398a5456a1a1e95d71965a158e9"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"bfdec199765b7d075d5ea99aef6e07056e8755bb","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Dell PowerMax driver `bug #2034937"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2034937\u003e`_: Fixed"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    This change is to update the live migration ability in environments using PowerMax. In previous 2023.1 version, the live migration fails without a pool name."},{"line_number":8,"context_line":"    This update fixes the ability of live migration without a pool name."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"c1dd404b_f65cd91d","line":7,"updated":"2023-11-21 08:01:59.000000000","message":"Format doesn\u0027t look good. Phrasing needs attention.\nExplain where pool_name get filled when it\u0027s empty.","commit_id":"52d346a679ce53aa46185ff26fe1ccc37b2d88f2"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"3490c5b39318f0d98e5d023f11fb8c4baac253ff","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Dell PowerMax driver `bug #2034937"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2034937\u003e`_: Fixed"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    This change is to update the live migration ability in environments using PowerMax. In previous 2023.1 version, the live migration fails without a pool name."},{"line_number":8,"context_line":"    This update fixes the ability of live migration without a pool name."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"13c9007e_a23737df","line":7,"in_reply_to":"c1dd404b_f65cd91d","updated":"2023-11-21 13:55:50.000000000","message":"resolved","commit_id":"52d346a679ce53aa46185ff26fe1ccc37b2d88f2"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"05df430a76fc17bd8971f29c55aa32b50aaa7151","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Dell PowerMax driver `bug #2034937"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2034937\u003e`_: Fixed"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    This change is to update the live migration ability in environments using PowerMax."},{"line_number":8,"context_line":"    In previous 2023.1 version, the live migration will fail if the pool_name is not"},{"line_number":9,"context_line":"    specified in the volume type. Because in the line"},{"line_number":10,"context_line":"    \"split_pool \u003d extra_specs[\u0027pool_name\u0027].split(\u0027+\u0027)\", the split method will raise"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"20a7b754_d566094d","line":7,"updated":"2023-11-21 10:40:22.000000000","message":"Still needs to be rephrased:\nCurrently, when a user initiates a live migration, the process will fail if the pool_name is not specified in the volume type as the split method will raise an exception.\nThis patch enables \"src_slo\" and \"src_wl\" to be retrieved from utils.SLO and utils.WORKLOAD.\nThis fixes permits a live migration to complete successfully even if the pool_name is not specified in the extra_specs of a particular volume type","commit_id":"67afd01105f1f525ef872d70822d6a62cf92aee1"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"58e4ec2a28bfaafee152ec21e0a74df0d18aac46","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Dell PowerMax driver `bug #2034937"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2034937\u003e`_: Fixed"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    This change is to update the live migration ability in environments using PowerMax."},{"line_number":8,"context_line":"    In previous 2023.1 version, the live migration will fail if the pool_name is not"},{"line_number":9,"context_line":"    specified in the volume type. Because in the line"},{"line_number":10,"context_line":"    \"split_pool \u003d extra_specs[\u0027pool_name\u0027].split(\u0027+\u0027)\", the split method will raise"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"38259e41_5851202e","line":7,"in_reply_to":"20a7b754_d566094d","updated":"2023-11-21 13:54:59.000000000","message":"Resolved","commit_id":"67afd01105f1f525ef872d70822d6a62cf92aee1"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"27df1d50325caa3913cf103a0bded18e3dac65b3","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    This patch enables \"src_slo\" and \"src_wl\" to be retrieved from utils.SLO and"},{"line_number":11,"context_line":"    utils.WORKLOAD."},{"line_number":12,"context_line":"    This fixes permits a live migration to complete successfully even if the pool_name is"},{"line_number":13,"context_line":"    not specified in the extra_specs of a particular volume type"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"6c3b0931_18fbb3ee","line":13,"updated":"2023-11-22 07:57:55.000000000","message":"Nit: add a .","commit_id":"0977a7cd2c9958c5f15a4982e57f1ae9991d88ec"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"73a9da8fc6fa261fa18f5ed1c0f7126869d60402","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    This patch enables \"src_slo\" and \"src_wl\" to be retrieved from utils.SLO and"},{"line_number":11,"context_line":"    utils.WORKLOAD."},{"line_number":12,"context_line":"    This fixes permits a live migration to complete successfully even if the pool_name is"},{"line_number":13,"context_line":"    not specified in the extra_specs of a particular volume type"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"45a0a9f7_e3df38bc","line":13,"in_reply_to":"6c3b0931_18fbb3ee","updated":"2023-11-22 13:49:09.000000000","message":"resolved","commit_id":"0977a7cd2c9958c5f15a4982e57f1ae9991d88ec"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"f2d2bcc5fbe29f109a908e593ee3b5f0ab4251ab","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Dell PowerMax driver `bug #2034937"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2034937\u003e`_: Fixed"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    This change is to update the live migration ability in environments using PowerMax."},{"line_number":8,"context_line":"    Currently, when a user initiates a live migration, the process will fail if the pool_name"},{"line_number":9,"context_line":"    is not specified in the volume type as the split method will raise an exception."},{"line_number":10,"context_line":"    This patch enables \"src_slo\" and \"src_wl\" to be retrieved from utils.SLO and"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"36fc5e9c_de13c3cc","line":7,"updated":"2024-01-03 15:42:35.000000000","message":"Should be Dell PowerMax","commit_id":"1d5decee8e6d053b567c1be806697f36019be61b"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"5da21bcacf3c95acae9773801f1033b75997ab18","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Dell PowerMax driver `bug #2034937"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2034937\u003e`_: Fixed"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    This change is to update the live migration ability in environments using PowerMax."},{"line_number":8,"context_line":"    Currently, when a user initiates a live migration, the process will fail if the pool_name"},{"line_number":9,"context_line":"    is not specified in the volume type as the split method will raise an exception."},{"line_number":10,"context_line":"    This patch enables \"src_slo\" and \"src_wl\" to be retrieved from utils.SLO and"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"6f6af40a_915cd2ad","line":7,"in_reply_to":"36fc5e9c_de13c3cc","updated":"2024-01-05 10:29:48.000000000","message":"Resolved","commit_id":"1d5decee8e6d053b567c1be806697f36019be61b"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"b232a5901a05f5e57deff4b80c0f95176432f76a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Dell PowerMax driver `bug #2034937"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2034937\u003e`_: Fixed"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    This change is to update the live migration ability in environments using PowerMax."},{"line_number":8,"context_line":"    Currently, when a user initiates a live migration, the process will fail if the pool_name"},{"line_number":9,"context_line":"    is not specified in the volume type as the split method will raise an exception."},{"line_number":10,"context_line":"    This patch enables \"src_slo\" and \"src_wl\" to be retrieved from utils.SLO and"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"d2a05928_2292406f","line":7,"in_reply_to":"6f6af40a_915cd2ad","updated":"2024-01-16 09:44:11.000000000","message":"rechecka","commit_id":"1d5decee8e6d053b567c1be806697f36019be61b"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"2e5ecea3476729ea53179dd01e90dddceec0d973","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Dell PowerMax driver `bug #2034937"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2034937\u003e`_: Fixed"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    This change is to update the live migration ability in environments using PowerMax."},{"line_number":8,"context_line":"    Currently, when a user initiates a live migration, the process will fail if the pool_name"},{"line_number":9,"context_line":"    is not specified in the volume type as the split method will raise an exception."},{"line_number":10,"context_line":"    This patch enables \"src_slo\" and \"src_wl\" to be retrieved from utils.SLO and"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"20a8eeff_eac00b3f","line":7,"in_reply_to":"d2a05928_2292406f","updated":"2024-01-16 09:44:29.000000000","message":"recheck","commit_id":"1d5decee8e6d053b567c1be806697f36019be61b"}]}