)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"92e9a9b422ade99ab004e8ee288cda533efe0721","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9226f7d8_9f0810a7","updated":"2023-12-08 13:52:41.000000000","message":"one concern inline regarding multiple calls to find_lun for the same check in the delete volume operation to see if the volume exists or not.","commit_id":"d3ad0155b948d6c8b246332ef464828c5a99850b"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"52f6e694f0a8724e3eab0d7d32f8b00c4be7b12e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1f566ddf_444d3b85","updated":"2023-12-27 14:02:41.000000000","message":"recheck tempest-integrated-storage cinder-tempest-plugin-lvm-lio-barbican","commit_id":"894201aa624d9a582fc70cc2b3495fae5c679b80"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"8b096fd167f9092710108b03b0a0b59e1c4a0db7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f6e044f2_82fd278e","updated":"2023-12-28 01:21:25.000000000","message":"recheck tempest-integrated-storage cinder-tempest-plugin-lvm-lio-barbican","commit_id":"894201aa624d9a582fc70cc2b3495fae5c679b80"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"25588c439110c399b0c328af0fd39bc729bfc67b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"183fa10d_b85a2de5","updated":"2023-12-27 09:17:05.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"894201aa624d9a582fc70cc2b3495fae5c679b80"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"726fa2debf9650d87aec06d32ed204a87eb51ad9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2f099c4f_297c7318","updated":"2023-12-27 14:02:58.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"894201aa624d9a582fc70cc2b3495fae5c679b80"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"1dc117b36d9b7d09ff210dfdf7cbe32d126694c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3b4f440a_1b0f0e33","updated":"2023-12-28 01:43:02.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"894201aa624d9a582fc70cc2b3495fae5c679b80"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"61df541de3267e6f4e9963ca5188a9cfbdd89adc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b57d7b69_2d78b2d9","updated":"2023-12-28 01:41:10.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"894201aa624d9a582fc70cc2b3495fae5c679b80"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"c73819692e96b375f736f6f73ef922af6ed6ba2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ad2e05c6_fe79b259","updated":"2024-01-15 14:32:05.000000000","message":"recheck tempest-integrated-storage","commit_id":"f57777d13d25c125fc03279a178607f71707d1e7"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"998d361eadd2c58aa2b0e07b40b8feea61ae34dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d998748a_2ea2774c","updated":"2024-01-15 09:31:36.000000000","message":"recheck tempest-integrated-storage tempest-slow-py3","commit_id":"f57777d13d25c125fc03279a178607f71707d1e7"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"4c688524f91d661ecd5e76b7296ef51c54678fb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"53d7c466_ac3275f7","updated":"2024-01-25 01:13:32.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican devstack-plugin-nfs-tempest-full","commit_id":"1c2fc81f6ca87a7bebdf15c39448dbce64edf4f7"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"8c33be3a839980a3bf61e73ad7815934be9e2a4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8ba1e598_4306c2d0","updated":"2024-01-24 13:48:58.000000000","message":"recheck tempest-integrated-storage","commit_id":"1c2fc81f6ca87a7bebdf15c39448dbce64edf4f7"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"43eab32b11c22235c894f006167383a96d2366c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8c6a0011_4785e96f","updated":"2024-01-24 09:03:43.000000000","message":"recheck tempest-integrated-storage","commit_id":"1c2fc81f6ca87a7bebdf15c39448dbce64edf4f7"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"bdd2852dc4b01956f8ea583b4c1e3aec946e407a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ab0c760d_c200ea29","updated":"2024-01-25 03:47:03.000000000","message":"recheck tempest-slow-py3","commit_id":"1c2fc81f6ca87a7bebdf15c39448dbce64edf4f7"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"dd0ef494433524f6474a880c43ac2ff71cd6cb47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4dc2a829_592cadc3","updated":"2024-01-24 08:06:26.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"1c2fc81f6ca87a7bebdf15c39448dbce64edf4f7"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"f2b893e1bc4b340033f224e130681aeef85a44fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3c2a6c6a_0920cbd3","updated":"2024-02-02 01:21:27.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"5322f73a51b5b2f8c0ae5a69585ee7e9b274eccc"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"a81e703bcc7fd8c3203234a1a37f939099131552","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a6b47141_83d61194","updated":"2024-02-02 03:55:42.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"5322f73a51b5b2f8c0ae5a69585ee7e9b274eccc"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a0412b02578ab268cfb345ff5dfc749bd8ce9100","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c3d63703_25453a85","updated":"2024-03-07 04:09:15.000000000","message":"A few questions/comments inline.  Have not looked at the tests yet.","commit_id":"77ccece9264cdf53fc87dd4bd336790d4d4f1f08"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"acaa59065c20ec0f1f30baf8a98e183b336dce15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"94233d7f_880c00d9","updated":"2024-03-06 12:47:29.000000000","message":"Code changes look good. Zuul and Fujitsu ETERNUS CI have passed.\nOne query inline.","commit_id":"77ccece9264cdf53fc87dd4bd336790d4d4f1f08"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"435de55d1a7b5e1b458ee2f22c05e6f3f0983f76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"67412a75_f4fea8e2","updated":"2024-02-16 03:07:48.000000000","message":"recheck cinder-plugin-ceph-tempest","commit_id":"77ccece9264cdf53fc87dd4bd336790d4d4f1f08"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"08de7c695deb2afe5168c3dcd40a46951e907e42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b0f8f4ff_e0449a4f","updated":"2024-02-15 12:59:08.000000000","message":"recheck tempest-slow-py3","commit_id":"77ccece9264cdf53fc87dd4bd336790d4d4f1f08"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"17bc9040c846a10b7e57a0cf4c85f8fc19995d80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b15ef6c9_1285f9ed","updated":"2024-02-16 12:11:04.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"77ccece9264cdf53fc87dd4bd336790d4d4f1f08"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"d32b86864c95f209a406347c263b78eec40c6427","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c4f862cf_24c0bce0","updated":"2024-02-16 03:08:12.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"77ccece9264cdf53fc87dd4bd336790d4d4f1f08"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"7a741eb4848b2e89da6e5c7546655a092ef4d2ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d21629a3_95a2b369","updated":"2024-02-16 15:38:35.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"77ccece9264cdf53fc87dd4bd336790d4d4f1f08"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"a6513a00c877eb51efb38dc9bf961e1d3a12bd5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e63a0cf1_2aadbb72","updated":"2024-02-16 08:14:33.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"77ccece9264cdf53fc87dd4bd336790d4d4f1f08"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"2489153c8c428cd5a9b0e800e9ade5406396958b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7e1eedc6_3db96554","updated":"2024-04-02 12:44:49.000000000","message":"My query has been addressed. Thanks.","commit_id":"07dd49babecf9585dca464525f8577850a1124a2"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"53099fc2ebf1260679af62025830697be53eff82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"23fb1f8e_682d8a5d","updated":"2024-04-22 01:17:41.000000000","message":"This patch has been merged. Thank you everyone.","commit_id":"07dd49babecf9585dca464525f8577850a1124a2"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"59231d912b569074efd622b97e046fc8b110df5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ad1f2784_e1571c5d","updated":"2024-04-02 05:06:06.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"07dd49babecf9585dca464525f8577850a1124a2"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"3f2f7593fd1d3675527314baffdfc702ffaedd21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fe5d4ae7_0bc551f9","updated":"2024-04-03 01:44:04.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"07dd49babecf9585dca464525f8577850a1124a2"}],"cinder/volume/drivers/fujitsu/eternus_dx/eternus_dx_cli.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"92e9a9b422ade99ab004e8ee288cda533efe0721","unresolved":true,"context_lines":[{"line_number":324,"context_line":"                    temp_phase \u003d \u0027Tracking\u0027"},{"line_number":325,"context_line":"                elif clidata[6] \u003d\u003d \u002704\u0027:"},{"line_number":326,"context_line":"                    temp_phase \u003d \u0027Tracking_Copying\u0027"},{"line_number":327,"context_line":"                elif clidata[6] \u003d\u003d \u002706\u0027:"},{"line_number":328,"context_line":"                    temp_phase \u003d \u0027Readying\u0027"},{"line_number":329,"context_line":"                else:"},{"line_number":330,"context_line":"                    temp_phase \u003d \u0027Other\u0027"},{"line_number":331,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fdd480a5_248a386b","line":328,"range":{"start_line":327,"start_character":0,"end_line":328,"end_character":43},"updated":"2023-12-08 13:52:41.000000000","message":"Just to confirm 05 is skipped intentionally here and doesn\u0027t resolve to a particular phase","commit_id":"d3ad0155b948d6c8b246332ef464828c5a99850b"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"25588c439110c399b0c328af0fd39bc729bfc67b","unresolved":false,"context_lines":[{"line_number":324,"context_line":"                    temp_phase \u003d \u0027Tracking\u0027"},{"line_number":325,"context_line":"                elif clidata[6] \u003d\u003d \u002704\u0027:"},{"line_number":326,"context_line":"                    temp_phase \u003d \u0027Tracking_Copying\u0027"},{"line_number":327,"context_line":"                elif clidata[6] \u003d\u003d \u002706\u0027:"},{"line_number":328,"context_line":"                    temp_phase \u003d \u0027Readying\u0027"},{"line_number":329,"context_line":"                else:"},{"line_number":330,"context_line":"                    temp_phase \u003d \u0027Other\u0027"},{"line_number":331,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"f836b837_1118217b","line":328,"range":{"start_line":327,"start_character":0,"end_line":328,"end_character":43},"in_reply_to":"fdd480a5_248a386b","updated":"2023-12-27 09:17:05.000000000","message":"Yes, \u002705\u0027 is skipped, and we don\u0027t resolve it to a particular phase.","commit_id":"d3ad0155b948d6c8b246332ef464828c5a99850b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3070b138d3a4792c5dba4ff7befacdd5c1279d03","unresolved":true,"context_lines":[{"line_number":362,"context_line":"            output \u003d {\u0027result\u0027: 0,"},{"line_number":363,"context_line":"                      \u0027rc\u0027: \u00274\u0027,"},{"line_number":364,"context_line":"                      \u0027message\u0027: \"Show copy sessions error: %s\""},{"line_number":365,"context_line":"                                 % six.text_type(ex)}"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        return output"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"d631dafd_324f82ba","line":365,"range":{"start_line":365,"start_character":35,"end_line":365,"end_character":48},"updated":"2024-01-31 19:43:47.000000000","message":"It would be better to just use str(), no need for python-six at this point.","commit_id":"1c2fc81f6ca87a7bebdf15c39448dbce64edf4f7"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"6a7b866bedbca55b022b8f4da030fc76322d9613","unresolved":false,"context_lines":[{"line_number":362,"context_line":"            output \u003d {\u0027result\u0027: 0,"},{"line_number":363,"context_line":"                      \u0027rc\u0027: \u00274\u0027,"},{"line_number":364,"context_line":"                      \u0027message\u0027: \"Show copy sessions error: %s\""},{"line_number":365,"context_line":"                                 % six.text_type(ex)}"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        return output"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"91886cd7_fc0c89e6","line":365,"range":{"start_line":365,"start_character":35,"end_line":365,"end_character":48},"in_reply_to":"d631dafd_324f82ba","updated":"2024-02-01 08:36:42.000000000","message":"Thanks for your review. I removed all the python-six.","commit_id":"1c2fc81f6ca87a7bebdf15c39448dbce64edf4f7"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"acaa59065c20ec0f1f30baf8a98e183b336dce15","unresolved":true,"context_lines":[{"line_number":327,"context_line":"                    temp_phase \u003d \u0027Tracking\u0027"},{"line_number":328,"context_line":"                elif clidata[6] \u003d\u003d \u002704\u0027:"},{"line_number":329,"context_line":"                    temp_phase \u003d \u0027Tracking_Copying\u0027"},{"line_number":330,"context_line":"                elif clidata[6] \u003d\u003d \u002706\u0027:"},{"line_number":331,"context_line":"                    temp_phase \u003d \u0027Readying\u0027"},{"line_number":332,"context_line":"                else:"},{"line_number":333,"context_line":"                    temp_phase \u003d \u0027Other\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"b14e2553_a3c24992","line":330,"range":{"start_line":330,"start_character":34,"end_line":330,"end_character":40},"updated":"2024-03-06 12:47:29.000000000","message":"i have no knowledge of contents of clidata[6].\nSo asking ... i hope \u002706\u0027 is intentional \u0026 we have not missed \u002705\u0027.\nRight ?","commit_id":"77ccece9264cdf53fc87dd4bd336790d4d4f1f08"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"0c41c86e5383514343cb915dc721c70ad010c26c","unresolved":false,"context_lines":[{"line_number":327,"context_line":"                    temp_phase \u003d \u0027Tracking\u0027"},{"line_number":328,"context_line":"                elif clidata[6] \u003d\u003d \u002704\u0027:"},{"line_number":329,"context_line":"                    temp_phase \u003d \u0027Tracking_Copying\u0027"},{"line_number":330,"context_line":"                elif clidata[6] \u003d\u003d \u002706\u0027:"},{"line_number":331,"context_line":"                    temp_phase \u003d \u0027Readying\u0027"},{"line_number":332,"context_line":"                else:"},{"line_number":333,"context_line":"                    temp_phase \u003d \u0027Other\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"a7b5949b_76c8cad8","line":330,"range":{"start_line":330,"start_character":34,"end_line":330,"end_character":40},"in_reply_to":"b14e2553_a3c24992","updated":"2024-04-01 09:02:52.000000000","message":"Yes, \u002706\u0027 is intentional, and we do not need to parse \u002705\u0027.","commit_id":"77ccece9264cdf53fc87dd4bd336790d4d4f1f08"}],"cinder/volume/drivers/fujitsu/eternus_dx/eternus_dx_common.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"92e9a9b422ade99ab004e8ee288cda533efe0721","unresolved":true,"context_lines":[{"line_number":452,"context_line":"        deleted \u003d False"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"        self.conn \u003d self._get_eternus_connection()"},{"line_number":455,"context_line":"        vol_instance \u003d self._find_lun(volume)"},{"line_number":456,"context_line":"        if not vol_instance:"},{"line_number":457,"context_line":"            return True"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        vol_exist \u003d self._delete_volume_setting(volume)"},{"line_number":460,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"67668115_15416e72","line":457,"range":{"start_line":455,"start_character":0,"end_line":457,"end_character":23},"updated":"2023-12-08 13:52:41.000000000","message":"why are we introducing this check here when we were already doing it in _delete_volume_setting method on L#488-494?","commit_id":"d3ad0155b948d6c8b246332ef464828c5a99850b"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"0ac830564894264a4fcd20ae6818845a447b122d","unresolved":true,"context_lines":[{"line_number":452,"context_line":"        deleted \u003d False"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"        self.conn \u003d self._get_eternus_connection()"},{"line_number":455,"context_line":"        vol_instance \u003d self._find_lun(volume)"},{"line_number":456,"context_line":"        if not vol_instance:"},{"line_number":457,"context_line":"            return True"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        vol_exist \u003d self._delete_volume_setting(volume)"},{"line_number":460,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a6a7a9ca_4998fa60","line":457,"range":{"start_line":455,"start_character":0,"end_line":457,"end_character":23},"in_reply_to":"67668115_15416e72","updated":"2023-12-08 15:47:24.000000000","message":"I agree that this looks unnecessarily redundant. Someone moved it from down the sequence, where the \"SnapOPC\" comment was.\n\nThis also calls into question the existence of _delete_volume_base(), which literally does this yet again and then invokes _delete_volume().","commit_id":"d3ad0155b948d6c8b246332ef464828c5a99850b"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"25588c439110c399b0c328af0fd39bc729bfc67b","unresolved":false,"context_lines":[{"line_number":452,"context_line":"        deleted \u003d False"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"        self.conn \u003d self._get_eternus_connection()"},{"line_number":455,"context_line":"        vol_instance \u003d self._find_lun(volume)"},{"line_number":456,"context_line":"        if not vol_instance:"},{"line_number":457,"context_line":"            return True"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        vol_exist \u003d self._delete_volume_setting(volume)"},{"line_number":460,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"45c9bb0e_dc5405fd","line":457,"range":{"start_line":455,"start_character":0,"end_line":457,"end_character":23},"in_reply_to":"a6a7a9ca_4998fa60","updated":"2023-12-27 09:17:05.000000000","message":"I removed the redundant.","commit_id":"d3ad0155b948d6c8b246332ef464828c5a99850b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"92e9a9b422ade99ab004e8ee288cda533efe0721","unresolved":true,"context_lines":[{"line_number":2554,"context_line":""},{"line_number":2555,"context_line":"        return ret"},{"line_number":2556,"context_line":""},{"line_number":2557,"context_line":"    def _get_volume_no(self, vol):"},{"line_number":2558,"context_line":"        \"\"\"Get volume no(return a hex string).\"\"\""},{"line_number":2559,"context_line":"        if self.model_name \u003d\u003d CONSTANTS.DX_S2:"},{"line_number":2560,"context_line":"            volume_no \u003d \"0x%04X\" % int(vol[\u0027DeviceID\u0027][-5:])"}],"source_content_type":"text/x-python","patch_set":1,"id":"0e3c3cbd_dab7c791","line":2557,"range":{"start_line":2557,"start_character":20,"end_line":2557,"end_character":22},"updated":"2023-12-08 13:52:41.000000000","message":"would\u0027ve been better written as \"number\"","commit_id":"d3ad0155b948d6c8b246332ef464828c5a99850b"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"25588c439110c399b0c328af0fd39bc729bfc67b","unresolved":false,"context_lines":[{"line_number":2554,"context_line":""},{"line_number":2555,"context_line":"        return ret"},{"line_number":2556,"context_line":""},{"line_number":2557,"context_line":"    def _get_volume_no(self, vol):"},{"line_number":2558,"context_line":"        \"\"\"Get volume no(return a hex string).\"\"\""},{"line_number":2559,"context_line":"        if self.model_name \u003d\u003d CONSTANTS.DX_S2:"},{"line_number":2560,"context_line":"            volume_no \u003d \"0x%04X\" % int(vol[\u0027DeviceID\u0027][-5:])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7c15776f_06f423de","line":2557,"range":{"start_line":2557,"start_character":20,"end_line":2557,"end_character":22},"in_reply_to":"0e3c3cbd_dab7c791","updated":"2023-12-27 09:17:05.000000000","message":"Done","commit_id":"d3ad0155b948d6c8b246332ef464828c5a99850b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"92e9a9b422ade99ab004e8ee288cda533efe0721","unresolved":true,"context_lines":[{"line_number":3169,"context_line":"    def _delete_volume_base(self, volume):"},{"line_number":3170,"context_line":"        LOG.debug(\u0027_delete_volume_base, Enter method.\u0027)"},{"line_number":3171,"context_line":""},{"line_number":3172,"context_line":"        vol_instance \u003d self._find_lun(volume)"},{"line_number":3173,"context_line":""},{"line_number":3174,"context_line":"        if not vol_instance:"},{"line_number":3175,"context_line":"            return True"},{"line_number":3176,"context_line":""},{"line_number":3177,"context_line":"        self._delete_volume(volume)"},{"line_number":3178,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"710b93ab_070f4a5e","line":3175,"range":{"start_line":3172,"start_character":0,"end_line":3175,"end_character":23},"updated":"2023-12-08 13:52:41.000000000","message":"IIUC this method is only called from L#466.\nWe already checked this inside delete_volume method, _delete_volume_setting method and finally here.\nAny reason for doing these 3 API calls/checks for the same operation?","commit_id":"d3ad0155b948d6c8b246332ef464828c5a99850b"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"25588c439110c399b0c328af0fd39bc729bfc67b","unresolved":false,"context_lines":[{"line_number":3169,"context_line":"    def _delete_volume_base(self, volume):"},{"line_number":3170,"context_line":"        LOG.debug(\u0027_delete_volume_base, Enter method.\u0027)"},{"line_number":3171,"context_line":""},{"line_number":3172,"context_line":"        vol_instance \u003d self._find_lun(volume)"},{"line_number":3173,"context_line":""},{"line_number":3174,"context_line":"        if not vol_instance:"},{"line_number":3175,"context_line":"            return True"},{"line_number":3176,"context_line":""},{"line_number":3177,"context_line":"        self._delete_volume(volume)"},{"line_number":3178,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b0d6801c_b05082cd","line":3175,"range":{"start_line":3172,"start_character":0,"end_line":3175,"end_character":23},"in_reply_to":"710b93ab_070f4a5e","updated":"2023-12-27 09:17:05.000000000","message":"I removed the redundant.","commit_id":"d3ad0155b948d6c8b246332ef464828c5a99850b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a0412b02578ab268cfb345ff5dfc749bd8ce9100","unresolved":true,"context_lines":[{"line_number":445,"context_line":"                  {\u0027rc\u0027: rc, \u0027job\u0027: job})"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    def delete_volume(self, volume):"},{"line_number":448,"context_line":"        \"\"\"Delete volume on ETERNUS.\"\"\""},{"line_number":449,"context_line":"        LOG.debug(\u0027delete_volume, volume id: %(vid)s.\u0027,"},{"line_number":450,"context_line":"                  {\u0027vid\u0027: volume[\u0027id\u0027]})"},{"line_number":451,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"67d6ef80_9b38b491","line":448,"updated":"2024-03-07 04:09:15.000000000","message":"It would be helpful if this comment said something about what the return value is supposed to mean.","commit_id":"77ccece9264cdf53fc87dd4bd336790d4d4f1f08"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"0c41c86e5383514343cb915dc721c70ad010c26c","unresolved":false,"context_lines":[{"line_number":445,"context_line":"                  {\u0027rc\u0027: rc, \u0027job\u0027: job})"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    def delete_volume(self, volume):"},{"line_number":448,"context_line":"        \"\"\"Delete volume on ETERNUS.\"\"\""},{"line_number":449,"context_line":"        LOG.debug(\u0027delete_volume, volume id: %(vid)s.\u0027,"},{"line_number":450,"context_line":"                  {\u0027vid\u0027: volume[\u0027id\u0027]})"},{"line_number":451,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"94bc67c8_5f87ca45","line":448,"in_reply_to":"67d6ef80_9b38b491","updated":"2024-04-01 09:02:52.000000000","message":"I deleted the return value of this function.","commit_id":"77ccece9264cdf53fc87dd4bd336790d4d4f1f08"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a0412b02578ab268cfb345ff5dfc749bd8ce9100","unresolved":true,"context_lines":[{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        if not vol_exist:"},{"line_number":457,"context_line":"            LOG.debug(\u0027delete_volume, volume not found in 1st check.\u0027)"},{"line_number":458,"context_line":"            return True"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"        try:"},{"line_number":461,"context_line":"            deleted \u003d self._delete_volume(volume)"}],"source_content_type":"text/x-python","patch_set":6,"id":"150063e2_429ecf5f","line":458,"range":{"start_line":458,"start_character":12,"end_line":458,"end_character":23},"updated":"2024-03-07 04:09:15.000000000","message":"So was it a mistake that the driver used to return False here?","commit_id":"77ccece9264cdf53fc87dd4bd336790d4d4f1f08"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"0c41c86e5383514343cb915dc721c70ad010c26c","unresolved":false,"context_lines":[{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        if not vol_exist:"},{"line_number":457,"context_line":"            LOG.debug(\u0027delete_volume, volume not found in 1st check.\u0027)"},{"line_number":458,"context_line":"            return True"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"        try:"},{"line_number":461,"context_line":"            deleted \u003d self._delete_volume(volume)"}],"source_content_type":"text/x-python","patch_set":6,"id":"53863170_9f0039b7","line":458,"range":{"start_line":458,"start_character":12,"end_line":458,"end_character":23},"in_reply_to":"150063e2_429ecf5f","updated":"2024-04-01 09:02:52.000000000","message":"Done","commit_id":"77ccece9264cdf53fc87dd4bd336790d4d4f1f08"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a0412b02578ab268cfb345ff5dfc749bd8ce9100","unresolved":true,"context_lines":[{"line_number":458,"context_line":"            return True"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"        try:"},{"line_number":461,"context_line":"            deleted \u003d self._delete_volume(volume)"},{"line_number":462,"context_line":"        except Exception:"},{"line_number":463,"context_line":"            msg \u003d (_(\u0027delete_volume, \u0027"},{"line_number":464,"context_line":"                     \u0027delete volume failed, \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"08ce5ab4_15cbea71","line":461,"updated":"2024-03-07 04:09:15.000000000","message":"I may be missing something, but _delete_volume() either returns True or raises an exception.  If it raises, then we will raise at line 468 and not return anything from this function.  So it\u0027s impossible that \u0027deleted\u0027 will be anything other than True at line 472.","commit_id":"77ccece9264cdf53fc87dd4bd336790d4d4f1f08"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"0c41c86e5383514343cb915dc721c70ad010c26c","unresolved":false,"context_lines":[{"line_number":458,"context_line":"            return True"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"        try:"},{"line_number":461,"context_line":"            deleted \u003d self._delete_volume(volume)"},{"line_number":462,"context_line":"        except Exception:"},{"line_number":463,"context_line":"            msg \u003d (_(\u0027delete_volume, \u0027"},{"line_number":464,"context_line":"                     \u0027delete volume failed, \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"562f8971_397d4f46","line":461,"in_reply_to":"08ce5ab4_15cbea71","updated":"2024-04-01 09:02:52.000000000","message":"Done","commit_id":"77ccece9264cdf53fc87dd4bd336790d4d4f1f08"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a0412b02578ab268cfb345ff5dfc749bd8ce9100","unresolved":true,"context_lines":[{"line_number":464,"context_line":"                     \u0027delete volume failed, \u0027"},{"line_number":465,"context_line":"                     \u0027deleted status is: %s.\u0027)"},{"line_number":466,"context_line":"                   % deleted)"},{"line_number":467,"context_line":"            LOG.error(msg)"},{"line_number":468,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        LOG.debug(\u0027delete_volume, deleted status is: %s.\u0027, deleted)"}],"source_content_type":"text/x-python","patch_set":6,"id":"79f4bffe_34a3b840","line":467,"updated":"2024-03-07 04:09:15.000000000","message":"I wonder whether it\u0027s worth logging what exception occurred here for debugging purposes?","commit_id":"77ccece9264cdf53fc87dd4bd336790d4d4f1f08"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"0c41c86e5383514343cb915dc721c70ad010c26c","unresolved":false,"context_lines":[{"line_number":464,"context_line":"                     \u0027delete volume failed, \u0027"},{"line_number":465,"context_line":"                     \u0027deleted status is: %s.\u0027)"},{"line_number":466,"context_line":"                   % deleted)"},{"line_number":467,"context_line":"            LOG.error(msg)"},{"line_number":468,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        LOG.debug(\u0027delete_volume, deleted status is: %s.\u0027, deleted)"}],"source_content_type":"text/x-python","patch_set":6,"id":"0deb1e97_d3e0e211","line":467,"in_reply_to":"79f4bffe_34a3b840","updated":"2024-04-01 09:02:52.000000000","message":"I added the exception information is the error log.","commit_id":"77ccece9264cdf53fc87dd4bd336790d4d4f1f08"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a0412b02578ab268cfb345ff5dfc749bd8ce9100","unresolved":true,"context_lines":[{"line_number":520,"context_line":"            self._wait_for_copy_complete(cpsession)"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        for cpsession in delete_copysession_list:"},{"line_number":523,"context_line":"            self._delete_copysession(cpsession)"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        volume_no \u003d self._get_volume_number(vol_instance)"},{"line_number":526,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ce2696d4_f228e5e7","line":523,"range":{"start_line":523,"start_character":17,"end_line":523,"end_character":47},"updated":"2024-03-07 04:09:15.000000000","message":"this can raise VolumeIsBusy ... what happens in that case?  I thought that\u0027s why you were adding the code below, so that you can try again with fresh info, but you won\u0027t execute that code.","commit_id":"77ccece9264cdf53fc87dd4bd336790d4d4f1f08"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"0c41c86e5383514343cb915dc721c70ad010c26c","unresolved":false,"context_lines":[{"line_number":520,"context_line":"            self._wait_for_copy_complete(cpsession)"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        for cpsession in delete_copysession_list:"},{"line_number":523,"context_line":"            self._delete_copysession(cpsession)"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        volume_no \u003d self._get_volume_number(vol_instance)"},{"line_number":526,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"0a464206_93230cf0","line":523,"range":{"start_line":523,"start_character":17,"end_line":523,"end_character":47},"in_reply_to":"ce2696d4_f228e5e7","updated":"2024-04-01 09:02:52.000000000","message":"If the volume to be deleted is in an inactive copysession, it will cause the VolumeIsBusy. \nAnd the added code below is not intended to retry in that case. There was a problem where the volume could not be deleted because the copy session information acquired by SMI-S IF from ETERNUS DX Storage, which was cached and did not reflect the information that had just been executed. In this case, deleting a snapshot that was just created will result in a failure.\nSo the added code below is to address this problem by scanning copy-session again using CLI.","commit_id":"77ccece9264cdf53fc87dd4bd336790d4d4f1f08"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a0412b02578ab268cfb345ff5dfc749bd8ce9100","unresolved":true,"context_lines":[{"line_number":547,"context_line":"                              \u0027clidata\u0027: clidata})"},{"line_number":548,"context_line":"                    LOG.error(msg)"},{"line_number":549,"context_line":"                    raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":550,"context_line":"                break"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"        LOG.debug(\u0027_delete_volume_setting, \u0027"},{"line_number":553,"context_line":"                  \u0027wait_cpsession: %(wait_cpsession)s, \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"096018c5_6222a969","line":550,"updated":"2024-03-07 04:09:15.000000000","message":"So if there are multiple snap copy sessions, if the first one fails, you won\u0027t try to stop any of the others.  Will you be leaving stuff on the backend, or will any remaining snap copy sessions be cleaned up automatically?","commit_id":"77ccece9264cdf53fc87dd4bd336790d4d4f1f08"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"0c41c86e5383514343cb915dc721c70ad010c26c","unresolved":false,"context_lines":[{"line_number":547,"context_line":"                              \u0027clidata\u0027: clidata})"},{"line_number":548,"context_line":"                    LOG.error(msg)"},{"line_number":549,"context_line":"                    raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":550,"context_line":"                break"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"        LOG.debug(\u0027_delete_volume_setting, \u0027"},{"line_number":553,"context_line":"                  \u0027wait_cpsession: %(wait_cpsession)s, \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"ce8e7f0f_1a1d50e2","line":550,"in_reply_to":"096018c5_6222a969","updated":"2024-04-01 09:02:52.000000000","message":"A volume as a target volume can only belong to one copy session. If the copy session deletion fails, stuff will be left on the backend and not automatically cleared, and the volume will also become the error_deleting state.","commit_id":"77ccece9264cdf53fc87dd4bd336790d4d4f1f08"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a0412b02578ab268cfb345ff5dfc749bd8ce9100","unresolved":true,"context_lines":[{"line_number":3210,"context_line":"                      \u0027emsg\u0027: emsg,"},{"line_number":3211,"context_line":"                      \u0027clidata\u0027: clidata})"},{"line_number":3212,"context_line":"            LOG.error(msg)"},{"line_number":3213,"context_line":"            raise Exception(msg)"},{"line_number":3214,"context_line":""},{"line_number":3215,"context_line":"        LOG.debug(\u0027_get_copy_sessions_list, Exit method, \u0027"},{"line_number":3216,"context_line":"                  \u0027copy sessions list: %(clidata)s. \u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"f3710bad_0a195e84","line":3213,"updated":"2024-03-07 04:09:15.000000000","message":"This would eventually be caught by that exception block at line 462.  I wonder whether you should raise something more specific here so you can distinguish this exception that you raise yourself from one that happened for some other reason.","commit_id":"77ccece9264cdf53fc87dd4bd336790d4d4f1f08"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"0c41c86e5383514343cb915dc721c70ad010c26c","unresolved":false,"context_lines":[{"line_number":3210,"context_line":"                      \u0027emsg\u0027: emsg,"},{"line_number":3211,"context_line":"                      \u0027clidata\u0027: clidata})"},{"line_number":3212,"context_line":"            LOG.error(msg)"},{"line_number":3213,"context_line":"            raise Exception(msg)"},{"line_number":3214,"context_line":""},{"line_number":3215,"context_line":"        LOG.debug(\u0027_get_copy_sessions_list, Exit method, \u0027"},{"line_number":3216,"context_line":"                  \u0027copy sessions list: %(clidata)s. \u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"c194fe7b_ed47b6b3","line":3213,"in_reply_to":"f3710bad_0a195e84","updated":"2024-04-01 09:02:52.000000000","message":"Done","commit_id":"77ccece9264cdf53fc87dd4bd336790d4d4f1f08"}]}