)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"c8bee6a23025738409737ca773384b50182e22fb","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Dell EMC: PowerMax - Configurable SRDF snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add \u0027powermax:disable_protected_snap\u0027 setting."},{"line_number":10,"context_line":"Implements blueprint powermax-protected-snap-config."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"When set to True, snapshot won\u0027t be replicated and won\u0027t"},{"line_number":13,"context_line":"match the source volume type, it will be a regular device"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":66,"id":"49679601_e561c8f3","line":10,"updated":"2024-01-09 10:47:09.000000000","message":"Should be at the end of the commit message.","commit_id":"5f945e8319a2786aada5a81615bbbf5e835e0b05"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"8c3994a323bbb572d0baff914f2ad40eabdc5f79","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Dell EMC: PowerMax - Configurable SRDF snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add \u0027powermax:disable_protected_snap\u0027 setting."},{"line_number":10,"context_line":"Implements blueprint powermax-protected-snap-config."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"When set to True, snapshot won\u0027t be replicated and won\u0027t"},{"line_number":13,"context_line":"match the source volume type, it will be a regular device"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":66,"id":"be9bb69c_5f534e72","line":10,"in_reply_to":"49679601_e561c8f3","updated":"2024-01-17 00:35:03.000000000","message":"Done","commit_id":"5f945e8319a2786aada5a81615bbbf5e835e0b05"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"203e2a995927d09043f7d33a9682028254a16472","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-02-22 13:16:57 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell EMC: PowerMax - Configurable SRDF snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add \u0027powermax:disable_protected_snap\u0027 setting."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"When set to True, snapshot won\u0027t be replicated and won\u0027t"},{"line_number":12,"context_line":"match the source volume type, it will be a regular device"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":77,"id":"698f339d_6c228fc0","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":46},"updated":"2024-02-26 18:07:53.000000000","message":"Add volume type extra spec property \u0027powermax:disable_protected_snap\u0027","commit_id":"530be19de08de269bf42d00e4ff97165dfc5f428"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"1905cedf3e7f5918fd0b294df07ab126523213e2","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-02-22 13:16:57 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell EMC: PowerMax - Configurable SRDF snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add \u0027powermax:disable_protected_snap\u0027 setting."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"When set to True, snapshot won\u0027t be replicated and won\u0027t"},{"line_number":12,"context_line":"match the source volume type, it will be a regular device"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":77,"id":"da36efb0_0d598b6b","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":46},"in_reply_to":"698f339d_6c228fc0","updated":"2024-02-26 21:33:37.000000000","message":"Resolved, thanks.","commit_id":"530be19de08de269bf42d00e4ff97165dfc5f428"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"203e2a995927d09043f7d33a9682028254a16472","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Dell EMC: PowerMax - Configurable SRDF snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add \u0027powermax:disable_protected_snap\u0027 setting."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"When set to True, snapshot won\u0027t be replicated and won\u0027t"},{"line_number":12,"context_line":"match the source volume type, it will be a regular device"},{"line_number":13,"context_line":"no matter what."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":77,"id":"11c43d60_f2dcaba1","line":10,"updated":"2024-02-26 18:07:53.000000000","message":"we should mention that we are introducing a new volume type property here and what are the possible values for it","commit_id":"530be19de08de269bf42d00e4ff97165dfc5f428"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"1905cedf3e7f5918fd0b294df07ab126523213e2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Dell EMC: PowerMax - Configurable SRDF snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add \u0027powermax:disable_protected_snap\u0027 setting."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"When set to True, snapshot won\u0027t be replicated and won\u0027t"},{"line_number":12,"context_line":"match the source volume type, it will be a regular device"},{"line_number":13,"context_line":"no matter what."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":77,"id":"c38c04bf_85790891","line":10,"in_reply_to":"11c43d60_f2dcaba1","updated":"2024-02-26 21:33:37.000000000","message":"Thanks @Rajat, I updated the commit message.","commit_id":"530be19de08de269bf42d00e4ff97165dfc5f428"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f1f8a11b25f21a7b69d3023a59e70531574221ed","unresolved":true,"context_lines":[{"line_number":14,"context_line":"match the source volume type, it will be a regular device"},{"line_number":15,"context_line":"no matter what."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"If set to False (default value) then the way cinder will"},{"line_number":18,"context_line":"handle won\u0027t change from what it\u0027s currently doing for now."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Implements blueprint powermax-protected-snap-config"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ib74c4730d937be8b907c82ac03d3fd26d9079d84"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":81,"id":"e7530878_62d79f68","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":0},"updated":"2024-02-28 04:09:41.000000000","message":"nit: This isn\u0027t quite right because it\u0027s not a config option any more.  Maybe say something like \"If the property is not enabled in extra_specs, then there is no change from the current behavior .\"","commit_id":"82fb879c836b7de9472fe380ad056311a4ea3e0b"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"d7ccb3bf37a87569e940480ecf1ab65650c79bf7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"match the source volume type, it will be a regular device"},{"line_number":15,"context_line":"no matter what."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"If set to False (default value) then the way cinder will"},{"line_number":18,"context_line":"handle won\u0027t change from what it\u0027s currently doing for now."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Implements blueprint powermax-protected-snap-config"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ib74c4730d937be8b907c82ac03d3fd26d9079d84"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":81,"id":"022be3a0_e194c7ac","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":0},"in_reply_to":"e7530878_62d79f68","updated":"2024-02-28 15:26:32.000000000","message":"@Brian, \nThanks I\u0027ve updated the message.","commit_id":"82fb879c836b7de9472fe380ad056311a4ea3e0b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"1fe6b5947584fb67cb9d85f1f163a63901d107f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"c4216e2a_627da0ae","updated":"2023-11-17 08:11:47.000000000","message":"Pep8/flake8 issues to be fixed.\nAdd a release note.","commit_id":"9256a374d16aa33a3b55b5aa272b0ed4aef23ee6"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"c4f2a14b5683baf04118e51943c6e72fc88f6109","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"fc6441e1_c4e923e4","in_reply_to":"c4216e2a_627da0ae","updated":"2023-11-20 18:39:55.000000000","message":"@happystacker,\nThanks for pointing that out. I\u0027ve update the commit with the release note for the change.","commit_id":"9256a374d16aa33a3b55b5aa272b0ed4aef23ee6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"a40711f163023d63c47235c9a89a52e988c04795","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":63,"id":"1497907a_c8bae446","updated":"2024-01-03 15:38:26.000000000","message":"recheck tempest-slow-py3 ssh Request timed out","commit_id":"889061ebe0b408f5103b28ebd29238e3d16bca4e"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"d5659142aaacdf60544566e16554bf2c4bf9227c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":65,"id":"89a218e7_b8438c90","updated":"2024-01-03 20:08:56.000000000","message":"do you have a blueprint registered for that? SHould be good to have one.","commit_id":"37ee056e208c698ea4e5888348193664930b8b95"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"ee699f08a4f838c14a96c000ce56208f3c3cfd5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":65,"id":"ef85ac8f_304fb16b","in_reply_to":"0e1e7b86_3fcf3040","updated":"2024-01-09 00:07:02.000000000","message":"Awesome. Commented updated with the blueprint.","commit_id":"37ee056e208c698ea4e5888348193664930b8b95"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"58ee4674e7b7ebf8b339759d4dafd5451082d3b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":65,"id":"0e1e7b86_3fcf3040","in_reply_to":"89a218e7_b8438c90","updated":"2024-01-03 20:10:54.000000000","message":"my bad, just found it\nhttps://blueprints.launchpad.net/cinder/+spec/powermax-protected-snap-config","commit_id":"37ee056e208c698ea4e5888348193664930b8b95"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"33085a301a8a3efdad1d13f56ac41d078279d958","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":70,"id":"6b4e83c3_b727c4da","updated":"2024-01-22 13:03:06.000000000","message":"recheck tempest-integrated-storage time-out","commit_id":"2b9fdf230c06b0cb3ed2db1c319256af54303e1e"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"5188c05c474f3f5eeaebdde9f3d37ce9d6cc5c0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":73,"id":"02fb5bd4_56405688","updated":"2024-02-07 13:40:37.000000000","message":"recheck tempest-integrated-storage failures","commit_id":"901e6848536ca26c4d213e7c30de9f25c9915469"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"4cf15f8f26498abb114a6bad0a263b86277fdd1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":75,"id":"4866dc70_c1df0571","updated":"2024-02-19 09:06:02.000000000","message":"Don\u0027t you think that a few more unit tests should be there?","commit_id":"5dfa530ab041266a9b3fb6d1dd2c2f97d13bf333"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"ed6c88b5a6a011a3d3312f8de271d90e3f4b768c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":75,"id":"aa95def8_e3f3fea7","updated":"2024-02-14 16:37:39.000000000","message":"Recheck DellEMC_PowerMAX_iSCSI","commit_id":"5dfa530ab041266a9b3fb6d1dd2c2f97d13bf333"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"268af64f75495befb0ec9c1b31afc884644cd290","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":75,"id":"3db9fec2_dc221280","updated":"2024-02-14 16:30:07.000000000","message":"Recheck build-openstack-releasenotes","commit_id":"5dfa530ab041266a9b3fb6d1dd2c2f97d13bf333"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"e8501d164d8d22829b396e67264e2b2644cfb573","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":75,"id":"7b11a09b_e3483c90","updated":"2024-02-14 21:39:29.000000000","message":"Run DellEMC_PowerMAX_FC","commit_id":"5dfa530ab041266a9b3fb6d1dd2c2f97d13bf333"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"68b9548d452b3cd4c562db6aec1690e9d5ab540f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":75,"id":"8252b8b1_12a6adaf","updated":"2024-02-14 18:35:31.000000000","message":"Run DellEMC_PowerMAX_FC","commit_id":"5dfa530ab041266a9b3fb6d1dd2c2f97d13bf333"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"27bed12fd58ea65238e6826e8f2b8bdddb49fac7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":75,"id":"46c7a76c_d5cc45a7","updated":"2024-02-19 08:49:52.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"5dfa530ab041266a9b3fb6d1dd2c2f97d13bf333"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"5df2e47f74f1d661e51e2272c287e149bc7bcb9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":75,"id":"6c72320b_4cc62f0e","updated":"2024-02-14 16:26:45.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"5dfa530ab041266a9b3fb6d1dd2c2f97d13bf333"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"d5a1f8048bb57971d66c5f72e862c5faa1ef5686","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":75,"id":"1f0f58d6_99cd344d","in_reply_to":"4866dc70_c1df0571","updated":"2024-02-28 18:54:45.000000000","message":"Sorry @happystacker, I missed this comment. I think that is a good idea. I will create a follow-up patch.","commit_id":"5dfa530ab041266a9b3fb6d1dd2c2f97d13bf333"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9903c5e8c3b1defb28bba34ef4c4dcbf3f10ce31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":76,"id":"a190dfe2_9ea3082e","updated":"2024-02-22 16:57:40.000000000","message":"I\u0027ve been struggling with understanding exactly what this patch is about from the release note and config option help text.  I guess this would make sense to a dell user?  I mean, snapshots are traditionally supposed to be kind of lightweight, so does powermax do a full clone of the volume when you\u0027re in replication mode?  I am confused, maybe you can point me to some docs, or just explain more clearly.","commit_id":"50be986be5e881fe29e0f45266bdd44a8984680b"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"81e7379b5f86c496d472e406fd0a2ad39b8e1d8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":76,"id":"85d3a91e_8f25c1c5","updated":"2024-02-20 20:17:47.000000000","message":"Run DellEMC_PowerFlex_3.6","commit_id":"50be986be5e881fe29e0f45266bdd44a8984680b"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"6ab0ee5673af27442fbd7ec44e9a8f09af2d03e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":76,"id":"081e7120_fcc39ae2","updated":"2024-02-20 20:23:01.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"50be986be5e881fe29e0f45266bdd44a8984680b"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"fbb3b3e194074b959a1252151a3bde1e5b5b3e4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":76,"id":"c0520545_d4db552d","updated":"2024-02-20 20:23:49.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"50be986be5e881fe29e0f45266bdd44a8984680b"},{"author":{"_account_id":17450,"name":"Chongchong Lei","email":"Nathaniel.Lei@dell.com","username":"Chongchong","status":"Dell EMC"},"change_message_id":"9dacfc27eea9e915f15aa92551005e7c55b56f11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":76,"id":"b868519c_861e0e3c","updated":"2024-02-21 08:22:11.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"50be986be5e881fe29e0f45266bdd44a8984680b"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"c88be5fdc3058070b67c038030995e96e9a06248","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":76,"id":"774ccd81_ead5db65","in_reply_to":"a190dfe2_9ea3082e","updated":"2024-02-22 17:27:41.000000000","message":"Hey Bryan.\nSo basically here\u0027s the workflow. Let\u0027s say we have a production system which uses a basic volume. Then the user wants to work with a snapshot for backup/tesing purposes. He takes a snapshot which is a PIT copy of the production volume, creates a new volumes which will be linked to that snapshot. That being said, he can now use this volumes as a regular one, and make it available to any purpose he wants without touching the production volume. When he has finished, he can delete the volume but the snapshot is still there awaiting any other link operation.\n\nAs a result, there is one to one mapping between the production volume and the snapshot volume. Production volume -\u003e snapshot -\u003e linked volume.\n\nThings get complicated when the source volume (the production) is replicated as the driver\u0027s logic tell cinder to create a snap at both source and target array, and link each of these snapshots to new volumes.\n\nAs a result, when a snapshot is taken at the source array, the same happens at the remote array and a volume is linked at the snapshots on each site. This is how the logic is implemented today. \n\nThis doesn\u0027t always make sense as taking a snapshot at the remote array may not be always appropriate depending on the use case and purpose, testing for example.\n\nThis patch enables the user to override the current logic of the driver and avoid to create unnecessary volumes at the target site which can add overload of the array without any reason.\n\nThe current logic remains present and is used by default. If the user wants to prevent the current logic to occur, he can set disable_protected_snap to True.\n\nHope that makes sense.","commit_id":"50be986be5e881fe29e0f45266bdd44a8984680b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c54120d501b9dbc2a83571ce102f41628a484691","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":77,"id":"584e2e8c_d2554c4a","updated":"2024-02-26 17:15:08.000000000","message":"@happystacker: thanks for the explanation!\n@bryanneumann: some questions inline.","commit_id":"530be19de08de269bf42d00e4ff97165dfc5f428"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"894a192897a2fc5e38961a9f1964cb019348fb91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":77,"id":"359314aa_f3136b01","updated":"2024-02-22 19:08:11.000000000","message":"Recheck openstack-tox-py38-arm64","commit_id":"530be19de08de269bf42d00e4ff97165dfc5f428"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"203e2a995927d09043f7d33a9682028254a16472","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":77,"id":"f33344ec_f238a612","updated":"2024-02-26 18:07:53.000000000","message":"few comments inline but agree with Brian that we should remove the config option and revise the releasenote and commit msg to mention the extra spec property","commit_id":"530be19de08de269bf42d00e4ff97165dfc5f428"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e84e6bf55c1733d44decdb77b1d89ebe260c6d0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":78,"id":"8a29ad9d_34c84a6f","updated":"2024-02-27 12:53:48.000000000","message":"I agree with Rajat\u0027s points; a few other comments inline.","commit_id":"312984ec09530acc5e0e86cd50d549153b3c4ec7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cdb8a6952c85776abd1c813c826c412446b1fffd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":78,"id":"b615251f_3428c9be","updated":"2024-02-27 08:12:28.000000000","message":"recheck lvm-lio-barbican failed with unrelated test\n\nDetails: group_snapshot e4fa4a37-01a8-4fc6-aed1-4669741ca115 failed to reach creating status (current available) within the required time (300 s).","commit_id":"312984ec09530acc5e0e86cd50d549153b3c4ec7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5172aa6ccd0eb9eff16bd120f69824c711e285d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":78,"id":"ef9d6cb2_2268e2a0","updated":"2024-02-27 08:27:33.000000000","message":"this looks close to ready, final few comments inline","commit_id":"312984ec09530acc5e0e86cd50d549153b3c4ec7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"338504f596f0e7897c945c53af515df0e37f04e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":79,"id":"06e3521d_10da99a7","updated":"2024-02-27 16:33:20.000000000","message":"i think we did some wrong changes in this patchset","commit_id":"d0b2cad7936a43b90ca83d33e2e5153c94cfee9c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b8f9960fedf6891b20a2df340772a2a2b5be5939","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":80,"id":"c83a93e7_03f1a40a","updated":"2024-02-27 17:41:25.000000000","message":"All my comments are addressed, would\u0027ve been better to see more extensive UT coverage but that can be done in a followup. LGTM.\nwill upgrade to +2 when CI is green","commit_id":"4217e96aee230e83ac718cda3cacf057bd46dcfe"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d5961bf5e202a2c32f7c6bf0013ee427d689d7df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":81,"id":"fa5bb4ef_4b9d9f60","updated":"2024-02-28 11:41:17.000000000","message":"LGTM, waiting for Powermax CI","commit_id":"82fb879c836b7de9472fe380ad056311a4ea3e0b"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"100acf0f77b8f94975b2cd721b30e290ce0e97ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":81,"id":"2682cb78_e1c4f2ef","updated":"2024-02-27 20:55:10.000000000","message":"Recheck build-openstack-releasenotes","commit_id":"82fb879c836b7de9472fe380ad056311a4ea3e0b"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"f986e6e4caf06087ebf4973ade354c6abfd16a93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":81,"id":"e993a756_83ebff44","updated":"2024-02-27 21:15:23.000000000","message":"Recheck grenade-skip-level","commit_id":"82fb879c836b7de9472fe380ad056311a4ea3e0b"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"e232b7b0f22a813bf784d791e3aa3ab53c154622","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":81,"id":"c277cf47_0e56dcd8","updated":"2024-02-28 14:11:28.000000000","message":"Recheck openstacksdk-functional-devstack","commit_id":"82fb879c836b7de9472fe380ad056311a4ea3e0b"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"3eaaef7e925327df30f3e9f90a7486a33d38113d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":81,"id":"77491277_0b621d79","updated":"2024-02-27 23:14:22.000000000","message":"Recheck tempest-slow-py3","commit_id":"82fb879c836b7de9472fe380ad056311a4ea3e0b"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"ca50137aae0bbc9f1902f3307874e8ff44cf4feb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":81,"id":"a27b80a2_9947bddf","updated":"2024-02-27 21:02:25.000000000","message":"Run grenade-skip-level","commit_id":"82fb879c836b7de9472fe380ad056311a4ea3e0b"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"3c0b90189d8ce40152d5a82e44fecda05af94f43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":81,"id":"09291031_8ec9b71e","updated":"2024-02-28 15:05:08.000000000","message":"Run-DellEMC PowerMAX CI","commit_id":"82fb879c836b7de9472fe380ad056311a4ea3e0b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f1f8a11b25f21a7b69d3023a59e70531574221ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":81,"id":"cd9ca035_2469180c","updated":"2024-02-28 04:09:41.000000000","message":"Two nits noted inline if you need to push another patch set.  I agree with Rajat that this could use some unit tests to verify that the extra spec is being detected correctly, but like he said, you can do that in a followup patch.\n\n+1 while waiting for the PowerMax CI to respond green.","commit_id":"82fb879c836b7de9472fe380ad056311a4ea3e0b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"eca8cf3b34ed7eae2324cf636757753d0c4b3669","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":81,"id":"35bf4f80_c853454f","updated":"2024-02-28 03:33:07.000000000","message":"recheck tempest-slow-py3 - test_volume_retype_attached_data_volume couldn\u0027t mount /mnt/vdb","commit_id":"82fb879c836b7de9472fe380ad056311a4ea3e0b"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"103ef0cb988e85ebd036af9c5b97ef908663185a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":81,"id":"f47b9616_6f0e6159","updated":"2024-02-28 15:17:41.000000000","message":"run-openstacksdk-functional-devstack","commit_id":"82fb879c836b7de9472fe380ad056311a4ea3e0b"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"1f61a84d15055e50581cb4f296422b448676f92a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":81,"id":"af3ded85_bc118ac7","updated":"2024-02-27 23:13:32.000000000","message":"tempest-slow-py3","commit_id":"82fb879c836b7de9472fe380ad056311a4ea3e0b"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"3c0b90189d8ce40152d5a82e44fecda05af94f43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":81,"id":"8bb80950_d3bd1238","in_reply_to":"cd9ca035_2469180c","updated":"2024-02-28 15:05:08.000000000","message":"Thank you @Brian Rosmaita, I\u0027ve added a note to myself to follow up on this.","commit_id":"82fb879c836b7de9472fe380ad056311a4ea3e0b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"88685979a41e02a71cb6954dcc19b4a548fb8a41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":83,"id":"900a72ac_cdd1ac7d","updated":"2024-02-28 20:31:35.000000000","message":"Another nit on the release note.","commit_id":"9ca5614bc85a5a76915a33a8aa5a777e7dc60846"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"2385e2db0c2fd167b635bd34d3b723d41bd32938","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":83,"id":"e6ed4dbc_f9bd798d","updated":"2024-02-28 18:16:22.000000000","message":"Recheck tempest-slow-py3","commit_id":"9ca5614bc85a5a76915a33a8aa5a777e7dc60846"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"cc46decc74f2cf215387e04314146deae2154cb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":83,"id":"b10d2ccf_63af5742","updated":"2024-02-28 19:44:25.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"9ca5614bc85a5a76915a33a8aa5a777e7dc60846"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"b9a7ed29001e1032711ae4f14d48f1ac3da38411","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":84,"id":"b3be5e8d_e2fa8a6b","updated":"2024-02-28 20:57:09.000000000","message":"Run-tempest-slow-py3","commit_id":"b3a441a1f30e70ea4e5e8737b86cb889ca894302"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"efa2049979598e9b4e85ed9210f800aca30a4b3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":85,"id":"71958673_258bd30a","updated":"2024-02-28 21:39:59.000000000","message":"Here\u0027s a link to the py311 job in case we need to look at it later:\nhttps://zuul.opendev.org/t/openstack/build/626e79528d5148a4b1d009a95961c742","commit_id":"ee0f0dee90d3c29927854f2852fe4799937eecb3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"758675d476bf523705bd3362da09f0554f9a96f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":85,"id":"ef692f92_34e125bb","updated":"2024-02-28 21:36:59.000000000","message":"The releasenotes job was failing because sphinx had trouble parsing a comma before two backticks without an intervening space.\n\nNot sure why the py311 job failed; it passes for me locally.","commit_id":"ee0f0dee90d3c29927854f2852fe4799937eecb3"}],"cinder/volume/drivers/dell_emc/powermax/common.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c54120d501b9dbc2a83571ce102f41628a484691","unresolved":true,"context_lines":[{"line_number":101,"context_line":"    cfg.BoolOpt(utils.DISABLE_PROTECTED_SNAP,"},{"line_number":102,"context_line":"                default\u003dFalse,"},{"line_number":103,"context_line":"                help\u003d\u0027When set to True, volume snapshot volumes will not be\u0027"},{"line_number":104,"context_line":"                     \u0027replicated.\u0027),"},{"line_number":105,"context_line":"    cfg.StrOpt(utils.POWERMAX_ARRAY,"},{"line_number":106,"context_line":"               help\u003d\u0027Serial number of the array to connect to.\u0027),"},{"line_number":107,"context_line":"    cfg.StrOpt(utils.POWERMAX_SRP,"}],"source_content_type":"text/x-python","patch_set":77,"id":"dd68a2b8_0397b3f6","line":104,"updated":"2024-02-26 17:15:08.000000000","message":"I\u0027m a bit confused by this option.  I don\u0027t think it\u0027s used anywhere.  AFAICT, the option is controlled entirely by extra-specs (which makes sense), and the option is reported by _init_vendor_properties(), which is correct.  So I think this opt should be removed.","commit_id":"530be19de08de269bf42d00e4ff97165dfc5f428"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"203e2a995927d09043f7d33a9682028254a16472","unresolved":true,"context_lines":[{"line_number":101,"context_line":"    cfg.BoolOpt(utils.DISABLE_PROTECTED_SNAP,"},{"line_number":102,"context_line":"                default\u003dFalse,"},{"line_number":103,"context_line":"                help\u003d\u0027When set to True, volume snapshot volumes will not be\u0027"},{"line_number":104,"context_line":"                     \u0027replicated.\u0027),"},{"line_number":105,"context_line":"    cfg.StrOpt(utils.POWERMAX_ARRAY,"},{"line_number":106,"context_line":"               help\u003d\u0027Serial number of the array to connect to.\u0027),"},{"line_number":107,"context_line":"    cfg.StrOpt(utils.POWERMAX_SRP,"}],"source_content_type":"text/x-python","patch_set":77,"id":"fb78c0aa_a9c6c38a","line":104,"in_reply_to":"dd68a2b8_0397b3f6","updated":"2024-02-26 18:07:53.000000000","message":"+1, either we need a config option or a volume type extra spec, both are configurable by operators so one should suffice\nI see the code being modified for volume type extra spec so this can be removed\nAlso we should mention in the commit message about the new extra spec","commit_id":"530be19de08de269bf42d00e4ff97165dfc5f428"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"1905cedf3e7f5918fd0b294df07ab126523213e2","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    cfg.BoolOpt(utils.DISABLE_PROTECTED_SNAP,"},{"line_number":102,"context_line":"                default\u003dFalse,"},{"line_number":103,"context_line":"                help\u003d\u0027When set to True, volume snapshot volumes will not be\u0027"},{"line_number":104,"context_line":"                     \u0027replicated.\u0027),"},{"line_number":105,"context_line":"    cfg.StrOpt(utils.POWERMAX_ARRAY,"},{"line_number":106,"context_line":"               help\u003d\u0027Serial number of the array to connect to.\u0027),"},{"line_number":107,"context_line":"    cfg.StrOpt(utils.POWERMAX_SRP,"}],"source_content_type":"text/x-python","patch_set":77,"id":"102ad67c_1fc6b80b","line":104,"in_reply_to":"fb78c0aa_a9c6c38a","updated":"2024-02-26 21:33:37.000000000","message":"Thanks @Brian \u0026 @Rajat for pointing this out. Initially I had confused properties of the volume extra specs and the driver configuration properties in cinder.conf.","commit_id":"530be19de08de269bf42d00e4ff97165dfc5f428"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5172aa6ccd0eb9eff16bd120f69824c711e285d8","unresolved":true,"context_lines":[{"line_number":1575,"context_line":"                if rep_config.get(utils.METROBIAS):"},{"line_number":1576,"context_line":"                    extra_specs[utils.METROBIAS] \u003d ("},{"line_number":1577,"context_line":"                        rep_config[utils.METROBIAS])"},{"line_number":1578,"context_line":"            if extra_specs.get(utils.DISABLE_PROTECTED_SNAP) \u003d\u003d \u0027\u003cis\u003e True\u0027:"},{"line_number":1579,"context_line":"                extra_specs[utils.DISABLE_PROTECTED_SNAP] \u003d True"},{"line_number":1580,"context_line":"        return extra_specs, qos_specs"},{"line_number":1581,"context_line":""}],"source_content_type":"text/x-python","patch_set":78,"id":"b70799de_21f6e6e1","line":1578,"range":{"start_line":1578,"start_character":64,"end_line":1578,"end_character":75},"updated":"2024-02-27 08:27:33.000000000","message":"shouldn\u0027t we check against all the values that we support as mentioned in the commit message?\n\n`\u0027\u003cis\u003e True\u0027`,`\u0027True\u0027`, `\u0027true\u0027`, or True","commit_id":"312984ec09530acc5e0e86cd50d549153b3c4ec7"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"a63be56a1bdc86fbbf0966c40ac45541b777ef42","unresolved":false,"context_lines":[{"line_number":1575,"context_line":"                if rep_config.get(utils.METROBIAS):"},{"line_number":1576,"context_line":"                    extra_specs[utils.METROBIAS] \u003d ("},{"line_number":1577,"context_line":"                        rep_config[utils.METROBIAS])"},{"line_number":1578,"context_line":"            if extra_specs.get(utils.DISABLE_PROTECTED_SNAP) \u003d\u003d \u0027\u003cis\u003e True\u0027:"},{"line_number":1579,"context_line":"                extra_specs[utils.DISABLE_PROTECTED_SNAP] \u003d True"},{"line_number":1580,"context_line":"        return extra_specs, qos_specs"},{"line_number":1581,"context_line":""}],"source_content_type":"text/x-python","patch_set":78,"id":"6e1f8afe_70e8b7f3","line":1578,"range":{"start_line":1578,"start_character":64,"end_line":1578,"end_character":75},"in_reply_to":"7d28fe5c_4a0d21e9","updated":"2024-02-27 16:18:04.000000000","message":"Thank you, I updated the file. This should have been using the is_protected_snap_disabled function I added.","commit_id":"312984ec09530acc5e0e86cd50d549153b3c4ec7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e84e6bf55c1733d44decdb77b1d89ebe260c6d0b","unresolved":true,"context_lines":[{"line_number":1575,"context_line":"                if rep_config.get(utils.METROBIAS):"},{"line_number":1576,"context_line":"                    extra_specs[utils.METROBIAS] \u003d ("},{"line_number":1577,"context_line":"                        rep_config[utils.METROBIAS])"},{"line_number":1578,"context_line":"            if extra_specs.get(utils.DISABLE_PROTECTED_SNAP) \u003d\u003d \u0027\u003cis\u003e True\u0027:"},{"line_number":1579,"context_line":"                extra_specs[utils.DISABLE_PROTECTED_SNAP] \u003d True"},{"line_number":1580,"context_line":"        return extra_specs, qos_specs"},{"line_number":1581,"context_line":""}],"source_content_type":"text/x-python","patch_set":78,"id":"7d28fe5c_4a0d21e9","line":1578,"range":{"start_line":1578,"start_character":64,"end_line":1578,"end_character":75},"in_reply_to":"b70799de_21f6e6e1","updated":"2024-02-27 12:53:48.000000000","message":"This is a good catch.  I thought you used a function somewhere else that handles this (or I may be thinking of a different patch).","commit_id":"312984ec09530acc5e0e86cd50d549153b3c4ec7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e84e6bf55c1733d44decdb77b1d89ebe260c6d0b","unresolved":true,"context_lines":[{"line_number":1576,"context_line":"                    extra_specs[utils.METROBIAS] \u003d ("},{"line_number":1577,"context_line":"                        rep_config[utils.METROBIAS])"},{"line_number":1578,"context_line":"            if extra_specs.get(utils.DISABLE_PROTECTED_SNAP) \u003d\u003d \u0027\u003cis\u003e True\u0027:"},{"line_number":1579,"context_line":"                extra_specs[utils.DISABLE_PROTECTED_SNAP] \u003d True"},{"line_number":1580,"context_line":"        return extra_specs, qos_specs"},{"line_number":1581,"context_line":""},{"line_number":1582,"context_line":"    def _get_replicated_volume_backend_id(self, volume):"}],"source_content_type":"text/x-python","patch_set":78,"id":"b6a765e5_86810e3a","line":1579,"updated":"2024-02-27 12:53:48.000000000","message":"Also, mixing types like this always worries me.  Note that if someone has an extra spec powermax:disable_protected_snap: \u003cis\u003e False, if you treat extra_specs[utils.DISABLE_PROTECTED_SNAP] as a boolean, it will evaluate to True in that case.\n\nProbably the safest thing to do here is to definitely set extra_specs[utils.DISABLE_PROTECTED_SNAP] to either True or False.","commit_id":"312984ec09530acc5e0e86cd50d549153b3c4ec7"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"a63be56a1bdc86fbbf0966c40ac45541b777ef42","unresolved":false,"context_lines":[{"line_number":1576,"context_line":"                    extra_specs[utils.METROBIAS] \u003d ("},{"line_number":1577,"context_line":"                        rep_config[utils.METROBIAS])"},{"line_number":1578,"context_line":"            if extra_specs.get(utils.DISABLE_PROTECTED_SNAP) \u003d\u003d \u0027\u003cis\u003e True\u0027:"},{"line_number":1579,"context_line":"                extra_specs[utils.DISABLE_PROTECTED_SNAP] \u003d True"},{"line_number":1580,"context_line":"        return extra_specs, qos_specs"},{"line_number":1581,"context_line":""},{"line_number":1582,"context_line":"    def _get_replicated_volume_backend_id(self, volume):"}],"source_content_type":"text/x-python","patch_set":78,"id":"d583ee0a_cc3581f4","line":1579,"in_reply_to":"b6a765e5_86810e3a","updated":"2024-02-27 16:18:04.000000000","message":"Thank you for pointing this out @Brian. I made use of the is_protected_snap_disabled function I added and explicitly set extra_specs[utils.DISABLE_PROTECTED_SNAP] to either True or False.","commit_id":"312984ec09530acc5e0e86cd50d549153b3c4ec7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"338504f596f0e7897c945c53af515df0e37f04e1","unresolved":true,"context_lines":[{"line_number":217,"context_line":"        self.powermax_array_tag_list \u003d None"},{"line_number":218,"context_line":"        self.powermax_short_host_name_template \u003d None"},{"line_number":219,"context_line":"        self.powermax_port_group_name_template \u003d None"},{"line_number":220,"context_line":"        self.powermax_disable_protected_snap \u003d False"},{"line_number":221,"context_line":"        if active_backend_id \u003d\u003d utils.PMAX_FAILOVER_START_ARRAY_PROMOTION:"},{"line_number":222,"context_line":"            self.promotion \u003d True"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":79,"id":"46f74c33_3102de3d","line":220,"range":{"start_line":220,"start_character":0,"end_line":220,"end_character":52},"updated":"2024-02-27 16:33:20.000000000","message":"maybe i missed out this parameter in previous review but here this is unused ...","commit_id":"d0b2cad7936a43b90ca83d33e2e5153c94cfee9c"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"a4aacdf1f141e35368bd855edc216acb9e408421","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        self.powermax_array_tag_list \u003d None"},{"line_number":218,"context_line":"        self.powermax_short_host_name_template \u003d None"},{"line_number":219,"context_line":"        self.powermax_port_group_name_template \u003d None"},{"line_number":220,"context_line":"        self.powermax_disable_protected_snap \u003d False"},{"line_number":221,"context_line":"        if active_backend_id \u003d\u003d utils.PMAX_FAILOVER_START_ARRAY_PROMOTION:"},{"line_number":222,"context_line":"            self.promotion \u003d True"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":79,"id":"e22ac24f_6c3e4b29","line":220,"range":{"start_line":220,"start_character":0,"end_line":220,"end_character":52},"in_reply_to":"46f74c33_3102de3d","updated":"2024-02-27 17:18:25.000000000","message":"@Rajat,\nRemoved, thanks.","commit_id":"d0b2cad7936a43b90ca83d33e2e5153c94cfee9c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"338504f596f0e7897c945c53af515df0e37f04e1","unresolved":true,"context_lines":[{"line_number":1575,"context_line":"                if rep_config.get(utils.METROBIAS):"},{"line_number":1576,"context_line":"                    extra_specs[utils.METROBIAS] \u003d ("},{"line_number":1577,"context_line":"                        rep_config[utils.METROBIAS])"},{"line_number":1578,"context_line":"            if self.utils.is_protected_snap_disabled(extra_specs):"},{"line_number":1579,"context_line":"                extra_specs[utils.DISABLE_PROTECTED_SNAP] \u003d True"},{"line_number":1580,"context_line":"            else:"},{"line_number":1581,"context_line":"                extra_specs[utils.DISABLE_PROTECTED_SNAP] \u003d False"},{"line_number":1582,"context_line":"        return extra_specs, qos_specs"},{"line_number":1583,"context_line":""},{"line_number":1584,"context_line":"    def _get_replicated_volume_backend_id(self, volume):"}],"source_content_type":"text/x-python","patch_set":79,"id":"2f62e97d_0a823e4c","line":1581,"range":{"start_line":1578,"start_character":12,"end_line":1581,"end_character":65},"updated":"2024-02-27 16:33:20.000000000","message":"nit: i think the method already returns the right boolean given the extra spec\n\n    extra_specs[utils.DISABLE_PROTECTED_SNAP] \u003d self.utils.is_protected_snap_disabled(extra_specs)","commit_id":"d0b2cad7936a43b90ca83d33e2e5153c94cfee9c"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"a4aacdf1f141e35368bd855edc216acb9e408421","unresolved":false,"context_lines":[{"line_number":1575,"context_line":"                if rep_config.get(utils.METROBIAS):"},{"line_number":1576,"context_line":"                    extra_specs[utils.METROBIAS] \u003d ("},{"line_number":1577,"context_line":"                        rep_config[utils.METROBIAS])"},{"line_number":1578,"context_line":"            if self.utils.is_protected_snap_disabled(extra_specs):"},{"line_number":1579,"context_line":"                extra_specs[utils.DISABLE_PROTECTED_SNAP] \u003d True"},{"line_number":1580,"context_line":"            else:"},{"line_number":1581,"context_line":"                extra_specs[utils.DISABLE_PROTECTED_SNAP] \u003d False"},{"line_number":1582,"context_line":"        return extra_specs, qos_specs"},{"line_number":1583,"context_line":""},{"line_number":1584,"context_line":"    def _get_replicated_volume_backend_id(self, volume):"}],"source_content_type":"text/x-python","patch_set":79,"id":"44dffda7_24ccd7cc","line":1581,"range":{"start_line":1578,"start_character":12,"end_line":1581,"end_character":65},"in_reply_to":"2f62e97d_0a823e4c","updated":"2024-02-27 17:18:25.000000000","message":"@Rajat,\nGood point, file updated.","commit_id":"d0b2cad7936a43b90ca83d33e2e5153c94cfee9c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b8f9960fedf6891b20a2df340772a2a2b5be5939","unresolved":true,"context_lines":[{"line_number":1574,"context_line":"                if rep_config.get(utils.METROBIAS):"},{"line_number":1575,"context_line":"                    extra_specs[utils.METROBIAS] \u003d ("},{"line_number":1576,"context_line":"                        rep_config[utils.METROBIAS])"},{"line_number":1577,"context_line":"                extra_specs[utils.DISABLE_PROTECTED_SNAP"},{"line_number":1578,"context_line":"                            ] \u003d self.utils.is_protected_snap_disabled("},{"line_number":1579,"context_line":"                                extra_specs)"},{"line_number":1580,"context_line":"        return extra_specs, qos_specs"},{"line_number":1581,"context_line":""},{"line_number":1582,"context_line":"    def _get_replicated_volume_backend_id(self, volume):"}],"source_content_type":"text/x-python","patch_set":80,"id":"8306391a_871235b2","line":1579,"range":{"start_line":1577,"start_character":16,"end_line":1579,"end_character":44},"updated":"2024-02-27 17:41:25.000000000","message":"hope this formatting doesn\u0027t break pep8","commit_id":"4217e96aee230e83ac718cda3cacf057bd46dcfe"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"87c39f3b1572343ada736a977c08f9ba3cd1f340","unresolved":true,"context_lines":[{"line_number":1574,"context_line":"                if rep_config.get(utils.METROBIAS):"},{"line_number":1575,"context_line":"                    extra_specs[utils.METROBIAS] \u003d ("},{"line_number":1576,"context_line":"                        rep_config[utils.METROBIAS])"},{"line_number":1577,"context_line":"                extra_specs[utils.DISABLE_PROTECTED_SNAP"},{"line_number":1578,"context_line":"                            ] \u003d self.utils.is_protected_snap_disabled("},{"line_number":1579,"context_line":"                                extra_specs)"},{"line_number":1580,"context_line":"        return extra_specs, qos_specs"},{"line_number":1581,"context_line":""},{"line_number":1582,"context_line":"    def _get_replicated_volume_backend_id(self, volume):"}],"source_content_type":"text/x-python","patch_set":80,"id":"85c9e719_3302c742","line":1579,"range":{"start_line":1577,"start_character":16,"end_line":1579,"end_character":44},"in_reply_to":"8306391a_871235b2","updated":"2024-02-27 17:50:02.000000000","message":"@Rajat,\n\nIs this preferable?\n+                extra_specs[utils.DISABLE_PROTECTED_SNAP] \u003d\\\n+                    self.utils.is_protected_snap_disabled(extra_specs)","commit_id":"4217e96aee230e83ac718cda3cacf057bd46dcfe"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"234904a544af498ffe71e4ab3bb26bf07372f8d8","unresolved":false,"context_lines":[{"line_number":1574,"context_line":"                if rep_config.get(utils.METROBIAS):"},{"line_number":1575,"context_line":"                    extra_specs[utils.METROBIAS] \u003d ("},{"line_number":1576,"context_line":"                        rep_config[utils.METROBIAS])"},{"line_number":1577,"context_line":"                extra_specs[utils.DISABLE_PROTECTED_SNAP"},{"line_number":1578,"context_line":"                            ] \u003d self.utils.is_protected_snap_disabled("},{"line_number":1579,"context_line":"                                extra_specs)"},{"line_number":1580,"context_line":"        return extra_specs, qos_specs"},{"line_number":1581,"context_line":""},{"line_number":1582,"context_line":"    def _get_replicated_volume_backend_id(self, volume):"}],"source_content_type":"text/x-python","patch_set":80,"id":"d7d21d87_bdd27258","line":1579,"range":{"start_line":1577,"start_character":16,"end_line":1579,"end_character":44},"in_reply_to":"85c9e719_3302c742","updated":"2024-02-27 18:22:43.000000000","message":"Done","commit_id":"4217e96aee230e83ac718cda3cacf057bd46dcfe"}],"cinder/volume/drivers/dell_emc/powermax/fc.py":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"4cf15f8f26498abb114a6bad0a263b86277fdd1c","unresolved":true,"context_lines":[{"line_number":223,"context_line":"        :param context: the context"},{"line_number":224,"context_line":"        :param volume: the cinder volume object"},{"line_number":225,"context_line":"        \"\"\""},{"line_number":226,"context_line":"        pass"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def create_export(self, context, volume, connector):"},{"line_number":229,"context_line":"        \"\"\"Driver entry point to get the export info for a new volume."}],"source_content_type":"text/x-python","patch_set":75,"id":"8ae2af09_fb60f54f","side":"PARENT","line":226,"updated":"2024-02-19 09:06:02.000000000","message":"How those removal are connected to this patch?","commit_id":"e7c8885686cb018e0387d17b1aaeba8e616bb2f4"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"263938722a20e489e850a1f469b0037d5ed59a9d","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        :param context: the context"},{"line_number":224,"context_line":"        :param volume: the cinder volume object"},{"line_number":225,"context_line":"        \"\"\""},{"line_number":226,"context_line":"        pass"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def create_export(self, context, volume, connector):"},{"line_number":229,"context_line":"        \"\"\"Driver entry point to get the export info for a new volume."}],"source_content_type":"text/x-python","patch_set":75,"id":"025538c9_ac14470f","side":"PARENT","line":226,"in_reply_to":"8ae2af09_fb60f54f","updated":"2024-02-19 19:19:27.000000000","message":"Hey @happstacker,\n\nThese 4 changes resolve \"Unnecessary pass statement Pylint W0107:unnecessary-pass\" warnings. I\u0027ll reapply these type of changes in another commit and undo here.","commit_id":"e7c8885686cb018e0387d17b1aaeba8e616bb2f4"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"4cf15f8f26498abb114a6bad0a263b86277fdd1c","unresolved":true,"context_lines":[{"line_number":548,"context_line":"        data[\u0027driver_version\u0027] \u003d self.VERSION"},{"line_number":549,"context_line":"        self._stats \u003d data"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    def manage_existing(self, volume, external_ref):"},{"line_number":552,"context_line":"        \"\"\"Manages an existing PowerMax/VMAX Volume (import to Cinder)."},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"        Renames the Volume to match the expected name for the volume."}],"source_content_type":"text/x-python","patch_set":75,"id":"13e68d4c_86c80459","side":"PARENT","line":551,"updated":"2024-02-19 09:06:02.000000000","message":"Same comment.","commit_id":"e7c8885686cb018e0387d17b1aaeba8e616bb2f4"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"263938722a20e489e850a1f469b0037d5ed59a9d","unresolved":false,"context_lines":[{"line_number":548,"context_line":"        data[\u0027driver_version\u0027] \u003d self.VERSION"},{"line_number":549,"context_line":"        self._stats \u003d data"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    def manage_existing(self, volume, external_ref):"},{"line_number":552,"context_line":"        \"\"\"Manages an existing PowerMax/VMAX Volume (import to Cinder)."},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"        Renames the Volume to match the expected name for the volume."}],"source_content_type":"text/x-python","patch_set":75,"id":"89e37952_c1eb3bb2","side":"PARENT","line":551,"in_reply_to":"13e68d4c_86c80459","updated":"2024-02-19 19:19:27.000000000","message":"Resolved mismatch between the comments and variable names; will move to follow-up commit.","commit_id":"e7c8885686cb018e0387d17b1aaeba8e616bb2f4"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"4cf15f8f26498abb114a6bad0a263b86277fdd1c","unresolved":true,"context_lines":[{"line_number":640,"context_line":"        return self.common.get_manageable_snapshots(marker, limit, offset,"},{"line_number":641,"context_line":"                                                    sort_keys, sort_dirs)"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"    def retype(self, ctxt, volume, new_type, diff, host):"},{"line_number":644,"context_line":"        \"\"\"Migrate volume to another host using retype."},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"        :param ctxt: context"}],"source_content_type":"text/x-python","patch_set":75,"id":"dbf8dac2_2039e7c6","side":"PARENT","line":643,"updated":"2024-02-19 09:06:02.000000000","message":"Same comment.","commit_id":"e7c8885686cb018e0387d17b1aaeba8e616bb2f4"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"263938722a20e489e850a1f469b0037d5ed59a9d","unresolved":false,"context_lines":[{"line_number":640,"context_line":"        return self.common.get_manageable_snapshots(marker, limit, offset,"},{"line_number":641,"context_line":"                                                    sort_keys, sort_dirs)"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"    def retype(self, ctxt, volume, new_type, diff, host):"},{"line_number":644,"context_line":"        \"\"\"Migrate volume to another host using retype."},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"        :param ctxt: context"}],"source_content_type":"text/x-python","patch_set":75,"id":"2fa4af3b_cd013830","side":"PARENT","line":643,"in_reply_to":"dbf8dac2_2039e7c6","updated":"2024-02-19 19:19:27.000000000","message":"@happystacker,\n\nResolves warning \"context\" is not accessed; will apply in a follow-up commit.","commit_id":"e7c8885686cb018e0387d17b1aaeba8e616bb2f4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c54120d501b9dbc2a83571ce102f41628a484691","unresolved":true,"context_lines":[{"line_number":656,"context_line":"    def retype(self, context, volume, new_type, diff, host):"},{"line_number":657,"context_line":"        \"\"\"Migrate volume to another host using retype."},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        :param ctxt: context"},{"line_number":660,"context_line":"        :param volume: the volume object including the volume_type_id"},{"line_number":661,"context_line":"        :param new_type: the new volume type."},{"line_number":662,"context_line":"        :param diff: difference between old and new volume types."}],"source_content_type":"text/x-python","patch_set":77,"id":"7e34f740_fe5e1dd7","line":659,"range":{"start_line":659,"start_character":15,"end_line":659,"end_character":19},"updated":"2024-02-26 17:15:08.000000000","message":"You changed the name of the parameter in the method signature, so you should update this comment.","commit_id":"530be19de08de269bf42d00e4ff97165dfc5f428"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"1905cedf3e7f5918fd0b294df07ab126523213e2","unresolved":false,"context_lines":[{"line_number":656,"context_line":"    def retype(self, context, volume, new_type, diff, host):"},{"line_number":657,"context_line":"        \"\"\"Migrate volume to another host using retype."},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        :param ctxt: context"},{"line_number":660,"context_line":"        :param volume: the volume object including the volume_type_id"},{"line_number":661,"context_line":"        :param new_type: the new volume type."},{"line_number":662,"context_line":"        :param diff: difference between old and new volume types."}],"source_content_type":"text/x-python","patch_set":77,"id":"d22a827e_fba4aa7e","line":659,"range":{"start_line":659,"start_character":15,"end_line":659,"end_character":19},"in_reply_to":"7a0e6ae1_7fa7ff21","updated":"2024-02-26 21:33:37.000000000","message":"Resolved, thank you.","commit_id":"530be19de08de269bf42d00e4ff97165dfc5f428"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"203e2a995927d09043f7d33a9682028254a16472","unresolved":true,"context_lines":[{"line_number":656,"context_line":"    def retype(self, context, volume, new_type, diff, host):"},{"line_number":657,"context_line":"        \"\"\"Migrate volume to another host using retype."},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        :param ctxt: context"},{"line_number":660,"context_line":"        :param volume: the volume object including the volume_type_id"},{"line_number":661,"context_line":"        :param new_type: the new volume type."},{"line_number":662,"context_line":"        :param diff: difference between old and new volume types."}],"source_content_type":"text/x-python","patch_set":77,"id":"7a0e6ae1_7fa7ff21","line":659,"range":{"start_line":659,"start_character":15,"end_line":659,"end_character":19},"in_reply_to":"7e34f740_fe5e1dd7","updated":"2024-02-26 18:07:53.000000000","message":"+1 though this change seems not necessary","commit_id":"530be19de08de269bf42d00e4ff97165dfc5f428"}],"cinder/volume/drivers/dell_emc/powermax/iscsi.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"203e2a995927d09043f7d33a9682028254a16472","unresolved":true,"context_lines":[{"line_number":173,"context_line":"    def check_for_setup_error(self):"},{"line_number":174,"context_line":"        pass"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def _init_vendor_properties(self):"},{"line_number":177,"context_line":"        properties \u003d {}"},{"line_number":178,"context_line":"        self._set_property("},{"line_number":179,"context_line":"            properties,"}],"source_content_type":"text/x-python","patch_set":77,"id":"5d2c19d9_f0109faa","line":176,"range":{"start_line":176,"start_character":8,"end_line":176,"end_character":31},"updated":"2024-02-26 18:07:53.000000000","message":"two questions\n\n1. where is this being called from?\n2. if it\u0027s the same for FC and iSCSI driver, should we move this to the common file?","commit_id":"530be19de08de269bf42d00e4ff97165dfc5f428"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"1905cedf3e7f5918fd0b294df07ab126523213e2","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    def check_for_setup_error(self):"},{"line_number":174,"context_line":"        pass"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def _init_vendor_properties(self):"},{"line_number":177,"context_line":"        properties \u003d {}"},{"line_number":178,"context_line":"        self._set_property("},{"line_number":179,"context_line":"            properties,"}],"source_content_type":"text/x-python","patch_set":77,"id":"79e45a3a_72845e2b","line":176,"range":{"start_line":176,"start_character":8,"end_line":176,"end_character":31},"in_reply_to":"5d2c19d9_f0109faa","updated":"2024-02-26 21:33:37.000000000","message":"Hi @Rajat,\n1. This is called in `init_capabilities()` https://opendev.org/openstack/cinder/src/commit/530be19de08de269bf42d00e4ff97165dfc5f428/cinder/volume/driver.py#L773.\n2.","commit_id":"530be19de08de269bf42d00e4ff97165dfc5f428"}],"cinder/volume/drivers/dell_emc/powermax/metadata.py":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"4cf15f8f26498abb114a6bad0a263b86277fdd1c","unresolved":true,"context_lines":[{"line_number":525,"context_line":"            source_snapshot_id\u003dsource_snapshot_id,"},{"line_number":526,"context_line":"            rep_mode\u003drep_mode, replication_status\u003dreplication_status,"},{"line_number":527,"context_line":"            rdf_group_label\u003drdf_group_label, use_bias\u003duse_bias,"},{"line_number":528,"context_line":"            is_compression_disabled\u003dself.utils.is_compression_disabled("},{"line_number":529,"context_line":"                extra_specs),"},{"line_number":530,"context_line":"            source_device_id\u003dsource_device_id,"},{"line_number":531,"context_line":"            temporary_snapvx\u003dtemporary_snapvx,"}],"source_content_type":"text/x-python","patch_set":75,"id":"345ac353_84dc09d7","side":"PARENT","line":528,"updated":"2024-02-19 09:06:02.000000000","message":"Why ware we removing this option?","commit_id":"e7c8885686cb018e0387d17b1aaeba8e616bb2f4"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"263938722a20e489e850a1f469b0037d5ed59a9d","unresolved":false,"context_lines":[{"line_number":525,"context_line":"            source_snapshot_id\u003dsource_snapshot_id,"},{"line_number":526,"context_line":"            rep_mode\u003drep_mode, replication_status\u003dreplication_status,"},{"line_number":527,"context_line":"            rdf_group_label\u003drdf_group_label, use_bias\u003duse_bias,"},{"line_number":528,"context_line":"            is_compression_disabled\u003dself.utils.is_compression_disabled("},{"line_number":529,"context_line":"                extra_specs),"},{"line_number":530,"context_line":"            source_device_id\u003dsource_device_id,"},{"line_number":531,"context_line":"            temporary_snapvx\u003dtemporary_snapvx,"}],"source_content_type":"text/x-python","patch_set":75,"id":"85b1d6b6_5fc36b5e","side":"PARENT","line":528,"in_reply_to":"345ac353_84dc09d7","updated":"2024-02-19 19:19:27.000000000","message":"@happystacker,\nThanks for pointing this out, #528 was not intended to be removed.","commit_id":"e7c8885686cb018e0387d17b1aaeba8e616bb2f4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5172aa6ccd0eb9eff16bd120f69824c711e285d8","unresolved":true,"context_lines":[{"line_number":530,"context_line":"                extra_specs),"},{"line_number":531,"context_line":"            temporary_snapvx\u003dtemporary_snapvx,"},{"line_number":532,"context_line":"            target_array_model\u003dtarget_array_model,"},{"line_number":533,"context_line":"            array_tag_list\u003darray_tag_list),"},{"line_number":534,"context_line":"        volume_metadata \u003d self.update_volume_info_metadata("},{"line_number":535,"context_line":"            datadict, self.version_dict)"},{"line_number":536,"context_line":"        self.print_pretty_table(volume_metadata)"}],"source_content_type":"text/x-python","patch_set":78,"id":"c41cae4f_a4f946fe","line":533,"range":{"start_line":533,"start_character":42,"end_line":533,"end_character":43},"updated":"2024-02-27 08:27:33.000000000","message":"this comma will make datadict a tuple instead of a expected dict, is this intentional?\n\n\u003e\u003e\u003e def abc():\n...     print(\u0027abc\u0027)\n\n\u003e\u003e\u003e xyz \u003d abc(),\nabc\n\u003e\u003e\u003e xyz\n(None,)\n\n\u003e\u003e\u003e xyz \u003d abc()\nabc\n\u003e\u003e\u003e xyz\n\u003cno output/None\u003e","commit_id":"312984ec09530acc5e0e86cd50d549153b3c4ec7"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"a63be56a1bdc86fbbf0966c40ac45541b777ef42","unresolved":false,"context_lines":[{"line_number":530,"context_line":"                extra_specs),"},{"line_number":531,"context_line":"            temporary_snapvx\u003dtemporary_snapvx,"},{"line_number":532,"context_line":"            target_array_model\u003dtarget_array_model,"},{"line_number":533,"context_line":"            array_tag_list\u003darray_tag_list),"},{"line_number":534,"context_line":"        volume_metadata \u003d self.update_volume_info_metadata("},{"line_number":535,"context_line":"            datadict, self.version_dict)"},{"line_number":536,"context_line":"        self.print_pretty_table(volume_metadata)"}],"source_content_type":"text/x-python","patch_set":78,"id":"a1c7483f_5a46586b","line":533,"range":{"start_line":533,"start_character":42,"end_line":533,"end_character":43},"in_reply_to":"c41cae4f_a4f946fe","updated":"2024-02-27 16:18:04.000000000","message":"Thank you @Rajat, I reverted this file back to its original state. This was a left over from a previous version.","commit_id":"312984ec09530acc5e0e86cd50d549153b3c4ec7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"338504f596f0e7897c945c53af515df0e37f04e1","unresolved":true,"context_lines":[{"line_number":524,"context_line":"            target_device_id\u003dtarget_device_id,"},{"line_number":525,"context_line":"            source_snapshot_id\u003dsource_snapshot_id,"},{"line_number":526,"context_line":"            rep_mode\u003drep_mode, replication_status\u003dreplication_status,"},{"line_number":527,"context_line":"            rdf_group_label\u003drdf_group_label, use_bias\u003duse_bias,"},{"line_number":528,"context_line":"            source_device_id\u003dsource_device_id,"},{"line_number":529,"context_line":"            temporary_snapvx\u003dtemporary_snapvx,"},{"line_number":530,"context_line":"            target_array_model\u003dtarget_array_model,"}],"source_content_type":"text/x-python","patch_set":79,"id":"c007edbb_2067f19a","line":527,"updated":"2024-02-27 16:33:20.000000000","message":"I think it\u0027s a wrong revert but why are we removing the compression disabled check?","commit_id":"d0b2cad7936a43b90ca83d33e2e5153c94cfee9c"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"a4aacdf1f141e35368bd855edc216acb9e408421","unresolved":false,"context_lines":[{"line_number":524,"context_line":"            target_device_id\u003dtarget_device_id,"},{"line_number":525,"context_line":"            source_snapshot_id\u003dsource_snapshot_id,"},{"line_number":526,"context_line":"            rep_mode\u003drep_mode, replication_status\u003dreplication_status,"},{"line_number":527,"context_line":"            rdf_group_label\u003drdf_group_label, use_bias\u003duse_bias,"},{"line_number":528,"context_line":"            source_device_id\u003dsource_device_id,"},{"line_number":529,"context_line":"            temporary_snapvx\u003dtemporary_snapvx,"},{"line_number":530,"context_line":"            target_array_model\u003dtarget_array_model,"}],"source_content_type":"text/x-python","patch_set":79,"id":"c2c9b6c9_9b352c47","line":527,"in_reply_to":"c007edbb_2067f19a","updated":"2024-02-27 17:18:25.000000000","message":"@Rajat,\nThat was not intentional. The file should be correct now.","commit_id":"d0b2cad7936a43b90ca83d33e2e5153c94cfee9c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"338504f596f0e7897c945c53af515df0e37f04e1","unresolved":true,"context_lines":[{"line_number":528,"context_line":"            source_device_id\u003dsource_device_id,"},{"line_number":529,"context_line":"            temporary_snapvx\u003dtemporary_snapvx,"},{"line_number":530,"context_line":"            target_array_model\u003dtarget_array_model,"},{"line_number":531,"context_line":"            array_tag_list\u003darray_tag_list),"},{"line_number":532,"context_line":"        volume_metadata \u003d self.update_volume_info_metadata("},{"line_number":533,"context_line":"            datadict, self.version_dict)"},{"line_number":534,"context_line":"        self.print_pretty_table(volume_metadata)"}],"source_content_type":"text/x-python","patch_set":79,"id":"1d01177b_fadf6fd5","line":531,"range":{"start_line":531,"start_character":42,"end_line":531,"end_character":43},"updated":"2024-02-27 16:33:20.000000000","message":"my comment was regarding this additional comma here which still exists ...","commit_id":"d0b2cad7936a43b90ca83d33e2e5153c94cfee9c"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"a4aacdf1f141e35368bd855edc216acb9e408421","unresolved":false,"context_lines":[{"line_number":528,"context_line":"            source_device_id\u003dsource_device_id,"},{"line_number":529,"context_line":"            temporary_snapvx\u003dtemporary_snapvx,"},{"line_number":530,"context_line":"            target_array_model\u003dtarget_array_model,"},{"line_number":531,"context_line":"            array_tag_list\u003darray_tag_list),"},{"line_number":532,"context_line":"        volume_metadata \u003d self.update_volume_info_metadata("},{"line_number":533,"context_line":"            datadict, self.version_dict)"},{"line_number":534,"context_line":"        self.print_pretty_table(volume_metadata)"}],"source_content_type":"text/x-python","patch_set":79,"id":"ce50f1cc_7ee63ed3","line":531,"range":{"start_line":531,"start_character":42,"end_line":531,"end_character":43},"in_reply_to":"1d01177b_fadf6fd5","updated":"2024-02-27 17:18:25.000000000","message":"@Rajat,\nFile corrected. I misunderstood what was going on with Gerit WRT to resetting files. The file should now be in the correct state.","commit_id":"d0b2cad7936a43b90ca83d33e2e5153c94cfee9c"}],"cinder/volume/drivers/dell_emc/powermax/rest.py":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"68f1c011e392a3c49565265f808f4bd26c86ed61","unresolved":true,"context_lines":[{"line_number":2228,"context_line":"                tgt_list.append({\u0027name\u0027: target_id})"},{"line_number":2229,"context_line":""},{"line_number":2230,"context_line":"            if self.disable_protected_snap:"},{"line_number":2231,"context_line":"                src_list.remove(source_id)"},{"line_number":2232,"context_line":""},{"line_number":2233,"context_line":"            payload \u003d {\"deviceNameListSource\": src_list,"},{"line_number":2234,"context_line":"                       \"deviceNameListTarget\": tgt_list,"}],"source_content_type":"text/x-python","patch_set":20,"id":"d29c67d6_e18161a2","line":2231,"updated":"2023-11-20 19:57:13.000000000","message":"Why are we removing the volume source id in case we disable the protected snapshot?","commit_id":"4e3f1114558335075749be860f110c0ecfe452ca"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"7de49c590fd685658edd55220a7d7f151a66b91a","unresolved":true,"context_lines":[{"line_number":2228,"context_line":"                tgt_list.append({\u0027name\u0027: target_id})"},{"line_number":2229,"context_line":""},{"line_number":2230,"context_line":"            if self.disable_protected_snap:"},{"line_number":2231,"context_line":"                src_list.remove(source_id)"},{"line_number":2232,"context_line":""},{"line_number":2233,"context_line":"            payload \u003d {\"deviceNameListSource\": src_list,"},{"line_number":2234,"context_line":"                       \"deviceNameListTarget\": tgt_list,"}],"source_content_type":"text/x-python","patch_set":20,"id":"8e905722_6a0f1e5e","line":2231,"in_reply_to":"186ef646_6e506277","updated":"2023-11-27 23:30:10.000000000","message":"Good point @happystacker; in that case, how would you update the payload in the case where  self.disable_protected_snap is False?","commit_id":"4e3f1114558335075749be860f110c0ecfe452ca"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"a1f4017c395e0ba52744e84f6635d82f2a5a0178","unresolved":true,"context_lines":[{"line_number":2228,"context_line":"                tgt_list.append({\u0027name\u0027: target_id})"},{"line_number":2229,"context_line":""},{"line_number":2230,"context_line":"            if self.disable_protected_snap:"},{"line_number":2231,"context_line":"                src_list.remove(source_id)"},{"line_number":2232,"context_line":""},{"line_number":2233,"context_line":"            payload \u003d {\"deviceNameListSource\": src_list,"},{"line_number":2234,"context_line":"                       \"deviceNameListTarget\": tgt_list,"}],"source_content_type":"text/x-python","patch_set":20,"id":"186ef646_6e506277","line":2231,"in_reply_to":"83e39a08_f5c11e1a","updated":"2023-11-21 08:12:09.000000000","message":"But if we are removing the volume source id, how can a target volume can be linked to a source volume?","commit_id":"4e3f1114558335075749be860f110c0ecfe452ca"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"4fd44c88cf2fa5efe801f464756621b9728c3c55","unresolved":true,"context_lines":[{"line_number":2228,"context_line":"                tgt_list.append({\u0027name\u0027: target_id})"},{"line_number":2229,"context_line":""},{"line_number":2230,"context_line":"            if self.disable_protected_snap:"},{"line_number":2231,"context_line":"                src_list.remove(source_id)"},{"line_number":2232,"context_line":""},{"line_number":2233,"context_line":"            payload \u003d {\"deviceNameListSource\": src_list,"},{"line_number":2234,"context_line":"                       \"deviceNameListTarget\": tgt_list,"}],"source_content_type":"text/x-python","patch_set":20,"id":"a535606c_6c67b6cf","line":2231,"in_reply_to":"8e905722_6a0f1e5e","updated":"2023-11-29 07:51:01.000000000","message":"disable_protected_snap prevents the snapshot to be configured as a replicated device if the source device is replicated, I\u0027d assume that there is a step where replication on the source device is checked and when creating target volume it\u0027ll configure it accordingly.","commit_id":"4e3f1114558335075749be860f110c0ecfe452ca"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"62fca07fcc576303a2d23f35d17a35cf597f10ce","unresolved":false,"context_lines":[{"line_number":2228,"context_line":"                tgt_list.append({\u0027name\u0027: target_id})"},{"line_number":2229,"context_line":""},{"line_number":2230,"context_line":"            if self.disable_protected_snap:"},{"line_number":2231,"context_line":"                src_list.remove(source_id)"},{"line_number":2232,"context_line":""},{"line_number":2233,"context_line":"            payload \u003d {\"deviceNameListSource\": src_list,"},{"line_number":2234,"context_line":"                       \"deviceNameListTarget\": tgt_list,"}],"source_content_type":"text/x-python","patch_set":20,"id":"c5c311b0_a0123a72","line":2231,"in_reply_to":"a535606c_6c67b6cf","updated":"2023-12-15 19:58:20.000000000","message":"Acknowledged","commit_id":"4e3f1114558335075749be860f110c0ecfe452ca"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"b7c4ff8301464759579b3b45669d27f743cfb1cd","unresolved":true,"context_lines":[{"line_number":2228,"context_line":"                tgt_list.append({\u0027name\u0027: target_id})"},{"line_number":2229,"context_line":""},{"line_number":2230,"context_line":"            if self.disable_protected_snap:"},{"line_number":2231,"context_line":"                src_list.remove(source_id)"},{"line_number":2232,"context_line":""},{"line_number":2233,"context_line":"            payload \u003d {\"deviceNameListSource\": src_list,"},{"line_number":2234,"context_line":"                       \"deviceNameListTarget\": tgt_list,"}],"source_content_type":"text/x-python","patch_set":20,"id":"83e39a08_f5c11e1a","line":2231,"in_reply_to":"d29c67d6_e18161a2","updated":"2023-11-20 22:47:48.000000000","message":"@happystacker, \nThe thinking is to remove the device ID from the list of source devices before the ID is included in the payload. Are you thinking an alternative approach would be more appropriate (e.g. raise an exception)?","commit_id":"4e3f1114558335075749be860f110c0ecfe452ca"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5172aa6ccd0eb9eff16bd120f69824c711e285d8","unresolved":true,"context_lines":[{"line_number":83,"context_line":"        self.primary_u4p \u003d None"},{"line_number":84,"context_line":"        self.u4p_failover_enabled \u003d False"},{"line_number":85,"context_line":"        self.u4p_failover_autofailback \u003d True"},{"line_number":86,"context_line":"        self.u4p_failover_targets \u003d ()"},{"line_number":87,"context_line":"        self.u4p_failover_retries \u003d 3"},{"line_number":88,"context_line":"        self.u4p_failover_timeout \u003d 30"},{"line_number":89,"context_line":"        self.u4p_failover_backoff_factor \u003d 1"}],"source_content_type":"text/x-python","patch_set":78,"id":"294d30eb_2a74dbf3","line":86,"range":{"start_line":86,"start_character":36,"end_line":86,"end_character":38},"updated":"2024-02-27 08:27:33.000000000","message":"we are changing this from a list to an empty tuple and tuples are immutable, should this be [] instead?","commit_id":"312984ec09530acc5e0e86cd50d549153b3c4ec7"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"a63be56a1bdc86fbbf0966c40ac45541b777ef42","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        self.primary_u4p \u003d None"},{"line_number":84,"context_line":"        self.u4p_failover_enabled \u003d False"},{"line_number":85,"context_line":"        self.u4p_failover_autofailback \u003d True"},{"line_number":86,"context_line":"        self.u4p_failover_targets \u003d ()"},{"line_number":87,"context_line":"        self.u4p_failover_retries \u003d 3"},{"line_number":88,"context_line":"        self.u4p_failover_timeout \u003d 30"},{"line_number":89,"context_line":"        self.u4p_failover_backoff_factor \u003d 1"}],"source_content_type":"text/x-python","patch_set":78,"id":"17b5c382_d40961a7","line":86,"range":{"start_line":86,"start_character":36,"end_line":86,"end_character":38},"in_reply_to":"294d30eb_2a74dbf3","updated":"2024-02-27 16:18:04.000000000","message":"Hi @Rajat,\n\nThanks, I reverted this file back to its original state as it turns out my changes here are leftovers.","commit_id":"312984ec09530acc5e0e86cd50d549153b3c4ec7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5172aa6ccd0eb9eff16bd120f69824c711e285d8","unresolved":true,"context_lines":[{"line_number":95,"context_line":"        self.u4p_version \u003d None"},{"line_number":96,"context_line":"        self.rest_api_connect_timeout \u003d 30"},{"line_number":97,"context_line":"        self.rest_api_read_timeout \u003d 30"},{"line_number":98,"context_line":"        self.disable_protected_snap \u003d False"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def set_rest_credentials(self, array_info):"},{"line_number":101,"context_line":"        \"\"\"Given the array record set the rest server credentials."}],"source_content_type":"text/x-python","patch_set":78,"id":"6d1e018e_4a310e0e","line":98,"range":{"start_line":98,"start_character":8,"end_line":98,"end_character":43},"updated":"2024-02-27 08:27:33.000000000","message":"I don\u0027t see this being used anywhere in this file","commit_id":"312984ec09530acc5e0e86cd50d549153b3c4ec7"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"a63be56a1bdc86fbbf0966c40ac45541b777ef42","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        self.u4p_version \u003d None"},{"line_number":96,"context_line":"        self.rest_api_connect_timeout \u003d 30"},{"line_number":97,"context_line":"        self.rest_api_read_timeout \u003d 30"},{"line_number":98,"context_line":"        self.disable_protected_snap \u003d False"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def set_rest_credentials(self, array_info):"},{"line_number":101,"context_line":"        \"\"\"Given the array record set the rest server credentials."}],"source_content_type":"text/x-python","patch_set":78,"id":"e1202f10_3ba013c0","line":98,"range":{"start_line":98,"start_character":8,"end_line":98,"end_character":43},"in_reply_to":"20e23d9a_9e2c4d45","updated":"2024-02-27 16:18:04.000000000","message":"Thanks @Rajat \u0026 @Brian,\nThis was left over from an earlier version of the patch. I reverted my changes to this file.","commit_id":"312984ec09530acc5e0e86cd50d549153b3c4ec7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e84e6bf55c1733d44decdb77b1d89ebe260c6d0b","unresolved":true,"context_lines":[{"line_number":95,"context_line":"        self.u4p_version \u003d None"},{"line_number":96,"context_line":"        self.rest_api_connect_timeout \u003d 30"},{"line_number":97,"context_line":"        self.rest_api_read_timeout \u003d 30"},{"line_number":98,"context_line":"        self.disable_protected_snap \u003d False"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def set_rest_credentials(self, array_info):"},{"line_number":101,"context_line":"        \"\"\"Given the array record set the rest server credentials."}],"source_content_type":"text/x-python","patch_set":78,"id":"20e23d9a_9e2c4d45","line":98,"range":{"start_line":98,"start_character":8,"end_line":98,"end_character":43},"in_reply_to":"6d1e018e_4a310e0e","updated":"2024-02-27 12:53:48.000000000","message":"This is a good point.  It doesn\u0027t make sense as a driver attribute, given that it\u0027s set by extra-spec and not config option (that is, the backend can handle both protected and unprotected snaps).  This is probably left over from an earlier version of this patch when you thought disable_protected_snap could be set by a config option.\n\nIt would be a good idea to review the logic of how disable_protected_snap is handled throughout this patch to make sure that the logic is entirely extra-spec driven.","commit_id":"312984ec09530acc5e0e86cd50d549153b3c4ec7"}],"cinder/volume/drivers/dell_emc/powermax/utils.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"203e2a995927d09043f7d33a9682028254a16472","unresolved":true,"context_lines":[{"line_number":532,"context_line":""},{"line_number":533,"context_line":"        :param extra_specs: extra specifications :returns: boolean"},{"line_number":534,"context_line":"        \"\"\""},{"line_number":535,"context_line":"        disable_protected_snap \u003d False"},{"line_number":536,"context_line":"        if extra_specs.get(DISABLE_PROTECTED_SNAP, False):"},{"line_number":537,"context_line":"            if extra_specs.get(DISABLE_PROTECTED_SNAP) in IS_TRUE:"},{"line_number":538,"context_line":"                disable_protected_snap \u003d True"},{"line_number":539,"context_line":"        return disable_protected_snap"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    def is_compression_disabled(self, extra_specs):"},{"line_number":542,"context_line":"        \"\"\"Check is compression is to be disabled."}],"source_content_type":"text/x-python","patch_set":77,"id":"bf94e354_6dbff361","line":539,"range":{"start_line":535,"start_character":8,"end_line":539,"end_character":37},"updated":"2024-02-26 18:07:53.000000000","message":"nit: this can be improved\n\n    if extra_specs.get(DISABLE_PROTECTED_SNAP, False) in IS_TRUE:\n        return True\n    return False","commit_id":"530be19de08de269bf42d00e4ff97165dfc5f428"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"1905cedf3e7f5918fd0b294df07ab126523213e2","unresolved":false,"context_lines":[{"line_number":532,"context_line":""},{"line_number":533,"context_line":"        :param extra_specs: extra specifications :returns: boolean"},{"line_number":534,"context_line":"        \"\"\""},{"line_number":535,"context_line":"        disable_protected_snap \u003d False"},{"line_number":536,"context_line":"        if extra_specs.get(DISABLE_PROTECTED_SNAP, False):"},{"line_number":537,"context_line":"            if extra_specs.get(DISABLE_PROTECTED_SNAP) in IS_TRUE:"},{"line_number":538,"context_line":"                disable_protected_snap \u003d True"},{"line_number":539,"context_line":"        return disable_protected_snap"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    def is_compression_disabled(self, extra_specs):"},{"line_number":542,"context_line":"        \"\"\"Check is compression is to be disabled."}],"source_content_type":"text/x-python","patch_set":77,"id":"d5b2fda4_4fd15b44","line":539,"range":{"start_line":535,"start_character":8,"end_line":539,"end_character":37},"in_reply_to":"bf94e354_6dbff361","updated":"2024-02-26 21:33:37.000000000","message":"Code updated, thanks.","commit_id":"530be19de08de269bf42d00e4ff97165dfc5f428"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"338504f596f0e7897c945c53af515df0e37f04e1","unresolved":true,"context_lines":[{"line_number":536,"context_line":""},{"line_number":537,"context_line":"        :param extra_specs: extra specifications :returns: boolean"},{"line_number":538,"context_line":"        \"\"\""},{"line_number":539,"context_line":"        disable_protected_snap \u003d False"},{"line_number":540,"context_line":"        if extra_specs.get(DISABLE_PROTECTED_SNAP, False):"},{"line_number":541,"context_line":"            if extra_specs.get(DISABLE_PROTECTED_SNAP) in IS_TRUE:"},{"line_number":542,"context_line":"                disable_protected_snap \u003d True"},{"line_number":543,"context_line":"        return disable_protected_snap"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"    def is_compression_disabled(self, extra_specs):"},{"line_number":546,"context_line":"        \"\"\"Check is compression is to be disabled."}],"source_content_type":"text/x-python","patch_set":79,"id":"9cf63914_a5662271","line":543,"range":{"start_line":539,"start_character":0,"end_line":543,"end_character":37},"updated":"2024-02-27 16:33:20.000000000","message":"did we revert this file as well? we improved the logic here with\n\n        if extra_specs.get(DISABLE_PROTECTED_SNAP, False) in IS_TRUE:\n            return True\n        return False","commit_id":"d0b2cad7936a43b90ca83d33e2e5153c94cfee9c"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"a4aacdf1f141e35368bd855edc216acb9e408421","unresolved":false,"context_lines":[{"line_number":536,"context_line":""},{"line_number":537,"context_line":"        :param extra_specs: extra specifications :returns: boolean"},{"line_number":538,"context_line":"        \"\"\""},{"line_number":539,"context_line":"        disable_protected_snap \u003d False"},{"line_number":540,"context_line":"        if extra_specs.get(DISABLE_PROTECTED_SNAP, False):"},{"line_number":541,"context_line":"            if extra_specs.get(DISABLE_PROTECTED_SNAP) in IS_TRUE:"},{"line_number":542,"context_line":"                disable_protected_snap \u003d True"},{"line_number":543,"context_line":"        return disable_protected_snap"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"    def is_compression_disabled(self, extra_specs):"},{"line_number":546,"context_line":"        \"\"\"Check is compression is to be disabled."}],"source_content_type":"text/x-python","patch_set":79,"id":"b0b03b94_2d16d201","line":543,"range":{"start_line":539,"start_character":0,"end_line":543,"end_character":37},"in_reply_to":"9cf63914_a5662271","updated":"2024-02-27 17:18:25.000000000","message":"Thanks @Rajat, I inadvertently dropped the change based on your original comment.","commit_id":"d0b2cad7936a43b90ca83d33e2e5153c94cfee9c"}],"releasenotes/notes/bp-powermax-protected-snap-82eb6731553356d9.yaml":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"68f1c011e392a3c49565265f808f4bd26c86ed61","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |  "},{"line_number":4,"context_line":"    Dell EMC PowerMax driver: Added SRDF ``disable_protected_snap``"},{"line_number":5,"context_line":"    configuration option for replicated devices. When set to ``True``,"},{"line_number":6,"context_line":"    snapshots won\u0027t be replicated and won\u0027t match the source volume type and"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ed967899_1d5aa604","line":3,"updated":"2023-11-20 19:57:13.000000000","message":"Nit: remove extra space.","commit_id":"4e3f1114558335075749be860f110c0ecfe452ca"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"b7c4ff8301464759579b3b45669d27f743cfb1cd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |  "},{"line_number":4,"context_line":"    Dell EMC PowerMax driver: Added SRDF ``disable_protected_snap``"},{"line_number":5,"context_line":"    configuration option for replicated devices. When set to ``True``,"},{"line_number":6,"context_line":"    snapshots won\u0027t be replicated and won\u0027t match the source volume type and"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"c5fe48de_adaf19f0","line":3,"in_reply_to":"ed967899_1d5aa604","updated":"2023-11-20 22:47:48.000000000","message":"Acknowledged","commit_id":"4e3f1114558335075749be860f110c0ecfe452ca"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"68f1c011e392a3c49565265f808f4bd26c86ed61","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |  "},{"line_number":4,"context_line":"    Dell EMC PowerMax driver: Added SRDF ``disable_protected_snap``"},{"line_number":5,"context_line":"    configuration option for replicated devices. When set to ``True``,"},{"line_number":6,"context_line":"    snapshots won\u0027t be replicated and won\u0027t match the source volume type and"},{"line_number":7,"context_line":"    will be a regular device no matter what. If set to ``False`` (default"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"d7b3fe17_31c324d5","line":4,"updated":"2023-11-20 19:57:13.000000000","message":"Should be rephrased to something like:\nWhen set to False which is the default value, a replicated source volume will be protected with a snapshot from the same volume type (ie: replicated). This is the current behavior.\nIf set to True, this enhancement will enable the snapshot to be created as a regular device even if the source volume is replicated which will avoid to add overconsumption on both source and target storage arrays.","commit_id":"4e3f1114558335075749be860f110c0ecfe452ca"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"b7c4ff8301464759579b3b45669d27f743cfb1cd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |  "},{"line_number":4,"context_line":"    Dell EMC PowerMax driver: Added SRDF ``disable_protected_snap``"},{"line_number":5,"context_line":"    configuration option for replicated devices. When set to ``True``,"},{"line_number":6,"context_line":"    snapshots won\u0027t be replicated and won\u0027t match the source volume type and"},{"line_number":7,"context_line":"    will be a regular device no matter what. If set to ``False`` (default"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"313db7b4_1b6349ed","line":4,"in_reply_to":"d7b3fe17_31c324d5","updated":"2023-11-20 22:47:48.000000000","message":"Acknowledged","commit_id":"4e3f1114558335075749be860f110c0ecfe452ca"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9903c5e8c3b1defb28bba34ef4c4dcbf3f10ce31","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    When set to False (which is the default value), a replicated source-volume"},{"line_number":7,"context_line":"    will be protected with a snapshot from the same volume type (i.e."},{"line_number":8,"context_line":"    replicated). This is the current behavior. If set to True, this"},{"line_number":9,"context_line":"    enhancement will enable the\tsnapshot to be created as a regular device even"},{"line_number":10,"context_line":"    if the source volume is replicated which will avoid to add overconsumption"},{"line_number":11,"context_line":"    on both source and target storage arrays."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"6e9779cd_a1b97836","line":9,"range":{"start_line":9,"start_character":31,"end_line":9,"end_character":32},"updated":"2024-02-22 16:57:40.000000000","message":"nit: please replace the tab character with a space","commit_id":"50be986be5e881fe29e0f45266bdd44a8984680b"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"ef195d8bce15db90c499a33e2de063dc6c3aca69","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    When set to False (which is the default value), a replicated source-volume"},{"line_number":7,"context_line":"    will be protected with a snapshot from the same volume type (i.e."},{"line_number":8,"context_line":"    replicated). This is the current behavior. If set to True, this"},{"line_number":9,"context_line":"    enhancement will enable the\tsnapshot to be created as a regular device even"},{"line_number":10,"context_line":"    if the source volume is replicated which will avoid to add overconsumption"},{"line_number":11,"context_line":"    on both source and target storage arrays."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"5243abba_8c847ebb","line":9,"range":{"start_line":9,"start_character":31,"end_line":9,"end_character":32},"in_reply_to":"6e9779cd_a1b97836","updated":"2024-02-22 18:18:34.000000000","message":"Thanks! Fixed.","commit_id":"50be986be5e881fe29e0f45266bdd44a8984680b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9903c5e8c3b1defb28bba34ef4c4dcbf3f10ce31","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    will be protected with a snapshot from the same volume type (i.e."},{"line_number":8,"context_line":"    replicated). This is the current behavior. If set to True, this"},{"line_number":9,"context_line":"    enhancement will enable the\tsnapshot to be created as a regular device even"},{"line_number":10,"context_line":"    if the source volume is replicated which will avoid to add overconsumption"},{"line_number":11,"context_line":"    on both source and target storage arrays."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"62fb6bc9_1dbb0325","line":10,"range":{"start_line":10,"start_character":56,"end_line":10,"end_character":62},"updated":"2024-02-22 16:57:40.000000000","message":"don\u0027t think you need the \"to add\" here","commit_id":"50be986be5e881fe29e0f45266bdd44a8984680b"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"ef195d8bce15db90c499a33e2de063dc6c3aca69","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    will be protected with a snapshot from the same volume type (i.e."},{"line_number":8,"context_line":"    replicated). This is the current behavior. If set to True, this"},{"line_number":9,"context_line":"    enhancement will enable the\tsnapshot to be created as a regular device even"},{"line_number":10,"context_line":"    if the source volume is replicated which will avoid to add overconsumption"},{"line_number":11,"context_line":"    on both source and target storage arrays."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"8588e050_46e6d1ed","line":10,"range":{"start_line":10,"start_character":56,"end_line":10,"end_character":62},"in_reply_to":"62fb6bc9_1dbb0325","updated":"2024-02-22 18:18:34.000000000","message":"Thanks! Fixed.","commit_id":"50be986be5e881fe29e0f45266bdd44a8984680b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c54120d501b9dbc2a83571ce102f41628a484691","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    enhancement will enable the snapshot to be created as a regular device"},{"line_number":10,"context_line":"    even if the source volume is replicated which will avoid overconsumption"},{"line_number":11,"context_line":"    on both source and target storage arrays."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":77,"id":"5a48aa68_8d995872","line":12,"updated":"2024-02-26 17:15:08.000000000","message":"You need to rewrite this in terms of the extra-spec.  An operator enables the functionality by creating a specific volume type that has \"powermax:disable_protected_snap \u003cis\u003e True\", not by setting a config option.","commit_id":"530be19de08de269bf42d00e4ff97165dfc5f428"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"1905cedf3e7f5918fd0b294df07ab126523213e2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    enhancement will enable the snapshot to be created as a regular device"},{"line_number":10,"context_line":"    even if the source volume is replicated which will avoid overconsumption"},{"line_number":11,"context_line":"    on both source and target storage arrays."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":77,"id":"a1610d7d_3d58d67a","line":12,"in_reply_to":"5a48aa68_8d995872","updated":"2024-02-26 21:33:37.000000000","message":"Thanks for the feedback @Brian, I re-worded the release note to hopefully capture your point.","commit_id":"530be19de08de269bf42d00e4ff97165dfc5f428"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5172aa6ccd0eb9eff16bd120f69824c711e285d8","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    overconsumption on both source and target storage arrays."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    An operator may enable this functionality by creating a specific volume"},{"line_number":9,"context_line":"    type containing \"powermax:disable_protected_snap \u003cis\u003e True\"."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    When disabled (which is the default and current behavior), a"},{"line_number":12,"context_line":"    replicated source volume will be protected with a snapshot of the"}],"source_content_type":"text/x-yaml","patch_set":78,"id":"1ff77c0e_8581c463","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":62},"updated":"2024-02-27 08:27:33.000000000","message":"nit:\n\n\\`\\`\"powermax:disable_protected_snap\": \"\u003cis\u003e True\"\\`\\` property in extra specs.","commit_id":"312984ec09530acc5e0e86cd50d549153b3c4ec7"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"a63be56a1bdc86fbbf0966c40ac45541b777ef42","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    overconsumption on both source and target storage arrays."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    An operator may enable this functionality by creating a specific volume"},{"line_number":9,"context_line":"    type containing \"powermax:disable_protected_snap \u003cis\u003e True\"."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    When disabled (which is the default and current behavior), a"},{"line_number":12,"context_line":"    replicated source volume will be protected with a snapshot of the"}],"source_content_type":"text/x-yaml","patch_set":78,"id":"6770cd9b_7afc7956","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":62},"in_reply_to":"1ff77c0e_8581c463","updated":"2024-02-27 16:18:04.000000000","message":"Nice catch, thank you. I updated the release note.","commit_id":"312984ec09530acc5e0e86cd50d549153b3c4ec7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"338504f596f0e7897c945c53af515df0e37f04e1","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    overconsumption on both source and target storage arrays."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    An operator may enable this functionality by creating a specific volume"},{"line_number":9,"context_line":"    type containing \"powermax:disable_protected_snap: \u003cis\u003e True\"."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    When disabled (which is the default and current behavior), a"},{"line_number":12,"context_line":"    replicated source volume will be protected with a snapshot of the"}],"source_content_type":"text/x-yaml","patch_set":79,"id":"8e5e5845_130458fd","line":9,"range":{"start_line":9,"start_character":64,"end_line":9,"end_character":65},"updated":"2024-02-27 16:33:20.000000000","message":"nit: property in extra specs","commit_id":"d0b2cad7936a43b90ca83d33e2e5153c94cfee9c"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"a4aacdf1f141e35368bd855edc216acb9e408421","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    overconsumption on both source and target storage arrays."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    An operator may enable this functionality by creating a specific volume"},{"line_number":9,"context_line":"    type containing \"powermax:disable_protected_snap: \u003cis\u003e True\"."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    When disabled (which is the default and current behavior), a"},{"line_number":12,"context_line":"    replicated source volume will be protected with a snapshot of the"}],"source_content_type":"text/x-yaml","patch_set":79,"id":"d1adc659_e69922b4","line":9,"range":{"start_line":9,"start_character":64,"end_line":9,"end_character":65},"in_reply_to":"8e5e5845_130458fd","updated":"2024-02-27 17:18:25.000000000","message":"@Rajat,\nAddressed if I understood your comment correctly.","commit_id":"d0b2cad7936a43b90ca83d33e2e5153c94cfee9c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f1f8a11b25f21a7b69d3023a59e70531574221ed","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    overconsumption on both source and target storage arrays."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    An operator may enable this functionality by creating a specific volume"},{"line_number":9,"context_line":"    type with the property \"powermax:disable_protected_snap: \u003cis\u003e True\"."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    When disabled (which is the default and current behavior), a"},{"line_number":12,"context_line":"    replicated source volume will be protected with a snapshot of the"}],"source_content_type":"text/x-yaml","patch_set":81,"id":"f6852a58_4d2ea042","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":71},"updated":"2024-02-28 04:09:41.000000000","message":"nit: I guess this is clear enough, but when the extra specs are displayed in JSON in an API response, this would look like:\n\n```\n    \"powermax:disable_protected_snap\": \"\u003cis\u003e True\"\n```\n\nYou can get it to display in monospace font if you quote the above line with double-backticks(\\`\\`) at the beginning and end.","commit_id":"82fb879c836b7de9472fe380ad056311a4ea3e0b"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"d7ccb3bf37a87569e940480ecf1ab65650c79bf7","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    overconsumption on both source and target storage arrays."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    An operator may enable this functionality by creating a specific volume"},{"line_number":9,"context_line":"    type with the property \"powermax:disable_protected_snap: \u003cis\u003e True\"."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    When disabled (which is the default and current behavior), a"},{"line_number":12,"context_line":"    replicated source volume will be protected with a snapshot of the"}],"source_content_type":"text/x-yaml","patch_set":81,"id":"b1913bf7_22bdcc95","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":71},"in_reply_to":"f6852a58_4d2ea042","updated":"2024-02-28 15:26:32.000000000","message":"Thanks for the tip @Brian, I\u0027ve updated the release note.","commit_id":"82fb879c836b7de9472fe380ad056311a4ea3e0b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"88685979a41e02a71cb6954dcc19b4a548fb8a41","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    overconsumption on both source and target storage arrays."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    An operator may enable this functionality by creating a specific volume"},{"line_number":9,"context_line":"    type with the property, `\"powermax:disable_protected_snap\": \"\u003cis\u003e True\"`."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    When disabled (which is the default and current behavior), a"},{"line_number":12,"context_line":"    replicated source volume will be protected with a snapshot of the"}],"source_content_type":"text/x-yaml","patch_set":83,"id":"9dfcdf74_7a1ab259","line":9,"updated":"2024-02-28 20:31:35.000000000","message":"another nit about this -- single backticks give you italics, you need to use two backticks at the beginning and two at the end to get monospace font.","commit_id":"9ca5614bc85a5a76915a33a8aa5a777e7dc60846"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"f0ab2d010e2e06e1297fbdd7ff565a00f08eebe9","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    overconsumption on both source and target storage arrays."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    An operator may enable this functionality by creating a specific volume"},{"line_number":9,"context_line":"    type with the property, `\"powermax:disable_protected_snap\": \"\u003cis\u003e True\"`."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    When disabled (which is the default and current behavior), a"},{"line_number":12,"context_line":"    replicated source volume will be protected with a snapshot of the"}],"source_content_type":"text/x-yaml","patch_set":83,"id":"4081b1c3_8319ae14","line":9,"in_reply_to":"9dfcdf74_7a1ab259","updated":"2024-02-28 20:49:58.000000000","message":"Thank you @Brian, updated.","commit_id":"9ca5614bc85a5a76915a33a8aa5a777e7dc60846"}]}