)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1ca9523f0e7c11782209ca573f52edb50ac58b83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fa8a3a9d_b8916ba3","updated":"2023-10-31 10:00:25.000000000","message":"Hi Premlata,\nThank you for your first contribution.\nI\u0027ve a comment and a suggestion inline, hope that will help.","commit_id":"9639bdbb9bd1922cb3f53d8dccbf2c7dd089df82"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b167de16f20f79b74731c37e09dc9661be2f2d43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"07c3274e_42c7ab85","updated":"2023-11-21 05:42:28.000000000","message":"Thanks, LGTM.","commit_id":"67713f67130fecfeb2764591d02f7333760112c4"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"244631c89cc772a8fc35e0ccd464950e6132c5ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7dec549d_2efe7845","updated":"2023-11-21 16:17:51.000000000","message":"ltgm too!","commit_id":"67713f67130fecfeb2764591d02f7333760112c4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"60abeb8645969264dfb40f0f44d6ddcddfb2f76c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"614369da_54372fb4","updated":"2023-11-21 05:42:41.000000000","message":"reflected in the cover job https://9a0a11b5cc30d3c3e103-26ed4bee8811f1ce91956806602f515f.ssl.cf1.rackcdn.com/899582/2/check/cinder-code-coverage/1704e1e/cover/d_81e0d3d19f688c9d_cisco_fc_san_lookup_service_py.html","commit_id":"67713f67130fecfeb2764591d02f7333760112c4"}],"cinder/tests/unit/zonemanager/test_cisco_fc_san_lookup_service.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1ca9523f0e7c11782209ca573f52edb50ac58b83","unresolved":true,"context_lines":[{"line_number":67,"context_line":"        mock_ssh_execute.return_value \u003d (\"command output\", \"\")"},{"line_number":68,"context_line":"        cmd_list \u003d [\"dummy_command\"]"},{"line_number":69,"context_line":"        expected_output \u003d \"command output\""},{"line_number":70,"context_line":"        actual_output, _ \u003d self._run_ssh(cmd_list)"},{"line_number":71,"context_line":"        self.assertEqual(expected_output, actual_output)"},{"line_number":72,"context_line":"        mock_ssh_execute.assert_called_once_with([\"dummy_command\"])"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"484d0985_f3f15119","line":70,"range":{"start_line":70,"start_character":32,"end_line":70,"end_character":40},"updated":"2023-10-31 10:00:25.000000000","message":"we are not testing anything here since we are calling the same method we are mocking so this method will never be called as it\u0027s replaced by a mock.\nI think a better and easier test would be to test the except part of get_nameserver_info\nThis part of code isn\u0027t covered yet\n\n        except exception.FCSanLookupServiceException: \n            with excutils.save_and_reraise_exception(): \n                LOG.error(\"Failed collecting show fcns database for fabric\")","commit_id":"9639bdbb9bd1922cb3f53d8dccbf2c7dd089df82"}]}
