)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b824950fe16b50be0696406070592ee5aec64df0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8073649e_2aef1b1f","updated":"2023-11-07 16:39:37.000000000","message":"Looks good but I would suggest rewording the message.","commit_id":"30091cf01775bed550197bbe2995714fe37827c2"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"e41f531c054b6a79120faae286e294fc109941b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f7295141_7afb7209","updated":"2023-11-03 16:22:56.000000000","message":"recheck\n\n(Zuul had two jobs not running this code fail)","commit_id":"30091cf01775bed550197bbe2995714fe37827c2"},{"author":{"_account_id":22312,"name":"Andrei","email":"andrei.perepiolkin@open-e.com","username":"andrei.perepiolkin"},"change_message_id":"f1d7528f3c3a696a5158ca6d73b0d1627c177191","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8d880029_67928db7","updated":"2023-11-14 11:54:06.000000000","message":"Code and style looks good. But Im not sure if that fix is needed.","commit_id":"3ecd414fa3926d881aca3fa97fecd895013dc847"},{"author":{"_account_id":22312,"name":"Andrei","email":"andrei.perepiolkin@open-e.com","username":"andrei.perepiolkin"},"change_message_id":"3439bf83b8cb5ae9008b8e820b6afb5919453244","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bae46a8d_75dd3af7","updated":"2023-11-15 08:14:51.000000000","message":"Looks good to me.","commit_id":"3ecd414fa3926d881aca3fa97fecd895013dc847"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"d61d3d8abf32f8733876065e4705a9d97955c922","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c8cb4a77_8392d653","updated":"2023-11-08 14:51:06.000000000","message":"Thanks for taking a look.\nI fell back to the msg as used in the smbfs driver.\nAlso added the missing driver version bump.","commit_id":"3ecd414fa3926d881aca3fa97fecd895013dc847"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"bcaabb3f3e970d8c6669dc71254a1b62630eb11e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1c989262_1bc9d4cf","updated":"2023-11-15 08:57:43.000000000","message":"Patchset 3 updates the driver version comment, only.","commit_id":"6179d5ef3c32f46047d79ebc3ac3479394ba0b33"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"edd9fdeeb2c37bb8d893489e8007df4c93cd8a5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"79e51944_d77ef475","updated":"2024-02-20 13:23:43.000000000","message":"Sorry we missed this on change I896f70d204ad103e.  Thanks for fixing it.  Code \u0026 tests LGTM.  Nit noted inline in case you have to push a new patch set, but nothing to hold this up over.","commit_id":"6179d5ef3c32f46047d79ebc3ac3479394ba0b33"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"f1fa47443d2bc8c05918c08909a18bc471492072","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5b5505e4_2b854549","updated":"2024-02-21 09:23:56.000000000","message":"ah, right. Will correct in a follow up.","commit_id":"6179d5ef3c32f46047d79ebc3ac3479394ba0b33"},{"author":{"_account_id":22312,"name":"Andrei","email":"andrei.perepiolkin@open-e.com","username":"andrei.perepiolkin"},"change_message_id":"dd35ed0a2ee4d3024fe76676b375dfbcbcee2aad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"60e7d049_6988a4ab","updated":"2023-12-13 13:19:26.000000000","message":"looks good","commit_id":"6179d5ef3c32f46047d79ebc3ac3479394ba0b33"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"21f2b9f949e2c6f4267b287172d0184f02d571d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"81bdd065_ce61a2e2","updated":"2024-06-17 11:53:18.000000000","message":"recheck bug #2067733","commit_id":"c330d4d362d845afb569b734fa8ab56c81528883"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"02aa59e67a95807abe32c4f3e31c32d5e6682dc3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9bb0767c_ccea008a","updated":"2024-06-21 09:06:57.000000000","message":"recheck lvm-lio-barbican failed with a timed out ssh connection","commit_id":"c330d4d362d845afb569b734fa8ab56c81528883"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"dce0c452d260c6591569baa804c59723f5a0332e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2ab18e9d_be5b295c","updated":"2024-05-29 11:51:55.000000000","message":"recheck two tempest plugins failed with kernel panic, rally on instance not booting and pylint on an sqlalchemy lib not related to the change.","commit_id":"c330d4d362d845afb569b734fa8ab56c81528883"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"ef0b0eb84c25145dc1a11670210fa1bd3c76715e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bba23d35_deea7380","updated":"2024-07-29 09:46:21.000000000","message":"recheck  Tempest timed out waiting for compute in a test not using the changed code.","commit_id":"a204c7271e750eafee3c057fb539e7252a832ea1"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"44b5a3ded239459448c816de703289fa88054490","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c2cc951d_c53f43f6","updated":"2025-03-25 15:00:48.000000000","message":"recheck","commit_id":"24b209fe327018e9f1003248533ff5100687e659"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"5eaf262e04c2db4859eeb69a0460c44ccc6e1fff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c76d0262_15ae8702","updated":"2025-07-10 10:40:17.000000000","message":"recheck\n\nTwo zuul jobs failed but they do not run the modified code.","commit_id":"a58a4ab2212eac501415847b67ea388c87675216"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"547e17b22ec45694a90d5db1a4845fdea5bd0ec4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"86ca658d_05b4e2e5","updated":"2025-09-15 12:11:42.000000000","message":"run-quobyteci","commit_id":"a58a4ab2212eac501415847b67ea388c87675216"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"5f0405c28ccce7c3b66f8523cba7e9374f7e3e23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"00b87da6_dcfe38f1","updated":"2026-01-13 16:37:30.000000000","message":"run-Quobyte CI","commit_id":"8cf57d9abe7b67fa83be11cec10fa849bc4e7246"}],"cinder/volume/drivers/quobyte.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b824950fe16b50be0696406070592ee5aec64df0","unresolved":true,"context_lines":[{"line_number":385,"context_line":"        \"\"\""},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"        if src_encryption_key_id or new_encryption_key_id:"},{"line_number":388,"context_line":"            msg \u003d _(\"Encryption key %s was provided. Volume \""},{"line_number":389,"context_line":"                    \"encryption is not supported.\")"},{"line_number":390,"context_line":"            raise exception.NotSupportedOperation("},{"line_number":391,"context_line":"                message\u003dmsg % new_encryption_key_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5d258fad_71fb0789","line":388,"range":{"start_line":388,"start_character":21,"end_line":388,"end_character":52},"updated":"2023-11-07 16:39:37.000000000","message":"This message will be confusing when the source is encrypted but the dest isn\u0027t.","commit_id":"30091cf01775bed550197bbe2995714fe37827c2"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"d61d3d8abf32f8733876065e4705a9d97955c922","unresolved":false,"context_lines":[{"line_number":385,"context_line":"        \"\"\""},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"        if src_encryption_key_id or new_encryption_key_id:"},{"line_number":388,"context_line":"            msg \u003d _(\"Encryption key %s was provided. Volume \""},{"line_number":389,"context_line":"                    \"encryption is not supported.\")"},{"line_number":390,"context_line":"            raise exception.NotSupportedOperation("},{"line_number":391,"context_line":"                message\u003dmsg % new_encryption_key_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"0d327892_3016213b","line":388,"range":{"start_line":388,"start_character":21,"end_line":388,"end_character":52},"in_reply_to":"5d258fad_71fb0789","updated":"2023-11-08 14:51:06.000000000","message":"Done","commit_id":"30091cf01775bed550197bbe2995714fe37827c2"},{"author":{"_account_id":22312,"name":"Andrei","email":"andrei.perepiolkin@open-e.com","username":"andrei.perepiolkin"},"change_message_id":"f1d7528f3c3a696a5158ca6d73b0d1627c177191","unresolved":true,"context_lines":[{"line_number":374,"context_line":"        return self._create_volume_from_snapshot(volume, snapshot)"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    @coordination.synchronized(\u0027{self.driver_prefix}-{volume.id}\u0027)"},{"line_number":377,"context_line":"    def _copy_volume_from_snapshot(self, snapshot, volume, volume_size,"},{"line_number":378,"context_line":"                                   src_encryption_key_id\u003dNone,"},{"line_number":379,"context_line":"                                   new_encryption_key_id\u003dNone):"},{"line_number":380,"context_line":"        \"\"\"Copy data from snapshot to destination volume."},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"        This is done with a qemu-img convert to raw/qcow2 from the snapshot"}],"source_content_type":"text/x-python","patch_set":2,"id":"4bd0c3fb_31eccaf5","line":379,"range":{"start_line":377,"start_character":0,"end_line":379,"end_character":63},"updated":"2023-11-14 11:54:06.000000000","message":"Im not sure if that fix is needed. Ive looked through your code and it looks like you are not using \u0027new_encryption_key_id\u0027, have I missed that one?\n\nIve checked https://opendev.org/openstack/cinder/src/commit/3ecd414fa3926d881aca3fa97fecd895013dc847/cinder/volume/drivers/remotefs.py#L1996\nand it is not using it as well. So Im not sure if that fix is needed.","commit_id":"3ecd414fa3926d881aca3fa97fecd895013dc847"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"6c8194c3853e1e59a74b624cf8cd590c9d7761bd","unresolved":true,"context_lines":[{"line_number":374,"context_line":"        return self._create_volume_from_snapshot(volume, snapshot)"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    @coordination.synchronized(\u0027{self.driver_prefix}-{volume.id}\u0027)"},{"line_number":377,"context_line":"    def _copy_volume_from_snapshot(self, snapshot, volume, volume_size,"},{"line_number":378,"context_line":"                                   src_encryption_key_id\u003dNone,"},{"line_number":379,"context_line":"                                   new_encryption_key_id\u003dNone):"},{"line_number":380,"context_line":"        \"\"\"Copy data from snapshot to destination volume."},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"        This is done with a qemu-img convert to raw/qcow2 from the snapshot"}],"source_content_type":"text/x-python","patch_set":2,"id":"980a1ecf_f963d0f1","line":379,"range":{"start_line":377,"start_character":0,"end_line":379,"end_character":63},"in_reply_to":"4bd0c3fb_31eccaf5","updated":"2023-11-14 14:24:57.000000000","message":"Thanks for taking a look!\n\nThe fix is needed not because the driver uses the parameters but because python raises an error when calling this method in the Quobyte driver due to the unknown parameters. This causes the volume creation to fail in specific scenarios.\n\nThe parent class (remotefs) had the encryption parameters added in the _copy_volume_from_snapshot method.\nThis change adapts the method signature and adds meaningful logging output to point out the usage of superfluous parameters.","commit_id":"3ecd414fa3926d881aca3fa97fecd895013dc847"},{"author":{"_account_id":22312,"name":"Andrei","email":"andrei.perepiolkin@open-e.com","username":"andrei.perepiolkin"},"change_message_id":"3439bf83b8cb5ae9008b8e820b6afb5919453244","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        return self._create_volume_from_snapshot(volume, snapshot)"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    @coordination.synchronized(\u0027{self.driver_prefix}-{volume.id}\u0027)"},{"line_number":377,"context_line":"    def _copy_volume_from_snapshot(self, snapshot, volume, volume_size,"},{"line_number":378,"context_line":"                                   src_encryption_key_id\u003dNone,"},{"line_number":379,"context_line":"                                   new_encryption_key_id\u003dNone):"},{"line_number":380,"context_line":"        \"\"\"Copy data from snapshot to destination volume."},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"        This is done with a qemu-img convert to raw/qcow2 from the snapshot"}],"source_content_type":"text/x-python","patch_set":2,"id":"74f0dcf0_a7968aba","line":379,"range":{"start_line":377,"start_character":0,"end_line":379,"end_character":63},"in_reply_to":"980a1ecf_f963d0f1","updated":"2023-11-15 08:14:51.000000000","message":"Done","commit_id":"3ecd414fa3926d881aca3fa97fecd895013dc847"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"edd9fdeeb2c37bb8d893489e8007df4c93cd8a5e","unresolved":true,"context_lines":[{"line_number":116,"context_line":"        1.1.11 - NAS secure ownership \u0026 permissions are now False by default"},{"line_number":117,"context_line":"        1.1.12 - Ensure the currently configured volume url is always used"},{"line_number":118,"context_line":"        1.1.13 - Allow creating volumes from snapshots in state \u0027backing-up\u0027"},{"line_number":119,"context_line":"        1.1.14 - Fixes regression from encryption being added in parent class\u0027"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    \"\"\""},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"e31890f9_e568ec7b","line":119,"range":{"start_line":119,"start_character":77,"end_line":119,"end_character":78},"updated":"2024-02-20 13:23:43.000000000","message":"nit: don\u0027t need this \u0027 at the end of the line","commit_id":"6179d5ef3c32f46047d79ebc3ac3479394ba0b33"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"f1fa47443d2bc8c05918c08909a18bc471492072","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        1.1.11 - NAS secure ownership \u0026 permissions are now False by default"},{"line_number":117,"context_line":"        1.1.12 - Ensure the currently configured volume url is always used"},{"line_number":118,"context_line":"        1.1.13 - Allow creating volumes from snapshots in state \u0027backing-up\u0027"},{"line_number":119,"context_line":"        1.1.14 - Fixes regression from encryption being added in parent class\u0027"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    \"\"\""},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"24086e8f_0d97d685","line":119,"range":{"start_line":119,"start_character":77,"end_line":119,"end_character":78},"in_reply_to":"e31890f9_e568ec7b","updated":"2024-02-21 09:23:56.000000000","message":"Acknowledged","commit_id":"6179d5ef3c32f46047d79ebc3ac3479394ba0b33"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"62d9df57610833ff04f48978ef21f937bddf8643","unresolved":true,"context_lines":[{"line_number":116,"context_line":"        1.1.11 - NAS secure ownership \u0026 permissions are now False by default"},{"line_number":117,"context_line":"        1.1.12 - Ensure the currently configured volume url is always used"},{"line_number":118,"context_line":"        1.1.13 - Allow creating volumes from snapshots in state \u0027backing-up\u0027"},{"line_number":119,"context_line":"        1.1.14 - Fixes regression from encryption being added in parent class\u0027"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    \"\"\""},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"84ab2762_b0d245e9","line":119,"range":{"start_line":119,"start_character":77,"end_line":119,"end_character":78},"updated":"2025-04-09 15:47:08.000000000","message":"Can remove this quote here since there is a follow-up patch doing the same.","commit_id":"24b209fe327018e9f1003248533ff5100687e659"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"8e0282be18c80d47f8d85feb94b9abaa902ac898","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        1.1.11 - NAS secure ownership \u0026 permissions are now False by default"},{"line_number":117,"context_line":"        1.1.12 - Ensure the currently configured volume url is always used"},{"line_number":118,"context_line":"        1.1.13 - Allow creating volumes from snapshots in state \u0027backing-up\u0027"},{"line_number":119,"context_line":"        1.1.14 - Fixes regression from encryption being added in parent class\u0027"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    \"\"\""},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"d0cf1669_46ac0127","line":119,"range":{"start_line":119,"start_character":77,"end_line":119,"end_character":78},"in_reply_to":"84ab2762_b0d245e9","updated":"2025-05-12 09:55:00.000000000","message":"Yes, merged as the original reason for the follow up is no longer valid.","commit_id":"24b209fe327018e9f1003248533ff5100687e659"}]}