)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"8436ad5cda0bb2d9e2a36f2b7cda684db91409a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ea7a1832_41c91610","updated":"2023-11-09 07:48:11.000000000","message":"A release note would be great.","commit_id":"4715a7a88bad7d365568a6d5b94679de24274eee"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"09058b73b073cf86d3c8ca67c61625243d8e60dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"73a21545_cdd35312","updated":"2023-11-22 08:00:12.000000000","message":"I thing we should extend the patch to update the documentation accordingly.","commit_id":"f4b386a1d2a8962edfc07662fcab3a571fb5d44b"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"109c7279d9d33ac066441bc207e8496fa33f7c01","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3ab9351d_1b0c8bcb","updated":"2023-11-24 14:16:09.000000000","message":"recheck","commit_id":"1f1fe011387d3425407328606ddfd46337786094"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"107c40d10e28383e00579519b02b406387af3d36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8a5b73a5_8a466966","updated":"2023-11-25 10:42:49.000000000","message":"recheck","commit_id":"1f1fe011387d3425407328606ddfd46337786094"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fb77d75c99b7d4302ce68e7b15041af83c220f49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"04391e8d_b633a6e3","updated":"2024-01-30 23:32:00.000000000","message":"A few questions/comments inline about the scope of the change.  Otherwise, the code and tests LGTM.","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b8f12bbceffc2de1f50ba01edd037e389f24ddc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2b955abe_bf7d18f6","updated":"2024-01-31 13:36:11.000000000","message":"Based on your replies, I think you should make a change in rest.py (see comment inline).  I also left a comment on the doc file suggesting how to handle the backport.","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"00f1f65b473d4f88384b9bab3ee717f781180884","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"60cb88a8_22da41b3","updated":"2023-12-18 11:04:38.000000000","message":"Is \"DellEMC PowerMAX CI\" passed on this patch ?","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"b14abab0ece8cd443484f326a2cb0c2b8623e3e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"db6e1c88_28e6a256","updated":"2024-01-17 20:49:15.000000000","message":"Voting -1 mainly to spur conversation around whether this patch could be eligible for backporting to stable releases that already support Unisphere 10.","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"8fd6c6f7fb027626e697388574aa93a77fe6a4af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5ea68fb3_1cb0149b","updated":"2024-01-24 01:35:48.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":17450,"name":"Chongchong Lei","email":"Nathaniel.Lei@dell.com","username":"Chongchong","status":"Dell EMC"},"change_message_id":"302a80f075b8009b7a3e36ffe8a076c0a5bcc8f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8318d475_b8318d89","updated":"2024-01-24 03:46:55.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"55ddb2f9153009e4ad5149a082f26cd7a61d5f98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ae4a749e_cb4640b2","updated":"2023-12-18 11:07:19.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"4beaf394ffa06598a7d27784b9119ec4fce381f7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9c350d68_6a6f124a","in_reply_to":"089b735c_76db0b73","updated":"2024-01-24 21:34:41.000000000","message":"I tried to explain it better in the other comment I added (in the code). I know that this patch is required in order to support UniSphere 10.1. The patch is very simple, and only loosens the validation logic. As far as I can tell, there are no other driver changes required for UniSphere 10.1.\n\nFor that reason, I wonder if the core reviewers would be OK if this patch (after it merges on master) were backported to stable releases.","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"55ddb2f9153009e4ad5149a082f26cd7a61d5f98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"31965e5e_d7442386","in_reply_to":"60cb88a8_22da41b3","updated":"2023-12-18 11:07:19.000000000","message":"I don\u0027t see it. Let me trigger it.","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"493bc62b8c18b3fec6076ac3d0f401ec6a153bb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"00c2bd04_34c3b71c","in_reply_to":"8bcd6b21_076b3667","updated":"2024-02-01 09:13:41.000000000","message":"Refactored as a bugfix.","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"62a06ce9a5a9a0f9cd17646c1c5368e641fb1780","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8bcd6b21_076b3667","in_reply_to":"9c350d68_6a6f124a","updated":"2024-01-29 08:02:37.000000000","message":"I\u0027ll ask core team. That\u0027d be great as we can then provide U4P 10.1 support down to Antelope (RHOSP 18 baseline).","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"1a1ff331659f48ad895fd6850684033b831e3c99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"089b735c_76db0b73","in_reply_to":"db6e1c88_28e6a256","updated":"2024-01-24 08:15:36.000000000","message":"not sure to get your point. This patch needs to merge in master to allow support of UniSphere 10.1 into release post caracal.","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6b6363dd8c4a7835272665a05a0ae1ee04166216","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"71c83234_d9b48e81","updated":"2024-02-01 15:00:37.000000000","message":"Code and tests look good.  The -1 is for a typo that you need to address because it\u0027s user facing.  Since you\u0027ll have to push a new patch, I have some suggestions also for the release note.  Except for those, this patch is fine.","commit_id":"c04bc7460396fe54e759c0d410a38160b01d2cd1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"764faa101bca4d8b96617480efa5cf9c00f32707","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2eb6e1e9_92bc9505","updated":"2024-02-01 15:02:05.000000000","message":"Forgot to vote.","commit_id":"c04bc7460396fe54e759c0d410a38160b01d2cd1"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"28b8627a7b7bfda1c4369a949f3ea2350bf9038e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d0ca75c6_37e35a77","updated":"2024-02-01 12:02:14.000000000","message":"recheck tempest-integrated-storage cinder-plugin-ceph-tempest","commit_id":"c04bc7460396fe54e759c0d410a38160b01d2cd1"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"0e6e6ac5845fdabcfd162402ea487e989c067c89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"689dabfa_3b101e08","updated":"2024-02-02 00:56:38.000000000","message":"I already mentioned that this code is weirdly written. Please see inside.","commit_id":"c3fb9c7bc2f7e4c2b242cd060c91a674e90bb9c7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8e40d0a332477a9e59b25a4d95cc4fde15902584","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7d854543_715a243f","updated":"2024-02-02 22:52:40.000000000","message":"Pete has a good point, but I think it could be dealt with in a followup patch.  (Not other cores will agree about that, though.)","commit_id":"c3fb9c7bc2f7e4c2b242cd060c91a674e90bb9c7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"82abbb5b64c4777fa2f5f07f113fe3ecb5439bad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"14ce4180_f9658602","updated":"2024-02-01 21:49:50.000000000","message":"That test failure is completely unrelated to this patch.  Code, tests, docs, and release note LGTM.","commit_id":"c3fb9c7bc2f7e4c2b242cd060c91a674e90bb9c7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9970ef9da5171fc9072d74b9a8f82b5369a993ed","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"67afa08a_f055ad53","updated":"2024-02-01 21:49:07.000000000","message":"recheck openstack-tox-py311 - we\u0027re suddenly seeing a weird eventlet timeout error in cinder.tests.unit.backup.drivers.test_backup_ceph.BackupCephTestCase, though it seems to happen in different tests in that class (this one is in test_restore_invalid_metadata_version), maybe because we run the tests in random order","commit_id":"c3fb9c7bc2f7e4c2b242cd060c91a674e90bb9c7"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"57c209de65046246a4cdf7480b3fbe6369c8f932","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"505f2c40_ef9115f3","updated":"2024-02-02 09:29:49.000000000","message":"recheck tempest-integrated-storage tempest-slow-py3","commit_id":"c3fb9c7bc2f7e4c2b242cd060c91a674e90bb9c7"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"db2288ec5d616bbf567eadd1aee8f48e477a8ab9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"78f6d7bc_254063ba","in_reply_to":"67afa08a_f055ad53","updated":"2024-02-08 05:19:18.000000000","message":"Done","commit_id":"c3fb9c7bc2f7e4c2b242cd060c91a674e90bb9c7"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"b69dc9146086eaad6b67a0a9add11fcbdecb9a32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ec1daafb_fe1641d4","updated":"2024-02-13 05:07:04.000000000","message":"Code changes and UT look good. Zuul and DellEMC PowerMAX CI have passed. So +1.","commit_id":"5d725806ff274d60aaeef83903303e1939502343"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"3d1e04f615165520d54d2e53a85958971b2e0ab8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bff0b10e_947011ef","updated":"2024-02-07 13:44:00.000000000","message":"LGTM","commit_id":"5d725806ff274d60aaeef83903303e1939502343"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5002c5ce47163047c9c82f5849b0da415493cd0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fcccd44b_893a8dce","updated":"2024-02-13 17:05:44.000000000","message":"Revisions LGTM.","commit_id":"5d725806ff274d60aaeef83903303e1939502343"},{"author":{"_account_id":17450,"name":"Chongchong Lei","email":"Nathaniel.Lei@dell.com","username":"Chongchong","status":"Dell EMC"},"change_message_id":"bd9f495fb7dfa451b5a3b1a9a7669b7898e48d03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"49ec3d3f_91e0e4a9","updated":"2024-02-05 13:20:31.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"5d725806ff274d60aaeef83903303e1939502343"},{"author":{"_account_id":36625,"name":"Rick Liu","email":"rick.liu@dell.com"},"change_message_id":"83d486df94487ee5c2ebf319dbe0568901e3ca95","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e295600f_b2a50705","updated":"2024-02-06 02:49:50.000000000","message":"run-DellEMC PowerStore CI","commit_id":"5d725806ff274d60aaeef83903303e1939502343"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"db2288ec5d616bbf567eadd1aee8f48e477a8ab9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"921b3e2a_76fc7628","in_reply_to":"e295600f_b2a50705","updated":"2024-02-08 05:19:18.000000000","message":"Done","commit_id":"5d725806ff274d60aaeef83903303e1939502343"}],"cinder/volume/drivers/dell_emc/powermax/rest.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fb77d75c99b7d4302ce68e7b15041af83c220f49","unresolved":true,"context_lines":[{"line_number":3465,"context_line":"        :returns: unisphere_meets_min_req -- boolean"},{"line_number":3466,"context_line":"        \"\"\""},{"line_number":3467,"context_line":"        running_version, major_version \u003d self.get_uni_version()"},{"line_number":3468,"context_line":"        if major_version \u003d\u003d U4P_100_VERSION:"},{"line_number":3469,"context_line":"            self.u4p_version \u003d U4P_100_VERSION"},{"line_number":3470,"context_line":"            minimum_version \u003d MIN_U4P_100_VERSION"},{"line_number":3471,"context_line":"        elif major_version:"}],"source_content_type":"text/x-python","patch_set":5,"id":"756eec75_4bc0eb29","side":"PARENT","line":3468,"range":{"start_line":3468,"start_character":8,"end_line":3468,"end_character":44},"updated":"2024-01-30 23:32:00.000000000","message":"OK, so what was basically going on here was that if the uni version was 10.1, we\u0027d take the else branch and be forced to use 9.2.0.0 instead.","commit_id":"4ee1bdaf648064adb6ad9f0e4fda6adc6ad1cbb6"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"857ca9663ce7e433b7484e1e4e90f3f1faa6813c","unresolved":false,"context_lines":[{"line_number":3465,"context_line":"        :returns: unisphere_meets_min_req -- boolean"},{"line_number":3466,"context_line":"        \"\"\""},{"line_number":3467,"context_line":"        running_version, major_version \u003d self.get_uni_version()"},{"line_number":3468,"context_line":"        if major_version \u003d\u003d U4P_100_VERSION:"},{"line_number":3469,"context_line":"            self.u4p_version \u003d U4P_100_VERSION"},{"line_number":3470,"context_line":"            minimum_version \u003d MIN_U4P_100_VERSION"},{"line_number":3471,"context_line":"        elif major_version:"}],"source_content_type":"text/x-python","patch_set":5,"id":"a3d4343e_b164f74e","side":"PARENT","line":3468,"range":{"start_line":3468,"start_character":8,"end_line":3468,"end_character":44},"in_reply_to":"756eec75_4bc0eb29","updated":"2024-01-31 05:13:18.000000000","message":"For Unisphere 10.1, it\u0027s invoking PowerMax RESTAPI 92.\n\nBelow is the compatibility of PowerMax Unisphere and RESTAPI version:\n| PowerMax Unisphere  | PowerMax RESTAPI version\n| 9.2                 | 92\n| 10.0                | 92 and 100\n| 10.1                | 100 and 101    \n\nThe problem here is Unisphere 10.1 is not compatible with RESTAPI 92.","commit_id":"4ee1bdaf648064adb6ad9f0e4fda6adc6ad1cbb6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fb77d75c99b7d4302ce68e7b15041af83c220f49","unresolved":true,"context_lines":[{"line_number":3466,"context_line":"        \"\"\""},{"line_number":3467,"context_line":"        running_version, major_version \u003d self.get_uni_version()"},{"line_number":3468,"context_line":"        if major_version:"},{"line_number":3469,"context_line":"            if int(major_version) \u003e\u003d int(U4P_100_VERSION):"},{"line_number":3470,"context_line":"                self.u4p_version \u003d U4P_100_VERSION"},{"line_number":3471,"context_line":"                minimum_version \u003d MIN_U4P_100_VERSION"},{"line_number":3472,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"e6232f33_107ebf2b","line":3469,"updated":"2024-01-30 23:32:00.000000000","message":"If the uni version is 11.2 or something, we\u0027ll still take this branch, but presumably that\u0027s OK because 11 should be backward compatible with 10.  Is that correct?  (See my comment on the doc page.)","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"40fd76f48ffd145dd4057c6e322ff7d7458aa332","unresolved":false,"context_lines":[{"line_number":3466,"context_line":"        \"\"\""},{"line_number":3467,"context_line":"        running_version, major_version \u003d self.get_uni_version()"},{"line_number":3468,"context_line":"        if major_version:"},{"line_number":3469,"context_line":"            if int(major_version) \u003e\u003d int(U4P_100_VERSION):"},{"line_number":3470,"context_line":"                self.u4p_version \u003d U4P_100_VERSION"},{"line_number":3471,"context_line":"                minimum_version \u003d MIN_U4P_100_VERSION"},{"line_number":3472,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"88d0db8e_4c4272fd","line":3469,"in_reply_to":"a18b2e7b_e45f0e32","updated":"2024-02-01 08:48:05.000000000","message":"Done. Thank you!","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b8f12bbceffc2de1f50ba01edd037e389f24ddc2","unresolved":true,"context_lines":[{"line_number":3466,"context_line":"        \"\"\""},{"line_number":3467,"context_line":"        running_version, major_version \u003d self.get_uni_version()"},{"line_number":3468,"context_line":"        if major_version:"},{"line_number":3469,"context_line":"            if int(major_version) \u003e\u003d int(U4P_100_VERSION):"},{"line_number":3470,"context_line":"                self.u4p_version \u003d U4P_100_VERSION"},{"line_number":3471,"context_line":"                minimum_version \u003d MIN_U4P_100_VERSION"},{"line_number":3472,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"a18b2e7b_e45f0e32","line":3469,"in_reply_to":"e0175fd3_d72ee10c","updated":"2024-01-31 13:36:11.000000000","message":"OK, in that case, I suggest changing this to first check if int(major_version) \u003e\u003d int(\u0027110\u0027) (or whatever the appropriate comparison is), and if so, logging and raising an exception indicating that this version is not supported.  That will be a more graceful way to fail in the interim before 11.x support is added.","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"857ca9663ce7e433b7484e1e4e90f3f1faa6813c","unresolved":false,"context_lines":[{"line_number":3466,"context_line":"        \"\"\""},{"line_number":3467,"context_line":"        running_version, major_version \u003d self.get_uni_version()"},{"line_number":3468,"context_line":"        if major_version:"},{"line_number":3469,"context_line":"            if int(major_version) \u003e\u003d int(U4P_100_VERSION):"},{"line_number":3470,"context_line":"                self.u4p_version \u003d U4P_100_VERSION"},{"line_number":3471,"context_line":"                minimum_version \u003d MIN_U4P_100_VERSION"},{"line_number":3472,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"e0175fd3_d72ee10c","line":3469,"in_reply_to":"e6232f33_107ebf2b","updated":"2024-01-31 05:13:18.000000000","message":"Same as above.\nFor 11.x or later, we will need to bump up RESTAPI version accordingly.","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"890460a211ee83f7ec77e37fc70c32476915fc9b","unresolved":true,"context_lines":[{"line_number":3472,"context_line":"            else:"},{"line_number":3473,"context_line":"                self.u4p_version \u003d U4P_92_VERSION"},{"line_number":3474,"context_line":"                minimum_version \u003d MIN_U4P_92_VERSION"},{"line_number":3475,"context_line":"        unisphere_meets_min_req \u003d False"},{"line_number":3476,"context_line":""},{"line_number":3477,"context_line":"        if running_version and (running_version[0].isalpha()):"},{"line_number":3478,"context_line":"            # remove leading letter"}],"source_content_type":"text/x-python","patch_set":5,"id":"c380664a_78e4d6d9","line":3475,"updated":"2024-01-30 23:41:34.000000000","message":"I don\u0027t quite understand, what was the refactoring supposed to accomplish? The original code would traceback if major_version was not properly returned. But this improvement still uses minimum_version down below and would traceback anyway, it looks to me. But if major_version is always present, then the outside if: is pointless.","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"bea9242acc27828d5caffc77323321c5dd0a67b5","unresolved":false,"context_lines":[{"line_number":3472,"context_line":"            else:"},{"line_number":3473,"context_line":"                self.u4p_version \u003d U4P_92_VERSION"},{"line_number":3474,"context_line":"                minimum_version \u003d MIN_U4P_92_VERSION"},{"line_number":3475,"context_line":"        unisphere_meets_min_req \u003d False"},{"line_number":3476,"context_line":""},{"line_number":3477,"context_line":"        if running_version and (running_version[0].isalpha()):"},{"line_number":3478,"context_line":"            # remove leading letter"}],"source_content_type":"text/x-python","patch_set":5,"id":"423dfc17_a81a1962","line":3475,"in_reply_to":"c380664a_78e4d6d9","updated":"2024-01-31 06:05:16.000000000","message":"For Unisphere 10.1, the driver need to invoke PowerMax RESTAPI 100 instead of 92.","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6b6363dd8c4a7835272665a05a0ae1ee04166216","unresolved":true,"context_lines":[{"line_number":3470,"context_line":"        if major_version:"},{"line_number":3471,"context_line":"            if int(major_version) \u003e\u003d int(U4P_110_VERSION):"},{"line_number":3472,"context_line":"                msg \u003d _(\"Unisphere version %(running_version)s \""},{"line_number":3473,"context_line":"                        \"is not supportted.\") % {"},{"line_number":3474,"context_line":"                            \u0027running_version\u0027: running_version}"},{"line_number":3475,"context_line":"                LOG.error(msg)"},{"line_number":3476,"context_line":"                raise exception.InvalidConfigurationValue(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"b04be7e9_02441173","line":3473,"range":{"start_line":3473,"start_character":32,"end_line":3473,"end_character":42},"updated":"2024-02-01 15:00:37.000000000","message":"nit: supported (only 1 \u0027t\u0027)","commit_id":"c04bc7460396fe54e759c0d410a38160b01d2cd1"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"06996582aba1628628b4050dd70cf4630bf1f207","unresolved":false,"context_lines":[{"line_number":3470,"context_line":"        if major_version:"},{"line_number":3471,"context_line":"            if int(major_version) \u003e\u003d int(U4P_110_VERSION):"},{"line_number":3472,"context_line":"                msg \u003d _(\"Unisphere version %(running_version)s \""},{"line_number":3473,"context_line":"                        \"is not supportted.\") % {"},{"line_number":3474,"context_line":"                            \u0027running_version\u0027: running_version}"},{"line_number":3475,"context_line":"                LOG.error(msg)"},{"line_number":3476,"context_line":"                raise exception.InvalidConfigurationValue(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"323da3c7_f91a6f72","line":3473,"range":{"start_line":3473,"start_character":32,"end_line":3473,"end_character":42},"in_reply_to":"b04be7e9_02441173","updated":"2024-02-01 16:11:49.000000000","message":"Done","commit_id":"c04bc7460396fe54e759c0d410a38160b01d2cd1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8e40d0a332477a9e59b25a4d95cc4fde15902584","unresolved":true,"context_lines":[{"line_number":762,"context_line":"        response \u003d self.get_unisphere_version()"},{"line_number":763,"context_line":"        if response and response.get(\u0027version\u0027):"},{"line_number":764,"context_line":"            version \u003d response[\u0027version\u0027]"},{"line_number":765,"context_line":"            version_list \u003d version.split(\u0027.\u0027)"},{"line_number":766,"context_line":"            major_version \u003d version_list[0][1:] + version_list[1]"},{"line_number":767,"context_line":"        return version, major_version"},{"line_number":768,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"89e3e26e_33c16337","line":765,"updated":"2024-02-02 22:52:40.000000000","message":"This code does make an assumption that if the repsonse contains a \u0027version\u0027 key, the value is correctly formatted.  For example, if response[\u0027version\u0027] is an empty string or doesn\u0027t contain a \u0027.\u0027, you\u0027ll get an IndexError when you refer to element 1 in line 766.","commit_id":"c3fb9c7bc2f7e4c2b242cd060c91a674e90bb9c7"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"28f23ae67e95e9d70a112d05c85469348a19f7a8","unresolved":false,"context_lines":[{"line_number":762,"context_line":"        response \u003d self.get_unisphere_version()"},{"line_number":763,"context_line":"        if response and response.get(\u0027version\u0027):"},{"line_number":764,"context_line":"            version \u003d response[\u0027version\u0027]"},{"line_number":765,"context_line":"            version_list \u003d version.split(\u0027.\u0027)"},{"line_number":766,"context_line":"            major_version \u003d version_list[0][1:] + version_list[1]"},{"line_number":767,"context_line":"        return version, major_version"},{"line_number":768,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"6d657802_19e812b9","line":765,"in_reply_to":"89e3e26e_33c16337","updated":"2024-02-04 13:22:49.000000000","message":"Done","commit_id":"c3fb9c7bc2f7e4c2b242cd060c91a674e90bb9c7"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"0e6e6ac5845fdabcfd162402ea487e989c067c89","unresolved":true,"context_lines":[{"line_number":3467,"context_line":"        :returns: unisphere_meets_min_req -- boolean"},{"line_number":3468,"context_line":"        \"\"\""},{"line_number":3469,"context_line":"        running_version, major_version \u003d self.get_uni_version()"},{"line_number":3470,"context_line":"        if major_version:"},{"line_number":3471,"context_line":"            if int(major_version) \u003e\u003d int(U4P_110_VERSION):"},{"line_number":3472,"context_line":"                msg \u003d _(\"Unisphere version %(running_version)s \""},{"line_number":3473,"context_line":"                        \"is not supported.\") % {"}],"source_content_type":"text/x-python","patch_set":7,"id":"af4874b1_3e7879ce","line":3470,"updated":"2024-02-02 00:56:38.000000000","message":"What does this check do? Under what scenario does it do anything at all?\n\nIf running_version is present and major_version is not, the code will tracebakc when it refers to minimum_version below.","commit_id":"c3fb9c7bc2f7e4c2b242cd060c91a674e90bb9c7"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"72b2be9084374f142bdafbaf145301f872a72260","unresolved":false,"context_lines":[{"line_number":3467,"context_line":"        :returns: unisphere_meets_min_req -- boolean"},{"line_number":3468,"context_line":"        \"\"\""},{"line_number":3469,"context_line":"        running_version, major_version \u003d self.get_uni_version()"},{"line_number":3470,"context_line":"        if major_version:"},{"line_number":3471,"context_line":"            if int(major_version) \u003e\u003d int(U4P_110_VERSION):"},{"line_number":3472,"context_line":"                msg \u003d _(\"Unisphere version %(running_version)s \""},{"line_number":3473,"context_line":"                        \"is not supported.\") % {"}],"source_content_type":"text/x-python","patch_set":7,"id":"1bb4891a_7a39629e","line":3470,"in_reply_to":"20ee1ed1_c6464ee9","updated":"2024-02-02 23:03:40.000000000","message":"Indeed the new code is not worse than before, there\u0027s no regression. I just thought that if a refactoring happens, it could be fixed up.","commit_id":"c3fb9c7bc2f7e4c2b242cd060c91a674e90bb9c7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8e40d0a332477a9e59b25a4d95cc4fde15902584","unresolved":false,"context_lines":[{"line_number":3467,"context_line":"        :returns: unisphere_meets_min_req -- boolean"},{"line_number":3468,"context_line":"        \"\"\""},{"line_number":3469,"context_line":"        running_version, major_version \u003d self.get_uni_version()"},{"line_number":3470,"context_line":"        if major_version:"},{"line_number":3471,"context_line":"            if int(major_version) \u003e\u003d int(U4P_110_VERSION):"},{"line_number":3472,"context_line":"                msg \u003d _(\"Unisphere version %(running_version)s \""},{"line_number":3473,"context_line":"                        \"is not supported.\") % {"}],"source_content_type":"text/x-python","patch_set":7,"id":"20ee1ed1_c6464ee9","line":3470,"in_reply_to":"9ad9cff4_755b83c7","updated":"2024-02-02 22:52:40.000000000","message":"Looking at the get_uni_version(), it looks like either both running_v and major_v will have a value or they\u0027ll both be None (or an exception will have already happened -- see my comment above).\n\nI agree with Pete that this code is very weird, because the gating condition for minimum_v having a value is that major_v has a value, but when we use minimum_v at line 3507, we gate on running_v (not major_v).  This makes it difficult to see that minimum_v will be initialized when we first use it.  (I\u0027m surprised that the pylint job didn\u0027t flag this.)\n\nA better way to structure this code might be to initialize minimum_v (and probably also self.u4p_version) to MIN_U4P_92_VERSION (and U4P_100_VERSION) at the beginning of the function, and then do the checks after you get_uni_version to see if they should be changed.\n\nBut maybe that should be a followup patch.  Your patch doesn\u0027t introduce the possibly-uninitialized-minimum_v problem; it existed on the previous patch.","commit_id":"c3fb9c7bc2f7e4c2b242cd060c91a674e90bb9c7"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"1ee4a8e80d3b1dd4856e0132239b4b29126ea508","unresolved":false,"context_lines":[{"line_number":3467,"context_line":"        :returns: unisphere_meets_min_req -- boolean"},{"line_number":3468,"context_line":"        \"\"\""},{"line_number":3469,"context_line":"        running_version, major_version \u003d self.get_uni_version()"},{"line_number":3470,"context_line":"        if major_version:"},{"line_number":3471,"context_line":"            if int(major_version) \u003e\u003d int(U4P_110_VERSION):"},{"line_number":3472,"context_line":"                msg \u003d _(\"Unisphere version %(running_version)s \""},{"line_number":3473,"context_line":"                        \"is not supported.\") % {"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad9cff4_755b83c7","line":3470,"in_reply_to":"af4874b1_3e7879ce","updated":"2024-02-02 08:07:55.000000000","message":"Hi Pete,\nThe \u0027running_version\u0027 is retrieved from the property \u0027version\u0027 of the rest response.\nThe \u0027major_version\u0027 is formatted from the part of \u0027running_version\u0027.\nThey can be both \u0027None\u0027 if the response is not as expected.\nIt\u0027s unlikely \u0027running_version\u0027 is present and \u0027major_version\u0027 is not.","commit_id":"c3fb9c7bc2f7e4c2b242cd060c91a674e90bb9c7"}],"doc/source/configuration/block-storage/drivers/dell-emc-powermax-driver.rst":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"b14abab0ece8cd443484f326a2cb0c2b8623e3e2","unresolved":true,"context_lines":[{"line_number":59,"context_line":"   | OpenStack | Unisphere    | PowerMax OS | Supported Arrays               |"},{"line_number":60,"context_line":"   | release   | for PowerMax |             |                                |"},{"line_number":61,"context_line":"   +\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":62,"context_line":"   | Caracal   | 10.1.0       | 10.1.0      | PowerMax 2500,8500             |"},{"line_number":63,"context_line":"   |           |              | (6079.225)  |                                |"},{"line_number":64,"context_line":"   |           |              +-------------+--------------------------------+"},{"line_number":65,"context_line":"   |           |              | 5978.711    | PowerMax 2000,8000             |"}],"source_content_type":"text/x-rst","patch_set":5,"id":"c67f57d9_25eb48aa","line":62,"updated":"2024-01-17 20:49:15.000000000","message":"I understand the request to backport Unisphere 10 support to a stable release was rejected [1] because it\u0027s a feature backport.\n\n[1] https://review.opendev.org/c/openstack/cinder/+/899141\n\nThis patch simply loosens the Unisphere version validation, which I personally don\u0027t view as a feature. I would be curious to know how the cinder cores feel about this, and whether this patch might be eligible for backports to stable releases that support Unisphere 10.","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fb77d75c99b7d4302ce68e7b15041af83c220f49","unresolved":true,"context_lines":[{"line_number":59,"context_line":"   | OpenStack | Unisphere    | PowerMax OS | Supported Arrays               |"},{"line_number":60,"context_line":"   | release   | for PowerMax |             |                                |"},{"line_number":61,"context_line":"   +\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":62,"context_line":"   | Caracal   | 10.1.0       | 10.1.0      | PowerMax 2500,8500             |"},{"line_number":63,"context_line":"   |           |              | (6079.225)  |                                |"},{"line_number":64,"context_line":"   |           |              +-------------+--------------------------------+"},{"line_number":65,"context_line":"   |           |              | 5978.711    | PowerMax 2000,8000             |"}],"source_content_type":"text/x-rst","patch_set":5,"id":"b118c782_27b7248b","line":62,"in_reply_to":"33d40460_e0cd6d7f","updated":"2024-01-30 23:32:00.000000000","message":"Well, it can, right?  Without this patch the driver acts as if it\u0027s using 9.2, but it still basically works.  Or am I misunderstanding what this patch is doing?","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"b3f0d3e98c3b135a821b1776628a1eaf8dfd6687","unresolved":false,"context_lines":[{"line_number":59,"context_line":"   | OpenStack | Unisphere    | PowerMax OS | Supported Arrays               |"},{"line_number":60,"context_line":"   | release   | for PowerMax |             |                                |"},{"line_number":61,"context_line":"   +\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":62,"context_line":"   | Caracal   | 10.1.0       | 10.1.0      | PowerMax 2500,8500             |"},{"line_number":63,"context_line":"   |           |              | (6079.225)  |                                |"},{"line_number":64,"context_line":"   |           |              +-------------+--------------------------------+"},{"line_number":65,"context_line":"   |           |              | 5978.711    | PowerMax 2000,8000             |"}],"source_content_type":"text/x-rst","patch_set":5,"id":"4950f601_aae24883","line":62,"in_reply_to":"aea571b6_07920342","updated":"2024-02-01 09:12:47.000000000","message":"Got it. Thanks!","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"857ca9663ce7e433b7484e1e4e90f3f1faa6813c","unresolved":true,"context_lines":[{"line_number":59,"context_line":"   | OpenStack | Unisphere    | PowerMax OS | Supported Arrays               |"},{"line_number":60,"context_line":"   | release   | for PowerMax |             |                                |"},{"line_number":61,"context_line":"   +\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":62,"context_line":"   | Caracal   | 10.1.0       | 10.1.0      | PowerMax 2500,8500             |"},{"line_number":63,"context_line":"   |           |              | (6079.225)  |                                |"},{"line_number":64,"context_line":"   |           |              +-------------+--------------------------------+"},{"line_number":65,"context_line":"   |           |              | 5978.711    | PowerMax 2000,8000             |"}],"source_content_type":"text/x-rst","patch_set":5,"id":"effeab84_4c4b3602","line":62,"in_reply_to":"b118c782_27b7248b","updated":"2024-01-31 05:13:18.000000000","message":"It doesn\u0027t work as 10.1 is not compatible with 92.\n\nI will refactor this patch as bugfix.\nOne question is can I revert the change in this doc.\nOnce backported, mentioning Caracal on previous release looks strange.","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"9ebcc9552cac67ebc3690bb40450902cf136219d","unresolved":true,"context_lines":[{"line_number":59,"context_line":"   | OpenStack | Unisphere    | PowerMax OS | Supported Arrays               |"},{"line_number":60,"context_line":"   | release   | for PowerMax |             |                                |"},{"line_number":61,"context_line":"   +\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":62,"context_line":"   | Caracal   | 10.1.0       | 10.1.0      | PowerMax 2500,8500             |"},{"line_number":63,"context_line":"   |           |              | (6079.225)  |                                |"},{"line_number":64,"context_line":"   |           |              +-------------+--------------------------------+"},{"line_number":65,"context_line":"   |           |              | 5978.711    | PowerMax 2000,8000             |"}],"source_content_type":"text/x-rst","patch_set":5,"id":"33d40460_e0cd6d7f","line":62,"in_reply_to":"c67f57d9_25eb48aa","updated":"2024-01-18 12:43:09.000000000","message":"Without this change, the driver can\u0027t work with PowerMax Unisphere 10.1.","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b8f12bbceffc2de1f50ba01edd037e389f24ddc2","unresolved":true,"context_lines":[{"line_number":59,"context_line":"   | OpenStack | Unisphere    | PowerMax OS | Supported Arrays               |"},{"line_number":60,"context_line":"   | release   | for PowerMax |             |                                |"},{"line_number":61,"context_line":"   +\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":62,"context_line":"   | Caracal   | 10.1.0       | 10.1.0      | PowerMax 2500,8500             |"},{"line_number":63,"context_line":"   |           |              | (6079.225)  |                                |"},{"line_number":64,"context_line":"   |           |              +-------------+--------------------------------+"},{"line_number":65,"context_line":"   |           |              | 5978.711    | PowerMax 2000,8000             |"}],"source_content_type":"text/x-rst","patch_set":5,"id":"aea571b6_07920342","line":62,"in_reply_to":"effeab84_4c4b3602","updated":"2024-01-31 13:36:11.000000000","message":"Yes, it\u0027s permitted to modify the backport as long as you mention what has changed in the commit message.  I suggest doing something like this:\n\nDo the backport (with \u0027git cherry-pick -x \u003chash\u003e\u0027), which will give you a commit message that looks something like this:\n\n    Recognize Dell PowerMax Unisphere 10.x (x\u003e0)\n    \n    Fixes an issue introduced by change Ie9561eeb30a54539cbd, which added\n    support for PowerMax Unisphere 10.\n    \n    Closes-bug: #12345\n    Change-Id: Ib66688f319d6aed5d7339f4eabdd7ca9ce7e0f6c\n    (cherry picked from commit \u003chash\u003e)\n\nMake the doc change and then amend the commit and change the commit message to something like this:\n\n    Recognize Dell PowerMax Unisphere 10.x (x\u003e0)\n    \n    Fixes an issue introduced by change Ie9561eeb30a54539cbd, which added\n    support for PowerMax Unisphere 10.\n    \n    Closes-bug: #12345\n    Change-Id: Ib66688f319d6aed5d7339f4eabdd7ca9ce7e0f6c\n    (cherry picked from commit \u003chash\u003e)\n    Changes:\n      doc/source/configuration/block-storage/drivers/dell-emc-powermax-driver.rst\n      - removed reference to Caracal, updated Bobcat info\n\nAnd then do a similar thing when you backport to Antelope:\n\n    Recognize Dell PowerMax Unisphere 10.x (x\u003e0)\n    \n    Fixes an issue introduced by change Ie9561eeb30a54539cbd, which added\n    support for PowerMax Unisphere 10.\n    \n    Closes-bug: #12345\n    Change-Id: Ib66688f319d6aed5d7339f4eabdd7ca9ce7e0f6c\n    (cherry picked from commit \u003chash\u003e)\n    Changes:\n      doc/source/configuration/block-storage/drivers/dell-emc-powermax-driver.rst\n      - removed reference to Caracal, updated Bobcat info\n    (cherry picked from commit \u003chash2\u003e)\n    Changes:\n      doc/source/configuration/block-storage/drivers/dell-emc-powermax-driver.rst\n      - removed reference to Bobcat, updated Antelope info","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"}],"releasenotes/notes/dell-powermax-unisphere-v101-7195af74d1c7671c.yaml":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"e4ac27247f45509fa9a4f65fbdf19f9dfca75482","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerMax driver: Enabled PowerMax Unisphere v10.1 endpoints."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5543ca5f_65636693","line":4,"updated":"2023-11-15 06:59:23.000000000","message":"Dell PowerMax driver: Add support for UniSphere v10 and PowerMax v4","commit_id":"f4b386a1d2a8962edfc07662fcab3a571fb5d44b"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"ccfd783e7c92437e7e448e955de5a519f98125dc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerMax driver: Enabled PowerMax Unisphere v10.1 endpoints."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"96020ddd_02c10e3c","line":4,"in_reply_to":"5543ca5f_65636693","updated":"2023-11-15 07:08:21.000000000","message":"Dell PowerMax driver: Extend support for Unisphere v10.x","commit_id":"f4b386a1d2a8962edfc07662fcab3a571fb5d44b"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"76f5657b2502cf76c9ae575d8bb05739c5c3095c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerMax driver: Enabled PowerMax Unisphere v10.1 endpoints."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6f26ab1e_0973c41c","line":4,"in_reply_to":"96020ddd_02c10e3c","updated":"2023-11-16 03:45:52.000000000","message":"We will qualify Unisphere v10.1 only. Claiming support of v10.x is not suitable.","commit_id":"f4b386a1d2a8962edfc07662fcab3a571fb5d44b"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"a3c09fbd3c103d2664867cc0e28c616f4ffe712d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerMax driver: Enabled PowerMax Unisphere v10.1 endpoints."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"2325a08f_91af8473","line":4,"updated":"2023-11-27 10:56:54.000000000","message":"Sould be rephrased to:\nAdd support for Unisphere for PowerMax v10.1","commit_id":"1f1fe011387d3425407328606ddfd46337786094"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"a0ec0e199b35a3d2fcdeb2932e774a6a698e9724","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerMax driver: Enabled PowerMax Unisphere v10.1 endpoints."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"af6fd962_d2b95be8","line":4,"in_reply_to":"2325a08f_91af8473","updated":"2023-11-30 10:45:57.000000000","message":"Done","commit_id":"1f1fe011387d3425407328606ddfd46337786094"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"b1a16a36eb9a4436a6fa4131ed287828c7ce752d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerMax driver: Added support for Unisphere for PowerMax v10.1."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3752ec81_8b653ec6","line":4,"updated":"2024-01-29 08:03:43.000000000","message":"Should be rephrased to a more meaning full manner\nExtend Unisphere for PowerMax support to 10.1","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"1d2eb19c13230346c5fedd5a9ac556a7c4799d4a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerMax driver: Added support for Unisphere for PowerMax v10.1."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4b9e018e_15e53cb0","line":4,"in_reply_to":"3752ec81_8b653ec6","updated":"2024-01-29 11:02:54.000000000","message":"Frankly speaking, I don\u0027t see any difference...","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fb77d75c99b7d4302ce68e7b15041af83c220f49","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerMax driver: Added support for Unisphere for PowerMax v10.1."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6b9706f5_106d4467","line":4,"in_reply_to":"4568c5ff_3cc0e166","updated":"2024-01-30 23:32:00.000000000","message":"@Yian: the difference is that \"Add support\" sounds like you\u0027re adding a new feature, which generally speaking, would not be backportable.  What\u0027s actually going on is that change Ie9561eeb30a54539cbd added the infrastructure necessary to support PowerMax 10 series, but it unfortunately checked for an exact match for 10.0, and so wound up using only 9.2 features for PowerMax 10.x for x\u003e0.  That sounds like a bug to me, and a bug fix is usually backportable.  So I\u0027d rephrase what this patch is doing, both here and in the commit message, and it wouldn\u0027t hurt to file a bug to make it clear what the scope of this change is.  (That is, assuming my understanding is correct.)","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"897829a4ee5b048babea09702b4504d1b2d9905f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerMax driver: Added support for Unisphere for PowerMax v10.1."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4568c5ff_3cc0e166","line":4,"in_reply_to":"4b9e018e_15e53cb0","updated":"2024-01-29 11:05:25.000000000","message":"This is an extension of the initial support.","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"857ca9663ce7e433b7484e1e4e90f3f1faa6813c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerMax driver: Added support for Unisphere for PowerMax v10.1."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f1ee7fb1_691ce068","line":4,"in_reply_to":"6b9706f5_106d4467","updated":"2024-01-31 05:13:18.000000000","message":"I will refactor this patch as a bugfix.","commit_id":"61123b1bc4664c9206f50ba65af9a5a09933bf1a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6b6363dd8c4a7835272665a05a0ae1ee04166216","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Dell PowerMax driver \u0027bug #2051828"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2051828\u003e`_: Fixed"},{"line_number":6,"context_line":"    an issue introduced by change Ie9561eeb30a54539cbd, which"},{"line_number":7,"context_line":"    added support for PowerMax Unisphere 10."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"091e8c94_4b32e6a8","line":7,"updated":"2024-02-01 15:00:37.000000000","message":"I think for this, you should instead say something about the actual problem being that the driver only recognized 10.0 as being unisphere 10 and would try to use 9.2 for 10.x (where x \u003e 0), but now it correctly recognizes 10.x as being unisphere 10.  (Otherwise, operators reading the note won\u0027t know exactly what the issue was that was fixed.)","commit_id":"c04bc7460396fe54e759c0d410a38160b01d2cd1"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"06996582aba1628628b4050dd70cf4630bf1f207","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Dell PowerMax driver \u0027bug #2051828"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2051828\u003e`_: Fixed"},{"line_number":6,"context_line":"    an issue introduced by change Ie9561eeb30a54539cbd, which"},{"line_number":7,"context_line":"    added support for PowerMax Unisphere 10."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6c24e4ff_618d9748","line":7,"in_reply_to":"091e8c94_4b32e6a8","updated":"2024-02-01 16:11:49.000000000","message":"Done","commit_id":"c04bc7460396fe54e759c0d410a38160b01d2cd1"}]}