)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"1f1a9d2c80645119cfd88ac2b9f894e53e339e39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7c0c9370_2cd63080","updated":"2023-12-08 15:10:54.000000000","message":"Please explain why this change is made.\n\nAND PLEASE DON\u0027T ABANDON THE WHOLE THING JUST TO MAKE A SMALL CHANGE LIKE THIS.","commit_id":"415c9629d71f9494bf91ebb4c9da41128c326b60"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"58e374c0fbfb4dea7a5cd46450e91776c9d3543c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b561967b_5d208357","updated":"2023-12-08 13:59:45.000000000","message":"code and tests looks good though the gate failure seems legit\n\nhttps://f8bf2d4a845608449589-8f1f171af5507b30533733754e7f1ad8.ssl.cf5.rackcdn.com/900654/1/check/openstack-tox-py38/718a681/testr_results.html\n\ncinder.tests.unit.volume.drivers.test_fujitsu_dx.FJCommonTestCase.test_get_matadata\n\n\nTraceback (most recent call last):\n  File \"/home/zuul/src/opendev.org/openstack/cinder/cinder/tests/unit/volume/drivers/test_fujitsu_dx.py\", line 1782, in test_get_matadata\n    self.assertEqual({}, TEST_METADATA)\n  File \"/home/zuul/src/opendev.org/openstack/cinder/.tox/py38/lib/python3.8/site-packages/testtools/testcase.py\", line 394, in assertEqual\n    self.assertThat(observed, matcher, message)\n  File \"/home/zuul/src/opendev.org/openstack/cinder/.tox/py38/lib/python3.8/site-packages/testtools/testcase.py\", line 481, in assertThat\n    raise mismatch_error\ntesttools.matchers._impl.MismatchError: !\u003d:\nreference \u003d {}\nactual    \u003d {\u0027FJ_Backend\u0027: \u0027ET603SA4621302115\u0027,\n \u0027FJ_Pool_Name\u0027: \u0027abcd1234_TPP\u0027,\n \u0027FJ_Pool_Type\u0027: \u0027Thinporvisioning_POOL\u0027,\n \u0027FJ_Volume_Name\u0027: \u0027FJosv_0qJ4rpOHgFE8ipcJOMfBmg\u003d\u003d\u0027,\n \u0027FJ_Volume_No\u0027: \u00270x0014\u0027}","commit_id":"415c9629d71f9494bf91ebb4c9da41128c326b60"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"0c4df025df16d105c27d3dca1f3fbf8f75c6d5cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"37031533_0637a1b6","in_reply_to":"7c0c9370_2cd63080","updated":"2024-01-03 09:23:20.000000000","message":"We want to backport this patch to OSP16, but hashlib is not supported in OSP16.\nSo we added this package. We\u0027ll remove the support for this import in future patches.","commit_id":"415c9629d71f9494bf91ebb4c9da41128c326b60"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"0c4df025df16d105c27d3dca1f3fbf8f75c6d5cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"da31adff_68f12059","in_reply_to":"b561967b_5d208357","updated":"2024-01-03 09:23:20.000000000","message":"This error has been addressed.","commit_id":"415c9629d71f9494bf91ebb4c9da41128c326b60"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"4fe2e3305bca4c4c4a636ae51ae276f6eed3b3c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"070b7ce4_82eb96b0","updated":"2024-01-03 07:51:28.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"d292ab2d383a3eb32f9a648a3b03b6990e173749"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"28ef2084bc249289ff4fa28100297c0a99742e69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3787f8b7_94da3712","updated":"2024-01-03 07:04:41.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"d292ab2d383a3eb32f9a648a3b03b6990e173749"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"d411cc20b2da7590591896f5984057ea2250ba86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"386eaf98_e2935a3f","updated":"2024-01-03 06:59:54.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"d292ab2d383a3eb32f9a648a3b03b6990e173749"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"3a017df577ee53ca649d2265e853099020325b00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ab805257_8148f82e","updated":"2024-01-03 07:01:05.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"d292ab2d383a3eb32f9a648a3b03b6990e173749"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"33d51ce130b17957eb24be175aea9c3ef9ecd305","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dd1e4659_9e60cd5b","updated":"2024-01-03 07:22:45.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"d292ab2d383a3eb32f9a648a3b03b6990e173749"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"2ad24a94901c73d0450d4a66f6bc41c56e5ad879","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e762c395_2de8dc28","updated":"2024-01-03 07:06:01.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"d292ab2d383a3eb32f9a648a3b03b6990e173749"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"47798282b5c15bc75609dffa1fbcc9cd0d973596","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f115380e_6420e499","updated":"2024-01-03 07:19:02.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"d292ab2d383a3eb32f9a648a3b03b6990e173749"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"be29cd63dde2a6edbec5475709a672e142e78581","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f17d6996_5abe27cf","updated":"2024-01-16 06:30:48.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican","commit_id":"ca9bca299815b2b5f93d7d022e4c45fdd158e486"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"6eb966b68617f1bb0bc7e50df0686fd3a15f2fe1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7c3b6b19_0858aed5","updated":"2024-01-16 09:23:56.000000000","message":"recheck openstacksdk-functional-devstack","commit_id":"ca9bca299815b2b5f93d7d022e4c45fdd158e486"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"8a7b706a1048750a5b56ba4048ecd803bea11568","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"655b57d4_e5238b68","updated":"2024-01-16 12:09:48.000000000","message":"recheck tempest-slow-py3","commit_id":"ca9bca299815b2b5f93d7d022e4c45fdd158e486"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"6905ecc2f950aa8d86ad8283a50b9448d5e522da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ada2f133_ce90f3eb","updated":"2024-01-26 09:09:57.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"5c7407fe2f7eb2ffedff320247fdc420ad4b2979"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"970a01a1aa4abc080650a73a728126a2dce6208f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a34ddfaf_b5482365","updated":"2024-02-08 10:11:26.000000000","message":"recheck build-openstack-releasenotes","commit_id":"097133072f5588f056760dbeb02d8ba4b287103c"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"c29f174363b4aba80925cd8849e3f2018bc5b7ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b271ce9b_48c95d58","updated":"2024-02-14 10:21:33.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican","commit_id":"097133072f5588f056760dbeb02d8ba4b287103c"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"78301442ba133c1ac4af4fd17d1ff1084c636ed3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1a1baa4e_d5d31701","updated":"2024-04-18 21:42:05.000000000","message":"Could someone please explain why the import of md5 has an explicit fallback?","commit_id":"a4228c01e5bdebac1603ce468a10162c9ffde60b"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"d3c668f258fb89671f4212a675c63611e47c59f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7c80c4b7_632f9278","updated":"2024-02-16 12:17:46.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"a4228c01e5bdebac1603ce468a10162c9ffde60b"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"352f55862a696fe2ed43c60f69b9759eb03d0764","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d651a9d3_968cdc25","updated":"2024-02-16 03:10:08.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"a4228c01e5bdebac1603ce468a10162c9ffde60b"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"314d92609d3839f51ef5c8602724c7ecf3b2a80d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"21565bdd_d3a82033","updated":"2024-04-29 03:01:41.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"81da20274485bf3b82d64be03b45317c171d338c"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"946584a46a4e621daac8b7a78181149d1b51cfb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"68470e00_44cad32a","updated":"2024-04-29 07:21:12.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"81da20274485bf3b82d64be03b45317c171d338c"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"34b52a61d6c7509bfbb2ea471538eb32de0a43b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b545fccb_7b987216","updated":"2024-04-30 07:14:34.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"81da20274485bf3b82d64be03b45317c171d338c"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"685b924d9ac40b79fc49ddd066251cad3650c1f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"20d45abf_c3148a17","updated":"2024-08-01 01:11:32.000000000","message":"This patch has been merged. Thank you everyone.","commit_id":"eb9a3d9c1e237107fd1fd39e584a89ce22d4a7d9"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"9103158038ec078a3fbab38cac3ef87a612942ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6bfadc2c_22adb380","updated":"2024-06-14 09:34:18.000000000","message":"recheck openstack-tox-py311","commit_id":"eb9a3d9c1e237107fd1fd39e584a89ce22d4a7d9"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"0f4ba86fba63fb52ce615ee3533105f3c7c40ef7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3222fe5b_7b0896a0","updated":"2024-06-17 01:17:47.000000000","message":"recheck tempest-slow-py3","commit_id":"eb9a3d9c1e237107fd1fd39e584a89ce22d4a7d9"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"df4f05fbbeeee5512e9f9e602d6c051057f63909","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3c29752c_b29b7dd7","updated":"2024-06-17 07:49:34.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"eb9a3d9c1e237107fd1fd39e584a89ce22d4a7d9"}],"cinder/tests/unit/volume/drivers/test_fujitsu_dx.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"d098555a7905b2698f698f715da059acc19abafc","unresolved":true,"context_lines":[{"line_number":1115,"context_line":""},{"line_number":1116,"context_line":"    def volume_update(self, volume, diction):"},{"line_number":1117,"context_line":"        for key, value in diction.items():"},{"line_number":1118,"context_line":"            volume[key] \u003d value"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"    def test_get_volume_stats(self):"},{"line_number":1121,"context_line":"        ret \u003d self.driver.get_volume_stats(True)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3117338e_7ce9f07c","line":1118,"updated":"2024-07-26 20:02:29.000000000","message":"Just an aside, I think volume.update(diction) would do this in one line. In all other classes below too. I don\u0027t think it warrants -1, but maybe something to include if you update this patch.","commit_id":"eb9a3d9c1e237107fd1fd39e584a89ce22d4a7d9"}],"cinder/volume/drivers/fujitsu/eternus_dx/eternus_dx_common.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"58e374c0fbfb4dea7a5cd46450e91776c9d3543c","unresolved":true,"context_lines":[{"line_number":44,"context_line":"CONF \u003d cfg.CONF"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"try:"},{"line_number":47,"context_line":"    from oslo_utils.secretutils import md5"},{"line_number":48,"context_line":"    use_md5 \u003d True"},{"line_number":49,"context_line":"except ImportError:"},{"line_number":50,"context_line":"    import hashlib"}],"source_content_type":"text/x-python","patch_set":1,"id":"14ef2861_f34a0a06","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":42},"updated":"2023-12-08 13:59:45.000000000","message":"are we planning to remove the support for this import?","commit_id":"415c9629d71f9494bf91ebb4c9da41128c326b60"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"0c4df025df16d105c27d3dca1f3fbf8f75c6d5cf","unresolved":false,"context_lines":[{"line_number":44,"context_line":"CONF \u003d cfg.CONF"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"try:"},{"line_number":47,"context_line":"    from oslo_utils.secretutils import md5"},{"line_number":48,"context_line":"    use_md5 \u003d True"},{"line_number":49,"context_line":"except ImportError:"},{"line_number":50,"context_line":"    import hashlib"}],"source_content_type":"text/x-python","patch_set":1,"id":"46e116da_7eaf6bc2","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":42},"in_reply_to":"14ef2861_f34a0a06","updated":"2024-01-03 09:23:20.000000000","message":"We want to backport this patch to OSP16, but hashlib is not supported in OSP16.\nSo we added this package. We\u0027ll remove the support for this import in future patches.","commit_id":"415c9629d71f9494bf91ebb4c9da41128c326b60"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"58e374c0fbfb4dea7a5cd46450e91776c9d3543c","unresolved":true,"context_lines":[{"line_number":1661,"context_line":"                if vol_instance and vol_instance[\u0027ElementName\u0027] \u003d\u003d volumename:"},{"line_number":1662,"context_line":"                    volumeinstance \u003d vol_instance"},{"line_number":1663,"context_line":"        except Exception:"},{"line_number":1664,"context_line":"            issuccess \u003d False"},{"line_number":1665,"context_line":"            LOG.debug(\u0027_find_lun, \u0027"},{"line_number":1666,"context_line":"                      \u0027Cannot get volume instance from provider location, \u0027"},{"line_number":1667,"context_line":"                      \u0027Search all volume using EnumerateInstanceNames.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"acd1c84c_533f6eb2","line":1664,"range":{"start_line":1664,"start_character":12,"end_line":1664,"end_character":21},"updated":"2023-12-08 13:59:45.000000000","message":"nit: maybe use pascal case, isSuccess?","commit_id":"415c9629d71f9494bf91ebb4c9da41128c326b60"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"0c4df025df16d105c27d3dca1f3fbf8f75c6d5cf","unresolved":false,"context_lines":[{"line_number":1661,"context_line":"                if vol_instance and vol_instance[\u0027ElementName\u0027] \u003d\u003d volumename:"},{"line_number":1662,"context_line":"                    volumeinstance \u003d vol_instance"},{"line_number":1663,"context_line":"        except Exception:"},{"line_number":1664,"context_line":"            issuccess \u003d False"},{"line_number":1665,"context_line":"            LOG.debug(\u0027_find_lun, \u0027"},{"line_number":1666,"context_line":"                      \u0027Cannot get volume instance from provider location, \u0027"},{"line_number":1667,"context_line":"                      \u0027Search all volume using EnumerateInstanceNames.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4aeada4f_f900ec98","line":1664,"range":{"start_line":1664,"start_character":12,"end_line":1664,"end_character":21},"in_reply_to":"acd1c84c_533f6eb2","updated":"2024-01-03 09:23:20.000000000","message":"Done","commit_id":"415c9629d71f9494bf91ebb4c9da41128c326b60"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"af96e54a4e730e372e473488b79fbe827d3cf8fd","unresolved":true,"context_lines":[{"line_number":43,"context_line":"CONF \u003d cfg.CONF"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"try:"},{"line_number":46,"context_line":"    from oslo_utils.secretutils import md5"},{"line_number":47,"context_line":"    use_md5 \u003d True"},{"line_number":48,"context_line":"except ImportError:"},{"line_number":49,"context_line":"    import hashlib"}],"source_content_type":"text/x-python","patch_set":6,"id":"415939a4_e8e38187","line":46,"range":{"start_line":46,"start_character":4,"end_line":46,"end_character":42},"updated":"2024-04-19 16:06:05.000000000","message":"This will never fail because we require a new enough oslo.utils for it to always be present.  Should just import it normally w/o this check.","commit_id":"a4228c01e5bdebac1603ce468a10162c9ffde60b"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"04dabcb26e5245e3e1bcd474989c9b94acfc79bb","unresolved":false,"context_lines":[{"line_number":43,"context_line":"CONF \u003d cfg.CONF"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"try:"},{"line_number":46,"context_line":"    from oslo_utils.secretutils import md5"},{"line_number":47,"context_line":"    use_md5 \u003d True"},{"line_number":48,"context_line":"except ImportError:"},{"line_number":49,"context_line":"    import hashlib"}],"source_content_type":"text/x-python","patch_set":6,"id":"f2058790_0f86286d","line":46,"range":{"start_line":46,"start_character":4,"end_line":46,"end_character":42},"in_reply_to":"415939a4_e8e38187","updated":"2024-04-25 06:32:37.000000000","message":"We wanted to backport it to train release, now we know that the explicit fallback is unneccassary.\nI\u0027ve removed it.","commit_id":"a4228c01e5bdebac1603ce468a10162c9ffde60b"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"78301442ba133c1ac4af4fd17d1ff1084c636ed3","unresolved":true,"context_lines":[{"line_number":47,"context_line":"    use_md5 \u003d True"},{"line_number":48,"context_line":"except ImportError:"},{"line_number":49,"context_line":"    import hashlib"},{"line_number":50,"context_line":"    use_md5 \u003d False"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"try:"},{"line_number":53,"context_line":"    import pywbem"}],"source_content_type":"text/x-python","patch_set":6,"id":"5906f333_398aa7ae","line":50,"updated":"2024-04-18 21:42:05.000000000","message":"I do not understand what this fallback is for. Is there an environment where oslo_utils does not have secretutils or md5? Every other place in Cinder imports secretutils.md5. What is special about Eternus driver?","commit_id":"a4228c01e5bdebac1603ce468a10162c9ffde60b"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"04dabcb26e5245e3e1bcd474989c9b94acfc79bb","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    use_md5 \u003d True"},{"line_number":48,"context_line":"except ImportError:"},{"line_number":49,"context_line":"    import hashlib"},{"line_number":50,"context_line":"    use_md5 \u003d False"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"try:"},{"line_number":53,"context_line":"    import pywbem"}],"source_content_type":"text/x-python","patch_set":6,"id":"8e7eb1c7_f0e05d95","line":50,"in_reply_to":"5906f333_398aa7ae","updated":"2024-04-25 06:32:37.000000000","message":"We wanted to backport it to train release, now we know that the explicit fallback is unneccassary.\nI\u0027ve removed it.","commit_id":"a4228c01e5bdebac1603ce468a10162c9ffde60b"}]}