)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a6abb308e10156b4df2b28bff8e5e484bbd148b1","unresolved":true,"context_lines":[{"line_number":10,"context_line":"target, meaning they can be attached directly as a"},{"line_number":11,"context_line":"local block device by an instance running on the same node."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"TODO: This currently fails extend volume operations/tests -- need"},{"line_number":14,"context_line":"to work more on that area."},{"line_number":15,"context_line":"TODO: unit tests"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"acaef3de_ed9ba2be","line":13,"updated":"2023-11-15 09:45:55.000000000","message":"It should be raising NotImplemented https://github.com/openstack/os-brick/blob/b72f575e26c5fb55c1511e02108c5c521303aa78/os_brick/initiator/connectors/local.py#L81","commit_id":"3b7ea6281bbb738b0bb3ea0753e08c4b37639831"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"04bff8c42ceb9e80edb1b1ac36e17ba61d4c0ac6","unresolved":true,"context_lines":[{"line_number":10,"context_line":"target, meaning they can be attached directly as a"},{"line_number":11,"context_line":"local block device by an instance running on the same node."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"TODO: This currently fails extend volume operations/tests -- need"},{"line_number":14,"context_line":"to work more on that area."},{"line_number":15,"context_line":"TODO: unit tests"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"07c0dc36_ce2fb8db","line":13,"in_reply_to":"6c67878a_25c40409","updated":"2023-11-16 09:42:51.000000000","message":"Sorry, wrong wording on my part. I didn\u0027t mean that that\u0027s what needs to happen, I meant it\u0027s the error it should be giving right now.\nI agree, this should be changed to support the local attachment.","commit_id":"3b7ea6281bbb738b0bb3ea0753e08c4b37639831"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"1945b850ecb759677d2f051eb6176b60c4fe1255","unresolved":true,"context_lines":[{"line_number":10,"context_line":"target, meaning they can be attached directly as a"},{"line_number":11,"context_line":"local block device by an instance running on the same node."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"TODO: This currently fails extend volume operations/tests -- need"},{"line_number":14,"context_line":"to work more on that area."},{"line_number":15,"context_line":"TODO: unit tests"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6c67878a_25c40409","line":13,"in_reply_to":"acaef3de_ed9ba2be","updated":"2023-11-15 14:16:47.000000000","message":"It is, but why is that the right behavior?  Presumably we can support extend operations for this mode.","commit_id":"3b7ea6281bbb738b0bb3ea0753e08c4b37639831"}],"cinder/volume/drivers/lvm.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a6abb308e10156b4df2b28bff8e5e484bbd148b1","unresolved":true,"context_lines":[{"line_number":859,"context_line":""},{"line_number":860,"context_line":"        self.vg.activate_lv(volume[\u0027name\u0027])"},{"line_number":861,"context_line":""},{"line_number":862,"context_line":"        if self.configuration.lvm_local is True:"},{"line_number":863,"context_line":"            return {\u0027provider_location\u0027: volume_path,"},{"line_number":864,"context_line":"                    \u0027protocol\u0027: \u0027local\u0027}"},{"line_number":865,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"29084e69_7198d3dd","line":862,"updated":"2023-11-15 09:45:55.000000000","message":"To be honest I was hoping we would make it a bit smarter in the sense that it would do local when the requests come from this same host and do iSCSI/NVMe-oF if it came from another host.\n\nThat way we would not be losing the possibility of migrations (live or otherwise), backups, etc.\n\nI think choosing one of the approach depends on how we want the feature to work:\n- Only support local attachments: Your implementation\n- Do local attachments whenever possible but support remote: What I had in mind","commit_id":"3b7ea6281bbb738b0bb3ea0753e08c4b37639831"}]}