)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"23b69e9877d1e18e4bd68561217c05b9d872b986","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d06e7afc_d142dcd4","updated":"2023-12-08 15:55:52.000000000","message":"I like the release note on this one, very nice.\n\nPlease refer at inline comment about the -1","commit_id":"37f74b8bd6ac881d7fed39a90f083a39fce293a1"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"259a71543f3f0d74a62ee8f40e35905785d63513","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eeb5ac84_b5e5d9b3","updated":"2023-12-08 15:43:56.000000000","message":"Signficant number of merge conflicts, please if you can, submit these\npatches as a stack or sequence so that merge conflicts are resolved in\nyour local repository prior to submission.","commit_id":"37f74b8bd6ac881d7fed39a90f083a39fce293a1"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"33e596cff96fb231265ded2ac38aa4296a707c8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b93aa3c3_599b31c9","updated":"2023-11-20 02:12:32.000000000","message":"recheck grenade-skip-level","commit_id":"37f74b8bd6ac881d7fed39a90f083a39fce293a1"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"618b46557e3d4f68a0f316f4682a043ce916e265","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"86edd54a_6239c7f1","updated":"2023-11-20 11:57:48.000000000","message":"recheck tempest-integrated-storage","commit_id":"37f74b8bd6ac881d7fed39a90f083a39fce293a1"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"2d793c265cc368637985a9834e18c17b9c0284a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"15d8976d_448f4b4a","updated":"2023-11-20 02:41:36.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"37f74b8bd6ac881d7fed39a90f083a39fce293a1"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"1b9d6af590b5285cbc9e384832d96cb7ee0e16d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"173b68fe_ba4adba3","updated":"2023-11-21 08:26:59.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"37f74b8bd6ac881d7fed39a90f083a39fce293a1"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"f66d9aab04fa8af2f47238c72a90f24514658251","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"219c9f33_a9bf28dd","updated":"2023-11-20 02:10:09.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"37f74b8bd6ac881d7fed39a90f083a39fce293a1"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"19bea2f30bf6c76d7879e647dc3ccf0827e48345","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2550d5a0_aca57c1a","updated":"2023-11-21 05:41:10.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"37f74b8bd6ac881d7fed39a90f083a39fce293a1"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"2aded19e40965c8191ece44aa06438b58961b138","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4b8219f7_5caf1287","updated":"2023-11-21 01:09:43.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"37f74b8bd6ac881d7fed39a90f083a39fce293a1"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"2a52f4797d993d978e15a7158f29f019e6e8a313","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6590832f_08cd3c08","updated":"2023-11-17 05:08:45.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"37f74b8bd6ac881d7fed39a90f083a39fce293a1"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"42a3ef056d59c0768b347f6469fc2177bb992d46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"be7493ae_5d005b10","updated":"2023-11-20 12:00:18.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"37f74b8bd6ac881d7fed39a90f083a39fce293a1"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"0c9eaea74a99f81e69200d91c8c273c028ad4a87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c767369d_de9bb820","updated":"2023-11-20 11:57:57.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"37f74b8bd6ac881d7fed39a90f083a39fce293a1"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"2bcccc3e5f3357d18f11803dd031b74a64f5ce3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cc9643e7_89d77da8","updated":"2023-11-20 02:44:32.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"37f74b8bd6ac881d7fed39a90f083a39fce293a1"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"72d1d2ac8c83d65aebaba3fec24cf9a56f90c32a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d52fcbdb_43fa1d50","updated":"2023-11-20 19:44:47.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"37f74b8bd6ac881d7fed39a90f083a39fce293a1"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"69d01cd13b5f291719202a6170eec061e7d74cad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ee377925_bd6ddba7","updated":"2023-11-21 05:42:21.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"37f74b8bd6ac881d7fed39a90f083a39fce293a1"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"47fe164d1050787cca552ed9f24fca0c8a3029c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f7e19a60_edb73802","updated":"2023-11-20 06:20:28.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"37f74b8bd6ac881d7fed39a90f083a39fce293a1"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"fd427575e711fb0f7fb957124ebda31abeed7c93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e9823234_cb01010d","in_reply_to":"eeb5ac84_b5e5d9b3","updated":"2024-01-02 03:41:07.000000000","message":"I rebased this patch, could you please review this patch again?","commit_id":"37f74b8bd6ac881d7fed39a90f083a39fce293a1"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"6658c244bf4506aacac12d6b24b860c0977500be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"436f7835_2988c2ce","updated":"2024-01-02 05:52:31.000000000","message":"recheck openstack-tox-py38","commit_id":"ee86f8b2f2d1ee286074d12a485656d020f14495"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"61d972ff8138bcac28c0e0b9442550442afd9d50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0f99a2f5_626cbd39","updated":"2024-01-02 07:42:54.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"ee86f8b2f2d1ee286074d12a485656d020f14495"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"fd427575e711fb0f7fb957124ebda31abeed7c93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1983a73f_dccb9eb2","updated":"2024-01-02 03:41:07.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"ee86f8b2f2d1ee286074d12a485656d020f14495"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"3f6bbd155cd7b723a777c3a007f1d74052a3638f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"59b72146_efa5020c","updated":"2024-01-04 01:27:11.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"ee86f8b2f2d1ee286074d12a485656d020f14495"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"1ea718bca8f866eb1642e9a1a061cdb2ea9ce994","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7c61e55a_b5ad4f9d","updated":"2024-01-02 05:32:02.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"ee86f8b2f2d1ee286074d12a485656d020f14495"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"eec9c9e186752bc84f38bb48986b87adabcaa592","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"89fed551_8484078e","updated":"2024-01-02 09:48:18.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"ee86f8b2f2d1ee286074d12a485656d020f14495"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"bc5a081f667a1974eb02d19ef463a54dbf274414","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b837b0d7_01fb57f3","updated":"2024-01-04 02:06:05.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"ee86f8b2f2d1ee286074d12a485656d020f14495"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"cfb4c6b6cd3bf39affbaa45f2b68d91eb14d8d2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c609ebd2_bcad62b2","updated":"2024-01-02 07:26:22.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"ee86f8b2f2d1ee286074d12a485656d020f14495"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"f1f483b09a5cd1cf7b62c3ed224ec019336074f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3b859318_576b4694","updated":"2024-01-16 05:21:27.000000000","message":"recheck cinder-plugin-ceph-tempest","commit_id":"de0751376d0b00c2762db88ebd1c04b0877613c5"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"dec5c00b609e3025bc0bd5b905093062ba84e0a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"35401feb_e00de27f","updated":"2024-01-26 06:27:40.000000000","message":"recheck cinder-plugin-ceph-tempest","commit_id":"356cdf7859145c6e59a7026941bc96de44c0d253"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"9d0ab7a2b208cdc3224a69f3b9633d1fd8744d87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b4b5dee9_9cb18a27","updated":"2024-01-26 04:11:01.000000000","message":"recheck openstacksdk-functional-devstack","commit_id":"356cdf7859145c6e59a7026941bc96de44c0d253"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"c1ce6e289b50fcfdce3cdef4db9910395ce7400f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"20103418_12a821d2","updated":"2024-02-05 03:08:30.000000000","message":"recheck cinder-plugin-ceph-tempest","commit_id":"3c4970d4571d76c6b4424ce72adf39c507be5965"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"576abbad7d2164082c3c1153204b1e38d01f6798","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"20c8dbec_a04a0f71","updated":"2024-02-08 10:10:05.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"3c4970d4571d76c6b4424ce72adf39c507be5965"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"0a17e5a508db063a3a0f47e821ec02bc52ef27db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"99149ff6_9675b22f","updated":"2024-02-09 07:13:23.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"3c4970d4571d76c6b4424ce72adf39c507be5965"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"007ab9077a2e4a0115142856533d04fff6cc9444","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4cae3e7d_403acdb7","updated":"2024-04-18 19:44:16.000000000","message":"Looks fine, mostly.\n\nThe amount of redundant debug output is concerning.","commit_id":"bca3dd6cdd3a4c64db3d1de3d92d734e30c6cc0e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b11c1443516cea6424b7515d0f9fd9c3b03a5a3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"417c69c8_fcbbffb1","updated":"2024-04-19 15:51:36.000000000","message":"not sure how much benefit the new method provides other than logging the details since we already update the _name_id and provider_location from new volume\u0027s data if the driver doesn\u0027t do it[1]. but anyways LGTM.\n\nFujitsu iSCSI and FC CI are passing.\n\n[1] https://opendev.org/openstack/cinder/src/branch/master/cinder/volume/manager.py#L4394-L4406","commit_id":"bca3dd6cdd3a4c64db3d1de3d92d734e30c6cc0e"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"e33f84caa83eb92110b5d9bde685bc4a79c494a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6a30321e_247213eb","updated":"2024-02-15 13:02:31.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican","commit_id":"bca3dd6cdd3a4c64db3d1de3d92d734e30c6cc0e"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"62cf2c81a92a64dee726351a549e2cc354de7687","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"249e3f97_82671ccc","updated":"2024-02-17 02:03:50.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"bca3dd6cdd3a4c64db3d1de3d92d734e30c6cc0e"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"fbd533233c619d2b6d7b1fc9a5a0edcc9a5a9d28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4e5f7b4c_52f2ac90","updated":"2024-02-16 12:17:11.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"bca3dd6cdd3a4c64db3d1de3d92d734e30c6cc0e"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"74e61de21082fc5c4a89af4137f5af6d9d7510b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f5460374_94d948fe","updated":"2024-02-16 03:09:40.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"bca3dd6cdd3a4c64db3d1de3d92d734e30c6cc0e"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"bc777377794e9dac6550553913409edaf61f0854","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fadc20b7_f522d169","updated":"2024-02-16 06:51:12.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"bca3dd6cdd3a4c64db3d1de3d92d734e30c6cc0e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8479d48e9e12b30a392cddd480e82b4674b07c16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"37f6ea78_0e88d3a3","updated":"2024-05-22 13:58:15.000000000","message":"Ran out of time, still need to look at the code \u0026 tests.  Left some comments about the docs in the meantime.","commit_id":"53b792b369b2b2246f9c120e860cca8081c41c89"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"09a3fbeca670e3e4868b07580dbfc02efb65c155","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f2ff4a38_b0670c2a","updated":"2024-04-25 05:52:11.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"53b792b369b2b2246f9c120e860cca8081c41c89"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"f900b691a700ef514de6294e8f0644e7fe6f72ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"150e39f4_df43f410","updated":"2024-06-28 07:11:22.000000000","message":"Code changes look good;\nFujitsu ETERNUS CI passed on latest patchset (PS_8).","commit_id":"82d9b3f6697cda2fb2c06ac82972ced3f980b30a"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"9c13d8e488db8757ccfd8ac2119caaffc797201a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c1e974c2_e9f863ac","updated":"2024-07-31 03:47:55.000000000","message":"This had a +W from Rajat that was removed after a rebase - which seems to have only changed documentation.  Looks good to me.","commit_id":"82d9b3f6697cda2fb2c06ac82972ced3f980b30a"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"b5a88f4e491ad3addfea12f28a6713d8985bb18a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"74759e4a_40ddce20","updated":"2024-08-01 01:11:18.000000000","message":"This patch has been merged. Thank you everyone.","commit_id":"82d9b3f6697cda2fb2c06ac82972ced3f980b30a"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"714663f0d4cdc656f0d732b412d181d99a7cf520","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"34b6581f_7ea62b85","updated":"2024-06-26 18:27:25.000000000","message":"This was previously +A by Rajat and the changes since Patchset 6 constitute the requested improvements to comments and release notes. I think it\u0027s okay to approve, but let\u0027s have just 1 more +2.","commit_id":"82d9b3f6697cda2fb2c06ac82972ced3f980b30a"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"cea01360b63104158eae16a85ff209db37fa0f28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"56956ef5_f7d4a42a","updated":"2024-06-14 05:25:27.000000000","message":"recheck openstacksdk-functional-devstack","commit_id":"82d9b3f6697cda2fb2c06ac82972ced3f980b30a"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"8f5531e5237a4b80bf4040fdc2ea6c497162a1f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2b433fd2_41eb19eb","updated":"2024-06-14 08:29:27.000000000","message":"recheck tempest-integrated-storage","commit_id":"82d9b3f6697cda2fb2c06ac82972ced3f980b30a"}],"cinder/volume/drivers/fujitsu/eternus_dx/eternus_dx_common.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"23b69e9877d1e18e4bd68561217c05b9d872b986","unresolved":true,"context_lines":[{"line_number":2520,"context_line":""},{"line_number":2521,"context_line":"            db.volume_update("},{"line_number":2522,"context_line":"                ctxt, new_volume[\u0027id\u0027],"},{"line_number":2523,"context_line":"                {\u0027provider_location\u0027: str(src_location)})"},{"line_number":2524,"context_line":""},{"line_number":2525,"context_line":"    def _get_eternus_model(self):"},{"line_number":2526,"context_line":"        \"\"\"Get ENTERNUS model.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7e4a08cc_60cfeb6f","line":2523,"updated":"2023-12-08 15:55:52.000000000","message":"Please don\u0027t do direct DB updates in a driver. Refer to the way HPE/3PAR do it:\n cinder/volume/drivers/hpe/hpe_3par_common.py:update_migrated_volume\n\nThey return a dictionary, which Cinder core applies to the DB.","commit_id":"37f74b8bd6ac881d7fed39a90f083a39fce293a1"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"fd427575e711fb0f7fb957124ebda31abeed7c93","unresolved":false,"context_lines":[{"line_number":2520,"context_line":""},{"line_number":2521,"context_line":"            db.volume_update("},{"line_number":2522,"context_line":"                ctxt, new_volume[\u0027id\u0027],"},{"line_number":2523,"context_line":"                {\u0027provider_location\u0027: str(src_location)})"},{"line_number":2524,"context_line":""},{"line_number":2525,"context_line":"    def _get_eternus_model(self):"},{"line_number":2526,"context_line":"        \"\"\"Get ENTERNUS model.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"629261b9_b0ff5ee4","line":2523,"in_reply_to":"7e4a08cc_60cfeb6f","updated":"2024-01-02 03:41:07.000000000","message":"Thanks for your review. I rewrote the function \u0027update_migrated_volume\u0027, and now the DB is not updated in our driver.","commit_id":"37f74b8bd6ac881d7fed39a90f083a39fce293a1"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"a803b479bdf262360c26e1b9fd5c01f22f3b5161","unresolved":true,"context_lines":[{"line_number":2596,"context_line":"                  {\u0027poolname\u0027: poolname, \u0027target_pool\u0027: target_pool})"},{"line_number":2597,"context_line":"        return poolname, target_pool"},{"line_number":2598,"context_line":""},{"line_number":2599,"context_line":"    def update_migrated_volume(self, ctxt, volume, new_volume):"},{"line_number":2600,"context_line":"        \"\"\"Update migrated volume.\"\"\""},{"line_number":2601,"context_line":"        LOG.debug(\u0027update_migrated_volume, \u0027"},{"line_number":2602,"context_line":"                  \u0027source volume id: %(s_id)s, \u0027"},{"line_number":2603,"context_line":"                  \u0027target volume id: %(t_id)s.\u0027,"},{"line_number":2604,"context_line":"                  {\u0027s_id\u0027: volume[\u0027id\u0027], \u0027t_id\u0027: new_volume[\u0027id\u0027]})"},{"line_number":2605,"context_line":""},{"line_number":2606,"context_line":"        model_update \u003d None"},{"line_number":2607,"context_line":""},{"line_number":2608,"context_line":"        dst_metadata \u003d self.get_metadata(new_volume)"},{"line_number":2609,"context_line":"        src_metadata \u003d self.get_metadata(volume)"},{"line_number":2610,"context_line":""},{"line_number":2611,"context_line":"        LOG.debug(\u0027source: (%(src_meta)s)(%(src_loc)s), \u0027"},{"line_number":2612,"context_line":"                  \u0027target: (%(dst_meta)s)(%(dst_loc)s).\u0027,"},{"line_number":2613,"context_line":"                  {\u0027src_meta\u0027: src_metadata,"},{"line_number":2614,"context_line":"                   \u0027src_loc\u0027: volume[\u0027provider_location\u0027],"},{"line_number":2615,"context_line":"                   \u0027dst_meta\u0027: dst_metadata,"},{"line_number":2616,"context_line":"                   \u0027dst_loc\u0027: new_volume[\u0027provider_location\u0027]})"},{"line_number":2617,"context_line":""},{"line_number":2618,"context_line":"        if volume[\u0027provider_location\u0027]:"},{"line_number":2619,"context_line":"            dst_location \u003d new_volume[\u0027provider_location\u0027]"},{"line_number":2620,"context_line":"            model_update \u003d {\u0027_name_id\u0027: new_volume[\u0027id\u0027],"},{"line_number":2621,"context_line":"                            \u0027provider_location\u0027: dst_location}"},{"line_number":2622,"context_line":""},{"line_number":2623,"context_line":"        LOG.debug(\u0027update_migrated_volume, model_update: %s.\u0027,"},{"line_number":2624,"context_line":"                  model_update)"},{"line_number":2625,"context_line":"        return model_update"},{"line_number":2626,"context_line":""},{"line_number":2627,"context_line":"    def _get_eternus_model(self):"},{"line_number":2628,"context_line":"        \"\"\"Get ENTERNUS model.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"c5fe81cf_d91e0af4","line":2625,"range":{"start_line":2599,"start_character":4,"end_line":2625,"end_character":27},"updated":"2024-07-12 02:45:00.000000000","message":"Cinder volume manager updates new volume\u0027s \u0027provider_location\u0027 before it invokes driver\u0027s \u0027update_migrated_volume\u0027.\nIs this code change necessary?\n\n[1] https://opendev.org/openstack/cinder/src/branch/master/cinder/volume/manager.py#L4385-L4396","commit_id":"82d9b3f6697cda2fb2c06ac82972ced3f980b30a"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"29ba19f92baae586fe44384b6b0a053f99b3fa6d","unresolved":false,"context_lines":[{"line_number":2596,"context_line":"                  {\u0027poolname\u0027: poolname, \u0027target_pool\u0027: target_pool})"},{"line_number":2597,"context_line":"        return poolname, target_pool"},{"line_number":2598,"context_line":""},{"line_number":2599,"context_line":"    def update_migrated_volume(self, ctxt, volume, new_volume):"},{"line_number":2600,"context_line":"        \"\"\"Update migrated volume.\"\"\""},{"line_number":2601,"context_line":"        LOG.debug(\u0027update_migrated_volume, \u0027"},{"line_number":2602,"context_line":"                  \u0027source volume id: %(s_id)s, \u0027"},{"line_number":2603,"context_line":"                  \u0027target volume id: %(t_id)s.\u0027,"},{"line_number":2604,"context_line":"                  {\u0027s_id\u0027: volume[\u0027id\u0027], \u0027t_id\u0027: new_volume[\u0027id\u0027]})"},{"line_number":2605,"context_line":""},{"line_number":2606,"context_line":"        model_update \u003d None"},{"line_number":2607,"context_line":""},{"line_number":2608,"context_line":"        dst_metadata \u003d self.get_metadata(new_volume)"},{"line_number":2609,"context_line":"        src_metadata \u003d self.get_metadata(volume)"},{"line_number":2610,"context_line":""},{"line_number":2611,"context_line":"        LOG.debug(\u0027source: (%(src_meta)s)(%(src_loc)s), \u0027"},{"line_number":2612,"context_line":"                  \u0027target: (%(dst_meta)s)(%(dst_loc)s).\u0027,"},{"line_number":2613,"context_line":"                  {\u0027src_meta\u0027: src_metadata,"},{"line_number":2614,"context_line":"                   \u0027src_loc\u0027: volume[\u0027provider_location\u0027],"},{"line_number":2615,"context_line":"                   \u0027dst_meta\u0027: dst_metadata,"},{"line_number":2616,"context_line":"                   \u0027dst_loc\u0027: new_volume[\u0027provider_location\u0027]})"},{"line_number":2617,"context_line":""},{"line_number":2618,"context_line":"        if volume[\u0027provider_location\u0027]:"},{"line_number":2619,"context_line":"            dst_location \u003d new_volume[\u0027provider_location\u0027]"},{"line_number":2620,"context_line":"            model_update \u003d {\u0027_name_id\u0027: new_volume[\u0027id\u0027],"},{"line_number":2621,"context_line":"                            \u0027provider_location\u0027: dst_location}"},{"line_number":2622,"context_line":""},{"line_number":2623,"context_line":"        LOG.debug(\u0027update_migrated_volume, model_update: %s.\u0027,"},{"line_number":2624,"context_line":"                  model_update)"},{"line_number":2625,"context_line":"        return model_update"},{"line_number":2626,"context_line":""},{"line_number":2627,"context_line":"    def _get_eternus_model(self):"},{"line_number":2628,"context_line":"        \"\"\"Get ENTERNUS model.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"e89db179_76676e63","line":2625,"range":{"start_line":2599,"start_character":4,"end_line":2625,"end_character":27},"in_reply_to":"c5fe81cf_d91e0af4","updated":"2024-07-17 08:44:27.000000000","message":"Thanks for your comment. I understand that cinder will update the _name_id and provider_location from new volume\u0027s data if our driver doesn\u0027t do it.\nNevertheless, we define the function update_migrated_volume in our driver to provider detailed logs ensure its readability and consistency.\nMore over, I think this design makes future debugging and extensions easier if needed.","commit_id":"82d9b3f6697cda2fb2c06ac82972ced3f980b30a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"21ad150b2a2d5a908f4fb21a586c4266d7cce5ed","unresolved":false,"context_lines":[{"line_number":2596,"context_line":"                  {\u0027poolname\u0027: poolname, \u0027target_pool\u0027: target_pool})"},{"line_number":2597,"context_line":"        return poolname, target_pool"},{"line_number":2598,"context_line":""},{"line_number":2599,"context_line":"    def update_migrated_volume(self, ctxt, volume, new_volume):"},{"line_number":2600,"context_line":"        \"\"\"Update migrated volume.\"\"\""},{"line_number":2601,"context_line":"        LOG.debug(\u0027update_migrated_volume, \u0027"},{"line_number":2602,"context_line":"                  \u0027source volume id: %(s_id)s, \u0027"},{"line_number":2603,"context_line":"                  \u0027target volume id: %(t_id)s.\u0027,"},{"line_number":2604,"context_line":"                  {\u0027s_id\u0027: volume[\u0027id\u0027], \u0027t_id\u0027: new_volume[\u0027id\u0027]})"},{"line_number":2605,"context_line":""},{"line_number":2606,"context_line":"        model_update \u003d None"},{"line_number":2607,"context_line":""},{"line_number":2608,"context_line":"        dst_metadata \u003d self.get_metadata(new_volume)"},{"line_number":2609,"context_line":"        src_metadata \u003d self.get_metadata(volume)"},{"line_number":2610,"context_line":""},{"line_number":2611,"context_line":"        LOG.debug(\u0027source: (%(src_meta)s)(%(src_loc)s), \u0027"},{"line_number":2612,"context_line":"                  \u0027target: (%(dst_meta)s)(%(dst_loc)s).\u0027,"},{"line_number":2613,"context_line":"                  {\u0027src_meta\u0027: src_metadata,"},{"line_number":2614,"context_line":"                   \u0027src_loc\u0027: volume[\u0027provider_location\u0027],"},{"line_number":2615,"context_line":"                   \u0027dst_meta\u0027: dst_metadata,"},{"line_number":2616,"context_line":"                   \u0027dst_loc\u0027: new_volume[\u0027provider_location\u0027]})"},{"line_number":2617,"context_line":""},{"line_number":2618,"context_line":"        if volume[\u0027provider_location\u0027]:"},{"line_number":2619,"context_line":"            dst_location \u003d new_volume[\u0027provider_location\u0027]"},{"line_number":2620,"context_line":"            model_update \u003d {\u0027_name_id\u0027: new_volume[\u0027id\u0027],"},{"line_number":2621,"context_line":"                            \u0027provider_location\u0027: dst_location}"},{"line_number":2622,"context_line":""},{"line_number":2623,"context_line":"        LOG.debug(\u0027update_migrated_volume, model_update: %s.\u0027,"},{"line_number":2624,"context_line":"                  model_update)"},{"line_number":2625,"context_line":"        return model_update"},{"line_number":2626,"context_line":""},{"line_number":2627,"context_line":"    def _get_eternus_model(self):"},{"line_number":2628,"context_line":"        \"\"\"Get ENTERNUS model.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"875ebc8a_2525acfd","line":2625,"range":{"start_line":2599,"start_character":4,"end_line":2625,"end_character":27},"in_reply_to":"e89db179_76676e63","updated":"2024-07-18 02:24:10.000000000","message":"Thank you for clarifying.","commit_id":"82d9b3f6697cda2fb2c06ac82972ced3f980b30a"}],"doc/source/configuration/block-storage/drivers/fujitsu-eternus-dx-driver.rst":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8479d48e9e12b30a392cddd480e82b4674b07c16","unresolved":true,"context_lines":[{"line_number":291,"context_line":"        cinder_eternus_config_file \u003d /etc/cinder/cinder_fujitsu_eternus_dx.xml"},{"line_number":292,"context_line":"        volume_backend_name\u003dvolume_backend_name1"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"**Cautions**"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"There are some restrictions for volume migration:"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"e8b2a523_c13cbdab","line":294,"updated":"2024-05-22 13:58:15.000000000","message":"You could put this in a warning box using\n\n```\n.. warning::\n```\n\nYou can see an example in doc/source/install/cinder-storage-install-ubuntu.rst","commit_id":"53b792b369b2b2246f9c120e860cca8081c41c89"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"3a0b7cc3ece3bded5514373c56c5ed063d39f916","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        cinder_eternus_config_file \u003d /etc/cinder/cinder_fujitsu_eternus_dx.xml"},{"line_number":292,"context_line":"        volume_backend_name\u003dvolume_backend_name1"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"**Cautions**"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"There are some restrictions for volume migration:"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"aed1cecf_e97927c9","line":294,"in_reply_to":"e8b2a523_c13cbdab","updated":"2024-06-14 05:25:51.000000000","message":"I\u0027ve modified it.","commit_id":"53b792b369b2b2246f9c120e860cca8081c41c89"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8479d48e9e12b30a392cddd480e82b4674b07c16","unresolved":true,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"There are some restrictions for volume migration:"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"#. Volume migration with snapshots."},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"#. Volume Migration with drivers other than ETERNUS OpenStack"},{"line_number":301,"context_line":"   VolumeDriver."}],"source_content_type":"text/x-rst","patch_set":7,"id":"25f81c27_e981a99f","line":298,"updated":"2024-05-22 13:58:15.000000000","message":"I suggest being more explicit here.  Maybe say instead:\n\nYou cannot migrate a volume that has snapshots.\n\n(or whatever exactly the restriction is).","commit_id":"53b792b369b2b2246f9c120e860cca8081c41c89"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"3a0b7cc3ece3bded5514373c56c5ed063d39f916","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"There are some restrictions for volume migration:"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"#. Volume migration with snapshots."},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"#. Volume Migration with drivers other than ETERNUS OpenStack"},{"line_number":301,"context_line":"   VolumeDriver."}],"source_content_type":"text/x-rst","patch_set":7,"id":"74245400_6033de05","line":298,"in_reply_to":"25f81c27_e981a99f","updated":"2024-06-14 05:25:51.000000000","message":"Done","commit_id":"53b792b369b2b2246f9c120e860cca8081c41c89"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8479d48e9e12b30a392cddd480e82b4674b07c16","unresolved":true,"context_lines":[{"line_number":298,"context_line":"#. Volume migration with snapshots."},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"#. Volume Migration with drivers other than ETERNUS OpenStack"},{"line_number":301,"context_line":"   VolumeDriver."},{"line_number":302,"context_line":""},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"Supplementary Information for the Supported Functions"}],"source_content_type":"text/x-rst","patch_set":7,"id":"dfd58692_70ad34e7","line":301,"updated":"2024-05-22 13:58:15.000000000","message":"Same thing here, something like \"You cannot use driver-assisted migration to move a volume to or from a backend that does not use the ETERNUS OpenStack volume driver.\"","commit_id":"53b792b369b2b2246f9c120e860cca8081c41c89"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"3a0b7cc3ece3bded5514373c56c5ed063d39f916","unresolved":false,"context_lines":[{"line_number":298,"context_line":"#. Volume migration with snapshots."},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"#. Volume Migration with drivers other than ETERNUS OpenStack"},{"line_number":301,"context_line":"   VolumeDriver."},{"line_number":302,"context_line":""},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"Supplementary Information for the Supported Functions"}],"source_content_type":"text/x-rst","patch_set":7,"id":"62ec0ddb_f8bde8b8","line":301,"in_reply_to":"dfd58692_70ad34e7","updated":"2024-06-14 05:25:51.000000000","message":"Done","commit_id":"53b792b369b2b2246f9c120e860cca8081c41c89"}],"releasenotes/notes/fujitsu-update-migrated-volume-1d205cdbd7e65a28.yaml":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b11c1443516cea6424b7515d0f9fd9c3b03a5a3f","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fujitsu ETERNUS DX driver: Added support for update migrated volume"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    After migrated volume is completed, cinder invokes function"},{"line_number":7,"context_line":"    \u0027update_migrated_volume\u0027."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    It updates provider_location, which possesses the new volume ID, to match"},{"line_number":10,"context_line":"    the provider_location of original volume."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    See the `Fujitsu ETERNUS DX driver documentation"},{"line_number":13,"context_line":"    \u003chttps://docs.openstack.org/cinder/latest/configuration/block-storage/drivers/fujitsu-eternus-dx-driver.html\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"0d408f59_83e3a995","line":10,"range":{"start_line":6,"start_character":4,"end_line":10,"end_character":45},"updated":"2024-04-19 15:51:36.000000000","message":"maybe the method name is not necessary information for the target audience of releasenotes.\n\nMaybe just mention,\n\n    Now we update the required values to successfully complete the migration.","commit_id":"bca3dd6cdd3a4c64db3d1de3d92d734e30c6cc0e"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"9338b1a3600d655a789825cf950998339eafb700","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fujitsu ETERNUS DX driver: Added support for update migrated volume"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    After migrated volume is completed, cinder invokes function"},{"line_number":7,"context_line":"    \u0027update_migrated_volume\u0027."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    It updates provider_location, which possesses the new volume ID, to match"},{"line_number":10,"context_line":"    the provider_location of original volume."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    See the `Fujitsu ETERNUS DX driver documentation"},{"line_number":13,"context_line":"    \u003chttps://docs.openstack.org/cinder/latest/configuration/block-storage/drivers/fujitsu-eternus-dx-driver.html\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"f0ab615a_80110ab4","line":10,"range":{"start_line":6,"start_character":4,"end_line":10,"end_character":45},"in_reply_to":"0d408f59_83e3a995","updated":"2024-04-24 03:34:21.000000000","message":"Thank you rajat. I‘ve update the release note in the latest patchset.","commit_id":"bca3dd6cdd3a4c64db3d1de3d92d734e30c6cc0e"}]}