)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"ea03677aa5e31fa753aebcf0454e2dc5f136c9dc","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerStore Driver - Add a unit test for connection properties for NVMeOF connector"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  This NVMe connection properties support multiple portals. This patch addes the related unit test cases."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ibf79950ca4805f38bf008f35fd45aa7435efd61a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3343d09d_b8f90b52","line":9,"updated":"2023-11-20 08:06:05.000000000","message":"Nit. These/add","commit_id":"ddf5bfb254f2a711472915b3effed3da7909c0ac"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"94247aa13e8c657080abc1a712aecb6ea6822b31","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerStore Driver - Add a unit test for connection properties for NVMeOF connector"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  This NVMe connection properties support multiple portals. This patch addes the related unit test cases."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ibf79950ca4805f38bf008f35fd45aa7435efd61a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"459127d0_d36b1260","line":9,"in_reply_to":"3343d09d_b8f90b52","updated":"2023-11-20 08:59:34.000000000","message":"Correct","commit_id":"ddf5bfb254f2a711472915b3effed3da7909c0ac"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8b3b967a5bc70b9f44b8b6359ae7811eb051905d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     cuiyeliu \u003ccuiye.liu@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-12-08 13:41:30 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerStore Driver - Add a unit test for connection properties for NVMeOF connector"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  This NVMe connection properties support multiple portals. This patch adds the related unit test cases."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"f7c5cb79_31ac113b","line":7,"updated":"2023-12-11 07:11:06.000000000","message":"guideline\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\nThe first line should be limited to 50 characters.\nSubsequent lines should be wrapped at 72 characters.","commit_id":"ea2cc20cb82969ddd462a9d77190e2abbf0ec257"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"96497cba83ccc4de9cc2e054ae0f96ef27e0cd76","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     cuiyeliu \u003ccuiye.liu@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-12-08 13:41:30 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerStore Driver - Add a unit test for connection properties for NVMeOF connector"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  This NVMe connection properties support multiple portals. This patch adds the related unit test cases."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"f559e1b6_df2a0f9a","line":7,"in_reply_to":"5dc72edc_f0212644","updated":"2024-01-16 12:40:23.000000000","message":"In latest patchset (PS6), the commit message still needs to be updated as per guideline.","commit_id":"ea2cc20cb82969ddd462a9d77190e2abbf0ec257"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"214367975972588521ee24978f1bc3afac44b38b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     cuiyeliu \u003ccuiye.liu@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-12-08 13:41:30 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerStore Driver - Add a unit test for connection properties for NVMeOF connector"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  This NVMe connection properties support multiple portals. This patch adds the related unit test cases."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"e8f4b2b7_dd3392ea","line":7,"in_reply_to":"f559e1b6_df2a0f9a","updated":"2024-02-05 09:12:38.000000000","message":"resolved","commit_id":"ea2cc20cb82969ddd462a9d77190e2abbf0ec257"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"fa1d342d04c0dbc0f19decb550b14cb520b923b8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     cuiyeliu \u003ccuiye.liu@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-12-08 13:41:30 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerStore Driver - Add a unit test for connection properties for NVMeOF connector"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  This NVMe connection properties support multiple portals. This patch adds the related unit test cases."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5dc72edc_f0212644","line":7,"in_reply_to":"f7c5cb79_31ac113b","updated":"2024-01-11 08:32:32.000000000","message":"Resolved","commit_id":"ea2cc20cb82969ddd462a9d77190e2abbf0ec257"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"94097b5a8901b12c6576d967e452615186384808","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     cuiyeliu \u003ccuiye.liu@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-02-05 03:28:37 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerStore Driver - Add a unit test for connection properties for NVMeOF connector"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  This NVMe connection properties support multiple portals. This patch adds the related unit test cases."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"2b44e909_9ce67886","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":82},"updated":"2024-02-22 05:54:41.000000000","message":"Line 7: exceed 50 characters","commit_id":"e8507cce0ae78fd905fc75f21aaee5fad28f5df2"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"246d10dc7c59ae5b237245e7a9e0880789248c25","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     cuiyeliu \u003ccuiye.liu@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-02-05 03:28:37 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerStore Driver - Add a unit test for connection properties for NVMeOF connector"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  This NVMe connection properties support multiple portals. This patch adds the related unit test cases."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"d0ca9bd1_7c5839a7","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":82},"in_reply_to":"2b44e909_9ce67886","updated":"2024-02-27 02:55:45.000000000","message":"Acknowledged","commit_id":"e8507cce0ae78fd905fc75f21aaee5fad28f5df2"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"94097b5a8901b12c6576d967e452615186384808","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerStore Driver - Add a unit test for connection properties for NVMeOF connector"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  This NVMe connection properties support multiple portals. This patch adds the related unit test cases."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ibf79950ca4805f38bf008f35fd45aa7435efd61a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1f30f3db_b7d7913c","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":104},"updated":"2024-02-22 05:54:41.000000000","message":"Line 9: exceed 72 characters.\nPlease also remove the indent before this line.","commit_id":"e8507cce0ae78fd905fc75f21aaee5fad28f5df2"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"246d10dc7c59ae5b237245e7a9e0880789248c25","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerStore Driver - Add a unit test for connection properties for NVMeOF connector"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  This NVMe connection properties support multiple portals. This patch adds the related unit test cases."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ibf79950ca4805f38bf008f35fd45aa7435efd61a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1fc512d6_52012a27","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":104},"in_reply_to":"1f30f3db_b7d7913c","updated":"2024-02-27 02:55:45.000000000","message":"Resolved","commit_id":"e8507cce0ae78fd905fc75f21aaee5fad28f5df2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"0308de60fb697978ad4bf772cf51b20907358858","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4bb04ee9_9644e97c","updated":"2023-11-17 10:59:26.000000000","message":"run-DellEMC PowerStore C","commit_id":"ddf5bfb254f2a711472915b3effed3da7909c0ac"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"c6aa1ac041fded303106a5d455212019d910b124","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"db82c04d_0b70a1a1","updated":"2023-11-17 10:59:35.000000000","message":"run-DellEMC PowerStore CI","commit_id":"ddf5bfb254f2a711472915b3effed3da7909c0ac"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8b3b967a5bc70b9f44b8b6359ae7811eb051905d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0a364b3d_dbdc3e58","updated":"2023-12-11 07:11:06.000000000","message":"Minor comment in the commit message","commit_id":"ea2cc20cb82969ddd462a9d77190e2abbf0ec257"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"7b6e0af855ad9781923f372b2202eef41eeed6bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3432233b_eb05d350","updated":"2024-01-11 08:33:20.000000000","message":"Resolved","commit_id":"f3a5ccc999d2974c0d8657f73e3f35d983bfb662"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"96497cba83ccc4de9cc2e054ae0f96ef27e0cd76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0abecbd6_11ede862","updated":"2024-01-16 12:40:23.000000000","message":"Minor comment.","commit_id":"854172444a6517a8d657a2d08d4aead6aa3aa1c9"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"aa92abe174fd568cf20eaea7847eac075ca2fd26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d50ac4c3_6701bb80","updated":"2024-01-16 12:49:28.000000000","message":"please review first line length in the commit message. should be 50 chars max.","commit_id":"854172444a6517a8d657a2d08d4aead6aa3aa1c9"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"2b16bb85da31a102a50f8196ada926af1a084c70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6b2b92ce_273fb083","in_reply_to":"d50ac4c3_6701bb80","updated":"2024-02-08 14:22:42.000000000","message":"resolved","commit_id":"854172444a6517a8d657a2d08d4aead6aa3aa1c9"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"c2de7dcdbc0853b6a4e9a07e602873c7833f8300","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8d5cfa50_224050f2","updated":"2024-02-19 09:25:26.000000000","message":"LGTM now.","commit_id":"e8507cce0ae78fd905fc75f21aaee5fad28f5df2"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"eeca61dce062eba3165e4bb19d2fc6ac7d39c6a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a4a139c3_50c39bfe","updated":"2024-02-22 05:49:18.000000000","message":"My previous comments in lines are addressed. Thanks!\nSome minor comments in the commit message.","commit_id":"e8507cce0ae78fd905fc75f21aaee5fad28f5df2"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"df9246db37d4f822c314b6d5e230ef8211f89b09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e8f8433a_55778cd7","updated":"2024-02-22 05:55:13.000000000","message":"forgot to vote","commit_id":"e8507cce0ae78fd905fc75f21aaee5fad28f5df2"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"214367975972588521ee24978f1bc3afac44b38b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5d383280_d57e2a18","updated":"2024-02-05 09:12:38.000000000","message":"resolved","commit_id":"e8507cce0ae78fd905fc75f21aaee5fad28f5df2"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"f79037a87357f76ffd1d68b47928b00e8b1aec12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"98a14f93_f90d0ce1","updated":"2024-02-28 05:15:44.000000000","message":"My comment has been addressed. PowerStore CI passed on 24th Feb. Zuul also passed.","commit_id":"64a8c8e4c433fcc6b0a1a80f656548d45ef03ddd"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"dac98a691d0b79560459b336011485f726a7427c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"6d5dd593_37d26910","in_reply_to":"98a14f93_f90d0ce1","updated":"2024-03-01 05:57:57.000000000","message":"recheck","commit_id":"64a8c8e4c433fcc6b0a1a80f656548d45ef03ddd"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"061ca7bb5e1283c7e555a9c9aa0c1a467b3b8ed7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f203682a_6e7eaa3e","updated":"2024-03-04 19:03:27.000000000","message":"Question inline.","commit_id":"eae9d88678b8b753f057d19fb85e343577b6c8f8"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"fb55f0cfda69750e67e2569a055dafd6dd77ee5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"a930e759_507c6a03","updated":"2024-03-08 06:04:37.000000000","message":"@","commit_id":"2ae522ae923e6e346308de84e9e15507a9664146"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e9942e95f8a33c17bf01ec5e61a53489891b4c92","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":15,"id":"0dd0f5d8_6cda6398","updated":"2024-03-10 11:37:46.000000000","message":"@cherry please fix the pep8 failure.","commit_id":"2ae522ae923e6e346308de84e9e15507a9664146"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"c91db609f9709e0619d40158bc912e6f9c323a7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"5e37b34f_ba0b1a81","in_reply_to":"0dd0f5d8_6cda6398","updated":"2024-03-11 12:08:31.000000000","message":"resolved","commit_id":"2ae522ae923e6e346308de84e9e15507a9664146"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"9f734602f781f725c6071247ff8ed433126e2cd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"2aacf3e4_1b5776d2","updated":"2024-07-31 07:31:11.000000000","message":"Hi, \nrajatdhasmana@gmail.com, @zaitcev@kotori.zaitcev.us, @geguileo@redhat.com, @rosmaita.fossdev@gmail.com\n, can you approve the workflow? Thanks in advance.","commit_id":"579efddd6234ce84bbce649d57ce743907ddb4ca"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"a50a1859fd49584ff557eaab0400dd77835dbc6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"6e3b45ca_9b5c7f8f","updated":"2024-07-30 01:57:12.000000000","message":"Hi, can any core reviewer vote the workflow? @zaitcev@kotori.zaitcev.us @rajatdhasmana@gmail.com, @rosmaita.fossdev@gmail.com. Thanks in advance.","commit_id":"579efddd6234ce84bbce649d57ce743907ddb4ca"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"529099d5d903afbc09f3723e4e606b63a5ac8ba2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"232b02c4_94457d52","updated":"2024-07-18 08:13:45.000000000","message":"Hi,Rajat Dhasmana, @rajatdhasmana@gmail.com, can you approve the workflow? Thanks in advance.","commit_id":"579efddd6234ce84bbce649d57ce743907ddb4ca"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"84b9cae59d005c666cc12bab339f0d5faebd97fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"b69e1110_5300e479","updated":"2024-03-13 16:13:49.000000000","message":"I\u0027m not on core yet, but this looks okay. Does not overlap existing tests, as much as I can tell. Values are stable.","commit_id":"579efddd6234ce84bbce649d57ce743907ddb4ca"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"4f7ecd0bb9cb5ee216d25897724dafe5921d2ac4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"aa0aa0db_84c5d8ba","updated":"2024-05-23 17:03:21.000000000","message":"LGTM","commit_id":"579efddd6234ce84bbce649d57ce743907ddb4ca"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c111cb160896380196cbe1854581f185bb95b78f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"e966de1e_07807c7f","updated":"2024-03-26 04:07:08.000000000","message":"The NVMe support in dell powerstore driver was added in Zed[1] and these are unit tests related to that feature so doesn\u0027t seem release critical but good to have them in master at least.\nLGTM.\n\n[1] https://review.opendev.org/c/openstack/cinder/+/819149","commit_id":"579efddd6234ce84bbce649d57ce743907ddb4ca"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"76922d8663794fe0e8699b155f1655781c2f6f41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"600b859e_179efcc8","updated":"2024-08-01 01:45:26.000000000","message":"resolved","commit_id":"579efddd6234ce84bbce649d57ce743907ddb4ca"},{"author":{"_account_id":17450,"name":"Chongchong Lei","email":"Nathaniel.Lei@dell.com","username":"Chongchong","status":"Dell EMC"},"change_message_id":"4c03645eee3b518482870704b379a74dbb7a435f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"df80ffde_68008e20","updated":"2024-03-11 13:15:57.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"579efddd6234ce84bbce649d57ce743907ddb4ca"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"6e5a8837a350f079611116c0965337e18699b1f9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"6273ff6a_7fb048f9","in_reply_to":"232b02c4_94457d52","updated":"2024-07-26 09:52:38.000000000","message":"Hi,Rajat Dhasmana, \n@rajatdhasmana@gmail.com\n, can you approve the workflow? Thanks in advance.","commit_id":"579efddd6234ce84bbce649d57ce743907ddb4ca"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"a0818b8577ca5b9dd0e0dedb8be20a8cfe905446","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"57ba0409_f2af9dce","in_reply_to":"6273ff6a_7fb048f9","updated":"2024-08-01 01:50:02.000000000","message":"resolved","commit_id":"579efddd6234ce84bbce649d57ce743907ddb4ca"}],"cinder/tests/unit/volume/drivers/dell_emc/powerstore/test_volume_attach_detach.py":[{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"d109e04baa2072af6ab7c0e2921810ddde1bfae4","unresolved":true,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def test_get_nvme_targets_filtered(self):"},{"line_number":198,"context_line":"        self.nvme_driver.adapter.allowed_ports \u003d [\"11.22.33.44\"]"},{"line_number":199,"context_line":"        iqns, portals \u003d self.nvme_driver.adapter._get_nvme_targets()"},{"line_number":200,"context_line":"        self.assertTrue(len(iqns) \u003d\u003d len(portals))"},{"line_number":201,"context_line":"        self.assertEqual(1, len(portals))"},{"line_number":202,"context_line":"        self.assertNotIn("}],"source_content_type":"text/x-python","patch_set":3,"id":"819aa949_916297c9","line":199,"updated":"2023-12-05 07:55:30.000000000","message":"According to [1], it should be: \n    portals, nqn \u003d self.nvme_driver.adapter._get_nvme_targets()\n    \n[1] https://opendev.org/openstack/cinder/src/branch/master/cinder/volume/drivers/dell_emc/powerstore/adapter.py#L1153","commit_id":"b8c0e0ba15d8ea7b3e900baf0f0c163e12131e93"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"7b6e0af855ad9781923f372b2202eef41eeed6bb","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def test_get_nvme_targets_filtered(self):"},{"line_number":198,"context_line":"        self.nvme_driver.adapter.allowed_ports \u003d [\"11.22.33.44\"]"},{"line_number":199,"context_line":"        iqns, portals \u003d self.nvme_driver.adapter._get_nvme_targets()"},{"line_number":200,"context_line":"        self.assertTrue(len(iqns) \u003d\u003d len(portals))"},{"line_number":201,"context_line":"        self.assertEqual(1, len(portals))"},{"line_number":202,"context_line":"        self.assertNotIn("}],"source_content_type":"text/x-python","patch_set":3,"id":"69451998_e77ddc81","line":199,"in_reply_to":"819aa949_916297c9","updated":"2024-01-11 08:33:20.000000000","message":"Resolved","commit_id":"b8c0e0ba15d8ea7b3e900baf0f0c163e12131e93"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"d109e04baa2072af6ab7c0e2921810ddde1bfae4","unresolved":true,"context_lines":[{"line_number":200,"context_line":"        self.assertTrue(len(iqns) \u003d\u003d len(portals))"},{"line_number":201,"context_line":"        self.assertEqual(1, len(portals))"},{"line_number":202,"context_line":"        self.assertNotIn("},{"line_number":203,"context_line":"            \"iqn.2020-07.com.dell:dellemc-powerstore-test-iqn-2\", iqns"},{"line_number":204,"context_line":"        )"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def test_get_nvme_targets_filtered_no_matched_ports(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"c8eaf408_6a4518d9","line":203,"updated":"2023-12-05 07:55:30.000000000","message":"It should be a constant of fake nqn, not a iqn.a","commit_id":"b8c0e0ba15d8ea7b3e900baf0f0c163e12131e93"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"78c90b5eb15a0f607790ab96ec043d6482ad8583","unresolved":true,"context_lines":[{"line_number":200,"context_line":"        self.assertTrue(len(iqns) \u003d\u003d len(portals))"},{"line_number":201,"context_line":"        self.assertEqual(1, len(portals))"},{"line_number":202,"context_line":"        self.assertNotIn("},{"line_number":203,"context_line":"            \"iqn.2020-07.com.dell:dellemc-powerstore-test-iqn-2\", iqns"},{"line_number":204,"context_line":"        )"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def test_get_nvme_targets_filtered_no_matched_ports(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"f3e1e3eb_b8cec728","line":203,"in_reply_to":"c8eaf408_6a4518d9","updated":"2024-01-11 08:33:48.000000000","message":"Resolved","commit_id":"b8c0e0ba15d8ea7b3e900baf0f0c163e12131e93"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"4601ecea4a217293b6b9e7be8bff3cc34c73b8bb","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        self.assertTrue(len(iqns) \u003d\u003d len(portals))"},{"line_number":201,"context_line":"        self.assertEqual(1, len(portals))"},{"line_number":202,"context_line":"        self.assertNotIn("},{"line_number":203,"context_line":"            \"iqn.2020-07.com.dell:dellemc-powerstore-test-iqn-2\", iqns"},{"line_number":204,"context_line":"        )"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def test_get_nvme_targets_filtered_no_matched_ports(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"c7e76c7f_fe1bc334","line":203,"in_reply_to":"f3e1e3eb_b8cec728","updated":"2024-01-11 08:34:13.000000000","message":"Resolved","commit_id":"b8c0e0ba15d8ea7b3e900baf0f0c163e12131e93"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"061ca7bb5e1283c7e555a9c9aa0c1a467b3b8ed7","unresolved":true,"context_lines":[{"line_number":194,"context_line":"        portals, nqn \u003d self.nvme_driver.adapter._get_nvme_targets()"},{"line_number":195,"context_line":"        self.assertEqual(2, len(portals))"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def test_get_nvme_targets_filtered(self):"},{"line_number":198,"context_line":"        self.nvme_driver.adapter.allowed_ports \u003d [\"11.22.33.44\"]"},{"line_number":199,"context_line":"        portals, nqn \u003d self.nvme_driver.adapter._get_nvme_targets()"},{"line_number":200,"context_line":"        self.assertTrue(len(nqn) \u003d\u003d len(portals))"}],"source_content_type":"text/x-python","patch_set":12,"id":"83c14fbb_ad31f68b","line":197,"updated":"2024-03-04 19:03:27.000000000","message":"There\u0027s something very strange about this test.  Isn\u0027t nqn a single string value?  So it\u0027s kind of weird to do the comparison at line 200 (and even stranger that it passes), and line 202 is an odd way to compare strings.  What exactly are you testing here?","commit_id":"eae9d88678b8b753f057d19fb85e343577b6c8f8"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"fb55f0cfda69750e67e2569a055dafd6dd77ee5d","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        portals, nqn \u003d self.nvme_driver.adapter._get_nvme_targets()"},{"line_number":195,"context_line":"        self.assertEqual(2, len(portals))"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def test_get_nvme_targets_filtered(self):"},{"line_number":198,"context_line":"        self.nvme_driver.adapter.allowed_ports \u003d [\"11.22.33.44\"]"},{"line_number":199,"context_line":"        portals, nqn \u003d self.nvme_driver.adapter._get_nvme_targets()"},{"line_number":200,"context_line":"        self.assertTrue(len(nqn) \u003d\u003d len(portals))"}],"source_content_type":"text/x-python","patch_set":12,"id":"827857c6_f70b9957","line":197,"in_reply_to":"6b684897_17850ac3","updated":"2024-03-08 06:04:37.000000000","message":"Hi, Brian, I have add the right unit test cases for the _get_connection_properties(self, volume_identifier). Thank you for your comments. Pls help review the new patch.","commit_id":"eae9d88678b8b753f057d19fb85e343577b6c8f8"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"864b1f93e3a32763db901bc94a743a8fc6a963e2","unresolved":true,"context_lines":[{"line_number":194,"context_line":"        portals, nqn \u003d self.nvme_driver.adapter._get_nvme_targets()"},{"line_number":195,"context_line":"        self.assertEqual(2, len(portals))"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def test_get_nvme_targets_filtered(self):"},{"line_number":198,"context_line":"        self.nvme_driver.adapter.allowed_ports \u003d [\"11.22.33.44\"]"},{"line_number":199,"context_line":"        portals, nqn \u003d self.nvme_driver.adapter._get_nvme_targets()"},{"line_number":200,"context_line":"        self.assertTrue(len(nqn) \u003d\u003d len(portals))"}],"source_content_type":"text/x-python","patch_set":12,"id":"6b684897_17850ac3","line":197,"in_reply_to":"83c14fbb_ad31f68b","updated":"2024-03-05 07:44:43.000000000","message":"This patch is adding a unit test for patch \nhttps://review.opendev.org/c/openstack/cinder/+/852261\nThe line 200 means the len of nqn is as same as protals.","commit_id":"eae9d88678b8b753f057d19fb85e343577b6c8f8"}]}