)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"cd5d65a26f8f8555f7e8a66525cdc733206fc170","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9e18e463_49c0d8dd","updated":"2023-11-23 13:22:19.000000000","message":"recheck tempest-integrated-storage","commit_id":"900682dce610656ea9888206875d01e5d9fc5461"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"e38dd92b31d98016a8e5107590b8665575591410","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"67b0ac50_a4f3148c","updated":"2024-01-05 05:11:23.000000000","message":"run-HPE Storage CI","commit_id":"ca9462a318562e45fd5a0291363c5f96e1c05fcb"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"d50f5fe3a87bbad1fccfd7bab640fbc338cd06dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a7742d56_f7341b14","updated":"2024-01-05 03:56:22.000000000","message":"run-HPE Storage CI","commit_id":"ca9462a318562e45fd5a0291363c5f96e1c05fcb"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c5727e1911edaa84ae05f4229e1b19242bbd6548","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e1a73104_a15b2eb1","updated":"2024-01-04 05:12:34.000000000","message":"run-HPE Storage CI","commit_id":"ca9462a318562e45fd5a0291363c5f96e1c05fcb"},{"author":{"_account_id":36121,"name":"tomasz","display_name":"toch","email":"tomasz_chendynski@polcom.com.pl","username":"Chendynski"},"change_message_id":"9a31577b3d089fc74c897aafd8aa92e6826941fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"23356b00_8c425ad8","updated":"2024-03-26 11:42:16.000000000","message":"works for me","commit_id":"ffb836b3cb0bc9429814cc40441f07bd6b9e57ba"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ba0b09610e26453a1c0ed45d6da0c4bc9e56f81e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e7ab2423_425cbd1a","updated":"2024-04-15 23:06:42.000000000","message":"I guess the code is OK, but I really don\u0027t understand what\u0027s going on there.  I do think you need to enhance the unit test(s), though.","commit_id":"6b2188d669292b42e3cdafb5cd0016905830acb6"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"597a29e5556cff3da4a6877ebe422a50986f4514","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9bbcaf8a_490c2237","updated":"2024-04-16 05:14:05.000000000","message":"Thanks Brian.","commit_id":"6b2188d669292b42e3cdafb5cd0016905830acb6"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"92bc59f490baca4f53237acdf48a0d8850f2ada8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"13af4377_fde80e6f","updated":"2024-04-04 12:34:52.000000000","message":"run-HPE Storage CI","commit_id":"6b2188d669292b42e3cdafb5cd0016905830acb6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"db4ba3ddc70284e8d8e226120f20acb3bc56de4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"868abebb_f0769620","updated":"2024-04-16 12:29:23.000000000","message":"As far as I can tell, the code addresses the issue as outlined in the bug report, and the unit test is satisfactory.  Only issue at this point is that the third party CI has not passed, and I notice that the \"HPE Storage CI\" is currently only running a 3par-iscsi-driver-master-client-pip-ssa02-dsvm 3par-iscsi-driver-master-client-pip-ssa02-dsvm job ... I think we want to see FC job results also?\n\nComment inline about the versioning, though you can take it or leave it, I\u0027m not sure how you track what version of the driver your customers are using.","commit_id":"1f66d2e4d9bf34e594d4dc633ed8a1aefc2315ab"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"080bb4ad7fe8993f722ad6c9478263cde9cbfddc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"eb0c272c_c0f90b28","updated":"2024-04-16 09:52:05.000000000","message":"Hi Brian,\ni updated the UT code. Thanks.","commit_id":"1f66d2e4d9bf34e594d4dc633ed8a1aefc2315ab"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"3078655ebd76cd7e510a846c9a807d748becfaa5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6718e265_1a799159","updated":"2024-04-16 12:47:08.000000000","message":"Thanks Brian for quick review.\ni will check \u0026 revert.","commit_id":"1f66d2e4d9bf34e594d4dc633ed8a1aefc2315ab"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"930a112abf4d03626200368b329eb695fd5e1c43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c0e6a10f_057942bd","updated":"2024-05-06 06:05:32.000000000","message":"Incremented the version.\nStill working on FC CI (in progress).","commit_id":"ec953c10460e86a2163dbcb9eb6bf621b42f8573"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"93bda8bfd58eb770e6db4eea9df12ab8de9d24bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"73918fa3_8a707a8e","updated":"2024-05-21 05:31:13.000000000","message":"run-hpe-fc-storage","commit_id":"ec953c10460e86a2163dbcb9eb6bf621b42f8573"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"dbf389e1ba802f60a22e108a66842e81bb3e7ed2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"81b986d2_0ef1a991","updated":"2024-06-20 14:14:34.000000000","message":"Brian is a +2.  Code looks good to me.  I will merge.","commit_id":"efa1e80fb2386afa3ffb07328e862e58f60836d7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"635e61dea3ec97020fcb0d01390ea63d530c02f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8948b3ad_f0e6cb41","updated":"2024-06-18 22:16:57.000000000","message":"Changes between PS 7 and 9 LGTM.  Now that the HPE FC CI is reporting green, upgrading my vote to +2.","commit_id":"efa1e80fb2386afa3ffb07328e862e58f60836d7"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"1ca63f0eca4fd6c9ca0d550bfe1d26d392d8b652","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8d0fc539_ad2e46c3","updated":"2024-06-11 09:44:59.000000000","message":"Hi Brian,\nA gentle reminder please.\n\"HPE FC CI\" and Zuul have passed.\n\nIt would be great to know your feedback.\nThanks.","commit_id":"efa1e80fb2386afa3ffb07328e862e58f60836d7"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c7662ca7857e8ba051f10f37589c2108f8a211a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"88c3813e_7b2d1982","updated":"2024-06-04 09:06:52.000000000","message":"Hi Brian,\nNow we have added \"HPE FC CI\" and it has passed.\nZuul also passed.\nMay i request your feedback please.","commit_id":"efa1e80fb2386afa3ffb07328e862e58f60836d7"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"6fce93066875c07cf3250082aed2d31f67e83d33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"0446818a_bbda5bd0","updated":"2024-06-19 03:37:34.000000000","message":"Thank you Brian","commit_id":"efa1e80fb2386afa3ffb07328e862e58f60836d7"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"6369b707c41713e16a6ca64d478794361b6ef9ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b751be1c_d365dab3","updated":"2024-06-20 14:35:42.000000000","message":"Thank you Jay","commit_id":"efa1e80fb2386afa3ffb07328e862e58f60836d7"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"05c4982a841371e3f9df48893008e7ede052718e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f28188bd_cefda916","updated":"2024-06-04 04:28:57.000000000","message":"run-HPE FC Storage CI","commit_id":"efa1e80fb2386afa3ffb07328e862e58f60836d7"}],"cinder/tests/unit/volume/drivers/hpe/test_hpe3par.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ba0b09610e26453a1c0ed45d6da0c4bc9e56f81e","unresolved":true,"context_lines":[{"line_number":7681,"context_line":"                \u0027encrypted\u0027: False,"},{"line_number":7682,"context_line":"                \u0027target_wwn\u0027: [\u00270987654321234\u0027, \u0027123456789000987\u0027,"},{"line_number":7683,"context_line":"                               \u00270987654321234\u0027, \u0027123456789000987\u0027],"},{"line_number":7684,"context_line":"                \u0027target_luns\u0027: [90, 90, 90, 90],"},{"line_number":7685,"context_line":"                \u0027target_discovered\u0027: True,"},{"line_number":7686,"context_line":"                \u0027initiator_target_map\u0027:"},{"line_number":7687,"context_line":"                    {\u0027123456789012345\u0027: [\u00270987654321234\u0027, \u0027123456789000987\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"e8db16cd_5263b265","line":7684,"updated":"2024-04-15 23:06:42.000000000","message":"Is the info_peer target_lun always going to be the same as the \"regular\" target_lun?  I guess it must be possible to be different, since you use it at line 287 in the code file.  I think you should set up the test data so that you\u0027ll get a list of regular luns + peer luns that are different, so you can see that the code is doing the right thing.","commit_id":"6b2188d669292b42e3cdafb5cd0016905830acb6"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"080bb4ad7fe8993f722ad6c9478263cde9cbfddc","unresolved":false,"context_lines":[{"line_number":7681,"context_line":"                \u0027encrypted\u0027: False,"},{"line_number":7682,"context_line":"                \u0027target_wwn\u0027: [\u00270987654321234\u0027, \u0027123456789000987\u0027,"},{"line_number":7683,"context_line":"                               \u00270987654321234\u0027, \u0027123456789000987\u0027],"},{"line_number":7684,"context_line":"                \u0027target_luns\u0027: [90, 90, 90, 90],"},{"line_number":7685,"context_line":"                \u0027target_discovered\u0027: True,"},{"line_number":7686,"context_line":"                \u0027initiator_target_map\u0027:"},{"line_number":7687,"context_line":"                    {\u0027123456789012345\u0027: [\u00270987654321234\u0027, \u0027123456789000987\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"75405e2c_b1bfc03f","line":7684,"in_reply_to":"e8db16cd_5263b265","updated":"2024-04-16 09:52:05.000000000","message":"Done","commit_id":"6b2188d669292b42e3cdafb5cd0016905830acb6"}],"cinder/volume/drivers/hpe/hpe_3par_fc.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"db4ba3ddc70284e8d8e226120f20acb3bc56de4e","unresolved":true,"context_lines":[{"line_number":114,"context_line":"        4.0.5 - Set proper backend on subsequent operation, after group"},{"line_number":115,"context_line":"                failover. bug #1773069"},{"line_number":116,"context_line":"        4.0.6 - Set NSP for single path attachments. Bug #1809249"},{"line_number":117,"context_line":"        4.0.7 - Added Peer Persistence feature"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    \"\"\""},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"f8c4fe66_4d300f40","line":117,"range":{"start_line":117,"start_character":8,"end_line":117,"end_character":13},"updated":"2024-04-16 12:29:23.000000000","message":"Entirely up to you, but you may want to bump the version number so that you can easily tell the difference between a 4.0.7 driver that supports peer persistence, and a 4.0.8 driver that contains the fix for FC peer persistence.","commit_id":"1f66d2e4d9bf34e594d4dc633ed8a1aefc2315ab"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"930a112abf4d03626200368b329eb695fd5e1c43","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        4.0.5 - Set proper backend on subsequent operation, after group"},{"line_number":115,"context_line":"                failover. bug #1773069"},{"line_number":116,"context_line":"        4.0.6 - Set NSP for single path attachments. Bug #1809249"},{"line_number":117,"context_line":"        4.0.7 - Added Peer Persistence feature"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    \"\"\""},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"557e6f1d_65e91516","line":117,"range":{"start_line":117,"start_character":8,"end_line":117,"end_character":13},"in_reply_to":"f8c4fe66_4d300f40","updated":"2024-05-06 06:05:32.000000000","message":"Done","commit_id":"1f66d2e4d9bf34e594d4dc633ed8a1aefc2315ab"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"79fdeb6f7edfb379fb1b03d80bb9aae05737667d","unresolved":true,"context_lines":[{"line_number":280,"context_line":"            common._destroy_replication_client(remote_client)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"            len_main_wwn \u003d len(info[\u0027data\u0027][\u0027target_wwn\u0027])"},{"line_number":283,"context_line":"            target_luns \u003d []"},{"line_number":284,"context_line":"            target_luns \u003d [info[\u0027data\u0027][\u0027target_lun\u0027]] * len_main_wwn"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"            len_backup_wwn \u003d len(info_peer[\u0027data\u0027][\u0027target_wwn\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a7e8893_f91367fa","line":283,"range":{"start_line":283,"start_character":12,"end_line":283,"end_character":28},"updated":"2024-04-17 10:54:36.000000000","message":"(nit) this line can be removed.","commit_id":"1f66d2e4d9bf34e594d4dc633ed8a1aefc2315ab"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"930a112abf4d03626200368b329eb695fd5e1c43","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            common._destroy_replication_client(remote_client)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"            len_main_wwn \u003d len(info[\u0027data\u0027][\u0027target_wwn\u0027])"},{"line_number":283,"context_line":"            target_luns \u003d []"},{"line_number":284,"context_line":"            target_luns \u003d [info[\u0027data\u0027][\u0027target_lun\u0027]] * len_main_wwn"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"            len_backup_wwn \u003d len(info_peer[\u0027data\u0027][\u0027target_wwn\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"e2e002b6_785e3390","line":283,"range":{"start_line":283,"start_character":12,"end_line":283,"end_character":28},"in_reply_to":"9a7e8893_f91367fa","updated":"2024-05-06 06:05:32.000000000","message":"Acknowledged","commit_id":"1f66d2e4d9bf34e594d4dc633ed8a1aefc2315ab"}]}