)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"315057ba8b307f5dd64b6c445330ca2713a929e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e622551a_24d03a03","updated":"2024-01-24 08:07:58.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"664412383eb0a3ff7ba497c72b9252583e7160cd"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"08bb2f5b2f068b2990e5fa0cd426d32091824f57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7147f33b_b54e1a0c","updated":"2024-03-20 15:58:05.000000000","message":"Mostly looks good; a few comments inline.","commit_id":"a6e09e3c81066b361898aedb7e59f9190c30a69a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a112d3780f9fb92e9a0ad0ff76eae15d2b7adaad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d84a13c1_34ce99b4","updated":"2024-03-19 20:03:22.000000000","message":"few questions inline.\npowermax CI is aborted after running for 10 hours which needs to be fixed.","commit_id":"a6e09e3c81066b361898aedb7e59f9190c30a69a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e6e1077e74a887fc962a03e18794c25d117b9092","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d39eb8da_34f3f051","updated":"2024-03-15 03:19:16.000000000","message":"recheck","commit_id":"a6e09e3c81066b361898aedb7e59f9190c30a69a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"a2b52b57e131f089c3c08ba14759eb4061f0ec3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"16cbaf5d_48aa0fe9","updated":"2024-03-15 05:21:16.000000000","message":"recheck cinder-plugin-ceph-tempest","commit_id":"a6e09e3c81066b361898aedb7e59f9190c30a69a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"bf6b32cdbc52231f778eea5e1ce0d951600828e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2b6e7404_649965ac","updated":"2024-03-12 06:43:06.000000000","message":"recheck openstack-tox-py38 cinder.tests.unit.backup.test_backup.BackupTestCase.test_tpool_size","commit_id":"a6e09e3c81066b361898aedb7e59f9190c30a69a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"aecfb17922f79ee1fefe3f73bd1ddce6a12e49e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4d5bd7fb_7a35abae","updated":"2024-03-19 20:03:28.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"a6e09e3c81066b361898aedb7e59f9190c30a69a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"0708f06dc7ea9905afd13a0f9c4370c414ef38f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ee8dce33_183fca72","updated":"2024-03-12 06:46:35.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"a6e09e3c81066b361898aedb7e59f9190c30a69a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"39ef56979f9f5e62287e4bc98c1abdda14764055","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"03c6139d_c80a50d1","in_reply_to":"d84a13c1_34ce99b4","updated":"2024-03-20 05:38:15.000000000","message":"Patchset 4 passed PowerMax CI on Mar 12 10:08 PM.\n\nI noticed the CI keeps failing since last weekend. Unfortunately, the CI owner has been OOO. Will reach out to e-lab to see if anyone else can help.","commit_id":"a6e09e3c81066b361898aedb7e59f9190c30a69a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ea35e810322b85480c2319239370b9e57f67359d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9401e187_283ab125","updated":"2024-03-20 17:23:21.000000000","message":"Looks like we were caught in a race condition and you pushed PS 5 while I was reviewing PS 4.  My comments still hold.","commit_id":"a4d3b5b170fc2107e7f5a2092bacd3bf4f1f04e3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"20cc1388284d2bd0977c7104625cc7cec92cde7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4a0d1f77_96057e63","updated":"2024-03-21 21:12:05.000000000","message":"All my concerns have been addressed.  Only a +1 while waiting for the Dell CI to respond.","commit_id":"03ac369854597f6c886906c1f71561894b10aa04"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"6522d78002e79071f448e5033c93356a1fb625ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e0af7ac0_0ef7146c","updated":"2024-03-25 02:29:11.000000000","message":"Created cherry pick: https://review.opendev.org/c/openstack/cinder/+/914005","commit_id":"03ac369854597f6c886906c1f71561894b10aa04"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"122a86e8c9abfc58f94c252ba848ca3457c8b112","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"cdbbd43a_feedc099","updated":"2024-03-22 13:19:45.000000000","message":"I agree with Rajat\u0027s analysis of the difference between PS 4 and PS 7 with respect to the third party CI passing, and since the Dell team has asserted that they are working on getting the CI back online, I\u0027m OK with approving this change.","commit_id":"03ac369854597f6c886906c1f71561894b10aa04"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"6fec53436d073a1a546c905c52ab86c6b1c9adcf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1a4661f5_615e7e8e","updated":"2024-03-23 08:53:47.000000000","message":"PowerMax CI passed, but Zuul tempest-integrated-storage failed.","commit_id":"03ac369854597f6c886906c1f71561894b10aa04"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8d04db92c6035a312154174611b3b3eaab0596f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"acff31da_addee3d5","updated":"2024-03-22 08:27:16.000000000","message":"The only functional change from PS4 is passing the value in lowercase in the payload which is supposed to work given other parameters use similar syntax.\n\nThe CI passed on PS4 and now it is being worked upon. Dell team has already mentioned that the CI will take time and given this is a critical fix + RC2 needs to happen next week, I\u0027m okay with merging this.\n\nBut if other reviewers think it\u0027s not appropriate, they can flag it which is also totally fine since that is inline with our policy.","commit_id":"03ac369854597f6c886906c1f71561894b10aa04"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"37b307e2ee0bad7377218aeeea4568a0e78c65f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"320a1592_3a0a2b26","updated":"2024-03-24 04:13:40.000000000","message":"recheck openstack-tox-py39 cinder.tests.unit.backup.test_backup.BackupTestCase","commit_id":"03ac369854597f6c886906c1f71561894b10aa04"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"c1b53e55c5353fc5f89b5233e790808a268dcea2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0cb155e1_4a46187d","updated":"2024-03-23 08:54:01.000000000","message":"recheck tempest-integrated-storage","commit_id":"03ac369854597f6c886906c1f71561894b10aa04"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"fc005b822858fe9ce57a7b03d8abb34606efc01b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ad8e26d7_4a4d22cc","updated":"2024-03-22 15:41:40.000000000","message":"recheck tempest-integrated-storage TimeoutException","commit_id":"03ac369854597f6c886906c1f71561894b10aa04"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"88a00f4d3d2647b81e73c15d2fe8d58cc6171673","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8c78d0ae_793c3795","updated":"2024-03-23 03:42:54.000000000","message":"recheck tempest-integrated-storage massive failures","commit_id":"03ac369854597f6c886906c1f71561894b10aa04"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"82ede3647ef6a778a44e8609ff87c76e27b0efd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"230915ba_1a6592a1","updated":"2024-03-24 12:49:23.000000000","message":"recheck tempest-integrated-storage tempest.api.volume.admin.test_volumes_backup.VolumesBackupsAdminTest tempest.api.volume.test_volumes_backup.VolumesBackupsV39Test","commit_id":"03ac369854597f6c886906c1f71561894b10aa04"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"32d1a474803a3c82efedc6e16e2ad9e72768d86e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4962d050_150e16d9","updated":"2024-03-24 10:31:06.000000000","message":"recheck tempest-integrated-storage tempest.api.volume.test_volumes_actions.VolumesActionsTest","commit_id":"03ac369854597f6c886906c1f71561894b10aa04"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"aa16ccd6c9658e879b14a8c7ccc213cba9ea7f25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a0691b65_d696a1ff","updated":"2024-03-23 05:50:26.000000000","message":"recheck tempest-integrated-storage tempest.api.volume.test_volumes_actions.VolumesActionsTest not found","commit_id":"03ac369854597f6c886906c1f71561894b10aa04"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"5d1107d0d4afe3bdd076e801cab8e90491aa17b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"68c76619_8e80b88e","updated":"2024-03-22 08:12:31.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"03ac369854597f6c886906c1f71561894b10aa04"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"0813edf4ec54449f72bf170be5ae977108712138","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ad9362b2_4f3aa0f3","updated":"2024-03-22 14:56:37.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"03ac369854597f6c886906c1f71561894b10aa04"}],"cinder/tests/unit/volume/drivers/dell_emc/powermax/test_powermax_rest.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a112d3780f9fb92e9a0ad0ff76eae15d2b7adaad","unresolved":true,"context_lines":[{"line_number":1301,"context_line":"                   \u0027copy\u0027: \u0027false\u0027, \u0027action\u0027: \"\","},{"line_number":1302,"context_line":"                   \u0027star\u0027: \u0027false\u0027, \u0027force\u0027: \u0027false\u0027,"},{"line_number":1303,"context_line":"                   \u0027exact\u0027: \u0027false\u0027, \u0027remote\u0027: \u0027false\u0027,"},{"line_number":1304,"context_line":"                   \u0027symforce\u0027: \u0027False\u0027, \u0027snap_id\u0027: self.data.snap_id}"},{"line_number":1305,"context_line":"        payload_restore \u003d {\u0027deviceNameListSource\u0027: [{\u0027name\u0027: source_id}],"},{"line_number":1306,"context_line":"                           \u0027deviceNameListTarget\u0027: [{\u0027name\u0027: source_id}],"},{"line_number":1307,"context_line":"                           \u0027action\u0027: \u0027Restore\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"91709626_13377fd4","line":1304,"range":{"start_line":1304,"start_character":31,"end_line":1304,"end_character":38},"updated":"2024-03-19 20:03:22.000000000","message":"I could be wrong but shouldn\u0027t this be a boolean instead of a string?\n\n    False instead of \u0027False\u0027","commit_id":"a6e09e3c81066b361898aedb7e59f9190c30a69a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8f3b31f1107b960fc4e5bdcc5a2e6629ba774448","unresolved":false,"context_lines":[{"line_number":1301,"context_line":"                   \u0027copy\u0027: \u0027false\u0027, \u0027action\u0027: \"\","},{"line_number":1302,"context_line":"                   \u0027star\u0027: \u0027false\u0027, \u0027force\u0027: \u0027false\u0027,"},{"line_number":1303,"context_line":"                   \u0027exact\u0027: \u0027false\u0027, \u0027remote\u0027: \u0027false\u0027,"},{"line_number":1304,"context_line":"                   \u0027symforce\u0027: \u0027False\u0027, \u0027snap_id\u0027: self.data.snap_id}"},{"line_number":1305,"context_line":"        payload_restore \u003d {\u0027deviceNameListSource\u0027: [{\u0027name\u0027: source_id}],"},{"line_number":1306,"context_line":"                           \u0027deviceNameListTarget\u0027: [{\u0027name\u0027: source_id}],"},{"line_number":1307,"context_line":"                           \u0027action\u0027: \u0027Restore\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"58deb54e_8ea5648c","line":1304,"range":{"start_line":1304,"start_character":31,"end_line":1304,"end_character":38},"in_reply_to":"1e5381f2_63be46cf","updated":"2024-03-20 14:31:44.000000000","message":"Acknowledged","commit_id":"a6e09e3c81066b361898aedb7e59f9190c30a69a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"39ef56979f9f5e62287e4bc98c1abdda14764055","unresolved":true,"context_lines":[{"line_number":1301,"context_line":"                   \u0027copy\u0027: \u0027false\u0027, \u0027action\u0027: \"\","},{"line_number":1302,"context_line":"                   \u0027star\u0027: \u0027false\u0027, \u0027force\u0027: \u0027false\u0027,"},{"line_number":1303,"context_line":"                   \u0027exact\u0027: \u0027false\u0027, \u0027remote\u0027: \u0027false\u0027,"},{"line_number":1304,"context_line":"                   \u0027symforce\u0027: \u0027False\u0027, \u0027snap_id\u0027: self.data.snap_id}"},{"line_number":1305,"context_line":"        payload_restore \u003d {\u0027deviceNameListSource\u0027: [{\u0027name\u0027: source_id}],"},{"line_number":1306,"context_line":"                           \u0027deviceNameListTarget\u0027: [{\u0027name\u0027: source_id}],"},{"line_number":1307,"context_line":"                           \u0027action\u0027: \u0027Restore\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1e5381f2_63be46cf","line":1304,"range":{"start_line":1304,"start_character":31,"end_line":1304,"end_character":38},"in_reply_to":"91709626_13377fd4","updated":"2024-03-20 05:38:15.000000000","message":"The \u0027symforce\u0027 field is type of string in the PowerMax restapi.","commit_id":"a6e09e3c81066b361898aedb7e59f9190c30a69a"}],"cinder/volume/drivers/dell_emc/powermax/common.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"08bb2f5b2f068b2990e5fa0cd426d32091824f57","unresolved":true,"context_lines":[{"line_number":157,"context_line":"                    \u0027timeout value (in seconds) for rest call.\u0027),"},{"line_number":158,"context_line":"    cfg.BoolOpt(utils.SNAPVX_UNLINK_SYMFORCE,"},{"line_number":159,"context_line":"                default\u003dFalse,"},{"line_number":160,"context_line":"                help\u003d\u0027Enable SnapVx unlink symforce.\u0027),"},{"line_number":161,"context_line":"]"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"b6ed77f0_1465fb02","line":160,"range":{"start_line":160,"start_character":43,"end_line":160,"end_character":51},"updated":"2024-03-20 15:58:05.000000000","message":"nit: I guess it is obvious to Dell users what \"symforce\" is?","commit_id":"a6e09e3c81066b361898aedb7e59f9190c30a69a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"3770646f85896533684a448ce76f745cd5f82619","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                    \u0027timeout value (in seconds) for rest call.\u0027),"},{"line_number":158,"context_line":"    cfg.BoolOpt(utils.SNAPVX_UNLINK_SYMFORCE,"},{"line_number":159,"context_line":"                default\u003dFalse,"},{"line_number":160,"context_line":"                help\u003d\u0027Enable SnapVx unlink symforce.\u0027),"},{"line_number":161,"context_line":"]"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"19771732_f88f8fd2","line":160,"range":{"start_line":160,"start_character":43,"end_line":160,"end_character":51},"in_reply_to":"b6ed77f0_1465fb02","updated":"2024-03-21 13:54:21.000000000","message":"Done","commit_id":"a6e09e3c81066b361898aedb7e59f9190c30a69a"}],"cinder/volume/drivers/dell_emc/powermax/provision.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"08bb2f5b2f068b2990e5fa0cd426d32091824f57","unresolved":true,"context_lines":[{"line_number":238,"context_line":"        :param extra_specs: extra specifications"},{"line_number":239,"context_line":"        :param snap_id: the unique snap id of the SnapVX"},{"line_number":240,"context_line":"        :param list_volume_pairs: list of volume pairs, optional"},{"line_number":241,"context_line":"        :param loop: if looping call is required for handling retries"},{"line_number":242,"context_line":"        :returns: return code"},{"line_number":243,"context_line":"        \"\"\""},{"line_number":244,"context_line":"        def _unlink_vol():"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ce9993a_e3011f2a","line":241,"updated":"2024-03-20 15:58:05.000000000","message":"nit: should include the new \u0027symforce\u0027 parameter here","commit_id":"a6e09e3c81066b361898aedb7e59f9190c30a69a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"3770646f85896533684a448ce76f745cd5f82619","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        :param extra_specs: extra specifications"},{"line_number":239,"context_line":"        :param snap_id: the unique snap id of the SnapVX"},{"line_number":240,"context_line":"        :param list_volume_pairs: list of volume pairs, optional"},{"line_number":241,"context_line":"        :param loop: if looping call is required for handling retries"},{"line_number":242,"context_line":"        :returns: return code"},{"line_number":243,"context_line":"        \"\"\""},{"line_number":244,"context_line":"        def _unlink_vol():"}],"source_content_type":"text/x-python","patch_set":4,"id":"ed4fc422_649858e0","line":241,"in_reply_to":"3ce9993a_e3011f2a","updated":"2024-03-21 13:54:21.000000000","message":"Done","commit_id":"a6e09e3c81066b361898aedb7e59f9190c30a69a"}],"cinder/volume/drivers/dell_emc/powermax/rest.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"08bb2f5b2f068b2990e5fa0cd426d32091824f57","unresolved":true,"context_lines":[{"line_number":2248,"context_line":"                       \"copy\": copy, \"action\": action,"},{"line_number":2249,"context_line":"                       \"star\": \u0027false\u0027, \"force\": force,"},{"line_number":2250,"context_line":"                       \"exact\": \u0027false\u0027, \"remote\": \u0027false\u0027,"},{"line_number":2251,"context_line":"                       \"symforce\": str(symforce)}"},{"line_number":2252,"context_line":"        elif action \u003d\u003d \"Rename\":"},{"line_number":2253,"context_line":"            operation \u003d \u0027Rename snapVx snapshot\u0027"},{"line_number":2254,"context_line":"            payload \u003d {\"deviceNameListSource\": [{\"name\": source_id}],"}],"source_content_type":"text/x-python","patch_set":4,"id":"df3a4720_a6174975","line":2251,"updated":"2024-03-20 15:58:05.000000000","message":"I wonder whether you should force this to lowercase for consistency with the rest of the payload.  (This is why you had to change the unit test that Rajat asked about.)  We know that the \"old\" way of having \u0027false\u0027 worked; maybe \u0027False\u0027 also works, but why take the chance?","commit_id":"a6e09e3c81066b361898aedb7e59f9190c30a69a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"3770646f85896533684a448ce76f745cd5f82619","unresolved":false,"context_lines":[{"line_number":2248,"context_line":"                       \"copy\": copy, \"action\": action,"},{"line_number":2249,"context_line":"                       \"star\": \u0027false\u0027, \"force\": force,"},{"line_number":2250,"context_line":"                       \"exact\": \u0027false\u0027, \"remote\": \u0027false\u0027,"},{"line_number":2251,"context_line":"                       \"symforce\": str(symforce)}"},{"line_number":2252,"context_line":"        elif action \u003d\u003d \"Rename\":"},{"line_number":2253,"context_line":"            operation \u003d \u0027Rename snapVx snapshot\u0027"},{"line_number":2254,"context_line":"            payload \u003d {\"deviceNameListSource\": [{\"name\": source_id}],"}],"source_content_type":"text/x-python","patch_set":4,"id":"cb6729a0_db8a0227","line":2251,"in_reply_to":"df3a4720_a6174975","updated":"2024-03-21 13:54:21.000000000","message":"Done","commit_id":"a6e09e3c81066b361898aedb7e59f9190c30a69a"}],"releasenotes/notes/bug-2045230-dell-powermax-fix-snapvx-unlink-e27d67d6b217d706.yaml":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a112d3780f9fb92e9a0ad0ff76eae15d2b7adaad","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerMax Driver `Bug #2045230"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2045230\u003e`_: Fixed"},{"line_number":6,"context_line":"    the issue that Dell PowerMax SnapVx link fails as the linked device is not"},{"line_number":7,"context_line":"    yet fully defined."},{"line_number":8,"context_line":"    This is achieved by checking the new configuration ``snapvx_unlink_symforce``"},{"line_number":9,"context_line":"    and the linked device ``defined`` status to determine the value of ``symforce``"},{"line_number":10,"context_line":"    in the payload of SnapVx unlink restcall."},{"line_number":11,"context_line":"    When ``snapvx_unlink_symforce`` is enabled and the linked device is not fully"},{"line_number":12,"context_line":"    defined, proceed unlink symforce operation."},{"line_number":13,"context_line":"    Otherwise, proceed as usual."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b4fa6853_815af8be","line":13,"range":{"start_line":5,"start_character":56,"end_line":13,"end_character":32},"updated":"2024-03-19 20:03:22.000000000","message":"maybe this is an internal thing we are fixing but I don\u0027t understand what will be the end user impact of this fix.\nWould be useful to state the operation being performed/affected, current behavior, new behavior after this fix is applied etc.","commit_id":"a6e09e3c81066b361898aedb7e59f9190c30a69a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"137cd94e7727078010389ab155af681c20f1a7e8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerMax Driver `Bug #2045230"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2045230\u003e`_: Fixed"},{"line_number":6,"context_line":"    the issue that Dell PowerMax SnapVx link fails as the linked device is not"},{"line_number":7,"context_line":"    yet fully defined."},{"line_number":8,"context_line":"    This is achieved by checking the new configuration ``snapvx_unlink_symforce``"},{"line_number":9,"context_line":"    and the linked device ``defined`` status to determine the value of ``symforce``"},{"line_number":10,"context_line":"    in the payload of SnapVx unlink restcall."},{"line_number":11,"context_line":"    When ``snapvx_unlink_symforce`` is enabled and the linked device is not fully"},{"line_number":12,"context_line":"    defined, proceed unlink symforce operation."},{"line_number":13,"context_line":"    Otherwise, proceed as usual."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a6a05f35_1775daee","line":13,"range":{"start_line":5,"start_character":56,"end_line":13,"end_character":32},"in_reply_to":"1b42c119_ad974edc","updated":"2024-03-20 15:52:01.000000000","message":"Done. Thank you, Rajat!","commit_id":"a6e09e3c81066b361898aedb7e59f9190c30a69a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"3770646f85896533684a448ce76f745cd5f82619","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerMax Driver `Bug #2045230"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2045230\u003e`_: Fixed"},{"line_number":6,"context_line":"    the issue that Dell PowerMax SnapVx link fails as the linked device is not"},{"line_number":7,"context_line":"    yet fully defined."},{"line_number":8,"context_line":"    This is achieved by checking the new configuration ``snapvx_unlink_symforce``"},{"line_number":9,"context_line":"    and the linked device ``defined`` status to determine the value of ``symforce``"},{"line_number":10,"context_line":"    in the payload of SnapVx unlink restcall."},{"line_number":11,"context_line":"    When ``snapvx_unlink_symforce`` is enabled and the linked device is not fully"},{"line_number":12,"context_line":"    defined, proceed unlink symforce operation."},{"line_number":13,"context_line":"    Otherwise, proceed as usual."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b641604d_7fc41d2d","line":13,"range":{"start_line":5,"start_character":56,"end_line":13,"end_character":32},"in_reply_to":"39f7445e_e250a0db","updated":"2024-03-21 13:54:21.000000000","message":"Done","commit_id":"a6e09e3c81066b361898aedb7e59f9190c30a69a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"39ef56979f9f5e62287e4bc98c1abdda14764055","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerMax Driver `Bug #2045230"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2045230\u003e`_: Fixed"},{"line_number":6,"context_line":"    the issue that Dell PowerMax SnapVx link fails as the linked device is not"},{"line_number":7,"context_line":"    yet fully defined."},{"line_number":8,"context_line":"    This is achieved by checking the new configuration ``snapvx_unlink_symforce``"},{"line_number":9,"context_line":"    and the linked device ``defined`` status to determine the value of ``symforce``"},{"line_number":10,"context_line":"    in the payload of SnapVx unlink restcall."},{"line_number":11,"context_line":"    When ``snapvx_unlink_symforce`` is enabled and the linked device is not fully"},{"line_number":12,"context_line":"    defined, proceed unlink symforce operation."},{"line_number":13,"context_line":"    Otherwise, proceed as usual."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c3e5e606_50cb2ede","line":13,"range":{"start_line":5,"start_character":56,"end_line":13,"end_character":32},"in_reply_to":"b4fa6853_815af8be","updated":"2024-03-20 05:38:15.000000000","message":"Can I say:\n\nPreviously, below operations fail if the linked device is not fully defined.\nNow, when ``snapvx_unlink_symforce`` is enabled, those operations are not interrupted by not fully defined devices.\n\nImpacted operations:\n``Clone a volume``\n``Create a volume from a snapshot``\n``Create volume snapshots``\n``Delete volume snapshots``\n``Revert volume to snapshot``\n``Create generic volume group from source``\n``Unmanage volumes``","commit_id":"a6e09e3c81066b361898aedb7e59f9190c30a69a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"08bb2f5b2f068b2990e5fa0cd426d32091824f57","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerMax Driver `Bug #2045230"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2045230\u003e`_: Fixed"},{"line_number":6,"context_line":"    the issue that Dell PowerMax SnapVx link fails as the linked device is not"},{"line_number":7,"context_line":"    yet fully defined."},{"line_number":8,"context_line":"    This is achieved by checking the new configuration ``snapvx_unlink_symforce``"},{"line_number":9,"context_line":"    and the linked device ``defined`` status to determine the value of ``symforce``"},{"line_number":10,"context_line":"    in the payload of SnapVx unlink restcall."},{"line_number":11,"context_line":"    When ``snapvx_unlink_symforce`` is enabled and the linked device is not fully"},{"line_number":12,"context_line":"    defined, proceed unlink symforce operation."},{"line_number":13,"context_line":"    Otherwise, proceed as usual."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"39f7445e_e250a0db","line":13,"range":{"start_line":5,"start_character":56,"end_line":13,"end_character":32},"in_reply_to":"c3e5e606_50cb2ede","updated":"2024-03-20 15:58:05.000000000","message":"@Yian, your proposal sounds good to me, though maybe say \"Previously, the below operations could fail if the linked device was not yet fully defined at the time of the call.\"\n\nAlso, it would be good to say what the default value of the new config opt is.  Also, since the default is False, it would be good to say something about when it should be enabled.  (Or you could put a link to the Dell docs about symforce.)\n\nFinally, you might want to add something to the \"upgrade\" section, something like:\n\n```\nupgrade:\n  - |\n    Dell PowerMax Driver: introduced a new configuration option,\n    ``snapvx_unlink_symforce``, to address Bug #2045230.  See the Bug Fixes\n    section for details.\n```","commit_id":"a6e09e3c81066b361898aedb7e59f9190c30a69a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8f3b31f1107b960fc4e5bdcc5a2e6629ba774448","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerMax Driver `Bug #2045230"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2045230\u003e`_: Fixed"},{"line_number":6,"context_line":"    the issue that Dell PowerMax SnapVx link fails as the linked device is not"},{"line_number":7,"context_line":"    yet fully defined."},{"line_number":8,"context_line":"    This is achieved by checking the new configuration ``snapvx_unlink_symforce``"},{"line_number":9,"context_line":"    and the linked device ``defined`` status to determine the value of ``symforce``"},{"line_number":10,"context_line":"    in the payload of SnapVx unlink restcall."},{"line_number":11,"context_line":"    When ``snapvx_unlink_symforce`` is enabled and the linked device is not fully"},{"line_number":12,"context_line":"    defined, proceed unlink symforce operation."},{"line_number":13,"context_line":"    Otherwise, proceed as usual."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1b42c119_ad974edc","line":13,"range":{"start_line":5,"start_character":56,"end_line":13,"end_character":32},"in_reply_to":"c3e5e606_50cb2ede","updated":"2024-03-20 14:31:44.000000000","message":"This looks much better given the end users understand the issue and impact of this fix.\nIf you can update the releasenote, I can vote based on the CI results of previous patchset.","commit_id":"a6e09e3c81066b361898aedb7e59f9190c30a69a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ea35e810322b85480c2319239370b9e57f67359d","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    ``delete volume snapshots``,"},{"line_number":18,"context_line":"    ``revert volume to snapshot``,"},{"line_number":19,"context_line":"    ``create generic volume group from source``,"},{"line_number":20,"context_line":"    ``unmanage volumes``."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"2174cbb2_c5623733","line":20,"updated":"2024-03-20 17:23:21.000000000","message":"I\u0027m not sure that you need these in monospace font, but it\u0027s up to you.  Also, I assume you\u0027re OK with them being arranged in a single paragraph?  You can see how this gets rendered into html here:\nhttps://ae6051574b06c5285369-242e23f01f4a3c50d38acf4a24e0c600.ssl.cf2.rackcdn.com/902262/5/check/build-openstack-releasenotes/21d3ca5/docs/unreleased.html","commit_id":"a4d3b5b170fc2107e7f5a2092bacd3bf4f1f04e3"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"3770646f85896533684a448ce76f745cd5f82619","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    ``delete volume snapshots``,"},{"line_number":18,"context_line":"    ``revert volume to snapshot``,"},{"line_number":19,"context_line":"    ``create generic volume group from source``,"},{"line_number":20,"context_line":"    ``unmanage volumes``."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e38710f1_ecf485e3","line":20,"in_reply_to":"2174cbb2_c5623733","updated":"2024-03-21 13:54:21.000000000","message":"Done.\nThank you, Brian!","commit_id":"a4d3b5b170fc2107e7f5a2092bacd3bf4f1f04e3"}]}