)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"de038789fd96308dd5d27cffe9ed59c71e0ff986","unresolved":true,"context_lines":[{"line_number":14,"context_line":"defined to be 1.47.0."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This change does not affect any of the functionality of the driver"},{"line_number":17,"context_line":"but does affect the minimum required FlashArray operaing system,"},{"line_number":18,"context_line":"increasing this to Purity//FA 6.1.0."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This change will also allow for the addition of new features"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"84eb0808_85da1136","line":17,"range":{"start_line":17,"start_character":48,"end_line":17,"end_character":56},"updated":"2024-05-29 09:07:52.000000000","message":"typo: operating","commit_id":"86265eaeff97e2071643daa9cdcee586f4e3d5e8"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"5202f301d7dd152efff470db09acfd1e7b0249d1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"defined to be 1.47.0."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This change does not affect any of the functionality of the driver"},{"line_number":17,"context_line":"but does affect the minimum required FlashArray operaing system,"},{"line_number":18,"context_line":"increasing this to Purity//FA 6.1.0."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This change will also allow for the addition of new features"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"842575e6_106544ef","line":17,"range":{"start_line":17,"start_character":48,"end_line":17,"end_character":56},"in_reply_to":"84eb0808_85da1136","updated":"2024-05-29 13:52:08.000000000","message":"Done","commit_id":"86265eaeff97e2071643daa9cdcee586f4e3d5e8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"557570c54d0a457fb6ef2f0ff3255d1e50da2253","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a14bf7e7_61493a60","updated":"2024-01-11 20:56:14.000000000","message":"recheck","commit_id":"974429d8a61ecd94553ee67973895d6f75286632"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"9a0b66575d96a27805899f8e04bb6b1e5c7bb641","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fa923460_f1315171","updated":"2024-01-10 20:03:25.000000000","message":"run Pure Storage CI","commit_id":"974429d8a61ecd94553ee67973895d6f75286632"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"90b5a4f4c3adedb2b8814bba5a8e9f3c88c5d906","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"07302c5d_5f4fd0b3","updated":"2024-04-24 02:05:09.000000000","message":"recheck","commit_id":"faf7174bd83bd9f3e37a4c3a5b5c24922fd7a286"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"30fde6df8a26a3086022a6231d86ba69ba2f2310","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"0fd65ba4_a981da33","updated":"2024-04-24 13:26:51.000000000","message":"recheck","commit_id":"faf7174bd83bd9f3e37a4c3a5b5c24922fd7a286"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"d2bf6234e00fa706d13aeddf92c70cef30079102","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2072eae8_333fb206","updated":"2024-04-23 22:56:31.000000000","message":"recheck","commit_id":"faf7174bd83bd9f3e37a4c3a5b5c24922fd7a286"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"929ad71325fc9077f626ab083139fb486c4021fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"196bef75_ebfad4cc","updated":"2024-04-23 20:36:57.000000000","message":"recheck openstack-tox-py311","commit_id":"faf7174bd83bd9f3e37a4c3a5b5c24922fd7a286"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"e9ece897302ca24f676daf4c3f84d0ed898e0fca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"bddc54c5_58008aed","updated":"2024-04-25 00:20:13.000000000","message":"Just one tiny question:\nWhy is it the version of py-pure-client is 1.47.0 in driver-requirements.txt, but is 1.44.0 in setup.cfg? Not sure if this matters.","commit_id":"9d5466a96f5a8a22ea289d70ed56cdf15dfe715f"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"7108308778a2718d1a2ac8b7cbee382fa64990a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"48860503_8effecaa","updated":"2024-04-24 16:45:06.000000000","message":"recheck","commit_id":"9d5466a96f5a8a22ea289d70ed56cdf15dfe715f"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"8ad04429288f7ee1bd11c9c7e3f0bd0a13e25d72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"79fbc88e_9e7edbf5","in_reply_to":"bddc54c5_58008aed","updated":"2024-04-25 00:52:07.000000000","message":"Doesn\u0027t matter, but I\u0027ll change it anyway.","commit_id":"9d5466a96f5a8a22ea289d70ed56cdf15dfe715f"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"9ef1c1821ae98583af7d2a4e607122422a285557","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1a5b3026_8020531d","updated":"2024-04-25 13:37:54.000000000","message":"recheck","commit_id":"02a3199cd5f26f83e57a1aacfc6a4877e1ab0757"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"fd1508821ea503ce3178ed25a35945c7a501e5a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"5a65bb2d_d8a865dc","updated":"2024-04-25 21:56:01.000000000","message":"recheck","commit_id":"02a3199cd5f26f83e57a1aacfc6a4877e1ab0757"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"48698b6002a86545e80b290d51f0d4f75a584b3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"8322732c_44a68ac3","updated":"2024-04-25 16:50:50.000000000","message":"recheck","commit_id":"02a3199cd5f26f83e57a1aacfc6a4877e1ab0757"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"2d666e3fcf73da365f77ee676bc282e008e4d90a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f55603af_90c58548","updated":"2024-04-25 19:25:43.000000000","message":"recheck","commit_id":"02a3199cd5f26f83e57a1aacfc6a4877e1ab0757"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a2d4998b1ea51a0edd775d8fd09fd6d426c103fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1e3c979f_a7be9ffd","updated":"2024-05-22 12:15:48.000000000","message":"Looks like the pep8 and unit test failures are real.","commit_id":"b8d243ec74b735608ad856fa8c0b7157ac158464"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"de038789fd96308dd5d27cffe9ed59c71e0ff986","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"09a9702e_df420c9c","updated":"2024-05-29 09:07:52.000000000","message":"Few minor comments inline","commit_id":"86265eaeff97e2071643daa9cdcee586f4e3d5e8"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"ef1eb8b7525105de8966b2776707bcecd2a88254","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"18083df2_414a59d9","updated":"2024-05-28 18:03:03.000000000","message":"recheck","commit_id":"86265eaeff97e2071643daa9cdcee586f4e3d5e8"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"e91f1f93dc107aff8062fb4fc26f21e697905e61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"2f59a240_a1d0320e","updated":"2024-05-28 21:14:36.000000000","message":"recheck","commit_id":"86265eaeff97e2071643daa9cdcee586f4e3d5e8"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"e713ea8207c8a8bd2311a732c97a79f417674ef8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"be76692a_585939ac","updated":"2024-05-29 00:19:31.000000000","message":"recheck","commit_id":"86265eaeff97e2071643daa9cdcee586f4e3d5e8"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"f263679c8ac68882a845d824dfa440c58369490e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"02c84a05_a5241880","updated":"2024-05-31 12:51:49.000000000","message":"My two minor comments have been addressed.\nHopefully the third comment would be addressed in next patch.\nCode looks good. Zuul has passed. So +1.","commit_id":"839bdf6dcd830719b6cafc7b6430508f84ebb9c6"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"8680362bf7b700dc21cb6cee817ca4e7c0bc4ec0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"2e3f451e_4cf07c27","updated":"2024-06-06 19:03:28.000000000","message":"This looks good to me, code looks fine, tests, release note, CI is passing according to Simon, no issues here.","commit_id":"839bdf6dcd830719b6cafc7b6430508f84ebb9c6"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"b88cc3e614606200a5ad483fc363feedd98b91a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"709e608e_bc6e1f02","updated":"2024-06-12 14:16:28.000000000","message":"With +2\u0027s from Pete, Sean, and myself I think this can go in.","commit_id":"839bdf6dcd830719b6cafc7b6430508f84ebb9c6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"630376bcffcc7e2bbd90912e304d40a1efa6556f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"0efbbd93_ca2c45f1","updated":"2024-06-12 21:00:17.000000000","message":"recheck","commit_id":"839bdf6dcd830719b6cafc7b6430508f84ebb9c6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"659a1d28224f73da5469535653759be8d46810ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"981e4d2b_b39643bc","updated":"2024-06-12 17:32:49.000000000","message":"recheck","commit_id":"839bdf6dcd830719b6cafc7b6430508f84ebb9c6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"1854a1ad254de43b8592643fdbc52dc43925b3b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ae904e7d_b32125be","updated":"2024-06-14 01:12:31.000000000","message":"recheck","commit_id":"839bdf6dcd830719b6cafc7b6430508f84ebb9c6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"8bc5aea4ae2e2ba999ccf548808b0579e71bdbce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"d308e527_ceb95ae5","updated":"2024-06-13 19:02:01.000000000","message":"recheck","commit_id":"839bdf6dcd830719b6cafc7b6430508f84ebb9c6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"944a602f8ba18c4b2d9b7a871ec57b7e61f4fad6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"fd1e20d4_92b47e36","updated":"2024-06-13 12:30:14.000000000","message":"recheck","commit_id":"839bdf6dcd830719b6cafc7b6430508f84ebb9c6"}],"cinder/tests/unit/volume/drivers/test_pure.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"e9ece897302ca24f676daf4c3f84d0ed898e0fca","unresolved":true,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    # Required for python2 compatibility"},{"line_number":165,"context_line":"    next \u003d __next__"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def __len__(self):"},{"line_number":168,"context_line":"        \"\"\"Get the length of collection. Number of items returned is not guaranteed"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3dbb9513_999b5e59","line":166,"updated":"2024-04-25 00:20:13.000000000","message":"Do we even support py2?","commit_id":"9d5466a96f5a8a22ea289d70ed56cdf15dfe715f"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"8ad04429288f7ee1bd11c9c7e3f0bd0a13e25d72","unresolved":true,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    # Required for python2 compatibility"},{"line_number":165,"context_line":"    next \u003d __next__"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def __len__(self):"},{"line_number":168,"context_line":"        \"\"\"Get the length of collection. Number of items returned is not guaranteed"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"45ba5599_d44e89cd","line":166,"in_reply_to":"3dbb9513_999b5e59","updated":"2024-04-25 00:52:07.000000000","message":"This comes as a direct lift from the py-pure-client codebase which still supports Python2.x. I don\u0027t know the implications of removing this. I\u0027ll have a look","commit_id":"9d5466a96f5a8a22ea289d70ed56cdf15dfe715f"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"9ef1c1821ae98583af7d2a4e607122422a285557","unresolved":true,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    # Required for python2 compatibility"},{"line_number":165,"context_line":"    next \u003d __next__"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def __len__(self):"},{"line_number":168,"context_line":"        \"\"\"Get the length of collection. Number of items returned is not guaranteed"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7d42cb1a_6616cf87","line":166,"in_reply_to":"45ba5599_d44e89cd","updated":"2024-04-25 13:37:54.000000000","message":"I removed the offending line","commit_id":"9d5466a96f5a8a22ea289d70ed56cdf15dfe715f"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"ffc657cda70ddedbe7d7cead354e9f279ee7a2f4","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    # Required for python2 compatibility"},{"line_number":165,"context_line":"    next \u003d __next__"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def __len__(self):"},{"line_number":168,"context_line":"        \"\"\"Get the length of collection. Number of items returned is not guaranteed"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"8753878d_b9346bc8","line":166,"in_reply_to":"7d42cb1a_6616cf87","updated":"2024-04-25 13:38:05.000000000","message":"Done","commit_id":"9d5466a96f5a8a22ea289d70ed56cdf15dfe715f"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"757c8dbda7a85e48c0dd24a6650925250a3b1789","unresolved":true,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class Parameters(object):"},{"line_number":60,"context_line":"    \"\"\"A class for static parameter names."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    \"\"\""},{"line_number":63,"context_line":"    continuation_token \u003d \u0027continuation_token\u0027"},{"line_number":64,"context_line":"    filter \u003d \u0027filter\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"619f132e_b710f117","line":61,"updated":"2024-06-10 22:03:26.000000000","message":"nit: Even though it\u0027s copied, it would be nice to remove all these extra empty lines from the docstrings.","commit_id":"839bdf6dcd830719b6cafc7b6430508f84ebb9c6"}],"cinder/volume/drivers/pure.py":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"de038789fd96308dd5d27cffe9ed59c71e0ff986","unresolved":true,"context_lines":[{"line_number":340,"context_line":"                            target_array)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    @pure_driver_debug_trace"},{"line_number":343,"context_line":"    def set_qos(self, array, vol_name, qos):"},{"line_number":344,"context_line":"        if qos[\u0027maxIOPS\u0027] \u003d\u003d \u00270\u0027 and qos[\u0027maxBWS\u0027] \u003d\u003d 0:"},{"line_number":345,"context_line":"            array.patch_volumes(names\u003d[vol_name],"},{"line_number":346,"context_line":"                                volume\u003dflasharray.VolumePatch("}],"source_content_type":"text/x-python","patch_set":14,"id":"dd692ea3_dd8e8a26","line":343,"range":{"start_line":343,"start_character":0,"end_line":343,"end_character":44},"updated":"2024-05-29 09:07:52.000000000","message":"This entire function can also be written as below:\n(i don\u0027t know how to apply indentation while submitting comment here i.e add two/four spaces)\n\nlimit_x \u003d qos[\u0027maxIOPS\u0027]\nlimit_y \u003d qos[\u0027maxBWS\u0027]\n\nif qos[\u0027maxIOPS\u0027] \u003d\u003d 0:\n  limit_x\u003d100000000\nif qos[\u0027maxBWS\u0027] \u003d\u003d 0:\n  limit_y\u003d549755813888\n\narray.patch_volumes(names\u003d[vol_name],\n                    volume\u003dflasharray.VolumePatch(\n                    qos\u003dflasharray.Qos(\n                        iops_limit\u003dlimit_x,\n                        bandwidth_limit\u003dlimit_y)))","commit_id":"86265eaeff97e2071643daa9cdcee586f4e3d5e8"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"5202f301d7dd152efff470db09acfd1e7b0249d1","unresolved":false,"context_lines":[{"line_number":340,"context_line":"                            target_array)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    @pure_driver_debug_trace"},{"line_number":343,"context_line":"    def set_qos(self, array, vol_name, qos):"},{"line_number":344,"context_line":"        if qos[\u0027maxIOPS\u0027] \u003d\u003d \u00270\u0027 and qos[\u0027maxBWS\u0027] \u003d\u003d 0:"},{"line_number":345,"context_line":"            array.patch_volumes(names\u003d[vol_name],"},{"line_number":346,"context_line":"                                volume\u003dflasharray.VolumePatch("}],"source_content_type":"text/x-python","patch_set":14,"id":"c49ed073_6df0fea3","line":343,"range":{"start_line":343,"start_character":0,"end_line":343,"end_character":44},"in_reply_to":"dd692ea3_dd8e8a26","updated":"2024-05-29 13:52:08.000000000","message":"Will address in the next patch","commit_id":"86265eaeff97e2071643daa9cdcee586f4e3d5e8"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"de038789fd96308dd5d27cffe9ed59c71e0ff986","unresolved":true,"context_lines":[{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    @pure_driver_debug_trace"},{"line_number":343,"context_line":"    def set_qos(self, array, vol_name, qos):"},{"line_number":344,"context_line":"        if qos[\u0027maxIOPS\u0027] \u003d\u003d \u00270\u0027 and qos[\u0027maxBWS\u0027] \u003d\u003d 0:"},{"line_number":345,"context_line":"            array.patch_volumes(names\u003d[vol_name],"},{"line_number":346,"context_line":"                                volume\u003dflasharray.VolumePatch("},{"line_number":347,"context_line":"                                    qos\u003dflasharray.Qos("}],"source_content_type":"text/x-python","patch_set":14,"id":"d0b442a5_196a2563","line":344,"range":{"start_line":344,"start_character":28,"end_line":344,"end_character":32},"updated":"2024-05-29 09:07:52.000000000","message":"should this be number 0 instead of string \u00270\u0027 ?","commit_id":"86265eaeff97e2071643daa9cdcee586f4e3d5e8"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"5202f301d7dd152efff470db09acfd1e7b0249d1","unresolved":false,"context_lines":[{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    @pure_driver_debug_trace"},{"line_number":343,"context_line":"    def set_qos(self, array, vol_name, qos):"},{"line_number":344,"context_line":"        if qos[\u0027maxIOPS\u0027] \u003d\u003d \u00270\u0027 and qos[\u0027maxBWS\u0027] \u003d\u003d 0:"},{"line_number":345,"context_line":"            array.patch_volumes(names\u003d[vol_name],"},{"line_number":346,"context_line":"                                volume\u003dflasharray.VolumePatch("},{"line_number":347,"context_line":"                                    qos\u003dflasharray.Qos("}],"source_content_type":"text/x-python","patch_set":14,"id":"6a7ccb52_5ddfa254","line":344,"range":{"start_line":344,"start_character":28,"end_line":344,"end_character":32},"in_reply_to":"d0b442a5_196a2563","updated":"2024-05-29 13:52:08.000000000","message":"Good catch","commit_id":"86265eaeff97e2071643daa9cdcee586f4e3d5e8"}]}