)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"da177844b3d6c671ecd8fd4050efe32312c500bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3a54bc8d_d12aba04","updated":"2024-01-02 11:04:15.000000000","message":"Oops. Yeah, this looks correct to me. Guess we want test coverage for this (in a follow-up).\n\nI said this on IRC also, but I think it would make sense to rename the functions to e.g. `_sync_quotas` and `_sync_project_quotas` and negate and rename the `do_fix` variable to e.g. `dry_run`? As these are, it\u0027s not obvious that they have side-effects.","commit_id":"092040c239ed7149e1710fec3a9678fd15944703"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4655654f2b1cf642429e8ce132158cf744bcd173","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b6a4f19e_918580ee","updated":"2024-01-08 08:34:45.000000000","message":"recheck unrelated failure","commit_id":"092040c239ed7149e1710fec3a9678fd15944703"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"04a49cdff6f0980cbd770779efb4a0505cf59eca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fba80d89_4dc67771","updated":"2025-08-21 16:51:37.000000000","message":"Looks good, discussed in PTG.","commit_id":"bfc71207d21cfe5ccdd07853336505e79006cf4f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"254e8d25a67a018fb0b763865187910f85179d13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f4342b27_dc506217","updated":"2025-04-10 21:42:35.000000000","message":"We discussed this patch at today\u0027s PTG session and decided to merge it with the \u0027writer\u0027 decorator and refactor along the lines discussed in the comments as a possible followup.","commit_id":"bfc71207d21cfe5ccdd07853336505e79006cf4f"}],"cinder/cmd/manage.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8a920ef785d67e8a26293072e68d5845f62f95e8","unresolved":true,"context_lines":[{"line_number":519,"context_line":"        print(\u0027Action successfully completed\u0027)"},{"line_number":520,"context_line":"        return discrepancy"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    @db_api.main_context_manager.writer"},{"line_number":523,"context_line":"    def _check_project_sync(self,"},{"line_number":524,"context_line":"                            ctxt: context.RequestContext,"},{"line_number":525,"context_line":"                            project: str,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3454bc91_f546fdce","line":522,"updated":"2024-01-02 10:59:21.000000000","message":"We might want to take the writer path only when do_fix\u003dTrue, but I don\u0027t think we can make wrappers conditional? so it would have to be done inline, but that exceeds my current sqla knowledge, feel free to improve on this.\n\nat least I verified in an affected deployment that this actually do work in fixing some broken quota values","commit_id":"092040c239ed7149e1710fec3a9678fd15944703"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"108f9ec2e5f3e05385ed8b9056dd553c6d171b80","unresolved":true,"context_lines":[{"line_number":519,"context_line":"        print(\u0027Action successfully completed\u0027)"},{"line_number":520,"context_line":"        return discrepancy"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    @db_api.main_context_manager.writer"},{"line_number":523,"context_line":"    def _check_project_sync(self,"},{"line_number":524,"context_line":"                            ctxt: context.RequestContext,"},{"line_number":525,"context_line":"                            project: str,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bcf740e1_c1ed2d5c","line":522,"in_reply_to":"3454bc91_f546fdce","updated":"2024-01-02 11:05:33.000000000","message":"It\u0027s not possible to drop privileges as far as I\u0027m aware. We probably will need to split this into two methods if we want to take that path.","commit_id":"092040c239ed7149e1710fec3a9678fd15944703"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"daccbb042b683eda3cbd7d5f18be1fe8f5eb39d4","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        print(\u0027Action successfully completed\u0027)"},{"line_number":520,"context_line":"        return discrepancy"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    @db_api.main_context_manager.writer"},{"line_number":523,"context_line":"    def _check_project_sync(self,"},{"line_number":524,"context_line":"                            ctxt: context.RequestContext,"},{"line_number":525,"context_line":"                            project: str,"}],"source_content_type":"text/x-python","patch_set":1,"id":"70b9208b_511ef2f4","line":522,"in_reply_to":"bcf740e1_c1ed2d5c","updated":"2025-04-10 17:33:18.000000000","message":"Done","commit_id":"092040c239ed7149e1710fec3a9678fd15944703"}]}