)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"f3ae3fe5bcb81b9aba9011e15de83450c0ca2931","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f7e7196b_2d3f528a","updated":"2024-01-12 07:30:11.000000000","message":"1] Zuul and Fujitsu ETERNUS CI have passed. Code change look good.\n\n2] If it is helpful, the documentation (fujitsu-eternus-dx-driver.rst) can also be updated.\n\n3] One query inline about UT code.","commit_id":"6c361c86d1c3b2cd82626611f89c1c93fb7fba56"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"230b273a9787ce8cc265ef2b6719ef853231c6e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f474ef99_e0833b59","updated":"2024-01-10 03:44:02.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"6c361c86d1c3b2cd82626611f89c1c93fb7fba56"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"350854d45f198f2663daaf87b55a1e003955521b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"235f06db_786b38a2","updated":"2024-01-17 14:36:56.000000000","message":"Thank you Raghavendra.","commit_id":"7810bf468915dc95043fa90f0f0717ef447968ca"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"3f755c42412ed3f8d82125d9c22a90bc432d2a36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ebe17b0c_1d32fa1d","updated":"2024-01-17 06:31:06.000000000","message":"The documentation and UT code look good.\nThe Zuul and Fujitsu ETERNUS CI have passed on latest patchset (PS 2).","commit_id":"7810bf468915dc95043fa90f0f0717ef447968ca"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"d206c6a269f5942ab59e6a8546281af98c959bda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"63e531cb_57319fb0","updated":"2024-01-29 08:47:21.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"b73c1f02c8a0fd531bd7ae358b36cb3a496ce8f2"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"aa6bd83fc935cc2866aaf8fa8965e6f3e1c4d46c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f2eeb18c_925de3f5","updated":"2024-02-08 10:11:17.000000000","message":"recheck build-openstack-releasenotes","commit_id":"0093f9c6136bd600120d1c687abf7ab55e97f1d4"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"e246bef1b80fab97e63a42f3181cc2125f82171d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2f773c53_65273768","updated":"2024-02-14 10:18:36.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican","commit_id":"0093f9c6136bd600120d1c687abf7ab55e97f1d4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"85ada36e4617bfc3844c88045e58b384aeac460b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8013ea2d_7a571050","updated":"2024-04-19 15:58:11.000000000","message":"from a high level overview, this patch looks good.\nFujitsu CI is passing, one recommendation noted for releasenote.","commit_id":"b044e86f547079656765654d43bfa366e8f7a8e3"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"9382a7c601e3ba91dad5ce4cb92e34588f83d548","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"64919f5b_fe4d8bad","updated":"2024-02-16 03:10:45.000000000","message":"recheck grenade","commit_id":"b044e86f547079656765654d43bfa366e8f7a8e3"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"abbd08fa7f0a62f77e7b13859fbecc22f8abc024","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9d5ba258_c21d282d","updated":"2024-02-15 13:03:53.000000000","message":"recheck openstack-tox-py38","commit_id":"b044e86f547079656765654d43bfa366e8f7a8e3"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"76b229a2b4d8b0b1e3f7e6115f3c80994364c9e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0e904ace_806645a0","updated":"2024-05-07 01:51:02.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"3db8512ca34f4f0304ee6c7556ac9472d37d63be"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"5073039bee85aa91e1141f29f16d1a2fc1eddc44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b994d85d_de8a17a0","updated":"2024-04-30 07:15:14.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"3db8512ca34f4f0304ee6c7556ac9472d37d63be"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"dcb1de6ec8f965940f3551b554dbba2330955abd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e49abdd7_084ab774","updated":"2024-04-29 07:22:12.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"3db8512ca34f4f0304ee6c7556ac9472d37d63be"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"1d5640464c1b1303d76f22267045e3527b5ed39b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3c194b91_ad3b7565","updated":"2024-07-26 20:56:51.000000000","message":"The docs explain why to use CLI and when the API (SMI-S), which is good.","commit_id":"a50b897459d4bba70f1f76ba2a4b3ef0197bcb10"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"05e309be0f860df37366a11b07cfc034b151fc23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0054cdf4_cd995a3e","updated":"2024-08-02 01:16:15.000000000","message":"This patch has been merged. Thank you every one.","commit_id":"a50b897459d4bba70f1f76ba2a4b3ef0197bcb10"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"8e205dcce14e5e56161204283ce6ef64c754199e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"93c043e6_894bd0ed","updated":"2024-06-14 09:28:57.000000000","message":"recheck cinder-plugin-ceph-tempest","commit_id":"a50b897459d4bba70f1f76ba2a4b3ef0197bcb10"}],"cinder/tests/unit/volume/drivers/test_fujitsu_dx.py":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"f3ae3fe5bcb81b9aba9011e15de83450c0ca2931","unresolved":true,"context_lines":[{"line_number":1829,"context_line":"        self.configuration.cinder_eternus_config_file \u003d self.config_file.name"},{"line_number":1830,"context_line":"        self.configuration.safe_get \u003d self.fake_safe_get"},{"line_number":1831,"context_line":"        self.configuration.max_over_subscription_ratio \u003d \u002720.0\u0027"},{"line_number":1832,"context_line":"        self.configuration.fujitsu_use_cli_copy \u003d False"},{"line_number":1833,"context_line":""},{"line_number":1834,"context_line":"        self.mock_object(dx_common.FJDXCommon, \u0027_get_eternus_connection\u0027,"},{"line_number":1835,"context_line":"                         self.fake_eternus_connection)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e6ebb7a1_282e3f6e","line":1832,"updated":"2024-01-12 07:30:11.000000000","message":"For self.configuration.fujitsu_use_cli_copy value as True,\ncan we add UT that would cover new code added in eternus_dx_common.py (from line 812)","commit_id":"6c361c86d1c3b2cd82626611f89c1c93fb7fba56"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"afea883ffddcd05905bed67f200c07eca643660c","unresolved":false,"context_lines":[{"line_number":1829,"context_line":"        self.configuration.cinder_eternus_config_file \u003d self.config_file.name"},{"line_number":1830,"context_line":"        self.configuration.safe_get \u003d self.fake_safe_get"},{"line_number":1831,"context_line":"        self.configuration.max_over_subscription_ratio \u003d \u002720.0\u0027"},{"line_number":1832,"context_line":"        self.configuration.fujitsu_use_cli_copy \u003d False"},{"line_number":1833,"context_line":""},{"line_number":1834,"context_line":"        self.mock_object(dx_common.FJDXCommon, \u0027_get_eternus_connection\u0027,"},{"line_number":1835,"context_line":"                         self.fake_eternus_connection)"}],"source_content_type":"text/x-python","patch_set":1,"id":"148e6851_0f2a1726","line":1832,"in_reply_to":"e6ebb7a1_282e3f6e","updated":"2024-01-17 01:57:52.000000000","message":"Thanks for your review. I\u0027ve updated the documentation, and add new test cases about new code.","commit_id":"6c361c86d1c3b2cd82626611f89c1c93fb7fba56"}],"cinder/volume/drivers/fujitsu/eternus_dx/eternus_dx_common.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"3883d5de0ed9b2eed42f9c74c0ca562963503a86","unresolved":true,"context_lines":[{"line_number":696,"context_line":"                        if self.model_name !\u003d CONSTANTS.DX_S2"},{"line_number":697,"context_line":"                        else CONSTANTS.STOR_CONF)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        volume_size \u003d int(float(snapshot[\u0027volume\u0027][\u0027size\u0027])) * 1024"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        smis_service \u003d self._find_eternus_service(service_name)"},{"line_number":702,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bd02db4d_187cd8da","line":699,"updated":"2024-04-18 22:55:33.000000000","message":"Are you sure that you don\u0027t want this:\n\n    volume_size \u003d int(float(snapshot[\u0027volume\u0027][\u0027size\u0027]) * 1024)","commit_id":"b044e86f547079656765654d43bfa366e8f7a8e3"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"e3afa3bbe477461d7e1d8e8558d352cd7f90b825","unresolved":false,"context_lines":[{"line_number":696,"context_line":"                        if self.model_name !\u003d CONSTANTS.DX_S2"},{"line_number":697,"context_line":"                        else CONSTANTS.STOR_CONF)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        volume_size \u003d int(float(snapshot[\u0027volume\u0027][\u0027size\u0027])) * 1024"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        smis_service \u003d self._find_eternus_service(service_name)"},{"line_number":702,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"15a32d88_3759ec80","line":699,"in_reply_to":"1f637186_b8e514ce","updated":"2024-04-29 03:05:46.000000000","message":"Done","commit_id":"b044e86f547079656765654d43bfa366e8f7a8e3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"85ada36e4617bfc3844c88045e58b384aeac460b","unresolved":true,"context_lines":[{"line_number":696,"context_line":"                        if self.model_name !\u003d CONSTANTS.DX_S2"},{"line_number":697,"context_line":"                        else CONSTANTS.STOR_CONF)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        volume_size \u003d int(float(snapshot[\u0027volume\u0027][\u0027size\u0027])) * 1024"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        smis_service \u003d self._find_eternus_service(service_name)"},{"line_number":702,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"c9ed2d24_1e160910","line":699,"in_reply_to":"bd02db4d_187cd8da","updated":"2024-04-19 15:58:11.000000000","message":"since we convert the first part to int and the second part (1024) is already int, the final value of volume_size will also return an int right?\nint * int \u003d int\nso maybe the change is not needed","commit_id":"b044e86f547079656765654d43bfa366e8f7a8e3"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"65f0c877c2d26ed9bcabb23fae95c8c261b31bed","unresolved":true,"context_lines":[{"line_number":696,"context_line":"                        if self.model_name !\u003d CONSTANTS.DX_S2"},{"line_number":697,"context_line":"                        else CONSTANTS.STOR_CONF)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        volume_size \u003d int(float(snapshot[\u0027volume\u0027][\u0027size\u0027])) * 1024"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        smis_service \u003d self._find_eternus_service(service_name)"},{"line_number":702,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1f637186_b8e514ce","line":699,"in_reply_to":"c9ed2d24_1e160910","updated":"2024-04-24 15:59:44.000000000","message":"This construction is kind of odd, snapshot[\u0027volume\u0027][\u0027size\u0027] is an int already.\n\nI would recommend just changing it to\n\n    volume_size \u003d snapshot[\u0027volume\u0027][\u0027size\u0027] * 1024","commit_id":"b044e86f547079656765654d43bfa366e8f7a8e3"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"1d5640464c1b1303d76f22267045e3527b5ed39b","unresolved":true,"context_lines":[{"line_number":53,"context_line":"    cfg.StrOpt(\u0027cinder_eternus_config_file\u0027,"},{"line_number":54,"context_line":"               default\u003d\u0027/etc/cinder/cinder_fujitsu_eternus_dx.xml\u0027,"},{"line_number":55,"context_line":"               help\u003d\u0027Config file for cinder eternus_dx volume driver.\u0027),"},{"line_number":56,"context_line":"    cfg.BoolOpt(\u0027fujitsu_use_cli_copy\u0027,"},{"line_number":57,"context_line":"                default\u003dFalse,"},{"line_number":58,"context_line":"                help\u003d\u0027If True use CLI command to create snapshot.\u0027),"},{"line_number":59,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"cb0ca8f2_67261181","line":56,"updated":"2024-07-26 20:56:51.000000000","message":"I\u0027m okay with the change of the prefix. In fact even fujitsu_ is unnecessary, I think.","commit_id":"a50b897459d4bba70f1f76ba2a4b3ef0197bcb10"}],"releasenotes/notes/fujitsu-add-cli-copy-1647fb54970a186d.yaml":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"85ada36e4617bfc3844c88045e58b384aeac460b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fujitsu Eternus DX driver: Added cli operations when creating snapshot"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    When creating a snapshot using SMI-S, the \"Copy Scope\" of SnapOPC"},{"line_number":7,"context_line":"    copy-session becomes \"Totally\", resulting in the failure of source volume"},{"line_number":8,"context_line":"    extension."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    To make the volume extendable after creating a snapshot, an additional"},{"line_number":11,"context_line":"    parameter ``fujitsu_use_cli_copy`` is introduced with a default value of"},{"line_number":12,"context_line":"    ``False``."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    * If ``fujitsu_use_cli_copy`` is set to ``False``, create a Snapshot using"},{"line_number":15,"context_line":"      the conventional SMI-S method."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    * If ``fujitsu_use_cli_copy`` is set to ``True``, create a Snapshot using"},{"line_number":18,"context_line":"      the CLI method \"start copy-snap-opc\" with specified \"-source-lba\" and"},{"line_number":19,"context_line":"      \"-destination-lba\". \"Copy Scope\" will be set to \"Extent\", allowing volume"},{"line_number":20,"context_line":"      extension of the source volume."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    Note that ``fujitsu_use_cli_copy`` cannot be set to True when the type of"},{"line_number":23,"context_line":"    target pool is RAID Group."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    See the `Fujitsu ETERNUS DX driver documentation"},{"line_number":26,"context_line":"    \u003chttps://docs.openstack.org/cinder/latest/configuration/block-storage/drivers/fujitsu-eternus-dx-driver.html\u003e`_"},{"line_number":27,"context_line":"    for details."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"2dc947dd_7b22ea4b","line":27,"range":{"start_line":4,"start_character":4,"end_line":27,"end_character":16},"updated":"2024-04-19 15:58:11.000000000","message":"nit: maybe rewrite this with the intent that a cloud operator (with not too much internal knowledge about the Fujitsu driver) will be reading it.\nThey will be more interested in what *impact* does this change bring to their deployment.","commit_id":"b044e86f547079656765654d43bfa366e8f7a8e3"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"e3afa3bbe477461d7e1d8e8558d352cd7f90b825","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fujitsu Eternus DX driver: Added cli operations when creating snapshot"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    When creating a snapshot using SMI-S, the \"Copy Scope\" of SnapOPC"},{"line_number":7,"context_line":"    copy-session becomes \"Totally\", resulting in the failure of source volume"},{"line_number":8,"context_line":"    extension."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    To make the volume extendable after creating a snapshot, an additional"},{"line_number":11,"context_line":"    parameter ``fujitsu_use_cli_copy`` is introduced with a default value of"},{"line_number":12,"context_line":"    ``False``."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    * If ``fujitsu_use_cli_copy`` is set to ``False``, create a Snapshot using"},{"line_number":15,"context_line":"      the conventional SMI-S method."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    * If ``fujitsu_use_cli_copy`` is set to ``True``, create a Snapshot using"},{"line_number":18,"context_line":"      the CLI method \"start copy-snap-opc\" with specified \"-source-lba\" and"},{"line_number":19,"context_line":"      \"-destination-lba\". \"Copy Scope\" will be set to \"Extent\", allowing volume"},{"line_number":20,"context_line":"      extension of the source volume."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    Note that ``fujitsu_use_cli_copy`` cannot be set to True when the type of"},{"line_number":23,"context_line":"    target pool is RAID Group."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    See the `Fujitsu ETERNUS DX driver documentation"},{"line_number":26,"context_line":"    \u003chttps://docs.openstack.org/cinder/latest/configuration/block-storage/drivers/fujitsu-eternus-dx-driver.html\u003e`_"},{"line_number":27,"context_line":"    for details."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"39baac9f_78dddbce","line":27,"range":{"start_line":4,"start_character":4,"end_line":27,"end_character":16},"in_reply_to":"2dc947dd_7b22ea4b","updated":"2024-04-29 03:05:46.000000000","message":"Thank you rajat. I rewrote the release note.","commit_id":"b044e86f547079656765654d43bfa366e8f7a8e3"}]}