)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36630,"name":"Winicius Allan Bezerra da Silva","display_name":"Winicius Allan","email":"winiciusab12@gmail.com","username":"winiciusallan"},"change_message_id":"d8db9dc1efa0b91eab190cd708db41126147fc10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"05ddc876_78988397","updated":"2024-01-11 16:23:23.000000000","message":"LGTM.","commit_id":"308c4fbcc3f3f302ae6dbbf0ac74cb61eb5e610f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d30188468dba42adc3358a4ad77ecfe9006f3120","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a5464618_ed0627df","updated":"2024-01-19 14:23:37.000000000","message":"Thanks for fixing this Walt, can we add a releasenote mentioning the fix and if possible a UT? not sure if we have code coverage for that part.","commit_id":"b4348dadf1213bea583459eabc99264c479b49b5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"839fd0bc4b8883e754a721445cd1976facb6d24b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"74172b65_f2e066f7","updated":"2024-01-19 15:33:15.000000000","message":"one suggestion noted inline","commit_id":"f13baaf6a6d24c59922b36da0008c58080ab667b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"74a5615fa08d0d86e2986cbcf4261d20666f6e14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"23d7096c_bc48893f","updated":"2024-02-13 14:47:34.000000000","message":"This should have a unit test.","commit_id":"d6907cee570723041d958a55a4cf3b5e4f934d38"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3910acd1437384a9c9208961fb35520017ccd2b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"93d9d3d7_86f6279e","updated":"2024-02-05 21:25:18.000000000","message":"adding -1 to highlight my comment","commit_id":"d6907cee570723041d958a55a4cf3b5e4f934d38"}],"releasenotes/notes/fix-readonly-flag-test-64e172113f4d01d0.yaml":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"839fd0bc4b8883e754a721445cd1976facb6d24b","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #2049048 \u003chttps://bugs.launchpad.net/cinder/+bug/2049048\u003e`_: Fixed"},{"line_number":5,"context_line":"    the test for checking the boolean flag in volume_admin_metadata.  The test"},{"line_number":6,"context_line":"    was trying to check for a True value, but the value is a string, so any"},{"line_number":7,"context_line":"    content means the test will be True.  The fix changes the test to convert"},{"line_number":8,"context_line":"    the flag to a boolean first.  This bug has been around for 6+ years."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0b4b58c4_d1a01af2","line":5,"range":{"start_line":5,"start_character":8,"end_line":5,"end_character":12},"updated":"2024-01-19 15:33:15.000000000","message":"test sounds like we are fixing something in the tests, condition might be more suitable\n\nFixed the condition for checking the boolean flag in volume_admin_metadata. The condition was trying to check for a True value, but the value is a string, so any content means the condition will evaluate to True. The fix changes the condition to convert the flag to a boolean first.\n\n\u003cwe might want to omit the part that the bug has been sitting for this long, won\u0027t put a good impression on the users about the health of the project but that\u0027s just my opinion\u003e","commit_id":"f13baaf6a6d24c59922b36da0008c58080ab667b"}]}