)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"dc0e15602764d216568cd0576c0fac2a359ae828","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"aa4729f5_0dfc1f3f","updated":"2024-01-29 19:47:29.000000000","message":"I thought we had a test in place so that this wouldn\u0027t happen ... I need to look into why this stuff slipped through.","commit_id":"53d8dba3f794f66a01908d0245d2e3b1d2df39a5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f5dda4c7be4a8595fb8adcb8a144d9199b2cb105","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4f577ef1_f3b5ee5f","updated":"2024-01-30 14:46:35.000000000","message":"Maybe the thing to do here is drop the releasenotes from this patch, then merge this and Eric\u0027s test patch, and figure out whether to deal with the release notes or not later.","commit_id":"53d8dba3f794f66a01908d0245d2e3b1d2df39a5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b06134047c3de2fb11e245679abc4161d4921bbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"36c6aa32_7649a636","updated":"2024-01-29 12:37:22.000000000","message":"See also,\n    https://review.opendev.org/c/openstack/cinder/+/848759","commit_id":"53d8dba3f794f66a01908d0245d2e3b1d2df39a5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"78e51be09e1c4ddde8f745f9dce2149550737804","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"07a84aa9_976cb265","updated":"2024-01-30 15:40:59.000000000","message":"Thanks, Takashi.  Looks like you are right about reno handling changes to stable branch release notes correctly now:\n\nTaking releasenotes/notes/hitachi-storage-driver-d38dbd990730388d.yaml\n- it\u0027s modified in this patch to master\n- it was added in victoria by https://review.opendev.org/c/openstack/cinder/+/712832\n- the text is \"New Cinder Hitachi driver based on REST API for Hitachi VSP storages.\" for the New Features section.\n\nLooking at the generated releasenotes from this patch:\n- it does not show up in the Current Series\n- it does show up in the Victoria Series in the New Features section for 17.0.0\n\nSo I withdraw my objection.  I think we should go ahead and merge this change, and then merge Eric\u0027s patch that should prevent CRLFs from being introduced by future changes.","commit_id":"53d8dba3f794f66a01908d0245d2e3b1d2df39a5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"113abb98dfdd010304ed9496c3885e5a349cb022","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0fcad987_cb8fedf2","updated":"2024-02-02 12:44:45.000000000","message":"This patch looks good and based on the discussion, we don\u0027t have the reno changes appearing in current release as well. LGTM.","commit_id":"53d8dba3f794f66a01908d0245d2e3b1d2df39a5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7aac992f04c984f6efea1867950a2c66bf8d7d27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8706e2d8_8194c23d","updated":"2024-01-30 14:42:41.000000000","message":"We can\u0027t merge this because the releasenotes change will make them all apply to master.  There\u0027s a way around this, but we need to figure it out first.","commit_id":"53d8dba3f794f66a01908d0245d2e3b1d2df39a5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"46cd269693fe8ce14e22d04c89f53f49d2191333","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c7395fcb_73c8fe69","updated":"2024-01-27 07:55:46.000000000","message":"recheck unrelated failure","commit_id":"53d8dba3f794f66a01908d0245d2e3b1d2df39a5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"418206a09819ee82354af7b15cca3e81f7dc49ac","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3a00f9ff_596ebc7f","in_reply_to":"8706e2d8_8194c23d","updated":"2024-01-30 14:47:51.000000000","message":"That\u0027s what I thought in the past, but I had a discussion with Stephen recently and we later noticed that the issue with reno was fixed a while ago[1] and now reno only adds a note according to the timestamp of addition, instead of one of modification.\n\nThe rendered result may explain the current behavior.\n\n[1] https://github.com/openstack/reno/commit/bcc65c9e846c829158671ccfbcd0308284f2092a","commit_id":"53d8dba3f794f66a01908d0245d2e3b1d2df39a5"}]}