)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"93a1a72951915c15e6bdb49d3a0c1108968b5b57","unresolved":true,"context_lines":[{"line_number":15,"context_line":"viewed in the log."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"In addition, this patch also adds support for SSH keys,"},{"line_number":18,"context_line":"allowing connections to the storage using SSH key."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Closes-Bug: #2048850"},{"line_number":21,"context_line":"Change-Id: I204f3889e3401b142dd7c9a6e11585639585abfc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"0ffbd375_670ae448","line":18,"updated":"2025-02-13 17:46:22.000000000","message":"These are kind of unrelated changes, but this patch has been sitting so long, I\u0027m not going to insist on separating them out.","commit_id":"25f942b9fad1b7fed995c9e67e60a19d719e5446"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"47b5eadc184ce43cb0b6f1113486388247a251f0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"viewed in the log."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"In addition, this patch also adds support for SSH keys,"},{"line_number":18,"context_line":"allowing connections to the storage using SSH key."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Closes-Bug: #2048850"},{"line_number":21,"context_line":"Change-Id: I204f3889e3401b142dd7c9a6e11585639585abfc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7a574f73_b7c628f4","line":18,"in_reply_to":"0ffbd375_670ae448","updated":"2025-02-14 06:42:43.000000000","message":"Thanks for your review.","commit_id":"25f942b9fad1b7fed995c9e67e60a19d719e5446"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"144e92ddca2366d6483cb82d5e65a0a6cb20248e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"089867a8_2596732d","updated":"2024-03-18 09:39:00.000000000","message":"recheck tempest-slow-py3","commit_id":"8ef225e5754d6bd635de2e69c52b4ec3d3106c70"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"fee6e891ef559703cf28e979c507ab5cdf580715","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"09748efe_52633020","updated":"2024-02-18 07:55:56.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"8ef225e5754d6bd635de2e69c52b4ec3d3106c70"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"7c9c57fd93fb110a8980c1a6f22e900e9142540f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bc4a7c83_a5bd737b","updated":"2024-05-07 10:07:13.000000000","message":"recheck tempest-integrated-storage","commit_id":"1bebd0cd4fefca818cf5229463b0f9b1a0fbd3d9"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"3f7c98d64eb3895b0df3e8eeb8eee187867257ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"21c87499_134dca25","updated":"2024-05-08 02:45:56.000000000","message":"recheck tempest-ipv6-only","commit_id":"1bebd0cd4fefca818cf5229463b0f9b1a0fbd3d9"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"816116a733e5e1bf415a5c03512060543f2e6a69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"582ec77d_22239c18","updated":"2024-05-16 03:16:55.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"1bebd0cd4fefca818cf5229463b0f9b1a0fbd3d9"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"576650a936f68587e04fb55fbade2e363c02f234","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a4fe20ea_a04c6230","updated":"2024-05-16 03:57:09.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"1bebd0cd4fefca818cf5229463b0f9b1a0fbd3d9"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b68ca052f121e06184e0b9a7fb5ab0411a00a0a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f9463569_04da8e5d","updated":"2024-08-12 23:02:59.000000000","message":"See comments inline.","commit_id":"69488d722158c8bb19c9e0512ca4d81869b3f283"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"5186c5cfb1a98e7a3ca19a0c74f79f0dfe2fa026","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bc714857_7f0638e5","updated":"2024-06-21 02:32:06.000000000","message":"recheck cinder-plugin-ceph-tempest","commit_id":"69488d722158c8bb19c9e0512ca4d81869b3f283"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"560ca6ed72d34a7738bd126e3602cc707266a7e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d9163edd_8685f736","updated":"2024-06-21 02:31:26.000000000","message":"recheck cinder-plugin-ceph-tempest","commit_id":"69488d722158c8bb19c9e0512ca4d81869b3f283"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"4618e670f3863505fcdbdfc0d8e43e9f1f0ce2f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e9c17ec3_0649f72b","updated":"2024-06-14 09:34:47.000000000","message":"recheck openstack-tox-py311","commit_id":"69488d722158c8bb19c9e0512ca4d81869b3f283"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"596ebb20c1ab7dd3f3ab1f233d1db9569b20346c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f6641900_9cec109a","updated":"2024-06-18 07:52:59.000000000","message":"recheck openstack-tox-py311","commit_id":"69488d722158c8bb19c9e0512ca4d81869b3f283"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"541e37a73183a9c6390458bd9460379af93149b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"30a10b92_2985e736","updated":"2024-06-20 07:41:46.000000000","message":"recheck tempest-integrated-storage","commit_id":"69488d722158c8bb19c9e0512ca4d81869b3f283"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"ee1f0e4dae43a20fa6ea2facfd4c9389b8ba2681","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d3b9fdcd_b565657e","updated":"2024-06-17 07:50:19.000000000","message":"recheck tempest-integrated-storage","commit_id":"69488d722158c8bb19c9e0512ca4d81869b3f283"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"285dfac66296f1e684c8afd06eaa384a80dd5f35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9fe0febd_01755f73","updated":"2024-06-24 03:31:30.000000000","message":"recheck tempest-slow-py3","commit_id":"69488d722158c8bb19c9e0512ca4d81869b3f283"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f0d6ee80ab38509e186a1fff5bda70ddb7fe1bb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5dd16a72_3219cce1","updated":"2024-11-04 21:51:07.000000000","message":"I don\u0027t see any major issues, but there are a few minor ones.","commit_id":"c8fe1ef2287bf1872e8d0fff44ad4e5c2c3427e5"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"f283528e65c44301e9d6bf95dae06da7a51d70bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"16dc1740_f2815ac8","updated":"2024-08-27 08:03:47.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"c8fe1ef2287bf1872e8d0fff44ad4e5c2c3427e5"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"4608d8a851d7889c5d1ee64b05cfe3ff0d741933","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"56fadb45_55be80cd","updated":"2024-08-28 01:37:05.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"c8fe1ef2287bf1872e8d0fff44ad4e5c2c3427e5"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"3f5d7b7ce0e27b649e45029f104eedd61acf2a7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"59766472_99f17ac7","updated":"2024-08-27 10:52:08.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"c8fe1ef2287bf1872e8d0fff44ad4e5c2c3427e5"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"4224f22faf48fb32995bc994d92acd391e4e31ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a40aabe9_533532a5","updated":"2024-08-28 02:31:39.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"c8fe1ef2287bf1872e8d0fff44ad4e5c2c3427e5"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"3a1398d73c16501cd821fc60bb926ec1fac31907","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d931b27e_0df1c32a","updated":"2024-12-03 08:16:44.000000000","message":"recheck openstack-tox-py39","commit_id":"b040bffa434f3bf54ea5a3997f6753912ca643a2"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"287f0f434aebca8a0f549d7afd0e204e6620d9cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"14ca22f3_4d9a22d6","updated":"2024-12-11 01:38:21.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"b040bffa434f3bf54ea5a3997f6753912ca643a2"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"9cc2b52f30b62a51dcf34e75efaa9098f8787228","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1dad24aa_b75fe81f","updated":"2024-12-10 05:35:06.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"b040bffa434f3bf54ea5a3997f6753912ca643a2"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"516b7a628ac55473389ede6ebbe83b9f1891111f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3d69410e_13054737","updated":"2024-12-11 06:32:14.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"b040bffa434f3bf54ea5a3997f6753912ca643a2"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"e1e1b5910586b15ef48c0c2917a09ab6a1ca994f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"68f15d2b_1bfb64fc","updated":"2024-12-03 08:29:55.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"b040bffa434f3bf54ea5a3997f6753912ca643a2"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"5d123362478366d0f492133c510e789541e41ccc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a9af103b_e37526d0","updated":"2024-12-04 05:57:02.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"b040bffa434f3bf54ea5a3997f6753912ca643a2"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"a39a6c360268f72e0d61e1593a02f1afc4003593","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ab73038c_ef756457","updated":"2024-12-10 09:01:57.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"b040bffa434f3bf54ea5a3997f6753912ca643a2"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"178d6b7de43abeb8adf20fcd57a5f00a92c524e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"cd6e37e1_2325e687","updated":"2024-12-03 08:16:11.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"b040bffa434f3bf54ea5a3997f6753912ca643a2"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"7a258459d18c8ebb413f559967988df4cf3c18fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d559a09b_8d29db2d","updated":"2024-12-05 01:18:33.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"b040bffa434f3bf54ea5a3997f6753912ca643a2"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"a256021ecb354e4e7d75284aae9f2215b40c82e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f21e49f5_c7e5144e","updated":"2024-12-04 02:18:28.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"b040bffa434f3bf54ea5a3997f6753912ca643a2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"93a1a72951915c15e6bdb49d3a0c1108968b5b57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"acf513a2_872f5739","updated":"2025-02-13 17:46:22.000000000","message":"Code and tests look fine.  Only a +1 because I think you need to revise the release note (but not a -1 because I don\u0027t want to discourage other people from reviewing).","commit_id":"25f942b9fad1b7fed995c9e67e60a19d719e5446"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"e0d7241e838cadb373881f5a32a64525563c227b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"bc70b35f_af4c28fb","updated":"2024-12-12 01:37:49.000000000","message":"recheck devstack-plugin-nfs-tempest-full","commit_id":"25f942b9fad1b7fed995c9e67e60a19d719e5446"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"24658c776ff2529401437ce85d490b26e880f858","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e192191c_2052d70b","updated":"2024-12-12 05:38:31.000000000","message":"recheck tempest-integrated-storage","commit_id":"25f942b9fad1b7fed995c9e67e60a19d719e5446"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"81fd8f6b490bdad0bf31d2676621b3de5b9cd7e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"31251544_9d418975","updated":"2024-12-31 06:32:27.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"25f942b9fad1b7fed995c9e67e60a19d719e5446"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"bfa68eb8220bffab1aa218d0ca9870f2d3b84787","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7a3bb3a7_39438b5d","updated":"2024-12-18 05:50:59.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"25f942b9fad1b7fed995c9e67e60a19d719e5446"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"b49ca4eaaa04074d1d298f67a2681dd429df0873","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8c3095f7_c4e65288","updated":"2024-12-20 05:40:40.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"25f942b9fad1b7fed995c9e67e60a19d719e5446"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"25ac5ae2b5898c3ec59ecae28df4048c99b9f968","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"90a1d608_44ae9716","updated":"2024-12-31 03:27:08.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"25f942b9fad1b7fed995c9e67e60a19d719e5446"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"54fd6aa07cd9a0dc404a8ad92420a4fdff9b8392","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"bdba040a_1790cf79","updated":"2024-12-12 05:39:26.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"25f942b9fad1b7fed995c9e67e60a19d719e5446"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"526d7dbed4c3e80f210a45b229dfa101514769fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"be0e042b_8e5f98e5","updated":"2024-12-12 01:37:22.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"25f942b9fad1b7fed995c9e67e60a19d719e5446"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"dfff0f8ed3c77f458d5ac1f7540009d8928fb562","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c7e6e24a_94d5dfa2","updated":"2024-12-30 02:46:49.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"25f942b9fad1b7fed995c9e67e60a19d719e5446"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"0c6f081bdf6ad7ddc6b3afe131192a4ca30a8d1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"dfae794d_0aaa4059","updated":"2024-12-30 05:56:10.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"25f942b9fad1b7fed995c9e67e60a19d719e5446"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"f1d9b040b8d0dd69becd19e9ad50ce982fdcd90d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ef4b4dbd_d32ba772","updated":"2024-12-12 05:35:18.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"25f942b9fad1b7fed995c9e67e60a19d719e5446"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"c39974ee6770216e99134a1eba29001454d6a067","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f121c661_34038b77","updated":"2024-12-30 09:29:36.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"25f942b9fad1b7fed995c9e67e60a19d719e5446"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b45fbfccec835b1a0001fd4f91fd0357f7648f5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"98487e16_3ab4e0b7","updated":"2025-02-14 13:46:28.000000000","message":"Revised release note LGTM.  There were no functional changes on this patch since the last time it had clean CI.","commit_id":"6adc73299b1ec16916f8dfe89a60714eaae9b447"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"ec9566202b2c26f4edf09a88254895baa62e4faa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0d446a41_7e550370","updated":"2025-02-19 00:24:15.000000000","message":"This patch has been merged. Thank you everyone","commit_id":"6adc73299b1ec16916f8dfe89a60714eaae9b447"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e2759f084d01c057040d63d786408bf2c873e86a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"aaf96bc6_00e20d73","updated":"2025-02-18 11:15:40.000000000","message":"main changes are introducing support for connecting to storage array via ssh and a bunch of error codes. Ideally both changes should be different but given the number of changes fujitsu has open and our review bandwidth, i won\u0027t flag this patch for that.\n\nfujitsu iscsi and fc CI are passing. LGTM.","commit_id":"6adc73299b1ec16916f8dfe89a60714eaae9b447"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"aefafc9aae8bcd2e5aa1c6009fb0ca4b0aa76233","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"82cd9d71_d9177a69","updated":"2025-02-14 08:59:28.000000000","message":"recheck cinder-plugin-ceph-tempest","commit_id":"6adc73299b1ec16916f8dfe89a60714eaae9b447"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"971916c91a363c66b84945dcdbe50202ebff175a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8ccfedbb_6dfe0684","updated":"2025-02-17 01:09:52.000000000","message":"recheck cinder-plugin-ceph-tempest","commit_id":"6adc73299b1ec16916f8dfe89a60714eaae9b447"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"afdb8254e3ffc47b7b2c1c8d9b2cef2da658b536","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8475378a_c6c54c62","updated":"2025-02-14 13:25:51.000000000","message":"recheck cinder-plugin-ceph-tempest - oom_reaper killed mysqld, causing db connection errors in some tests","commit_id":"6adc73299b1ec16916f8dfe89a60714eaae9b447"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"71634051554f60bc6f26402c2ccb1dd244640a45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"dc7bf8c1_20911abb","updated":"2025-02-14 22:55:08.000000000","message":"recheck devstack-plugin-nfs-tempest-full - bunch of timeouts","commit_id":"6adc73299b1ec16916f8dfe89a60714eaae9b447"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"d325e8dd88107a2547a4a7e67af6d1aac8b12cf7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"244361e6_fa31858e","updated":"2025-02-17 03:42:11.000000000","message":"recheck grenade","commit_id":"6adc73299b1ec16916f8dfe89a60714eaae9b447"}],"cinder/volume/drivers/fujitsu/eternus_dx/eternus_dx_cli.py":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f0d6ee80ab38509e186a1fff5bda70ddb7fe1bb0","unresolved":true,"context_lines":[{"line_number":165,"context_line":"        try:"},{"line_number":166,"context_line":"            rc \u003d output[\u0027rc\u0027]"},{"line_number":167,"context_line":"            if rc !\u003d \u00270\u0027:"},{"line_number":168,"context_line":"                raise Exception(\u0027_show_cli_error_message fails.\u0027)"},{"line_number":169,"context_line":"            message \u003d output[\u0027message\u0027][1]"},{"line_number":170,"context_line":"            output[\u0027message\u0027] \u003d message.split(\u0027\\t\u0027)[1]"},{"line_number":171,"context_line":"            return output"}],"source_content_type":"text/x-python","patch_set":7,"id":"68a46201_2d6be0b0","line":168,"updated":"2024-11-04 21:51:07.000000000","message":"You should probably include the \u0027rc\u0027 value in the exception message.","commit_id":"c8fe1ef2287bf1872e8d0fff44ad4e5c2c3427e5"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"e5fa3082aca61ed61f25990e4347bf2c2101211a","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        try:"},{"line_number":166,"context_line":"            rc \u003d output[\u0027rc\u0027]"},{"line_number":167,"context_line":"            if rc !\u003d \u00270\u0027:"},{"line_number":168,"context_line":"                raise Exception(\u0027_show_cli_error_message fails.\u0027)"},{"line_number":169,"context_line":"            message \u003d output[\u0027message\u0027][1]"},{"line_number":170,"context_line":"            output[\u0027message\u0027] \u003d message.split(\u0027\\t\u0027)[1]"},{"line_number":171,"context_line":"            return output"}],"source_content_type":"text/x-python","patch_set":7,"id":"4da8d678_6786d0ba","line":168,"in_reply_to":"68a46201_2d6be0b0","updated":"2024-12-03 05:18:45.000000000","message":"Done","commit_id":"c8fe1ef2287bf1872e8d0fff44ad4e5c2c3427e5"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f0d6ee80ab38509e186a1fff5bda70ddb7fe1bb0","unresolved":true,"context_lines":[{"line_number":169,"context_line":"            message \u003d output[\u0027message\u0027][1]"},{"line_number":170,"context_line":"            output[\u0027message\u0027] \u003d message.split(\u0027\\t\u0027)[1]"},{"line_number":171,"context_line":"            return output"},{"line_number":172,"context_line":"        except Exception as e:"},{"line_number":173,"context_line":"            raise Exception(e)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def _create_error_message(self, code, msg):"},{"line_number":176,"context_line":"        \"\"\"Create error code and message using arguements.\"\"\""},{"line_number":177,"context_line":"        message \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"51e35ecf_1b5be841","line":174,"range":{"start_line":172,"start_character":0,"end_line":174,"end_character":1},"updated":"2024-11-04 21:51:07.000000000","message":"These two lines don\u0027t do anything useful and should be eliminated.","commit_id":"c8fe1ef2287bf1872e8d0fff44ad4e5c2c3427e5"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"e5fa3082aca61ed61f25990e4347bf2c2101211a","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            message \u003d output[\u0027message\u0027][1]"},{"line_number":170,"context_line":"            output[\u0027message\u0027] \u003d message.split(\u0027\\t\u0027)[1]"},{"line_number":171,"context_line":"            return output"},{"line_number":172,"context_line":"        except Exception as e:"},{"line_number":173,"context_line":"            raise Exception(e)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def _create_error_message(self, code, msg):"},{"line_number":176,"context_line":"        \"\"\"Create error code and message using arguements.\"\"\""},{"line_number":177,"context_line":"        message \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"c203e0c9_d6854cc8","line":174,"range":{"start_line":172,"start_character":0,"end_line":174,"end_character":1},"in_reply_to":"51e35ecf_1b5be841","updated":"2024-12-03 05:18:45.000000000","message":"Done","commit_id":"c8fe1ef2287bf1872e8d0fff44ad4e5c2c3427e5"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f0d6ee80ab38509e186a1fff5bda70ddb7fe1bb0","unresolved":true,"context_lines":[{"line_number":182,"context_line":"            }"},{"line_number":183,"context_line":"            message \u003d self._show_cli_error_message(**option)[\u0027message\u0027]"},{"line_number":184,"context_line":"        except Exception:"},{"line_number":185,"context_line":"            if rc in CONSTANTS.CLIRETCODE_dic:"},{"line_number":186,"context_line":"                message \u003d CONSTANTS.CLIRETCODE_dic[rc]"},{"line_number":187,"context_line":"            else:"},{"line_number":188,"context_line":"                message \u003d msg"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        return rc, message"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"6cbe5bdd_65fc124f","line":188,"range":{"start_line":185,"start_character":0,"end_line":188,"end_character":29},"updated":"2024-11-04 21:51:07.000000000","message":"I think L185..L188 could be simplified:\n\n            message \u003d CONSTANTS.CLIRETCODE_dic.get(rc, msg)","commit_id":"c8fe1ef2287bf1872e8d0fff44ad4e5c2c3427e5"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"e5fa3082aca61ed61f25990e4347bf2c2101211a","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            }"},{"line_number":183,"context_line":"            message \u003d self._show_cli_error_message(**option)[\u0027message\u0027]"},{"line_number":184,"context_line":"        except Exception:"},{"line_number":185,"context_line":"            if rc in CONSTANTS.CLIRETCODE_dic:"},{"line_number":186,"context_line":"                message \u003d CONSTANTS.CLIRETCODE_dic[rc]"},{"line_number":187,"context_line":"            else:"},{"line_number":188,"context_line":"                message \u003d msg"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        return rc, message"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"38c102c5_a7ee2961","line":188,"range":{"start_line":185,"start_character":0,"end_line":188,"end_character":29},"in_reply_to":"6cbe5bdd_65fc124f","updated":"2024-12-03 05:18:45.000000000","message":"Done","commit_id":"c8fe1ef2287bf1872e8d0fff44ad4e5c2c3427e5"}],"cinder/volume/drivers/fujitsu/eternus_dx/eternus_dx_common.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"cc45c4dd48b296a8f89968c7599adddaaab8eae0","unresolved":true,"context_lines":[{"line_number":60,"context_line":"               default\u003d\u0027/etc/cinder/cinder_fujitsu_eternus_dx.xml\u0027,"},{"line_number":61,"context_line":"               help\u003d\u0027Config file for cinder eternus_dx volume driver.\u0027),"},{"line_number":62,"context_line":"    cfg.BoolOpt(\u0027fujitsu_passwordless\u0027,"},{"line_number":63,"context_line":"                default\u003dTrue,"},{"line_number":64,"context_line":"                help\u003d\u0027Use SSH key/password to connect to storage.\u0027),"},{"line_number":65,"context_line":"    cfg.StrOpt(\u0027fujitsu_private_key_path\u0027,"},{"line_number":66,"context_line":"               default\u003d\u0027$state_path/eternus\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"69f09cdf_5c4f5d35","line":63,"updated":"2024-04-24 16:08:34.000000000","message":"Won\u0027t defaulting this to True break existing deployments when they update, because the key won\u0027t necessarily be present?","commit_id":"8db32bff70797191db8bc571aa917b1c7f890835"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"85e4b3588dee3ac2788f55b362d98db78d2c9ae0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"               default\u003d\u0027/etc/cinder/cinder_fujitsu_eternus_dx.xml\u0027,"},{"line_number":61,"context_line":"               help\u003d\u0027Config file for cinder eternus_dx volume driver.\u0027),"},{"line_number":62,"context_line":"    cfg.BoolOpt(\u0027fujitsu_passwordless\u0027,"},{"line_number":63,"context_line":"                default\u003dTrue,"},{"line_number":64,"context_line":"                help\u003d\u0027Use SSH key/password to connect to storage.\u0027),"},{"line_number":65,"context_line":"    cfg.StrOpt(\u0027fujitsu_private_key_path\u0027,"},{"line_number":66,"context_line":"               default\u003d\u0027$state_path/eternus\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7b7a1bb6_e34389c4","line":63,"in_reply_to":"69f09cdf_5c4f5d35","updated":"2024-05-07 07:40:24.000000000","message":"It is recommended to connect to ETERNUS by public key, so we changed it to default from this version.\nWe recommend changing the connection method to public key in version up, but in case it is not possible,\nyou can add this option and set it to \"false\" to be compatible with the previous version.","commit_id":"8db32bff70797191db8bc571aa917b1c7f890835"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b68ca052f121e06184e0b9a7fb5ab0411a00a0a2","unresolved":true,"context_lines":[{"line_number":55,"context_line":"               help\u003d\u0027Config file for cinder eternus_dx volume driver.\u0027),"},{"line_number":56,"context_line":"    cfg.BoolOpt(\u0027fujitsu_passwordless\u0027,"},{"line_number":57,"context_line":"                default\u003dTrue,"},{"line_number":58,"context_line":"                help\u003d\u0027Use SSH key/password to connect to storage.\u0027),"},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027fujitsu_private_key_path\u0027,"},{"line_number":60,"context_line":"               default\u003d\u0027$state_path/eternus\u0027,"},{"line_number":61,"context_line":"               help\u003d\u0027Default path of private key.\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"53cda8ae_8a530b30","line":58,"updated":"2024-08-12 23:02:59.000000000","message":"Two comments:\n\n1. I share Eric\u0027s concern about the default value.  I understand that you want to encourage people to use the ssh key, but this will break people on upgrade.  I\u0027m inclined to say make this False, but add an \"Upgrade\" section to the release note that advertises the new config opts.   You could also add a \"Security\" section saying that you now support ssh key access to the backend instead of using a password from the config file.\n\n2. I think the help text should mention that the other option must be set when this is True.  Also, \"Use SSH key/password\" is a bit misleading ... I suggest just saying \"Use SSH key to connect to storage\".\n\nIf you disagree about #1, we can discuss it at the weekly cinder meeting.","commit_id":"69488d722158c8bb19c9e0512ca4d81869b3f283"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"30d6fdfbd3daab12f697d4877c694ab9c3ebd087","unresolved":false,"context_lines":[{"line_number":55,"context_line":"               help\u003d\u0027Config file for cinder eternus_dx volume driver.\u0027),"},{"line_number":56,"context_line":"    cfg.BoolOpt(\u0027fujitsu_passwordless\u0027,"},{"line_number":57,"context_line":"                default\u003dTrue,"},{"line_number":58,"context_line":"                help\u003d\u0027Use SSH key/password to connect to storage.\u0027),"},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027fujitsu_private_key_path\u0027,"},{"line_number":60,"context_line":"               default\u003d\u0027$state_path/eternus\u0027,"},{"line_number":61,"context_line":"               help\u003d\u0027Default path of private key.\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"01ff7dce_1d8e4aa0","line":58,"in_reply_to":"53cda8ae_8a530b30","updated":"2024-08-26 02:27:00.000000000","message":"Thanks for your review. Since it is more secure to use SSH key for authentication than password, and our customers commonly use SSH keys for access rather than passwords for authentication when deploying in the field, I thought it might be more realistic to set the default value of fujitsu_passwordless to True.\nI understand your concern about the current default value, so we have also provided details on this point in the release note and the guide.","commit_id":"69488d722158c8bb19c9e0512ca4d81869b3f283"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b68ca052f121e06184e0b9a7fb5ab0411a00a0a2","unresolved":true,"context_lines":[{"line_number":58,"context_line":"                help\u003d\u0027Use SSH key/password to connect to storage.\u0027),"},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027fujitsu_private_key_path\u0027,"},{"line_number":60,"context_line":"               default\u003d\u0027$state_path/eternus\u0027,"},{"line_number":61,"context_line":"               help\u003d\u0027Default path of private key.\u0027),"},{"line_number":62,"context_line":"    cfg.BoolOpt(\u0027fujitsu_use_cli_copy\u0027,"},{"line_number":63,"context_line":"                default\u003dFalse,"},{"line_number":64,"context_line":"                help\u003d\u0027If True use CLI command to create snapshot.\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"0deb0c5b_5ec666ce","line":61,"updated":"2024-08-12 23:02:59.000000000","message":"It\u0027s not really a default path, it\u0027s the path to the private key.  Also, it\u0027s the full pathname of the file, right?  Might be worth saying that so it\u0027s clear that you\u0027re not specifying a directory where the driver will look for the key -- it must be the full pathname of the file containing the private key.","commit_id":"69488d722158c8bb19c9e0512ca4d81869b3f283"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"30d6fdfbd3daab12f697d4877c694ab9c3ebd087","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                help\u003d\u0027Use SSH key/password to connect to storage.\u0027),"},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027fujitsu_private_key_path\u0027,"},{"line_number":60,"context_line":"               default\u003d\u0027$state_path/eternus\u0027,"},{"line_number":61,"context_line":"               help\u003d\u0027Default path of private key.\u0027),"},{"line_number":62,"context_line":"    cfg.BoolOpt(\u0027fujitsu_use_cli_copy\u0027,"},{"line_number":63,"context_line":"                default\u003dFalse,"},{"line_number":64,"context_line":"                help\u003d\u0027If True use CLI command to create snapshot.\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9c4759fa_0b60d57b","line":61,"in_reply_to":"0deb0c5b_5ec666ce","updated":"2024-08-26 02:27:00.000000000","message":"Done","commit_id":"69488d722158c8bb19c9e0512ca4d81869b3f283"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b68ca052f121e06184e0b9a7fb5ab0411a00a0a2","unresolved":true,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        self.conn \u003d None"},{"line_number":108,"context_line":"        self.passwordless \u003d self.configuration.fujitsu_passwordless"},{"line_number":109,"context_line":"        self.private_key_path \u003d self.configuration.fujitsu_private_key_path"},{"line_number":110,"context_line":"        self.use_cli_copy \u003d self.configuration.fujitsu_use_cli_copy"},{"line_number":111,"context_line":"        self.fjdxcli \u003d {}"},{"line_number":112,"context_line":"        self.model_name \u003d self._get_eternus_model()"}],"source_content_type":"text/x-python","patch_set":6,"id":"1eb610c2_30cbc67a","line":109,"updated":"2024-08-12 23:02:59.000000000","message":"I think it would be a good idea to add a check to make sure you can find the key to either do_setup() or check_for_setup_error().  You can poke around in the other drivers to see how they handle this.\n\nhttps://opendev.org/openstack/cinder/src/commit/221a66940ebbba97ecfc4f8830cea50adb3a97a3/cinder/interface/volume_driver.py#L31","commit_id":"69488d722158c8bb19c9e0512ca4d81869b3f283"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"30d6fdfbd3daab12f697d4877c694ab9c3ebd087","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        self.conn \u003d None"},{"line_number":108,"context_line":"        self.passwordless \u003d self.configuration.fujitsu_passwordless"},{"line_number":109,"context_line":"        self.private_key_path \u003d self.configuration.fujitsu_private_key_path"},{"line_number":110,"context_line":"        self.use_cli_copy \u003d self.configuration.fujitsu_use_cli_copy"},{"line_number":111,"context_line":"        self.fjdxcli \u003d {}"},{"line_number":112,"context_line":"        self.model_name \u003d self._get_eternus_model()"}],"source_content_type":"text/x-python","patch_set":6,"id":"fc48152c_c793fa5b","line":109,"in_reply_to":"04ec655b_8359f9a2","updated":"2024-08-26 02:27:00.000000000","message":"Thanks for your advice. I added check_for_setup_error in the patch 910495, so I will add the check in that patch when rebase.","commit_id":"69488d722158c8bb19c9e0512ca4d81869b3f283"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ebdec43085b484ed950715eb23acd75da9132a02","unresolved":true,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        self.conn \u003d None"},{"line_number":108,"context_line":"        self.passwordless \u003d self.configuration.fujitsu_passwordless"},{"line_number":109,"context_line":"        self.private_key_path \u003d self.configuration.fujitsu_private_key_path"},{"line_number":110,"context_line":"        self.use_cli_copy \u003d self.configuration.fujitsu_use_cli_copy"},{"line_number":111,"context_line":"        self.fjdxcli \u003d {}"},{"line_number":112,"context_line":"        self.model_name \u003d self._get_eternus_model()"}],"source_content_type":"text/x-python","patch_set":6,"id":"04ec655b_8359f9a2","line":109,"in_reply_to":"1eb610c2_30cbc67a","updated":"2024-08-13 12:04:13.000000000","message":"Just want to add, this check could be added in a followup.  Presumably what will happen now is that there will be the same failure you get if you are using the password and it\u0027s incorrect in the file, and I\u0027m assuming that you handle that gracefully.  So as long as an un-found ssh key doesn\u0027t blow up in a bad way, I\u0027m ok with a followup patch.","commit_id":"69488d722158c8bb19c9e0512ca4d81869b3f283"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f0d6ee80ab38509e186a1fff5bda70ddb7fe1bb0","unresolved":true,"context_lines":[{"line_number":3001,"context_line":"                          \u0027retdata\u0027: retdata})"},{"line_number":3002,"context_line":""},{"line_number":3003,"context_line":"                LOG.error(msg)"},{"line_number":3004,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":3005,"context_line":"            else:"},{"line_number":3006,"context_line":"                LOG.warning(\u0027_exec_eternus_cli, Retry was exceeded.\u0027)"},{"line_number":3007,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"0520f076_1a520665","side":"PARENT","line":3004,"updated":"2024-11-04 21:51:07.000000000","message":"It looks like the new code never raises an exception. Is that intentional?","commit_id":"68590efa06728eb74bf8ab1b32693817939fea57"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"e5fa3082aca61ed61f25990e4347bf2c2101211a","unresolved":false,"context_lines":[{"line_number":3001,"context_line":"                          \u0027retdata\u0027: retdata})"},{"line_number":3002,"context_line":""},{"line_number":3003,"context_line":"                LOG.error(msg)"},{"line_number":3004,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":3005,"context_line":"            else:"},{"line_number":3006,"context_line":"                LOG.warning(\u0027_exec_eternus_cli, Retry was exceeded.\u0027)"},{"line_number":3007,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"88eaeefc_e4d67ca1","side":"PARENT","line":3004,"in_reply_to":"0520f076_1a520665","updated":"2024-12-03 05:18:45.000000000","message":"Yes, in the new code, we raise exceptions in the CLI functions or upper-level functions.","commit_id":"68590efa06728eb74bf8ab1b32693817939fea57"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"386d520930ad124e4d488a19f9074f67b1f21770","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    cfg.BoolOpt(\u0027fujitsu_passwordless\u0027,"},{"line_number":57,"context_line":"                default\u003dTrue,"},{"line_number":58,"context_line":"                help\u003d\u0027Use SSH key to connect to storage.\u0027),"},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027fujitsu_private_key_path\u0027,"},{"line_number":60,"context_line":"               default\u003d\u0027$state_path/eternus\u0027,"},{"line_number":61,"context_line":"               help\u003d\u0027Filename of private key for ETERNUS CLI. \u0027"},{"line_number":62,"context_line":"                    \u0027This option must be set when \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"38137dcf_51a0a671","line":59,"updated":"2024-11-04 21:59:06.000000000","message":"You should use existing san_XXX options whenever possible. For example, you could use \"san_private_key\" [1]\n\n[1] https://opendev.org/openstack/cinder/src/commit/3e0705f6b4c340ff9f0e1604cd01402a60b5949e/cinder/volume/drivers/san/san.py#L53","commit_id":"c8fe1ef2287bf1872e8d0fff44ad4e5c2c3427e5"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c97cf600e5b9e191dc266e51974f3827353c2034","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    cfg.BoolOpt(\u0027fujitsu_passwordless\u0027,"},{"line_number":57,"context_line":"                default\u003dTrue,"},{"line_number":58,"context_line":"                help\u003d\u0027Use SSH key to connect to storage.\u0027),"},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027fujitsu_private_key_path\u0027,"},{"line_number":60,"context_line":"               default\u003d\u0027$state_path/eternus\u0027,"},{"line_number":61,"context_line":"               help\u003d\u0027Filename of private key for ETERNUS CLI. \u0027"},{"line_number":62,"context_line":"                    \u0027This option must be set when \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"faa91294_e474e897","line":59,"in_reply_to":"215503fa_f2f84939","updated":"2024-12-03 12:29:45.000000000","message":"We encourage using existing san_XXX options to avoid having each driver define their own. Run \"fgrep -rl san_ip cinder/volume/drivers\" and find a large number of drivers use san_ip.","commit_id":"c8fe1ef2287bf1872e8d0fff44ad4e5c2c3427e5"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"e5fa3082aca61ed61f25990e4347bf2c2101211a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    cfg.BoolOpt(\u0027fujitsu_passwordless\u0027,"},{"line_number":57,"context_line":"                default\u003dTrue,"},{"line_number":58,"context_line":"                help\u003d\u0027Use SSH key to connect to storage.\u0027),"},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027fujitsu_private_key_path\u0027,"},{"line_number":60,"context_line":"               default\u003d\u0027$state_path/eternus\u0027,"},{"line_number":61,"context_line":"               help\u003d\u0027Filename of private key for ETERNUS CLI. \u0027"},{"line_number":62,"context_line":"                    \u0027This option must be set when \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"215503fa_f2f84939","line":59,"in_reply_to":"38137dcf_51a0a671","updated":"2024-12-03 05:18:45.000000000","message":"Our driver is Fujitsu Eternus Driver, so I think the name of option should be fujitsu_xxx rather than san_XXX which used in SAN driver.","commit_id":"c8fe1ef2287bf1872e8d0fff44ad4e5c2c3427e5"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"72b0ee949d5c01c08f17dc93c3b6dacd5a7a171e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    cfg.BoolOpt(\u0027fujitsu_passwordless\u0027,"},{"line_number":57,"context_line":"                default\u003dTrue,"},{"line_number":58,"context_line":"                help\u003d\u0027Use SSH key to connect to storage.\u0027),"},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027fujitsu_private_key_path\u0027,"},{"line_number":60,"context_line":"               default\u003d\u0027$state_path/eternus\u0027,"},{"line_number":61,"context_line":"               help\u003d\u0027Filename of private key for ETERNUS CLI. \u0027"},{"line_number":62,"context_line":"                    \u0027This option must be set when \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"346f0aca_105b38de","line":59,"in_reply_to":"faa91294_e474e897","updated":"2024-12-18 05:22:17.000000000","message":"Due to the widespread use of the current parameter name at customer filed, changing it could lead to compatibility issues and disrupt their operations.\nTherefore, I think we should maintain the current name to ensure system stability.","commit_id":"c8fe1ef2287bf1872e8d0fff44ad4e5c2c3427e5"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f0d6ee80ab38509e186a1fff5bda70ddb7fe1bb0","unresolved":true,"context_lines":[{"line_number":2931,"context_line":""},{"line_number":2932,"context_line":"            if rc_str.startswith(\u0027E\u0027):"},{"line_number":2933,"context_line":"                errordesc \u003d rc_str"},{"line_number":2934,"context_line":"                rc \u003d 4"},{"line_number":2935,"context_line":"                if rc_str in retry_code:"},{"line_number":2936,"context_line":"                    LOG.info(\u0027_exec_eternus_cli, retry, \u0027"},{"line_number":2937,"context_line":"                             \u0027ip: %(ip)s, \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"0f7487ac_e8663e81","line":2934,"updated":"2024-11-04 21:51:07.000000000","message":"I think 4 means Failed (based on the value in the RETCODE_dic). It would be easier to understand the code if you used a meaningful variable instead of \"magic\" values like this. For example, you could add these to constants.py:\n\nRC_OK \u003d 0\nRC_FAILED \u003d 4\netc.","commit_id":"c8fe1ef2287bf1872e8d0fff44ad4e5c2c3427e5"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"e5fa3082aca61ed61f25990e4347bf2c2101211a","unresolved":false,"context_lines":[{"line_number":2931,"context_line":""},{"line_number":2932,"context_line":"            if rc_str.startswith(\u0027E\u0027):"},{"line_number":2933,"context_line":"                errordesc \u003d rc_str"},{"line_number":2934,"context_line":"                rc \u003d 4"},{"line_number":2935,"context_line":"                if rc_str in retry_code:"},{"line_number":2936,"context_line":"                    LOG.info(\u0027_exec_eternus_cli, retry, \u0027"},{"line_number":2937,"context_line":"                             \u0027ip: %(ip)s, \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"9b1eba23_ae9380da","line":2934,"in_reply_to":"0f7487ac_e8663e81","updated":"2024-12-03 05:18:45.000000000","message":"Done","commit_id":"c8fe1ef2287bf1872e8d0fff44ad4e5c2c3427e5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"93a1a72951915c15e6bdb49d3a0c1108968b5b57","unresolved":true,"context_lines":[{"line_number":59,"context_line":"    cfg.StrOpt(\u0027fujitsu_private_key_path\u0027,"},{"line_number":60,"context_line":"               default\u003d\u0027$state_path/eternus\u0027,"},{"line_number":61,"context_line":"               help\u003d\u0027Filename of private key for ETERNUS CLI. \u0027"},{"line_number":62,"context_line":"                    \u0027This option must be set when \u0027"},{"line_number":63,"context_line":"                    \u0027the fujitsu_passwordless is True.\u0027),"},{"line_number":64,"context_line":"    cfg.BoolOpt(\u0027fujitsu_use_cli_copy\u0027,"},{"line_number":65,"context_line":"                default\u003dFalse,"},{"line_number":66,"context_line":"                help\u003d\u0027If True use CLI command to create snapshot.\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ba3082b_211d6698","line":63,"range":{"start_line":62,"start_character":0,"end_line":63,"end_character":57},"updated":"2025-02-13 17:46:22.000000000","message":"Maybe you should enforce this in check_for_setup_error()?  That could be done as a follow-up.\n\nShould probably also check to make sure the file is readable.","commit_id":"25f942b9fad1b7fed995c9e67e60a19d719e5446"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b45fbfccec835b1a0001fd4f91fd0357f7648f5f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    cfg.StrOpt(\u0027fujitsu_private_key_path\u0027,"},{"line_number":60,"context_line":"               default\u003d\u0027$state_path/eternus\u0027,"},{"line_number":61,"context_line":"               help\u003d\u0027Filename of private key for ETERNUS CLI. \u0027"},{"line_number":62,"context_line":"                    \u0027This option must be set when \u0027"},{"line_number":63,"context_line":"                    \u0027the fujitsu_passwordless is True.\u0027),"},{"line_number":64,"context_line":"    cfg.BoolOpt(\u0027fujitsu_use_cli_copy\u0027,"},{"line_number":65,"context_line":"                default\u003dFalse,"},{"line_number":66,"context_line":"                help\u003d\u0027If True use CLI command to create snapshot.\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"83c476c8_d586030c","line":63,"range":{"start_line":62,"start_character":0,"end_line":63,"end_character":57},"in_reply_to":"77e7565d_f7c84ca2","updated":"2025-02-14 13:46:28.000000000","message":"OK, sounds good to me.  Left a comment for you on that patch.","commit_id":"25f942b9fad1b7fed995c9e67e60a19d719e5446"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"47b5eadc184ce43cb0b6f1113486388247a251f0","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    cfg.StrOpt(\u0027fujitsu_private_key_path\u0027,"},{"line_number":60,"context_line":"               default\u003d\u0027$state_path/eternus\u0027,"},{"line_number":61,"context_line":"               help\u003d\u0027Filename of private key for ETERNUS CLI. \u0027"},{"line_number":62,"context_line":"                    \u0027This option must be set when \u0027"},{"line_number":63,"context_line":"                    \u0027the fujitsu_passwordless is True.\u0027),"},{"line_number":64,"context_line":"    cfg.BoolOpt(\u0027fujitsu_use_cli_copy\u0027,"},{"line_number":65,"context_line":"                default\u003dFalse,"},{"line_number":66,"context_line":"                help\u003d\u0027If True use CLI command to create snapshot.\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"77e7565d_f7c84ca2","line":63,"range":{"start_line":62,"start_character":0,"end_line":63,"end_character":57},"in_reply_to":"9ba3082b_211d6698","updated":"2025-02-14 06:42:43.000000000","message":"We\u0027ve added the check for password and private key in do_setup() in the following patch:\nhttps://review.opendev.org/c/openstack/cinder/+/910495/13.\nWe\u0027ll move it to check_for_setup_error() and add a check for file readability when rebasing that patch.","commit_id":"25f942b9fad1b7fed995c9e67e60a19d719e5446"}],"doc/source/configuration/block-storage/drivers/fujitsu-eternus-dx-driver.rst":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f0d6ee80ab38509e186a1fff5bda70ddb7fe1bb0","unresolved":true,"context_lines":[{"line_number":102,"context_line":"#. Ensure LAN connection between cinder controller and MNT port of ETERNUS DX"},{"line_number":103,"context_line":"   and SAN connection between Compute nodes and CA ports of ETERNUS DX."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"#. (Optional) If you want to SSH to ETERNUS DX storage, generate the SSH key,"},{"line_number":106,"context_line":"   and upload the ``eternus.ietf`` file to the ETERNUS storage."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"   For information about how to set the public key, refer to the ETERNUS Web"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9f82dd61_0a9a26be","line":105,"range":{"start_line":105,"start_character":14,"end_line":105,"end_character":54},"updated":"2024-11-04 21:51:07.000000000","message":"I think this sentence is misleading because it suggests the *only* way to SSH to the Eternus storage is by using an SSH key. I think it would be clearer if it said something like, \"If you want to use a public key to SSH to the ETERNUS DX storage, ...\"\n\nYou could also preface the sentence by explaining there are two ways to access the storage via SSH: using a password or using a public key.","commit_id":"c8fe1ef2287bf1872e8d0fff44ad4e5c2c3427e5"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"e5fa3082aca61ed61f25990e4347bf2c2101211a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"#. Ensure LAN connection between cinder controller and MNT port of ETERNUS DX"},{"line_number":103,"context_line":"   and SAN connection between Compute nodes and CA ports of ETERNUS DX."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"#. (Optional) If you want to SSH to ETERNUS DX storage, generate the SSH key,"},{"line_number":106,"context_line":"   and upload the ``eternus.ietf`` file to the ETERNUS storage."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"   For information about how to set the public key, refer to the ETERNUS Web"}],"source_content_type":"text/x-rst","patch_set":7,"id":"c74097d7_f12ec5c6","line":105,"range":{"start_line":105,"start_character":14,"end_line":105,"end_character":54},"in_reply_to":"9f82dd61_0a9a26be","updated":"2024-12-03 05:18:45.000000000","message":"Done","commit_id":"c8fe1ef2287bf1872e8d0fff44ad4e5c2c3427e5"}],"releasenotes/notes/fujitsu-improve-cli-function-6cabf36ffc6d44d6.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b68ca052f121e06184e0b9a7fb5ab0411a00a0a2","unresolved":true,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    Added the method for connect to Eternus Storage using SSH key."},{"line_number":7,"context_line":"    The connection method can be selected by setting the value of parameter"},{"line_number":8,"context_line":"    ``fujitsu_passwordless``, which has a default value of ``True``."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    * When ``fujitsu_passwordless`` is set to ``True``, SSH key is used for"},{"line_number":11,"context_line":"      connecting to the storage. Additionally, ``fujitsu_private_key_path``"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"61abcdf4_28602398","line":8,"updated":"2024-08-12 23:02:59.000000000","message":"See my comment about this where the option is defined.","commit_id":"69488d722158c8bb19c9e0512ca4d81869b3f283"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"30d6fdfbd3daab12f697d4877c694ab9c3ebd087","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    Added the method for connect to Eternus Storage using SSH key."},{"line_number":7,"context_line":"    The connection method can be selected by setting the value of parameter"},{"line_number":8,"context_line":"    ``fujitsu_passwordless``, which has a default value of ``True``."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    * When ``fujitsu_passwordless`` is set to ``True``, SSH key is used for"},{"line_number":11,"context_line":"      connecting to the storage. Additionally, ``fujitsu_private_key_path``"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"81d58631_97df39b9","line":8,"in_reply_to":"61abcdf4_28602398","updated":"2024-08-26 02:27:00.000000000","message":"Done","commit_id":"69488d722158c8bb19c9e0512ca4d81869b3f283"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b68ca052f121e06184e0b9a7fb5ab0411a00a0a2","unresolved":true,"context_lines":[{"line_number":20,"context_line":"fixes:"},{"line_number":21,"context_line":"  - |"},{"line_number":22,"context_line":"    Fujitsu Eternus DX driver `bug #2048850"},{"line_number":23,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2048850\u003e`_: Fixed"},{"line_number":24,"context_line":"    Added parsing of error messages when CLI execution fails."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"e9f05f6a_a4ca1a85","line":23,"range":{"start_line":23,"start_character":56,"end_line":23,"end_character":61},"updated":"2024-08-12 23:02:59.000000000","message":"remove this word (since the sentence begins on the next line)","commit_id":"69488d722158c8bb19c9e0512ca4d81869b3f283"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"30d6fdfbd3daab12f697d4877c694ab9c3ebd087","unresolved":false,"context_lines":[{"line_number":20,"context_line":"fixes:"},{"line_number":21,"context_line":"  - |"},{"line_number":22,"context_line":"    Fujitsu Eternus DX driver `bug #2048850"},{"line_number":23,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2048850\u003e`_: Fixed"},{"line_number":24,"context_line":"    Added parsing of error messages when CLI execution fails."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"27afb5d7_6d746faa","line":23,"range":{"start_line":23,"start_character":56,"end_line":23,"end_character":61},"in_reply_to":"e9f05f6a_a4ca1a85","updated":"2024-08-26 02:27:00.000000000","message":"Done","commit_id":"69488d722158c8bb19c9e0512ca4d81869b3f283"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f0d6ee80ab38509e186a1fff5bda70ddb7fe1bb0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fujitsu Eternus DX driver: Added support SSH key."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"4c0cffb5_cdd8f7ac","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"updated":"2024-11-04 21:51:07.000000000","message":"This looks more like \"features\" note than an \"upgrade\" node.","commit_id":"c8fe1ef2287bf1872e8d0fff44ad4e5c2c3427e5"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"e5fa3082aca61ed61f25990e4347bf2c2101211a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fujitsu Eternus DX driver: Added support SSH key."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"86bebb7b_7b6ee540","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"in_reply_to":"4c0cffb5_cdd8f7ac","updated":"2024-12-03 05:18:45.000000000","message":"In Brian\u0027s commets, he suggested us use upgrade note.\n\"I\u0027m inclined to say make this False, but add an \"Upgrade\" section to the release note that advertises the new config opts.\"","commit_id":"c8fe1ef2287bf1872e8d0fff44ad4e5c2c3427e5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"93a1a72951915c15e6bdb49d3a0c1108968b5b57","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fujitsu Eternus DX driver: Added support SSH key."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"65c1e001_bf230f8f","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"updated":"2025-02-13 17:46:22.000000000","message":"I suggest changing this to \u0027features\u0027, and then add a different \u0027upgrade\u0027 section.\n\nThe upgrade section can mostly have the same text, but you need to emphasize very clearly that the operator must add ``fujitsu_passwordless \u003d False`` to the config file to get the legacy behavior.  You can say something about how this is a small inconvenience relative to being more secure.","commit_id":"25f942b9fad1b7fed995c9e67e60a19d719e5446"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"47b5eadc184ce43cb0b6f1113486388247a251f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fujitsu Eternus DX driver: Added support SSH key."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3cc5e0c1_ae29b1b2","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"in_reply_to":"65c1e001_bf230f8f","updated":"2025-02-14 06:42:43.000000000","message":"Done","commit_id":"25f942b9fad1b7fed995c9e67e60a19d719e5446"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"93a1a72951915c15e6bdb49d3a0c1108968b5b57","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fujitsu Eternus DX driver: Added support SSH key."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    Added the method for connect to Eternus Storage using SSH key."},{"line_number":7,"context_line":"    The connection method can be selected by setting the value of parameter"},{"line_number":8,"context_line":"    ``fujitsu_passwordless``, which has a default value of ``True``."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f8980ab_1514dd1b","line":6,"range":{"start_line":6,"start_character":25,"end_line":6,"end_character":32},"updated":"2025-02-13 17:46:22.000000000","message":"nit: connecting","commit_id":"25f942b9fad1b7fed995c9e67e60a19d719e5446"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"47b5eadc184ce43cb0b6f1113486388247a251f0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fujitsu Eternus DX driver: Added support SSH key."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    Added the method for connect to Eternus Storage using SSH key."},{"line_number":7,"context_line":"    The connection method can be selected by setting the value of parameter"},{"line_number":8,"context_line":"    ``fujitsu_passwordless``, which has a default value of ``True``."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"103f5b31_df18696d","line":6,"range":{"start_line":6,"start_character":25,"end_line":6,"end_character":32},"in_reply_to":"1f8980ab_1514dd1b","updated":"2025-02-14 06:42:43.000000000","message":"Done","commit_id":"25f942b9fad1b7fed995c9e67e60a19d719e5446"}]}