)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"bef9db311e016ab9845a7e7b88a0d3dc6147004d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fd78ddec_f4d6aa3c","updated":"2024-03-18 09:37:41.000000000","message":"recheck openstack-tox-pep8","commit_id":"dfae2f0ca2e8ffc788f4b0c9ba352a6f52ee1921"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"8afb209a8932ee7d4cdb17d710bc6aa6f465ba22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0fed2484_4340664c","updated":"2024-03-20 08:14:44.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"c42028fd55cf104c85b555a399d931fef607e9a8"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"8cbac5f3e13a5722ad1001ff1c07a13ec10e5e07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c4adae13_d9e34824","updated":"2024-03-20 01:44:42.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"c42028fd55cf104c85b555a399d931fef607e9a8"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"3f056b81e7c96ce8911beba6cda057de80904232","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ad691c2a_987d2b49","updated":"2024-05-22 05:49:51.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican","commit_id":"94d32b5a26290c0a42732121240911c02299e794"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"5a362c2eb8510120d68ea2c987d66179e5a279de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8f80b8c5_83d61661","updated":"2024-05-10 08:05:52.000000000","message":"recheck grenade","commit_id":"94d32b5a26290c0a42732121240911c02299e794"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"9e27d271372aeaa333d567e323d7d49dcb21f90b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b9a66ef6_c1f319b5","updated":"2024-05-14 09:40:54.000000000","message":"recheck tempest-integrated-storage","commit_id":"94d32b5a26290c0a42732121240911c02299e794"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"63fb9f3831ee51af885aa91d03d9607a670ddfee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2aa56864_53f3c72b","updated":"2024-05-10 08:02:55.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"94d32b5a26290c0a42732121240911c02299e794"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"14b11538d3c677033dc3184d86ff3344798966ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"40c9b08f_c21dc9f2","updated":"2024-07-29 21:19:24.000000000","message":"Although generally I prefer not to meddle into drivers, as long as they don\u0027t screw with Cinder core, this type of code looks like a mistake. If you have an explicit-close type of construct, it has to have something like finally: or a context manager (with:). So I cannot add +2 in a good conscience.","commit_id":"a99385e176fe388649d7c14aefaa67bb61381eac"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"5193f5688e879b16a00c017546434029062d3325","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8df5cefc_17ac1658","updated":"2024-06-14 09:31:56.000000000","message":"recheck tempest-slow-py3","commit_id":"a99385e176fe388649d7c14aefaa67bb61381eac"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"9f536e2f88f8fdc24240bf0084e7d6809c639994","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1d0dcf69_a45b5ce2","updated":"2025-01-03 01:23:32.000000000","message":"recheck devstack-plugin-nfs-tempest-full","commit_id":"5d8074bd3a61f0a0b18e6ff6d18621eca51f2e2d"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"c22fa6be24d1f11d898a6b56297bba6b39ae4728","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2463f6be_e8d93269","updated":"2024-12-17 01:25:05.000000000","message":"recheck devstack-plugin-nfs-tempest-full","commit_id":"5d8074bd3a61f0a0b18e6ff6d18621eca51f2e2d"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"656d7d4c5e0d68635643460a229643966163d82e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e2e392b8_6d49c4ac","updated":"2025-01-02 09:14:38.000000000","message":"recheck devstack-plugin-nfs-tempest-full","commit_id":"5d8074bd3a61f0a0b18e6ff6d18621eca51f2e2d"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"1a52a7412db8064c03c52c13974661d72174f31f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"29df9cdd_5e3aa818","updated":"2024-12-13 07:34:59.000000000","message":"recheck grenade-skip-level-always","commit_id":"5d8074bd3a61f0a0b18e6ff6d18621eca51f2e2d"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"68af34661e54b8a83295b963f85595730e103bba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ec8a4853_78c98363","updated":"2025-01-03 05:45:58.000000000","message":"recheck tempest-slow-py3","commit_id":"5d8074bd3a61f0a0b18e6ff6d18621eca51f2e2d"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"c6440dbba927f53a6de63b2be1bed66d88f02ed2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"42cc4f7c_d5c6e672","updated":"2025-01-02 09:17:10.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"5d8074bd3a61f0a0b18e6ff6d18621eca51f2e2d"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"a02ee22c837e11633be4de52a342d1268788b9ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"583a17cb_8a2c017f","updated":"2025-01-06 08:41:08.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"5d8074bd3a61f0a0b18e6ff6d18621eca51f2e2d"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"a8c224d9ac7e20765b0f653bd155cd661727c796","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7531281c_c2d69ad1","updated":"2024-12-13 01:21:52.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"5d8074bd3a61f0a0b18e6ff6d18621eca51f2e2d"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"ff31639a83667a960065a71ac79edaf8bdbd6e29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"824d396a_f1b08268","updated":"2025-01-07 05:31:55.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"5d8074bd3a61f0a0b18e6ff6d18621eca51f2e2d"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"7b7ea515d0cbb41b7e1309d6f4d2121a522c18fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8f64a9e8_7ecdce20","updated":"2025-01-06 05:42:10.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"5d8074bd3a61f0a0b18e6ff6d18621eca51f2e2d"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"84c6dc7ef5a8ca7fefd2a3d582cbe2c88d288b9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"904ec37f_4ebe6045","updated":"2025-01-06 01:39:22.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"5d8074bd3a61f0a0b18e6ff6d18621eca51f2e2d"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"b46c468298cfce263916b880ba6dfeac79579f7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"95e77fe4_51cc3c8e","updated":"2025-01-03 01:23:43.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"5d8074bd3a61f0a0b18e6ff6d18621eca51f2e2d"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"d2bcd9fd7982afc42e2ecddafb76edf976542658","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9d4a2555_9128fcb7","updated":"2025-01-03 05:45:31.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"5d8074bd3a61f0a0b18e6ff6d18621eca51f2e2d"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"16c2c72fc385b9d7ca3cb144137fa94f886616cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a50e152b_531e63f7","updated":"2024-12-17 01:24:49.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"5d8074bd3a61f0a0b18e6ff6d18621eca51f2e2d"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"9dd6c39f02cab81fbad80c88415cc860d3812ea5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c4aacaac_17f28729","updated":"2025-01-07 01:21:41.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"5d8074bd3a61f0a0b18e6ff6d18621eca51f2e2d"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"450a0c2eeb86648c75650782d1a957a0f6318aaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2d50edee_7c8d26fd","updated":"2025-01-02 09:14:59.000000000","message":"run-Fujitsu ETERNUS CI\u0027","commit_id":"5d8074bd3a61f0a0b18e6ff6d18621eca51f2e2d"},{"author":{"_account_id":37834,"name":"Masahiko Eba","display_name":"Eba","email":"eba.masahiko@fujitsu.com","username":"m-eba"},"change_message_id":"d260b7ab3fbbbde96e7b4bc1e12940c796f01bf1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3448d1a4_4aed5d96","updated":"2025-03-24 07:55:08.000000000","message":"recheck","commit_id":"8c6b1ff8e3810dae74deda1e43be5d17fbec31fd"},{"author":{"_account_id":37834,"name":"Masahiko Eba","display_name":"Eba","email":"eba.masahiko@fujitsu.com","username":"m-eba"},"change_message_id":"d7156c957fd873d6efc7c2d24da03fd79466241c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ae87e118_e0909b50","updated":"2025-03-24 01:54:11.000000000","message":"recheck","commit_id":"8c6b1ff8e3810dae74deda1e43be5d17fbec31fd"},{"author":{"_account_id":37834,"name":"Masahiko Eba","display_name":"Eba","email":"eba.masahiko@fujitsu.com","username":"m-eba"},"change_message_id":"b7f52243425a7571be6c0196b5fe6906688c676c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6fec3bf5_4ff8e060","updated":"2025-03-25 02:50:36.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"8c6b1ff8e3810dae74deda1e43be5d17fbec31fd"},{"author":{"_account_id":37834,"name":"Masahiko Eba","display_name":"Eba","email":"eba.masahiko@fujitsu.com","username":"m-eba"},"change_message_id":"241fa99f6b5eb9bfc0076a209dc1a747dea2c8af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"61a644e3_57cc38ab","updated":"2025-03-26 07:11:47.000000000","message":"recheck tempest-slow-py3","commit_id":"248562b2036934973b23177e0653aa0004c1e12d"}],"cinder/volume/drivers/fujitsu/eternus_dx/eternus_dx_common.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"14b11538d3c677033dc3184d86ff3344798966ff","unresolved":true,"context_lines":[{"line_number":2983,"context_line":"                                        **param_dict):"},{"line_number":2984,"context_line":"        filename \u003d self.filename"},{"line_number":2985,"context_line":"        conn \u003d self._get_eternus_connection(filename)"},{"line_number":2986,"context_line":"        rc, retdata \u003d conn.InvokeMethod("},{"line_number":2987,"context_line":"            classname,"},{"line_number":2988,"context_line":"            instanceNameList,"},{"line_number":2989,"context_line":"            **param_dict)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f41e11b_57564edb","line":2986,"updated":"2024-07-29 21:19:24.000000000","message":"What does happen if InvokeMethod itself throws? Looks like a solid leak of conn.","commit_id":"a99385e176fe388649d7c14aefaa67bb61381eac"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"57b618fa6481ddbadd8db33cf654376d50d5e553","unresolved":false,"context_lines":[{"line_number":2983,"context_line":"                                        **param_dict):"},{"line_number":2984,"context_line":"        filename \u003d self.filename"},{"line_number":2985,"context_line":"        conn \u003d self._get_eternus_connection(filename)"},{"line_number":2986,"context_line":"        rc, retdata \u003d conn.InvokeMethod("},{"line_number":2987,"context_line":"            classname,"},{"line_number":2988,"context_line":"            instanceNameList,"},{"line_number":2989,"context_line":"            **param_dict)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bc6a3cb5_909fa937","line":2986,"in_reply_to":"7f41e11b_57564edb","updated":"2024-08-01 09:14:11.000000000","message":"Thanks for your review. In our testing, even in cases where the version of pywbem is lower than 1.2.0(which means the conn does not have close function) or the InvokeMethod itself throws, the connection to storage will automatically disconnect. Therefore, it will not actually case the leak of conn.\nBut your comment is helpful in enhancing the consistency of our code, so we will consider modifying it in future versions.","commit_id":"a99385e176fe388649d7c14aefaa67bb61381eac"}]}